Change in openvpn[release/2.7]: Fix 1-byte buffer overrun on NTLMv2 proxy responses.
A message that is not in the archive (sent off-list or not yet received): gerrit.1781716678000.Iac54e6772b2c26a09227fd638d24d6e2aa35cec6@gerrit.openvpn.net
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1713?usp=email
to review the following change.
Change subject: Fix 1-byte buffer overrun on NTLMv2 proxy responses.
......................................................................
Fix 1-byte buffer overrun on NTLMv2 proxy responses.
An attacker controlling an HTTP proxy (or performing MITM on the plaintext pre-TLS proxy connection) can trigger a single 0-byte overrun to a buffer on the stack by sending a crafted NTLM Type 2 challenge response.
The effects of this depend on memory layout, but could possibly lead to a crashing OpenVPN client.
CVE: 2026-11771
---
M src/openvpn/ntlm.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/13/1713/1
src/openvpn/ntlm.c +1 -1
@@ -317,7 +317,7 @@if ((flags &0x00800000 ) ==0x00800000 ) { tib_len = buf2[0x28 ];/* Get Target Information block size */ -if (tib_len +0x1c +16 >sizeof (ntlmv2_response)) +if (tib_len +0x1c +16 >=sizeof (ntlmv2_response)) {msg (M_WARN ,"NTLM: target information buffer too long for response (len=%d)" , tib_len);return NULL ;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1713?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: release/2.7
Gerrit-Change-Id: Iac54e6772b2c26a09227fd638d24d6e2aa35cec6
Gerrit-Change-Number: 1713
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1713?usp=email
to look at the new patch set (#2).
Change subject: Fix 1-byte buffer overrun on NTLMv2 proxy responses.
......................................................................
Fix 1-byte buffer overrun on NTLMv2 proxy responses.
An attacker controlling an HTTP proxy (or performing MITM on the plaintext pre-TLS proxy connection) can trigger a single 0-byte overrun to a buffer on the stack by sending a crafted NTLM Type 2 challenge response.
The effects of this depend on memory layout, but could possibly lead to a crashing OpenVPN client.
CVE: 2026-11771
Github: OpenVPN/openvpn-private-issues#116
---
M src/openvpn/ntlm.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/13/1713/2
src/openvpn/ntlm.c +1 -1
@@ -317,7 +317,7 @@if ((flags &0x00800000 ) ==0x00800000 ) { tib_len = buf2[0x28 ];/* Get Target Information block size */ -if (tib_len +0x1c +16 >sizeof (ntlmv2_response)) +if (tib_len +0x1c +16 >=sizeof (ntlmv2_response)) {msg (M_WARN ,"NTLM: target information buffer too long for response (len=%d)" , tib_len);return NULL ;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1713?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: release/2.7
Gerrit-Change-Id: Iac54e6772b2c26a09227fd638d24d6e2aa35cec6
Gerrit-Change-Number: 1713
Gerrit-PatchSet: 2
Gerrit-Owner: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Attention is currently required from: cron2.
plaisthos has posted comments on this change by cron2. ( http://gerrit.openvpn.net/c/openvpn/+/1713?usp=email )
Change subject: Fix 1-byte buffer overrun on NTLMv2 proxy responses.
......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Commit Message:
http://gerrit.openvpn.net/c/openvpn/+/1713/comment/a1104ba8_b5c0316f?usp=email :
PS2, Line 10: plaintext pre-TLS proxy connection) can trigger a single 0-byte A 0 byte overrun sounds like not an overrun at all. The subject also says 1 byte.
File src/openvpn/ntlm.c:
http://gerrit.openvpn.net/c/openvpn/+/1713/comment/9eaf74ec_648ccee9?usp=email :
PS2, Line 214: uint8_t *ntlmv2_blob = ntlmv2_response + 16; /* inside ntlmv2_response, length: 128 */
So this pointer aliases ntlmv2_response. The length: 128 is weird and probably incorrect or meant as some maximum that normally occurs? I don't know. Since we already removed this in master, I think we can ignore it.
http://gerrit.openvpn.net/c/openvpn/+/1713/comment/775331cc_3f049b8e?usp=email :
PS2, Line 348: ntlmv2_blob[0x1c + tib_len] = 0;
Here we then have the off by one.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1713?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: release/2.7
Gerrit-Change-Id: Iac54e6772b2c26a09227fd638d24d6e2aa35cec6
Gerrit-Change-Number: 1713
Gerrit-PatchSet: 2
Gerrit-Owner: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Comment-Date: Thu, 18 Jun 2026 12:21:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Attention is currently required from: cron2.
plaisthos has posted comments on this change by cron2. ( http://gerrit.openvpn.net/c/openvpn/+/1713?usp=email )
Change subject: Fix 1-byte buffer overrun on NTLMv2 proxy responses.
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
This is quite convoluted code but the fix looks good.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1713?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: release/2.7
Gerrit-Change-Id: Iac54e6772b2c26a09227fd638d24d6e2aa35cec6
Gerrit-Change-Number: 1713
Gerrit-PatchSet: 2
Gerrit-Owner: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Comment-Date: Thu, 18 Jun 2026 12:21:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
PATCH v2 1/1 Fix 1-byte buffer overrun on NTLMv2 proxy responses.
In reply to a message not in the archiveAn attacker controlling an HTTP proxy (or performing MITM on the plaintext pre-TLS proxy connection) can trigger a single 0-byte overrun to a buffer on the stack by sending a crafted NTLM Type 2 challenge response.
The effects of this depend on memory layout, but could possibly lead to a crashing OpenVPN client.
CVE: 2026-11771
Github: OpenVPN/openvpn-private-issues#116
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1713
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to release/2.7.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1713
This mail reflects revision 2 of this Change.
Acked-by according to Gerrit (reflected above):
Arne Schwabe <[email protected]>
src/openvpn/ntlm.c +1 -1
@@ -317,7 +317,7 @@if ((flags &0x00800000 ) ==0x00800000 ) { tib_len = buf2[0x28 ];/* Get Target Information block size */ -if (tib_len +0x1c +16 >sizeof (ntlmv2_response)) +if (tib_len +0x1c +16 >=sizeof (ntlmv2_response)) {msg (M_WARN ,"NTLM: target information buffer too long for response (len=%d)" , tib_len);return NULL ;
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH applied] Re: Fix 1-byte buffer overrun on NTLMv2 proxy responses.
Patch has been applied to the release/2.7 and release/2.6 branch (bugfix).
The NTLM code in release/2.6 is different enough (NTLMv1 not removed yet) that it a straightforward "git cherry-pick" does not work, but the offending line is there and fixed just the same (">" -> ">=").
commit 04309bfe0313c09edd02c29945893b9d7e2ca920 (release/2.7) commit e1bf48ab80a22598000a7ab83d3688f07d139cc7 (release/2.6)
Author: Gert Doering Date: Thu Jun 18 14:37:24 2026 +0200
Fix 1-byte buffer overrun on NTLMv2 proxy responses.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1713
Message-Id: <[email protected]>
URL: https://www.mail-archive.com/[email protected]/msg37218.html
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1713?usp=email )
Change subject: Fix 1-byte buffer overrun on NTLMv2 proxy responses.
......................................................................
Fix 1-byte buffer overrun on NTLMv2 proxy responses.
An attacker controlling an HTTP proxy (or performing MITM on the plaintext pre-TLS proxy connection) can trigger a single 0-byte overrun to a buffer on the stack by sending a crafted NTLM Type 2 challenge response.
The effects of this depend on memory layout, but could possibly lead to a crashing OpenVPN client.
CVE: 2026-11771
Github: OpenVPN/openvpn-private-issues#116
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1713
Message-Id: <[email protected]>
URL: https://www.mail-archive.com/[email protected]/msg37218.html
---
M src/openvpn/ntlm.c
1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/ntlm.c +1 -1
@@ -317,7 +317,7 @@if ((flags &0x00800000 ) ==0x00800000 ) { tib_len = buf2[0x28 ];/* Get Target Information block size */ -if (tib_len +0x1c +16 >sizeof (ntlmv2_response)) +if (tib_len +0x1c +16 >=sizeof (ntlmv2_response)) {msg (M_WARN ,"NTLM: target information buffer too long for response (len=%d)" , tib_len);return NULL ;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1713?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: release/2.7
Gerrit-Change-Id: Iac54e6772b2c26a09227fd638d24d6e2aa35cec6
Gerrit-Change-Number: 1713
Gerrit-PatchSet: 3
Gerrit-Owner: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1713?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: Fix 1-byte buffer overrun on NTLMv2 proxy responses.
......................................................................
Fix 1-byte buffer overrun on NTLMv2 proxy responses.
An attacker controlling an HTTP proxy (or performing MITM on the plaintext pre-TLS proxy connection) can trigger a single 0-byte overrun to a buffer on the stack by sending a crafted NTLM Type 2 challenge response.
The effects of this depend on memory layout, but could possibly lead to a crashing OpenVPN client.
CVE: 2026-11771
Github: OpenVPN/openvpn-private-issues#116
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1713
Message-Id: <[email protected]>
URL: https://www.mail-archive.com/[email protected]/msg37218.html
---
M src/openvpn/ntlm.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/13/1713/3
src/openvpn/ntlm.c +1 -1
@@ -317,7 +317,7 @@if ((flags &0x00800000 ) ==0x00800000 ) { tib_len = buf2[0x28 ];/* Get Target Information block size */ -if (tib_len +0x1c +16 >sizeof (ntlmv2_response)) +if (tib_len +0x1c +16 >=sizeof (ntlmv2_response)) {msg (M_WARN ,"NTLM: target information buffer too long for response (len=%d)" , tib_len);return NULL ;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1713?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: release/2.7
Gerrit-Change-Id: Iac54e6772b2c26a09227fd638d24d6e2aa35cec6
Gerrit-Change-Number: 1713
Gerrit-PatchSet: 3
Gerrit-Owner: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel