Skip to contentSkip to conversation

ofono: update to 1.28

PATCH In review Oleksandr Kravchuk 4 participants 7 messages Mar 30, 2019 – Apr 1, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ofono: update to 1.28

Deleted patch has been mainstremaed.

Changelog:
ver 1.28:
- Fix issue with SIM initialization and Gemalto modems.

ver 1.27:
- Add support for handling SIMCom based SIM800 modems.
- Add support for SIM lock state with xmm7xxx modems.
- Add support for coexistence feature with xmm7xxx modems.

ver 1.26:
- Fix issue with AT callback handler and GPRS.
- Fix issue with handling EUTRAN SMS only states.
- Fix issue with handling MBIM strings on big endian.
- Fix issue with missing char and SMS national language.
- Fix issue with unsolicited notifications of +CGAUTH/+CGDCONT.
- Add support for setting "none" authentication method.
- Add support for SMS and phonebook with xmm7xxx modems.
- Add support for voice features and Gemalto modems.
- Add support for Bengali and Gujrati SMS alphabets.
- Add support for 8 additional languages for GSM 7 bit
- Add support for using internal Embedded Linux library.

---
 meta/recipes-connectivity/ofono/ofono.inc     |  7 ++---
 .../ofono/ofono/use-python3.patch             | 27 -------------------
 meta/recipes-connectivity/ofono/ofono_1.25.bb |  9 -------
 meta/recipes-connectivity/ofono/ofono_1.28.bb |  8 ++++++
 4 files changed, 12 insertions(+), 39 deletions(-)
 delete mode 100644 meta/recipes-connectivity/ofono/ofono/use-python3.patch
 delete mode 100644 meta/recipes-connectivity/ofono/ofono_1.25.bb
 create mode 100644 meta/recipes-connectivity/ofono/ofono_1.28.bb
meta/recipes-connectivity/ofono/ofono.inc +4 -3
index 0472414b19..37772121f8 100644
@@ -1,13 +1,14 @@
 HOMEPAGE = "http://www.ofono.org"
-SUMMARY  = "open source telephony"
-DESCRIPTION = "oFono is a stack for mobile telephony devices on Linux. oFono supports speaking to telephony devices through specific drivers, or with generic AT commands."
+SUMMARY  = "Open Source Telephony"
+DESCRIPTION = "oFono is a stack for mobile telephony devices on Linux. \
+oFono supports speaking to telephony devices through specific drivers, or with generic AT commands."
 LICENSE  = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
                     file://src/ofono.h;beginline=1;endline=20;md5=3ce17d5978ef3445def265b98899c2ee"
 
 inherit autotools pkgconfig update-rc.d systemd bluetooth gobject-introspection-data
 
-DEPENDS  = "dbus glib-2.0 udev mobile-broadband-provider-info"
+DEPENDS  = "dbus glib-2.0 udev mobile-broadband-provider-info ell"
 
 INITSCRIPT_NAME = "ofono"
 INITSCRIPT_PARAMS = "defaults 22"
meta/recipes-connectivity/ofono/ofono/use-python3.patch deleted +0 -27
deleted file mode 100644
index 7b84075257..0000000000
@@ -1,27 +0,0 @@
-set-ddr should use Python3 like all the other tests.
-
-Upstream-Status: Submitted
-Signed-off-by: Ross Burton <[email protected]>
-
-From 17b69cd1da4c5c5f732acb38ca1602446c567ee7 Mon Sep 17 00:00:00 2001
-From: Ross Burton <[email protected]>
-Date: Mon, 29 Jan 2018 11:31:25 +0000
-Subject: [PATCH] test/setddr: use Python 3
-
-All the other tests use Python 3, so this should to.
----
- test/set-ddr | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/test/set-ddr b/test/set-ddr
-index 5d061b95..33631f31 100755
---- a/test/set-ddr
-+++ b/test/set-ddr
-@@ -1,4 +1,4 @@
--#!/usr/bin/python
-+#!/usr/bin/python3
- 
- import sys
- import dbus
--- 
-2.11.0
meta/recipes-connectivity/ofono/ofono_1.25.bb deleted +0 -9
deleted file mode 100644
index 3688b9d2fc..0000000000
@@ -1,9 +0,0 @@
-require ofono.inc
-
-SRC_URI  = "\
-  ${KERNELORG_MIRROR}/linux/network/${BPN}/${BP}.tar.xz \
-  file://ofono \
-  file://use-python3.patch \
-"
-SRC_URI[md5sum] = "31450cabdd8dbbf3f808ea2f2f066863"
-SRC_URI[sha256sum] = "eb011fcd3080e93f3a56f96be60350b6595a8b5f36b61646312ba41b0bcb0d75"
meta/recipes-connectivity/ofono/ofono_1.28.bb new file +8 -0
new file mode 100644
index 0000000000..130a902322
@@ -0,0 +1,8 @@
+require ofono.inc
+
+SRC_URI  = "\
+    ${KERNELORG_MIRROR}/linux/network/${BPN}/${BP}.tar.xz \
+    file://ofono \
+"
+SRC_URI[md5sum] = "3a5406565b552b16602610619b034967"
+SRC_URI[sha256sum] = "93bb2cedef54f897dd5200e22b072a6e38b5d9b44be57eebbbe8d513f0beb0e4"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 63 lines · Oleksandr Kravchuk

Deleted patch has been mainstremaed.

Changelog:
ver 1.28:
- Fix issue with SIM initialization and Gemalto modems.

ver 1.27:
- Add support for handling SIMCom based SIM800 modems.
- Add support for SIM lock state with xmm7xxx modems.
- Add support for coexistence feature with xmm7xxx modems.

ver 1.26:
- Fix issue with AT callback handler and GPRS.
- Fix issue with handling EUTRAN SMS only states.
- Fix issue with handling MBIM strings on big endian.
- Fix issue with missing char and SMS national language.
- Fix issue with unsolicited notifications of +CGAUTH/+CGDCONT.
- Add support for setting "none" authentication method.
- Add support for SMS and phonebook with xmm7xxx modems.
- Add support for voice features and Gemalto modems.
- Add support for Bengali and Gujrati SMS alphabets.
- Add support for 8 additional languages for GSM 7 bit
- Add support for using internal Embedded Linux library.

Quoted 1 line
---
 meta/recipes-connectivity/ofono/ofono.inc     |  7 ++---
 .../ofono/ofono/use-python3.patch             | 27 ---------------
----
 meta/recipes-connectivity/ofono/ofono_1.25.bb |  9 -------
 meta/recipes-connectivity/ofono/ofono_1.28.bb |  8 ++++++
 4 files changed, 12 insertions(+), 39 deletions(-)
 delete mode 100644 meta/recipes-connectivity/ofono/ofono/use-
python3.patch
 delete mode 100644 meta/recipes-connectivity/ofono/ofono_1.25.bb
 create mode 100644 meta/recipes-connectivity/ofono/ofono_1.28.bb
meta/recipes-connectivity/ofono/ofono.inc +0 -2
index 0472414b19..37772121f8 100644
@@ -1,13 +1,14 @@
 HOMEPAGE = "http://www.ofono.org"
-SUMMARY  = "open source telephony"
-DESCRIPTION = "oFono is a stack for mobile telephony devices on

Linux. oFono supports speaking to telephony devices through specific drivers, or with generic AT commands."

meta/recipes-connectivity/ofono/ofono.inc +2 -0
+SUMMARY  = "Open Source Telephony"
+DESCRIPTION = "oFono is a stack for mobile telephony devices on

Linux. \
+oFono supports speaking to telephony devices through specific drivers, or with generic AT commands."
LICENSE = "GPLv2"
LIC_FILES_CHKSUM =

"file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
                     file://src/ofono.h;beginline=1;endline=20;md5=3c

e17d5978ef3445def265b98899c2ee"

inherit autotools pkgconfig update-rc.d systemd bluetooth gobject-
introspection-data

meta/recipes-connectivity/ofono/ofono.inc line 11

Quoted 2 lines
meta/recipes-connectivity/ofono/ofono.inc +1 -1
-DEPENDS  = "dbus glib-2.0 udev mobile-broadband-provider-info"
+DEPENDS  = "dbus glib-2.0 udev mobile-broadband-provider-info ell"

ERROR: Nothing PROVIDES 'ell' (but /media/build1/poky/meta/recipes- connectivity/ofono/ofono_1.28.bb DEPENDS on or otherwise requires it)

OE-Core doesn't contain ell?

The new dependency isn't mentioned in the changelog?

Cheers,

Richard

#2 lore raw
Quoted 69 lines · Richard Purdie
Quoted 62 lines · Oleksandr Kravchuk

Deleted patch has been mainstremaed.

Changelog:
ver 1.28:
- Fix issue with SIM initialization and Gemalto modems.

ver 1.27:
- Add support for handling SIMCom based SIM800 modems.
- Add support for SIM lock state with xmm7xxx modems.
- Add support for coexistence feature with xmm7xxx modems.

ver 1.26:
- Fix issue with AT callback handler and GPRS.
- Fix issue with handling EUTRAN SMS only states.
- Fix issue with handling MBIM strings on big endian.
- Fix issue with missing char and SMS national language.
- Fix issue with unsolicited notifications of +CGAUTH/+CGDCONT.
- Add support for setting "none" authentication method.
- Add support for SMS and phonebook with xmm7xxx modems.
- Add support for voice features and Gemalto modems.
- Add support for Bengali and Gujrati SMS alphabets.
- Add support for 8 additional languages for GSM 7 bit
- Add support for using internal Embedded Linux library.

---
 meta/recipes-connectivity/ofono/ofono.inc     |  7 ++---
 .../ofono/ofono/use-python3.patch             | 27 ---------------
----
 meta/recipes-connectivity/ofono/ofono_1.25.bb |  9 -------
 meta/recipes-connectivity/ofono/ofono_1.28.bb |  8 ++++++
 4 files changed, 12 insertions(+), 39 deletions(-)
 delete mode 100644 meta/recipes-connectivity/ofono/ofono/use-
python3.patch
 delete mode 100644 meta/recipes-connectivity/ofono/ofono_1.25.bb
 create mode 100644 meta/recipes-connectivity/ofono/ofono_1.28.bb
meta/recipes-connectivity/ofono/ofono.inc +0 -2
index 0472414b19..37772121f8 100644
@@ -1,13 +1,14 @@
 HOMEPAGE = "http://www.ofono.org"
-SUMMARY  = "open source telephony"
-DESCRIPTION = "oFono is a stack for mobile telephony devices on

Linux. oFono supports speaking to telephony devices through specific drivers, or with generic AT commands."

meta/recipes-connectivity/ofono/ofono.inc +2 -0
+SUMMARY  = "Open Source Telephony"
+DESCRIPTION = "oFono is a stack for mobile telephony devices on

Linux. \
+oFono supports speaking to telephony devices through specific drivers, or with generic AT commands."
LICENSE = "GPLv2"
LIC_FILES_CHKSUM =

"file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
                     file://src/ofono.h;beginline=1;endline=20;md5=3c

e17d5978ef3445def265b98899c2ee"

inherit autotools pkgconfig update-rc.d systemd bluetooth gobject-
introspection-data

meta/recipes-connectivity/ofono/ofono.inc line 11

Quoted 2 lines
meta/recipes-connectivity/ofono/ofono.inc +1 -1
-DEPENDS  = "dbus glib-2.0 udev mobile-broadband-provider-info"
+DEPENDS  = "dbus glib-2.0 udev mobile-broadband-provider-info ell"

ERROR: Nothing PROVIDES 'ell' (but /media/build1/poky/meta/recipes- connectivity/ofono/ofono_1.28.bb DEPENDS on or otherwise requires it)

Quoted 7 lines

OE-Core doesn't contain ell?

The new dependency isn't mentioned in the changelog?

Cheers,

Richard

Right, it's part of meta-openembedded. I did not think about this.

What does the project usually do in this kind of situations, ports dependency to meta-oe or refuses package bump?

#3 lore raw

It does not look like a hard dependency.

configure.ac has:
AC_ARG_ENABLE([external_ell], AC_HELP_STRING([--enable-external-ell],

So you can make it a PACKAGECONFIG option, disabled by default. It's fine to have oe-core packages conditionally depend on things in meta-oe, if the condition defaults to disable.

Alex

Quoted 89 lines · Oleksandr Kravchuk
Quoted 69 lines · Richard Purdie
Quoted 62 lines · Oleksandr Kravchuk

Deleted patch has been mainstremaed.

Changelog:
ver 1.28:
- Fix issue with SIM initialization and Gemalto modems.

ver 1.27:
- Add support for handling SIMCom based SIM800 modems.
- Add support for SIM lock state with xmm7xxx modems.
- Add support for coexistence feature with xmm7xxx modems.

ver 1.26:
- Fix issue with AT callback handler and GPRS.
- Fix issue with handling EUTRAN SMS only states.
- Fix issue with handling MBIM strings on big endian.
- Fix issue with missing char and SMS national language.
- Fix issue with unsolicited notifications of +CGAUTH/+CGDCONT.
- Add support for setting "none" authentication method.
- Add support for SMS and phonebook with xmm7xxx modems.
- Add support for voice features and Gemalto modems.
- Add support for Bengali and Gujrati SMS alphabets.
- Add support for 8 additional languages for GSM 7 bit
- Add support for using internal Embedded Linux library.

---
 meta/recipes-connectivity/ofono/ofono.inc     |  7 ++---
 .../ofono/ofono/use-python3.patch             | 27 ---------------
----
 meta/recipes-connectivity/ofono/ofono_1.25.bb |  9 -------
 meta/recipes-connectivity/ofono/ofono_1.28.bb |  8 ++++++
 4 files changed, 12 insertions(+), 39 deletions(-)
 delete mode 100644 meta/recipes-connectivity/ofono/ofono/use-
python3.patch
 delete mode 100644 meta/recipes-connectivity/ofono/ofono_1.25.bb
 create mode 100644 meta/recipes-connectivity/ofono/ofono_1.28.bb
meta/recipes-connectivity/ofono/ofono.inc +0 -2
index 0472414b19..37772121f8 100644
@@ -1,13 +1,14 @@
 HOMEPAGE = "http://www.ofono.org"
-SUMMARY  = "open source telephony"
-DESCRIPTION = "oFono is a stack for mobile telephony devices on

Linux. oFono supports speaking to telephony devices through specific drivers, or with generic AT commands."

meta/recipes-connectivity/ofono/ofono.inc +2 -0
+SUMMARY  = "Open Source Telephony"
+DESCRIPTION = "oFono is a stack for mobile telephony devices on

Linux. \
+oFono supports speaking to telephony devices through specific drivers, or with generic AT commands."
LICENSE = "GPLv2"
LIC_FILES_CHKSUM =

"file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
                     file://src/ofono.h;beginline=1;endline=20;md5=3c

e17d5978ef3445def265b98899c2ee"

inherit autotools pkgconfig update-rc.d systemd bluetooth gobject-
introspection-data

meta/recipes-connectivity/ofono/ofono.inc line 11

Quoted 2 lines
meta/recipes-connectivity/ofono/ofono.inc +1 -1
-DEPENDS  = "dbus glib-2.0 udev mobile-broadband-provider-info"
+DEPENDS  = "dbus glib-2.0 udev mobile-broadband-provider-info ell"

ERROR: Nothing PROVIDES 'ell' (but /media/build1/poky/meta/recipes- connectivity/ofono/ofono_1.28.bb DEPENDS on or otherwise requires it)

Quoted 7 lines

OE-Core doesn't contain ell?

The new dependency isn't mentioned in the changelog?

Cheers,

Richard

Right, it's part of meta-openembedded. I did not think about this.

What does the project usually do in this kind of situations, ports dependency to meta-oe or refuses package bump?

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw
Quoted 8 lines · Alexander Kanavin

It does not look like a hard dependency.

configure.ac has:
AC_ARG_ENABLE([external_ell], AC_HELP_STRING([--enable-external-ell],

So you can make it a PACKAGECONFIG option, disabled by default. It's fine to have oe-core packages conditionally depend on things in meta-oe, if the condition defaults to disable.

That's not right: that's the toggle between "a system-provided ell" or "you have checked out ell into the source tree".

https://git.kernel.org/pub/scm/network/ofono/ofono.git/commit/?id=8452a7f34907472c5e21c334673afd10df409eef

We'll need to bring ell.bb into oe-core too.

Ross

#5 lore raw
Quoted 9 lines · Ross
Quoted 8 lines · Alexander Kanavin

It does not look like a hard dependency.

configure.ac has:
AC_ARG_ENABLE([external_ell], AC_HELP_STRING([--enable-external-ell],

So you can make it a PACKAGECONFIG option, disabled by default. It's fine to have oe-core packages conditionally depend on things in meta-oe, if the condition defaults to disable.

Quoted 8 lines

That's not right: that's the toggle between "a system-provided ell" or "you have checked out ell into the source tree".

https://git.kernel.org/pub/scm/network/ofono/ofono.git/commit/?id=8452a7f34907472c5e21c334673afd10df409eef

We'll need to bring ell.bb into oe-core too.

Ross

Alright, gents. I am rather new to the project, so just instruct me how to proceed here.

Ofono is a great piece of widely-used software that would be nice to have up to date.

#6 lore raw

You need to add ell recipe to oe-core, add yourself or the ofono maintainer to maintainers.inc for it, and make a patch to remove ell from meta-oe.

ell removal patch goes to oe-devel list.

Also you can clean up the ell recipe and update ell as well to latest version at the same time.

Alex

Quoted 26 lines · Oleksandr Kravchuk
Quoted 9 lines · Ross
Quoted 8 lines · Alexander Kanavin

It does not look like a hard dependency.

configure.ac has:
AC_ARG_ENABLE([external_ell], AC_HELP_STRING([--enable-external-ell],

So you can make it a PACKAGECONFIG option, disabled by default. It's fine to have oe-core packages conditionally depend on things in meta-oe, if the condition defaults to disable.

Quoted 8 lines

That's not right: that's the toggle between "a system-provided ell" or "you have checked out ell into the source tree".

https://git.kernel.org/pub/scm/network/ofono/ofono.git/commit/?id=8452a7f34907472c5e21c334673afd10df409eef

We'll need to bring ell.bb into oe-core too.

Ross

Alright, gents. I am rather new to the project, so just instruct me how to proceed here.

Ofono is a great piece of widely-used software that would be nice to have up to date.