crypto/armv8: update meson build
Subsystems (2)
PATCH 1/2 crypto/armv8: update meson build
With pkg-config support available within AArch64crypto library, meson option 'armv8_crypto_dir' can be removed. PKG_CONFIG_PATH environment variable should be set appropriately to use the crypto library.
Refer [1] for build instructions.
[1]
https://doc.dpdk.org/guides/cryptodevs/armv8.html
--- drivers/crypto/armv8/meson.build | 19 ++++--------------- meson_options.txt | 2 -- 2 files changed, 4 insertions(+), 17 deletions(-)
drivers/crypto/armv8/meson.build +4 -15
@@ -1,24 +1,13 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019 Arm Limited -path = get_option('armv8_crypto_dir') -if path == '' +dep = dependency('libAArch64crypto', required: false) +if not dep.found() build = false - reason = 'missing dependency, "armv8_crypto"' + reason = 'missing dependency, "libAArch64crypto"' subdir_done() endif -inc_dir = path - -lib = cc.find_library('libAArch64crypto', dirs: [path], required: false) -if not lib.found() - build = false - reason = 'missing dependency, "AArch64crypto"' - subdir_done() -else - ext_deps += lib - includes += include_directories(inc_dir) -endif - +ext_deps += dep deps += ['bus_vdev'] sources = files('rte_armv8_pmd.c', 'rte_armv8_pmd_ops.c')
meson_options.txt +0 -2
@@ -1,7 +1,5 @@ # Please keep these options sorted alphabetically. -option('armv8_crypto_dir', type: 'string', value: '', - description: 'path to the armv8_crypto library installation directory') option('disable_drivers', type: 'string', value: '', description: 'Comma-separated list of drivers to explicitly disable.') option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',
Signature · 1 line
2.17.1
PATCH 2/2 doc: update build guide for armv8 crypto PMD
Remove build steps about using meson option armv8_crypto_dir.
Add build steps about using pkg-config.
--- doc/guides/cryptodevs/armv8.rst | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
doc/guides/cryptodevs/armv8.rst +8 -2
@@ -37,11 +37,17 @@ To build DPDK with this virtual crypto PMD, the user is required to: make -* Build DPDK with meson option ``-Darmv8_crypto_dir=<path_to_AArch64cryptolib>``: +* Add path to `libAArch64crypto.pc` in `PKG_CONFIG_PATH` environment variable: .. code-block:: console - meson -Darmv8_crypto_dir=<path_to_AArch64cryptolib> build + export PKG_CONFIG_PATH=<path_to_AArch64cryptolib>/pkgconfig/:$PKG_CONFIG_PATH + +* Build DPDK: + +.. code-block:: console + + meson build ninja -C build The corresponding device can be created only if the following features
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH 2/2] doc: update build guide for armv8 crypto PMD
Quoted 52 lines
-----Original Message-----
From: Dharmik Thakkar <[email protected]>
Sent: Thursday, November 5, 2020 11:33 PM
To: Ruifeng Wang <[email protected]>
Cc: [email protected]; nd <[email protected]>; Dharmik Thakkar <[email protected]>
Subject: [PATCH 2/2] doc: update build guide for armv8 crypto PMDRemove build steps about using meson option
armv8_crypto_dir.Add build steps about using pkg-config.
Suggested-by Thomas Monjalon <[email protected]>Signed-off-by Dharmik Thakkar <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>--- doc/guides/cryptodevs/armv8.rst | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/doc/guides/cryptodevs/armv8.rstindexf0f30fe0003a..8963f66a206c100644doc/guides/cryptodevs/armv8.rst +0
-0@@ -37,11 +37,17 @@ To build DPDK with this virtual crypto PMD, the user isrequired to:
make
-* Build DPDK with meson option ``- Darmv8_crypto_dir=<path_to_AArch64cryptolib>``:
+* Add path tolibAArch64crypto.pcinPKG_CONFIG_PATHenvironment variable:.. code-block:: console
doc/guides/cryptodevs/armv8.rst +2
-1- meson -Darmv8_crypto_dir=<path_to_AArch64cryptolib> build + export +PKG_CONFIG_PATH=<path_to_AArch64cryptolib>/pkgconfig/:$PKG_CONFI
G_PATHdoc/guides/cryptodevs/armv8.rst +6
-1+ +* Build DPDK: + +.. code-block:: console + + meson build ninja -C build The corresponding device can be created only if the following features --
Quoted 1 line
2.17.1
Quoted 10 lines · Dharmik Thakkar
With pkg-config support available within AArch64crypto library, meson option '
armv8_crypto_dir' can be removed.PKG_CONFIG_PATHenvironment variable should be set appropriately to use the crypto library.Refer [1] for build instructions.
Quoted 8 lines
Suggested-by Thomas Monjalon <[email protected]>Signed-off-by Dharmik Thakkar <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>--- drivers/crypto/armv8/meson.build | 19 ++++--------------- meson_options.txt | 2 -- 2 files changed, 4 insertions(+), 17 deletions(-)
This simplification is great to see, thanks.
05/11/2020 17:11, Bruce Richardson:
Quoted 11 lines · Dharmik Thakkar
Quoted 10 lines
With pkg-config support available within AArch64crypto library, meson option '
armv8_crypto_dir' can be removed.PKG_CONFIG_PATHenvironment variable should be set appropriately to use the crypto library.Refer [1] for build instructions.
Quoted 7 lines
Quoted 4 lines
Suggested-by Thomas Monjalon <[email protected]>Signed-off-by Dharmik Thakkar <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>This simplification is great to see, thanks.
Acked-by Bruce Richardson <[email protected]>
Series applied, thanks
Next meson options to be removed please:
- flexran_sdk
- lib_musdk_dir
13/11/2020 10:29, Thomas Monjalon:
Quoted 16 lines
05/11/2020 17:11, Bruce Richardson:
Quoted 15 lines · Dharmik Thakkar
Quoted 14 lines
With pkg-config support available within AArch64crypto library, meson option '
armv8_crypto_dir' can be removed.PKG_CONFIG_PATHenvironment variable should be set appropriately to use the crypto library.Refer [1] for build instructions.
[1]
https://doc.dpdk.org/guides/cryptodevs/armv8.htmlSuggested-by Thomas Monjalon <[email protected]>Signed-off-by Dharmik Thakkar <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>
Quoted 5 lines
Quoted 3 lines
This simplification is great to see, thanks.
Acked-by Bruce Richardson <[email protected]>Series applied, thanks
Note: doc and code changes should be atomic,
that's why they are squashed when merging.
Quoted 74 lines
-----Original Message-----
From: Dharmik Thakkar <[email protected]>
Sent: Thursday, November 5, 2020 11:33 PM
To: Ruifeng Wang <[email protected]>; Bruce Richardson <[email protected]>
Cc: [email protected]; nd <[email protected]>; Dharmik Thakkar <[email protected]>
Subject: [PATCH 1/2]crypto/armv8: update meson buildWith pkg-config support available within AArch64crypto library, meson option '
armv8_crypto_dir' can be removed.PKG_CONFIG_PATHenvironment variable should be set appropriately to use the crypto library.Refer [1] for build instructions.
[1]
https://doc.dpdk.org/guides/cryptodevs/armv8.htmlSuggested-by Thomas Monjalon <[email protected]>Signed-off-by Dharmik Thakkar <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>--- drivers/crypto/armv8/meson.build | 19 ++++--------------- meson_options.txt | 2 -- 2 files changed, 4 insertions(+), 17 deletions(-)drivers/crypto/armv8/meson.build +4
-14@@ -1,24 +1,13 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019 Arm Limited -path = get_option('armv8_crypto_dir') -if path == '' +dep = dependency('libAArch64crypto', required: false) if not +dep.found() build = false - reason = 'missing dependency, "armv8_crypto"' + reason = 'missing dependency, "libAArch64crypto"' subdir_done() endif -inc_dir = path - -lib = cc.find_library('libAArch64crypto', dirs: [path], required: false) -if not lib.found() - build = false - reason = 'missing dependency, "AArch64crypto"' - subdir_done() -else - ext_deps += lib - includes += include_directories(inc_dir) -endif - +ext_deps += dep deps += ['bus_vdev'] sources = files('rte_armv8_pmd.c', 'rte_armv8_pmd_ops.c') diff --git
a/meson_options.txtb/meson_options.txtindex9bf18ab6b1c9..e384e6dbb29e100644meson_options.txt +0
-3@@ -1,7 +1,5 @@ # Please keep these options sorted alphabetically. -option('armv8_crypto_dir', type: 'string', value: '', - description: 'path to the armv8_crypto library installation directory') option('disable_drivers', type: 'string', value: '', description: 'Comma-separated list of drivers to explicitly disable.') option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>', --
Quoted 1 line
2.17.1