hw/arm/virt: ARM_VIRT must select ARM_GIC
PATCH 1/1 hw/arm/virt: ARM_VIRT must select ARM_GIC
The removal of the selection of A15MPCORE from ARM_VIRT also removed what A15MPCORE selects, ARM_GIC. We still need ARM_GIC.
--- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)
hw/arm/Kconfig +1 -0
@@ -6,6 +6,7 @@ config ARM_VIRT imply VFIO_PLATFORM imply VFIO_XGMAC imply TPM_TIS_SYSBUS + select ARM_GIC select ACPI select ARM_SMMUV3 select GPIO_KEY
Signature · 1 line
2.26.2
----- Original Message -----
Quoted 30 lines
From: "Andrew Jones" <[email protected]>
To: [email protected], [email protected]
Cc: "peter maydell" <[email protected]>, [email protected], "Miroslav Rezanina" <[email protected]>
Sent: Wednesday, November 11, 2020 3:34:40 PM
Subject: [PATCH] hw/arm/virt:ARM_VIRTmust selectARM_GICThe removal of the selection of A15MPCORE from
ARM_VIRTalso removed what A15MPCORE selects,ARM_GIC. We still needARM_GIC.Fixes bec3c97e0cf9 ("hw/arm/virt: Remove dependency on Cortex-A15 MPCoreperipherals")
Reported-by Miroslav Rezanina <[email protected]>Signed-off-by Andrew Jones <[email protected]>--- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)hw/arm/Kconfig +1
-1@@ -6,6 +6,7 @@ config ARM_VIRT imply VFIO_PLATFORM imply VFIO_XGMAC imply TPM_TIS_SYSBUS + select ARM_GIC select ACPI select ARM_SMMUV3 select GPIO_KEY --
Quoted 3 lines
2.26.2
Problems with missing dependencies solved by this patch.
Signature · 2 lines
Miroslav Rezanina Software Engineer - Virtualization Team Maintainer
Quoted 8 lines · Miroslav Rezanina
----- Original Message -----
Quoted 6 lines
From: "Andrew Jones" <[email protected]>
To: [email protected], [email protected]
Cc: "peter maydell" <[email protected]>, [email protected], "Miroslav Rezanina" <[email protected]>
Sent: Wednesday, November 11, 2020 3:34:40 PM
Subject: [PATCH] hw/arm/virt:ARM_VIRTmust selectARM_GIC
Quoted 7 lines
Quoted 2 lines
The removal of the selection of A15MPCORE from
ARM_VIRTalso removed what A15MPCORE selects,ARM_GIC. We still needARM_GIC.Problems with missing dependencies solved by this patch.
Reviewed-by Miroslav Rezanina <[email protected]>
This is the second of this kind of "missing select" bug I've seen recently. I don't suppose there's some kind of testing we could add to 'make check' that automatically catches them?
thanks
-- PMM
Quoted 13 lines · Peter Maydell
Quoted 12 lines · Miroslav Rezanina
----- Original Message -----
Quoted 8 lines
From: "Andrew Jones" <[email protected]>
To: [email protected], [email protected]
Cc: "peter maydell" <[email protected]>, [email protected], "Miroslav Rezanina" <[email protected]>
Sent: Wednesday, November 11, 2020 3:34:40 PM
Subject: [PATCH] hw/arm/virt:ARM_VIRTmust selectARM_GICThe removal of the selection of A15MPCORE from
ARM_VIRTalso removed what A15MPCORE selects,ARM_GIC. We still needARM_GIC.
Quoted 8 lines
Quoted 3 lines
Problems with missing dependencies solved by this patch.
Reviewed-by Miroslav Rezanina <[email protected]>This is the second of this kind of "missing select" bug I've seen recently. I don't suppose there's some kind of testing we could add to 'make check' that automatically catches them?
Miroslav is finding them because the RHEL build of QEMU is more selective than upstream as to what gets pulled in. Effort keeps going into making upstream more configurable, but it's not quite there yet for RHEL's purposes. I'm not sure how best to test something like this upstream. I guess it would require the flexible configuration support we don't yet have.
Thanks,
drew
----- Original Message -----
Quoted 32 lines
From: "Andrew Jones" <[email protected]>
To: "Peter Maydell" <[email protected]>
Cc: "Miroslav Rezanina" <[email protected]>, "QEMU Developers" <[email protected]>, "qemu-arm" <[email protected]>, "Philippe Mathieu-Daudé" <[email protected]>
Sent: Wednesday, November 11, 2020 6:39:32 PM
Subject: Re: [PATCH] hw/arm/virt:ARM_VIRTmust selectARM_GICQuoted 15 lines · Peter Maydell
Quoted 13 lines · Miroslav Rezanina
----- Original Message -----
Quoted 9 lines
From: "Andrew Jones" <[email protected]>
To: [email protected], [email protected]
Cc: "peter maydell" <[email protected]>, [email protected], "Miroslav Rezanina" <[email protected]>
Sent: Wednesday, November 11, 2020 3:34:40 PM
Subject: [PATCH] hw/arm/virt:ARM_VIRTmust selectARM_GICThe removal of the selection of A15MPCORE from
ARM_VIRTalso removed what A15MPCORE selects,ARM_GIC. We still needARM_GIC.Quoted 8 lines
Quoted 3 lines
Problems with missing dependencies solved by this patch.
Reviewed-by Miroslav Rezanina <[email protected]>This is the second of this kind of "missing select" bug I've seen recently. I don't suppose there's some kind of testing we could add to 'make check' that automatically catches them?
Quoted 7 lines
Miroslav is finding them because the RHEL build of QEMU is more selective than upstream as to what gets pulled in. Effort keeps going into making upstream more configurable, but it's not quite there yet for RHEL's purposes. I'm not sure how best to test something like this upstream. I guess it would require the flexible configuration support we don't yet have.
We use --without-default-devices and then add only supported devices - this allow us to find this kind of errors. To prevent them by test we would need complete matrix possible of device configurations (or just usable combinations). Not always is broken build wrong - it can be caused by unusable configuration.
In this case, we have correct dependency - CONFIG_ARM_GIC_KVM requires CONFIG_KVM and CONFIG_ARM_GIC. In RC1 commit bec3c97e0cf9 (hw/arm/virt: Remove dependency on Cortex-A15 MPCore peripherals) removed indirect CONFIG_ARM_GIC from CONFIG_ARM_VIRT. So anyone using CONFIG_ARM_GIC_KVM with CONFIG_ARM_VIRT now gets build error.
Question here is: Is okay to use CONFIG_ARM_GIC_KVM with CONFIG_ARM_VIRT without explicit CONFIG_ARM_GIC? I can imagine both answers:
1) yes - CONFIG_ARM_VIRT implicate presence of CONFIG_ARM_GIC so no need to add it explicitly
2) no - If you want to use CONFIG_ARM_GIC_KVM you have to always add CONFIG_ARM_GIC explicitly too
I'm little bit confused now - why KConfig uses depends instead of select? If using option without dependent one is not possible shouldn't be logical to just get it?
Mirek
Quoted 3 lines
Thanks,
drew
Signature · 2 lines
Miroslav Rezanina Software Engineer - Virtualization Team Maintainer
Quoted 6 lines · Andrew Jones
The removal of the selection of A15MPCORE from
ARM_VIRTalso removed what A15MPCORE selects,ARM_GIC. We still needARM_GIC.Fixes bec3c97e0cf9 ("hw/arm/virt: Remove dependency on Cortex-A15 MPCore peripherals")Reported-by Miroslav Rezanina <[email protected]>Signed-off-by Andrew Jones <[email protected]>
Quoted 17 lines
--- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)hw/arm/Kconfig +1
-0@@ -6,6 +6,7 @@ config ARM_VIRT imply VFIO_PLATFORM imply VFIO_XGMAC imply TPM_TIS_SYSBUS + select ARM_GIC select ACPI select ARM_SMMUV3 select GPIO_KEY
Peter Maydell
AppliedQuoted 7 lines · Andrew Jones
The removal of the selection of A15MPCORE from
ARM_VIRTalso removed what A15MPCORE selects,ARM_GIC. We still needARM_GIC.Fixes bec3c97e0cf9 ("hw/arm/virt: Remove dependency on Cortex-A15 MPCore peripherals")Reported-by Miroslav Rezanina <[email protected]>Signed-off-by Andrew Jones <[email protected]>
Applied to target-arm.next, thanks.
-- PMM