gfs2: Only do glock put in gfs2_create_inode for free inodes
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 gfs2: Only do glock put in gfs2_create_inode for free inodes
Hi,
Before this patch, the error path of function gfs2_create_inode would always calls gfs2_glock_put for the inode glock. That's good for inodes that are free. But after they've been added to the vfs inodes, errors will cause the inode to be evicted, and the evict will do the glock put for us. If we do a glock put again, we can try to free the glock while there are still references to it, e.g. revokes pending for the transaction that created it.
This patch adds a check: if (free_vfs_inode) before the put, thus solving the problem.
Signed-off-by Bob Peterson <[email protected]>
--- fs/gfs2/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/gfs2/inode.c +2 -1
@@ -780,7 +780,8 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry, fail_free_inode:if (ip->i_gl) {glock_clear_object (ip->i_gl, ip); -gfs2_glock_put (ip->i_gl); +if (free_vfs_inode)/* else evict will do the put for us */ +gfs2_glock_put (ip->i_gl); }gfs2_rs_delete (ip,NULL );gfs2_qa_put (ip);