i2c: isch: Remove unnecessary acpi.h include

PATCH In review [email protected] 5 participants 10 messages Mar 25, 2019 – Apr 3, 2019

Subsystems (2)

I2C subsystem host drivers I2C/smbus controller drivers for pc

lore

Share & tools

lore

[email protected]

author

2019-03-25 18:36 UTC #0 lore raw

PATCH 1/1 i2c: isch: Remove unnecessary acpi.h include

From: Bjorn Helgaas <[email protected]>

54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
convert i2c-isch to platform_device") removed the use of acpi_check_region() but not the include.

Remove the now-unnecessary include of <linux/acpi.h>. No functional change intended.

Signed-off-by Bjorn Helgaas <[email protected]>

---
 drivers/i2c/busses/i2c-isch.c | 1 -
 1 file changed, 1 deletion(-)

drivers/i2c/busses/i2c-isch.c +0 -1

index 5c754bf659e2..f64c1d72f73f 100644
@@ -30,7 +30,6 @@
 #include <linux/ioport.h>
 #include <linux/i2c.h>
 #include <linux/io.h>
-#include <linux/acpi.h>
 
 /* SCH SMBus address offsets */
 #define SMBHSTCNT	(0 + sch_smba)

Signature · 1 line

2.21.0.392.gf8f6787159e-goog

Jean Delvare

Reviewed-by on v1 1/1

2019-03-31 08:36 UTC #1 lore raw

Quoted 20 lines · On Mon, 25 Mar 2019 13:36:52 -0500, [email protected] wrote:

From: Bjorn Helgaas <[email protected]>
54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
convert i2c-isch to platform_device") removed the use of acpi_check_region() but not the include.
Remove the now-unnecessary include of <linux/acpi.h>. No functional change intended.
Signed-off-by Bjorn Helgaas <[email protected]>
---
 drivers/i2c/busses/i2c-isch.c | 1 -
 1 file changed, 1 deletion(-)
drivers/i2c/busses/i2c-isch.c +0 -0
index 5c754bf659e2..f64c1d72f73f 100644

drivers/i2c/busses/i2c-isch.c line 35

Quoted 7 lines

drivers/i2c/busses/i2c-isch.c +0 -1

@@ -30,7 +30,6 @@
 #include <linux/ioport.h>
 #include <linux/i2c.h>
 #include <linux/io.h>
-#include <linux/acpi.h>
 
 /* SCH SMBus address offsets */
 #define SMBHSTCNT	(0 + sch_smba)

Reviewed-by Jean Delvare <[email protected]>

(I would add a Fixes tag but maybe that's just me.)

Thanks,

Signature · 2 lines

Jean Delvare
SUSE L3 Support

Mukesh Ojha

Reviewed-by on v1 1/1

2019-03-31 09:31 UTC #2 lore raw

In reply to [email protected]

Quoted 11 lines · On 3/26/2019 12:06 AM, [email protected] wrote:

From: Bjorn Helgaas <[email protected]>
54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
convert i2c-isch to platform_device") removed the use of acpi_check_region() but not the include.
Remove the now-unnecessary include of <linux/acpi.h>. No functional change intended.
Signed-off-by Bjorn Helgaas <[email protected]>

Reviewed-by Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

Quoted 16 lines

---
  drivers/i2c/busses/i2c-isch.c | 1 -
  1 file changed, 1 deletion(-)

drivers/i2c/busses/i2c-isch.c +0 -1

index 5c754bf659e2..f64c1d72f73f 100644
@@ -30,7 +30,6 @@
  #include <linux/ioport.h>
  #include <linux/i2c.h>
  #include <linux/io.h>
-#include <linux/acpi.h>
 
  /* SCH SMBus address offsets */
  #define SMBHSTCNT	(0 + sch_smba)

Bjorn Helgaas

Reviewed-by Jean Delvare Reviewed-by Mukesh Ojha on v1 1/1

2019-04-01 13:50 UTC #3 lore raw

In reply to [email protected]

Quoted 8 lines · On Mon, Mar 25, 2019 at 1:37 PM <[email protected]> wrote:

From: Bjorn Helgaas <[email protected]>
54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
convert i2c-isch to platform_device") removed the use of acpi_check_region() but not the include.

Quoted 4 lines

Remove the now-unnecessary include of <linux/acpi.h>. No functional change intended.
Signed-off-by Bjorn Helgaas <[email protected]>

Added

Fixes fd46a0064af1 ("i2c: convert i2c-isch to platform_device")

Reviewed-by Jean Delvare <[email protected]>

Reviewed-by Mukesh Ojha <[email protected]>

on my local branch.

Jean, would you like me to repost this with the updates? I assume you will merge this (just based on get_maintainer.pl)?

Quoted 19 lines

---
 drivers/i2c/busses/i2c-isch.c | 1 -
 1 file changed, 1 deletion(-)

drivers/i2c/busses/i2c-isch.c +0 -2

index 5c754bf659e2..f64c1d72f73f 100644
@@ -30,7 +30,6 @@
 #include <linux/ioport.h>
 #include <linux/i2c.h>
 #include <linux/io.h>
-#include <linux/acpi.h>
 
 /* SCH SMBus address offsets */
 #define SMBHSTCNT      (0 + sch_smba)
--

2.21.0.392.gf8f6787159e-goog

Wolfram Sang

2019-04-01 14:08 UTC #4 lore raw

Quoted 15 lines

Quoted 8 lines
From: Bjorn Helgaas <[email protected]>
54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
convert i2c-isch to platform_device") removed the use of acpi_check_region() but not the include.
Quoted 4 lines
Remove the now-unnecessary include of <linux/acpi.h>. No functional change intended.
Signed-off-by Bjorn Helgaas <[email protected]>
Added

Quoted 8 lines

Fixes fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
Reviewed-by Jean Delvare <[email protected]>
Reviewed-by Mukesh Ojha <[email protected]>
on my local branch.
Jean, would you like me to repost this with the updates? I assume you will merge this (just based on get_maintainer.pl)?

I will apply it, now that it has Jean's Rev-by. I assume this is for-next material despite the Fixes tag?

Bjorn Helgaas

Reviewed-by Jean Delvare Reviewed-by Mukesh Ojha

2019-04-01 19:37 UTC #5 lore raw

Quoted 20 lines · Wolfram Sang

Quoted 20 lines
Quoted 9 lines
From: Bjorn Helgaas <[email protected]>
54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
convert i2c-isch to platform_device") removed the use of acpi_check_region() but not the include.
Quoted 4 lines
Remove the now-unnecessary include of <linux/acpi.h>. No functional change intended.
Signed-off-by Bjorn Helgaas <[email protected]>
Added
Fixes fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
Reviewed-by Jean Delvare <[email protected]>
Reviewed-by Mukesh Ojha <[email protected]>

Quoted 7 lines

Quoted 4 lines
on my local branch.
Jean, would you like me to repost this with the updates? I assume you will merge this (just based on get_maintainer.pl)?
I will apply it, now that it has Jean's Rev-by. I assume this is for-next material despite the Fixes tag?

Definitely for-next material, not for the current release. Jean suggested the Fixes tag, I think since it's related to a specific commit and could be backported together with that commit.

Should there be a MAINTAINERS update to clarify who applies patches to drivers/i2c/busses/i2c-isch.c? Right now, get_maintainers.pl doesn't mention you (Wolfram).

Patch with tags attached in case it's useful to you (sorry, I'm saddled with gmail right now and can't include it inline).

From 36fbdab89f5b8aa2d3616bd289e2c695fd3c0f9b Mon Sep 17 00:00:00 2001
From: Bjorn Helgaas <[email protected]>
Date: Tue, 30 Oct 2018 14:12:36 -0500
Subject: [PATCH] i2c: isch: Remove unnecessary acpi.h include

Remove the now-unnecessary include of <linux/acpi.h>. No functional change intended.

Fixes fd46a0064af1 ("i2c: convert i2c-isch to platform_device")

Signed-off-by Bjorn Helgaas <[email protected]>

Reviewed-by Jean Delvare <[email protected]>

Reviewed-by Mukesh Ojha <[email protected]>

---
 drivers/i2c/busses/i2c-isch.c | 1 -
 1 file changed, 1 deletion(-)

drivers/i2c/busses/i2c-isch.c +0 -1

index 5c754bf659e2..f64c1d72f73f 100644
@@ -30,7 +30,6 @@
 #include <linux/ioport.h>
 #include <linux/i2c.h>
 #include <linux/io.h>
-#include <linux/acpi.h>
 
 /* SCH SMBus address offsets */
 #define SMBHSTCNT	(0 + sch_smba)

Signature · 1 line

2.21.0.392.gf8f6787159e-goog

Wolfram Sang

2019-04-01 19:45 UTC #6 lore raw

Quoted 10 lines

Quoted 6 lines
Quoted 3 lines
Jean, would you like me to repost this with the updates? I assume you will merge this (just based on get_maintainer.pl)?
I will apply it, now that it has Jean's Rev-by. I assume this is for-next material despite the Fixes tag?
Definitely for-next material, not for the current release. Jean suggested the Fixes tag, I think since it's related to a specific commit and could be backported together with that commit.

Makes sense.

Quoted 3 lines

Should there be a MAINTAINERS update to clarify who applies patches to drivers/i2c/busses/i2c-isch.c? Right now, get_maintainers.pl doesn't mention you (Wolfram).

I have set the i2c/busses directory to 'Odd Fixes' in MAINTAINERS. I don't want to be mentioned for specific drivers. I am eagerly looking for driver maintainers to spread reponsibility. Maybe my tree could be added to Jean's maintainer entry, but not sure what that is worth...

Quoted 2 lines

Patch with tags attached in case it's useful to you (sorry, I'm saddled with gmail right now and can't include it inline).

No worries. Patchwork keeps it all for me.

Wolfram Sang

2019-04-03 20:57 UTC #7 lore raw

In reply to Bjorn Helgaas

Quoted 50 lines · Bjorn Helgaas

Quoted 20 lines · Wolfram Sang
Quoted 20 lines
Quoted 9 lines
From: Bjorn Helgaas <[email protected]>
54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
convert i2c-isch to platform_device") removed the use of acpi_check_region() but not the include.
Quoted 4 lines
Remove the now-unnecessary include of <linux/acpi.h>. No functional change intended.
Signed-off-by Bjorn Helgaas <[email protected]>
Added
Fixes fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
Reviewed-by Jean Delvare <[email protected]>
Reviewed-by Mukesh Ojha <[email protected]>
Quoted 7 lines
Quoted 4 lines
on my local branch.
Jean, would you like me to repost this with the updates? I assume you will merge this (just based on get_maintainer.pl)?
I will apply it, now that it has Jean's Rev-by. I assume this is for-next material despite the Fixes tag?
Definitely for-next material, not for the current release. Jean suggested the Fixes tag, I think since it's related to a specific commit and could be backported together with that commit.
Should there be a MAINTAINERS update to clarify who applies patches to drivers/i2c/busses/i2c-isch.c? Right now, get_maintainers.pl doesn't mention you (Wolfram).
Patch with tags attached in case it's useful to you (sorry, I'm saddled with gmail right now and can't include it inline).
From 36fbdab89f5b8aa2d3616bd289e2c695fd3c0f9b Mon Sep 17 00:00:00 2001
From: Bjorn Helgaas <[email protected]>
Date: Tue, 30 Oct 2018 14:12:36 -0500
Subject: [PATCH] i2c: isch: Remove unnecessary acpi.h include
54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
convert i2c-isch to platform_device") removed the use of acpi_check_region() but not the include.

Quoted 7 lines

Remove the now-unnecessary include of <linux/acpi.h>. No functional change intended.
Fixes fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
Signed-off-by Bjorn Helgaas <[email protected]>
Reviewed-by Jean Delvare <[email protected]>
Reviewed-by Mukesh Ojha <[email protected]>

Fixed this checkpatch error:

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit fd46a0064af1 ("i2c: convert i2c-isch to platform_device")'

and applied to for-next, thanks!

Bjorn Helgaas

2019-04-03 22:27 UTC #8 lore raw

Quoted 55 lines · Wolfram Sang

Quoted 53 lines · Bjorn Helgaas
Quoted 20 lines · Wolfram Sang
Quoted 20 lines
Quoted 9 lines
From: Bjorn Helgaas <[email protected]>
54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
convert i2c-isch to platform_device") removed the use of acpi_check_region() but not the include.
Quoted 4 lines
Remove the now-unnecessary include of <linux/acpi.h>. No functional change intended.
Signed-off-by Bjorn Helgaas <[email protected]>
Added
Fixes fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
Reviewed-by Jean Delvare <[email protected]>
Reviewed-by Mukesh Ojha <[email protected]>
Quoted 7 lines
Quoted 4 lines
on my local branch.
Jean, would you like me to repost this with the updates? I assume you will merge this (just based on get_maintainer.pl)?
I will apply it, now that it has Jean's Rev-by. I assume this is for-next material despite the Fixes tag?
Definitely for-next material, not for the current release. Jean suggested the Fixes tag, I think since it's related to a specific commit and could be backported together with that commit.
Should there be a MAINTAINERS update to clarify who applies patches to drivers/i2c/busses/i2c-isch.c? Right now, get_maintainers.pl doesn't mention you (Wolfram).
Patch with tags attached in case it's useful to you (sorry, I'm saddled with gmail right now and can't include it inline).
From 36fbdab89f5b8aa2d3616bd289e2c695fd3c0f9b Mon Sep 17 00:00:00 2001
From: Bjorn Helgaas <[email protected]>
Date: Tue, 30 Oct 2018 14:12:36 -0500
Subject: [PATCH] i2c: isch: Remove unnecessary acpi.h include
54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
convert i2c-isch to platform_device") removed the use of acpi_check_region() but not the include.
Remove the now-unnecessary include of <linux/acpi.h>. No functional change intended.

Quoted 8 lines

Quoted 4 lines
Fixes fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
Signed-off-by Bjorn Helgaas <[email protected]>
Reviewed-by Jean Delvare <[email protected]>
Reviewed-by Mukesh Ojha <[email protected]>
Fixed this checkpatch error:
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit fd46a0064af1 ("i2c: convert i2c-isch to platform_device")'

Thanks, I didn't even know about that requirement for the word "commit"! I assume this only applies in the text, not in the "Fixes:" tag.

Jean Delvare

2019-04-01 15:07 UTC #9 lore raw

In reply to Bjorn Helgaas

Hi Bjorn,

Quoted 16 lines · Bjorn Helgaas

Quoted 8 lines · On Mon, Mar 25, 2019 at 1:37 PM <[email protected]> wrote:
From: Bjorn Helgaas <[email protected]>
54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
convert i2c-isch to platform_device") removed the use of acpi_check_region() but not the include.
Quoted 4 lines
Remove the now-unnecessary include of <linux/acpi.h>. No functional change intended.
Signed-off-by Bjorn Helgaas <[email protected]>
Added

Quoted 8 lines

Fixes fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
Reviewed-by Jean Delvare <[email protected]>
Reviewed-by Mukesh Ojha <[email protected]>
on my local branch.
Jean, would you like me to repost this with the updates? I assume you will merge this (just based on get_maintainer.pl)?

No, Wolfram prefers to pick all the i2c patches into his own branch, I'm only giving my Reviewed-by. So your question is for him.

Thanks,

Signature · 2 lines

Jean Delvare
SUSE L3 Support