Char: isicom, check kmalloc retval
PATCH 7/7 Char: isicom, check kmalloc retval
isicom, check kmalloc retval
Value returned from kamlloc may be NULL, we should check if ENOMEM occured.
Signed-off-by Jiri Slaby <[email protected]>
---
commit a026bdacd388dd774b6e6bd50dcb12adb10115f1
tree f729251fccf62c68dfc4e126574f2e1ee898a35a
parent b298d99f4a779fb54b0035f0f870d5247b13b269
author Jiri Slaby <[email protected]> Thu, 19 Oct 2006 19:47:29 +0200 committer Jiri Slaby <[email protected]> Thu, 19 Oct 2006 19:47:29 +0200
drivers/char/isicom.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
drivers/char/isicom.c +5 -0
@@ -1708,6 +1708,11 @@ static int __devinit load_firmware(struc } data =kmalloc (word_count *2 ,GFP_KERNEL ); +if (data ==NULL ) { +dev_err (&pdev->dev,"Card%d, firmware upload " +"failed, not enough memory\n" , index +1 ); + goto errrelfw; + }inw (base);insw (base, data, word_count);InterruptTheCard (base);
Ar Iau, 2006-10-19 am 22:26 +0200, ysgrifennodd Jiri Slaby:
Quoted 5 lines
isicom, check kmalloc retval
Value returned from kamlloc may be NULL, we should check if ENOMEM occured.
Signed-off-by Jiri Slaby <[email protected]>
Acked-by Alan Cox <[email protected]>