Skip to contentSkip to conversation

ARM: OMAP2+: Remove unused MUSB initialization code

PATCH New Laurent Pinchart 2 participants 4 messages Nov 10, 2016

Subsystems (4)
Arm (32-bit) Arm sub-architectures OMAP2+ support OMAP USB support
lore
Share & tools
lore

Laurent Pinchart

author
#0 lore raw

PATCH 1/1 ARM: OMAP2+: Remove unused MUSB initialization code

With the removal of board-ldp.c and board-rx51.c, the last users of the MUSB initialization board code are gone. Remove it.

Signed-off-by Laurent Pinchart <[email protected]>
---
 arch/arm/mach-omap2/Makefile   |   1 -
 arch/arm/mach-omap2/usb-musb.c | 106 -----------------------------------------
 arch/arm/mach-omap2/usb.h      |   1 -
 3 files changed, 108 deletions(-)
 delete mode 100644 arch/arm/mach-omap2/usb-musb.c
arch/arm/mach-omap2/Makefile +0 -1
index 5b37ec29996e..76e8ba70d952 100644
@@ -242,7 +242,6 @@ obj-y					+= $(omap-flash-y) $(omap-flash-m)
 omap-hsmmc-$(CONFIG_MMC_OMAP_HS)	:= hsmmc.o
 obj-y					+= $(omap-hsmmc-m) $(omap-hsmmc-y)
 
-obj-y					+= usb-musb.o
 obj-y					+= omap_phy_internal.o
 
 obj-$(CONFIG_MACH_OMAP2_TUSB6010)	+= usb-tusb6010.o
arch/arm/mach-omap2/usb-musb.c deleted +0 -106

106 lines not on this page · raw message

arch/arm/mach-omap2/usb.h +0 -1
index 3395365ef1db..1951535646d2 100644
@@ -60,7 +60,6 @@ struct usbhs_phy_data {
 	bool vcc_polarity;	/* 1 active high, 0 active low */
 };
 
-extern void usb_musb_init(struct omap_musb_board_data *board_data);
 extern void usbhs_init(struct usbhs_omap_platform_data *pdata);
 extern int usbhs_init_phys(struct usbhs_phy_data *phy, int num_phys);
Signature · 3 lines
Regards,

Laurent Pinchart
maintainer
#1 lore raw

PATCH 1/1 ARM: OMAP2+: Remove unused MUSB initialization code

Quoted 2 lines · Laurent Pinchart

With the removal of board-ldp.c and board-rx51.c, the last users of the MUSB initialization board code are gone. Remove it.

Thanks, I have the same patch already from 3 years ago in omap-for-v3.14/omap3-board-removal branch that I'll use. Still need to rebase and check few other patches there before reposting them all. FYI, to avoid duplicate work, the old barnch is at [0].

Regards,

Tony

https://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=omap-for-v3.14/omap3-board-removal

author
#2 lore raw

PATCH 1/1 ARM: OMAP2+: Remove unused MUSB initialization code

Hi Tony,

Quoted 6 lines · On Thursday 10 Nov 2016 10:54:02 Tony Lindgren wrote:
Quoted 2 lines · Laurent Pinchart

With the removal of board-ldp.c and board-rx51.c, the last users of the MUSB initialization board code are gone. Remove it.

Thanks, I have the same patch already from 3 years ago in omap-for- v3.14/omap3-board-removal branch that I'll use.

v3.14 ? That feels like cheating :-)

Quoted 2 lines

Still need to rebase and check few other patches there before reposting them all.

Will you get that one in v4.10 ?

Quoted 8 lines

FYI, to avoid duplicate work, the old barnch is at [0].

Regards,

Tony

https://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=om
ap-for-v3.14/omap3-board-removal

Signature · 3 lines
Regards,

Laurent Pinchart
maintainer
#3 lore raw

PATCH 1/1 ARM: OMAP2+: Remove unused MUSB initialization code

Quoted 11 lines · Laurent Pinchart

Hi Tony,

Quoted 6 lines · On Thursday 10 Nov 2016 10:54:02 Tony Lindgren wrote:
Quoted 2 lines · Laurent Pinchart

With the removal of board-ldp.c and board-rx51.c, the last users of the MUSB initialization board code are gone. Remove it.

Thanks, I have the same patch already from 3 years ago in omap-for- v3.14/omap3-board-removal branch that I'll use.

v3.14 ? That feels like cheating :-)

:p

Quoted 4 lines
Quoted 2 lines

Still need to rebase and check few other patches there before reposting them all.

Will you get that one in v4.10 ?

Yeah planning to assuming no problems and when out of the eternal musb regressions land.

Regards,

Tony