Skip to contentSkip to conversation

ARM: dts: s5pv210: Fix onenand's unit address format warning

PATCH In review Krzysztof Kozlowski 2 participants 2 messages Jan 9, 2019

Subsystems (2)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/1 ARM: dts: s5pv210: Fix onenand's unit address format warning

According to Devicetree specification, the unit-address must match the first address specified in the reg property of the node. Fix the DTC warning onenand node:

    arch/arm/boot/dts/s5pv210.dtsi:81.29-93.5:
        Warning (simple_bus_reg): /soc/onenand@b0000000: simple-bus unit address format error, expected "b0600000"

---

The remaining warning is wrong clock-controller subnode of fimc camera.
arch/arm/boot/dts/s5pv210.dtsi:578.32-580.6: Warning (simple_bus_reg): /soc/camera/clock-controller: missing or empty reg/ranges property
The subnode in my understanding does not follow bindings and the driver.
The driver with current s5pv210.dtsi will not register a clock provider... but
I do not have a device to confirm this.

---
 arch/arm/boot/dts/s5pv210.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/s5pv210.dtsi +1 -1
index cc22c9db80d2..26ea5c66d8ce 100644
@@ -78,7 +78,7 @@
 			};
 		};
 
-		onenand: onenand@b0000000 {
+		onenand: onenand@b0600000 {
 			compatible = "samsung,s5pv210-onenand";
 			reg = <0xb0600000 0x2000>,
 				<0xb0000000 0x20000>,
Signature · 1 line
2.7.4
Tested-by on v1 1/1
#1 lore raw

Dnia środa, 9 stycznia 2019 14:43:03 CET Krzysztof Kozlowski pisze:

Quoted 26 lines

According to Devicetree specification, the unit-address must match the first address specified in the reg property of the node. Fix the DTC warning onenand node:

    arch/arm/boot/dts/s5pv210.dtsi:81.29-93.5:
        Warning (simple_bus_reg): /soc/onenand@b0000000: simple-bus unit address format error, expected "b0600000"

---

The remaining warning is wrong clock-controller subnode of fimc camera.
arch/arm/boot/dts/s5pv210.dtsi:578.32-580.6: Warning (simple_bus_reg): /soc/camera/clock-controller: missing or empty reg/ranges property
The subnode in my understanding does not follow bindings and the driver.
The driver with current s5pv210.dtsi will not register a clock provider... but
I do not have a device to confirm this.

---
 arch/arm/boot/dts/s5pv210.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/s5pv210.dtsi +0 -0
index cc22c9db80d2..26ea5c66d8ce 100644

arch/arm/boot/dts/s5pv210.dtsi line 84

Quoted 8 lines
arch/arm/boot/dts/s5pv210.dtsi +1 -1
@@ -78,7 +78,7 @@
 			};
 		};
 
-		onenand: onenand@b0000000 {
+		onenand: onenand@b0600000 {
 			compatible = "samsung,s5pv210-onenand";
 			reg = <0xb0600000 0x2000>,
 				<0xb0000000 0x20000>,

Checked on Samsung Galaxy S (with local, not yet submited patches for devicetree support for onenand, which is missing in mainline) and it looks ok (device probed, was able to use ubi tools).