cpuidle: intel_idle: Kerneldoc update and cleanup
cover cpuidle: intel_idle: Kerneldoc update and cleanup
Hi All,
The following patches fix a kerneldoc comment and clean up whitespace in intel_idle.
Please refer to the patch changelogs for details.
Thanks!
PATCH 1/2 cpuidle: intel_idle: Update intel_idle() kerneldoc comment
From: Rafael J. Wysocki <[email protected]>
Commit bf9282dc26e7 ("cpuidle: Make CPUIDLE_FLAG_TLB_FLUSHED generic") moved the leave_mm() call away from intel_idle(), but it didn't update its kerneldoc comment accordingly, so do that now.
--- drivers/idle/intel_idle.c | 3 --- 1 file changed, 3 deletions(-)
drivers/idle/intel_idle.c +0 -3
@@ -122,9 +122,6 @@ static unsigned int mwait_substates __in* If the local APIC timer is not known to be reliable in the target idle state, * enable one-shot tick broadcasting for the target CPU before executing MWAIT. * -* Optionally call leave_mm() for the target CPU upfront to avoid wakeups due to -* flushing user TLBs. -* * Must be called under local_irq_disable(). */ static __cpuidle int intel_idle(struct cpuidle_device *dev,
Rafael J. Wysocki
maintainerRe: [PATCH v1 1/2] cpuidle: intel_idle: Update intel_idle() kerneldoc comment
Quoted 19 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
Commit
bf9282dc26e7("cpuidle: MakeCPUIDLE_FLAG_TLB_FLUSHEDgeneric") moved theleave_mm()call away fromintel_idle(), but it didn't update its kerneldoc comment accordingly, so do that now.Fixes bf9282dc26e7 ("cpuidle: Make CPUIDLE_FLAG_TLB_FLUSHED generic")Signed-off-by Rafael J. Wysocki <[email protected]>--- drivers/idle/intel_idle.c | 3 --- 1 file changed, 3 deletions(-)Index:
linux-pm/drivers/idle/intel_idle.c
===================================================================
drivers/idle/intel_idle.c static unsigned int mwait_substates __in · line 127
Quoted 9 lines
drivers/idle/intel_idle.c +0
-3@@ -122,9 +122,6 @@ static unsigned int mwait_substates __in* If the local APIC timer is not known to be reliable in the target idle state, * enable one-shot tick broadcasting for the target CPU before executing MWAIT. * -* Optionally call leave_mm() for the target CPU upfront to avoid wakeups due to -* flushing user TLBs. -* * Must be called under local_irq_disable(). */ static __cpuidle int intel_idle(struct cpuidle_device *dev,
Assuming no objections, so applied.
PATCH 2/2 cpuidle: intel_idle: Drop redundant backslash at line end
In reply to Rafael J. WysockiFrom: Rafael J. Wysocki <[email protected]>
Drop a redundant backslash character at the end of a line in the spr_cstates[] definition.
--- drivers/idle/intel_idle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/idle/intel_idle.c +1 -1
@@ -781,7 +781,7 @@ static struct cpuidle_state spr_cstates[ { .name = "C1E", .desc = "MWAIT 0x01", - .flags =MWAIT2flg (0x01 ) |CPUIDLE_FLAG_ALWAYS_ENABLE | \ + .flags =MWAIT2flg (0x01 ) |CPUIDLE_FLAG_ALWAYS_ENABLE | CPUIDLE_FLAG_UNUSABLE, .exit_latency = 2, .target_residency = 4,
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH v1 2/2] cpuidle: intel_idle: Drop redundant backslash at line end
Quoted 9 lines · CET Artem Bityutskiy
Quoted 6 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
Drop a redundant backslash character at the end of a line in the spr_cstates[] definition.
Signed-off-by Rafael J. Wysocki <[email protected]>Rafael, thanks for cleaning this up. Sorry for this.
No big deal. I'm taking this as an ACK. :-)