net/mlx5: fix flow tables double release
PATCH 1/1 net/mlx5: fix flow tables double release
In the function mlx5_alloc_shared_dr(), there are various reasons to result in a failure and error clean up process. While in the caller of mlx5_dev_spawn(), once there is a error occurring after the mlx5_alloc_shared_dr(), the mlx5_os_free_shared_dr() is called to release all the resources.
To prevent a double release, the pointers of the resources should be checked before the releasing and set to NULL after done.
In the mlx5_free_table_hash_list(), after the releasing, the pointer was missed to set to NULL and a double release may cause a crash.
By setting the tables pointer to NULL as done for other resources, the double release and crash could be solved.
--- drivers/net/mlx5/mlx5.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/mlx5/mlx5.c +1 -0
@@ -1369,6 +1369,7 @@ mlx5_free_table_hash_list(struct mlx5_priv *priv)if (!sh->flow_tbls)return ;mlx5_hlist_destroy (sh->flow_tbls); + sh->flow_tbls =NULL ; }/**
Signature · 1 line
2.27.0
From: Bing Zhao
Quoted 11 lines
In the function
mlx5_alloc_shared_dr(), there are various reasons to result in a failure and error clean up process. While in the caller ofmlx5_dev_spawn(), once there is a error occurring after themlx5_alloc_shared_dr(), themlx5_os_free_shared_dr()is called to release all the resources.To prevent a double release, the pointers of the resources should be checked before the releasing and set to NULL after done.
In the
mlx5_free_table_hash_list(), after the releasing, the pointer was missed to set to NULL and a double release may cause a crash.
Quoted 8 lines
By setting the tables pointer to NULL as done for other resources, the double release and crash could be solved.
Fixes 54534725d2f3 ("net/mlx5: fix flow table hash list conversion")Signed-off-by Bing Zhao <[email protected]>
Thomas Monjalon
Applied29/09/2021 09:55, Matan Azrad:
Quoted 15 lines
From: Bing Zhao
Quoted 14 lines
In the function
mlx5_alloc_shared_dr(), there are various reasons to result in a failure and error clean up process. While in the caller ofmlx5_dev_spawn(), once there is a error occurring after themlx5_alloc_shared_dr(), themlx5_os_free_shared_dr()is called to release all the resources.To prevent a double release, the pointers of the resources should be checked before the releasing and set to NULL after done.
In the
mlx5_free_table_hash_list(), after the releasing, the pointer was missed to set to NULL and a double release may cause a crash.By setting the tables pointer to NULL as done for other resources, the double release and crash could be solved.
Quoted 6 lines
Quoted 5 lines
Fixes 54534725d2f3 ("net/mlx5: fix flow table hash list conversion")Signed-off-by Bing Zhao <[email protected]>Acked-by Matan Azrad <[email protected]>
Applied in next-net-mlx, thanks.