Skip to contentSkip to conversation

pnp: use %*phC to dump small buffers

PATCH In review Andy Shevchenko 2 participants 2 messages Apr 22, 2013 – Apr 23, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pnp: use %*phC to dump small buffers

---
 drivers/pnp/isapnp/core.c  | 5 +----
 drivers/pnp/pnpbios/proc.c | 5 ++---
 2 files changed, 3 insertions(+), 7 deletions(-)
drivers/pnp/isapnp/core.c +1 -4
index 918d5f0..f380bcf 100644
@@ -814,10 +814,7 @@ static int __init isapnp_build_device_list(void)
 			continue;
 
 #if 0
-		dev_info(&card->dev,
-		       "vendor: %02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x\n",
-		       header[0], header[1], header[2], header[3], header[4],
-		       header[5], header[6], header[7], header[8]);
+		dev_info(&card->dev, "vendor: %9phC\n", header);
 		dev_info(&card->dev, "checksum = %#x\n", checksum);
 #endif
 		INIT_LIST_HEAD(&card->devices);
drivers/pnp/pnpbios/proc.c +2 -3
index 8dafd65..c212db0 100644
@@ -185,10 +185,9 @@ static int pnp_devices_proc_show(struct seq_file *m, void *v)
 
 		if (pnp_bios_get_dev_node(&nodenum, PNPMODE_DYNAMIC, node))
 			break;
-		seq_printf(m, "%02x\t%08x\t%02x:%02x:%02x\t%04x\n",
+		seq_printf(m, "%02x\t%08x\t%3phC\t%04x\n",
 			     node->handle, node->eisa_id,
-			     node->type_code[0], node->type_code[1],
-			     node->type_code[2], node->flags);
+			     node->type_code, node->flags);
 		if (nodenum <= thisnodenum) {
 			printk(KERN_ERR
 			       "%s Node number 0x%x is out of sequence following node 0x%x. Aborting.\n",
Signature · 1 line
1.8.2.rc0.22.gb3600c3
#1 lore raw

On Monday, April 22, 2013 04:01:05 PM Andy Shevchenko wrote:

Any changelog?

Quoted 11 lines
---
 drivers/pnp/isapnp/core.c  | 5 +----
 drivers/pnp/pnpbios/proc.c | 5 ++---
 2 files changed, 3 insertions(+), 7 deletions(-)
drivers/pnp/isapnp/core.c +0 -0
index 918d5f0..f380bcf 100644

drivers/pnp/isapnp/core.c static int __init isapnp_build_device_list(void) · line 819

Quoted 10 lines
drivers/pnp/isapnp/core.c +1 -4
@@ -814,10 +814,7 @@ static int __init isapnp_build_device_list(void)
 			continue;
 
 #if 0
-		dev_info(&card->dev,
-		       "vendor: %02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x\n",
-		       header[0], header[1], header[2], header[3], header[4],
-		       header[5], header[6], header[7], header[8]);
+		dev_info(&card->dev, "vendor: %9phC\n", header);
 		dev_info(&card->dev, "checksum = %#x\n", checksum);
 #endif

I'd rather see that #if 0 block go away entirely.

Quoted 9 lines
drivers/pnp/isapnp/core.c +0 -0
 		INIT_LIST_HEAD(&card->devices);
drivers/pnp/pnpbios/proc.c +0 -0
index 8dafd65..c212db0 100644
@@ -185,10 +185,9 @@ static int pnp_devices_proc_show(struct seq_file *m, void *v)
 
 		if (pnp_bios_get_dev_node(&nodenum, PNPMODE_DYNAMIC, node))

drivers/pnp/pnpbios/proc.c static int pnp_devices_proc_show(struct seq_file *m, void *v) · line 193

Quoted 10 lines
drivers/pnp/pnpbios/proc.c +2 -3
 			break;
-		seq_printf(m, "%02x\t%08x\t%02x:%02x:%02x\t%04x\n",
+		seq_printf(m, "%02x\t%08x\t%3phC\t%04x\n",
 			     node->handle, node->eisa_id,
-			     node->type_code[0], node->type_code[1],
-			     node->type_code[2], node->flags);
+			     node->type_code, node->flags);
 		if (nodenum <= thisnodenum) {
 			printk(KERN_ERR
 			       "%s Node number 0x%x is out of sequence following node 0x%x. Aborting.\n",

Thanks,
Rafael

Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.