RFC: drm/drm_plane: Expose the plane capability and interoperability
Subsystems (2)
PATCH 1/1 RFC: drm/drm_plane: Expose the plane capability and interoperability
Each plane has its own capability or interoperability based on the harware restrictions. If this is exposed to the user, then user can read it once on boot and store this. Later can be used as a lookup table to check a corresponding capability is supported by plane then only go ahead with the framebuffer creation/calling atomic_ioctl.
For Ex: There are few restiction as to async flip doesnt support all the formats/modifiers. Similar restrictions on scaling. With the availabililty of this info to user, failures in atomic_check can be avoided as these are more the hardware capabilities.
There are two options on how this can be acheived. Option 1:
Add a new element to struct drm_mode_get_plane that holds the addr to the array of a new struct. This new struct consists of the formats supported and the corresponding plane capabilities.
Option 2:
These can be exposed to user as a plane property so that the user can get to know the limitation ahead and avoid failures in atomic_check.
Usually atomic_get_property is controlled over the state struct for the parameters/elements that can change. But here these capabilities or the interoperabilities are rather hardware restrictions and wont change over flips. Hence having as a plane_property may not make much sense. On the other hand, Option 1 include changes in the uapi struct drm_mode_get_plane. Shouldnt have impact on backward compatibility, but if userspace has some implementation so as to check the size of the struct, then it might a challenge.
--- drivers/gpu/drm/drm_atomic_uapi.c | 3 +++ include/drm/drm_plane.h | 8 ++++++++ include/uapi/drm/drm_mode.h | 20 ++++++++++++++++++++ 3 files changed, 31 insertions(+)
=============Option 2========================
drivers/gpu/drm/drm_atomic_uapi.c +3 -0
@@ -631,6 +631,9 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->hotspot_x; }else if (property == plane->hotspot_y_property) { *val = state->hotspot_y; + }else if (property == config->prop_plane_caps) { + *val = (state->plane_caps) ? + state->plane_caps->base.id :0 ; }else { drm_dbg_atomic(dev, "[PLANE:%d:%s] unknown property [PROP:%d:%s]\n",
include/drm/drm_plane.h +8 -0
@@ -260,6 +260,14 @@ struct drm_plane_state {* flow. */ bool color_mgmt_changed : 1; + +/** +* @plane_caps: +* +* Blob representing plane capcabilites and interoperability. +* This element is a pointer to the array of struct drm_format_blob. +*/ +struct drm_property_blob *plane_caps; }; static inline struct drm_rect
=============Option 1========================
include/uapi/drm/drm_mode.h +20 -0
@@ -312,6 +312,20 @@ struct drm_mode_set_plane {__u32 src_w; }; +#define DRM_FORMAT_PLANE_CAP_LINEAR_TILE BIT(0) +#define DRM_FORMAT_PLANE_CAP_X_TILE BIT(1) +#define DRM_FORMAT_PLANE_CAP_Y_TILE BIT(2) +#define DRM_FORMAT_PLANE_CAP_Yf_TILE BIT(3) +#define DRM_FORMAT_PLANE_CAP_ASYNC_FLIP BIT(4) +#define DRM_FORMAT_PLANE_CAP_FBC BIT(5) +#define DRM_FORMAT_PLANE_CAP_RC BIT(6) + +struct drm_format_blob { +__u64 modifier; +__u32 plane_caps; + +}; +/** * struct drm_mode_get_plane - Get plane metadata. *
@@ -355,6 +369,12 @@ struct drm_mode_get_plane {* supported by the plane. These formats do not require modifiers. */ __u64 format_type_ptr; +/** +* @ format_blob_ptr: Pointer to the array of struct drm_format_blob. +* Specify the plane capabilites/restrictions w.r.t tiling/sync-async +* flips etc +*/ +__u64 format_blob_ptr; };struct drm_mode_get_plane_res {
Signature · 1 line
2.25.1
Patchwork
CI✗ Fi.CI.BUILD: failure for RFC: drm/drm_plane: Expose the plane capability and interoperability
== Series Details ==
== Series Details ==
Series: RFC: drm/drm_plane: Expose the plane capability and interoperability
URL : https://patchwork.freedesktop.org/series/135883/
State : failure
== Summary ==
Error: make failed
CALL scripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CC drivers/gpu/drm/drm_atomic_uapi.odrivers/gpu/drm/drm_atomic_uapi.c: In function ‘drm_atomic_plane_get_property’:drivers/gpu/drm/drm_atomic_uapi.c:634:31: error: ‘struct drm_mode_config’ has no member named ‘prop_plane_caps’
634 | } else if (property == config->prop_plane_caps) {
| ^~
make[5]: *** [scripts/Makefile.build:244: drivers/gpu/drm/drm_atomic_uapi.o] Error 1
make[4]: *** [scripts/Makefile.build:485: drivers/gpu/drm] Error 2
make[3]: *** [scripts/Makefile.build:485: drivers/gpu] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/home/kbuild/kernel/Makefile:1934: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
Build failed, no error log produced
Hi,
Quoted 23 lines · On Dienstag, 9. Juli 2024 09:46:56 MESZ Arun R Murthy wrote:
Each plane has its own capability or interoperability based on the harware restrictions. If this is exposed to the user, then user can read it once on boot and store this. Later can be used as a lookup table to check a corresponding capability is supported by plane then only go ahead with the framebuffer creation/calling
atomic_ioctl.For Ex: There are few restiction as to async flip doesnt support all the formats/modifiers. Similar restrictions on scaling. With the availabililty of this info to user, failures in
atomic_checkcan be avoided as these are more the hardware capabilities.There are two options on how this can be acheived. Option 1:
Add a new element to struct
drm_mode_get_planethat holds the addr to the array of a new struct. This new struct consists of the formats supported and the corresponding plane capabilities.Option 2:
These can be exposed to user as a plane property so that the user can get to know the limitation ahead and avoid failures in
atomic_check.
Quoted 8 lines
Usually
atomic_get_propertyis controlled over the state struct for the parameters/elements that can change. But here these capabilities or the interoperabilities are rather hardware restrictions and wont change over flips. Hence having as aplane_propertymay not make much sense. On the other hand, Option 1 include changes in the uapi structdrm_mode_get_plane. Shouldnt have impact on backward compatibility, but if userspace has some implementation so as to check the size of the struct, then it might a challenge.
Adding fields to the struct should be okay, but adding a per-plane immutable property is also fine and IMO the cleaner option. We already have the same thing with "IN_FORMATS" and "type" that don't ever change either.
Either way, having a capability flag per format+modifier pair sounds good to me and should be both easy to make use of in userspace.
Quoted 14 lines
Signed-off-by Arun R Murthy <[email protected]>--- drivers/gpu/drm/drm_atomic_uapi.c | 3 +++ include/drm/drm_plane.h | 8 ++++++++ include/uapi/drm/drm_mode.h | 20 ++++++++++++++++++++ 3 files changed, 31 insertions(+)=============Option 2========================
(quoted diff) +0
-0
b/drivers/gpu/drm/drm_atomic_uapi.cindex22bbb2d83e30..b46177d5fc8c100644
drivers/gpu/drm/drm_atomic_uapi.c drm_atomic_plane_get_property(struct drm_plane *plane, · line 639
Quoted 9 lines
drivers/gpu/drm/drm_atomic_uapi.c +3
-0@@ -631,6 +631,9 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->hotspot_x; }else if (property == plane->hotspot_y_property) { *val = state->hotspot_y; + }else if (property == config->prop_plane_caps) { + *val = (state->plane_caps) ? + state->plane_caps->base.id :0 ; }else { drm_dbg_atomic(dev, "[PLANE:%d:%s] unknown property
[PROP:%d:%s]\n",
Quoted 5 lines
include/drm/drm_plane.h +0
-0
include/drm/drm_plane.h struct drm_plane_state { · line 268
Quoted 9 lines
include/drm/drm_plane.h +6
-0@@ -260,6 +260,14 @@ struct drm_plane_state {* flow. */ bool color_mgmt_changed : 1; + +/** +* @plane_caps: +* +* Blob representing plane capcabilites and interoperability. +* This element is a pointer to the array of struct
drm_format_blob.
Quoted 34 lines
include/drm/drm_plane.h +2
-0+*/ +struct drm_property_blob *plane_caps; }; static inline struct drm_rect=============Option 1========================
include/uapi/drm/drm_mode.h +14
-0@@ -312,6 +312,20 @@ struct drm_mode_set_plane {__u32 src_w; }; +#define DRM_FORMAT_PLANE_CAP_LINEAR_TILE BIT(0) +#define DRM_FORMAT_PLANE_CAP_X_TILE BIT(1) +#define DRM_FORMAT_PLANE_CAP_Y_TILE BIT(2) +#define DRM_FORMAT_PLANE_CAP_Yf_TILE BIT(3) +#define DRM_FORMAT_PLANE_CAP_ASYNC_FLIP BIT(4) +#define DRM_FORMAT_PLANE_CAP_FBC BIT(5) +#define DRM_FORMAT_PLANE_CAP_RC BIT(6) + +struct drm_format_blob { +__u64 modifier; +__u32 plane_caps; + +}; +/** * struct drm_mode_get_plane - Get plane metadata. *
include/uapi/drm/drm_mode.h struct drm_mode_get_plane { · line 373
Quoted 5 lines
include/uapi/drm/drm_mode.h +2
-0@@ -355,6 +369,12 @@ struct drm_mode_get_plane {* supported by the plane. These formats do not require modifiers. */ __u64 format_type_ptr; +/** +* @ format_blob_ptr: Pointer to the array of struct
drm_format_blob.
include/uapi/drm/drm_mode.h struct drm_mode_get_plane { · line 374
Quoted 1 line
include/uapi/drm/drm_mode.h +1
-0+* Specify the plane capabilites/restrictions w.r.t tiling/sync-
async
Quoted 6 lines
include/uapi/drm/drm_mode.h +3
-0+* flips etc +*/ +__u64 format_blob_ptr; };struct drm_mode_get_plane_res {
Quoted 45 lines
-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Xaver Hugl
Sent: Thursday, July 11, 2024 9:06 PM
To: [email protected]
Subject: Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperabilityHi,
Quoted 23 lines · On Dienstag, 9. Juli 2024 09:46:56 MESZ Arun R Murthy wrote:
Each plane has its own capability or interoperability based on the harware restrictions. If this is exposed to the user, then user can read it once on boot and store this. Later can be used as a lookup table to check a corresponding capability is supported by plane then only go ahead with the framebuffer creation/calling
atomic_ioctl.For Ex: There are few restiction as to async flip doesnt support all the formats/modifiers. Similar restrictions on scaling. With the availabililty of this info to user, failures in
atomic_checkcan be avoided as these are more the hardware capabilities.There are two options on how this can be acheived. Option 1:
Add a new element to struct
drm_mode_get_planethat holds the addr to the array of a new struct. This new struct consists of the formats supported and the corresponding plane capabilities.Option 2:
These can be exposed to user as a plane property so that the user can get to know the limitation ahead and avoid failures in
atomic_check.Quoted 8 lines
Usually
atomic_get_propertyis controlled over the state struct for the parameters/elements that can change. But here these capabilities or the interoperabilities are rather hardware restrictions and wont change over flips. Hence having as aplane_propertymay not make much sense. On the other hand, Option 1 include changes in the uapi structdrm_mode_get_plane. Shouldnt have impact on backward compatibility, but if userspace has some implementation so as to check the size of the struct, then it might a challenge.
Quoted 6 lines
Adding fields to the struct should be okay, but adding a per-plane immutable property is also fine and IMO the cleaner option. We already have the same thing with "
IN_FORMATS" and "type" that don't ever change either.Either way, having a capability flag per format+modifier pair sounds good to me and should be both easy to make use of in userspace.
Adding new fields to a structure part of an existing UAPI may not be a great idea. This can have some issues of backward compatibility and multiple structure definitions with various kernel and user space header versions. So this doesn't look very promising. Others can chime in and share their perspective.
We can expose an immutable plane capability property (with interoperability info) which userspace can read and based on the capabilities exposed plane the composition. So, option 2 looks more viable to me.
Regards,
Uma Shankar
Quoted 92 lines
drivers/gpu/drm/drm_atomic_uapi.c drm_atomic_plane_get_property(struct drm_plane
Quoted 15 lines
Signed-off-by Arun R Murthy <[email protected]>--- drivers/gpu/drm/drm_atomic_uapi.c | 3 +++ include/drm/drm_plane.h | 8 ++++++++ include/uapi/drm/drm_mode.h | 20 ++++++++++++++++++++ 3 files changed, 31 insertions(+)=============Option 2========================
(quoted diff) +0
-0
b/drivers/gpu/drm/drm_atomic_uapi.cindex22bbb2d83e30..b46177d5fc8c100644drivers/gpu/drm/drm_atomic_uapi.c +0
-0@@ -631,6 +631,9 @@ drm_atomic_plane_get_property(struct drm_plane*plane,
drivers/gpu/drm/drm_atomic_uapi.c drm_atomic_plane_get_property(struct drm_plane *plane,
Quoted 9 lines
drivers/gpu/drm/drm_atomic_uapi.c +3
-0*val = state->hotspot_x; }else if (property == plane->hotspot_y_property) { *val = state->hotspot_y; + }else if (property == config->prop_plane_caps) { + *val = (state->plane_caps) ? + state->plane_caps->base.id :0 ; }else { drm_dbg_atomic(dev, "[PLANE:%d:%s] unknown property[PROP:%d:%s]\n",
Quoted 5 lines
include/drm/drm_plane.h index renamed from include/drm/drm_plane.h +0
-0
dd718c62ac31..dfe931677d0a100644include/drm/drm_plane.h struct drm_plane_state { · line 268
Quoted 9 lines
include/drm/drm_plane.h +6
-0@@ -260,6 +260,14 @@ struct drm_plane_state {* flow. */ bool color_mgmt_changed : 1; + +/** +* @plane_caps: +* +* Blob representing plane capcabilites and interoperability. +* This element is a pointer to the array of struct
drm_format_blob.Quoted 34 lines
include/drm/drm_plane.h +2
-0+*/ +struct drm_property_blob *plane_caps; }; static inline struct drm_rect=============Option 1========================
include/uapi/drm/drm_mode.h +14
-0@@ -312,6 +312,20 @@ struct drm_mode_set_plane {__u32 src_w; }; +#define DRM_FORMAT_PLANE_CAP_LINEAR_TILE BIT(0) +#define DRM_FORMAT_PLANE_CAP_X_TILE BIT(1) +#define DRM_FORMAT_PLANE_CAP_Y_TILE BIT(2) +#define DRM_FORMAT_PLANE_CAP_Yf_TILE BIT(3) +#define DRM_FORMAT_PLANE_CAP_ASYNC_FLIP BIT(4) +#define DRM_FORMAT_PLANE_CAP_FBC BIT(5) +#define DRM_FORMAT_PLANE_CAP_RC BIT(6) + +struct drm_format_blob { +__u64 modifier; +__u32 plane_caps; + +}; +/** * struct drm_mode_get_plane - Get plane metadata. * include/uapi/drm/drm_mode.h struct drm_mode_get_plane { · line 373
Quoted 5 lines
include/uapi/drm/drm_mode.h +2
-0@@ -355,6 +369,12 @@ struct drm_mode_get_plane {* supported by the plane. These formats do not require modifiers. */ __u64 format_type_ptr; +/** +* @ format_blob_ptr: Pointer to the array of struct
drm_format_blob.include/uapi/drm/drm_mode.h struct drm_mode_get_plane { · line 374
Quoted 1 line
include/uapi/drm/drm_mode.h +1
-0+* Specify the plane capabilites/restrictions w.r.t tiling/sync- async
Quoted 6 lines
include/uapi/drm/drm_mode.h +3
-0+* flips etc +*/ +__u64 format_blob_ptr; };struct drm_mode_get_plane_res {
Gentle Reminder!
Any comments?
Thanks and Regards,
Arun R Murthy
--------------------
Quoted 127 lines
-----Original Message-----
From: Murthy, Arun R <[email protected]>
Sent: Tuesday, July 9, 2024 1:17 PM
To: [email protected]; [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperabilityEach plane has its own capability or interoperability based on the harware restrictions. If this is exposed to the user, then user can read it once on boot and store this. Later can be used as a lookup table to check a corresponding capability is supported by plane then only go ahead with the framebuffer creation/calling
atomic_ioctl.For Ex: There are few restiction as to async flip doesnt support all the formats/modifiers. Similar restrictions on scaling. With the availabililty of this info to user, failures in
atomic_checkcan be avoided as these are more the hardware capabilities.There are two options on how this can be acheived. Option 1:
Add a new element to struct
drm_mode_get_planethat holds the addr to the array of a new struct. This new struct consists of the formats supported and the corresponding plane capabilities.Option 2:
These can be exposed to user as a plane property so that the user can get to know the limitation ahead and avoid failures in
atomic_check.Usually
atomic_get_propertyis controlled over the state struct for the parameters/elements that can change. But here these capabilities or the interoperabilities are rather hardware restrictions and wont change over flips. Hence having as aplane_propertymay not make much sense.
On the other hand, Option 1 include changes in the uapi structdrm_mode_get_plane. Shouldnt have impact on backward compatibility, but if userspace has some implementation so as to check the size of the struct, then it might a challenge.Signed-off-by Arun R Murthy <[email protected]>--- drivers/gpu/drm/drm_atomic_uapi.c | 3 +++ include/drm/drm_plane.h | 8 ++++++++ include/uapi/drm/drm_mode.h | 20 ++++++++++++++++++++ 3 files changed, 31 insertions(+)=============Option 2========================
drivers/gpu/drm/drm_atomic_uapi.c +3
-0@@ -631,6 +631,9 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->hotspot_x; }else if (property == plane->hotspot_y_property) { *val = state->hotspot_y; + }else if (property == config->prop_plane_caps) { + *val = (state->plane_caps) ? + state->plane_caps->base.id :0 ; }else { drm_dbg_atomic(dev,"[PLANE:%d:%s] unknown property
[PROP:%d:%s]\n", diff --gita/include/drm/drm_plane.hb/include/drm/drm_plane.hindexdd718c62ac31..dfe931677d0a100644include/drm/drm_plane.h +8
-0@@ -260,6 +260,14 @@ struct drm_plane_state {* flow. */ bool color_mgmt_changed : 1; + +/** +* @plane_caps: +* +* Blob representing plane capcabilites and interoperability. +* This element is a pointer to the array of struct drm_format_blob. +*/ +struct drm_property_blob *plane_caps; }; static inline struct drm_rect=============Option 1========================
include/uapi/drm/drm_mode.h +20
-1@@ -312,6 +312,20 @@ struct drm_mode_set_plane {__u32 src_w; }; +#define DRM_FORMAT_PLANE_CAP_LINEAR_TILE BIT(0) +#define DRM_FORMAT_PLANE_CAP_X_TILE BIT(1) +#define DRM_FORMAT_PLANE_CAP_Y_TILE BIT(2) +#define DRM_FORMAT_PLANE_CAP_Yf_TILE BIT(3) +#define DRM_FORMAT_PLANE_CAP_ASYNC_FLIP BIT(4) +#define DRM_FORMAT_PLANE_CAP_FBC BIT(5) +#define DRM_FORMAT_PLANE_CAP_RC BIT(6) + +struct drm_format_blob { +__u64 modifier; +__u32 plane_caps; + +}; +/** * struct drm_mode_get_plane - Get plane metadata. * @@ -355,6 +369,12 @@ struct drm_mode_get_plane {* supported by the plane. These formats do not require modifiers. */ __u64 format_type_ptr; +/** +* @ format_blob_ptr: Pointer to the array of struct drm_format_blob. +* Specify the plane capabilites/restrictions w.r.t tiling/sync-async +* flips etc +*/ +__u64 format_blob_ptr; };struct drm_mode_get_plane_res { --2.25.1
Quoted 2 lines · Arun R
Gentle Reminder!
Any comments?
First of all, the format is underdocumented. Second, there is a usual requirement for new uAPI: please provide a pointer to IGT patch and to the userspace utilising the property.
Quoted 133 lines
Thanks and Regards,
Arun R Murthy
--------------------Quoted 127 lines
-----Original Message-----
From: Murthy, Arun R <[email protected]>
Sent: Tuesday, July 9, 2024 1:17 PM
To: [email protected]; [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperabilityEach plane has its own capability or interoperability based on the harware restrictions. If this is exposed to the user, then user can read it once on boot and store this. Later can be used as a lookup table to check a corresponding capability is supported by plane then only go ahead with the framebuffer creation/calling
atomic_ioctl.For Ex: There are few restiction as to async flip doesnt support all the formats/modifiers. Similar restrictions on scaling. With the availabililty of this info to user, failures in
atomic_checkcan be avoided as these are more the hardware capabilities.There are two options on how this can be acheived. Option 1:
Add a new element to struct
drm_mode_get_planethat holds the addr to the array of a new struct. This new struct consists of the formats supported and the corresponding plane capabilities.Option 2:
These can be exposed to user as a plane property so that the user can get to know the limitation ahead and avoid failures in
atomic_check.Usually
atomic_get_propertyis controlled over the state struct for the parameters/elements that can change. But here these capabilities or the interoperabilities are rather hardware restrictions and wont change over flips. Hence having as aplane_propertymay not make much sense.
On the other hand, Option 1 include changes in the uapi structdrm_mode_get_plane. Shouldnt have impact on backward compatibility, but if userspace has some implementation so as to check the size of the struct, then it might a challenge.Signed-off-by Arun R Murthy <[email protected]>--- drivers/gpu/drm/drm_atomic_uapi.c | 3 +++ include/drm/drm_plane.h | 8 ++++++++ include/uapi/drm/drm_mode.h | 20 ++++++++++++++++++++ 3 files changed, 31 insertions(+)=============Option 2========================
drivers/gpu/drm/drm_atomic_uapi.c +3
-0@@ -631,6 +631,9 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->hotspot_x; }else if (property == plane->hotspot_y_property) { *val = state->hotspot_y; + }else if (property == config->prop_plane_caps) { + *val = (state->plane_caps) ? + state->plane_caps->base.id :0 ; }else { drm_dbg_atomic(dev,"[PLANE:%d:%s] unknown property
[PROP:%d:%s]\n", diff --gita/include/drm/drm_plane.hb/include/drm/drm_plane.hindexdd718c62ac31..dfe931677d0a100644include/drm/drm_plane.h +8
-0@@ -260,6 +260,14 @@ struct drm_plane_state {* flow. */ bool color_mgmt_changed : 1; + +/** +* @plane_caps: +* +* Blob representing plane capcabilites and interoperability. +* This element is a pointer to the array of struct drm_format_blob. +*/ +struct drm_property_blob *plane_caps; }; static inline struct drm_rect=============Option 1========================
include/uapi/drm/drm_mode.h +20
-1@@ -312,6 +312,20 @@ struct drm_mode_set_plane {__u32 src_w; }; +#define DRM_FORMAT_PLANE_CAP_LINEAR_TILE BIT(0) +#define DRM_FORMAT_PLANE_CAP_X_TILE BIT(1) +#define DRM_FORMAT_PLANE_CAP_Y_TILE BIT(2) +#define DRM_FORMAT_PLANE_CAP_Yf_TILE BIT(3) +#define DRM_FORMAT_PLANE_CAP_ASYNC_FLIP BIT(4) +#define DRM_FORMAT_PLANE_CAP_FBC BIT(5) +#define DRM_FORMAT_PLANE_CAP_RC BIT(6) + +struct drm_format_blob { +__u64 modifier; +__u32 plane_caps; + +}; +/** * struct drm_mode_get_plane - Get plane metadata. * @@ -355,6 +369,12 @@ struct drm_mode_get_plane {* supported by the plane. These formats do not require modifiers. */ __u64 format_type_ptr; +/** +* @ format_blob_ptr: Pointer to the array of struct drm_format_blob. +* Specify the plane capabilites/restrictions w.r.t tiling/sync-async +* flips etc +*/ +__u64 format_blob_ptr; };struct drm_mode_get_plane_res { --2.25.1
Signature · 2 lines
With best wishes Dmitry
Quoted 8 lines
-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Tuesday, July 30, 2024 4:21 AM
To: Murthy, Arun R <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperability
Quoted 7 lines
Quoted 2 lines · Arun R
Gentle Reminder!
Any comments?First of all, the format is underdocumented. Second, there is a usual requirement for new uAPI: please provide a pointer to IGT patch and to the userspace utilising the property.
There are some discussions on using this in UMD. https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29618#note_2487123
Thanks and Regards,
Arun R Murthy
--------------------
Quoted 141 lines
Quoted 40 lines
Thanks and Regards,
Arun R Murthy
--------------------Quoted 34 lines
-----Original Message-----
From: Murthy, Arun R <[email protected]>
Sent: Tuesday, July 9, 2024 1:17 PM
To: [email protected]; [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperabilityEach plane has its own capability or interoperability based on the harware restrictions. If this is exposed to the user, then user can read it once on boot and store this. Later can be used as a lookup table to check a corresponding capability is supported by plane then only go ahead with the framebuffer creation/calling
atomic_ioctl.For Ex: There are few restiction as to async flip doesnt support all the formats/modifiers. Similar restrictions on scaling. With the availabililty of this info to user, failures in
atomic_checkcan be avoided as these are more the hardware capabilities.There are two options on how this can be acheived. Option 1:
Add a new element to struct
drm_mode_get_planethat holds the addr to the array of a new struct. This new struct consists of the formats supported and the corresponding plane capabilities.Option 2:
These can be exposed to user as a plane property so that the user can get to know the limitation ahead and avoid failures in
atomic_check.Usually
atomic_get_propertyis controlled over the state struct for the parameters/elements that can change. But here these capabilities or the interoperabilities are rather hardware restrictions and wont changeover flips.
Quoted 15 lines
Quoted 15 lines
Hence having as a
plane_propertymay not make much sense. On the other hand, Option 1 include changes in the uapi structdrm_mode_get_plane. Shouldnt have impact on backward compatibility, but if userspace has some implementation so as to check the size of the struct, then it might a challenge.Signed-off-by Arun R Murthy <[email protected]>--- drivers/gpu/drm/drm_atomic_uapi.c | 3 +++ include/drm/drm_plane.h | 8 ++++++++ include/uapi/drm/drm_mode.h | 20 ++++++++++++++++++++ 3 files changed, 31 insertions(+)=============Option 2========================
Quoted 16 lines
Quoted 15 lines
drivers/gpu/drm/drm_atomic_uapi.c +3
-0@@ -631,6 +631,9 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->hotspot_x; }else if (property == plane->hotspot_y_property) { *val = state->hotspot_y; + }else if (property == config->prop_plane_caps) { + *val = (state->plane_caps) ? + state->plane_caps->base.id :0 ; }else { drm_dbg_atomic(dev,Quoted 1 line
"[PLANE:%d:%s] unknown property
[PROP:%d:%s]\n", diff
Quoted 60 lines
Quoted 60 lines
--git
a/include/drm/drm_plane.hb/include/drm/drm_plane.hindexdd718c62ac31..dfe931677d0a100644include/drm/drm_plane.h +8
-0@@ -260,6 +260,14 @@ struct drm_plane_state {* flow. */ bool color_mgmt_changed : 1; + +/** +* @plane_caps: +* +* Blob representing plane capcabilites and interoperability. +* This element is a pointer to the array of struct drm_format_blob. +*/ +struct drm_property_blob *plane_caps; }; static inline struct drm_rect=============Option 1========================
(quoted diff) +0
-0
b/include/uapi/drm/drm_mode.hindexd390011b89b4..0b5c1b65ef63100644include/uapi/drm/drm_mode.h +20
-0@@ -312,6 +312,20 @@ struct drm_mode_set_plane {__u32 src_w; }; +#define DRM_FORMAT_PLANE_CAP_LINEAR_TILE BIT(0) +#define DRM_FORMAT_PLANE_CAP_X_TILE BIT(1) +#define DRM_FORMAT_PLANE_CAP_Y_TILE BIT(2) +#define DRM_FORMAT_PLANE_CAP_Yf_TILE BIT(3) +#define DRM_FORMAT_PLANE_CAP_ASYNC_FLIP BIT(4) +#define DRM_FORMAT_PLANE_CAP_FBC BIT(5) +#define DRM_FORMAT_PLANE_CAP_RC BIT(6) + +struct drm_format_blob { +__u64 modifier; +__u32 plane_caps; + +}; +/** * struct drm_mode_get_plane - Get plane metadata. * @@ -355,6 +369,12 @@ struct drm_mode_get_plane {* supported by the plane. These formats do not require modifiers. */ __u64 format_type_ptr; +/** +* @ format_blob_ptr: Pointer to the array of struct drm_format_blob. +* Specify the plane capabilites/restrictions w.r.t tiling/sync-async +* flips etc +*/ +__u64 format_blob_ptr; };Quoted 4 lines
Quoted 3 lines
include/uapi/drm/drm_mode.h +0
-1struct drm_mode_get_plane_res { --2.25.1
--
With best wishes
Dmitry
Quoted 8 lines · Arun R
Quoted 8 lines
-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Tuesday, July 30, 2024 4:21 AM
To: Murthy, Arun R <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperability
Please fix your email client.
Quoted 9 lines
Quoted 8 lines · Arun R
Quoted 2 lines
Gentle Reminder!
Any comments?First of all, the format is underdocumented. Second, there is a usual requirement for new uAPI: please provide a pointer to IGT patch and to the userspace utilising the property.
There are some discussions on using this in UMD. https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29618#note_2487123
It should be a MR rather than "some discussion". And IGT patchset too, please.
Regarding the patch itself. It is completely underdocumented. There is no way for me to understand which of these caps should e.g. be set for the drm/msm planes.
Quoted 145 lines
Thanks and Regards,
Arun R Murthy
--------------------Quoted 141 lines
Quoted 40 lines
Thanks and Regards,
Arun R Murthy
--------------------Quoted 34 lines
-----Original Message-----
From: Murthy, Arun R <[email protected]>
Sent: Tuesday, July 9, 2024 1:17 PM
To: [email protected]; [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperabilityEach plane has its own capability or interoperability based on the harware restrictions. If this is exposed to the user, then user can read it once on boot and store this. Later can be used as a lookup table to check a corresponding capability is supported by plane then only go ahead with the framebuffer creation/calling
atomic_ioctl.For Ex: There are few restiction as to async flip doesnt support all the formats/modifiers. Similar restrictions on scaling. With the availabililty of this info to user, failures in
atomic_checkcan be avoided as these are more the hardware capabilities.There are two options on how this can be acheived. Option 1:
Add a new element to struct
drm_mode_get_planethat holds the addr to the array of a new struct. This new struct consists of the formats supported and the corresponding plane capabilities.Option 2:
These can be exposed to user as a plane property so that the user can get to know the limitation ahead and avoid failures in
atomic_check.Usually
atomic_get_propertyis controlled over the state struct for the parameters/elements that can change. But here these capabilities or the interoperabilities are rather hardware restrictions and wont changeover flips.
Quoted 15 lines
Quoted 15 lines
Hence having as a
plane_propertymay not make much sense. On the other hand, Option 1 include changes in the uapi structdrm_mode_get_plane. Shouldnt have impact on backward compatibility, but if userspace has some implementation so as to check the size of the struct, then it might a challenge.Signed-off-by Arun R Murthy <[email protected]>--- drivers/gpu/drm/drm_atomic_uapi.c | 3 +++ include/drm/drm_plane.h | 8 ++++++++ include/uapi/drm/drm_mode.h | 20 ++++++++++++++++++++ 3 files changed, 31 insertions(+)=============Option 2========================
Quoted 16 lines
Quoted 15 lines
drivers/gpu/drm/drm_atomic_uapi.c +3
-0@@ -631,6 +631,9 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->hotspot_x; }else if (property == plane->hotspot_y_property) { *val = state->hotspot_y; + }else if (property == config->prop_plane_caps) { + *val = (state->plane_caps) ? + state->plane_caps->base.id :0 ; }else { drm_dbg_atomic(dev,Quoted 1 line
"[PLANE:%d:%s] unknown property
[PROP:%d:%s]\n", diff
Quoted 60 lines
Quoted 60 lines
--git
a/include/drm/drm_plane.hb/include/drm/drm_plane.hindexdd718c62ac31..dfe931677d0a100644include/drm/drm_plane.h +8
-0@@ -260,6 +260,14 @@ struct drm_plane_state {* flow. */ bool color_mgmt_changed : 1; + +/** +* @plane_caps: +* +* Blob representing plane capcabilites and interoperability. +* This element is a pointer to the array of struct drm_format_blob. +*/ +struct drm_property_blob *plane_caps; }; static inline struct drm_rect=============Option 1========================
(quoted diff) +0
-0
b/include/uapi/drm/drm_mode.hindexd390011b89b4..0b5c1b65ef63100644include/uapi/drm/drm_mode.h +20
-0@@ -312,6 +312,20 @@ struct drm_mode_set_plane {__u32 src_w; }; +#define DRM_FORMAT_PLANE_CAP_LINEAR_TILE BIT(0) +#define DRM_FORMAT_PLANE_CAP_X_TILE BIT(1) +#define DRM_FORMAT_PLANE_CAP_Y_TILE BIT(2) +#define DRM_FORMAT_PLANE_CAP_Yf_TILE BIT(3) +#define DRM_FORMAT_PLANE_CAP_ASYNC_FLIP BIT(4) +#define DRM_FORMAT_PLANE_CAP_FBC BIT(5) +#define DRM_FORMAT_PLANE_CAP_RC BIT(6) + +struct drm_format_blob { +__u64 modifier; +__u32 plane_caps; + +}; +/** * struct drm_mode_get_plane - Get plane metadata. * @@ -355,6 +369,12 @@ struct drm_mode_get_plane {* supported by the plane. These formats do not require modifiers. */ __u64 format_type_ptr; +/** +* @ format_blob_ptr: Pointer to the array of struct drm_format_blob. +* Specify the plane capabilites/restrictions w.r.t tiling/sync-async +* flips etc +*/ +__u64 format_blob_ptr; };Quoted 4 lines
Quoted 3 lines
include/uapi/drm/drm_mode.h +0
-1struct drm_mode_get_plane_res { --2.25.1
--
With best wishes
Dmitry
Signature · 2 lines
With best wishes Dmitry
Quoted 19 lines
-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Wednesday, July 31, 2024 2:04 PM
To: Murthy, Arun R <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperabilityQuoted 8 lines · Arun R
Quoted 8 lines
-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Tuesday, July 30, 2024 4:21 AM
To: Murthy, Arun R <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperability
Quoted 2 lines
Please fix your email client.
Sorry for that. Sure will fix it.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines · Arun R
Quoted 2 lines
Gentle Reminder!
Any comments?
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
First of all, the format is underdocumented. Second, there is a usual requirement for new uAPI: please provide a pointer to IGT patch and to the userspace utilising the property.
There are some discussions on using this in UMD.
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29618#note_2
487123It should be a MR rather than "some discussion". And IGT patchset too, please.
There is no IGT patch yet.
Quoted 4 lines
Regarding the patch itself. It is completely underdocumented. There is no way for me to understand which of these caps should e.g. be set for the drm/msm planes.
I have explained it in the patch header. There are certain plane restrictions.
For example, certain pixel formats are not supported in async flip. If this is known to the compositor ahead, then compositor sending a flip with this unsupported formats leads to a flip failure. In order to overcome this if the KMD sends the list of supported pixel formats, compositor can verify for the same and then send the flip request. This can be achieved in two options. The options are listed below in the patch header and expected some review comments or suggestion as to which option to use!
Thanks and Regards,
Arun R Murthy
--------------------
Quoted 157 lines
Quoted 25 lines
Thanks and Regards,
Arun R Murthy
--------------------Quoted 20 lines
Quoted 20 lines
Thanks and Regards,
Arun R Murthy
--------------------Quoted 14 lines
-----Original Message-----
From: Murthy, Arun R <[email protected]>
Sent: Tuesday, July 9, 2024 1:17 PM
To: [email protected]; [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperabilityEach plane has its own capability or interoperability based on the harware restrictions. If this is exposed to the user, then user can read it once on boot and store this. Later can be used as a lookup table to check a corresponding capability is supported by plane then only go ahead with the framebuffer
creation/calling
atomic_ioctl.Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
For Ex: There are few restiction as to async flip doesnt support all the formats/modifiers. Similar restrictions on scaling. With the availabililty of this info to user, failures in
atomic_checkcan be avoided as these are more the hardware capabilities.There are two options on how this can be acheived. Option 1:
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Add a new element to struct
drm_mode_get_planethat holds the addr to the array of a new struct. This new struct consists of the formats supported and the corresponding plane capabilities.Option 2:
These can be exposed to user as a plane property so that the user can get to know the limitation ahead and avoid failures in
atomic_check.Quoted 99 lines
Quoted 99 lines
Quoted 5 lines
Quoted 5 lines
Usually
atomic_get_propertyis controlled over the state struct for the parameters/elements that can change. But here these capabilities or the interoperabilities are rather hardware restrictions and wont changeover flips.
Quoted 15 lines
Quoted 15 lines
Hence having as a
plane_propertymay not make much sense. On the other hand, Option 1 include changes in the uapi structdrm_mode_get_plane. Shouldnt have impact on backward compatibility, but if userspace has some implementation so as to check the size of the struct, then it might a challenge.Signed-off-by Arun R Murthy <[email protected]>--- drivers/gpu/drm/drm_atomic_uapi.c | 3 +++ include/drm/drm_plane.h | 8 ++++++++ include/uapi/drm/drm_mode.h | 20 ++++++++++++++++++++ 3 files changed, 31 insertions(+)=============Option 2========================
Quoted 16 lines
Quoted 15 lines
drivers/gpu/drm/drm_atomic_uapi.c +3
-0@@ -631,6 +631,9 @@ drm_atomic_plane_get_property(structdrm_plane *plane, *val = state->hotspot_x; }else if (property == plane->hotspot_y_property) { *val = state->hotspot_y; + }else if (property == config->prop_plane_caps) { + *val = (state->plane_caps) ? + state->plane_caps->base.id :0 ; }else { drm_dbg_atomic(dev,Quoted 1 line
"[PLANE:%d:%s] unknown property
[PROP:%d:%s]\n", diff
Quoted 61 lines
Quoted 61 lines
--git
a/include/drm/drm_plane.hb/include/drm/drm_plane.hindexdd718c62ac31..dfe931677d0a100644include/drm/drm_plane.h +8
-0@@ -260,6 +260,14 @@ struct drm_plane_state {* flow. */ bool color_mgmt_changed : 1; + +/** +* @plane_caps: +* +* Blob representing plane capcabilites and interoperability. +* This element is a pointer to the array of struct drm_format_blob. +*/ +struct drm_property_blob *plane_caps; }; static inline struct drm_rect=============Option 1========================
(quoted diff) +0
-0
b/include/uapi/drm/drm_mode.hindexd390011b89b4..0b5c1b65ef63100644include/uapi/drm/drm_mode.h +21
-0@@ -312,6 +312,20 @@ struct drm_mode_set_plane {__u32 src_w; }; +#define DRM_FORMAT_PLANE_CAP_LINEAR_TILE BIT(0) +#define DRM_FORMAT_PLANE_CAP_X_TILE BIT(1) +#define DRM_FORMAT_PLANE_CAP_Y_TILE BIT(2) +#define DRM_FORMAT_PLANE_CAP_Yf_TILE BIT(3) +#define DRM_FORMAT_PLANE_CAP_ASYNC_FLIP BIT(4) +#define DRM_FORMAT_PLANE_CAP_FBC BIT(5) +#define DRM_FORMAT_PLANE_CAP_RC BIT(6) + +struct drm_format_blob { +__u64 modifier; +__u32 plane_caps; + +}; +/** * struct drm_mode_get_plane - Get plane metadata. * @@ -355,6 +369,12 @@ struct drm_mode_get_plane {* supported by the plane. These formats do not require modifiers. */ __u64 format_type_ptr; +/** +* @ format_blob_ptr: Pointer to the array of struct drm_format_blob. +* Specify the plane capabilites/restrictions w.r.t +tiling/sync-async +* flips etc +*/ +__u64 format_blob_ptr; };Quoted 8 lines
Quoted 8 lines
Quoted 4 lines
Quoted 3 lines
struct
drm_mode_get_plane_res{
--
2.25.1--
With best wishes
Dmitry--
With best wishes
Dmitry
Quoted 39 lines · Arun R
Quoted 20 lines
-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Wednesday, July 31, 2024 2:04 PM
To: Murthy, Arun R <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperabilityQuoted 8 lines · Arun R
Quoted 8 lines
-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Tuesday, July 30, 2024 4:21 AM
To: Murthy, Arun R <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperabilityQuoted 2 lines
Please fix your email client.
Sorry for that. Sure will fix it.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines · Arun R
Quoted 2 lines
Gentle Reminder!
Any comments?Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
First of all, the format is underdocumented. Second, there is a usual requirement for new uAPI: please provide a pointer to IGT patch and to the userspace utilising the property.
There are some discussions on using this in UMD.
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29618#note_2
487123It should be a MR rather than "some discussion". And IGT patchset too, please.
There is no IGT patch yet.
Quoted 1 line
Quoted 7 lines
Quoted 3 lines
Regarding the patch itself. It is completely underdocumented. There is no way for me to understand which of these caps should e.g. be set for the drm/msm planes.
I have explained it in the patch header. There are certain plane restrictions.
For example, certain pixel formats are not supported in async flip. If this is known to the compositor ahead, then compositor sending a flip with this unsupported formats leads to a flip failure. In order to overcome this if the KMD sends the list of supported pixel formats, compositor can verify for the same and then send the flip request. This can be achieved in two options. The options are listed below in the patch header and expected some review comments or suggestion as to which option to use!
It is impossible to understand what your options / capabilities _actually_ mean. I browsed through the patch and I still don't understand how to select which options apply to DRM_FORMAT_MOD_QCOM_*
Signature · 2 lines
With best wishes Dmitry
Quoted 64 lines
-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Wednesday, July 31, 2024 2:51 PM
To: Murthy, Arun R <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperabilityQuoted 22 lines · Arun R
Quoted 22 lines
-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Wednesday, July 31, 2024 2:04 PM
To: Murthy, Arun R <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperabilityQuoted 9 lines · Arun R
Quoted 9 lines
-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Tuesday, July 30, 2024 4:21 AM
To: Murthy, Arun R <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperabilityQuoted 18 lines
Quoted 2 lines
Please fix your email client.
Sorry for that. Sure will fix it.
Quoted 14 lines
Quoted 5 lines
Quoted 5 lines · Arun R
Quoted 2 lines
Gentle Reminder!
Any comments?Quoted 7 lines
Quoted 3 lines
First of all, the format is underdocumented. Second, there is a usual requirement for new uAPI: please provide a pointer to IGT patch and to the userspace utilising the property.
There are some discussions on using this in UMD.
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29618#note_2
487123It should be a MR rather than "some discussion". And IGT patchset too,
please.
Quoted 8 lines
There is no IGT patch yet.
Quoted 4 lines
Regarding the patch itself. It is completely underdocumented. There is no way for me to understand which of these caps should e.g. be set for the drm/msm planes.
I have explained it in the patch header. There are certain plane restrictions. For example, certain pixel formats are not supported in async flip. If this is
known to the compositor ahead, then compositor sending a flip with this unsupported formats leads to a flip failure. In order to overcome this if the KMD sends the list of supported pixel formats, compositor can verify for the same and then send the flip request.
Quoted 8 lines
Quoted 1 line
This can be achieved in two options. The options are listed below in the patch
header and expected some review comments or suggestion as to which option to use!
It is impossible to understand what your options / capabilities _actually_ mean. I browsed through the patch and I still don't understand how to select which options apply to DRM_FORMAT_MOD_QCOM_*
Sorry for that let me put it more simple words.
Agenda: KMD should share the plane restrictions i.e capability in terms of what is supported and what is not to the UMD.
We can see two options of achieving this
Option 1: drm_mode_getplane() -> This function exposes the plane metadata such as formats. But these are generic formats supported by the plane. There can be few restrictions like some formats not supported by async flip, certain formats not supported in 270/90 deg rotation and so on. These are the hardware limitations and in order to expose these, this function can be reused. A new pointer is added to the existing drm_mode_get_plane struct to share this.
include/uapi/drm/drm_mode.h +14 -0
@@ -312,6 +312,20 @@ struct drm_mode_set_plane {__u32 src_w; }; +#define DRM_FORMAT_PLANE_CAP_LINEAR_TILE BIT(0) +#define DRM_FORMAT_PLANE_CAP_X_TILE BIT(1) +#define DRM_FORMAT_PLANE_CAP_Y_TILE BIT(2) +#define DRM_FORMAT_PLANE_CAP_Yf_TILE BIT(3) +#define DRM_FORMAT_PLANE_CAP_ASYNC_FLIP BIT(4) +#define DRM_FORMAT_PLANE_CAP_FBC BIT(5) +#define DRM_FORMAT_PLANE_CAP_RC BIT(6) + +struct drm_format_blob { +__u64 modifier; +__u32 plane_caps; + +}; +
/**
* struct drm_mode_get_plane - Get plane metadata. *
@@ -355,6 +369,12 @@ struct drm_mode_get_plane {
* supported by the plane. These formats do not require modifiers.
*/
__u64 format_type_ptr;
+ /**
+ * @ format_blob_ptr: Pointer to the array of struct drm_format_blob.
+ * Specify the plane capabilites/restrictions w.r.t tiling/sync-async
+ * flips etc
+ */+ __u64 format_blob_ptr;
};
Option 2: Exposing this restriction/capabilities as a plane property. The struct drm_format_blob defined in Option 1 will be used over here as well.
drivers/gpu/drm/drm_atomic_uapi.c +3 -0
@@ -631,6 +631,9 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->hotspot_x; }else if (property == plane->hotspot_y_property) { *val = state->hotspot_y; + }else if (property == config->prop_plane_caps) { + *val = (state->plane_caps) ? + state->plane_caps->base.id :0 ; }else { drm_dbg_atomic(dev, "[PLANE:%d:%s] unknown property [PROP:%d:%s]\n",
include/drm/drm_plane.h +8 -0
@@ -260,6 +260,14 @@ struct drm_plane_state {* flow. */ bool color_mgmt_changed : 1; + +/** +* @plane_caps: +* +* Blob representing plane capcabilites and interoperability. +* This element is a pointer to the array of struct drm_format_blob. +*/ +struct drm_property_blob *plane_caps; };
Thanks and Regards,
Arun R Murthy
--------------------
Patchwork
CI✗ Fi.CI.BUILD: failure for RFC: drm/drm_plane: Expose the plane capability and interoperability (rev2)
In reply to Arun R Murthy== Series Details ==
== Series Details ==
Series: RFC: drm/drm_plane: Expose the plane capability and interoperability (rev2)
URL : https://patchwork.freedesktop.org/series/135883/
State : failure
== Summary ==
Error: patch https://patchwork.freedesktop.org/api/1.0/series/135883/revisions/2/mbox/ not applied
Applying: RFC: drm/drm_plane: Expose the plane capability and interoperability
error: corrupt patch at line 21
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RFC: drm/drm_plane: Expose the plane capability and interoperability When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Build failed, no error log produced