Skip to contentSkip to conversation

Revert "ACPI / PM: LPIT: Register sysfs attributes based on FADT"

PATCH In review Rafael J. Wysocki 2 participants 2 messages Jul 13, 2022 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "ACPI / PM: LPIT: Register sysfs attributes based on FADT"

Author: Rafael J. Wysocki <[email protected]>

Revert commit 1cdda9486f51 ("ACPI / PM: LPIT: Register sysfs attributes based on FADT"), because what it did was more confusing than it would be to allow the sysfs attributes in question to be created regardless of whether or not the relevant flag was set in the FADT.

If ACPI_FADT_LOW_POWER_S0 is not set, it need not mean that LPIT is invalid and low-power S0 idle is not usable. It merely means that using S3 on the given system is more beneficial from the energy saving perspective than using low-power S0 idle.

---

drivers/acpi/acpi_lpit.c +0 -6
index 48e5059d67ca..50540d4d4948 100644
@@ -109,17 +109,11 @@ static void lpit_update_residency(struct lpit_residency_info *info,
 		if (!info->iomem_addr)
 			return;
 
-		if (!(acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0))
-			return;
-
 		/* Silently fail, if cpuidle attribute group is not present */
 		sysfs_add_file_to_group(&cpu_subsys.dev_root->kobj,
 					&dev_attr_low_power_idle_system_residency_us.attr,
 					"cpuidle");
 	} else if (info->gaddr.space_id == ACPI_ADR_SPACE_FIXED_HARDWARE) {
-		if (!(acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0))
-			return;
-
 		/* Silently fail, if cpuidle attribute group is not present */
 		sysfs_add_file_to_group(&cpu_subsys.dev_root->kobj,
 					&dev_attr_low_power_idle_cpu_residency_us.attr,
Reviewed-by on v1 1/1
#1 lore raw

[Public]

Quoted 18 lines

-----Original Message-----
From: Rafael J. Wysocki <[email protected]>
Sent: Wednesday, July 13, 2022 12:33
To: Linux ACPI <[email protected]>
Cc: LKML <[email protected]>; Linux PM <linux- [email protected]>; Srinivas Pandruvada <[email protected]>; Zhang Rui <[email protected]>; Limonciello, Mario <[email protected]>
Subject: [PATCH] Revert "ACPI / PM: LPIT: Register sysfs attributes based on FADT"

Author: Rafael J. Wysocki <[email protected]>

Revert commit 1cdda9486f51 ("ACPI / PM: LPIT: Register sysfs attributes based on FADT"), because what it did was more confusing than it would be to allow the sysfs attributes in question to be created regardless of whether or not the relevant flag was set in the FADT.

Quoted 6 lines

If ACPI_FADT_LOW_POWER_S0 is not set, it need not mean that LPIT is invalid and low-power S0 idle is not usable. It merely means that using S3 on the given system is more beneficial from the energy saving perspective than using low-power S0 idle.

Quoted 29 lines

---

drivers/acpi/acpi_lpit.c +0 -6
index 48e5059d67ca..50540d4d4948 100644
@@ -109,17 +109,11 @@ static void lpit_update_residency(struct
 lpit_residency_info *info,
 		if (!info->iomem_addr)
 			return;
 
-		if (!(acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0))
-			return;
-
 		/* Silently fail, if cpuidle attribute group is not present */
 		sysfs_add_file_to_group(&cpu_subsys.dev_root->kobj,
 
 	&dev_attr_low_power_idle_system_residency_us.attr,
 					"cpuidle");
 	} else if (info->gaddr.space_id ==
 ACPI_ADR_SPACE_FIXED_HARDWARE) {
-		if (!(acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0))
-			return;
-
drivers/acpi/acpi_lpit.c +0 -0
 		/* Silently fail, if cpuidle attribute group is not present */
 		sysfs_add_file_to_group(&cpu_subsys.dev_root->kobj,

&dev_attr_low_power_idle_cpu_residency_us.attr,