Skip to contentSkip to conversation

drivers: parisc: Follow the indentation coding standard on printks

PATCH Superseded Carlos Bilbao 3 participants 5 messages Jul 8, 2021 PA-RISC architecture

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: parisc: Follow the indentation coding standard on printks

Fix indentation of printks that start at the beginning of the line. Change this for the right number of space characters, or tabs if the file uses them.

---
 drivers/parisc/iosapic.c               | 4 ++--
 drivers/parisc/sba_iommu.c             | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/parisc/iosapic.c +2 -2
index 8a3b0c3a1e92..5d27c23e6429 100644
@@ -633,7 +633,7 @@ static void iosapic_unmask_irq(struct irq_data *d)
 	printk("\n");
 }
 
-printk("iosapic_enable_irq(): sel ");
+	printk("iosapic_enable_irq(): sel ");
 {
 	struct iosapic_info *isp = vi->iosapic;
 
@@ -642,7 +642,7 @@ printk("iosapic_enable_irq(): sel ");
 		printk(" %x", d1);
 	}
 }
-printk("\n");
+	printk("\n");
 #endif
 
 	/*
drivers/parisc/sba_iommu.c +1 -1
index dce4cdf786cd..c3381facdfc5 100644
@@ -1550,7 +1550,7 @@ static void sba_hw_init(struct sba_device *sba_dev)
 
 
 #if 0
-printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x 0x%x\n", PAGE0->mem_boot.hpa,
+	printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x 0x%x\n", PAGE0->mem_boot.hpa,
 	PAGE0->mem_boot.spa, PAGE0->mem_boot.pad, PAGE0->mem_boot.cl_class);
 
 	/*
Signature · 1 line
2.25.1
#1 lore raw
Quoted 2 lines · Carlos Bilbao

Fix indentation of printks that start at the beginning of the line. Change this for the right number of space characters, or tabs if the file uses them.

These are ancient codes, but:

drivers/parisc/iosapic.c

Quoted 1 line
drivers/parisc/iosapic.c +0 -0

[]

Quoted 12 lines
drivers/parisc/iosapic.c +0 -0
@@ -633,7 +633,7 @@ static void iosapic_unmask_irq(struct irq_data *d)
  	printk("\n");
  }

drivers/parisc/iosapic.c +1 -1
-printk("iosapic_enable_irq(): sel ");
+	printk("iosapic_enable_irq(): sel ");

 {
  struct iosapic_info *isp = vi->iosapic;

drivers/parisc/iosapic.c printk("iosapic_enable_irq(): sel "); · line 646

Quoted 6 lines
drivers/parisc/iosapic.c +1 -1
@@ -642,7 +642,7 @@ printk("iosapic_enable_irq(): sel ");
  		printk(" %x", d1);
  	}
  }
-printk("\n");
+	printk("\n");
  #endif

This is in an undefined #ifdef block and the block could be deleted.

drivers/parisc/sba_iommu.c

Quoted 1 line
drivers/parisc/sba_iommu.c +0 -0

[]

Quoted 6 lines
drivers/parisc/sba_iommu.c +0 -0
@@ -1550,7 +1550,7 @@ static void sba_hw_init(struct sba_device *sba_dev)

 #if 0

#if 0 blocks can be removed.

Quoted 6 lines
drivers/parisc/sba_iommu.c +1 -1
-printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x 0x%x\n", PAGE0->mem_boot.hpa,
+	printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x 0x%x\n", PAGE0->mem_boot.hpa,

  PAGE0->mem_boot.spa, PAGE0->mem_boot.pad, PAGE0->mem_boot.cl_class);

  /*

#2 lore raw

PATCH v2 1/1 drivers: parisc: Remove unnecessary #if blocks

Remove undefined #ifdefs and #if 0 from these two files.

---
 drivers/parisc/iosapic.c   | 21 -------------
 drivers/parisc/sba_iommu.c | 63 --------------------------------------
 2 files changed, 84 deletions(-)
drivers/parisc/iosapic.c +0 -21
index 8a3b0c3a1e92..5ca80beb12cf 100644
@@ -624,27 +624,6 @@ static void iosapic_unmask_irq(struct irq_data *d)
 	iosapic_set_irt_data(vi, &d0, &d1);
 	iosapic_wr_irt_entry(vi, d0, d1);
 
-#ifdef DEBUG_IOSAPIC_IRT
-{
-	u32 *t = (u32 *) ((ulong) vi->eoi_addr & ~0xffUL);
-	printk("iosapic_enable_irq(): regs %p", vi->eoi_addr);
-	for ( ; t < vi->eoi_addr; t++)
-		printk(" %x", readl(t));
-	printk("\n");
-}
-
-printk("iosapic_enable_irq(): sel ");
-{
-	struct iosapic_info *isp = vi->iosapic;
-
-	for (d0=0x10; d0<0x1e; d0++) {
-		d1 = iosapic_read(isp->addr, d0);
-		printk(" %x", d1);
-	}
-}
-printk("\n");
-#endif
-
 	/*
 	 * Issuing I/O SAPIC an EOI causes an interrupt IFF IRQ line is
 	 * asserted.  IRQ generally should not be asserted when a driver
drivers/parisc/sba_iommu.c +0 -63

93 lines not on this page · raw message

Signature · 1 line
2.25.1
#3 lore raw

Re: [PATCH net-next v2] drivers: parisc: Remove unnecessary #if blocks

Quoted 1 line · Carlos Bilbao

Remove undefined #ifdefs and #if 0 from these two files.

Hi Carlos

This is not a network driver, so putting net-next in the subject is not useful.

Also, at the moment, we are in the merge window. It is unlikely that any maintainer will accept your patches until the merge window closes, which should be this weekend. You can whoever still send patches, but please mark them RFC, and send them just to the appropriate list, not the maintainer.

Andrew

#4 lore raw

Re: [PATCH net-next v2] drivers: parisc: Remove unnecessary #if blocks

Hello Andrew, following your suggestions I will just abandon this and resubmit next week with proper Subjects, etc.

Quoted 17 lines · Andrew Lunn
Quoted 1 line · Carlos Bilbao

Remove undefined #ifdefs and #if 0 from these two files.

Hi Carlos

This is not a network driver, so putting net-next in the subject is not useful.

Also, at the moment, we are in the merge window. It is unlikely that any maintainer will accept your patches until the merge window closes, which should be this weekend. You can whoever still send patches, but please mark them RFC, and send them just to the appropriate list, not the maintainer.

Andrew