Skip to contentSkip to conversation

JSON file boot_table in openbmc-test-automation

DISCUSSION Tony Lee (李文富) 2 participants 3 messages Dec 20, 2019 – Dec 23, 2019

lore
Share & tools
lore
#0 lore raw

Hi Michael,

Refer to the method readHostState() in repo phosphor-logging. The description "For host on, looks for the values of 'BootComplete' or 'Standby' in the OperatingSystemState property ..."
So, I'm wonder that if the value of the key "operating_system" can be "^BootComplete|Standby$" for action "Power On" in the boot_table.json?

Thanks
Best Regards,
Tony

#1 lore raw

There are several 'Power on' boot types represented in data/boot_table.json. Let's take the 'REST Power On' as an example:

    "REST Power On": {
        "start": {
            "rest": "^1$",
            "chassis": "^Off$",
            "boot_progress": "^Off|Unspecified$",
            "operating_system": "^Inactive$",
            "host": "^Off$"
        },
        "end": {
            "rest": "^1$",
            "chassis": "^On$",
            "boot_progress": "^FW Progress, Starting OS|OSStart$",
            "operating_system": "^BootComplete$",
            "host": "^Running$",
            "os_ping": "^1$",
            "os_login": "^1$",
            "os_run_cmd": "^1$"
        },
        "bmc_reboot": 0,
        "method_type": "keyword",
        "method": "Initiate Host Boot  wait=${0}",
        "lib_file_path": "state_manager.robot"
    },

The end requirements indicate that the operating_system value must be BootComplete. I've never seen this fail because the operating_system state was "Standby". Unless you foresee a change coming that necessitate this, I'd be inclined to leave it as is. As the saying goes "If it ain't broke, don't fix it".

Michael Walsh
IBM Dept 3AL
Rochester, MN
[email protected]

From:   "Tony Lee (李文富)" <[email protected]>
To:     "[email protected]" <[email protected]>
Date:   12/19/2019 09:24 PM
Subject:        [EXTERNAL] JSON file boot_table in openbmc-test-automation

Hi Michael,

Refer to the method readHostState() in repo phosphor-logging. The description
"For host on, looks for the values of 'BootComplete' or 'Standby' in the OperatingSystemState property ..."
So, I'm wonder that if the value of the key "operating_system" can be "^BootComplete|Standby$" for action "Power On" in the boot_table.json?

Thanks
Best Regards,
Tony

#2 lore raw

I see. Thanks for your reply.

From: Michael Walsh <[email protected]>
Sent: Saturday, December 21, 2019 3:38 AM
To: Tony Lee (李文富) <[email protected]>
Cc: [email protected]; George Keishing <[email protected]>
Subject: Re: JSON file boot_table in openbmc-test-automation

There are several 'Power on' boot types represented in data/boot_table.json.  Let's take the 'REST Power On' as an example:

    "REST Power On": {
        "start": {
            "rest": "^1$",
            "chassis": "^Off$",
            "boot_progress": "^Off|Unspecified$", "operating_system": "^Inactive$",
            "host": "^Off$"
        },
        "end": {
            "rest": "^1$",
            "chassis": "^On$",
            "boot_progress": "^FW Progress, Starting OS|OSStart$", "operating_system": "^BootComplete$", "host": "^Running$",
            "os_ping": "^1$",
            "os_login": "^1$",
            "os_run_cmd": "^1$"
        },
        "bmc_reboot": 0,
        "method_type": "keyword",
        "method": "Initiate Host Boot  wait=${0}", "lib_file_path": "state_manager.robot"
    },

The end requirements indicate that the operating_system value must be BootComplete.  I've never seen this fail because the operating_system state was "Standby".  Unless you foresee a change coming that necessitate this, I'd be inclined to leave it as is.  As the saying goes "If it ain't broke, don't fix it".

Michael Walsh
IBM Dept 3AL
Rochester, MN
mailto:[email protected]

From:        "Tony Lee (李文富)" <mailto:[email protected]>
To:        "mailto:[email protected]" <mailto:[email protected]>
Cc:        "mailto:[email protected]" <mailto:[email protected]>
Date:        12/19/2019 09:24 PM
Subject:        [EXTERNAL] JSON file boot_table in openbmc-test-automation
________________________________________

Hi Michael,

Refer to the method readHostState() in repo phosphor-logging. The description "For host on, looks for the values of 'BootComplete' or 'Standby' in the OperatingSystemState property ..."
So, I'm wonder that if the value of the key "operating_system" can be "^BootComplete|Standby$" for action "Power On" in the boot_table.json?

Thanks
Best Regards,
Tony