Skip to contentSkip to conversation

uapi: net: mii: correct 100BASE4 bit descriptions

PATCH In review Ethan Nelson-Moore 2 participants 2 messages Jan 29

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uapi: net: mii: correct 100BASE4 bit descriptions

The 100BASE4 bits in MII registers indicate 100BASE-T4, as can be seen in Ethernet PHY documentation (such as the datasheet linked below), not 4K packets. Correct the comments describing these bits.

---
 include/uapi/linux/mii.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
include/uapi/linux/mii.h +3 -3
index 39f7c44baf53..ba6f8a4fe0a6 100644
@@ -66,7 +66,7 @@
 #define BMSR_10FULL		0x1000	/* Can do 10mbps, full-duplex  */
 #define BMSR_100HALF		0x2000	/* Can do 100mbps, half-duplex */
 #define BMSR_100FULL		0x4000	/* Can do 100mbps, full-duplex */
-#define BMSR_100BASE4		0x8000	/* Can do 100mbps, 4k packets  */
+#define BMSR_100BASE4		0x8000	/* Can do 100BASE-T4           */
 
 /* Advertisement control register. */
 #define ADVERTISE_SLCT		0x001f	/* Selector bits               */
@@ -79,7 +79,7 @@
 #define ADVERTISE_1000XPAUSE	0x0080	/* Try for 1000BASE-X pause    */
 #define ADVERTISE_100FULL	0x0100	/* Try for 100mbps full-duplex */
 #define ADVERTISE_1000XPSE_ASYM	0x0100	/* Try for 1000BASE-X asym pause */
-#define ADVERTISE_100BASE4	0x0200	/* Try for 100mbps 4k packets  */
+#define ADVERTISE_100BASE4	0x0200	/* Try for 100BASE-T4          */
 #define ADVERTISE_PAUSE_CAP	0x0400	/* Try for pause               */
 #define ADVERTISE_PAUSE_ASYM	0x0800	/* Try for asymetric pause     */
 #define ADVERTISE_RESV		0x1000	/* Unused...                   */
@@ -102,7 +102,7 @@
 #define LPA_1000XPAUSE		0x0080	/* Can do 1000BASE-X pause     */
 #define LPA_100FULL		0x0100	/* Can do 100mbps full-duplex  */
 #define LPA_1000XPAUSE_ASYM	0x0100	/* Can do 1000BASE-X pause asym*/
-#define LPA_100BASE4		0x0200	/* Can do 100mbps 4k packets   */
+#define LPA_100BASE4		0x0200	/* Can do 100BASE-T4           */
 #define LPA_PAUSE_CAP		0x0400	/* Can pause                   */
 #define LPA_PAUSE_ASYM		0x0800	/* Can pause asymetrically     */
 #define LPA_RESV		0x1000	/* Unused...                   */
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 5 lines · Ethan Nelson-Moore

The 100BASE4 bits in MII registers indicate 100BASE-T4, as can be seen in Ethernet PHY documentation (such as the datasheet linked below), not 4K packets. Correct the comments describing these bits.

It is much better to reference IEEE 802.3, clause 22, section X.Y.Z.

The standard is free to download.

I do wounder where the 4K comment comes from. Did 100BASE-T4 introduce the concept of jumbo packets?

Andrew

---
pw-bot: cr