ARM: remove unused/deprecated read_cpuid_part_number()
PATCH 1/1 ARM: remove unused/deprecated read_cpuid_part_number()
Commit af040ffc9ba1 ("ARM: make it easier to check the CPU part number correctly") has left (now unused in the upstream tree and marked as deprecated) read_cpuid_part_number() while changing the way it works (using the old function with the definitions will now always evaluate as false). This causes problems with porting older code to new kernels as the code compiles (with warnings but they are very easy to miss) but it can fail silently or work just fine depending on the used hardware.
Remove unused/deprecated read_cpuid_part_number() so developers have to update their code during build time instead of running into tricky runtime problems later.
Please see the commit af040ffc9ba1 for details on how to convert your old out-of-tree code to use read_cpuid_part() instead of read_cpuid_part_number().
--- arch/arm/include/asm/cputype.h | 5 ----- 1 file changed, 5 deletions(-)
arch/arm/include/asm/cputype.h +0 -5
@@ -182,11 +182,6 @@ static inline unsigned int __attribute_creturn read_cpuid_id () &0xff00fff0 ; } -static inline unsigned int __attribute_const__ __deprecated read_cpuid_part_number(void) -{ -return read_cpuid_id () &0xFFF0 ; -} - static inline unsigned int __attribute_const__ xscale_cpu_arch_version(void) {return read_cpuid_id () &ARM_CPU_XSCALE_ARCH_MASK ;
Quoted 13 lines · Bartlomiej Zolnierkiewicz
Commit
af040ffc9ba1("ARM: make it easier to check the CPU part number correctly") has left (now unused in the upstream tree and marked as deprecated)read_cpuid_part_number()while changing the way it works (using the old function with the definitions will now always evaluate as false). This causes problems with porting older code to new kernels as the code compiles (with warnings but they are very easy to miss) but it can fail silently or work just fine depending on the used hardware.Remove unused/deprecated
read_cpuid_part_number()so developers have to update their code during build time instead of running into tricky runtime problems later.
Quoted 6 lines
Please see the commit
af040ffc9ba1for details on how to convert your old out-of-tree code to useread_cpuid_part()instead ofread_cpuid_part_number().Cc Nicolas Pitre <[email protected]>Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
If there are no more in-tree users then it should go indeed.
Quoted 22 lines
--- arch/arm/include/asm/cputype.h | 5 ----- 1 file changed, 5 deletions(-)Index:
b/arch/arm/include/asm/cputype.h
===================================================================arch/arm/include/asm/cputype.h +0
-5@@ -182,11 +182,6 @@ static inline unsigned int __attribute_creturn read_cpuid_id () &0xff00fff0 ; } -static inline unsigned int __attribute_const__ __deprecated read_cpuid_part_number(void) -{ -return read_cpuid_id () &0xFFF0 ; -} - static inline unsigned int __attribute_const__ xscale_cpu_arch_version(void) {return read_cpuid_id () &ARM_CPU_XSCALE_ARCH_MASK ;