Skip to contentSkip to conversation

get_maintainers.pl subsystem output

DISCUSSION Duda, Sebastian 3 participants 10 messages Jul 19, 2019 – Jul 23, 2019

lore
Share & tools
lore
#0 lore raw

Hi Joe,

I'm conducting a large-scale patch analysis of the LKML with 1.8 million patch emails. I'm using the get_maintainer.pl script to know which patch is related to which subsystem.

I ran into two issues while using the script:

1. When I use the script the trivial way

    $ scripts/get_maintainer.pl --subsystem --status --separator , 
drivers/media/i2c/adv748x/
    Kieran Bingham <[email protected]> (maintainer:ANALOG 
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]> (maintainer:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC ADV748X DRIVER),[email protected] (open list)
    Maintained,Buried alive in reporters
    ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB),THE REST

the output is hard to parse because the status Maintained is displayed only once but related to two subsystems.

I'd prefer a more table like representation, like this:

Kieran Bingham <[email protected]> (maintainer:ANALOG
DEVICES INC ADV748X DRIVER),[email protected] (open list:ANALOG DEVICES INC ADV748X DRIVER),ANALOG DEVICES INC ADV748X DRIVER,Maintained
Mauro Carvalho Chehab <[email protected]> (maintainer:MEDIA INPUT
INFRASTRUCTURE (V4L/DVB)),MEDIA INPUT INFRASTRUCTURE (V4L/DVB),Maintained
[email protected] (open list),THE REST,Buried alive in
reporters

2. I want to analyze multiple patches, currently I am calling the script once per patch. When calling the script with multiple files the files output is merged

    $ scripts/get_maintainer.pl --subsystem --status --separator ',' 
drivers/media/i2c/adv748x/ include/uapi/linux/wmi.h
    Kieran Bingham <[email protected]> (maintainer:ANALOG 
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]> (maintainer:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC ADV748X DRIVER),[email protected] (open list),[email protected] (open list:ACPI WMI DRIVER)
    Maintained,Buried alive in reporters,Orphan
    ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB),THE REST,ACPI WMI DRIVER

I'd like to run the script with all files but separated output, like this:

    $ scripts/get_maintainer.pl --subsystem --status --separator ',' 
--separate-files drivers/media/i2c/adv748x/ include/uapi/linux/wmi.h
    Kieran Bingham <[email protected]> (maintainer:ANALOG 
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]> (maintainer:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC ADV748X DRIVER),[email protected] (open list)
    Maintained,Buried alive in reporters
    ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB),THE REST

[email protected] (open list:ACPI WMI
DRIVER),[email protected] (open list)
Orphan,Buried alive in reporters
ACPI WMI DRIVER,THE REST

My Questions are:
1. How can I make get_maintainer's output to be more table-like?
2. How can I make get_maintainer.pl to separate each file's output?

Kind Regards
Sebastian

#1 lore raw
Quoted 5 lines · Sebastian

Hi Joe,

I'm conducting a large-scale patch analysis of the LKML with 1.8 million patch emails. I'm using the get_maintainer.pl script to know which patch is related to which subsystem.

The MAINTAINERS file is updated frequently.

Are you also using the MAINTAINERS file used
at the time each patch was submitted?

Quoted 61 lines

I ran into two issues while using the script:

1. When I use the script the trivial way

     $ scripts/get_maintainer.pl --subsystem --status --separator , 
drivers/media/i2c/adv748x/
     Kieran Bingham <[email protected]> (maintainer:ANALOG 
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]> 
(maintainer:MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC 
ADV748X DRIVER),[email protected] (open list)
     Maintained,Buried alive in reporters
     ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB),THE REST

the output is hard to parse because the status Maintained is displayed only once but related to two subsystems.

I'd prefer a more table like representation, like this:

Kieran Bingham <[email protected]> (maintainer:ANALOG
DEVICES INC ADV748X DRIVER),[email protected] (open list:ANALOG DEVICES INC ADV748X DRIVER),ANALOG DEVICES INC ADV748X DRIVER,Maintained
Mauro Carvalho Chehab <[email protected]> (maintainer:MEDIA INPUT
INFRASTRUCTURE (V4L/DVB)),MEDIA INPUT INFRASTRUCTURE (V4L/DVB),Maintained
[email protected] (open list),THE REST,Buried alive in
reporters

2. I want to analyze multiple patches, currently I am calling the script once per patch. When calling the script with multiple files the files output is merged

     $ scripts/get_maintainer.pl --subsystem --status --separator ',' 
drivers/media/i2c/adv748x/ include/uapi/linux/wmi.h
     Kieran Bingham <[email protected]> (maintainer:ANALOG 
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]> 
(maintainer:MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC 
ADV748X DRIVER),[email protected] (open 
list),[email protected] (open list:ACPI WMI DRIVER)
     Maintained,Buried alive in reporters,Orphan
     ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB),THE REST,ACPI WMI DRIVER

I'd like to run the script with all files but separated output, like this:

     $ scripts/get_maintainer.pl --subsystem --status --separator ',' 
--separate-files drivers/media/i2c/adv748x/ include/uapi/linux/wmi.h
     Kieran Bingham <[email protected]> (maintainer:ANALOG 
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]> 
(maintainer:MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC 
ADV748X DRIVER),[email protected] (open list)
     Maintained,Buried alive in reporters
     ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB),THE REST
Quoted 8 lines

[email protected] (open list:ACPI WMI
DRIVER),[email protected] (open list)
Orphan,Buried alive in reporters
ACPI WMI DRIVER,THE REST

My Questions are:
1. How can I make get_maintainer's output to be more table-like?

I suggest adding --nogit --nogit-fallback --roles --norolestats

Quoted 1 line

2. How can I make get_maintainer.pl to separate each file's output?

Run the script with multiple invocations. once for each file modified by the patch.

#2 lore raw
Quoted 11 lines · Joe Perches
Quoted 5 lines · Sebastian

Hi Joe,

I'm conducting a large-scale patch analysis of the LKML with 1.8 million patch emails. I'm using the get_maintainer.pl script to know which patch is related to which subsystem.

The MAINTAINERS file is updated frequently.

Are you also using the MAINTAINERS file used
at the time each patch was submitted?

Yes, for each patch we use the MAINTAINERS file from the current (by the time the patch was submitted) release (candidate).

Quoted 72 lines
Quoted 72 lines

I ran into two issues while using the script:

1. When I use the script the trivial way

     $ scripts/get_maintainer.pl --subsystem --status --separator ,
drivers/media/i2c/adv748x/
     Kieran Bingham <[email protected]> 
(maintainer:ANALOG
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]>
(maintainer:MEDIA INPUT INFRASTRUCTURE
(V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC
ADV748X DRIVER),[email protected] (open list)
     Maintained,Buried alive in reporters
     ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE
(V4L/DVB),THE REST

the output is hard to parse because the status Maintained is displayed only once but related to two subsystems.

I'd prefer a more table like representation, like this:

Kieran Bingham <[email protected]>
(maintainer:ANALOG
DEVICES INC ADV748X DRIVER),[email protected] (open list:ANALOG DEVICES INC ADV748X DRIVER),ANALOG DEVICES INC ADV748X DRIVER,Maintained
Mauro Carvalho Chehab <[email protected]> (maintainer:MEDIA
INPUT
INFRASTRUCTURE (V4L/DVB)),MEDIA INPUT INFRASTRUCTURE (V4L/DVB),Maintained
[email protected] (open list),THE REST,Buried alive in
reporters

2. I want to analyze multiple patches, currently I am calling the script once per patch. When calling the script with multiple files the files output is merged

     $ scripts/get_maintainer.pl --subsystem --status --separator ','
drivers/media/i2c/adv748x/ include/uapi/linux/wmi.h
     Kieran Bingham <[email protected]> 
(maintainer:ANALOG
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]>
(maintainer:MEDIA INPUT INFRASTRUCTURE
(V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC
ADV748X DRIVER),[email protected] (open
list),[email protected] (open list:ACPI WMI DRIVER)
     Maintained,Buried alive in reporters,Orphan
     ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE
(V4L/DVB),THE REST,ACPI WMI DRIVER

I'd like to run the script with all files but separated output, like this:

     $ scripts/get_maintainer.pl --subsystem --status --separator ','
--separate-files drivers/media/i2c/adv748x/ include/uapi/linux/wmi.h
     Kieran Bingham <[email protected]> 
(maintainer:ANALOG
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]>
(maintainer:MEDIA INPUT INFRASTRUCTURE
(V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC
ADV748X DRIVER),[email protected] (open list)
     Maintained,Buried alive in reporters
     ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE
(V4L/DVB),THE REST

[email protected] (open list:ACPI WMI
DRIVER),[email protected] (open list)
Orphan,Buried alive in reporters
ACPI WMI DRIVER,THE REST

Quoted 4 lines
Quoted 2 lines

My Questions are:
1. How can I make get_maintainer's output to be more table-like?

I suggest adding --nogit --nogit-fallback --roles --norolestats

Unfortunately, this doesn't change the output:

    $ scripts/get_maintainer.pl --subsystem --status --separator , 
drivers/media/i2c/adv748x/
    Kieran Bingham <[email protected]> (maintainer:ANALOG 
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]> (maintainer:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC ADV748X DRIVER),[email protected] (open list)
    Maintained,Buried alive in reporters
    ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB),THE REST
    $ scripts/get_maintainer.pl --subsystem --status --separator , 
--nogit --nogit-fallback --roles --norolestats drivers/media/i2c/adv748x/
    Kieran Bingham <[email protected]> (maintainer:ANALOG 
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]> (maintainer:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC ADV748X DRIVER),[email protected] (open list)
    Maintained,Buried alive in reporters
    ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB),THE REST
Quoted 4 lines
Quoted 1 line

2. How can I make get_maintainer.pl to separate each file's output?

Run the script with multiple invocations. once for each file modified by the patch.

This is the way I'm doing it right now but this is very slow. I thought calling the script only once for many files could speed up the analysis.

Thank you
Sebastian

#3 lore raw
Quoted 8 lines · Sebastian
Quoted 4 lines · Joe Perches
Quoted 2 lines

My Questions are:
1. How can I make get_maintainer's output to be more table-like?

I suggest adding --nogit --nogit-fallback --roles --norolestats

Unfortunately, this doesn't change the output:

Quoted 10 lines
     $ scripts/get_maintainer.pl --subsystem --status --separator , 
drivers/media/i2c/adv748x/
     Kieran Bingham <[email protected]> (maintainer:ANALOG 
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]> 
(maintainer:MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC 
ADV748X DRIVER),[email protected] (open list)
     Maintained,Buried alive in reporters
     ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB),THE REST

It does change the output for files that do not have a specific maintainer.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

2. How can I make get_maintainer.pl to separate each file's output?

Run the script with multiple invocations. once for each file modified by the patch.

This is the way I'm doing it right now but this is very slow. I thought calling the script only once for many files could speed up the analysis.

get_maintainer is effectively single threaded.

Averaging 10 runs:

A single file run time is ~0.135 seconds on my system. An invocation with two files on the command line has a run time of ~0.195 seconds.

Using something like gnu parallel would allow multiple instances to run simulateously and would significantly reduce overall wall-clock runtime on most systems.

https://www.gnu.org/software/parallel/

#4 lore raw
In reply to Joe Perches

Hi Joe,

when analyzing the patch <[email protected]> [1] with get_maintainers.pl --subsystem --status --separator , /tmp/patch, there is the following output:

Chris Mason <[email protected]> (maintainer:BTRFS FILE SYSTEM),Josef Bacik
<[email protected]> (maintainer:BTRFS FILE SYSTEM),David Sterba <[email protected]> (maintainer:BTRFS FILE SYSTEM),Alexander Viro <[email protected]> (maintainer:FILESYSTEMS (VFS and infrastructure)),"Theodore Ts'o" <[email protected]> (maintainer:EXT4 FILE SYSTEM),Andreas Dilger <[email protected]> (maintainer:EXT4 FILE SYSTEM),Jaegeuk Kim <[email protected]> (maintainer:F2FS FILE SYSTEM),Changman Lee <[email protected]> (maintainer:F2FS FILE SYSTEM),Miklos Szeredi <[email protected]> (maintainer:FUSE: FILESYSTEM IN USERSPACE),Steven Whitehouse <[email protected]> (supporter:GFS2 FILE SYSTEM),Anton Altaparmakov <[email protected]> (supporter:NTFS FILESYSTEM),Hugh Dickins <[email protected]> (maintainer:TMPFS (SHMEM FILESYSTEM)),[email protected] (open list:BTRFS FILE SYSTEM),[email protected] (open list),[email protected] (open list:FILESYSTEMS (VFS and infrastructure)),[email protected] (open list:EXT4 FILE SYSTEM),[email protected] (open list:F2FS FILE SYSTEM),[email protected] (open list:FUSE: FILESYSTEM IN USERSPACE),[email protected] (open list:GFS2 FILE SYSTEM),[email protected] (open list:NTFS FILESYSTEM),[email protected] (open list:MEMORY MANAGEMENT)
Maintained,Buried alive in reporters,Supported
BTRFS FILE SYSTEM,THE REST,FILESYSTEMS (VFS and infrastructure),EXT4
FILE SYSTEM,F2FS FILE SYSTEM,FUSE: FILESYSTEM IN USERSPACE,GFS2 FILE SYSTEM,NTFS FILESYSTEM,MEMORY MANAGEMENT,TMPFS (SHMEM FILESYSTEM)

How can I parse this output automatically? or how can I generate a parsable output?

I need the tuples of subsystems and status:
(THE REST, Buried alive in reporters)
(TMPFS, Maintained)
(BTRFS FILE SYSTEM, Maintained)
…
(GFS2 FILE SYSTEM, Supported)

I'm not aware how to reliably assign the statuses to the subsystems.

Thank you in advance
Kind regards

Sebastian Duda

[1] https://lore.kernel.org/patchwork/patch/537252/

Quoted 93 lines · Joe Perches
Quoted 5 lines · Sebastian

Hi Joe,

I'm conducting a large-scale patch analysis of the LKML with 1.8 million patch emails. I'm using the get_maintainer.pl script to know which patch is related to which subsystem.

The MAINTAINERS file is updated frequently.

Are you also using the MAINTAINERS file used
at the time each patch was submitted?

Quoted 66 lines

I ran into two issues while using the script:

1. When I use the script the trivial way

     $ scripts/get_maintainer.pl --subsystem --status --separator ,
drivers/media/i2c/adv748x/
     Kieran Bingham <[email protected]> 
(maintainer:ANALOG
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]>
(maintainer:MEDIA INPUT INFRASTRUCTURE
(V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC
ADV748X DRIVER),[email protected] (open list)
     Maintained,Buried alive in reporters
     ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE
(V4L/DVB),THE REST

the output is hard to parse because the status Maintained is displayed only once but related to two subsystems.

I'd prefer a more table like representation, like this:

Kieran Bingham <[email protected]>
(maintainer:ANALOG
DEVICES INC ADV748X DRIVER),[email protected] (open list:ANALOG DEVICES INC ADV748X DRIVER),ANALOG DEVICES INC ADV748X DRIVER,Maintained
Mauro Carvalho Chehab <[email protected]> (maintainer:MEDIA
INPUT
INFRASTRUCTURE (V4L/DVB)),MEDIA INPUT INFRASTRUCTURE (V4L/DVB),Maintained
[email protected] (open list),THE REST,Buried alive in
reporters

2. I want to analyze multiple patches, currently I am calling the script once per patch. When calling the script with multiple files the files output is merged

     $ scripts/get_maintainer.pl --subsystem --status --separator ','
drivers/media/i2c/adv748x/ include/uapi/linux/wmi.h
     Kieran Bingham <[email protected]> 
(maintainer:ANALOG
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]>
(maintainer:MEDIA INPUT INFRASTRUCTURE
(V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC
ADV748X DRIVER),[email protected] (open
list),[email protected] (open list:ACPI WMI DRIVER)
     Maintained,Buried alive in reporters,Orphan
     ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE
(V4L/DVB),THE REST,ACPI WMI DRIVER

I'd like to run the script with all files but separated output, like this:

     $ scripts/get_maintainer.pl --subsystem --status --separator ','
--separate-files drivers/media/i2c/adv748x/ include/uapi/linux/wmi.h
     Kieran Bingham <[email protected]> 
(maintainer:ANALOG
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <[email protected]>
(maintainer:MEDIA INPUT INFRASTRUCTURE
(V4L/DVB)),[email protected] (open list:ANALOG DEVICES INC
ADV748X DRIVER),[email protected] (open list)
     Maintained,Buried alive in reporters
     ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE
(V4L/DVB),THE REST
Quoted 8 lines

[email protected] (open list:ACPI WMI
DRIVER),[email protected] (open list)
Orphan,Buried alive in reporters
ACPI WMI DRIVER,THE REST

My Questions are:
1. How can I make get_maintainer's output to be more table-like?

I suggest adding --nogit --nogit-fallback --roles --norolestats

Quoted 1 line

2. How can I make get_maintainer.pl to separate each file's output?

Run the script with multiple invocations. once for each file modified by the patch.

#5 lore raw

Hi Sebastian, Hi Joe,

Quoted 37 lines · Sebastian

Hi Joe,

when analyzing the patch <[email protected]> [1] with get_maintainers.pl --subsystem --status --separator , /tmp/patch, there is the following output:

Chris Mason <[email protected]> (maintainer:BTRFS FILE SYSTEM),Josef Bacik
<[email protected]> (maintainer:BTRFS FILE SYSTEM),David Sterba <[email protected]> (maintainer:BTRFS FILE SYSTEM),Alexander Viro <[email protected]> (maintainer:FILESYSTEMS (VFS and infrastructure)),"Theodore Ts'o" <[email protected]> (maintainer:EXT4 FILE SYSTEM),Andreas Dilger <[email protected]> (maintainer:EXT4 FILE SYSTEM),Jaegeuk Kim <[email protected]> (maintainer:F2FS FILE SYSTEM),Changman Lee <[email protected]> (maintainer:F2FS FILE SYSTEM),Miklos Szeredi <[email protected]> (maintainer:FUSE: FILESYSTEM IN USERSPACE),Steven Whitehouse <[email protected]> (supporter:GFS2 FILE SYSTEM),Anton Altaparmakov <[email protected]> (supporter:NTFS FILESYSTEM),Hugh Dickins <[email protected]> (maintainer:TMPFS (SHMEM FILESYSTEM)),[email protected] (open list:BTRFS FILE SYSTEM),[email protected] (open list),[email protected] (open list:FILESYSTEMS (VFS and infrastructure)),[email protected] (open list:EXT4 FILE SYSTEM),[email protected] (open list:F2FS FILE SYSTEM),[email protected] (open list:FUSE: FILESYSTEM IN USERSPACE),[email protected] (open list:GFS2 FILE SYSTEM),[email protected] (open list:NTFS FILESYSTEM),[email protected] (open list:MEMORY MANAGEMENT)
Maintained,Buried alive in reporters,Supported
BTRFS FILE SYSTEM,THE REST,FILESYSTEMS (VFS and infrastructure),EXT4
FILE SYSTEM,F2FS FILE SYSTEM,FUSE: FILESYSTEM IN USERSPACE,GFS2 FILE SYSTEM,NTFS FILESYSTEM,MEMORY MANAGEMENT,TMPFS (SHMEM FILESYSTEM)

How can I parse this output automatically? or how can I generate a parsable output?

Quoted 9 lines

I need the tuples of subsystems and status:
(THE REST, Buried alive in reporters)
(TMPFS, Maintained)
(BTRFS FILE SYSTEM, Maintained)
…
(GFS2 FILE SYSTEM, Supported)

I'm not aware how to reliably assign the statuses to the subsystems.

Joe, I hope this example makes more clear what and how Sebastian would actually like to have the information from the MAINTAINERS file presented for our use case. Currently, we would consider get_maintainer.pl to be the proper place for such a feature in the upstream development.

Joe, would you support and would you accept if we extend get_maintainer.pl to provide output of the status in such a way that the status output can be clearly mapped to the subsystem? If so, we would try our best to extend the current script and sent those patches back to lkml for review and inclusion.
If you do not support to extend get_maintainer.pl as we suggest, we would probably simply write our own specific script (probably then in python) to parse MAINTAINERS and extract and present the information as we need for our use case.

Sebastian, Considering style of mail interaction, please do not use top posting:
If you want to answer to a specific point of the previous mail discussion, keep only the relevant part for your answer (delete the rest!) and answer inline.
If you start a new discussion and do not refer to any points of the previous discussion very specifically, just delete the whole previous discussion and do not resend the content of previous mails.

Best regards,

Lukas

#6 lore raw
Quoted 32 lines · Lukas Bulwahn
Quoted 31 lines · Sebastian

when analyzing the patch <[email protected]> [1] with get_maintainers.pl --subsystem --status --separator , /tmp/patch, there is the following output:

Chris Mason <[email protected]> (maintainer:BTRFS FILE SYSTEM),Josef Bacik
<[email protected]> (maintainer:BTRFS FILE SYSTEM),David Sterba <[email protected]> (maintainer:BTRFS FILE SYSTEM),Alexander Viro <[email protected]> (maintainer:FILESYSTEMS (VFS and infrastructure)),"Theodore Ts'o" <[email protected]> (maintainer:EXT4 FILE SYSTEM),Andreas Dilger <[email protected]> (maintainer:EXT4 FILE SYSTEM),Jaegeuk Kim <[email protected]> (maintainer:F2FS FILE SYSTEM),Changman Lee <[email protected]> (maintainer:F2FS FILE SYSTEM),Miklos Szeredi <[email protected]> (maintainer:FUSE: FILESYSTEM IN USERSPACE),Steven Whitehouse <[email protected]> (supporter:GFS2 FILE SYSTEM),Anton Altaparmakov <[email protected]> (supporter:NTFS FILESYSTEM),Hugh Dickins <[email protected]> (maintainer:TMPFS (SHMEM FILESYSTEM)),[email protected] (open list:BTRFS FILE SYSTEM),[email protected] (open list),[email protected] (open list:FILESYSTEMS (VFS and infrastructure)),[email protected] (open list:EXT4 FILE SYSTEM),[email protected] (open list:F2FS FILE SYSTEM),[email protected] (open list:FUSE: FILESYSTEM IN USERSPACE),[email protected] (open list:GFS2 FILE SYSTEM),[email protected] (open list:NTFS FILESYSTEM),[email protected] (open list:MEMORY MANAGEMENT)
Maintained,Buried alive in reporters,Supported
BTRFS FILE SYSTEM,THE REST,FILESYSTEMS (VFS and infrastructure),EXT4
FILE SYSTEM,F2FS FILE SYSTEM,FUSE: FILESYSTEM IN USERSPACE,GFS2 FILE SYSTEM,NTFS FILESYSTEM,MEMORY MANAGEMENT,TMPFS (SHMEM FILESYSTEM)

Quoted 2 lines
Quoted 2 lines

How can I parse this output automatically? or how can I generate a parsable output?

[]

Quoted 8 lines
Quoted 8 lines

I need the tuples of subsystems and status:
(THE REST, Buried alive in reporters)
(TMPFS, Maintained)
(BTRFS FILE SYSTEM, Maintained)
…
(GFS2 FILE SYSTEM, Supported)

I'm not aware how to reliably assign the statuses to the subsystems.

Again, run the script using the individual files contained in a patch
instead of the entire patch.

I again suggest using gnu parallel.

Quoted 5 lines

Joe, I hope this example makes more clear what and how Sebastian would actually like to have the information from the MAINTAINERS file presented for our use case. Currently, we would consider get_maintainer.pl to be the proper place for such a feature in the upstream development.

I believe I understand how you want to use the get_maintainer script output.

Quoted 3 lines

Joe, would you support and would you accept if we extend get_maintainer.pl to provide output of the status in such a way that the status output can be clearly mapped to the subsystem?

Not really, no. I don't see much value in your request to others. It seems you are doing some academic work rather than actually using it for sending patches.

You are of course welcome to extexd the script in whatever manner you need for your own use, but even here, I don't believe you need to do anything to the script but change how you use it.

#7 lore raw

Hi Joe,

Quoted 2 lines · Joe Perches

On Tue, 2019-07-23 at 10:42 +0200, Lukas Bulwahn wrote:

[...]

Quoted 9 lines
Quoted 3 lines

Joe, would you support and would you accept if we extend get_maintainer.pl to provide output of the status in such a way that the status output can be clearly mapped to the subsystem?

Not really, no. I don't see much value in your request to others. It seems you are doing some academic work rather than actually using it for sending patches.

Thank you for that indication. It is good to know that our use case is too special to be covered in the existing tool and serves no one else besides our research work.

Quoted 5 lines

You are of course welcome to extexd the script in whatever manner you need for your own use, but even here, I don't believe you need to do anything to the script but change how you use it.

Okay, I now understood your suggestion how to use it. Sebastian and I will investigate and discuss this further off-list.

Lukas

#8 lore raw
Quoted 1 line · Lukas Bulwahn

Hi Joe,

Hi again.

Quoted 13 lines · Joe Perches
Quoted 1 line · Lukas Bulwahn

[...]

Quoted 9 lines
Quoted 3 lines

Joe, would you support and would you accept if we extend get_maintainer.pl to provide output of the status in such a way that the status output can be clearly mapped to the subsystem?

Not really, no. I don't see much value in your
request to others. It seems you are doing some
academic work rather than actually using it for
sending patches.

Quoted 3 lines

Thank you for that indication. It is good to know that our use case is too special to be covered in the existing tool and serves no one else besides our research work.

Seems a bit harsh a description, and yes, I've
not ever seen a single request similar to yours
to use get_maintainer in such a manner.

#9 lore raw
In reply to Duda, Sebastian
Quoted 4 lines · Sebastian

Hi Joe,

when analyzing the patch <[email protected]> [1] with

https://lore.kernel.org/lkml/[email protected]

Quoted 2 lines

get_maintainers.pl --subsystem --status --separator , /tmp/patch, there is the following output:

[]

Quoted 2 lines
Quoted 2 lines

Run the script with multiple invocations. once for each file modified by the patch.

For example: perhaps use something like:

$ grep -h '^\+\+\+ b/' <patch> | \
  sed 's@^\+\+\+ b/@@' | sort | uniq | \
  while read file ; do \
    ./scripts/get_maintainer.pl --nogit --nogit-fallback --subsystem --status --separator , $file ; \
  done

or use parallel like:

$ grep -h '^\+\+\+ b/' <patch> | \
  sed 's@^\+\+\+ b/@@' | sort | uniq | \
  parallel -k ./scripts/get_maintainer.pl --nogit --nogit-fallback --subsystem --status --separator ,

runtime on my system for this is

Using while read loop:

real 0m2.509s
user 0m2.236s
sys 0m0.296s

Using parallel:

real 0m1.340s
user 0m4.159s
sys 0m0.429s