boot_aggregate.test: Skip if CONFIG_IMA not enabled
PATCH 1/1 boot_aggregate.test: Skip if CONFIG_IMA not enabled
This is required, because when TPM HW available (i.e. -c /dev/tpm0), evmctl ima_boot_aggregate returns sha1:xxxx.
skip requires to move cleanup().
---
Hi Mimi,
this Fixes problems on current Debian, which has still disabled CONFIG_IMA (FYI [1]). I was not able to figure out how to get it working with sample-* files, but maybe there is a way.
Although it sound strange, people may want to build and check evmctl even on a system with disabled CONFIG_IMA (both Debian and Ubuntu have outdated ima-evm-utils (1.1)).
Kind regards,
Petr
[1] https://bugs.debian.org/972459 linux: Reenable CONFIG_IMA
tests/boot_aggregate.test | 35 ++++++++++++++++++++--------------- 1 file changed, 20 insertions(+), 15 deletions(-)
tests/boot_aggregate.test +20 -15
@@ -26,21 +26,6 @@ TSSDIR="$(dirname -- "$(which tssstartup)")" PCRFILE="/sys/class/tpm/tpm0/device/pcrs" MISC_PCRFILE="/sys/class/misc/tpm0/device/pcrs" -if [ "$(id -u)" = 0 ] && [ -c "/dev/tpm0" ]; then - ASCII_RUNTIME_MEASUREMENTS="/sys/kernel/security/ima/ascii_runtime_measurements" -else - BINARY_BIOS_MEASUREMENTS="./sample-binary_bios_measurements-pcrs-8-9" - ASCII_RUNTIME_MEASUREMENTS="./sample-ascii_runtime_measurements-pcrs-8-9" - export TPM_INTERFACE_TYPE="socsim" - export TPM_COMMAND_PORT=2321 - export TPM_PLATFORM_PORT=2322 - export TPM_SERVER_NAME="localhost" - - # swtpm uses the raw, unencapsulated packet format - export TPM_SERVER_TYPE="raw" - -fi - # Only stop this test's software TPM cleanup() { if [ -n "${SWTPM_PID}" ]; then
@@ -165,6 +150,26 @@ check() { return "$FAIL" } +if [ ! -d "/sys/kernel/security/ima" ]; then + echo "${CYAN}SKIP: CONFIG_IMA not enabled${NORM}" + exit "$SKIP" +fi + +if [ "$(id -u)" = 0 ] && [ -c "/dev/tpm0" ]; then + ASCII_RUNTIME_MEASUREMENTS="/sys/kernel/security/ima/ascii_runtime_measurements" +else + BINARY_BIOS_MEASUREMENTS="./sample-binary_bios_measurements-pcrs-8-9" + ASCII_RUNTIME_MEASUREMENTS="./sample-ascii_runtime_measurements-pcrs-8-9" + export TPM_INTERFACE_TYPE="socsim" + export TPM_COMMAND_PORT=2321 + export TPM_PLATFORM_PORT=2322 + export TPM_SERVER_NAME="localhost" + + # swtpm uses the raw, unencapsulated packet format + export TPM_SERVER_TYPE="raw" + +fi + # Start and initialize a software TPM as needed if [ "$(id -u)" != 0 ] || [ ! -c "/dev/tpm0" ]; then if [ -f "$PCRFILE" ] || [ -f "$MISC_PCRFILE" ]; then
Signature · 1 line
2.27.0.rc0
Mimi Zohar
maintainer[Cc'ing Dmitry Eremin-Solenikov]
Hi Petr,
Quoted 6 lines · Petr Vorel
This is required, because when TPM HW available (i.e. -c
/dev/tpm0), evmctlima_boot_aggregatereturns sha1:xxxx.skip requires to move
cleanup().Signed-off-by Petr Vorel <[email protected]>
Nice.
Quoted 10 lines
---
Hi Mimi,this Fixes problems on current Debian, which has still disabled
CONFIG_IMA(FYI [1]). I was not able to figure out how to get it working with sample-* files, but maybe there is a way.Although it sound strange, people may want to build and check evmctl even on a system with disabled
CONFIG_IMA(both Debian and Ubuntu have outdated ima-evm-utils (1.1)).
Oops, I need to keep Dmitry in the loop better. I'm hoping to release v1.3 shortly.
Quoted 5 lines
Kind regards,
Petr[1] https://bugs.debian.org/972459 linux: Reenable
CONFIG_IMA
I wasn't aware that because of lockdown, IMA was disabled. Thank you for reporting and updating the IMA w/lockdown status.
Mimi
Hi Mimi, Dmitry,
Quoted 20 lines
[Cc'ing Dmitry Eremin-Solenikov]
Hi Petr,
Quoted 6 lines · Petr Vorel
This is required, because when TPM HW available (i.e. -c
/dev/tpm0), evmctlima_boot_aggregatereturns sha1:xxxx.skip requires to move
cleanup().Signed-off-by Petr Vorel <[email protected]>Nice.
Quoted 6 lines
---
Hi Mimi,this Fixes problems on current Debian, which has still disabled
CONFIG_IMA(FYI [1]). I was not able to figure out how to get it working with sample-* files, but maybe there is a way.
Quoted 6 lines
Quoted 3 lines
Although it sound strange, people may want to build and check evmctl even on a system with disabled
CONFIG_IMA(both Debian and Ubuntu have outdated ima-evm-utils (1.1)).Oops, I need to keep Dmitry in the loop better. I'm hoping to release v1.3 shortly.
Thanks!
@Dmitry do you wish to be Cc: before release or any other time?
Quoted 7 lines
Quoted 4 lines
Kind regards,
Petr[1] https://bugs.debian.org/972459 linux: Reenable
CONFIG_IMAI wasn't aware that because of lockdown, IMA was disabled. Thank you for reporting and updating the IMA w/lockdown status.
Feel free to comment it, please. It'd be nice to have IMA in Debian (not sure about Ubuntu status).
@Dmitry: do you plan to update Debian package? (you're the listed maintainer, although the package was signed by Wartan Hachaturow).
Quoted 1 line
Mimi
Kind regards,
Petr
Mimi Zohar
maintainer[Cc'ing Wartan Hachaturow]
Hi Wartan,
Quoted 9 lines · Petr Vorel
Quoted 4 lines
Quoted 1 line
[1] https://bugs.debian.org/972459 linux: Reenable
CONFIG_IMAI wasn't aware that because of lockdown, IMA was disabled. Thank you for reporting and updating the IMA w/lockdown status.
Feel free to comment it, please. It'd be nice to have IMA in Debian (not sure about Ubuntu status).
@Dmitry: do you plan to update Debian package? (you're the listed maintainer, although the package was signed by Wartan Hachaturow).
Earlier this year Dmitry Eremin-Solenikov posted a patch to add libressl support to ima-evm-utils. Part of the reason for our adding travis support was in order to create a testing matrix for testing openssl, libressl, ibmtss and tpm2-tss, which further led to the travis-docker distro support. (Due to some issues, the libressl support was not upstreamed.)
Do you know if there are any plans on updating the ima-evm-utils package on Debian?
thanks,
Mimi
Hello,
27.10.2020 19:06, Mimi Zohar пишет:
Quoted 11 lines
[Cc'ing Wartan Hachaturow]
Hi Wartan,
Quoted 6 lines · Petr Vorel
Quoted 3 lines
Quoted 1 line
[1] https://bugs.debian.org/972459 linux: Reenable
CONFIG_IMAI wasn't aware that because of lockdown, IMA was disabled. Thank you for reporting and updating the IMA w/lockdown status.
Feel free to comment it, please. It'd be nice to have IMA in Debian (not sure about Ubuntu status).
Quoted 8 lines
Quoted 2 lines
@Dmitry: do you plan to update Debian package? (you're the listed maintainer, although the package was signed by Wartan Hachaturow).
Earlier this year Dmitry Eremin-Solenikov posted a patch to add libressl support to ima-evm-utils. Part of the reason for our adding travis support was in order to create a testing matrix for testing openssl, libressl, ibmtss and tpm2-tss, which further led to the travis-docker distro support. (Due to some issues, the libressl support was not upstreamed.)
Mimi, it was me who posted patch for LibreSSL ("[PATCH] ima-evm-utils: Fix compatibility with LibreSSL"), but unfortunately I did not have enough time to finish it properly (I am very sorry...).
I was just going to try a newer version of ima-evm-utils and, if possible, continue upstreamizing support of LibreSSL. also, a colleague of mine made an additional patch which requires separate upstreamization. Was there another patch from Dmitry about which I do not know
Mimi Zohar
maintainerQuoted 27 lines · Mikhail Novosyolov
Hello,
27.10.2020 19:06, Mimi Zohar пишет:
Quoted 11 lines
[Cc'ing Wartan Hachaturow]
Hi Wartan,
Quoted 6 lines · Petr Vorel
Quoted 3 lines
Quoted 1 line
[1] https://bugs.debian.org/972459 linux: Reenable
CONFIG_IMAI wasn't aware that because of lockdown, IMA was disabled. Thank you for reporting and updating the IMA w/lockdown status.
Feel free to comment it, please. It'd be nice to have IMA in Debian (not sure about Ubuntu status).
Quoted 8 lines
Quoted 2 lines
@Dmitry: do you plan to update Debian package? (you're the listed maintainer, although the package was signed by Wartan Hachaturow).
Earlier this year Dmitry Eremin-Solenikov posted a patch to add libressl support to ima-evm-utils. Part of the reason for our adding travis support was in order to create a testing matrix for testing openssl, libressl, ibmtss and tpm2-tss, which further led to the travis-docker distro support. (Due to some issues, the libressl support was not upstreamed.)
Mimi, it was me who posted patch for LibreSSL ("[PATCH] ima-evm-
utils: Fix compatibility with LibreSSL"), but unfortunately I did not have enough time to finish it properly (I am very sorry...).
Quoted 5 lines
I was just going to try a newer version of ima-evm-utils and, if possible, continue upstreamizing support of LibreSSL. also, a colleague of mine made an additional patch which requires separate upstreamization. Was there another patch from Dmitry about which I do not know
Mikhail, my mistake. Thank you for the correction! Testing the
libressl changes should be a lot easier now. Please remember to include a distro travis.yml example.
thanks,
Mimi
27.10.2020 22:06, Mimi Zohar пишет:
Quoted 27 lines · Mikhail Novosyolov
Quoted 26 lines
Hello,
27.10.2020 19:06, Mimi Zohar пишет:
Quoted 11 lines
[Cc'ing Wartan Hachaturow]
Hi Wartan,
Quoted 6 lines · Petr Vorel
Quoted 3 lines
Quoted 1 line
[1] https://bugs.debian.org/972459 linux: Reenable
CONFIG_IMAI wasn't aware that because of lockdown, IMA was disabled. Thank you for reporting and updating the IMA w/lockdown status.
Feel free to comment it, please. It'd be nice to have IMA in Debian (not sure about Ubuntu status).
Quoted 8 lines
Quoted 2 lines
@Dmitry: do you plan to update Debian package? (you're the listed maintainer, although the package was signed by Wartan Hachaturow).
Earlier this year Dmitry Eremin-Solenikov posted a patch to add libressl support to ima-evm-utils. Part of the reason for our adding travis support was in order to create a testing matrix for testing openssl, libressl, ibmtss and tpm2-tss, which further led to the travis-docker distro support. (Due to some issues, the libressl support was not upstreamed.)
Mimi, it was me who posted patch for LibreSSL ("[PATCH] ima-evm-
utils: Fix compatibility with LibreSSL"), but unfortunately I did not have enough time to finish it properly (I am very sorry...).
Quoted 8 lines
Quoted 5 lines
I was just going to try a newer version of ima-evm-utils and, if possible, continue upstreamizing support of LibreSSL. also, a colleague of mine made an additional patch which requires separate upstreamization. Was there another patch from Dmitry about which I do not know
Mikhail, my mistake. Thank you for the correction! Testing the
libressl changes should be a lot easier now. Please remember to include a distro travis.yml example.
What do you mean? Do you mean adding testing of building ima-evm-utils against LibreSSL?
Which environment is used there and which ones are available? There are not many dsitros where LibreSSL is pre-packaged [1], in many of them it is not updated often enough. I would choose either ROSA where I myself maintain LibreSSL and ima-evm-utils or Arch Linux, is at least Arch Linux available in CI/CD environment? Won't we have to deal with often breakages of other parts of the rolling Arch Linux?
Also, I can just build LibreSSL from source in any available distro, e.g. Ubuntu, but the pipeline will take a lot more time.
How do we better deal with it?
Hi all,
...
Quoted 5 lines
Quoted 3 lines
Mikhail, my mistake. Thank you for the correction! Testing the
libressl changes should be a lot easier now. Please remember to include a distro travis.yml example.What do you mean? Do you mean adding testing of building ima-evm-utils against LibreSSL?
Yes, I understand Mimi wants this.
Quoted 1 line
Which environment is used there and which ones are available? There are not many dsitros where LibreSSL is pre-packaged [1], in many of them it is not updated often enough.
Look at the supported distros in travis/ in next or next-testing branch. Could you use some bleeding edge distro (Tumbleweed or Fedora?) You could handl LibreSSL vs. openSSL with variable, similarly like IBM TSS and Intel TSS are handled (with $TSS variable).
Quoted 4 lines
I would choose either ROSA where I myself maintain LibreSSL and ima-evm-utils or Arch Linux, is at least Arch Linux available in CI/CD environment? Won't we have to deal with often breakages of other parts of the rolling Arch Linux?
Also, I can just build LibreSSL from source in any available distro, e.g. Ubuntu, but the pipeline will take a lot more time.
Please use distro package. Not only it's faster (as you noted), but it also covers more users (IMHO most of the people use distro package, not a git version).
Quoted 1 line
How do we better deal with it?
Kind regards,
Petr
Quoted 1 line
Quoted 34 lines · Petr Vorel
Hi Mimi, Dmitry,
Quoted 20 lines
[Cc'ing Dmitry Eremin-Solenikov]
Hi Petr,
Quoted 6 lines · Petr Vorel
This is required, because when TPM HW available (i.e. -c
/dev/tpm0), evmctlima_boot_aggregatereturns sha1:xxxx.skip requires to move
cleanup().Signed-off-by Petr Vorel <[email protected]>Nice.
Quoted 6 lines
---
Hi Mimi,this Fixes problems on current Debian, which has still disabled
CONFIG_IMA(FYI [1]). I was not able to figure out how to get it working with sample-* files, but maybe there is a way.Quoted 6 lines
Quoted 3 lines
Although it sound strange, people may want to build and check evmctl even on a system with disabled
CONFIG_IMA(both Debian and Ubuntu have outdated ima-evm-utils (1.1)).Oops, I need to keep Dmitry in the loop better. I'm hoping to release v1.3 shortly.
Thanks!
@Dmitry do you wish to be Cc: before release or any other time?Quoted 2 lines
Quoted 2 lines
Kind regards,
Petr
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
[1] https://bugs.debian.org/972459 linux: Reenable
CONFIG_IMAI wasn't aware that because of lockdown, IMA was disabled. Thank you for reporting and updating the IMA w/lockdown status.
Feel free to comment it, please. It'd be nice to have IMA in Debian (not sure about Ubuntu status).
I can help with the Ubuntu status. IMA is still enabled there. You can see CONFIG_IMA set to 'y' in the 20.04 LTS (Focal) and most recent 20.10 release (Groovy):
https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/focal/tree/debian.master/config/annotations#n12861
https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/groovy/tree/debian.master/config/annotations#n13173
Tyler
Quoted 8 lines
@Dmitry: do you plan to update Debian package? (you're the listed maintainer, although the package was signed by Wartan Hachaturow).
Quoted 1 line
Mimi
Kind regards,
Petr
27.10.2020 21:49, Tyler Hicks пишет:
Quoted 8 lines
I can help with the Ubuntu status. IMA is still enabled there. You can see
CONFIG_IMAset to 'y' in the 20.04 LTS (Focal) and most recent 20.10 release (Groovy):https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/focal/tree/debian.master/config/annotations#n12861
https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/groovy/tree/debian.master/config/annotations#n13173Tyler
Sorry for a bit offtop, by the way, does any Linux distro ship packages with IMA-signed files?
I know that work was done to support it in DEB and RPM and at least in RPM it was upstreamized.
We are going to try shipping IMA-signed packages in ROSA, it would be nice to study experience of other distros if there is any.
Mimi Zohar
maintainerHi Petr,
Quoted 15 lines · Mimi Zohar
Quoted 6 lines · Petr Vorel
This is required, because when TPM HW available (i.e. -c
/dev/tpm0), evmctlima_boot_aggregatereturns sha1:xxxx.skip requires to move
cleanup().Signed-off-by Petr Vorel <[email protected]>Nice.
Quoted 6 lines
---
Hi Mimi,this Fixes problems on current Debian, which has still disabled
CONFIG_IMA(FYI [1]). I was not able to figure out how to get it working with sample-* files, but maybe there is a way.
Moving the test down to within "if [ "$(id -u)" = 0 ] && [ -c "/dev/tpm0" ]; then" will allow the sample tests to work. I've modified your patch and pushed it out to next-testing.
thanks,
Mimi