Various fixes and extensions to Exynos4 clock driver
cover Various fixes and extensions to Exynos4 clock driver
This series is a collection of various fixes and extensions to Exynos4 clock driver, which improve coverage of clocks present on Exynos4 SoCs and fix problems discovered during our internal work and testing.
Andrzej Hajda (1):
clk: samsung: exynos4: Add missing CMU_TOP and ISP clocks
Lukasz Majewski (1):
clk: samsung: exynos4: Export clocks used by exynos cpufreq drivers
Sylwester Nawrocki (2):
clk: samsung: exynos4: Correct sclk_mfc clock definition
clk: samsung: exynos4: Add camera related clock definitions
Tomasz Figa (17):
clk: samsung: exynos4: Use mout_mpll_user_* on Exynos4x12
clk: samsung: exynos4: Add missing mout_mipihsi clock
clk: samsung: exynos4: Add missing sclk_audio0 clock
clk: samsung: exynos4: Export sclk_pcm0
clk: samsung: exynos4: Move dac and mixer to Exynos4210-specific
clocks
clk: samsung: pll: Remove unimplemented ops
clk: samsung: exynos4: Export mout_core clock of Exynos4210
clk: samsung: exynos4: Add G3D clocks
clk: samsung: exynos4: Add missing mout_sata on Exynos4210
clk: samsung: exynos4: Define {E,V}PLL registers
clk: samsung: exynos4: Use SRC_MASK_PERIL{0,1} definitions
clk: samsung: exynos4: Remove SoC-specific registers from save list
clk: samsung: exynos4: Add E4210 prefix to LCD1 clock registers
clk: samsung: exynos4: Add E4210 prefix to GATE_IP_PERIR register
clk: samsung: exynos4: Remove E4X12 prefix from SRC_DMC register
clk: samsung: exynos4: Add missing registers to suspend save list
clk: samsung: exynos4: Add support for SoC-specific register save list
.../devicetree/bindings/clock/exynos4-clock.txt | 61 ++- drivers/clk/samsung/clk-exynos4.c | 491 +++++++++++++++------ drivers/clk/samsung/clk-exynos5250.c | 3 +- drivers/clk/samsung/clk-exynos5440.c | 2 +- drivers/clk/samsung/clk-pll.c | 80 ---- drivers/clk/samsung/clk.c | 9 +- drivers/clk/samsung/clk.h | 3 +- 7 files changed, 437 insertions(+), 212 deletions(-)
Signature · 1 line
1.8.1.5
PATCH 1/21 clk: samsung: exynos4: Correct sclk_mfc clock definition
From: Sylwester Nawrocki <[email protected]>
This clock must be exported to allow lookup using device tree.
--- Documentation/devicetree/bindings/clock/exynos4-clock.txt | 2 +- drivers/clk/samsung/clk-exynos4.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/clock/exynos4-clock.txt +1 -1
@@ -91,7 +91,7 @@ Exynos4 SoC and this is specified where applicable. sclk_i2s1 167 sclk_i2s2 168 sclk_mipihsi 169 Exynos4412 - + sclk_mfc 170 [Peripheral Clock Gates]
drivers/clk/samsung/clk-exynos4.c +2 -2
@@ -122,7 +122,7 @@ enum exynos4_clks { sclk_sata, sclk_uart0, sclk_uart1, sclk_uart2, sclk_uart3, sclk_uart4, sclk_audio1, sclk_audio2, sclk_spdif, sclk_spi0, sclk_spi1, sclk_spi2, sclk_slimbus, sclk_fimd1, sclk_mipi1, sclk_pcm1, sclk_pcm2, sclk_i2s1, - sclk_i2s2, sclk_mipihsi, + sclk_i2s2, sclk_mipihsi, sclk_mfc,/* gate clocks */ fimc0 = 256, fimc1, fimc2, fimc3, csis0, csis1, jpeg, smmu_fimc0,
@@ -355,7 +355,7 @@ struct samsung_div_clock exynos4_div_clks[] __initdata = {DIV (none,"div_cam1" ,"mout_cam1" ,DIV_CAM ,20 ,4 ),DIV (none,"div_csis0" ,"mout_csis0" ,DIV_CAM ,24 ,4 ),DIV (none,"div_csis1" ,"mout_csis1" ,DIV_CAM ,28 ,4 ), -DIV (none,"div_mfc" ,"mout_mfc" ,DIV_MFC ,0 ,4 ), +DIV (sclk_mfc,"sclk_mfc" ,"mout_mfc" ,DIV_MFC ,0 ,4 ),DIV (none,"div_g3d" ,"mout_g3d" ,DIV_G3D ,0 ,4 ),DIV (none,"div_fimd0" ,"mout_fimd0" ,DIV_LCD0 ,0 ,4 ), DIV(none, "div_mipi0", "mout_mipi0", DIV_LCD0, 16, 4),
Signature · 1 line
1.8.1.5
PATCH 2/21 clk: samsung: exynos4: Use mout_mpll_user_* on Exynos4x12
In reply to Tomasz FigaMany clock muxes of Exynos 4x12 uses mout_mpll_user_* clocks instead of sclk_mpll as one of their parents.
This patch moves such clocks from common array into SoC-specific arrays and adjusts their parent lists respectively.
--- .../devicetree/bindings/clock/exynos4-clock.txt | 2 + drivers/clk/samsung/clk-exynos4.c | 172 +++++++++++++-------- 2 files changed, 113 insertions(+), 61 deletions(-)
Documentation/devicetree/bindings/clock/exynos4-clock.txt +2 -0
@@ -42,6 +42,8 @@ Exynos4 SoC and this is specified where applicable. aclk100 14 aclk160 15 aclk133 16 + mout_mpll_user_t 17 Exynos4x12 + mout_mpll_user_c 18 Exynos4x12 [Clock Gate for Special Clocks]
drivers/clk/samsung/clk-exynos4.c +111 -61
233 lines not on this page · raw message
Signature · 1 line
1.8.1.5
PATCH 3/21 clk: samsung: exynos4: Add missing mout_mipihsi clock
In reply to Tomasz FigaThis patch adds missing output of mux MIPIHSI which is needed for div_mipihsi clock.
--- drivers/clk/samsung/clk-exynos4.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/samsung/clk-exynos4.c +1 -0
@@ -381,6 +381,7 @@ struct samsung_mux_clock exynos4x12_mux_clks[] __initdata = {MUX (none,"mout_mmc2" , group1_p4x12,SRC_FSYS ,8 ,4 ),MUX (none,"mout_mmc3" , group1_p4x12,SRC_FSYS ,12 ,4 ),MUX (none,"mout_mmc4" , group1_p4x12,SRC_FSYS ,16 ,4 ), +MUX (none,"mout_mipihsi" , aclk_p4412,SRC_FSYS ,24 ,1 ),MUX (none,"mout_uart0" , group1_p4x12,SRC_PERIL0 ,0 ,4 ),MUX (none,"mout_uart1" , group1_p4x12,SRC_PERIL0 ,4 ,4 ), MUX(none, "mout_uart2", group1_p4x12, SRC_PERIL0, 8, 4),
Signature · 1 line
1.8.1.5
PATCH 4/21 clk: samsung: exynos4: Add missing sclk_audio0 clock
In reply to Tomasz FigaThis clock is a parent of mout_spdif and sclk_pcm0.
--- drivers/clk/samsung/clk-exynos4.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/clk/samsung/clk-exynos4.c +2 -0
@@ -508,6 +508,8 @@ struct samsung_gate_clock exynos4_gate_clks[] __initdata = { CLK_SET_RATE_PARENT, 0),GATE (sclk_mipi0,"sclk_mipi0" ,"div_mipi_pre0" ,SRC_MASK_LCD0 ,12 ,CLK_SET_RATE_PARENT ,0 ), +GATE (sclk_audio0,"sclk_audio0" ,"div_audio0" ,SRC_MASK_MAUDIO ,0 , +CLK_SET_RATE_PARENT ,0 ),GATE (sclk_audio1,"sclk_audio1" ,"div_audio1" ,0xc354 ,0 ,CLK_SET_RATE_PARENT ,0 ), GATE_D(vp, "s5p-mixer", "vp", "aclk160", GATE_IP_TV, 0, 0, 0),
Signature · 1 line
1.8.1.5
PATCH 5/21 clk: samsung: exynos4: Export sclk_pcm0
In reply to Tomasz FigaThis clock is used by PCM interface 0.
--- Documentation/devicetree/bindings/clock/exynos4-clock.txt | 1 + drivers/clk/samsung/clk-exynos4.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/clock/exynos4-clock.txt +1 -0
@@ -94,6 +94,7 @@ Exynos4 SoC and this is specified where applicable. sclk_i2s2 168 sclk_mipihsi 169 Exynos4412 sclk_mfc 170 + sclk_pcm0 171 [Peripheral Clock Gates]
drivers/clk/samsung/clk-exynos4.c +2 -2
@@ -122,7 +122,7 @@ enum exynos4_clks { sclk_sata, sclk_uart0, sclk_uart1, sclk_uart2, sclk_uart3, sclk_uart4, sclk_audio1, sclk_audio2, sclk_spdif, sclk_spi0, sclk_spi1, sclk_spi2, sclk_slimbus, sclk_fimd1, sclk_mipi1, sclk_pcm1, sclk_pcm2, sclk_i2s1, - sclk_i2s2, sclk_mipihsi, sclk_mfc, + sclk_i2s2, sclk_mipihsi, sclk_mfc, sclk_pcm0,/* gate clocks */ fimc0 = 256, fimc1, fimc2, fimc3, csis0, csis1, jpeg, smmu_fimc0,
@@ -411,7 +411,7 @@ struct samsung_div_clock exynos4_div_clks[] __initdata = {DIV (none,"div_fimd0" ,"mout_fimd0" ,DIV_LCD0 ,0 ,4 ),DIV (none,"div_mipi0" ,"mout_mipi0" ,DIV_LCD0 ,16 ,4 ),DIV (none,"div_audio0" ,"mout_audio0" ,DIV_MAUDIO ,0 ,4 ), -DIV (none,"div_pcm0" ,"sclk_audio0" ,DIV_MAUDIO ,4 ,8 ), +DIV (sclk_pcm0,"sclk_pcm0" ,"sclk_audio0" ,DIV_MAUDIO ,4 ,8 ),DIV (none,"div_mmc0" ,"mout_mmc0" ,DIV_FSYS1 ,0 ,4 ),DIV (none,"div_mmc1" ,"mout_mmc1" ,DIV_FSYS1 ,16 ,4 ), DIV(none, "div_mmc2", "mout_mmc2", DIV_FSYS2, 0, 4),
Signature · 1 line
1.8.1.5
PATCH 6/21 clk: samsung: exynos4: Move dac and mixer to Exynos4210-specific clocks
In reply to Tomasz FigaThe sclk_dac and sclk_mixer clocks are not present on Exynos4x12.
--- drivers/clk/samsung/clk-exynos4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/samsung/clk-exynos4.c +2 -2
@@ -483,8 +483,6 @@ struct samsung_gate_clock exynos4_gate_clks[] __initdata = {* of the clocks can be removed. */ GATE (sclk_hdmi,"sclk_hdmi" ,"mout_hdmi" ,SRC_MASK_TV ,0 ,0 ,0 ), -GATE (sclk_mixer,"sclk_mixer" ,"mout_mixer" ,SRC_MASK_TV ,4 ,0 ,0 ), -GATE (sclk_dac,"sclk_dac" ,"mout_dac" ,SRC_MASK_TV ,8 ,0 ,0 ),GATE (sclk_spdif,"sclk_spdif" ,"mout_spdif" ,0xc354 ,8 ,0 ,0 ),GATE (jpeg,"jpeg" ,"aclk160" ,GATE_IP_CAM ,6 ,0 ,0 ), GATE(mie0, "mie0", "aclk160", GATE_IP_LCD0, 1, 0, 0),
@@ -681,6 +679,8 @@ struct samsung_gate_clock exynos4210_gate_clks[] __initdata = { SRC_MASK_LCD1, 12, CLK_SET_RATE_PARENT, 0),GATE (sclk_sata,"sclk_sata" ,"div_sata" ,SRC_MASK_FSYS ,24 ,CLK_SET_RATE_PARENT ,0 ), +GATE (sclk_mixer,"sclk_mixer" ,"mout_mixer" ,SRC_MASK_TV ,4 ,0 ,0 ), +GATE (sclk_dac,"sclk_dac" ,"mout_dac" ,SRC_MASK_TV ,8 ,0 ,0 ),GATE_A (tsadc,"tsadc" ,"aclk100" ,GATE_IP_PERIL ,15 ,0 ,0 ,"adc" ),GATE_A (mct,"mct" ,"aclk100" ,GATE_IP_PERIR ,13 ,0 ,0 ,"mct" ), GATE_A(wdt, "watchdog", "aclk100", GATE_IP_PERIR, 14, 0, 0, "watchdog"),
Signature · 1 line
1.8.1.5
PATCH 7/21 clk: samsung: exynos4: Export clocks used by exynos cpufreq drivers
In reply to Tomasz FigaFrom: Lukasz Majewski <[email protected]>
This patch exports clocks used by Exynos cpufreq drivers to allow lookup using device tree. (Support to cpufreq drivers will be added in further patches.)
--- Documentation/devicetree/bindings/clock/exynos4-clock.txt | 2 ++ drivers/clk/samsung/clk-exynos4.c | 8 +++++--- 2 files changed, 7 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/clock/exynos4-clock.txt +2 -0
@@ -44,6 +44,8 @@ Exynos4 SoC and this is specified where applicable. aclk133 16 mout_mpll_user_t 17 Exynos4x12 mout_mpll_user_c 18 Exynos4x12 + mout_core 19 + mout_apll 20 [Clock Gate for Special Clocks]
drivers/clk/samsung/clk-exynos4.c +5 -3
@@ -112,7 +112,8 @@ enum exynos4_clks {/* core clocks */ xxti, xusbxti, fin_pll, fout_apll, fout_mpll, fout_epll, fout_vpll, sclk_apll, sclk_mpll, sclk_epll, sclk_vpll, arm_clk, aclk200, aclk100, - aclk160, aclk133, mout_mpll_user_t, mout_mpll_user_c,/* 18 */ + aclk160, aclk133, mout_mpll_user_t, mout_mpll_user_c, mout_core, + mout_apll,/* 20 */ /* gate for special clocks (sclk) */ sclk_fimc0 = 128, sclk_fimc1, sclk_fimc2, sclk_fimc3, sclk_cam0,
@@ -284,7 +285,8 @@ struct samsung_fixed_rate_clock exynos4210_fixed_rate_clks[] __initdata = {/* list of mux clocks supported in all exynos4 soc's */ struct samsung_mux_clock exynos4_mux_clks[]__initdata = { -MUX (none,"mout_apll" , mout_apll_p,SRC_CPU ,0 ,1 ), +MUX_F (mout_apll,"mout_apll" , mout_apll_p,SRC_CPU ,0 ,1 , +CLK_SET_RATE_PARENT ,0 ),MUX (none,"mout_hdmi" , mout_hdmi_p,SRC_TV ,0 ,1 ),MUX (none,"mout_mfc1" , sclk_evpll_p,SRC_MFC ,4 ,1 ),MUX (none,"mout_mfc" , mout_mfc_p,SRC_MFC ,8 ,1 ),
@@ -362,7 +364,7 @@ struct samsung_mux_clock exynos4x12_mux_clks[] __initdata = { E4X12_SRC_DMC, 12, 1, "sclk_mpll"),MUX_A (sclk_vpll,"sclk_vpll" , mout_vpll_p,SRC_TOP0 ,8 ,1 ,"sclk_vpll" ), -MUX (none,"mout_core" , mout_core_p4x12,SRC_CPU ,16 ,1 ), +MUX (mout_core,"mout_core" , mout_core_p4x12,SRC_CPU ,16 ,1 ),MUX (none,"mout_fimc0" , group1_p4x12,SRC_CAM ,0 ,4 ),MUX (none,"mout_fimc1" , group1_p4x12,SRC_CAM ,4 ,4 ), MUX(none, "mout_fimc2", group1_p4x12, SRC_CAM, 8, 4),
Signature · 1 line
1.8.1.5
PATCH 8/21 clk: samsung: pll: Remove unimplemented ops
In reply to Tomasz FigaUnimplemented clock operations should be simply omitted instead of returning error values.
This patch removes unimplemented PLL operations to fix problems caused by returning error code in round_rate callback.
--- drivers/clk/samsung/clk-pll.c | 80 ------------------------------------------- 1 file changed, 80 deletions(-)
drivers/clk/samsung/clk-pll.c +0 -80
@@ -49,24 +49,8 @@ static unsigned long samsung_pll35xx_recalc_rate(struct clk_hw *hw,return (unsigned long )fvco; } -/* todo: implement pl35xx clock round rate operation */ -static long samsung_pll35xx_round_rate (struct clk_hw *hw, -unsigned long drate,unsigned long *prate) -{ -return -ENOTSUPP ; -} - -/* todo: implement pl35xx clock set rate */ -static int samsung_pll35xx_set_rate (struct clk_hw *hw,unsigned long drate, -unsigned long prate) -{ -return -ENOTSUPP ; -} -static const struct clk_ops samsung_pll35xx_clk_ops = { .recalc_rate = samsung_pll35xx_recalc_rate, - .round_rate = samsung_pll35xx_round_rate, - .set_rate = samsung_pll35xx_set_rate, }; struct clk * __init samsung_clk_register_pll35xx(const char *name,
@@ -144,24 +128,8 @@ static unsigned long samsung_pll36xx_recalc_rate(struct clk_hw *hw,return (unsigned long )fvco; } -/* todo: implement pl36xx clock round rate operation */ -static long samsung_pll36xx_round_rate (struct clk_hw *hw, -unsigned long drate,unsigned long *prate) -{ -return -ENOTSUPP ; -} - -/* todo: implement pl36xx clock set rate */ -static int samsung_pll36xx_set_rate (struct clk_hw *hw,unsigned long drate, -unsigned long prate) -{ -return -ENOTSUPP ; -} -static const struct clk_ops samsung_pll36xx_clk_ops = { .recalc_rate = samsung_pll36xx_recalc_rate, - .round_rate = samsung_pll36xx_round_rate, - .set_rate = samsung_pll36xx_set_rate, }; struct clk * __init samsung_clk_register_pll36xx(const char *name,
@@ -239,24 +207,8 @@ static unsigned long samsung_pll45xx_recalc_rate(struct clk_hw *hw,return (unsigned long )fvco; } -/* todo: implement pl45xx clock round rate operation */ -static long samsung_pll45xx_round_rate (struct clk_hw *hw, -unsigned long drate,unsigned long *prate) -{ -return -ENOTSUPP ; -} - -/* todo: implement pl45xx clock set rate */ -static int samsung_pll45xx_set_rate (struct clk_hw *hw,unsigned long drate, -unsigned long prate) -{ -return -ENOTSUPP ; -} -static const struct clk_ops samsung_pll45xx_clk_ops = { .recalc_rate = samsung_pll45xx_recalc_rate, - .round_rate = samsung_pll45xx_round_rate, - .set_rate = samsung_pll45xx_set_rate, }; struct clk * __init samsung_clk_register_pll45xx(const char *name,
@@ -342,24 +294,8 @@ static unsigned long samsung_pll46xx_recalc_rate(struct clk_hw *hw,return (unsigned long )fvco; } -/* todo: implement pl46xx clock round rate operation */ -static long samsung_pll46xx_round_rate (struct clk_hw *hw, -unsigned long drate,unsigned long *prate) -{ -return -ENOTSUPP ; -} - -/* todo: implement pl46xx clock set rate */ -static int samsung_pll46xx_set_rate (struct clk_hw *hw,unsigned long drate, -unsigned long prate) -{ -return -ENOTSUPP ; -} -static const struct clk_ops samsung_pll46xx_clk_ops = { .recalc_rate = samsung_pll46xx_recalc_rate, - .round_rate = samsung_pll46xx_round_rate, - .set_rate = samsung_pll46xx_set_rate, }; struct clk * __init samsung_clk_register_pll46xx(const char *name,
@@ -441,24 +377,8 @@ static unsigned long samsung_pll2550x_recalc_rate(struct clk_hw *hw,return (unsigned long )fvco; } -/* todo: implement pl2550x clock round rate operation */ -static long samsung_pll2550x_round_rate (struct clk_hw *hw, -unsigned long drate,unsigned long *prate) -{ -return -ENOTSUPP ; -} - -/* todo: implement pl2550x clock set rate */ -static int samsung_pll2550x_set_rate (struct clk_hw *hw,unsigned long drate, -unsigned long prate) -{ -return -ENOTSUPP ; -} -static const struct clk_ops samsung_pll2550x_clk_ops = { .recalc_rate = samsung_pll2550x_recalc_rate, - .round_rate = samsung_pll2550x_round_rate, - .set_rate = samsung_pll2550x_set_rate, }; struct clk * __init samsung_clk_register_pll2550x(const char *name,
Signature · 1 line
1.8.1.5
PATCH 9/21 clk: samsung: exynos4: Export mout_core clock of Exynos4210
In reply to Tomasz FigaThis patch enables clock lookup registration for mout_core clock used in Exynos4210 cpufreq driver.
--- drivers/clk/samsung/clk-exynos4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/samsung/clk-exynos4.c +1 -1
@@ -311,7 +311,7 @@ struct samsung_mux_clock exynos4210_mux_clks[] __initdata = {MUX (none,"mout_fimd1" , group1_p4210,SRC_LCD1 ,0 ,4 ),MUX (none,"mout_mipi1" , group1_p4210,SRC_LCD1 ,12 ,4 ),MUX_A (sclk_mpll,"sclk_mpll" , mout_mpll_p,SRC_CPU ,8 ,1 ,"sclk_mpll" ), -MUX (none,"mout_core" , mout_core_p4210,SRC_CPU ,16 ,1 ), +MUX_A (mout_core,"mout_core" , mout_core_p4210,SRC_CPU ,16 ,1 ,"mout_core" ),MUX_A (sclk_vpll,"sclk_vpll" , sclk_vpll_p4210,SRC_TOP0 ,8 ,1 ,"sclk_vpll" ), MUX(none, "mout_fimc0", group1_p4210, SRC_CAM, 0, 4),
Signature · 1 line
1.8.1.5
PATCH 10/21 clk: samsung: exynos4: Add camera related clock definitions
In reply to Tomasz FigaFrom: Sylwester Nawrocki <[email protected]>
This patch adds several gate and mux clocks related to camera and ISP blocks.
--- .../devicetree/bindings/clock/exynos4-clock.txt | 20 +++++++++ drivers/clk/samsung/clk-exynos4.c | 50 ++++++++++++++-------- 2 files changed, 53 insertions(+), 17 deletions(-)
Documentation/devicetree/bindings/clock/exynos4-clock.txt +20 -0
@@ -198,6 +198,26 @@ Exynos4 SoC and this is specified where applicable. audss 348 mipi_hsi 349 Exynos4210 mdma2 350 Exynos4210 + pixelasyncm0 351 + pixelasyncm1 352 + fimc_lite0 353 Exynos4x12 + fimc_lite1 354 Exynos4x12 + ppmuispx 355 Exynos4x12 + ppmuispmx 356 Exynos4x12 + + [Mux Clocks] + + Clock ID SoC (if specific) + ----------------------------------------------- + + mout_fimc0 384 + mout_fimc1 385 + mout_fimc2 386 + mout_fimc3 387 + mout_cam0 388 + mout_cam1 389 + mout_csis0 390 + mout_csis1 391 Example 1: An example of a clock controller node is listed below.
drivers/clk/samsung/clk-exynos4.c +33 -17
86 lines not on this page · raw message
Signature · 1 line
1.8.1.5
PATCH 11/21 clk: samsung: exynos4: Add G3D clocks
In reply to Tomasz FigaThis patch adds clocks needed for G3D block present on Exynos 4 SoCs.
--- .../devicetree/bindings/clock/exynos4-clock.txt | 4 ++++ drivers/clk/samsung/clk-exynos4.c | 22 ++++++++++++++-------- 2 files changed, 18 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/clock/exynos4-clock.txt +4 -0
@@ -97,6 +97,7 @@ Exynos4 SoC and this is specified where applicable. sclk_mipihsi 169 Exynos4412 sclk_mfc 170 sclk_pcm0 171 + sclk_g3d 172 [Peripheral Clock Gates]
@@ -218,6 +219,9 @@ Exynos4 SoC and this is specified where applicable. mout_cam1 389 mout_csis0 390 mout_csis1 391 + mout_g3d0 392 + mout_g3d1 393 + mout_g3d 394 Example 1: An example of a clock controller node is listed below.
drivers/clk/samsung/clk-exynos4.c +14 -8
@@ -124,7 +124,7 @@ enum exynos4_clks { sclk_sata, sclk_uart0, sclk_uart1, sclk_uart2, sclk_uart3, sclk_uart4, sclk_audio1, sclk_audio2, sclk_spdif, sclk_spi0, sclk_spi1, sclk_spi2, sclk_slimbus, sclk_fimd1, sclk_mipi1, sclk_pcm1, sclk_pcm2, sclk_i2s1, - sclk_i2s2, sclk_mipihsi, sclk_mfc, sclk_pcm0, + sclk_i2s2, sclk_mipihsi, sclk_mfc, sclk_pcm0, sclk_g3d,/* gate clocks */ fimc0 = 256, fimc1, fimc2, fimc3, csis0, csis1, jpeg, smmu_fimc0,
@@ -142,7 +142,7 @@ enum exynos4_clks {/* mux clocks */ mout_fimc0 =384 , mout_fimc1, mout_fimc2, mout_fimc3, mout_cam0, - mout_cam1, mout_csis0, mout_csis1, + mout_cam1, mout_csis0, mout_csis1, mout_g3d0, mout_g3d1, mout_g3d, nr_clks, };
@@ -296,8 +296,10 @@ struct samsung_mux_clock exynos4_mux_clks[] __initdata = {MUX (none,"mout_hdmi" , mout_hdmi_p,SRC_TV ,0 ,1 ),MUX (none,"mout_mfc1" , sclk_evpll_p,SRC_MFC ,4 ,1 ),MUX (none,"mout_mfc" , mout_mfc_p,SRC_MFC ,8 ,1 ), -MUX (none,"mout_g3d1" , sclk_evpll_p,SRC_G3D ,4 ,1 ), -MUX (none,"mout_g3d" , mout_g3d_p,SRC_G3D ,8 ,1 ), +MUX_F (mout_g3d1,"mout_g3d1" , sclk_evpll_p,SRC_G3D ,4 ,1 , +CLK_SET_RATE_PARENT ,0 ), +MUX_F (mout_g3d,"mout_g3d" , mout_g3d_p,SRC_G3D ,8 ,1 , +CLK_SET_RATE_PARENT ,0 ),MUX (none,"mout_spdif" , mout_spdif_p,SRC_PERIL1 ,8 ,2 ), MUX_A(sclk_epll, "sclk_epll", mout_epll_p, SRC_TOP0, 4, 1, "sclk_epll"), };
@@ -329,7 +331,8 @@ struct samsung_mux_clock exynos4210_mux_clks[] __initdata = {MUX (mout_csis0,"mout_csis0" , group1_p4210,SRC_CAM ,24 ,4 ),MUX (mout_csis1,"mout_csis1" , group1_p4210,SRC_CAM ,28 ,4 ),MUX (none,"mout_mfc0" , sclk_ampll_p4210,SRC_MFC ,0 ,1 ), -MUX (none,"mout_g3d0" , sclk_ampll_p4210,SRC_G3D ,0 ,1 ), +MUX_F (mout_g3d0,"mout_g3d0" , sclk_ampll_p4210,SRC_G3D ,0 ,1 , +CLK_SET_RATE_PARENT ,0 ),MUX (none,"mout_fimd0" , group1_p4210,SRC_LCD0 ,0 ,4 ),MUX (none,"mout_mipi0" , group1_p4210,SRC_LCD0 ,12 ,4 ), MUX(none, "mout_audio0", mout_audio0_p4210, SRC_MAUDIO, 0, 4),
@@ -380,7 +383,8 @@ struct samsung_mux_clock exynos4x12_mux_clks[] __initdata = {MUX (mout_csis0,"mout_csis0" , group1_p4x12,SRC_CAM ,24 ,4 ),MUX (mout_csis1,"mout_csis1" , group1_p4x12,SRC_CAM ,28 ,4 ),MUX (none,"mout_mfc0" , sclk_ampll_p4x12,SRC_MFC ,0 ,1 ), -MUX (none,"mout_g3d0" , sclk_ampll_p4x12,SRC_G3D ,0 ,1 ), +MUX_F (mout_g3d0,"mout_g3d0" , sclk_ampll_p4x12,SRC_G3D ,0 ,1 , +CLK_SET_RATE_PARENT ,0 ),MUX (none,"mout_fimd0" , group1_p4x12,SRC_LCD0 ,0 ,4 ),MUX (none,"mout_mipi0" , group1_p4x12,SRC_LCD0 ,12 ,4 ), MUX(none, "mout_audio0", mout_audio0_p4x12, SRC_MAUDIO, 0, 4),
@@ -415,7 +419,8 @@ struct samsung_div_clock exynos4_div_clks[] __initdata = {DIV (none,"div_csis0" ,"mout_csis0" ,DIV_CAM ,24 ,4 ),DIV (none,"div_csis1" ,"mout_csis1" ,DIV_CAM ,28 ,4 ),DIV (sclk_mfc,"sclk_mfc" ,"mout_mfc" ,DIV_MFC ,0 ,4 ), -DIV (none,"div_g3d" ,"mout_g3d" ,DIV_G3D ,0 ,4 ), +DIV_F (none,"div_g3d" ,"mout_g3d" ,DIV_G3D ,0 ,4 , +CLK_SET_RATE_PARENT ,0 ),DIV (none,"div_fimd0" ,"mout_fimd0" ,DIV_LCD0 ,0 ,4 ),DIV (none,"div_mipi0" ,"mout_mipi0" ,DIV_LCD0 ,16 ,4 ), DIV(none, "div_audio0", "mout_audio0", DIV_MAUDIO, 0, 4),
@@ -501,7 +506,8 @@ struct samsung_gate_clock exynos4_gate_clks[] __initdata = {GATE (smmu_fimd1,"smmu_fimd1" ,"aclk160" ,GATE_IP_LCD1 ,4 ,0 ,0 ),GATE (tsi,"tsi" ,"aclk133" ,GATE_IP_FSYS ,4 ,0 ,0 ),GATE (sromc,"sromc" ,"aclk133" ,GATE_IP_FSYS ,11 ,0 ,0 ), -GATE (g3d,"g3d" ,"aclk200" ,GATE_IP_G3D ,0 ,0 ,0 ), +GATE (sclk_g3d,"sclk_g3d" ,"div_g3d" ,GATE_IP_G3D ,0 , +CLK_SET_RATE_PARENT ,0 ),GATE (usb_device,"usb_device" ,"aclk133" ,GATE_IP_FSYS ,13 ,0 ,0 ),GATE (onenand,"onenand" ,"aclk133" ,GATE_IP_FSYS ,15 ,0 ,0 ), GATE(nfcon, "nfcon", "aclk133", GATE_IP_FSYS, 16, 0, 0),
Signature · 1 line
1.8.1.5
PATCH 12/21 clk: samsung: exynos4: Add missing CMU_TOP and ISP clocks
In reply to Tomasz FigaFrom: Andrzej Hajda <[email protected]>
The patch adds missing clocks to TOP and ISP clock domains. It also adds clock gates for ISP sub-blocks.
--- .../devicetree/bindings/clock/exynos4-clock.txt | 30 ++++++ drivers/clk/samsung/clk-exynos4.c | 110 ++++++++++++++++++++- 2 files changed, 137 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/clock/exynos4-clock.txt +30 -0
@@ -98,6 +98,10 @@ Exynos4 SoC and this is specified where applicable. sclk_mfc 170 sclk_pcm0 171 sclk_g3d 172 + sclk_pwm_isp 173 Exynos4x12 + sclk_spi0_isp 174 Exynos4x12 + sclk_spi1_isp 175 Exynos4x12 + sclk_uart_isp 176 Exynos4x12 [Peripheral Clock Gates]
@@ -205,6 +209,32 @@ Exynos4 SoC and this is specified where applicable. fimc_lite1 354 Exynos4x12 ppmuispx 355 Exynos4x12 ppmuispmx 356 Exynos4x12 + fimc_isp 357 Exynos4x12 + fimc_drc 358 Exynos4x12 + fimc_fd 359 Exynos4x12 + mcuisp 360 Exynos4x12 + gicisp 361 Exynos4x12 + smmu_isp 362 Exynos4x12 + smmu_drc 363 Exynos4x12 + smmu_fd 364 Exynos4x12 + smmu_lite0 365 Exynos4x12 + smmu_lite1 366 Exynos4x12 + mcuctl_isp 367 Exynos4x12 + mpwm_isp 368 Exynos4x12 + i2c0_isp 369 Exynos4x12 + i2c1_isp 370 Exynos4x12 + mtcadc_isp 371 Exynos4x12 + pwm_isp 372 Exynos4x12 + wdt_isp 373 Exynos4x12 + uart_isp 374 Exynos4x12 + asyncaxim 375 Exynos4x12 + smmu_ispcx 376 Exynos4x12 + spi0_isp 377 Exynos4x12 + spi1_isp 378 Exynos4x12 + pwm_isp_sclk 379 Exynos4x12 + spi0_isp_sclk 380 Exynos4x12 + spi1_isp_sclk 381 Exynos4x12 + uart_isp_sclk 382 Exynos4x12 [Mux Clocks]
drivers/clk/samsung/clk-exynos4.c +107 -3
221 lines not on this page · raw message
Signature · 1 line
1.8.1.5
PATCH 13/21 clk: samsung: exynos4: Add missing mout_sata on Exynos4210
In reply to Tomasz FigaThis patch adds missing mout_sata that is a parent of div_sata clock.
--- drivers/clk/samsung/clk-exynos4.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/samsung/clk-exynos4.c +1 -0
@@ -359,6 +359,7 @@ struct samsung_mux_clock exynos4210_mux_clks[] __initdata = {MUX (none,"mout_mmc2" , group1_p4210,SRC_FSYS ,8 ,4 ),MUX (none,"mout_mmc3" , group1_p4210,SRC_FSYS ,12 ,4 ),MUX (none,"mout_mmc4" , group1_p4210,SRC_FSYS ,16 ,4 ), +MUX (none,"mout_sata" , sclk_ampll_p4210,SRC_FSYS ,24 ,1 ),MUX (none,"mout_uart0" , group1_p4210,SRC_PERIL0 ,0 ,4 ),MUX (none,"mout_uart1" , group1_p4210,SRC_PERIL0 ,4 ,4 ), MUX(none, "mout_uart2", group1_p4210, SRC_PERIL0, 8, 4),
Signature · 1 line
1.8.1.5
PATCH 14/21 clk: samsung: exynos4: Define {E,V}PLL registers
In reply to Tomasz FigaThis patch adds preprocessor definitions of EPLL and VPLL registers and replaces all occurences of offsets of related registers with new definitions.
--- drivers/clk/samsung/clk-exynos4.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
drivers/clk/samsung/clk-exynos4.c +12 -4
@@ -25,6 +25,14 @@#define E4X12_GATE_IP_IMAGE 0x4930#define GATE_IP_RIGHTBUS 0x8800#define E4X12_GATE_IP_PERIR 0x8960 +#define EPLL_LOCK 0xc010 +#define VPLL_LOCK 0xc020 +#define EPLL_CON0 0xc110 +#define EPLL_CON1 0xc114 +#define EPLL_CON2 0xc118 +#define VPLL_CON0 0xc120 +#define VPLL_CON1 0xc124 +#define VPLL_CON2 0xc128#define SRC_TOP0 0xc210#define SRC_TOP1 0xc214#define SRC_CAM 0xc220
@@ -968,18 +976,18 @@ void __init exynos4_clk_init(struct device_node *np) mpll =samsung_clk_register_pll45xx ("fout_mpll" ,"fin_pll" , reg_base +E4210_MPLL_CON0 , pll_4508); epll =samsung_clk_register_pll46xx ("fout_epll" ,"fin_pll" , - reg_base +0xc110 , pll_4600); + reg_base +EPLL_CON0 , pll_4600); vpll =samsung_clk_register_pll46xx ("fout_vpll" ,"mout_vpllsrc" , - reg_base +0xc120 , pll_4650c); + reg_base +VPLL_CON0 , pll_4650c); }else { apll =samsung_clk_register_pll35xx ("fout_apll" ,"fin_pll" , reg_base +APLL_CON0 ); mpll =samsung_clk_register_pll35xx ("fout_mpll" ,"fin_pll" , reg_base +E4X12_MPLL_CON0 ); epll =samsung_clk_register_pll36xx ("fout_epll" ,"fin_pll" , - reg_base +0xc110 ); + reg_base +EPLL_CON0 ); vpll =samsung_clk_register_pll36xx ("fout_vpll" ,"fin_pll" , - reg_base +0xc120 ); + reg_base +VPLL_CON0 ); }samsung_clk_add_lookup (apll, fout_apll);
Signature · 1 line
1.8.1.5
PATCH 15/21 clk: samsung: exynos4: Use SRC_MASK_PERIL{0,1} definitions
In reply to Tomasz FigaThere are definitions of SRC_MASK_PERIL0 and SRC_MASK_PERIL1 registers, but they are not used for clock definitions. This patch modifies related clock definitions to use defined macros instead of numeric offsets.
--- drivers/clk/samsung/clk-exynos4.c | 30 +++++++++++++++++++----------- 1 file changed, 19 insertions(+), 11 deletions(-)
drivers/clk/samsung/clk-exynos4.c +19 -11
@@ -549,7 +549,7 @@ struct samsung_gate_clock exynos4_gate_clks[] __initdata = {* of the clocks can be removed. */ GATE (sclk_hdmi,"sclk_hdmi" ,"mout_hdmi" ,SRC_MASK_TV ,0 ,0 ,0 ), -GATE (sclk_spdif,"sclk_spdif" ,"mout_spdif" ,0xc354 ,8 ,0 ,0 ), +GATE (sclk_spdif,"sclk_spdif" ,"mout_spdif" ,SRC_MASK_PERIL1 ,8 ,0 ,0 ),GATE (jpeg,"jpeg" ,"aclk160" ,GATE_IP_CAM ,6 ,0 ,0 ),GATE (mie0,"mie0" ,"aclk160" ,GATE_IP_LCD0 ,1 ,0 ,0 ), GATE(dsim0, "dsim0", "aclk160", GATE_IP_LCD0, 3, 0, 0),
@@ -575,7 +575,7 @@ struct samsung_gate_clock exynos4_gate_clks[] __initdata = { SRC_MASK_LCD0, 12, CLK_SET_RATE_PARENT, 0),GATE (sclk_audio0,"sclk_audio0" ,"div_audio0" ,SRC_MASK_MAUDIO ,0 ,CLK_SET_RATE_PARENT ,0 ), -GATE (sclk_audio1,"sclk_audio1" ,"div_audio1" ,0xc354 ,0 , +GATE (sclk_audio1,"sclk_audio1" ,"div_audio1" ,SRC_MASK_PERIL1 ,0 ,CLK_SET_RATE_PARENT ,0 ),GATE_D (vp,"s5p-mixer" ,"vp" ,"aclk160" ,GATE_IP_TV ,0 ,0 ,0 ), GATE_D(mixer, "s5p-mixer", "mixer", "aclk160", GATE_IP_TV, 1, 0, 0),
@@ -613,23 +613,31 @@ struct samsung_gate_clock exynos4_gate_clks[] __initdata = {GATE_DA (sclk_mmc4,NULL ,"sclk_mmc4" ,"div_mmc_pre4" ,SRC_MASK_FSYS ,16 ,CLK_SET_RATE_PARENT ,0 ,"ciu" ),GATE_DA (sclk_uart0,"exynos4210-uart.0" ,"uclk0" ,"div_uart0" , -0xc350 ,0 ,CLK_SET_RATE_PARENT ,0 ,"clk_uart_baud0" ), +SRC_MASK_PERIL0 ,0 ,CLK_SET_RATE_PARENT , +0 ,"clk_uart_baud0" ),GATE_DA (sclk_uart1,"exynos4210-uart.1" ,"uclk1" ,"div_uart1" , -0xc350 ,4 ,CLK_SET_RATE_PARENT ,0 ,"clk_uart_baud0" ), +SRC_MASK_PERIL0 ,4 ,CLK_SET_RATE_PARENT , +0 ,"clk_uart_baud0" ),GATE_DA (sclk_uart2,"exynos4210-uart.2" ,"uclk2" ,"div_uart2" , -0xc350 ,8 ,CLK_SET_RATE_PARENT ,0 ,"clk_uart_baud0" ), +SRC_MASK_PERIL0 ,8 ,CLK_SET_RATE_PARENT , +0 ,"clk_uart_baud0" ),GATE_DA (sclk_uart3,"exynos4210-uart.3" ,"uclk3" ,"div_uart3" , -0xc350 ,12 ,CLK_SET_RATE_PARENT ,0 ,"clk_uart_baud0" ), +SRC_MASK_PERIL0 ,12 ,CLK_SET_RATE_PARENT , +0 ,"clk_uart_baud0" ),GATE_DA (sclk_uart4,"exynos4210-uart.4" ,"uclk4" ,"div_uart4" , -0xc350 ,16 ,CLK_SET_RATE_PARENT ,0 ,"clk_uart_baud0" ), -GATE (sclk_audio2,"sclk_audio2" ,"div_audio2" ,0xc354 ,4 , +SRC_MASK_PERIL0 ,16 ,CLK_SET_RATE_PARENT , +0 ,"clk_uart_baud0" ), +GATE (sclk_audio2,"sclk_audio2" ,"div_audio2" ,SRC_MASK_PERIL1 ,4 ,CLK_SET_RATE_PARENT ,0 ),GATE_DA (sclk_spi0,"exynos4210-spi.0" ,"sclk_spi0" ,"div_spi_pre0" , -0xc354 ,16 ,CLK_SET_RATE_PARENT ,0 ,"spi_busclk0" ), +SRC_MASK_PERIL1 ,16 ,CLK_SET_RATE_PARENT , +0 ,"spi_busclk0" ),GATE_DA (sclk_spi1,"exynos4210-spi.1" ,"sclk_spi1" ,"div_spi_pre1" , -0xc354 ,20 ,CLK_SET_RATE_PARENT ,0 ,"spi_busclk0" ), +SRC_MASK_PERIL1 ,20 ,CLK_SET_RATE_PARENT , +0 ,"spi_busclk0" ),GATE_DA (sclk_spi2,"exynos4210-spi.2" ,"sclk_spi2" ,"div_spi_pre2" , -0xc354 ,24 ,CLK_SET_RATE_PARENT ,0 ,"spi_busclk0" ), +SRC_MASK_PERIL1 ,24 ,CLK_SET_RATE_PARENT , +0 ,"spi_busclk0" ),GATE_DA (fimc0,"exynos4-fimc.0" ,"fimc0" ,"aclk160" ,GATE_IP_CAM ,0 ,0 ,0 ,"fimc" ), GATE_DA(fimc1, "exynos4-fimc.1", "fimc1", "aclk160",
Signature · 1 line
1.8.1.5
PATCH 16/21 clk: samsung: exynos4: Remove SoC-specific registers from save list
In reply to Tomasz FigaCurrent clock save list is shared for all Exynos4 SoCs, so it must contain only registers present in all supported SoCs, because accessing unavailable registers might have undefined effect.
This patch removes registers specific for particular SoCs from shared save list, as they should be supported by separate SoC-specific lists.
--- drivers/clk/samsung/clk-exynos4.c | 16 ---------------- 1 file changed, 16 deletions(-)
drivers/clk/samsung/clk-exynos4.c +0 -16
@@ -172,27 +172,21 @@ enum exynos4_clks {*/ static __initdata unsigned long exynos4_clk_regs[] = {SRC_LEFTBUS , -E4X12_GATE_IP_IMAGE ,GATE_IP_RIGHTBUS , -E4X12_GATE_IP_PERIR ,SRC_TOP0 ,SRC_TOP1 ,SRC_CAM ,SRC_TV ,SRC_MFC ,SRC_G3D , -E4210_SRC_IMAGE ,SRC_LCD0 , -SRC_LCD1 ,SRC_MAUDIO ,SRC_FSYS ,SRC_PERIL0 ,SRC_PERIL1 , -E4X12_SRC_CAM1 ,SRC_MASK_CAM ,SRC_MASK_TV ,SRC_MASK_LCD0 , -SRC_MASK_LCD1 ,SRC_MASK_MAUDIO ,SRC_MASK_FSYS ,SRC_MASK_PERIL0 ,
@@ -204,8 +198,6 @@ static __initdata unsigned long exynos4_clk_regs[] = {DIV_G3D ,DIV_IMAGE ,DIV_LCD0 , -E4210_DIV_LCD1 , -E4X12_DIV_ISP ,DIV_MAUDIO ,DIV_FSYS0 , DIV_FSYS1,
@@ -217,24 +209,16 @@ static __initdata unsigned long exynos4_clk_regs[] = {DIV_PERIL3 ,DIV_PERIL4 ,DIV_PERIL5 , -E4X12_DIV_CAM1 ,GATE_SCLK_CAM ,GATE_IP_CAM ,GATE_IP_TV ,GATE_IP_MFC ,GATE_IP_G3D , -E4210_GATE_IP_IMAGE ,GATE_IP_LCD0 , -GATE_IP_LCD1 , -E4X12_GATE_IP_MAUDIO ,GATE_IP_FSYS ,GATE_IP_GPS ,GATE_IP_PERIL , -GATE_IP_PERIR , -E4X12_MPLL_CON0 , -E4X12_SRC_DMC ,APLL_CON0 , -E4210_MPLL_CON0 ,SRC_CPU , DIV_CPU0, };
Signature · 1 line
1.8.1.5
PATCH 17/21 clk: samsung: exynos4: Add E4210 prefix to LCD1 clock registers
In reply to Tomasz FigaThis patch adds E4210 prefix to all registers related to LCD1 clock domain, because they are present only on Exynos4210.
--- drivers/clk/samsung/clk-exynos4.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/clk/samsung/clk-exynos4.c +11 -11
@@ -41,7 +41,7 @@#define SRC_G3D 0xc22c#define E4210_SRC_IMAGE 0xc230#define SRC_LCD0 0xc234 -#define SRC_LCD1 0xc238 +#define E4210_SRC_LCD1 0xc238#define E4X12_SRC_ISP 0xc238#define SRC_MAUDIO 0xc23c#define SRC_FSYS 0xc240
@@ -51,7 +51,7 @@#define SRC_MASK_CAM 0xc320#define SRC_MASK_TV 0xc324#define SRC_MASK_LCD0 0xc334 -#define SRC_MASK_LCD1 0xc338 +#define E4210_SRC_MASK_LCD1 0xc338#define E4X12_SRC_MASK_ISP 0xc338#define SRC_MASK_MAUDIO 0xc33c#define SRC_MASK_FSYS 0xc340
@@ -85,7 +85,7 @@#define GATE_IP_G3D 0xc92c#define E4210_GATE_IP_IMAGE 0xc930#define GATE_IP_LCD0 0xc934 -#define GATE_IP_LCD1 0xc938 +#define E4210_GATE_IP_LCD1 0xc938#define E4X12_GATE_IP_ISP 0xc938#define E4X12_GATE_IP_MAUDIO 0xc93c#define GATE_IP_FSYS 0xc940
@@ -326,8 +326,8 @@ struct samsung_mux_clock exynos4210_mux_clks[] __initdata = {MUX (none,"mout_g2d0" , sclk_ampll_p4210,E4210_SRC_IMAGE ,0 ,1 ),MUX (none,"mout_g2d1" , sclk_evpll_p,E4210_SRC_IMAGE ,4 ,1 ),MUX (none,"mout_g2d" , mout_g2d_p,E4210_SRC_IMAGE ,8 ,1 ), -MUX (none,"mout_fimd1" , group1_p4210,SRC_LCD1 ,0 ,4 ), -MUX (none,"mout_mipi1" , group1_p4210,SRC_LCD1 ,12 ,4 ), +MUX (none,"mout_fimd1" , group1_p4210,E4210_SRC_LCD1 ,0 ,4 ), +MUX (none,"mout_mipi1" , group1_p4210,E4210_SRC_LCD1 ,12 ,4 ),MUX_A (sclk_mpll,"sclk_mpll" , mout_mpll_p,SRC_CPU ,8 ,1 ,"sclk_mpll" ),MUX_A (mout_core,"mout_core" , mout_core_p4210,SRC_CPU ,16 ,1 ,"mout_core" ), MUX_A(sclk_vpll, "sclk_vpll", sclk_vpll_p4210,
@@ -537,10 +537,10 @@ struct samsung_gate_clock exynos4_gate_clks[] __initdata = {GATE (jpeg,"jpeg" ,"aclk160" ,GATE_IP_CAM ,6 ,0 ,0 ),GATE (mie0,"mie0" ,"aclk160" ,GATE_IP_LCD0 ,1 ,0 ,0 ),GATE (dsim0,"dsim0" ,"aclk160" ,GATE_IP_LCD0 ,3 ,0 ,0 ), -GATE (fimd1,"fimd1" ,"aclk160" ,GATE_IP_LCD1 ,0 ,0 ,0 ), -GATE (mie1,"mie1" ,"aclk160" ,GATE_IP_LCD1 ,1 ,0 ,0 ), -GATE (dsim1,"dsim1" ,"aclk160" ,GATE_IP_LCD1 ,3 ,0 ,0 ), -GATE (smmu_fimd1,"smmu_fimd1" ,"aclk160" ,GATE_IP_LCD1 ,4 ,0 ,0 ), +GATE (fimd1,"fimd1" ,"aclk160" ,E4210_GATE_IP_LCD1 ,0 ,0 ,0 ), +GATE (mie1,"mie1" ,"aclk160" ,E4210_GATE_IP_LCD1 ,1 ,0 ,0 ), +GATE (dsim1,"dsim1" ,"aclk160" ,E4210_GATE_IP_LCD1 ,3 ,0 ,0 ), +GATE (smmu_fimd1,"smmu_fimd1" ,"aclk160" ,E4210_GATE_IP_LCD1 ,4 ,0 ,0 ),GATE (tsi,"tsi" ,"aclk133" ,GATE_IP_FSYS ,4 ,0 ,0 ),GATE (sromc,"sromc" ,"aclk133" ,GATE_IP_FSYS ,11 ,0 ,0 ), GATE(sclk_g3d, "sclk_g3d", "div_g3d", GATE_IP_G3D, 0,
@@ -737,7 +737,7 @@ struct samsung_gate_clock exynos4210_gate_clks[] __initdata = {GATE (smmu_rotator,"smmu_rotator" ,"aclk200" ,E4210_GATE_IP_IMAGE ,4 ,0 ,0 ),GATE (sclk_mipi1,"sclk_mipi1" ,"div_mipi_pre1" , -SRC_MASK_LCD1 ,12 ,CLK_SET_RATE_PARENT ,0 ), +E4210_SRC_MASK_LCD1 ,12 ,CLK_SET_RATE_PARENT ,0 ),GATE (sclk_sata,"sclk_sata" ,"div_sata" ,SRC_MASK_FSYS ,24 ,CLK_SET_RATE_PARENT ,0 ), GATE(sclk_mixer, "sclk_mixer", "mout_mixer", SRC_MASK_TV, 4, 0, 0),
@@ -748,7 +748,7 @@ struct samsung_gate_clock exynos4210_gate_clks[] __initdata = {GATE_A (rtc,"rtc" ,"aclk100" ,GATE_IP_PERIR ,15 ,0 ,0 ,"rtc" ),GATE_A (keyif,"keyif" ,"aclk100" ,GATE_IP_PERIR ,16 ,0 ,0 ,"keypad" ),GATE_DA (sclk_fimd1,"exynos4-fb.1" ,"sclk_fimd1" ,"div_fimd1" , - SRC_MASK_LCD1, 0, CLK_SET_RATE_PARENT, 0, "sclk_fimd"), + E4210_SRC_MASK_LCD1, 0, CLK_SET_RATE_PARENT, 0, "sclk_fimd"), };/* list of gate clocks supported in exynos4x12 soc */
Signature · 1 line
1.8.1.5
PATCH 18/21 clk: samsung: exynos4: Add E4210 prefix to GATE_IP_PERIR register
In reply to Tomasz FigaThis definition is specific for Exynos4210 (which has another location than the same register on Exynos4x12 SoCs) and so needs appropriate prefix.
--- drivers/clk/samsung/clk-exynos4.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/clk/samsung/clk-exynos4.c +8 -8
@@ -91,7 +91,7 @@#define GATE_IP_FSYS 0xc940#define GATE_IP_GPS 0xc94c#define GATE_IP_PERIL 0xc950 -#define GATE_IP_PERIR 0xc960 +#define E4210_GATE_IP_PERIR 0xc960#define E4X12_MPLL_CON0 0x10108#define E4X12_SRC_DMC 0x10200#define APLL_CON0 0x14100
@@ -731,9 +731,9 @@ struct samsung_gate_clock exynos4210_gate_clks[] __initdata = {GATE (pcie,"pcie" ,"aclk133" ,GATE_IP_FSYS ,14 ,0 ,0 ),GATE (smmu_pcie,"smmu_pcie" ,"aclk133" ,GATE_IP_FSYS ,18 ,0 ,0 ),GATE (modemif,"modemif" ,"aclk100" ,GATE_IP_PERIL ,28 ,0 ,0 ), -GATE (chipid,"chipid" ,"aclk100" ,GATE_IP_PERIR ,0 ,0 ,0 ), -GATE (sysreg,"sysreg" ,"aclk100" ,GATE_IP_PERIR ,0 ,0 ,0 ), -GATE (hdmi_cec,"hdmi_cec" ,"aclk100" ,GATE_IP_PERIR ,11 ,0 ,0 ), +GATE (chipid,"chipid" ,"aclk100" ,E4210_GATE_IP_PERIR ,0 ,0 ,0 ), +GATE (sysreg,"sysreg" ,"aclk100" ,E4210_GATE_IP_PERIR ,0 ,0 ,0 ), +GATE (hdmi_cec,"hdmi_cec" ,"aclk100" ,E4210_GATE_IP_PERIR ,11 ,0 ,0 ),GATE (smmu_rotator,"smmu_rotator" ,"aclk200" ,E4210_GATE_IP_IMAGE ,4 ,0 ,0 ), GATE(sclk_mipi1, "sclk_mipi1", "div_mipi_pre1",
@@ -743,10 +743,10 @@ struct samsung_gate_clock exynos4210_gate_clks[] __initdata = {GATE (sclk_mixer,"sclk_mixer" ,"mout_mixer" ,SRC_MASK_TV ,4 ,0 ,0 ),GATE (sclk_dac,"sclk_dac" ,"mout_dac" ,SRC_MASK_TV ,8 ,0 ,0 ),GATE_A (tsadc,"tsadc" ,"aclk100" ,GATE_IP_PERIL ,15 ,0 ,0 ,"adc" ), -GATE_A (mct,"mct" ,"aclk100" ,GATE_IP_PERIR ,13 ,0 ,0 ,"mct" ), -GATE_A (wdt,"watchdog" ,"aclk100" ,GATE_IP_PERIR ,14 ,0 ,0 ,"watchdog" ), -GATE_A (rtc,"rtc" ,"aclk100" ,GATE_IP_PERIR ,15 ,0 ,0 ,"rtc" ), -GATE_A (keyif,"keyif" ,"aclk100" ,GATE_IP_PERIR ,16 ,0 ,0 ,"keypad" ), +GATE_A (mct,"mct" ,"aclk100" ,E4210_GATE_IP_PERIR ,13 ,0 ,0 ,"mct" ), +GATE_A (wdt,"watchdog" ,"aclk100" ,E4210_GATE_IP_PERIR ,14 ,0 ,0 ,"watchdog" ), +GATE_A (rtc,"rtc" ,"aclk100" ,E4210_GATE_IP_PERIR ,15 ,0 ,0 ,"rtc" ), +GATE_A (keyif,"keyif" ,"aclk100" ,E4210_GATE_IP_PERIR ,16 ,0 ,0 ,"keypad" ),GATE_DA (sclk_fimd1,"exynos4-fb.1" ,"sclk_fimd1" ,"div_fimd1" , E4210_SRC_MASK_LCD1, 0, CLK_SET_RATE_PARENT, 0, "sclk_fimd"), };
Signature · 1 line
1.8.1.5
PATCH 19/21 clk: samsung: exynos4: Remove E4X12 prefix from SRC_DMC register
In reply to Tomasz FigaThis register is present on all Exynos4 SoCs and so the prefix is misleading.
--- drivers/clk/samsung/clk-exynos4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/samsung/clk-exynos4.c +2 -2
@@ -93,7 +93,7 @@#define GATE_IP_PERIL 0xc950#define E4210_GATE_IP_PERIR 0xc960#define E4X12_MPLL_CON0 0x10108 -#define E4X12_SRC_DMC 0x10200 +#define SRC_DMC 0x10200#define APLL_CON0 0x14100#define E4210_MPLL_CON0 0x14108#define SRC_CPU 0x14200
@@ -388,7 +388,7 @@ struct samsung_mux_clock exynos4x12_mux_clks[] __initdata = {MUX (none,"mout_jpeg1" , sclk_evpll_p,E4X12_SRC_CAM1 ,4 ,1 ),MUX (none,"mout_jpeg" , mout_jpeg_p,E4X12_SRC_CAM1 ,8 ,1 ),MUX_A (sclk_mpll,"sclk_mpll" , mout_mpll_p, -E4X12_SRC_DMC ,12 ,1 ,"sclk_mpll" ), +SRC_DMC ,12 ,1 ,"sclk_mpll" ),MUX_A (sclk_vpll,"sclk_vpll" , mout_vpll_p,SRC_TOP0 ,8 ,1 ,"sclk_vpll" ), MUX(mout_core, "mout_core", mout_core_p4x12, SRC_CPU, 16, 1),
Signature · 1 line
1.8.1.5
PATCH 20/21 clk: samsung: exynos4: Add missing registers to suspend save list
In reply to Tomasz FigaThis patch adds missing clock control registers to the list of registers that should be saved across system suspend.
--- drivers/clk/samsung/clk-exynos4.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)
drivers/clk/samsung/clk-exynos4.c +33 -0
@@ -22,7 +22,11 @@/* Exynos4 clock controller register offsets */ #define SRC_LEFTBUS 0x4200 +#define DIV_LEFTBUS 0x4500 +#define GATE_IP_LEFTBUS 0x4800#define E4X12_GATE_IP_IMAGE 0x4930 +#define SRC_RIGHTBUS 0x8200 +#define DIV_RIGHTBUS 0x8500#define GATE_IP_RIGHTBUS 0x8800#define E4X12_GATE_IP_PERIR 0x8960#define EPLL_LOCK 0xc010
@@ -48,6 +52,7 @@#define SRC_PERIL0 0xc250#define SRC_PERIL1 0xc254#define E4X12_SRC_CAM1 0xc258 +#define SRC_MASK_TOP 0xc310#define SRC_MASK_CAM 0xc320#define SRC_MASK_TV 0xc324#define SRC_MASK_LCD0 0xc334
@@ -92,12 +97,20 @@#define GATE_IP_GPS 0xc94c#define GATE_IP_PERIL 0xc950#define E4210_GATE_IP_PERIR 0xc960 +#define GATE_BLOCK 0xc970#define E4X12_MPLL_CON0 0x10108#define SRC_DMC 0x10200 +#define SRC_MASK_DMC 0x10300 +#define DIV_DMC0 0x10500 +#define DIV_DMC1 0x10504 +#define GATE_IP_DMC 0x10900#define APLL_CON0 0x14100#define E4210_MPLL_CON0 0x14108#define SRC_CPU 0x14200#define DIV_CPU0 0x14500 +#define DIV_CPU1 0x14504 +#define GATE_SCLK_CPU 0x14800 +#define GATE_IP_CPU 0x14900#define E4X12_DIV_ISP0 0x18300#define E4X12_DIV_ISP1 0x18304#define E4X12_GATE_ISP0 0x18800
@@ -172,7 +185,17 @@ enum exynos4_clks {*/ static __initdata unsigned long exynos4_clk_regs[] = {SRC_LEFTBUS , +DIV_LEFTBUS , +GATE_IP_LEFTBUS , +SRC_RIGHTBUS , +DIV_RIGHTBUS ,GATE_IP_RIGHTBUS , +EPLL_CON0 , +EPLL_CON1 , +EPLL_CON2 , +VPLL_CON0 , +VPLL_CON1 , +VPLL_CON2 ,SRC_TOP0 ,SRC_TOP1 ,SRC_CAM ,
@@ -184,6 +207,7 @@ static __initdata unsigned long exynos4_clk_regs[] = {SRC_FSYS ,SRC_PERIL0 ,SRC_PERIL1 , +SRC_MASK_TOP ,SRC_MASK_CAM ,SRC_MASK_TV , SRC_MASK_LCD0,
@@ -218,9 +242,18 @@ static __initdata unsigned long exynos4_clk_regs[] = {GATE_IP_FSYS ,GATE_IP_GPS ,GATE_IP_PERIL , +GATE_BLOCK , +SRC_MASK_DMC , +SRC_DMC , +DIV_DMC0 , +DIV_DMC1 , +GATE_IP_DMC ,APLL_CON0 ,SRC_CPU ,DIV_CPU0 , +DIV_CPU1 , +GATE_SCLK_CPU , + GATE_IP_CPU, };/* list of all parent clock list */
Signature · 1 line
1.8.1.5
PATCH 21/21 clk: samsung: exynos4: Add support for SoC-specific register save list
In reply to Tomasz FigaThis patch extends suspend/resume support for SoC-specific registers to handle differences in register sets on particular SoCs.
--- drivers/clk/samsung/clk-exynos4.c | 30 ++++++++++++++++++++++++++++-- drivers/clk/samsung/clk-exynos5250.c | 3 ++- drivers/clk/samsung/clk-exynos5440.c | 2 +- drivers/clk/samsung/clk.c | 9 ++++++--- drivers/clk/samsung/clk.h | 3 ++- 5 files changed, 39 insertions(+), 8 deletions(-)
drivers/clk/samsung/clk-exynos4.c +28 -2
@@ -183,6 +183,26 @@ enum exynos4_clks {* list of controller registers to be saved and restored during a * suspend/resume cycle. */ +static __initdata unsigned long exynos4210_clk_save[] = { +E4210_SRC_IMAGE , +E4210_SRC_LCD1 , +E4210_SRC_MASK_LCD1 , +E4210_DIV_LCD1 , +E4210_GATE_IP_IMAGE , +E4210_GATE_IP_LCD1 , +E4210_GATE_IP_PERIR , +E4210_MPLL_CON0 , +}; + +static __initdata unsigned long exynos4x12_clk_save[] = { +E4X12_GATE_IP_IMAGE , +E4X12_GATE_IP_PERIR , +E4X12_SRC_CAM1 , +E4X12_DIV_ISP , +E4X12_DIV_CAM1 , +E4X12_MPLL_CON0 , +}; +static __initdata unsigned long exynos4_clk_regs[] = {SRC_LEFTBUS ,DIV_LEFTBUS ,
@@ -985,8 +1005,14 @@ void __init exynos4_clk_init(struct device_node *np)panic ("%s: unable to determine soc\n" , __func__); } -samsung_clk_init (np, reg_base, nr_clks, - exynos4_clk_regs,ARRAY_SIZE (exynos4_clk_regs)); +if (exynos4_soc ==EXYNOS4210 ) +samsung_clk_init (np, reg_base, nr_clks, + exynos4_clk_regs,ARRAY_SIZE (exynos4_clk_regs), + exynos4210_clk_save,ARRAY_SIZE (exynos4210_clk_save)); +else +samsung_clk_init (np, reg_base, nr_clks, + exynos4_clk_regs,ARRAY_SIZE (exynos4_clk_regs), + exynos4x12_clk_save,ARRAY_SIZE (exynos4x12_clk_save));if (np) samsung_clk_of_register_fixed_ext(exynos4_fixed_rate_ext_clks,
drivers/clk/samsung/clk-exynos5250.c +2 -1
@@ -477,7 +477,8 @@ void __init exynos5250_clk_init(struct device_node *np) }samsung_clk_init (np, reg_base, nr_clks, - exynos5250_clk_regs,ARRAY_SIZE (exynos5250_clk_regs)); + exynos5250_clk_regs,ARRAY_SIZE (exynos5250_clk_regs), +NULL ,0 );samsung_clk_of_register_fixed_ext (exynos5250_fixed_rate_ext_clks,ARRAY_SIZE (exynos5250_fixed_rate_ext_clks), ext_clk_match);
drivers/clk/samsung/clk-exynos5440.c +1 -1
@@ -115,7 +115,7 @@ void __init exynos5440_clk_init(struct device_node *np)return ; } -samsung_clk_init (np, reg_base, nr_clks,NULL ,0 ); +samsung_clk_init (np, reg_base, nr_clks,NULL ,0 ,NULL ,0 );samsung_clk_of_register_fixed_ext (exynos5440_fixed_rate_ext_clks,ARRAY_SIZE (exynos5440_fixed_rate_ext_clks), ext_clk_match);
drivers/clk/samsung/clk.c +6 -3
@@ -54,7 +54,8 @@ static struct syscore_ops samsung_clk_syscore_ops = {/* setup the essentials required to support clock lookup using ccf */ void __init samsung_clk_init (struct device_node *np,void __iomem *base,unsigned long nr_clks,unsigned long *rdump, -unsigned long nr_rdump) +unsigned long nr_rdump,unsigned long *soc_rdump, +unsigned long nr_soc_rdump) { reg_base = base;
@@ -62,7 +63,7 @@ void __init samsung_clk_init(struct device_node *np, void __iomem *base,if (rdump && nr_rdump) {unsigned int idx; reg_dump =kzalloc (sizeof (struct samsung_clk_reg_dump ) - * nr_rdump,GFP_KERNEL ); + * (nr_rdump + nr_soc_rdump),GFP_KERNEL );if (!reg_dump) {pr_err ("%s: memory alloc for register dump failed\n" , __func__);
@@ -71,7 +72,9 @@ void __init samsung_clk_init(struct device_node *np, void __iomem *base,for (idx =0 ; idx < nr_rdump; idx++) reg_dump[idx].offset = rdump[idx]; - nr_reg_dump = nr_rdump; +for (idx =0 ; idx < nr_soc_rdump; idx++) + reg_dump[nr_rdump + idx].offset = soc_rdump[idx]; + nr_reg_dump = nr_rdump + nr_soc_rdump; register_syscore_ops(&samsung_clk_syscore_ops); }#endif
drivers/clk/samsung/clk.h +2 -1
@@ -262,7 +262,8 @@ struct samsung_clk_reg_dump {extern void __init samsung_clk_init (struct device_node *np,void __iomem *base,unsigned long nr_clks,unsigned long *rdump, -unsigned long nr_rdump); +unsigned long nr_rdump,unsigned long *soc_rdump, +unsigned long nr_soc_rdump); extern void __init samsung_clk_of_register_fixed_ext( struct samsung_fixed_rate_clock *fixed_rate_clk, unsigned int nr_fixed_rate_clk,
Signature · 1 line
1.8.1.5
cover Various fixes and extensions to Exynos4 clock driver
In reply to Tomasz FigaHi Tomasz,
Quoted 3 lines · Tomasz Figa
This series is a collection of various fixes and extensions to Exynos4 clock driver, which improve coverage of clocks present on Exynos4 SoCs and fix problems discovered during our internal work and testing.
Nice series. Thanks for the improvements and fixes. Looking at the second patch in this series, I crossed checked again with the Exynos4412 user manual that I have. Your modifications are different from what the manual has listed. I suspect, you have a newer copy of the manual.
For this series:
Thanks,
Thomas.
Quoted 43 lines
Andrzej Hajda (1):
clk: samsung: exynos4: Add missingCMU_TOPand ISP clocksLukasz Majewski (1):
clk: samsung: exynos4: Export clocks used by exynos cpufreq driversSylwester Nawrocki (2):
clk: samsung: exynos4: Correctsclk_mfcclock definition
clk: samsung: exynos4: Add camera related clock definitionsTomasz Figa (17):
clk: samsung: exynos4: Use mout_mpll_user_* on Exynos4x12
clk: samsung: exynos4: Add missingmout_mipihsiclock
clk: samsung: exynos4: Add missingsclk_audio0clock
clk: samsung: exynos4: Exportsclk_pcm0
clk: samsung: exynos4: Move dac and mixer to Exynos4210-specific
clocks
clk: samsung: pll: Remove unimplemented ops
clk: samsung: exynos4: Exportmout_coreclock of Exynos4210
clk: samsung: exynos4: Add G3D clocks
clk: samsung: exynos4: Add missingmout_sataon Exynos4210
clk: samsung: exynos4: Define {E,V}PLL registers
clk: samsung: exynos4: Use SRC_MASK_PERIL{0,1} definitions
clk: samsung: exynos4: Remove SoC-specific registers from save list
clk: samsung: exynos4: Add E4210 prefix to LCD1 clock registers
clk: samsung: exynos4: Add E4210 prefix toGATE_IP_PERIRregister
clk: samsung: exynos4: Remove E4X12 prefix fromSRC_DMCregister
clk: samsung: exynos4: Add missing registers to suspend save list
clk: samsung: exynos4: Add support for SoC-specific register save list.../devicetree/bindings/clock/exynos4-clock.txt | 61 ++- drivers/clk/samsung/clk-exynos4.c | 491 +++++++++++++++------ drivers/clk/samsung/clk-exynos5250.c | 3 +- drivers/clk/samsung/clk-exynos5440.c | 2 +- drivers/clk/samsung/clk-pll.c | 80 ---- drivers/clk/samsung/clk.c | 9 +- drivers/clk/samsung/clk.h | 3 +- 7 files changed, 437 insertions(+), 212 deletions(-)--
1.8.1.5
cover Various fixes and extensions to Exynos4 clock driver
Quoted 7 lines · On Saturday 30 of March 2013 15:33:00 Thomas Abraham wrote:
Hi Tomasz,
Quoted 3 lines · Tomasz Figa
This series is a collection of various fixes and extensions to Exynos4 clock driver, which improve coverage of clocks present on Exynos4 SoCs and fix problems discovered during our internal work and testing.
Quoted 5 lines
Nice series. Thanks for the improvements and fixes. Looking at the second patch in this series, I crossed checked again with the Exynos4412 user manual that I have. Your modifications are different from what the manual has listed. I suspect, you have a newer copy of the manual.
Right. I have checked revisions 0.0, 0.1 and 1.1 of the manual and indeed there are differences in clock layout between 0.1 and 1.1. My patches are based on revision 1.1.
Quoted 2 lines
For this series:
Reviewed-by Thomas Abraham <[email protected]>
Thanks.
Best regards,
Tomasz
Quoted 54 lines
Thanks,
Thomas.Quoted 43 lines
Andrzej Hajda (1):
clk: samsung: exynos4: Add missingCMU_TOPand ISP clocksLukasz Majewski (1):
clk: samsung: exynos4: Export clocks used by exynos cpufreq driversSylwester Nawrocki (2):
clk: samsung: exynos4: Correctsclk_mfcclock definition
clk: samsung: exynos4: Add camera related clock definitionsTomasz Figa (17):
clk: samsung: exynos4: Use mout_mpll_user_* on Exynos4x12
clk: samsung: exynos4: Add missingmout_mipihsiclock
clk: samsung: exynos4: Add missingsclk_audio0clock
clk: samsung: exynos4: Exportsclk_pcm0
clk: samsung: exynos4: Move dac and mixer to Exynos4210-specificclocks
clk: samsung: pll: Remove unimplemented ops
clk: samsung: exynos4: Exportmout_coreclock of Exynos4210
clk: samsung: exynos4: Add G3D clocks
clk: samsung: exynos4: Add missingmout_sataon Exynos4210
clk: samsung: exynos4: Define {E,V}PLL registers
clk: samsung: exynos4: Use SRC_MASK_PERIL{0,1} definitions
clk: samsung: exynos4: Remove SoC-specific registers from save list
clk: samsung: exynos4: Add E4210 prefix to LCD1 clock registers
clk: samsung: exynos4: Add E4210 prefix toGATE_IP_PERIRregister
clk: samsung: exynos4: Remove E4X12 prefix fromSRC_DMCregister
clk: samsung: exynos4: Add missing registers to suspend save list
clk: samsung: exynos4: Add support for SoC-specific register save list.../devicetree/bindings/clock/exynos4-clock.txt | 61 ++- drivers/clk/samsung/clk-exynos4.c | 491 +++++++++++++++------ drivers/clk/samsung/clk-exynos5250.c | 3 +- drivers/clk/samsung/clk-exynos5440.c | 2 +- drivers/clk/samsung/clk-pll.c | 80 ---- drivers/clk/samsung/clk.c | 9 +- drivers/clk/samsung/clk.h | 3 +- 7 files changed, 437 insertions(+), 212 deletions(-)Quoted 2 lines
--
1.8.1.5--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
cover Various fixes and extensions to Exynos4 clock driver
Quoted 15 lines · Tomasz Figa
Quoted 7 lines · On Saturday 30 of March 2013 15:33:00 Thomas Abraham wrote:
Hi Tomasz,
Quoted 3 lines · Tomasz Figa
This series is a collection of various fixes and extensions to Exynos4 clock driver, which improve coverage of clocks present on Exynos4 SoCs and fix problems discovered during our internal work and testing.
Quoted 5 lines
Nice series. Thanks for the improvements and fixes. Looking at the second patch in this series, I crossed checked again with the Exynos4412 user manual that I have. Your modifications are different from what the manual has listed. I suspect, you have a newer copy of the manual.
Quoted 4 lines
Right. I have checked revisions 0.0, 0.1 and 1.1 of the manual and indeed there are differences in clock layout between 0.1 and 1.1. My patches are based on revision 1.1.
Correct...hmm...
Quoted 3 lines
Quoted 2 lines
For this series:
Reviewed-by Thomas Abraham <[email protected]>
Yes, looks good to me but would be better if I could get Mike's ack on this series.
Thanks.
- Kukjin
cover Various fixes and extensions to Exynos4 clock driver
Quoting Kukjin Kim (2013-04-02 01:30:39)
Quoted 20 lines
Quoted 15 lines · Tomasz Figa
Quoted 7 lines · On Saturday 30 of March 2013 15:33:00 Thomas Abraham wrote:
Hi Tomasz,
Quoted 3 lines · Tomasz Figa
This series is a collection of various fixes and extensions to Exynos4 clock driver, which improve coverage of clocks present on Exynos4 SoCs and fix problems discovered during our internal work and testing.
Quoted 5 lines
Nice series. Thanks for the improvements and fixes. Looking at the second patch in this series, I crossed checked again with the Exynos4412 user manual that I have. Your modifications are different from what the manual has listed. I suspect, you have a newer copy of the manual.
Quoted 4 lines
Right. I have checked revisions 0.0, 0.1 and 1.1 of the manual and indeed there are differences in clock layout between 0.1 and 1.1. My patches are based on revision 1.1.
Quoted 8 lines
Correct...hmm...
Quoted 3 lines
Quoted 2 lines
For this series:
Reviewed-by Thomas Abraham <[email protected]>Yes, looks good to me but would be better if I could get Mike's ack on this series.
Quoted 3 lines
Thanks.
- Kukjin
Kukjin Kim
Appliedcover Various fixes and extensions to Exynos4 clock driver
Quoted 31 lines · Mike Turquette
Quoting Kukjin Kim (2013-04-02 01:30:39)
Quoted 7 lines
Quoted 6 lines · Tomasz Figa
Quoted 4 lines · On Saturday 30 of March 2013 15:33:00 Thomas Abraham wrote:
Hi Tomasz,
Quoted 1 line · Tomasz Figa
This series is a collection of various fixes and extensions to
Exynos4
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
clock driver, which improve coverage of clocks present on Exynos4
SoCs
Quoted 9 lines
Quoted 9 lines
Quoted 7 lines
Quoted 1 line
and fix problems discovered during our internal work and testing.
Nice series. Thanks for the improvements and fixes. Looking at the second patch in this series, I crossed checked again with the Exynos4412 user manual that I have. Your modifications are different from what the manual has listed. I suspect, you have a newer copy of the manual.
Right. I have checked revisions 0.0, 0.1 and 1.1 of the manual and
indeed
Quoted 1 line
Quoted 1 line
there are differences in clock layout between 0.1 and 1.1. My patches
are
Quoted 7 lines
Quoted 2 lines
based on revision 1.1.
Correct...hmm...
Quoted 3 lines
Quoted 2 lines
For this series:
Reviewed-by Thomas Abraham <[email protected]>
Quoted 7 lines
Quoted 1 line
Yes, looks good to me but would be better if I could get Mike's ack on
this
Quoted 2 lines
series.
Acked-by Mike Turquette <[email protected]>
Thanks, applied.
- Kukjin