Skip to contentSkip to conversation

bmips: add BCM63xx power domain controller

PATCH Superseded Álvaro Fernández Rojas 4 participants 58 messages Jun 9, 2020 – Jul 24, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover bmips: add BCM63xx power domain controller

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

Álvaro Fernández Rojas (4):
dt-bindings: soc: brcm: add BCM63xx power domain binding
soc: bcm: add BCM63xx power domain driver
mips: bmips: dts: add BCM6328 power domain support
mips: bmips: dts: add BCM6362 power domain support

 .../devicetree/bindings/mips/brcm/soc.txt     |  17 +
 arch/mips/boot/dts/brcm/bcm6328.dtsi          |   6 +
 arch/mips/boot/dts/brcm/bcm6362.dtsi          |   6 +
 drivers/soc/bcm/Kconfig                       |   8 +
 drivers/soc/bcm/Makefile                      |   1 +
 drivers/soc/bcm/bcm63xx-power.c               | 374 ++++++++++++++++++
 6 files changed, 412 insertions(+)
 create mode 100644 drivers/soc/bcm/bcm63xx-power.c
Signature · 7 lines
2.26.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

PATCH 1/4 dt-bindings: soc: brcm: add BCM63xx power domain binding

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
 .../devicetree/bindings/mips/brcm/soc.txt       | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
Documentation/devicetree/bindings/mips/brcm/soc.txt +17 -0
index 3a66d3c483e1..22ec9e39bff7 100644
@@ -164,3 +164,20 @@ Example:
 		reg = <0x4067c0 0x40>;
 		interrupts = <&periph_intc 19>;
 	};
+
+BCM63xx
+-------
+
+= Power domain controller
+
+BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller
+to enable/disable certain components in order to save power.
+
+- compatible		: should contain one of:
+			  "brcm,bcm6318-power-controller"
+			  "brcm,bcm6328-power-controller"
+			  "brcm,bcm6362-power-controller"
+			  "brcm,bcm63268-power-controller"
+- reg 			: the register start and length for the power domain
+			  controller block
+- #power-domain-cells	: must be 1
Signature · 1 line
2.26.2
#2 lore raw

Re: [PATCH 1/4] dt-bindings: soc: brcm: add BCM63xx power domain binding

Quoted 6 lines · Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
 .../devicetree/bindings/mips/brcm/soc.txt       | 17 +++++++++++++++++

You should probably create a YAML binding from the beginning that way you get validation for free. This file should ultimately be broken down into separate YAML bindings, but I Have not had the time to do that yet (you are welcome to if you feel like it).

Other than that, the binding definition looks good to me.

Signature · 1 line
Florian
#3 lore raw

Re: [PATCH 1/4] dt-bindings: soc: brcm: add BCM63xx power domain binding

Ok, I will send v2 with a separate YAML file.

Quoted 12 lines · Florian Fainelli
Quoted 6 lines · Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
.../devicetree/bindings/mips/brcm/soc.txt | 17 +++++++++++++++++

Quoted 8 lines

You should probably create a YAML binding from the beginning that way you get validation for free. This file should ultimately be broken down into separate YAML bindings, but I Have not had the time to do that yet (you are welcome to if you feel like it).

Other than that, the binding definition looks good to me.

Signature · 1 line
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw

PATCH 2/4 soc: bcm: add BCM63xx power domain driver

In reply to Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
 drivers/soc/bcm/Kconfig         |   8 +
 drivers/soc/bcm/Makefile        |   1 +
 drivers/soc/bcm/bcm63xx-power.c | 374 ++++++++++++++++++++++++++++++++
 3 files changed, 383 insertions(+)
 create mode 100644 drivers/soc/bcm/bcm63xx-power.c
drivers/soc/bcm/Kconfig +8 -0
index 648e32693b7e..a2e60d28370b 100644
@@ -13,6 +13,14 @@ config BCM2835_POWER
 	  firmware means that Linux usage of the same power domain
 	  must be accessed using the RASPBERRYPI_POWER driver
 
+config BCM63XX_POWER
+	bool "BCM63xx power domain driver"
+	depends on BMIPS_GENERIC || (COMPILE_TEST && OF)
+	select PM_GENERIC_DOMAINS if PM
+	help
+	  This enables support for the BCM63xx power domains controller on
+	  BCM6318, BCM6328, BCM6362 and BCM63268 SoCs.
+
 config RASPBERRYPI_POWER
 	bool "Raspberry Pi power domain driver"
 	depends on ARCH_BCM2835 || (COMPILE_TEST && OF)
drivers/soc/bcm/Makefile +1 -0
index d92268a829a9..e6c3d04a4a83 100644
@@ -1,4 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
 obj-$(CONFIG_BCM2835_POWER)	+= bcm2835-power.o
+obj-$(CONFIG_BCM63XX_POWER)	+= bcm63xx-power.o
 obj-$(CONFIG_RASPBERRYPI_POWER)	+= raspberrypi-power.o
 obj-$(CONFIG_SOC_BRCMSTB)	+= brcmstb/
drivers/soc/bcm/bcm63xx-power.c new file +374 -0

374 lines not on this page · raw message

Signature · 1 line
2.26.2
#5 lore raw

Re: [PATCH 2/4] soc: bcm: add BCM63xx power domain driver

Quoted 8 lines · Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
 drivers/soc/bcm/Kconfig         |   8 +
 drivers/soc/bcm/Makefile        |   1 +
 drivers/soc/bcm/bcm63xx-power.c | 374 ++++++++++++++++++++++++++++++++

I would create drivers/soc/bcm/bcm63xx because there are likely going to be more changes for BCM63xx DSL SOCs in the future that would land there, for instance the BCM63138 and newer SoCs have an entirely different reset controller using the on-chip micro controller that would be landing there.

Can you also make sure that the MAINTAINERS file still matches that location?

With respect to the code, given that you have defined #reset-cells = <1> in the Device Tree binding, I would expect that you create a header under include/dt-bindings/ which defines constants for the various SoCs which you are then using within your power domain provider driver. bcm2835-power.c is a good example of how this works for instance.

Signature · 1 line
Florian
#6 lore raw

PATCH 3/4 mips: bmips: dts: add BCM6328 power domain support

In reply to Álvaro Fernández Rojas

BCM6328 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
 arch/mips/boot/dts/brcm/bcm6328.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/mips/boot/dts/brcm/bcm6328.dtsi +6 -0
index af860d06def6..1f9edd710392 100644
@@ -110,6 +110,12 @@ leds0: led-controller@10000800 {
 			status = "disabled";
 		};
 
+		periph_pwr: power-controller@10001848 {
+			compatible = "brcm,bcm6328-power-controller";
+			reg = <0x10001848 0x4>;
+			#power-domain-cells = <1>;
+		};
+
 		ehci: usb@10002500 {
 			compatible = "brcm,bcm6328-ehci", "generic-ehci";
 			reg = <0x10002500 0x100>;
Signature · 7 lines
2.26.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Acked-by on v1 3/4
#7 lore raw

Re: [PATCH 3/4] mips: bmips: dts: add BCM6328 power domain support

Quoted 4 lines · Álvaro Fernández Rojas

BCM6328 SoCs have a power domain controller to enable/disable certain components in order to save power.

Signature · 6 lines
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#8 lore raw

PATCH 4/4 mips: bmips: dts: add BCM6362 power domain support

In reply to Álvaro Fernández Rojas

BCM6362 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
 arch/mips/boot/dts/brcm/bcm6362.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/mips/boot/dts/brcm/bcm6362.dtsi +6 -0
index 8ae6981735b8..c98f9111e3c8 100644
@@ -108,6 +108,12 @@ uart1: serial@10000120 {
 			status = "disabled";
 		};
 
+		periph_pwr: power-controller@10001848 {
+			compatible = "brcm,bcm6362-power-controller";
+			reg = <0x10001848 0x4>;
+			#power-domain-cells = <1>;
+		};
+
 		leds0: led-controller@10001900 {
 			#address-cells = <1>;
 			#size-cells = <0>;
Signature · 7 lines
2.26.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#11 lore raw

v2 cover bmips: add BCM63xx power domain controller

In reply to Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

v2: Introduce changes suggested by Florian:
- Add separate YAML file for dt-bindings.
- Add bcm63xx folder in drivers/soc/bcm.
- Update MAINTAINERS.
- Add dt-bindings header files.
- Also add BCM63268 support.

Álvaro Fernández Rojas (6):
dt-bindings: soc: brcm: add BCM63xx power domain binding
soc: bcm: add BCM63xx power domain driver
mips: bmips: dts: add BCM6328 power domain support
mips: bmips: dts: add BCM6362 power domain support
mips: bmips: dts: add BCM63268 power domain support
mips: bmips: add BCM6318 power domain definitions

 .../bindings/soc/bcm/brcm,bcm63xx-power.yaml  |  44 +++
 MAINTAINERS                                   |   1 +
 arch/mips/boot/dts/brcm/bcm63268.dtsi         |   6 +
 arch/mips/boot/dts/brcm/bcm6328.dtsi          |   6 +
 arch/mips/boot/dts/brcm/bcm6362.dtsi          |   6 +
 drivers/soc/bcm/Kconfig                       |  10 +
 drivers/soc/bcm/Makefile                      |   1 +
 drivers/soc/bcm/bcm63xx/Kconfig               |  12 +
 drivers/soc/bcm/bcm63xx/Makefile              |   2 +
 drivers/soc/bcm/bcm63xx/bcm63xx-power.c       | 374 ++++++++++++++++++
 include/dt-bindings/soc/bcm6318-pm.h          |  17 +
 include/dt-bindings/soc/bcm63268-pm.h         |  21 +
 include/dt-bindings/soc/bcm6328-pm.h          |  17 +
 include/dt-bindings/soc/bcm6362-pm.h          |  21 +
 14 files changed, 538 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml
 create mode 100644 drivers/soc/bcm/bcm63xx/Kconfig
 create mode 100644 drivers/soc/bcm/bcm63xx/Makefile
 create mode 100644 drivers/soc/bcm/bcm63xx/bcm63xx-power.c
 create mode 100644 include/dt-bindings/soc/bcm6318-pm.h
 create mode 100644 include/dt-bindings/soc/bcm63268-pm.h
 create mode 100644 include/dt-bindings/soc/bcm6328-pm.h
 create mode 100644 include/dt-bindings/soc/bcm6362-pm.h
Signature · 1 line
2.26.2
#12 lore raw

PATCH v2 1/6 dt-bindings: soc: brcm: add BCM63xx power domain binding

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v2: Add separate YAML file.

 .../bindings/soc/bcm/brcm,bcm63xx-power.yaml  | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml
Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml new file +44 -0
new file mode 100644
index 000000000000..804d8b31679e
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/brcm/brcm,bcm63xx-power.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: BCM63xx power domain driver
+
+maintainers:
+  - Álvaro Fernández Rojas <[email protected]>
+
+description: |
+  BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller
+  to enable/disable certain components in order to save power.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - brcm,bcm6318-power-controller
+          - brcm,bcm6328-power-controller
+          - brcm,bcm6362-power-controller
+          - brcm,bcm63268-power-controller
+
+  reg:
+    maxItems: 1
+
+  #power-domain-cells:
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - #power-domain-cells
+
+additionalProperties: false
+
+examples:
+  - |
+    periph_pwr: power-controller@10001848 {
+        compatible = "brcm,bcm6328-power-controller";
+        reg = <0x10001848 0x4>;
+        #power-domain-cells = <1>;
+    };
Signature · 1 line
2.26.2
#14 lore raw

PATCH v2 2/6 soc: bcm: add BCM63xx power domain driver

In reply to Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v2: Introduce bcm63xx folder in drivers/soc/bcm and update MAINTAINERS.

 MAINTAINERS                             |   1 +
 drivers/soc/bcm/Kconfig                 |  10 +
 drivers/soc/bcm/Makefile                |   1 +
 drivers/soc/bcm/bcm63xx/Kconfig         |  12 +
 drivers/soc/bcm/bcm63xx/Makefile        |   2 +
 drivers/soc/bcm/bcm63xx/bcm63xx-power.c | 374 ++++++++++++++++++++++++
 6 files changed, 400 insertions(+)
 create mode 100644 drivers/soc/bcm/bcm63xx/Kconfig
 create mode 100644 drivers/soc/bcm/bcm63xx/Makefile
 create mode 100644 drivers/soc/bcm/bcm63xx/bcm63xx-power.c
MAINTAINERS +1 -0
index 77a3fa5e3edd..e9ba7b955d5f 100644
@@ -3442,6 +3442,7 @@ F:	arch/mips/bmips/*
 F:	arch/mips/boot/dts/brcm/bcm*.dts*
 F:	arch/mips/include/asm/mach-bmips/*
 F:	arch/mips/kernel/*bmips*
+F:	drivers/soc/bcm/bcm63xx
 F:	drivers/irqchip/irq-bcm63*
 F:	drivers/irqchip/irq-bcm7*
 F:	drivers/irqchip/irq-brcmstb*
drivers/soc/bcm/Kconfig +10 -0
index 648e32693b7e..24f92a6e882a 100644
@@ -22,6 +22,15 @@ config RASPBERRYPI_POWER
 	  This enables support for the RPi power domains which can be enabled
 	  or disabled via the RPi firmware.
 
+config SOC_BCM63XX
+	bool "Broadcom 63xx SoC drivers"
+	depends on BMIPS_GENERIC || COMPILE_TEST
+	help
+	  Enables drivers for the Broadcom 63xx series of chips.
+	  Drivers can be enabled individually within this menu.
+
+	  If unsure, say N.
+
 config SOC_BRCMSTB
 	bool "Broadcom STB SoC drivers"
 	depends on ARM || ARM64 || BMIPS_GENERIC || COMPILE_TEST
@@ -33,6 +42,7 @@ config SOC_BRCMSTB
 
 	  If unsure, say N.
 
+source "drivers/soc/bcm/bcm63xx/Kconfig"
 source "drivers/soc/bcm/brcmstb/Kconfig"
 
 endmenu
drivers/soc/bcm/Makefile +1 -0
index d92268a829a9..7bc90e0bd773 100644
@@ -1,4 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
 obj-$(CONFIG_BCM2835_POWER)	+= bcm2835-power.o
 obj-$(CONFIG_RASPBERRYPI_POWER)	+= raspberrypi-power.o
+obj-$(CONFIG_SOC_BCM63XX)	+= bcm63xx/
 obj-$(CONFIG_SOC_BRCMSTB)	+= brcmstb/
drivers/soc/bcm/bcm63xx/Kconfig new file +12 -0
new file mode 100644
index 000000000000..16f648a6c70a
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: GPL-2.0-only
+if SOC_BCM63XX
+
+config BCM63XX_POWER
+	bool "BCM63xx power domain driver"
+	depends on BMIPS_GENERIC || (COMPILE_TEST && OF)
+	select PM_GENERIC_DOMAINS if PM
+	help
+	  This enables support for the BCM63xx power domains controller on
+	  BCM6318, BCM6328, BCM6362 and BCM63268 SoCs.
+
+endif # SOC_BCM63XX
drivers/soc/bcm/bcm63xx/Makefile new file +2 -0
new file mode 100644
index 000000000000..0710d5e018cc
@@ -0,0 +1,2 @@
+# SPDX-License-Identifier: GPL-2.0-only
+obj-$(CONFIG_BCM63XX_POWER) += bcm63xx-power.o
drivers/soc/bcm/bcm63xx/bcm63xx-power.c new file +374 -0

374 lines not on this page · raw message

Signature · 1 line
2.26.2
#15 lore raw

Re: [PATCH v2 2/6] soc: bcm: add BCM63xx power domain driver

Quoted 4 lines · Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

Thanks for addressing the previous comments, this looks good to me, there is just a single request below:

[snip]

drivers/soc/bcm/bcm63xx/bcm63xx-power.c line 176

Quoted 4 lines
drivers/soc/bcm/bcm63xx/bcm63xx-power.c new file +4 -0
+static const struct bcm63xx_power_data bcm6318_power_domains[] = {
+	{
+		.name = "pcie",
+		.bit = 0,

All of these bits definition should use the constants that you add in patches 3 through 6, this means you would have to re-order the patches to maintain bisectability obviously.

Thanks!

Signature · 1 line
Florian
#16 lore raw

PATCH v2 3/6 mips: bmips: dts: add BCM6328 power domain support

In reply to Álvaro Fernández Rojas

BCM6328 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v2: Add dt-bindings header files.

 arch/mips/boot/dts/brcm/bcm6328.dtsi |  6 ++++++
 include/dt-bindings/soc/bcm6328-pm.h | 17 +++++++++++++++++
 2 files changed, 23 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm6328-pm.h
arch/mips/boot/dts/brcm/bcm6328.dtsi +6 -0
index af860d06def6..1f9edd710392 100644
@@ -110,6 +110,12 @@ leds0: led-controller@10000800 {
 			status = "disabled";
 		};
 
+		periph_pwr: power-controller@10001848 {
+			compatible = "brcm,bcm6328-power-controller";
+			reg = <0x10001848 0x4>;
+			#power-domain-cells = <1>;
+		};
+
 		ehci: usb@10002500 {
 			compatible = "brcm,bcm6328-ehci", "generic-ehci";
 			reg = <0x10002500 0x100>;
include/dt-bindings/soc/bcm6328-pm.h new file +17 -0
new file mode 100644
index 000000000000..557e1a69b7f7
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_BMIPS_BCM6328_PM_H
+#define __DT_BINDINGS_BMIPS_BCM6328_PM_H
+
+#define BCM6328_POWER_DOMAIN_ADSL2_MIPS	0
+#define BCM6328_POWER_DOMAIN_ADSL2_PHY	1
+#define BCM6328_POWER_DOMAIN_ADSL2_AFE	2
+#define BCM6328_POWER_DOMAIN_SAR	3
+#define BCM6328_POWER_DOMAIN_PCM	4
+#define BCM6328_POWER_DOMAIN_USBD	5
+#define BCM6328_POWER_DOMAIN_USBH	6
+#define BCM6328_POWER_DOMAIN_PCIE	7
+#define BCM6328_POWER_DOMAIN_ROBOSW	8
+#define BCM6328_POWER_DOMAIN_EPHY	9
+
+#endif /* __DT_BINDINGS_BMIPS_BCM6328_PM_H */
Signature · 1 line
2.26.2
#17 lore raw

PATCH v2 4/6 mips: bmips: dts: add BCM6362 power domain support

In reply to Álvaro Fernández Rojas

BCM6362 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v2: Add dt-bindings header files.

 arch/mips/boot/dts/brcm/bcm6362.dtsi |  6 ++++++
 include/dt-bindings/soc/bcm6362-pm.h | 21 +++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm6362-pm.h
arch/mips/boot/dts/brcm/bcm6362.dtsi +6 -0
index 8ae6981735b8..c98f9111e3c8 100644
@@ -108,6 +108,12 @@ uart1: serial@10000120 {
 			status = "disabled";
 		};
 
+		periph_pwr: power-controller@10001848 {
+			compatible = "brcm,bcm6362-power-controller";
+			reg = <0x10001848 0x4>;
+			#power-domain-cells = <1>;
+		};
+
 		leds0: led-controller@10001900 {
 			#address-cells = <1>;
 			#size-cells = <0>;
include/dt-bindings/soc/bcm6362-pm.h new file +21 -0
new file mode 100644
index 000000000000..d087ba63c7a1
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_BMIPS_BCM6362_PM_H
+#define __DT_BINDINGS_BMIPS_BCM6362_PM_H
+
+#define BCM6362_POWER_DOMAIN_SAR	0
+#define BCM6362_POWER_DOMAIN_IPSEC	1
+#define BCM6362_POWER_DOMAIN_MIPS	2
+#define BCM6362_POWER_DOMAIN_DECT	3
+#define BCM6362_POWER_DOMAIN_USBH	4
+#define BCM6362_POWER_DOMAIN_USBD	5
+#define BCM6362_POWER_DOMAIN_ROBOSW	6
+#define BCM6362_POWER_DOMAIN_PCM	7
+#define BCM6362_POWER_DOMAIN_PERIPH	8
+#define BCM6362_POWER_DOMAIN_ADSL_PHY	9
+#define BCM6362_POWER_DOMAIN_GMII_PADS	10
+#define BCM6362_POWER_DOMAIN_FAP	11
+#define BCM6362_POWER_DOMAIN_PCIE	12
+#define BCM6362_POWER_DOMAIN_WLAN_PADS	13
+
+#endif /* __DT_BINDINGS_BMIPS_BCM6362_PM_H */
Signature · 1 line
2.26.2
#18 lore raw

PATCH v2 5/6 mips: bmips: dts: add BCM63268 power domain support

In reply to Álvaro Fernández Rojas

BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v2: Add support for BCM63268 too.

 arch/mips/boot/dts/brcm/bcm63268.dtsi |  6 ++++++
 include/dt-bindings/soc/bcm63268-pm.h | 21 +++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm63268-pm.h
arch/mips/boot/dts/brcm/bcm63268.dtsi +6 -0
index beec24145af7..5acb49b61867 100644
@@ -117,6 +117,12 @@ leds0: led-controller@10001900 {
 			status = "disabled";
 		};
 
+		periph_pwr: power-controller@1000184c {
+			compatible = "brcm,bcm6328-power-controller";
+			reg = <0x1000184c 0x4>;
+			#power-domain-cells = <1>;
+		};
+
 		ehci: usb@10002500 {
 			compatible = "brcm,bcm63268-ehci", "generic-ehci";
 			reg = <0x10002500 0x100>;
include/dt-bindings/soc/bcm63268-pm.h new file +21 -0
new file mode 100644
index 000000000000..84ded53a732f
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_BMIPS_BCM63268_PM_H
+#define __DT_BINDINGS_BMIPS_BCM63268_PM_H
+
+#define BCM63268_POWER_DOMAIN_SAR	0
+#define BCM63268_POWER_DOMAIN_IPSEC	1
+#define BCM63268_POWER_DOMAIN_MIPS	2
+#define BCM63268_POWER_DOMAIN_DECT	3
+#define BCM63268_POWER_DOMAIN_USBH	4
+#define BCM63268_POWER_DOMAIN_USBD	5
+#define BCM63268_POWER_DOMAIN_ROBOSW	6
+#define BCM63268_POWER_DOMAIN_PCM	7
+#define BCM63268_POWER_DOMAIN_PERIPH	8
+#define BCM63268_POWER_DOMAIN_VDSL_PHY	9
+#define BCM63268_POWER_DOMAIN_VDSL_MIPS	10
+#define BCM63268_POWER_DOMAIN_FAP	11
+#define BCM63268_POWER_DOMAIN_PCIE	12
+#define BCM63268_POWER_DOMAIN_WLAN_PADS	13
+
+#endif /* __DT_BINDINGS_BMIPS_BCM63268_PM_H */
Signature · 1 line
2.26.2
#19 lore raw

PATCH v2 6/6 mips: bmips: add BCM6318 power domain definitions

In reply to Álvaro Fernández Rojas

BCM6318 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v2: Add BCM6318 dt-bindings header file.

 include/dt-bindings/soc/bcm6318-pm.h | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm6318-pm.h
include/dt-bindings/soc/bcm6318-pm.h new file +17 -0
new file mode 100644
index 000000000000..05931dce8333
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_BMIPS_BCM6318_PM_H
+#define __DT_BINDINGS_BMIPS_BCM6318_PM_H
+
+#define BCM6318_POWER_DOMAIN_PCIE	0
+#define BCM6318_POWER_DOMAIN_USB	1
+#define BCM6318_POWER_DOMAIN_EPHY0	2
+#define BCM6318_POWER_DOMAIN_EPHY1	3
+#define BCM6318_POWER_DOMAIN_EPHY2	4
+#define BCM6318_POWER_DOMAIN_EPHY3	5
+#define BCM6318_POWER_DOMAIN_LDO2P5	6
+#define BCM6318_POWER_DOMAIN_LDO2P9	7
+#define BCM6318_POWER_DOMAIN_SW1P0	8
+#define BCM6318_POWER_DOMAIN_PAD	9
+
+#endif /* __DT_BINDINGS_BMIPS_BCM6318_PM_H */
Signature · 1 line
2.26.2
#20 lore raw
In reply to Álvaro Fernández Rojas
Quoted 9 lines · Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

v2: Introduce changes suggested by Florian:
- Add separate YAML file for dt-bindings.
- Add bcm63xx folder in drivers/soc/bcm.
- Update MAINTAINERS.
- Add dt-bindings header files.
- Also add BCM63268 support.

Thomas, since I typically send pull requests to [email protected] for drivers/soc/bcm/, do you want me to take the full series and updatse to drivers/soc/bcm/bcm63xx/ in the future as well?

Signature · 1 line
Florian
#21 lore raw

v3 cover bmips: add BCM63xx power domain controller

In reply to Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

v3: Introduce changes suggested by Florian:
- Use dt-bindings definitions in power domain driver.
- Separate dt-bindings definitions from power domain .dtsi support.
v2: Introduce changes suggested by Florian:
- Add separate YAML file for dt-bindings.
- Add bcm63xx folder in drivers/soc/bcm.
- Update MAINTAINERS.
- Add dt-bindings header files.
- Also add BCM63268 support.

Álvaro Fernández Rojas (9):
dt-bindings: soc: brcm: add BCM63xx power domain binding
mips: bmips: dts: add BCM6328 power domain definitions
mips: bmips: dts: add BCM6362 power domain definitions
mips: bmips: dts: add BCM63268 power domain definitions
mips: bmips: add BCM6318 power domain definitions
soc: bcm: add BCM63xx power domain driver
mips: bmips: dts: add BCM6328 power domain support
mips: bmips: dts: add BCM6362 power domain support
mips: bmips: dts: add BCM63268 power domain support

 .../bindings/soc/bcm/brcm,bcm63xx-power.yaml  |  44 ++
 MAINTAINERS                                   |   1 +
 arch/mips/boot/dts/brcm/bcm63268.dtsi         |   6 +
 arch/mips/boot/dts/brcm/bcm6328.dtsi          |   6 +
 arch/mips/boot/dts/brcm/bcm6362.dtsi          |   6 +
 drivers/soc/bcm/Kconfig                       |  10 +
 drivers/soc/bcm/Makefile                      |   1 +
 drivers/soc/bcm/bcm63xx/Kconfig               |  12 +
 drivers/soc/bcm/bcm63xx/Makefile              |   2 +
 drivers/soc/bcm/bcm63xx/bcm63xx-power.c       | 378 ++++++++++++++++++
 include/dt-bindings/soc/bcm6318-pm.h          |  17 +
 include/dt-bindings/soc/bcm63268-pm.h         |  21 +
 include/dt-bindings/soc/bcm6328-pm.h          |  17 +
 include/dt-bindings/soc/bcm6362-pm.h          |  21 +
 14 files changed, 542 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml
 create mode 100644 drivers/soc/bcm/bcm63xx/Kconfig
 create mode 100644 drivers/soc/bcm/bcm63xx/Makefile
 create mode 100644 drivers/soc/bcm/bcm63xx/bcm63xx-power.c
 create mode 100644 include/dt-bindings/soc/bcm6318-pm.h
 create mode 100644 include/dt-bindings/soc/bcm63268-pm.h
 create mode 100644 include/dt-bindings/soc/bcm6328-pm.h
 create mode 100644 include/dt-bindings/soc/bcm6362-pm.h
Signature · 1 line
2.26.2
#22 lore raw

PATCH v3 1/9 dt-bindings: soc: brcm: add BCM63xx power domain binding

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v3: fix reg maxItems and quote #power-domain-cells.
v2: Add separate YAML file.

 .../bindings/soc/bcm/brcm,bcm63xx-power.yaml  | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml
Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml new file +44 -0
new file mode 100644
index 000000000000..fd4204d9aaf6
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/brcm/brcm,bcm63xx-power.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: BCM63xx power domain driver
+
+maintainers:
+  - Álvaro Fernández Rojas <[email protected]>
+
+description: |
+  BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller
+  to enable/disable certain components in order to save power.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - brcm,bcm6318-power-controller
+          - brcm,bcm6328-power-controller
+          - brcm,bcm6362-power-controller
+          - brcm,bcm63268-power-controller
+
+  reg:
+    maxItems: 2
+
+  "#power-domain-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - "#power-domain-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    periph_pwr: power-controller@10001848 {
+        compatible = "brcm,bcm6328-power-controller";
+        reg = <0x10001848 0x4>;
+        #power-domain-cells = <1>;
+    };
Signature · 1 line
2.26.2
maintainer
#23 lore raw

Re: [PATCH v3 1/9] dt-bindings: soc: brcm: add BCM63xx power domain binding

Quoted 5 lines · Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

Quoted 8 lines

---
v3: fix reg maxItems and quote #power-domain-cells.
v2: Add separate YAML file.

 .../bindings/soc/bcm/brcm,bcm63xx-power.yaml  | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml

My bot found errors running 'make dt_binding_check' on your patch:

Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/soc/bcm/brcm,bcm63xx-power.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.example.dt.yaml: power-controller@10001848: reg: [[268441672, 4]] is too short

See https://patchwork.ozlabs.org/patch/1307099

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.

maintainer
#24 lore raw

Re: [PATCH v3 1/9] dt-bindings: soc: brcm: add BCM63xx power domain binding

In reply to Álvaro Fernández Rojas
Quoted 10 lines · Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v3: fix reg maxItems and quote #power-domain-cells.
v2: Add separate YAML file.

 .../bindings/soc/bcm/brcm,bcm63xx-power.yaml  | 44 +++++++++++++++++++

Goes in bindings/power/

Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml line 1

Quoted 10 lines
 1 file changed, 44 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml
Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml new file +1 -0
new file mode 100644
index 000000000000..fd4204d9aaf6
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: GPL-2.0-or-later

Okay with GPLv9? Dual license new bindings:

(GPL-2.0-only OR BSD-2-Clause)

Quoted 46 lines
Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml new file +43 -0
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/brcm/brcm,bcm63xx-power.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: BCM63xx power domain driver
+
+maintainers:
+  - Álvaro Fernández Rojas <[email protected]>
+
+description: |
+  BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller
+  to enable/disable certain components in order to save power.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - brcm,bcm6318-power-controller
+          - brcm,bcm6328-power-controller
+          - brcm,bcm6362-power-controller
+          - brcm,bcm63268-power-controller
+
+  reg:
+    maxItems: 2
+
+  "#power-domain-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - "#power-domain-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    periph_pwr: power-controller@10001848 {
+        compatible = "brcm,bcm6328-power-controller";
+        reg = <0x10001848 0x4>;
+        #power-domain-cells = <1>;
+    };
Signature · 1 line
2.26.2
#25 lore raw

PATCH v3 2/9 mips: bmips: dts: add BCM6328 power domain definitions

In reply to Álvaro Fernández Rojas

BCM6328 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v3: Separate dt-bindings definitions from power domain .dtsi support.

 include/dt-bindings/soc/bcm6328-pm.h | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm6328-pm.h
include/dt-bindings/soc/bcm6328-pm.h new file +17 -0
new file mode 100644
index 000000000000..557e1a69b7f7
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_BMIPS_BCM6328_PM_H
+#define __DT_BINDINGS_BMIPS_BCM6328_PM_H
+
+#define BCM6328_POWER_DOMAIN_ADSL2_MIPS	0
+#define BCM6328_POWER_DOMAIN_ADSL2_PHY	1
+#define BCM6328_POWER_DOMAIN_ADSL2_AFE	2
+#define BCM6328_POWER_DOMAIN_SAR	3
+#define BCM6328_POWER_DOMAIN_PCM	4
+#define BCM6328_POWER_DOMAIN_USBD	5
+#define BCM6328_POWER_DOMAIN_USBH	6
+#define BCM6328_POWER_DOMAIN_PCIE	7
+#define BCM6328_POWER_DOMAIN_ROBOSW	8
+#define BCM6328_POWER_DOMAIN_EPHY	9
+
+#endif /* __DT_BINDINGS_BMIPS_BCM6328_PM_H */
Signature · 1 line
2.26.2
#26 lore raw

PATCH v3 3/9 mips: bmips: dts: add BCM6362 power domain definitions

In reply to Álvaro Fernández Rojas

BCM6362 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v3: Separate dt-bindings definitions from power domain .dtsi support.

 include/dt-bindings/soc/bcm6362-pm.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm6362-pm.h
include/dt-bindings/soc/bcm6362-pm.h new file +21 -0
new file mode 100644
index 000000000000..d087ba63c7a1
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_BMIPS_BCM6362_PM_H
+#define __DT_BINDINGS_BMIPS_BCM6362_PM_H
+
+#define BCM6362_POWER_DOMAIN_SAR	0
+#define BCM6362_POWER_DOMAIN_IPSEC	1
+#define BCM6362_POWER_DOMAIN_MIPS	2
+#define BCM6362_POWER_DOMAIN_DECT	3
+#define BCM6362_POWER_DOMAIN_USBH	4
+#define BCM6362_POWER_DOMAIN_USBD	5
+#define BCM6362_POWER_DOMAIN_ROBOSW	6
+#define BCM6362_POWER_DOMAIN_PCM	7
+#define BCM6362_POWER_DOMAIN_PERIPH	8
+#define BCM6362_POWER_DOMAIN_ADSL_PHY	9
+#define BCM6362_POWER_DOMAIN_GMII_PADS	10
+#define BCM6362_POWER_DOMAIN_FAP	11
+#define BCM6362_POWER_DOMAIN_PCIE	12
+#define BCM6362_POWER_DOMAIN_WLAN_PADS	13
+
+#endif /* __DT_BINDINGS_BMIPS_BCM6362_PM_H */
Signature · 1 line
2.26.2
#27 lore raw

PATCH v3 4/9 mips: bmips: dts: add BCM63268 power domain definitions

In reply to Álvaro Fernández Rojas

BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v3: Separate dt-bindings definitions from power domain .dtsi support.

 include/dt-bindings/soc/bcm63268-pm.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm63268-pm.h
include/dt-bindings/soc/bcm63268-pm.h new file +21 -0
new file mode 100644
index 000000000000..84ded53a732f
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_BMIPS_BCM63268_PM_H
+#define __DT_BINDINGS_BMIPS_BCM63268_PM_H
+
+#define BCM63268_POWER_DOMAIN_SAR	0
+#define BCM63268_POWER_DOMAIN_IPSEC	1
+#define BCM63268_POWER_DOMAIN_MIPS	2
+#define BCM63268_POWER_DOMAIN_DECT	3
+#define BCM63268_POWER_DOMAIN_USBH	4
+#define BCM63268_POWER_DOMAIN_USBD	5
+#define BCM63268_POWER_DOMAIN_ROBOSW	6
+#define BCM63268_POWER_DOMAIN_PCM	7
+#define BCM63268_POWER_DOMAIN_PERIPH	8
+#define BCM63268_POWER_DOMAIN_VDSL_PHY	9
+#define BCM63268_POWER_DOMAIN_VDSL_MIPS	10
+#define BCM63268_POWER_DOMAIN_FAP	11
+#define BCM63268_POWER_DOMAIN_PCIE	12
+#define BCM63268_POWER_DOMAIN_WLAN_PADS	13
+
+#endif /* __DT_BINDINGS_BMIPS_BCM63268_PM_H */
Signature · 1 line
2.26.2
#28 lore raw

PATCH v3 5/9 mips: bmips: add BCM6318 power domain definitions

In reply to Álvaro Fernández Rojas

BCM6318 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v3: no changes (patch reordered).
v2: Add BCM6318 dt-bindings header file.

 include/dt-bindings/soc/bcm6318-pm.h | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm6318-pm.h
include/dt-bindings/soc/bcm6318-pm.h new file +17 -0
new file mode 100644
index 000000000000..05931dce8333
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_BMIPS_BCM6318_PM_H
+#define __DT_BINDINGS_BMIPS_BCM6318_PM_H
+
+#define BCM6318_POWER_DOMAIN_PCIE	0
+#define BCM6318_POWER_DOMAIN_USB	1
+#define BCM6318_POWER_DOMAIN_EPHY0	2
+#define BCM6318_POWER_DOMAIN_EPHY1	3
+#define BCM6318_POWER_DOMAIN_EPHY2	4
+#define BCM6318_POWER_DOMAIN_EPHY3	5
+#define BCM6318_POWER_DOMAIN_LDO2P5	6
+#define BCM6318_POWER_DOMAIN_LDO2P9	7
+#define BCM6318_POWER_DOMAIN_SW1P0	8
+#define BCM6318_POWER_DOMAIN_PAD	9
+
+#endif /* __DT_BINDINGS_BMIPS_BCM6318_PM_H */
Signature · 1 line
2.26.2
#29 lore raw

PATCH v3 6/9 soc: bcm: add BCM63xx power domain driver

In reply to Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v3: Use dt-bindings definitions in power domain driver.
v2: Introduce bcm63xx folder in drivers/soc/bcm and update MAINTAINERS.

 MAINTAINERS                             |   1 +
 drivers/soc/bcm/Kconfig                 |  10 +
 drivers/soc/bcm/Makefile                |   1 +
 drivers/soc/bcm/bcm63xx/Kconfig         |  12 +
 drivers/soc/bcm/bcm63xx/Makefile        |   2 +
 drivers/soc/bcm/bcm63xx/bcm63xx-power.c | 378 ++++++++++++++++++++++++
 6 files changed, 404 insertions(+)
 create mode 100644 drivers/soc/bcm/bcm63xx/Kconfig
 create mode 100644 drivers/soc/bcm/bcm63xx/Makefile
 create mode 100644 drivers/soc/bcm/bcm63xx/bcm63xx-power.c
MAINTAINERS +1 -0
index 77a3fa5e3edd..e9ba7b955d5f 100644
@@ -3442,6 +3442,7 @@ F:	arch/mips/bmips/*
 F:	arch/mips/boot/dts/brcm/bcm*.dts*
 F:	arch/mips/include/asm/mach-bmips/*
 F:	arch/mips/kernel/*bmips*
+F:	drivers/soc/bcm/bcm63xx
 F:	drivers/irqchip/irq-bcm63*
 F:	drivers/irqchip/irq-bcm7*
 F:	drivers/irqchip/irq-brcmstb*
drivers/soc/bcm/Kconfig +10 -0
index 648e32693b7e..24f92a6e882a 100644
@@ -22,6 +22,15 @@ config RASPBERRYPI_POWER
 	  This enables support for the RPi power domains which can be enabled
 	  or disabled via the RPi firmware.
 
+config SOC_BCM63XX
+	bool "Broadcom 63xx SoC drivers"
+	depends on BMIPS_GENERIC || COMPILE_TEST
+	help
+	  Enables drivers for the Broadcom 63xx series of chips.
+	  Drivers can be enabled individually within this menu.
+
+	  If unsure, say N.
+
 config SOC_BRCMSTB
 	bool "Broadcom STB SoC drivers"
 	depends on ARM || ARM64 || BMIPS_GENERIC || COMPILE_TEST
@@ -33,6 +42,7 @@ config SOC_BRCMSTB
 
 	  If unsure, say N.
 
+source "drivers/soc/bcm/bcm63xx/Kconfig"
 source "drivers/soc/bcm/brcmstb/Kconfig"
 
 endmenu
drivers/soc/bcm/Makefile +1 -0
index d92268a829a9..7bc90e0bd773 100644
@@ -1,4 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
 obj-$(CONFIG_BCM2835_POWER)	+= bcm2835-power.o
 obj-$(CONFIG_RASPBERRYPI_POWER)	+= raspberrypi-power.o
+obj-$(CONFIG_SOC_BCM63XX)	+= bcm63xx/
 obj-$(CONFIG_SOC_BRCMSTB)	+= brcmstb/
drivers/soc/bcm/bcm63xx/Kconfig new file +12 -0
new file mode 100644
index 000000000000..16f648a6c70a
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: GPL-2.0-only
+if SOC_BCM63XX
+
+config BCM63XX_POWER
+	bool "BCM63xx power domain driver"
+	depends on BMIPS_GENERIC || (COMPILE_TEST && OF)
+	select PM_GENERIC_DOMAINS if PM
+	help
+	  This enables support for the BCM63xx power domains controller on
+	  BCM6318, BCM6328, BCM6362 and BCM63268 SoCs.
+
+endif # SOC_BCM63XX
drivers/soc/bcm/bcm63xx/Makefile new file +2 -0
new file mode 100644
index 000000000000..0710d5e018cc
@@ -0,0 +1,2 @@
+# SPDX-License-Identifier: GPL-2.0-only
+obj-$(CONFIG_BCM63XX_POWER) += bcm63xx-power.o
drivers/soc/bcm/bcm63xx/bcm63xx-power.c new file +378 -0

378 lines not on this page · raw message

Signature · 1 line
2.26.2
#30 lore raw

PATCH v3 7/9 mips: bmips: dts: add BCM6328 power domain support

In reply to Álvaro Fernández Rojas

BCM6328 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v3: Separate dt-bindings definitions from power domain .dtsi support.
v2: Add dt-bindings header files.

 arch/mips/boot/dts/brcm/bcm6328.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/mips/boot/dts/brcm/bcm6328.dtsi +6 -0
index af860d06def6..1f9edd710392 100644
@@ -110,6 +110,12 @@ leds0: led-controller@10000800 {
 			status = "disabled";
 		};
 
+		periph_pwr: power-controller@10001848 {
+			compatible = "brcm,bcm6328-power-controller";
+			reg = <0x10001848 0x4>;
+			#power-domain-cells = <1>;
+		};
+
 		ehci: usb@10002500 {
 			compatible = "brcm,bcm6328-ehci", "generic-ehci";
 			reg = <0x10002500 0x100>;
Signature · 1 line
2.26.2
#31 lore raw

PATCH v3 8/9 mips: bmips: dts: add BCM6362 power domain support

In reply to Álvaro Fernández Rojas

BCM6362 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v3: Separate dt-bindings definitions from power domain .dtsi support.
v2: Add dt-bindings header files.

 arch/mips/boot/dts/brcm/bcm6362.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/mips/boot/dts/brcm/bcm6362.dtsi +6 -0
index 8ae6981735b8..c98f9111e3c8 100644
@@ -108,6 +108,12 @@ uart1: serial@10000120 {
 			status = "disabled";
 		};
 
+		periph_pwr: power-controller@10001848 {
+			compatible = "brcm,bcm6362-power-controller";
+			reg = <0x10001848 0x4>;
+			#power-domain-cells = <1>;
+		};
+
 		leds0: led-controller@10001900 {
 			#address-cells = <1>;
 			#size-cells = <0>;
Signature · 1 line
2.26.2
#32 lore raw

PATCH v3 9/9 mips: bmips: dts: add BCM63268 power domain support

In reply to Álvaro Fernández Rojas

BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v3: Separate dt-bindings definitions from power domain .dtsi support.
v2: Add dt-bindings header files.

 arch/mips/boot/dts/brcm/bcm63268.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/mips/boot/dts/brcm/bcm63268.dtsi +6 -0
index beec24145af7..5acb49b61867 100644
@@ -117,6 +117,12 @@ leds0: led-controller@10001900 {
 			status = "disabled";
 		};
 
+		periph_pwr: power-controller@1000184c {
+			compatible = "brcm,bcm6328-power-controller";
+			reg = <0x1000184c 0x4>;
+			#power-domain-cells = <1>;
+		};
+
 		ehci: usb@10002500 {
 			compatible = "brcm,bcm63268-ehci", "generic-ehci";
 			reg = <0x10002500 0x100>;
Signature · 1 line
2.26.2
#33 lore raw

v4 cover bmips: add BCM63xx power domain controller

In reply to Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

v4: Fix device tree bindings documentation.
v3: Introduce changes suggested by Florian:
- Use dt-bindings definitions in power domain driver.
- Separate dt-bindings definitions from power domain .dtsi support.
v2: Introduce changes suggested by Florian:
- Add separate YAML file for dt-bindings.
- Add bcm63xx folder in drivers/soc/bcm.
- Update MAINTAINERS.
- Add dt-bindings header files.
- Also add BCM63268 support.

Álvaro Fernández Rojas (9):
dt-bindings: soc: brcm: add BCM63xx power domain binding
mips: bmips: add BCM6328 power domain definitions
mips: bmips: add BCM6362 power domain definitions
mips: bmips: add BCM63268 power domain definitions
mips: bmips: add BCM6318 power domain definitions
soc: bcm: add BCM63xx power domain driver
mips: bmips: dts: add BCM6328 power domain support
mips: bmips: dts: add BCM6362 power domain support
mips: bmips: dts: add BCM63268 power domain support

 .../bindings/power/brcm,bcm63xx-power.yaml    |  44 ++
 MAINTAINERS                                   |   1 +
 arch/mips/boot/dts/brcm/bcm63268.dtsi         |   6 +
 arch/mips/boot/dts/brcm/bcm6328.dtsi          |   6 +
 arch/mips/boot/dts/brcm/bcm6362.dtsi          |   6 +
 drivers/soc/bcm/Kconfig                       |  10 +
 drivers/soc/bcm/Makefile                      |   1 +
 drivers/soc/bcm/bcm63xx/Kconfig               |  12 +
 drivers/soc/bcm/bcm63xx/Makefile              |   2 +
 drivers/soc/bcm/bcm63xx/bcm63xx-power.c       | 378 ++++++++++++++++++
 include/dt-bindings/soc/bcm6318-pm.h          |  17 +
 include/dt-bindings/soc/bcm63268-pm.h         |  21 +
 include/dt-bindings/soc/bcm6328-pm.h          |  17 +
 include/dt-bindings/soc/bcm6362-pm.h          |  21 +
 14 files changed, 542 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/brcm,bcm63xx-power.yaml
 create mode 100644 drivers/soc/bcm/bcm63xx/Kconfig
 create mode 100644 drivers/soc/bcm/bcm63xx/Makefile
 create mode 100644 drivers/soc/bcm/bcm63xx/bcm63xx-power.c
 create mode 100644 include/dt-bindings/soc/bcm6318-pm.h
 create mode 100644 include/dt-bindings/soc/bcm63268-pm.h
 create mode 100644 include/dt-bindings/soc/bcm6328-pm.h
 create mode 100644 include/dt-bindings/soc/bcm6362-pm.h
Signature · 1 line
2.27.0
#34 lore raw

PATCH v4 1/9 dt-bindings: soc: brcm: add BCM63xx power domain binding

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v4: change license and move to bindings/power.
v3: fix reg maxItems and quote #power-domain-cells.
v2: Add separate YAML file.

 .../bindings/power/brcm,bcm63xx-power.yaml    | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/brcm,bcm63xx-power.yaml
Documentation/devicetree/bindings/power/brcm,bcm63xx-power.yaml new file +44 -0
new file mode 100644
index 000000000000..63b15ac6dde4
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/power/brcm,bcm63xx-power.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: BCM63xx power domain driver
+
+maintainers:
+  - Álvaro Fernández Rojas <[email protected]>
+
+description: |
+  BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller
+  to enable/disable certain components in order to save power.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - brcm,bcm6318-power-controller
+          - brcm,bcm6328-power-controller
+          - brcm,bcm6362-power-controller
+          - brcm,bcm63268-power-controller
+
+  reg:
+    maxItems: 1
+
+  "#power-domain-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - "#power-domain-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    periph_pwr: power-controller@10001848 {
+        compatible = "brcm,bcm6328-power-controller";
+        reg = <0x10001848 0x4>;
+        #power-domain-cells = <1>;
+    };
Signature · 1 line
2.27.0
maintainer Reviewed-by on v4 1/9
#35 lore raw

Re: [PATCH v4 1/9] dt-bindings: soc: brcm: add BCM63xx power domain binding

Quoted 5 lines · Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

Quoted 9 lines

---
v4: change license and move to bindings/power.
v3: fix reg maxItems and quote #power-domain-cells.
v2: Add separate YAML file.

 .../bindings/power/brcm,bcm63xx-power.yaml    | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/brcm,bcm63xx-power.yaml
#36 lore raw

PATCH v4 2/9 mips: bmips: add BCM6328 power domain definitions

In reply to Álvaro Fernández Rojas

BCM6328 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v4: Remove "dts: " from commit title.
v3: Separate dt-bindings definitions from power domain .dtsi support.

 include/dt-bindings/soc/bcm6328-pm.h | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm6328-pm.h
include/dt-bindings/soc/bcm6328-pm.h new file +17 -0
new file mode 100644
index 000000000000..557e1a69b7f7
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_BMIPS_BCM6328_PM_H
+#define __DT_BINDINGS_BMIPS_BCM6328_PM_H
+
+#define BCM6328_POWER_DOMAIN_ADSL2_MIPS	0
+#define BCM6328_POWER_DOMAIN_ADSL2_PHY	1
+#define BCM6328_POWER_DOMAIN_ADSL2_AFE	2
+#define BCM6328_POWER_DOMAIN_SAR	3
+#define BCM6328_POWER_DOMAIN_PCM	4
+#define BCM6328_POWER_DOMAIN_USBD	5
+#define BCM6328_POWER_DOMAIN_USBH	6
+#define BCM6328_POWER_DOMAIN_PCIE	7
+#define BCM6328_POWER_DOMAIN_ROBOSW	8
+#define BCM6328_POWER_DOMAIN_EPHY	9
+
+#endif /* __DT_BINDINGS_BMIPS_BCM6328_PM_H */
Signature · 7 lines
2.27.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer Reviewed-by on v4 2/9
#38 lore raw

Re: [PATCH v4 2/9] mips: bmips: add BCM6328 power domain definitions

In reply to Álvaro Fernández Rojas
Quoted 12 lines · Álvaro Fernández Rojas

BCM6328 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v4: Remove "dts: " from commit title.
v3: Separate dt-bindings definitions from power domain .dtsi support.

 include/dt-bindings/soc/bcm6328-pm.h | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm6328-pm.h
#39 lore raw

PATCH v4 3/9 mips: bmips: add BCM6362 power domain definitions

In reply to Álvaro Fernández Rojas

BCM6362 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v4: Remove "dts: " from commit title.
v3: Separate dt-bindings definitions from power domain .dtsi support.

 include/dt-bindings/soc/bcm6362-pm.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm6362-pm.h
include/dt-bindings/soc/bcm6362-pm.h new file +21 -0
new file mode 100644
index 000000000000..d087ba63c7a1
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_BMIPS_BCM6362_PM_H
+#define __DT_BINDINGS_BMIPS_BCM6362_PM_H
+
+#define BCM6362_POWER_DOMAIN_SAR	0
+#define BCM6362_POWER_DOMAIN_IPSEC	1
+#define BCM6362_POWER_DOMAIN_MIPS	2
+#define BCM6362_POWER_DOMAIN_DECT	3
+#define BCM6362_POWER_DOMAIN_USBH	4
+#define BCM6362_POWER_DOMAIN_USBD	5
+#define BCM6362_POWER_DOMAIN_ROBOSW	6
+#define BCM6362_POWER_DOMAIN_PCM	7
+#define BCM6362_POWER_DOMAIN_PERIPH	8
+#define BCM6362_POWER_DOMAIN_ADSL_PHY	9
+#define BCM6362_POWER_DOMAIN_GMII_PADS	10
+#define BCM6362_POWER_DOMAIN_FAP	11
+#define BCM6362_POWER_DOMAIN_PCIE	12
+#define BCM6362_POWER_DOMAIN_WLAN_PADS	13
+
+#endif /* __DT_BINDINGS_BMIPS_BCM6362_PM_H */
Signature · 1 line
2.27.0
maintainer Reviewed-by on v4 3/9
#41 lore raw

Re: [PATCH v4 3/9] mips: bmips: add BCM6362 power domain definitions

In reply to Álvaro Fernández Rojas
Quoted 12 lines · Álvaro Fernández Rojas

BCM6362 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v4: Remove "dts: " from commit title.
v3: Separate dt-bindings definitions from power domain .dtsi support.

 include/dt-bindings/soc/bcm6362-pm.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm6362-pm.h
#42 lore raw

PATCH v4 4/9 mips: bmips: add BCM63268 power domain definitions

In reply to Álvaro Fernández Rojas

BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v4: Remove "dts: " from commit title.
v3: Separate dt-bindings definitions from power domain .dtsi support.

 include/dt-bindings/soc/bcm63268-pm.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm63268-pm.h
include/dt-bindings/soc/bcm63268-pm.h new file +21 -0
new file mode 100644
index 000000000000..84ded53a732f
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_BMIPS_BCM63268_PM_H
+#define __DT_BINDINGS_BMIPS_BCM63268_PM_H
+
+#define BCM63268_POWER_DOMAIN_SAR	0
+#define BCM63268_POWER_DOMAIN_IPSEC	1
+#define BCM63268_POWER_DOMAIN_MIPS	2
+#define BCM63268_POWER_DOMAIN_DECT	3
+#define BCM63268_POWER_DOMAIN_USBH	4
+#define BCM63268_POWER_DOMAIN_USBD	5
+#define BCM63268_POWER_DOMAIN_ROBOSW	6
+#define BCM63268_POWER_DOMAIN_PCM	7
+#define BCM63268_POWER_DOMAIN_PERIPH	8
+#define BCM63268_POWER_DOMAIN_VDSL_PHY	9
+#define BCM63268_POWER_DOMAIN_VDSL_MIPS	10
+#define BCM63268_POWER_DOMAIN_FAP	11
+#define BCM63268_POWER_DOMAIN_PCIE	12
+#define BCM63268_POWER_DOMAIN_WLAN_PADS	13
+
+#endif /* __DT_BINDINGS_BMIPS_BCM63268_PM_H */
Signature · 1 line
2.27.0
maintainer Reviewed-by on v4 4/9
#44 lore raw

Re: [PATCH v4 4/9] mips: bmips: add BCM63268 power domain definitions

In reply to Álvaro Fernández Rojas
Quoted 12 lines · Álvaro Fernández Rojas

BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v4: Remove "dts: " from commit title.
v3: Separate dt-bindings definitions from power domain .dtsi support.

 include/dt-bindings/soc/bcm63268-pm.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm63268-pm.h
#45 lore raw

PATCH v4 5/9 mips: bmips: add BCM6318 power domain definitions

In reply to Álvaro Fernández Rojas

BCM6318 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v4: no changes.
v3: no changes (patch reordered).
v2: Add BCM6318 dt-bindings header file.

 include/dt-bindings/soc/bcm6318-pm.h | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm6318-pm.h
include/dt-bindings/soc/bcm6318-pm.h new file +17 -0
new file mode 100644
index 000000000000..05931dce8333
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_BMIPS_BCM6318_PM_H
+#define __DT_BINDINGS_BMIPS_BCM6318_PM_H
+
+#define BCM6318_POWER_DOMAIN_PCIE	0
+#define BCM6318_POWER_DOMAIN_USB	1
+#define BCM6318_POWER_DOMAIN_EPHY0	2
+#define BCM6318_POWER_DOMAIN_EPHY1	3
+#define BCM6318_POWER_DOMAIN_EPHY2	4
+#define BCM6318_POWER_DOMAIN_EPHY3	5
+#define BCM6318_POWER_DOMAIN_LDO2P5	6
+#define BCM6318_POWER_DOMAIN_LDO2P9	7
+#define BCM6318_POWER_DOMAIN_SW1P0	8
+#define BCM6318_POWER_DOMAIN_PAD	9
+
+#endif /* __DT_BINDINGS_BMIPS_BCM6318_PM_H */
Signature · 1 line
2.27.0
maintainer Reviewed-by on v4 5/9
#47 lore raw

Re: [PATCH v4 5/9] mips: bmips: add BCM6318 power domain definitions

In reply to Álvaro Fernández Rojas
Quoted 4 lines · Álvaro Fernández Rojas

BCM6318 SoCs have a power domain controller to enable/disable certain components in order to save power.

Quoted 9 lines

---
v4: no changes.
v3: no changes (patch reordered).
v2: Add BCM6318 dt-bindings header file.

 include/dt-bindings/soc/bcm6318-pm.h | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 include/dt-bindings/soc/bcm6318-pm.h
#48 lore raw

PATCH v4 6/9 soc: bcm: add BCM63xx power domain driver

In reply to Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v4: no changes.
v3: Use dt-bindings definitions in power domain driver.
v2: Introduce bcm63xx folder in drivers/soc/bcm and update MAINTAINERS.

 MAINTAINERS                             |   1 +
 drivers/soc/bcm/Kconfig                 |  10 +
 drivers/soc/bcm/Makefile                |   1 +
 drivers/soc/bcm/bcm63xx/Kconfig         |  12 +
 drivers/soc/bcm/bcm63xx/Makefile        |   2 +
 drivers/soc/bcm/bcm63xx/bcm63xx-power.c | 378 ++++++++++++++++++++++++
 6 files changed, 404 insertions(+)
 create mode 100644 drivers/soc/bcm/bcm63xx/Kconfig
 create mode 100644 drivers/soc/bcm/bcm63xx/Makefile
 create mode 100644 drivers/soc/bcm/bcm63xx/bcm63xx-power.c
MAINTAINERS +1 -0
index 56d7d27fc114..4eb0f248d440 100644
@@ -3450,6 +3450,7 @@ F:	arch/mips/bmips/*
 F:	arch/mips/boot/dts/brcm/bcm*.dts*
 F:	arch/mips/include/asm/mach-bmips/*
 F:	arch/mips/kernel/*bmips*
+F:	drivers/soc/bcm/bcm63xx
 F:	drivers/irqchip/irq-bcm63*
 F:	drivers/irqchip/irq-bcm7*
 F:	drivers/irqchip/irq-brcmstb*
drivers/soc/bcm/Kconfig +10 -0
index 648e32693b7e..24f92a6e882a 100644
@@ -22,6 +22,15 @@ config RASPBERRYPI_POWER
 	  This enables support for the RPi power domains which can be enabled
 	  or disabled via the RPi firmware.
 
+config SOC_BCM63XX
+	bool "Broadcom 63xx SoC drivers"
+	depends on BMIPS_GENERIC || COMPILE_TEST
+	help
+	  Enables drivers for the Broadcom 63xx series of chips.
+	  Drivers can be enabled individually within this menu.
+
+	  If unsure, say N.
+
 config SOC_BRCMSTB
 	bool "Broadcom STB SoC drivers"
 	depends on ARM || ARM64 || BMIPS_GENERIC || COMPILE_TEST
@@ -33,6 +42,7 @@ config SOC_BRCMSTB
 
 	  If unsure, say N.
 
+source "drivers/soc/bcm/bcm63xx/Kconfig"
 source "drivers/soc/bcm/brcmstb/Kconfig"
 
 endmenu
drivers/soc/bcm/Makefile +1 -0
index d92268a829a9..7bc90e0bd773 100644
@@ -1,4 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
 obj-$(CONFIG_BCM2835_POWER)	+= bcm2835-power.o
 obj-$(CONFIG_RASPBERRYPI_POWER)	+= raspberrypi-power.o
+obj-$(CONFIG_SOC_BCM63XX)	+= bcm63xx/
 obj-$(CONFIG_SOC_BRCMSTB)	+= brcmstb/
drivers/soc/bcm/bcm63xx/Kconfig new file +12 -0
new file mode 100644
index 000000000000..16f648a6c70a
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: GPL-2.0-only
+if SOC_BCM63XX
+
+config BCM63XX_POWER
+	bool "BCM63xx power domain driver"
+	depends on BMIPS_GENERIC || (COMPILE_TEST && OF)
+	select PM_GENERIC_DOMAINS if PM
+	help
+	  This enables support for the BCM63xx power domains controller on
+	  BCM6318, BCM6328, BCM6362 and BCM63268 SoCs.
+
+endif # SOC_BCM63XX
drivers/soc/bcm/bcm63xx/Makefile new file +2 -0
new file mode 100644
index 000000000000..0710d5e018cc
@@ -0,0 +1,2 @@
+# SPDX-License-Identifier: GPL-2.0-only
+obj-$(CONFIG_BCM63XX_POWER) += bcm63xx-power.o
drivers/soc/bcm/bcm63xx/bcm63xx-power.c new file +378 -0

378 lines not on this page · raw message

Signature · 1 line
2.27.0
#50 lore raw

PATCH v4 7/9 mips: bmips: dts: add BCM6328 power domain support

In reply to Álvaro Fernández Rojas

BCM6328 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v4: no changes.
v3: Separate dt-bindings definitions from power domain .dtsi support.
v2: Add dt-bindings header files.

 arch/mips/boot/dts/brcm/bcm6328.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/mips/boot/dts/brcm/bcm6328.dtsi +6 -0
index af860d06def6..1f9edd710392 100644
@@ -110,6 +110,12 @@ leds0: led-controller@10000800 {
 			status = "disabled";
 		};
 
+		periph_pwr: power-controller@10001848 {
+			compatible = "brcm,bcm6328-power-controller";
+			reg = <0x10001848 0x4>;
+			#power-domain-cells = <1>;
+		};
+
 		ehci: usb@10002500 {
 			compatible = "brcm,bcm6328-ehci", "generic-ehci";
 			reg = <0x10002500 0x100>;
Signature · 1 line
2.27.0
maintainer Acked-by on v4 7/9
#51 lore raw

Re: [PATCH v4 7/9] mips: bmips: dts: add BCM6328 power domain support

Quoted 5 lines · Álvaro Fernández Rojas

BCM6328 SoCs have a power domain controller to enable/disable certain components in order to save power.

Quoted 7 lines

---
v4: no changes.
v3: Separate dt-bindings definitions from power domain .dtsi support.
v2: Add dt-bindings header files.

 arch/mips/boot/dts/brcm/bcm6328.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
#52 lore raw

PATCH v4 8/9 mips: bmips: dts: add BCM6362 power domain support

In reply to Álvaro Fernández Rojas

BCM6362 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v4: no changes.
v3: Separate dt-bindings definitions from power domain .dtsi support.
v2: Add dt-bindings header files.

 arch/mips/boot/dts/brcm/bcm6362.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/mips/boot/dts/brcm/bcm6362.dtsi +6 -0
index 8ae6981735b8..c98f9111e3c8 100644
@@ -108,6 +108,12 @@ uart1: serial@10000120 {
 			status = "disabled";
 		};
 
+		periph_pwr: power-controller@10001848 {
+			compatible = "brcm,bcm6362-power-controller";
+			reg = <0x10001848 0x4>;
+			#power-domain-cells = <1>;
+		};
+
 		leds0: led-controller@10001900 {
 			#address-cells = <1>;
 			#size-cells = <0>;
Signature · 1 line
2.27.0
maintainer Acked-by on v4 8/9
#53 lore raw

Re: [PATCH v4 8/9] mips: bmips: dts: add BCM6362 power domain support

Quoted 5 lines · Álvaro Fernández Rojas

BCM6362 SoCs have a power domain controller to enable/disable certain components in order to save power.

Quoted 7 lines

---
v4: no changes.
v3: Separate dt-bindings definitions from power domain .dtsi support.
v2: Add dt-bindings header files.

 arch/mips/boot/dts/brcm/bcm6362.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
#54 lore raw

PATCH v4 9/9 mips: bmips: dts: add BCM63268 power domain support

In reply to Álvaro Fernández Rojas

BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v4: no changes.
v3: Separate dt-bindings definitions from power domain .dtsi support.
v2: Add dt-bindings header files.

 arch/mips/boot/dts/brcm/bcm63268.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/mips/boot/dts/brcm/bcm63268.dtsi +6 -0
index beec24145af7..5acb49b61867 100644
@@ -117,6 +117,12 @@ leds0: led-controller@10001900 {
 			status = "disabled";
 		};
 
+		periph_pwr: power-controller@1000184c {
+			compatible = "brcm,bcm6328-power-controller";
+			reg = <0x1000184c 0x4>;
+			#power-domain-cells = <1>;
+		};
+
 		ehci: usb@10002500 {
 			compatible = "brcm,bcm63268-ehci", "generic-ehci";
 			reg = <0x10002500 0x100>;
Signature · 1 line
2.27.0
maintainer Acked-by on v4 9/9
#56 lore raw

Re: [PATCH v4 9/9] mips: bmips: dts: add BCM63268 power domain support

In reply to Álvaro Fernández Rojas
Quoted 11 lines · Álvaro Fernández Rojas

BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

---
v4: no changes.
v3: Separate dt-bindings definitions from power domain .dtsi support.
v2: Add dt-bindings header files.

 arch/mips/boot/dts/brcm/bcm63268.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
#57 lore raw
In reply to Álvaro Fernández Rojas
Quoted 13 lines · Álvaro Fernández Rojas

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power.

v4: Fix device tree bindings documentation.
v3: Introduce changes suggested by Florian:
- Use dt-bindings definitions in power domain driver.
- Separate dt-bindings definitions from power domain .dtsi support.
v2: Introduce changes suggested by Florian:
- Add separate YAML file for dt-bindings.
- Add bcm63xx folder in drivers/soc/bcm.
- Update MAINTAINERS.
- Add dt-bindings header files.
- Also add BCM63268 support.

Series applied to drivers/next after capitalizing MIPS and BMIPS to follow prior contributions to these files, thanks!

Signature · 1 line
Florian