Skip to contentSkip to conversation

ACPI: processor: Refine messages in acpi_early_processor_control_setup()

PATCH In review Rafael J. Wysocki 2 participants 2 messages Jul 19, 2023 – Jul 20, 2023 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: processor: Refine messages in acpi_early_processor_control_setup()

From: Rafael J. Wysocki <[email protected]>

The source and meaning of the messages printed by acpi_early_processor_control_setup() is unclear, so add a pr_fmt() definition to acpi_processor.c and expand the messages to make it clear that they are about CPUs.

---

Based on linux-next.

---
 drivers/acpi/acpi_processor.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/acpi/acpi_processor.c +3 -2
Index: linux-pm/drivers/acpi/acpi_processor.c
===================================================================
@@ -9,6 +9,7 @@
  * Copyright (C) 2013, Intel Corporation
  *                     Rafael J. Wysocki <[email protected]>
  */
+#define pr_fmt(fmt) "ACPI: " fmt
 
 #include <linux/acpi.h>
 #include <linux/device.h>
@@ -611,9 +612,9 @@ static bool __init acpi_early_processor_
 void __init acpi_early_processor_control_setup(void)
 {
 	if (acpi_early_processor_osc()) {
-		pr_info("_OSC evaluated successfully\n");
+		pr_info("_OSC evaluated successfully for all CPUs\n");
 	} else {
-		pr_info("_OSC evaluation failed, trying _PDC\n");
+		pr_info("_OSC evaluation for CPUs failed, trying _PDC\n");
 		acpi_early_processor_set_pdc();
 	}
 }
Reviewed-by on v1 1/1
#1 lore raw
Quoted 30 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

The source and meaning of the messages printed by acpi_early_processor_control_setup() is unclear, so add a pr_fmt() definition to acpi_processor.c and expand the messages to make it clear that they are about CPUs.

---

Based on linux-next.

---
 drivers/acpi/acpi_processor.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: linux-pm/drivers/acpi/acpi_processor.c
===================================================================

drivers/acpi/acpi_processor.c +1 -0
@@ -9,6 +9,7 @@
  * Copyright (C) 2013, Intel Corporation
  *                     Rafael J. Wysocki <[email protected]>
  */
+#define pr_fmt(fmt) "ACPI: " fmt
 
 #include <linux/acpi.h>
 #include <linux/device.h>
@@ -611,9 +612,9 @@ static bool __init acpi_early_processor_
 void __init acpi_early_processor_control_setup(void)

drivers/acpi/acpi_processor.c static bool __init acpi_early_processor_ · line 620

Quoted 10 lines
drivers/acpi/acpi_processor.c +2 -2
 {
 	if (acpi_early_processor_osc()) {
-		pr_info("_OSC evaluated successfully\n");
+		pr_info("_OSC evaluated successfully for all CPUs\n");
 	} else {
-		pr_info("_OSC evaluation failed, trying _PDC\n");
+		pr_info("_OSC evaluation for CPUs failed, trying _PDC\n");
 		acpi_early_processor_set_pdc();
 	}
 }

Looks good to me,

Quoted 3 lines