Skip to contentSkip to conversation

mm: export "high_memory" symbol on !MMU

PATCH In review Arnd Bergmann 3 participants 3 messages Jan 28, 2015 – Feb 2, 2015

Subsystems (2)
Memory management Memory mapping
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 mm: export "high_memory" symbol on !MMU

Quoted 1 line

From f391eb37fafc8a22d7fd9574b8d220f0d90a91d0 Mon Sep 17 00:00:00 2001

From: Arnd Bergmann <[email protected]>
Date: Mon, 25 Aug 2014 16:24:41 +0200
Subject: [PATCH] mm: export "high_memory" symbol on !MMU

The symbol 'high_memory' is provided on both MMU- and NOMMU-kernels, but only one of them is exported, which leads to module build errors in drivers that work fine built-in:

ERROR: "high_memory" [drivers/net/virtio_net.ko] undefined!
ERROR: "high_memory" [drivers/net/ppp/ppp_mppe.ko] undefined!
ERROR: "high_memory" [drivers/mtd/nand/nand.ko] undefined!
ERROR: "high_memory" [crypto/tcrypt.ko] undefined!
ERROR: "high_memory" [crypto/cts.ko] undefined!

This exports the symbol to get these to work on NOMMU as well.

Signed-off-by Arnd Bergmann <[email protected]>
mm/nommu.c +1 -0
index e9228cbe46de..7bdeb281ad0e 100644
@@ -59,6 +59,7 @@
 #endif
 
 void *high_memory;
+EXPORT_SYMBOL(high_memory);
 struct page *mem_map;
 unsigned long max_mapnr;
 unsigned long highest_memmap_pfn;
Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Arnd Bergmann
Quoted 1 line

From f391eb37fafc8a22d7fd9574b8d220f0d90a91d0 Mon Sep 17 00:00:00 2001

From: Arnd Bergmann <[email protected]>
Date: Mon, 25 Aug 2014 16:24:41 +0200
Subject: [PATCH] mm: export "high_memory" symbol on !MMU

The symbol 'high_memory' is provided on both MMU- and NOMMU-kernels, but only one of them is exported, which leads to module build errors in drivers that work fine built-in:

ERROR: "high_memory" [drivers/net/virtio_net.ko] undefined!
ERROR: "high_memory" [drivers/net/ppp/ppp_mppe.ko] undefined!
ERROR: "high_memory" [drivers/mtd/nand/nand.ko] undefined!
ERROR: "high_memory" [crypto/tcrypt.ko] undefined!
ERROR: "high_memory" [crypto/cts.ko] undefined!

Quoted 3 lines

This exports the symbol to get these to work on NOMMU as well.

Signed-off-by Arnd Bergmann <[email protected]>

Here is an ack if you want one:

Acked-by Greg Ungerer <[email protected]>

Regards
Greg

Quoted 7 lines
mm/nommu.c +0 -0
index e9228cbe46de..7bdeb281ad0e 100644

mm/nommu.c line 65

Quoted 7 lines
mm/nommu.c +1 -0
@@ -59,6 +59,7 @@
 #endif
 
 void *high_memory;
+EXPORT_SYMBOL(high_memory);
 struct page *mem_map;
 unsigned long max_mapnr;
 unsigned long highest_memmap_pfn;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Acked-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann
Quoted 10 lines · Arnd Bergmann

The symbol 'high_memory' is provided on both MMU- and NOMMU-kernels, but only one of them is exported, which leads to module build errors in drivers that work fine built-in:

ERROR: "high_memory" [drivers/net/virtio_net.ko] undefined!
ERROR: "high_memory" [drivers/net/ppp/ppp_mppe.ko] undefined!
ERROR: "high_memory" [drivers/mtd/nand/nand.ko] undefined!
ERROR: "high_memory" [crypto/tcrypt.ko] undefined!
ERROR: "high_memory" [crypto/cts.ko] undefined!

Quoted 3 lines

This exports the symbol to get these to work on NOMMU as well.

Signed-off-by Arnd Bergmann <[email protected]>
Acked-by David Rientjes <[email protected]>