sched: update profile oversubscribe config file
PATCH 1/1 sched: update profile oversubscribe config file
update the profile_ov config file to support dynamic update of subport rate.
--- examples/qos_sched/profile_ov.cfg | 3 +++ 1 file changed, 3 insertions(+)
examples/qos_sched/profile_ov.cfg +3 -0
@@ -11,6 +11,9 @@ number of subports per port = 1 number of pipes per subport = 32 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 +subport 0-8 = 0 + +[subport profile 0] tb rate = 8400000 ; Bytes per second tb size = 100000 ; Bytes
Signature · 1 line
2.17.1
PATCH v2 1/1 examples/qos_sched: update profile oversubscribe config file
update the profile_ov config file to support dynamic update of subport rate.
---
v2: renamed the commit subject.
--- examples/qos_sched/profile_ov.cfg | 3 +++ 1 file changed, 3 insertions(+)
examples/qos_sched/profile_ov.cfg +3 -0
@@ -11,6 +11,9 @@ number of subports per port = 1 number of pipes per subport = 32 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 +subport 0-8 = 0 + +[subport profile 0] tb rate = 8400000 ; Bytes per second tb size = 100000 ; Bytes
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file
Quoted 37 lines
-----Original Message-----
From: Dharmappa, Savinay <[email protected]>
Sent: Tuesday, October 27, 2020 9:22 AM
To: Dumitrescu, Cristian <[email protected]>; Singh, Jasvinder <[email protected]>; [email protected]
Cc: Dharmappa, Savinay <[email protected]>
Subject: [PATCH v2] examples/qos_sched: update profile oversubscribe config fileupdate the
profile_ovconfig file to support dynamic update of subport rate.Signed-off-by Savinay Dharmappa <[email protected]>---
v2: renamed the commit subject.--- examples/qos_sched/profile_ov.cfg | 3 +++ 1 file changed, 3 insertions(+)examples/qos_sched/profile_ov.cfg +3
-1@@ -11,6 +11,9 @@ number of subports per port = 1 number of pipes per subport = 32 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 +subport 0-8 = 0 + +[subport profile 0] tb rate = 8400000 ; Bytes per second tb size = 100000 ; Bytes --
Quoted 1 line
2.17.1
Dharmappa, Savinay
Acked-by Cristian DumitrescuRe: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file
-----Original Message-----
From: Dumitrescu, Cristian <[email protected]>
Sent: Tuesday, October 27, 2020 3:16 PM
To: Dharmappa, Savinay <[email protected]>; Singh, Jasvinder <[email protected]>; [email protected]
Subject: RE: [PATCH v2] examples/qos_sched: update profile oversubscribe config file
Quoted 34 lines
-----Original Message-----
From: Dharmappa, Savinay <[email protected]>
Sent: Tuesday, October 27, 2020 9:22 AM
To: Dumitrescu, Cristian <[email protected]>; Singh, Jasvinder <[email protected]>; [email protected]
Cc: Dharmappa, Savinay <[email protected]>
Subject: [PATCH v2] examples/qos_sched: update profile oversubscribe config fileupdate the
profile_ovconfig file to support dynamic update of subport rate.Signed-off-by Savinay Dharmappa <[email protected]>---
v2: renamed the commit subject.--- examples/qos_sched/profile_ov.cfg | 3 +++ 1 file changed, 3 insertions(+)examples/qos_sched/profile_ov.cfg +0
-0@@ -11,6 +11,9 @@ number of subports per port = 1 number of pipes persubport = 32 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
examples/qos_sched/profile_ov.cfg +3
-1+subport 0-8 = 0 + +[subport profile 0] tb rate = 8400000 ; Bytes per second tb size = 100000 ; Bytes --
Quoted 1 line
2.17.1
Hi Thomas,
Quoted 1 line
Quoted 1 line
I see that this patch is not applied on rc2. When can this will be applied ? will it be part of rc3 ?. Please let me know
Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file
05/11/2020 10:39, Dharmappa, Savinay:
Quoted 3 lines
Hi Thomas,
I see that this patch is not applied on rc2. When can this will be applied ? will it be part of rc3 ?. Please let me know
-rc2 was very busy, and examples were low priority. Will look into examples for -rc3.
Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file
In reply to Dharmappa, SavinayQuoted 2 lines · Savinay
Hi Thomas,
Quoted 1 line
Quoted 1 line
I see that this patch is not applied on rc2. When can this will be applied ? will it be part of rc3 ?. Please let me know
Please, pay attention when editing replies, this mail of yours added Cristian token again in patchwork.
The commitlog is vague and gives no context.
I looked through patchwork and found:
https://patchwork.dpdk.org/patch/81666/
So, iiuc, you forgot to update those two examples configuration file and documentations.
If so, please submit one patch fixing the qos_sched example (both config and doc) and another patch for fixing the ip_pipeline (doc). In both of them, describe with a Fixes: tag which commits are being fixed.
Signature · 1 line
David Marchand
Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file
-----Original Message-----
From: David Marchand <[email protected]>
Sent: Friday, November 13, 2020 7:28 PM
To: Dharmappa, Savinay <[email protected]>
Cc: Dumitrescu, Cristian <[email protected]>; Singh, Jasvinder <[email protected]>; [email protected]; Thomas Monjalon <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file
Quoted 3 lines · Savinay
Hi Thomas,
Quoted 2 lines
Quoted 2 lines
I see that this patch is not applied on rc2. When can this will be applied ? will it be part of rc3 ?. Please let me know
Please, pay attention when editing replies, this mail of yours added Cristian token again in patchwork.
The commitlog is vague and gives no context.
I looked through patchwork and found:
https://patchwork.dpdk.org/patch/81666/
So, iiuc, you forgot to update those two examples configuration file and documentations.
If so, please submit one patch fixing the qos_sched example (both config and doc) and another patch for fixing the ip_pipeline (doc). In both of them, describe with a Fixes: tag which commits are being fixed.
Quoted 1 line
Quoted 1 line
Instead of new patch shall I send v3 of this patch which has (both config and doc) and similarly for https://patchwork.dpdk.org/patch/81666/ patch to have only
ip_pipeline(doc). Please let me know.
--
David Marchand
Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file
Quoted 4 lines · Savinay
If so, please submit one patch fixing the
qos_schedexample (both config and doc) and another patch for fixing theip_pipeline(doc). In both of them, describe with a Fixes: tag which commits are being fixed.Quoted 1 line
Quoted 1 line
Instead of new patch shall I send v3 of this patch which has (both config and doc) and similarly for https://patchwork.dpdk.org/patch/81666/ patch to have only
ip_pipeline(doc). Please let me know.
Yes, one patch for qos_shed and one patch for ip_pipeline.
Signature · 1 line
David Marchand
PATCH v3 1/1 examples/qos_sched: update profile config file
In reply to Savinay Dharmappaupdate the qos_sched user guide and profile config file with default subport profile.
---
v3: addressed the review comments of patch v2
--- doc/guides/sample_app_ug/qos_scheduler.rst | 4 ++++ examples/qos_sched/profile_ov.cfg | 3 +++ 2 files changed, 7 insertions(+)
doc/guides/sample_app_ug/qos_scheduler.rst +4 -0
@@ -135,6 +135,10 @@ The profile file has the following format: [subport 0] number of pipes per subport = 4096 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 + + subport 0-8 = 0 ; These subports are configured with subport profile 0 + + [subport profile 0] tb rate = 1250000000; Bytes per second tb size = 1000000; Bytes tc 0 rate = 1250000000; Bytes per second
examples/qos_sched/profile_ov.cfg +3 -0
@@ -11,6 +11,9 @@ number of subports per port = 1 number of pipes per subport = 32 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 +subport 0-8 = 0 + +[subport profile 0] tb rate = 8400000 ; Bytes per second tb size = 100000 ; Bytes
Signature · 1 line
2.17.1
David Marchand
AppliedRe: [dpdk-dev] [PATCH v3] examples/qos_sched: update profile config file
Quoted 8 lines · Savinay Dharmappa
update the
qos_scheduser guide and profile config file with default subport profile.Fixes 802d214dc880 ("examples/qos_sched: update subport rate dynamically")Signed-off-by Savinay Dharmappa <[email protected]>
Applied, thanks.
Signature · 1 line
David Marchand