Skip to contentSkip to conversation

PM / OPP: Make OPP invisible to users in Kconfig

PATCH Applied Mark Brown 4 participants 4 messages May 9, 2014 – May 19, 2014

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 PM / OPP: Make OPP invisible to users in Kconfig

From: Mark Brown <[email protected]>

The OPP code is an in kernel library selected by its users, there is no no architecture code required to implement it and enabling it without a user just increases the kernel size. Since the users select rather than depend on it just remove the ability to directly set the option from Kconfig.

---

This leaves the ARCH_HAS_OPP symbol since removing that requires updating the relevant architectures, if this is OK I can sumbit a followup patch cleaning that up.

 kernel/power/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
kernel/power/Kconfig +1 -2
index 2fac9cc79b3d..9a83d780facd 100644
@@ -257,8 +257,7 @@ config ARCH_HAS_OPP
 	bool
 
 config PM_OPP
-	bool "Operating Performance Point (OPP) Layer library"
-	depends on ARCH_HAS_OPP
+	bool
 	---help---
 	  SOCs have a standard set of tuples consisting of frequency and
 	  voltage pairs that the device will support per voltage domain. This
Signature · 1 line
2.0.0.rc2
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Mark Brown

From: Mark Brown <[email protected]>

The OPP code is an in kernel library selected by its users, there is no no architecture code required to implement it and enabling it without a user just increases the kernel size. Since the users select rather than depend on it just remove the ability to directly set the option from Kconfig.

Quoted 7 lines

---

This leaves the ARCH_HAS_OPP symbol since removing that requires updating the relevant architectures, if this is OK I can sumbit a followup patch cleaning that up.

Quoted 20 lines
 kernel/power/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
kernel/power/Kconfig +1 -3
index 2fac9cc79b3d..9a83d780facd 100644
@@ -257,8 +257,7 @@ config ARCH_HAS_OPP
        bool
 
 config PM_OPP
-       bool "Operating Performance Point (OPP) Layer library"
-       depends on ARCH_HAS_OPP
+       bool
        ---help---
          SOCs have a standard set of tuples consisting of frequency and
          voltage pairs that the device will support per voltage domain. This
--

2.0.0.rc2

Acked-by on v1 1/1
#2 lore raw
In reply to Mark Brown
Quoted 4 lines · Mark Brown

From: Mark Brown <[email protected]>

The OPP code is an in kernel library selected by its users, there is no no architecture code required to implement it and enabling it without a

s/no no/no

Quoted 5 lines

user just increases the kernel size. Since the users select rather than depend on it just remove the ability to directly set the option from Kconfig.

Quoted 8 lines

---

This leaves the ARCH_HAS_OPP symbol since removing that requires updating the relevant architectures, if this is OK I can sumbit a followup patch cleaning that up.

 kernel/power/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
#3 lore raw
Quoted 15 lines · Viresh Kumar
Quoted 4 lines · Mark Brown

From: Mark Brown <[email protected]>

The OPP code is an in kernel library selected by its users, there is no no architecture code required to implement it and enabling it without a

s/no no/no

Quoted 7 lines

user just increases the kernel size. Since the users select rather than depend on it just remove the ability to directly set the option from Kconfig.

---

Quoted 8 lines
Quoted 6 lines

This leaves the ARCH_HAS_OPP symbol since removing that requires updating the relevant architectures, if this is OK I can sumbit a followup patch cleaning that up.

 kernel/power/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Queued up for 3.16, thanks!

Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.