Skip to contentSkip to conversation

powerpc/power8: fix secondary CPUs hanging on boot for HV=0

PATCH In review Michael Neuling 2 participants 2 messages Apr 25, 2013 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/power8: fix secondary CPUs hanging on boot for HV=0

In __restore_cpu_power8 we determine if we are HV and if not, we return before setting HV only resources.

Unfortunately we forgot to restore the link register from r11 before returning.

This will happen on boot and with secondary CPUs not coming online.

This adds the missing link register restore.

arch/powerpc/kernel/cpu_setup_power.S +1 -0
index ea847ab..1167008 100644
@@ -66,6 +66,7 @@ _GLOBAL(__restore_cpu_power8)
 	bl	__init_FSCR
 	mfmsr	r3
 	rldicl.	r0,r3,4,63
+	mtlr	r11
 	beqlr
 	li	r0,0
 	mtspr	SPRN_LPID,r0
#1 lore raw
Quoted 11 lines · Michael Neuling

In __restore_cpu_power8 we determine if we are HV and if not, we return before setting HV only resources.

Unfortunately we forgot to restore the link register from r11 before returning.

This will happen on boot and with secondary CPUs not coming online.

This adds the missing link register restore.

Quoted 13 lines
arch/powerpc/kernel/cpu_setup_power.S +1 -0
index ea847ab..1167008 100644
@@ -66,6 +66,7 @@ _GLOBAL(__restore_cpu_power8)
 	bl	__init_FSCR
 	mfmsr	r3
 	rldicl.	r0,r3,4,63
+	mtlr	r11
 	beqlr
 	li	r0,0
 	mtspr	SPRN_LPID,r0