Skip to contentSkip to conversation

c-test-tutorial-simple.txt: improve documentation

PATCH In review Avinesh Kumar 2 participants 4 messages Jan 11, 2023 – Jan 13, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 c-test-tutorial-simple.txt: improve documentation

---
 doc/c-test-tutorial-simple.txt | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
doc/c-test-tutorial-simple.txt +6 -6
index 89b0ad4e7..c5861cb36 100644
@@ -333,16 +333,16 @@ call in the +*.in+ files (e.g. +x86_64.in+) which are used to generate
 may find the system call number is missing from the +*.in+ files and will need
 to add it (see +include/lapi/syscalls/strip_syscall.awk+).
 
-System call numbers vary between architectures, hence why there are multiple
+System call numbers vary between architectures, hence there are multiple
 +*.in+ files for each architecture. You can find the various values for the
-+statx+ system call across a number of +uinstd.h+ files in the Linux kernel.
++statx+ system call across a number of +unistd.h+ files in the Linux kernel.
 
 Note that we don't use the system-call-identifier value available in
-+/usr/include/linux/uinstd.h+ because the kernel might be much newer than the
++/include/uapi/linux/unistd.h+ because the kernel might be much newer than the
 user land development packages.
 
-For +statx+ we had to add +statx 332+ to +testcases/kernel/include/x86_64.in+,
-+statx 383+ to +testcases/kernel/include/powerpc.in+, etc.  Now lets look at
+For +statx+ we had to add +statx 332+ to +include/lapi/syscalls/x86_64.in+,
++statx 383+ to +include/lapi/syscalls/powerpc.in+, etc.  Now lets look at
 the code, which I will explain in more detail further down.
 
 [source,c]
@@ -1007,7 +1007,7 @@ We can then send this patch with the following command sans +--dry-run+.
 $ git send-email --dry-run output/v2-0001-tutorial-Add-a-step-by-step-C-test-tutorial.patch
 --------------------------------------------------------------------------------
 
-Git will ask some questions (which you an ignore) and then tell you what it
+Git will ask some questions (which you can ignore) and then tell you what it
 would do if this weren't a dry-run. In order for this to work you have to have
 a valid SMTP server set in +.gitconfig+ and also be signed up to the LTP
 mailing list under the same e-mail address you have configured in Git. You can
Signature · 5 lines
2.39.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v1 1/1
#1 lore raw

Hi Avinesh,

Quoted 12 lines
---
 doc/c-test-tutorial-simple.txt | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
doc/c-test-tutorial-simple.txt +0 -0
index 89b0ad4e7..c5861cb36 100644
@@ -333,16 +333,16 @@ call in the +*.in+ files (e.g. +x86_64.in+) which are used to generate
 may find the system call number is missing from the +*.in+ files and will need
 to add it (see +include/lapi/syscalls/strip_syscall.awk+).

doc/c-test-tutorial-simple.txt call in the +*.in+ files (e.g. +x86_64.in+) which are used to generate · line 341

Quoted 10 lines
doc/c-test-tutorial-simple.txt +3 -3
 
-System call numbers vary between architectures, hence why there are multiple
+System call numbers vary between architectures, hence there are multiple
 +*.in+ files for each architecture. You can find the various values for the
-+statx+ system call across a number of +uinstd.h+ files in the Linux kernel.
++statx+ system call across a number of +unistd.h+ files in the Linux kernel.
 
 Note that we don't use the system-call-identifier value available in
-+/usr/include/linux/uinstd.h+ because the kernel might be much newer than the
++/include/uapi/linux/unistd.h+ because the kernel might be much newer than the

NOTE: /include/uapi/linux/unistd.h does not exists. include/uapi/linux/unistd.h is relative path in kernel git tree. The same file exists as /usr/include/linux/unistd.h as part of kernel headers distro package.

I'd prefer to keep /usr/include/linux/unistd.h as a real path.

The other changes are good. Thank you for carefully reading docs and fixing them!

Kind regards,
Petr

Quoted 18 lines
doc/c-test-tutorial-simple.txt +3 -3
 user land development packages.
 
-For +statx+ we had to add +statx 332+ to +testcases/kernel/include/x86_64.in+,
-+statx 383+ to +testcases/kernel/include/powerpc.in+, etc.  Now lets look at
+For +statx+ we had to add +statx 332+ to +include/lapi/syscalls/x86_64.in+,
++statx 383+ to +include/lapi/syscalls/powerpc.in+, etc.  Now lets look at
 the code, which I will explain in more detail further down.
 
 [source,c]
@@ -1007,7 +1007,7 @@ We can then send this patch with the following command sans +--dry-run+.
 $ git send-email --dry-run output/v2-0001-tutorial-Add-a-step-by-step-C-test-tutorial.patch
 --------------------------------------------------------------------------------
 
-Git will ask some questions (which you an ignore) and then tell you what it
+Git will ask some questions (which you can ignore) and then tell you what it
 would do if this weren't a dry-run. In order for this to work you have to have
 a valid SMTP server set in +.gitconfig+ and also be signed up to the LTP
 mailing list under the same e-mail address you have configured in Git. You can
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Hi Petr,

Quoted 21 lines · IST Petr Vorel

Hi Avinesh,

Quoted 18 lines
---
 doc/c-test-tutorial-simple.txt | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
doc/c-test-tutorial-simple.txt +2 -2
index 89b0ad4e7..c5861cb36 100644
@@ -333,16 +333,16 @@ call in the +*.in+ files (e.g. +x86_64.in+) which are used to generate
 may find the system call number is missing from the +*.in+ files and will need
 to add it (see +include/lapi/syscalls/strip_syscall.awk+).
 
-System call numbers vary between architectures, hence why there are multiple
+System call numbers vary between architectures, hence there are multiple
 +*.in+ files for each architecture. You can find the various values for the
-+statx+ system call across a number of +uinstd.h+ files in the Linux kernel.
++statx+ system call across a number of +unistd.h+ files in the Linux kernel.
Quoted 8 lines

doc/c-test-tutorial-simple.txt call in the +*.in+ files (e.g. +x86_64.in+) which are used to generate · line 341

Quoted 3 lines
doc/c-test-tutorial-simple.txt +1 -1
 Note that we don't use the system-call-identifier value available in
-+/usr/include/linux/uinstd.h+ because the kernel might be much newer than the
++/include/uapi/linux/unistd.h+ because the kernel might be much newer than the

NOTE: /include/uapi/linux/unistd.h does not exists. include/uapi/linux/unistd.h is relative path in kernel git tree. The same file exists as /usr/include/linux/unistd.h as part of kernel headers distro package.

I'd prefer to keep /usr/include/linux/unistd.h as a real path.

Thank you for your review and correcting this.

Quoted 22 lines

The other changes are good. Thank you for carefully reading docs and fixing them!

Kind regards,
Petr

Quoted 12 lines
doc/c-test-tutorial-simple.txt +2 -2
 user land development packages.
 
-For +statx+ we had to add +statx 332+ to +testcases/kernel/include/x86_64.in+,
-+statx 383+ to +testcases/kernel/include/powerpc.in+, etc.  Now lets look at
+For +statx+ we had to add +statx 332+ to +include/lapi/syscalls/x86_64.in+,
++statx 383+ to +include/lapi/syscalls/powerpc.in+, etc.  Now lets look at
 the code, which I will explain in more detail further down.
 
 [source,c]
@@ -1007,7 +1007,7 @@ We can then send this patch with the following command sans +--dry-run+.
 $ git send-email --dry-run output/v2-0001-tutorial-Add-a-step-by-step-C-test-tutorial.patch
 --------------------------------------------------------------------------------
Quoted 6 lines

doc/c-test-tutorial-simple.txt We can then send this patch with the following command sans +--dry-run+. · line 1013

Quoted 5 lines
doc/c-test-tutorial-simple.txt +1 -1
-Git will ask some questions (which you an ignore) and then tell you what it
+Git will ask some questions (which you can ignore) and then tell you what it
 would do if this weren't a dry-run. In order for this to work you have to have
 a valid SMTP server set in +.gitconfig+ and also be signed up to the LTP
 mailing list under the same e-mail address you have configured in Git. You can

Regards,
Avinesh

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw
In reply to Petr Vorel

Hi Avinesh,

thanks a lot, merged (with the change to keep path to header).

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp