s390x: Clear RAM on diag308 subcode 3 reset
PATCH 1/1 s390x: Clear RAM on diag308 subcode 3 reset
The reset performed by subcode 3 of the diag308 instruction specifies that system memory should be reset. This patch implements that behaviour.
Introduce S390_RESET_REIPL_CLEAR to differentiate between subcode 3 and subcode 4 resets.
When doing a clear reset, discard the ramblock containing the system ram.
--- hw/s390x/ipl.h | 1 + hw/s390x/s390-virtio-ccw.c | 6 ++++++ target/s390x/diag.c | 3 +-- target/s390x/kvm/kvm.c | 6 +++++- 4 files changed, 13 insertions(+), 3 deletions(-)
hw/s390x/ipl.h +1 -0
@@ -38,6 +38,7 @@ enum s390_reset {/* default is a reset not triggered by a CPU e.g. issued by QMP */ S390_RESET_EXTERNAL =0 ,S390_RESET_REIPL , +S390_RESET_REIPL_CLEAR ,S390_RESET_MODIFIED_CLEAR ,S390_RESET_LOAD_NORMAL , S390_RESET_PV,
hw/s390x/s390-virtio-ccw.c +6 -0
@@ -455,6 +455,7 @@ static void s390_machine_reset(MachineState *machine, ResetType type)enum s390_reset reset_type;CPUState *cs, *t;S390CPU *cpu; +RAMBlock *rb = machine->ram->ram_block;/* * Temporarily drop the record/replay mutex to let rr_cpu_thread_fn()
@@ -479,6 +480,7 @@ static void s390_machine_reset(MachineState *machine, ResetType type)switch (reset_type) {case S390_RESET_EXTERNAL :case S390_RESET_REIPL : +case S390_RESET_REIPL_CLEAR :/* * Reset the subsystem which includes a AP reset. If a PV * guest had APQNs attached the AP reset is a prerequisite to
@@ -489,6 +491,10 @@ static void s390_machine_reset(MachineState *machine, ResetType type)s390_machine_unprotect (ms); } +if (reset_type ==S390_RESET_REIPL_CLEAR ) { +ram_block_discard_range (rb,0 ,qemu_ram_get_used_length (rb)); + } +/* * Device reset includes CPU clear resets so this has to be * done AFTER the unprotect call above.
target/s390x/diag.c +1 -2
@@ -105,8 +105,7 @@ void handle_diag_308(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)s390_ipl_reset_request (cs,S390_RESET_LOAD_NORMAL );break ;case DIAG308_LOAD_CLEAR : -/* Well we still lack the clearing bit... */ -s390_ipl_reset_request (cs,S390_RESET_REIPL ); +s390_ipl_reset_request (cs,S390_RESET_REIPL_CLEAR );break ;case DIAG308_SET :case DIAG308_PV_SET :
target/s390x/kvm/kvm.c +5 -1
@@ -1915,7 +1915,11 @@ int kvm_arch_handle_exit(CPUState *cs, struct kvm_run *run) ret =handle_intercept (cpu);break ;case KVM_EXIT_S390_RESET : -s390_ipl_reset_request (cs,S390_RESET_REIPL ); +if (run->s390_reset_flags &KVM_S390_RESET_CLEAR ) { +s390_ipl_reset_request (cs,S390_RESET_REIPL_CLEAR ); + }else { +s390_ipl_reset_request (cs,S390_RESET_REIPL ); + }break ;case KVM_EXIT_S390_TSCH : ret =handle_tsch (cpu);
Signature · 1 line
2.47.2
Quoted 51 lines · Nicholas Miehlbradt
The reset performed by subcode 3 of the diag308 instruction specifies that system memory should be reset. This patch implements that behaviour.
Introduce
S390_RESET_REIPL_CLEARto differentiate between subcode 3 and subcode 4 resets.When doing a clear reset, discard the ramblock containing the system ram.
Signed-off-by Nicholas Miehlbradt <[email protected]>--- hw/s390x/ipl.h | 1 + hw/s390x/s390-virtio-ccw.c | 6 ++++++ target/s390x/diag.c | 3 +-- target/s390x/kvm/kvm.c | 6 +++++- 4 files changed, 13 insertions(+), 3 deletions(-)hw/s390x/ipl.h +1
-0@@ -38,6 +38,7 @@ enum s390_reset {/* default is a reset not triggered by a CPU e.g. issued by QMP */ S390_RESET_EXTERNAL =0 ,S390_RESET_REIPL , +S390_RESET_REIPL_CLEAR ,S390_RESET_MODIFIED_CLEAR ,S390_RESET_LOAD_NORMAL , S390_RESET_PV,hw/s390x/s390-virtio-ccw.c +2
-0@@ -455,6 +455,7 @@ static void s390_machine_reset(MachineState *machine, ResetType type)enum s390_reset reset_type;CPUState *cs, *t;S390CPU *cpu; +RAMBlock *rb = machine->ram->ram_block;/* * Temporarily drop the record/replay mutex to let rr_cpu_thread_fn() @@ -479,6 +480,7 @@ static void s390_machine_reset(MachineState *machine, ResetType type)switch (reset_type) {case S390_RESET_EXTERNAL :case S390_RESET_REIPL : +case S390_RESET_REIPL_CLEAR :/* * Reset the subsystem which includes a AP reset. If a PV * guest had APQNs attached the AP reset is a prerequisite to
hw/s390x/s390-virtio-ccw.c static void s390_machine_reset(MachineState *machine, ResetType type) · line 497
Quoted 7 lines
hw/s390x/s390-virtio-ccw.c +4
-0@@ -489,6 +491,10 @@ static void s390_machine_reset(MachineState *machine, ResetType type)s390_machine_unprotect (ms); } +if (reset_type ==S390_RESET_REIPL_CLEAR ) { +ram_block_discard_range (rb,0 ,qemu_ram_get_used_length (rb)); + } +
I suspect that we don't care about virtio-mem devices, because the memory semantics are different (and usually they will get reset to "no memory" during reboots either way -> discarded)
The only problem I see is with vfio devices is the new "memory pinned" mode. [1]
There, we'd have to check if any such device is around (discarding of ram is disabled?), and fallback to actual zeroing of memory.
[1] https://lkml.kernel.org/r/[email protected]
Signature · 3 lines
Cheers, David / dhildenb
Am 29.04.25 um 09:37 schrieb David Hildenbrand:
[...]
Quoted 3 lines
The only problem I see is with vfio devices is the new "memory pinned" mode. [1]
There, we'd have to check if any such device is around (discarding of ram is disabled?), and fallback to actual zeroing of memory.
CC Matt to double check.
Quoted 2 lines
Quoted 7 lines · Christian Borntraeger
Am 29.04.25 um 09:37 schrieb David Hildenbrand:
[...]Quoted 3 lines
The only problem I see is with vfio devices is the new "memory pinned" mode. [1]
There, we'd have to check if any such device is around (discarding of ram is disabled?), and fallback to actual zeroing of memory.
CC Matt to double check.
When triggering the "relaxed translation" mode via iommu.passthrough in the guest, we now take the default (for other platforms) memory_region_is_ram() path in vfio_listener_region_add/del() which handles the pin/unpin from vfio common code. As for ram discarding, we then also use the vfio common path and only uncoordinated discards are disabled via:
vfio_ram_block_discard_disable() -> ram_block_uncoordinated_discard_disable()
Quoted 4 lines
Quoted 3 lines
Am 29.04.25 um 16:09 schrieb Matthew Rosato:
Quoted 5 lines · Christian Borntraeger
Quoted 4 lines
Am 29.04.25 um 09:37 schrieb David Hildenbrand:
[...]Quoted 2 lines
The only problem I see is with vfio devices is the new "memory pinned" mode. [1]
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
There, we'd have to check if any such device is around (discarding of ram is disabled?), and fallback to actual zeroing of memory.
CC Matt to double check.
When triggering the "relaxed translation" mode via iommu.passthrough in the guest, we now take the default (for other platforms)
memory_region_is_ram()path in vfio_listener_region_add/del() which handles the pin/unpin from vfio common code. As for ram discarding, we then also use the vfio common path and only uncoordinated discards are disabled via:
vfio_ram_block_discard_disable()->ram_block_uncoordinated_discard_disable()
So this patch is good?
Quoted 8 lines · Christian Borntraeger
Am 29.04.25 um 16:09 schrieb Matthew Rosato:
Quoted 7 lines · Christian Borntraeger
Quoted 6 lines
Am 29.04.25 um 09:37 schrieb David Hildenbrand:
[...]Quoted 3 lines
The only problem I see is with vfio devices is the new "memory pinned" mode. [1]
There, we'd have to check if any such device is around (discarding of ram is disabled?), and fallback to actual zeroing of memory.
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
CC Matt to double check.
When triggering the "relaxed translation" mode via iommu.passthrough in the guest, we now take the default (for other platforms)
memory_region_is_ram()path in vfio_listener_region_add/del() which handles the pin/unpin from vfio common code. As for ram discarding, we then also use the vfio common path and only uncoordinated discards are disabled via:
vfio_ram_block_discard_disable()->ram_block_uncoordinated_discard_disable()So this patch is good?
Worked fine in my testing in combination with iommu.passthrough=1. I traced to verify I was hitting the S390_RESET_REIPL_CLEAR path in s390_machine_reset() and observed the pinned memory of the guest shrink / grow. Device worked fine afterwards.
Quoted 11 lines · Matthew Rosato
Quoted 10 lines · Christian Borntraeger
Am 29.04.25 um 16:09 schrieb Matthew Rosato:
Quoted 9 lines · Christian Borntraeger
Quoted 7 lines
Am 29.04.25 um 09:37 schrieb David Hildenbrand:
[...]Quoted 3 lines
The only problem I see is with vfio devices is the new "memory pinned" mode. [1]
There, we'd have to check if any such device is around (discarding of ram is disabled?), and fallback to actual zeroing of memory.
CC Matt to double check.
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
When triggering the "relaxed translation" mode via iommu.passthrough in the guest, we now take the default (for other platforms)
memory_region_is_ram()path in vfio_listener_region_add/del() which handles the pin/unpin from vfio common code. As for ram discarding, we then also use the vfio common path and only uncoordinated discards are disabled via:
vfio_ram_block_discard_disable()->ram_block_uncoordinated_discard_disable()So this patch is good?
Worked fine in my testing in combination with iommu.passthrough=1. I traced to verify I was hitting the
S390_RESET_REIPL_CLEARpath ins390_machine_reset()and observed the pinned memory of the guest shrink / grow. Device worked fine afterwards.
What about David's concern here: https://lore.kernel.org/qemu-devel/[email protected]/ ?
Thomas
Quoted 14 lines · Thomas Huth
Quoted 13 lines · Matthew Rosato
Quoted 12 lines · Christian Borntraeger
Am 29.04.25 um 16:09 schrieb Matthew Rosato:
Quoted 11 lines · Christian Borntraeger
Quoted 7 lines
Am 29.04.25 um 09:37 schrieb David Hildenbrand:
[...]Quoted 3 lines
The only problem I see is with vfio devices is the new "memory pinned" mode. [1]
There, we'd have to check if any such device is around (discarding of ram is disabled?), and fallback to actual zeroing of memory.
CC Matt to double check.
When triggering the "relaxed translation" mode via iommu.passthrough in the guest, we now take the default (for other platforms)
memory_region_is_ram()path in vfio_listener_region_add/del() which handles the pin/unpin from vfio common code. As for ram discarding, we then also use the vfio common path and only uncoordinated discards are disabled via:
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
vfio_ram_block_discard_disable()->ram_block_uncoordinated_discard_disable()So this patch is good?
Worked fine in my testing in combination with iommu.passthrough=1. I traced to verify I was hitting the
S390_RESET_REIPL_CLEARpath ins390_machine_reset()and observed the pinned memory of the guest shrink / grow. Device worked fine afterwards.What about David's concern here: https://lore.kernel.org/qemu-devel/[email protected]/ ?
With the current code + this patch applied and testing with a vfio-pci device in the pinned mode, I can observe the pinned memory be discarded / pinned memory shrinks until finally ram_discard_block_range returns rc=0.
We don't disable discarding of ram when using the vfio-pci pinned memory mode, we only disable uncoordinated discarding of ram - maybe David's concern was based on an older version of my implementation that required disabling both coordinated and uncoordinated discards?
Or am I missing some other concern?
Am 29.04.25 um 07:20 schrieb Nicholas Miehlbradt:
Quoted 81 lines
The reset performed by subcode 3 of the diag308 instruction specifies that system memory should be reset. This patch implements that behaviour.
Introduce
S390_RESET_REIPL_CLEARto differentiate between subcode 3 and subcode 4 resets.When doing a clear reset, discard the ramblock containing the system ram.
Signed-off-by Nicholas Miehlbradt <[email protected]>--- hw/s390x/ipl.h | 1 + hw/s390x/s390-virtio-ccw.c | 6 ++++++ target/s390x/diag.c | 3 +-- target/s390x/kvm/kvm.c | 6 +++++- 4 files changed, 13 insertions(+), 3 deletions(-)hw/s390x/ipl.h +1
-0@@ -38,6 +38,7 @@ enum s390_reset {/* default is a reset not triggered by a CPU e.g. issued by QMP */ S390_RESET_EXTERNAL =0 ,S390_RESET_REIPL , +S390_RESET_REIPL_CLEAR ,S390_RESET_MODIFIED_CLEAR ,S390_RESET_LOAD_NORMAL , S390_RESET_PV,hw/s390x/s390-virtio-ccw.c +6
-0@@ -455,6 +455,7 @@ static void s390_machine_reset(MachineState *machine, ResetType type)enum s390_reset reset_type;CPUState *cs, *t;S390CPU *cpu; +RAMBlock *rb = machine->ram->ram_block;/* * Temporarily drop the record/replay mutex to let rr_cpu_thread_fn() @@ -479,6 +480,7 @@ static void s390_machine_reset(MachineState *machine, ResetType type)switch (reset_type) {case S390_RESET_EXTERNAL :case S390_RESET_REIPL : +case S390_RESET_REIPL_CLEAR :/* * Reset the subsystem which includes a AP reset. If a PV * guest had APQNs attached the AP reset is a prerequisite to @@ -489,6 +491,10 @@ static void s390_machine_reset(MachineState *machine, ResetType type)s390_machine_unprotect (ms); } +if (reset_type ==S390_RESET_REIPL_CLEAR ) { +ram_block_discard_range (rb,0 ,qemu_ram_get_used_length (rb)); + } +/* * Device reset includes CPU clear resets so this has to be * done AFTER the unprotect call above. target/s390x/diag.c +1
-2@@ -105,8 +105,7 @@ void handle_diag_308(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)s390_ipl_reset_request (cs,S390_RESET_LOAD_NORMAL );break ;case DIAG308_LOAD_CLEAR : -/* Well we still lack the clearing bit... */ -s390_ipl_reset_request (cs,S390_RESET_REIPL ); +s390_ipl_reset_request (cs,S390_RESET_REIPL_CLEAR );break ;case DIAG308_SET :case DIAG308_PV_SET :target/s390x/kvm/kvm.c +0
-0@@ -1915,7 +1915,11 @@ int kvm_arch_handle_exit(CPUState *cs, struct kvm_run *run) ret =handle_intercept (cpu);break ;
target/s390x/kvm/kvm.c int kvm_arch_handle_exit(CPUState *cs, struct kvm_run *run) · line 1925
Quoted 10 lines
target/s390x/kvm/kvm.c +5
-1case KVM_EXIT_S390_RESET : -s390_ipl_reset_request (cs,S390_RESET_REIPL ); +if (run->s390_reset_flags &KVM_S390_RESET_CLEAR ) { +s390_ipl_reset_request (cs,S390_RESET_REIPL_CLEAR ); + }else { +s390_ipl_reset_request (cs,S390_RESET_REIPL ); + }break ;case KVM_EXIT_S390_TSCH : ret =handle_tsch (cpu);
Do I see that right that this patch never made it into qemu master? IIRC Matt has clarified all concerns?
Quoted 91 lines · Christian Borntraeger
Am 29.04.25 um 07:20 schrieb Nicholas Miehlbradt:
Quoted 90 lines
The reset performed by subcode 3 of the diag308 instruction specifies that system memory should be reset. This patch implements that behaviour.
Introduce
S390_RESET_REIPL_CLEARto differentiate between subcode 3 and subcode 4 resets.When doing a clear reset, discard the ramblock containing the system ram.
Signed-off-by Nicholas Miehlbradt <[email protected]>---
hw/s390x/ipl.h | 1 +
hw/s390x/s390-virtio-ccw.c| 6 ++++++
target/s390x/diag.c | 3 +--
target/s390x/kvm/kvm.c | 6 +++++-4 files changed, 13 insertions(+), 3 deletions(-)hw/s390x/ipl.h +1
-0@@ -38,6 +38,7 @@ enum s390_reset { /* default is a reset not triggered by a CPU e.g. issued by QMP */ S390_RESET_EXTERNAL = 0, S390_RESET_REIPL, + S390_RESET_REIPL_CLEAR, S390_RESET_MODIFIED_CLEAR, S390_RESET_LOAD_NORMAL, S390_RESET_PV,hw/s390x/s390-virtio-ccw.c +1
-0@@ -455,6 +455,7 @@ static void s390_machine_reset(MachineState *machine, ResetType type) enum s390_reset reset_type; CPUState *cs, *t; S390CPU *cpu; + RAMBlock *rb = machine->ram->ram_block; /** Temporarily drop the record/replay mutex to let rr_cpu_thread_fn() @@ -479,6 +480,7 @@ static void s390_machine_reset(MachineState *machine, ResetType type) switch (reset_type) {case
S390_RESET_EXTERNAL:
caseS390_RESET_REIPL:
+ caseS390_RESET_REIPL_CLEAR:
/*
* Reset the subsystem which includes a AP reset. If a PV
* guest had APQNs attached the AP reset is a prerequisite tohw/s390x/s390-virtio-ccw.c +4
-0@@ -489,6 +491,10 @@ static void s390_machine_reset(MachineState *machine, ResetType type) s390_machine_unprotect(ms); } + if (reset_type == S390_RESET_REIPL_CLEAR) { + ram_block_discard_range(rb, 0 , qemu_ram_get_used_length(rb)); + } + /** Device reset includes CPU clear resets so this has to be * done AFTER the unprotect call above. target/s390x/diag.c +0
-0@@ -105,8 +105,7 @@ void handle_diag_308(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra) s390_ipl_reset_request(cs, S390_RESET_LOAD_NORMAL);break; case
DIAG308_LOAD_CLEAR:
- /* Well we still lack the clearing bit... */ -s390_ipl_reset_request(cs, S390_RESET_REIPL); +s390_ipl_reset_request(cs, S390_RESET_REIPL_CLEAR); break;
caseDIAG308_SET:
caseDIAG308_PV_SET:target/s390x/kvm/kvm.c +0
-0@@ -1915,7 +1915,11 @@ int kvm_arch_handle_exit(CPUState *cs, struct kvm_run *run) ret = handle_intercept(cpu); break;case
KVM_EXIT_S390_RESET:
-s390_ipl_reset_request(cs, S390_RESET_REIPL); + if (run->s390_reset_flags&KVM_S390_RESET_CLEAR) { +s390_ipl_reset_request(cs, S390_RESET_REIPL_CLEAR); + } else {
+s390_ipl_reset_request(cs, S390_RESET_REIPL);
Quoted 8 lines
Quoted 4 lines
+ }
break;
caseKVM_EXIT_S390_TSCH:
ret =handle_tsch(cpu);Do I see that right that this patch never made it into qemu master? IIRC Matt has clarified all concerns?
I was hoping to see a reply from David that he's fine with the patch now... David?
Thomas
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
/*
* Temporarily drop the record/replay mutex to letrr_cpu_thread_fn()hw/s390x/s390-virtio-ccw.c +1
-0@@ -479,6 +480,7 @@ static void s390_machine_reset(MachineState *machine, ResetType type) switch (reset_type) { case S390_RESET_EXTERNAL: case S390_RESET_REIPL: + case S390_RESET_REIPL_CLEAR: /** Reset the subsystem which includes a AP reset. If a PV * guest had APQNs attached the AP reset is a prerequisite to
hw/s390x/s390-virtio-ccw.c +4
-0@@ -489,6 +491,10 @@ static void s390_machine_reset(MachineState *machine, ResetType type) s390_machine_unprotect(ms); } + if (reset_type == S390_RESET_REIPL_CLEAR) { + ram_block_discard_range(rb, 0 , qemu_ram_get_used_length(rb)); + } +
...
Quoted 8 lines
Quoted 5 lines
Do I see that right that this patch never made it into qemu master? IIRC Matt has clarified all concerns?
I was hoping to see a reply from David that he's fine with the patch now... David?
Staring at this again, one more point regarding userfaultfd: doing the discard on the destination while postcopy is active might be problematic.
I don't remember all details, but I think that if we have the following:
1) Migrate page X to dst
2) Discard page X on dst
3) Access page X on dst
that postcopy_request_page()->migrate_send_rp_req_pages() would assume that the page was already transferred (marked received in the receive bitmap during 1) ) and essentially never place a fresh zeropage during 3) to be stuck forever.
Signature · 3 lines
Cheers David
Am 11.11.25 um 14:37 schrieb David Hildenbrand (Red Hat):
Quoted 33 lines
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
/*
* Temporarily drop the record/replay mutex to letrr_cpu_thread_fn()(quoted diff) +0
-0@@ -479,6 +480,7 @@ static void s390_machine_reset(MachineState *machine, ResetType type) switch (reset_type) {case
S390_RESET_EXTERNAL:
caseS390_RESET_REIPL:
+ caseS390_RESET_REIPL_CLEAR:
/*
* Reset the subsystem which includes a AP reset. If a PV
* guest had APQNs attached the AP reset is a prerequisite tohw/s390x/s390-virtio-ccw.c +4
-0@@ -489,6 +491,10 @@ static void s390_machine_reset(MachineState *machine, ResetType type) s390_machine_unprotect(ms); } + if (reset_type == S390_RESET_REIPL_CLEAR) { + ram_block_discard_range(rb, 0 , qemu_ram_get_used_length(rb)); + } +...
Quoted 8 lines
Quoted 5 lines
Do I see that right that this patch never made it into qemu master? IIRC Matt has clarified all concerns?
I was hoping to see a reply from David that he's fine with the patch now... David?
Staring at this again, one more point regarding userfaultfd: doing the discard on the destination while postcopy is active might be problematic.
Quoted 7 lines
I don't remember all details, but I think that if we have the following:
1) Migrate page X to dst
2) Discard page X on dst
3) Access page X on dstthat postcopy_request_page()->migrate_send_rp_req_pages() would assume that the page was already transferred (marked received in the receive bitmap during 1) ) and essentially never place a fresh zeropage during 3) to be stuck forever.
Can we have a postcopy running while we are in system reset? Or as an alternative can we check for postcopy running and not discard in that case.
Quoted 37 lines · Christian Borntraeger
Am 11.11.25 um 14:37 schrieb David Hildenbrand (Red Hat):
Quoted 35 lines
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
/*
* Temporarily drop the record/replay mutex to letrr_cpu_thread_fn()hw/s390x/s390-virtio-ccw.c +1
-0@@ -479,6 +480,7 @@ static void s390_machine_reset(MachineState *machine, ResetType type) switch (reset_type) { case S390_RESET_EXTERNAL: case S390_RESET_REIPL: + case S390_RESET_REIPL_CLEAR: /** Reset the subsystem which includes a AP reset. If a PV * guest had APQNs attached the AP reset is a prerequisite to
hw/s390x/s390-virtio-ccw.c +4
-0@@ -489,6 +491,10 @@ static void s390_machine_reset(MachineState *machine, ResetType type) s390_machine_unprotect(ms); } + if (reset_type == S390_RESET_REIPL_CLEAR) { + ram_block_discard_range(rb, 0 , qemu_ram_get_used_length(rb)); + } +...
Quoted 8 lines
Quoted 5 lines
Do I see that right that this patch never made it into qemu master? IIRC Matt has clarified all concerns?
I was hoping to see a reply from David that he's fine with the patch now... David?
Staring at this again, one more point regarding userfaultfd: doing the discard on the destination while postcopy is active might be problematic.
I don't remember all details, but I think that if we have the following:
Quoted 7 lines
Quoted 5 lines
1) Migrate page X to dst
2) Discard page X on dst
3) Access page X on dstthat postcopy_request_page()->migrate_send_rp_req_pages() would assume that the page was already transferred (marked received in the receive bitmap during 1) ) and essentially never place a fresh zeropage during 3) to be stuck forever.
Can we have a postcopy running while we are in system reset?
Yes, that should be possible. Start postcopy and then trigger a system reset on the destination (e.g., from the guest).
Quoted 1 line
Or as an alternative can we check for postcopy running and not discard in that case.
Another interaction might be with background snapshots (another form of migration) running concurrently. If we discard after populating all memory+registering userfaultfd-wp I think we might not get write events for all changes, possibly corrupting the snapshot (not 100% sure but that's what I remember).
What virtio-mem does to workaround all that is the following:
static bool virtio_mem_is_busy(void)
{
/*
* Postcopy cannot handle concurrent discards and we don't want to migrate
* pages on-demand with stale content when plugging new blocks. *
* For precopy, we don't want unplugged blocks in our migration stream, and
* when plugging new blocks, the page content might differ between source
* and destination (observable by the guest when not initializing pages
* after plugging them) until we're running on the destination (as we didn't
* migrate these blocks when they were unplugged).
*/
return migration_in_incoming_postcopy() || migration_is_running();
}
Signature · 3 lines
Cheers David