GPMI iMX6ull timeout on DMA
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset 0x000 : 0x20830002 gpmi-nand 1806000.gpmi-nand: offset 0x010 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x020 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x030 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x040 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x050 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x060 : 0x01c6800c gpmi-nand 1806000.gpmi-nand: offset 0x070 : 0x00010101 gpmi-nand 1806000.gpmi-nand: offset 0x080 : 0xe0000000 gpmi-nand 1806000.gpmi-nand: offset 0x090 : 0x23023336 gpmi-nand 1806000.gpmi-nand: offset 0x0a0 : 0x000001ee gpmi-nand 1806000.gpmi-nand: offset 0x0b0 : 0xff000001 gpmi-nand 1806000.gpmi-nand: offset 0x0c0 : 0x00000001 gpmi-nand 1806000.gpmi-nand: offset 0x0d0 : 0x05020000 gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset 0x000 : 0x00000100 gpmi-nand 1806000.gpmi-nand: offset 0x010 : 0x00000010 gpmi-nand 1806000.gpmi-nand: offset 0x020 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x030 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x040 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x050 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x060 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x070 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x080 : 0x030a2080 gpmi-nand 1806000.gpmi-nand: offset 0x090 : 0x083e2080 gpmi-nand 1806000.gpmi-nand: offset 0x0a0 : 0x070a4080 gpmi-nand 1806000.gpmi-nand: offset 0x0b0 : 0x10da4080 gpmi-nand 1806000.gpmi-nand: offset 0x0c0 : 0x070a4080 gpmi-nand 1806000.gpmi-nand: offset 0x0d0 : 0x10da4080 gpmi-nand 1806000.gpmi-nand: offset 0x0e0 : 0x070a4080 gpmi-nand 1806000.gpmi-nand: offset 0x0f0 : 0x10da4080 gpmi-nand 1806000.gpmi-nand: offset 0x100 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x110 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x120 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x130 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x140 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x150 : 0x20484342 gpmi-nand 1806000.gpmi-nand: offset 0x160 : 0x01000000 gpmi-nand 1806000.gpmi-nand: offset 0x170 : 0x00000000 gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chip gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
Scanning device for bad blocks
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
....
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
This is using a linux kernel v5.1.14. I have seen this happen on a number of boards I have here - but it is only occasional. It only happens once in a while on boot, maybe 1 in 40 or more times. So it can take quite a while to reproduce (using a boot loop setup).
As per the email thread I pointed to above I looked at reverting those patches, but that was not at all easy given how much the gpmi driver code had moved. So instead I modified the code with this:
linux/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2 -0
@@ -481,6 +481,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) { +#if 0 struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;
@@ -505,6 +512,7 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us); +#endif } int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,
So far after a couple of days of testing with this I no longer see the DMA timeout.
Any thoughts?
Regards
Greg
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Greg,
One question below.
+Michael
+Sascha
Hello Michael, here is a similar issue to yours, I know you did not have enough time to share your solution but here we have someone else reproducing the issue, would you mind sharing a branch or a patch, even a WIP one, just to help debugging?
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
Quoted 64 lines
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512
Quoted 8 lines
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chip
What is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Quoted 20 lines
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 Scanning device for bad blocks
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
....
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
Quoted 4 lines
This is using a linux kernel v5.1.14. I have seen this happen on a number of boards I have here - but it is only occasional. It only happens once in a while on boot, maybe 1 in 40 or more times. So it can take quite a while to reproduce (using a boot loop setup).
That's strange... I don't get what would produce such unstable issue.
Quoted 24 lines
As per the email thread I pointed to above I looked at reverting those patches, but that was not at all easy given how much the gpmi driver code had moved. So instead I modified the code with this:
linux/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -481,6 +481,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) { +#if 0 struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;@@ -505,6 +512,7 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us); +#endif } int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,So far after a couple of days of testing with this I no longer see the DMA timeout.
Quoted 5 lines
Any thoughts?
Regards
Greg
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi all
Quoted 8 lines · Miquel Raynal
Hi Greg,
One question below.
(quoted diff) +2
-0+Michael +Sascha
Quoted 5 lines
Hello Michael, here is a similar issue to yours, I know you did not have enough time to share your solution but here we have someone else reproducing the issue, would you mind sharing a branch or a patch, even a WIP one, just to help debugging?
I have patches reverted as I mention in the email. The step to reproduce is simple.
Just reboot every successful boot.
Michael
Quoted 139 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
Quoted 64 lines
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512Quoted 8 lines
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chipWhat is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Quoted 20 lines
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 Scanning device for bad blocks
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
....
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.Quoted 4 lines
This is using a linux kernel v5.1.14. I have seen this happen on a number of boards I have here - but it is only occasional. It only happens once in a while on boot, maybe 1 in 40 or more times. So it can take quite a while to reproduce (using a boot loop setup).
That's strange... I don't get what would produce such unstable issue.
Quoted 24 lines
As per the email thread I pointed to above I looked at reverting those patches, but that was not at all easy given how much the gpmi driver code had moved. So instead I modified the code with this:
linux/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -481,6 +481,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) { +#if 0 struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;@@ -505,6 +512,7 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us); +#endif } int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,So far after a couple of days of testing with this I no longer see the DMA timeout.
Quoted 5 lines
Any thoughts?
Regards
GregThanks,
Miquèl
Signature · 8 lines
| Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com | ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Michael,
Quoted 21 lines · Michael Nazzareno Trimarchi
Hi all
Quoted 8 lines · Miquel Raynal
Hi Greg,
One question below.
(quoted diff) +2
-0+Michael +SaschaQuoted 5 lines
Hello Michael, here is a similar issue to yours, I know you did not have enough time to share your solution but here we have someone else reproducing the issue, would you mind sharing a branch or a patch, even a WIP one, just to help debugging?
I have patches reverted as I mention in the email. The step to reproduce is simple.
Quoted 1 line
Just reboot every successful boot.
Testing like this how often does it occur?
Regards
Greg
Quoted 144 lines
Michael
Quoted 139 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
Quoted 64 lines
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512Quoted 8 lines
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chipWhat is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Quoted 20 lines
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 Scanning device for bad blocks
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
....
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.Quoted 4 lines
This is using a linux kernel v5.1.14. I have seen this happen on a number of boards I have here - but it is only occasional. It only happens once in a while on boot, maybe 1 in 40 or more times. So it can take quite a while to reproduce (using a boot loop setup).
That's strange... I don't get what would produce such unstable issue.
Quoted 24 lines
As per the email thread I pointed to above I looked at reverting those patches, but that was not at all easy given how much the gpmi driver code had moved. So instead I modified the code with this:
linux/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -481,6 +481,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) { +#if 0 struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;@@ -505,6 +512,7 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us); +#endif } int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,So far after a couple of days of testing with this I no longer see the DMA timeout.
Quoted 5 lines
Any thoughts?
Regards
GregThanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi
Quoted 25 lines · Greg Ungerer
Hi Michael,
Quoted 21 lines · Michael Nazzareno Trimarchi
Hi all
Quoted 8 lines · Miquel Raynal
Hi Greg,
One question below.
(quoted diff) +2
-0+Michael +SaschaQuoted 5 lines
Hello Michael, here is a similar issue to yours, I know you did not have enough time to share your solution but here we have someone else reproducing the issue, would you mind sharing a branch or a patch, even a WIP one, just to help debugging?
I have patches reverted as I mention in the email. The step to reproduce is simple.
Quoted 4 lines
Quoted 1 line
Just reboot every successful boot.
Testing like this how often does it occur?
Not more then 60 reboot ;). The problem is how is done the code the system can not rebooting without an hardware watchdog
MIchael
Quoted 148 lines
Regards
GregQuoted 144 lines
Michael
Quoted 139 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
Quoted 64 lines
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512Quoted 8 lines
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chipWhat is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Quoted 20 lines
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 Scanning device for bad blocks
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
....
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.Quoted 4 lines
This is using a linux kernel v5.1.14. I have seen this happen on a number of boards I have here - but it is only occasional. It only happens once in a while on boot, maybe 1 in 40 or more times. So it can take quite a while to reproduce (using a boot loop setup).
That's strange... I don't get what would produce such unstable issue.
Quoted 24 lines
As per the email thread I pointed to above I looked at reverting those patches, but that was not at all easy given how much the gpmi driver code had moved. So instead I modified the code with this:
linux/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -481,6 +481,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) { +#if 0 struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;@@ -505,6 +512,7 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us); +#endif } int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,So far after a couple of days of testing with this I no longer see the DMA timeout.
Quoted 5 lines
Any thoughts?
Regards
GregThanks,
Miquèl
Signature · 8 lines
| Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com | ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Miquel,
Quoted 87 lines · Miquel Raynal
Hi Greg,
One question below.
(quoted diff) +2
-0+Michael +SaschaHello Michael, here is a similar issue to yours, I know you did not have enough time to share your solution but here we have someone else reproducing the issue, would you mind sharing a branch or a patch, even a WIP one, just to help debugging?
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
Quoted 64 lines
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512Quoted 8 lines
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chip
Quoted 4 lines
What is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Sure, how to do that?
Quoted 20 lines
Quoted 20 lines
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 Scanning device for bad blocks
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
....
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
Quoted 6 lines
Quoted 4 lines
This is using a linux kernel v5.1.14. I have seen this happen on a number of boards I have here - but it is only occasional. It only happens once in a while on boot, maybe 1 in 40 or more times. So it can take quite a while to reproduce (using a boot loop setup).
That's strange... I don't get what would produce such unstable issue.
My initial guess is that the calculated timing is very marginal. The problem seems more likely to happen if flash write activity had been occurring just before a soft reboot. Its not a guarantee, just more likely.
Interesting observation is that Michael was using Micron flash, and boards that I have with the problem also have Micron flash. Both a form of Micron MT29F2G08.
I have similar boards, iMX6ull based, with different brands of NAND flash and I have not seen any problem on them.
Regards
Greg
Quoted 23 lines
Quoted 23 lines
As per the email thread I pointed to above I looked at reverting those patches, but that was not at all easy given how much the gpmi driver code had moved. So instead I modified the code with this:
linux/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -481,6 +481,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) { +#if 0 struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;@@ -505,6 +512,7 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us); +#endif } int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,So far after a couple of days of testing with this I no longer see the DMA timeout.
Quoted 9 lines
Quoted 5 lines
Any thoughts?
Regards
GregThanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Greg,
+ Boris
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 90 lines
Hi Miquel,
Quoted 87 lines · Miquel Raynal
Hi Greg,
One question below.
(quoted diff) +2
-0+Michael +SaschaHello Michael, here is a similar issue to yours, I know you did not have enough time to share your solution but here we have someone else reproducing the issue, would you mind sharing a branch or a patch, even a WIP one, just to help debugging?
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
Quoted 72 lines
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chip
Quoted 6 lines
Quoted 4 lines
What is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Sure, how to do that?
This loop [1] tries to configure each mode (5, 4, ...) until one succeeds (default is 0: must always work). Please try to limit mode to 0, 1, etc.
Mode 0 should work.
[1] https://elixir.bootlin.com/linux/v5.3-rc1/source/drivers/mtd/nand/raw/nand_base.c#L933
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 Scanning device for bad blocks
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
....
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
This is using a linux kernel v5.1.14. I have seen this happen on a number of boards I have here - but it is only occasional. It only happens once in a while on boot, maybe 1 in 40 or more times. So it can take quite a while to reproduce (using a boot loop setup).
That's strange... I don't get what would produce such unstable issue.
My initial guess is that the calculated timing is very marginal.
What do you mean by "marginal"?
Quoted 3 lines
The problem seems more likely to happen if flash write activity had been occurring just before a soft reboot. Its not a guarantee, just more likely.
That's really disturbing. I doubt this is the real cause though.
Quoted 7 lines
Interesting observation is that Michael was using Micron flash, and boards that I have with the problem also have Micron flash. Both a form of Micron MT29F2G08.
I have similar boards, iMX6ull based, with different brands of NAND flash and I have not seen any problem on them.
That's great to narrow down the root cause. Maybe these chips have tighter timing constraints.
Quoted 38 lines
Regards
GregQuoted 32 lines
Quoted 23 lines
As per the email thread I pointed to above I looked at reverting those patches, but that was not at all easy given how much the gpmi driver code had moved. So instead I modified the code with this:
linux/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -481,6 +481,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) { +#if 0 struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;@@ -505,6 +512,7 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us); +#endif } int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,So far after a couple of days of testing with this I no longer see the DMA timeout.
Quoted 5 lines
Any thoughts?
Regards
GregThanks,
Miquèl
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Miguel
Quoted 102 lines · Miquel Raynal
Hi Greg,
+ Boris
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 95 lines
Hi Miquel,
Quoted 91 lines · Miquel Raynal
Hi Greg,
One question below.
(quoted diff) +2
-0+Michael +SaschaHello Michael, here is a similar issue to yours, I know you did not have enough time to share your solution but here we have someone else reproducing the issue, would you mind sharing a branch or a patch, even a WIP one, just to help debugging?
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
Quoted 64 lines
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512Quoted 8 lines
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chipWhat is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Quoted 8 lines
Quoted 1 line
Sure, how to do that?
This loop [1] tries to configure each mode (5, 4, ...) until one succeeds (default is 0: must always work). Please try to limit mode to 0, 1, etc.
Mode 0 should work.
This is not correct. When all the mode fail it fallback to 0 that does not work. Already check
So the fallback is created for this situation
Quoted 29 lines
[1] https://elixir.bootlin.com/linux/v5.3-rc1/source/drivers/mtd/nand/raw/nand_base.c#L933
Quoted 27 lines
Quoted 27 lines
Quoted 26 lines
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 Scanning device for bad blocks
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
....
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.This is using a linux kernel v5.1.14. I have seen this happen on a number of boards I have here - but it is only occasional. It only happens once in a while on boot, maybe 1 in 40 or more times. So it can take quite a while to reproduce (using a boot loop setup).
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
That's strange... I don't get what would produce such unstable issue.
My initial guess is that the calculated timing is very marginal.
What do you mean by "marginal"?
I don't think that is timing calculation. I have tried to use the same timing as before but when those are applide. Is it possible?
Michael
Quoted 58 lines
Quoted 3 lines
The problem seems more likely to happen if flash write activity had been occurring just before a soft reboot. Its not a guarantee, just more likely.
That's really disturbing. I doubt this is the real cause though.
Quoted 7 lines
Interesting observation is that Michael was using Micron flash, and boards that I have with the problem also have Micron flash. Both a form of Micron MT29F2G08.
I have similar boards, iMX6ull based, with different brands of NAND flash and I have not seen any problem on them.
That's great to narrow down the root cause. Maybe these chips have tighter timing constraints.
Quoted 38 lines
Regards
GregQuoted 32 lines
Quoted 23 lines
As per the email thread I pointed to above I looked at reverting those patches, but that was not at all easy given how much the gpmi driver code had moved. So instead I modified the code with this:
linux/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -481,6 +481,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) { +#if 0 struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;@@ -505,6 +512,7 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us); +#endif } int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,So far after a couple of days of testing with this I no longer see the DMA timeout.
Quoted 5 lines
Any thoughts?
Regards
GregThanks,
MiquèlThanks,
Miquèl
Signature · 8 lines
| Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com | ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Mon, 29 Jul 2019 14:49:19 +0200:
Quoted 111 lines
Hi Miguel
Quoted 108 lines · Miquel Raynal
Hi Greg,
+ Boris
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 90 lines
Hi Miquel,
Quoted 87 lines · Miquel Raynal
Hi Greg,
One question below.
(quoted diff) +2
-0+Michael +SaschaHello Michael, here is a similar issue to yours, I know you did not have enough time to share your solution but here we have someone else reproducing the issue, would you mind sharing a branch or a patch, even a WIP one, just to help debugging?
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
Quoted 72 lines
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chipQuoted 6 lines
Quoted 4 lines
What is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Sure, how to do that?
This loop [1] tries to configure each mode (5, 4, ...) until one succeeds (default is 0: must always work). Please try to limit mode to 0, 1, etc.
Quoted 6 lines
Quoted 2 lines
Mode 0 should work.
This is not correct. When all the mode fail it fallback to 0 that does not work. Already check
So the fallback is created for this situation
Sorry but I don't understand what you are saying.
Are you telling me that you already tried mode 0 and that it did not work better than other timings?
Quoted 32 lines
Quoted 32 lines
[1] https://elixir.bootlin.com/linux/v5.3-rc1/source/drivers/mtd/nand/raw/nand_base.c#L933
Quoted 29 lines
Quoted 28 lines
Quoted 22 lines
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 Scanning device for bad blocks
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
....
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.Quoted 4 lines
This is using a linux kernel v5.1.14. I have seen this happen on a number of boards I have here - but it is only occasional. It only happens once in a while on boot, maybe 1 in 40 or more times. So it can take quite a while to reproduce (using a boot loop setup).
That's strange... I don't get what would produce such unstable issue.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
My initial guess is that the calculated timing is very marginal.
What do you mean by "marginal"?
I don't think that is timing calculation. I have tried to use the same timing as before but when those are applide. Is it possible?
^
I suppose the end of the sentence is missing?
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Miquel
Quoted 117 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Mon, 29 Jul 2019 14:49:19 +0200:
Quoted 111 lines
Hi Miguel
Quoted 108 lines · Miquel Raynal
Hi Greg,
+ Boris
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 90 lines
Hi Miquel,
Quoted 87 lines · Miquel Raynal
Hi Greg,
One question below.
(quoted diff) +2
-0+Michael +SaschaHello Michael, here is a similar issue to yours, I know you did not have enough time to share your solution but here we have someone else reproducing the issue, would you mind sharing a branch or a patch, even a WIP one, just to help debugging?
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
Quoted 72 lines
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chipQuoted 6 lines
Quoted 4 lines
What is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Sure, how to do that?
This loop [1] tries to configure each mode (5, 4, ...) until one succeeds (default is 0: must always work). Please try to limit mode to 0, 1, etc.
Quoted 9 lines
Quoted 6 lines
Quoted 2 lines
Mode 0 should work.
This is not correct. When all the mode fail it fallback to 0 that does not work. Already check
So the fallback is created for this situationSorry but I don't understand what you are saying.
I said that where a timing mode is not ackolege then the mtd stack should send a reset command and fallback to timeing mode 0. The nand does not respond anymore.
Quoted 3 lines
Are you telling me that you already tried mode 0 and that it did not work better than other timings?
I force only to use different mode but never try mode 0 ;) just because should be
the normal fallback
Michael
Quoted 46 lines
Quoted 32 lines
Quoted 32 lines
[1] https://elixir.bootlin.com/linux/v5.3-rc1/source/drivers/mtd/nand/raw/nand_base.c#L933
Quoted 29 lines
Quoted 28 lines
Quoted 22 lines
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 Scanning device for bad blocks
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
....
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.Quoted 4 lines
This is using a linux kernel v5.1.14. I have seen this happen on a number of boards I have here - but it is only occasional. It only happens once in a while on boot, maybe 1 in 40 or more times. So it can take quite a while to reproduce (using a boot loop setup).
That's strange... I don't get what would produce such unstable issue.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
My initial guess is that the calculated timing is very marginal.
What do you mean by "marginal"?
I don't think that is timing calculation. I have tried to use the same timing as before but when those are applide. Is it possible?
^I suppose the end of the sentence is missing?
Thanks,
Miquèl
Signature · 8 lines
| Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com | ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Mon, 29 Jul 2019 15:00:04 +0200:
Quoted 127 lines
Hi Miquel
Quoted 124 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Mon, 29 Jul 2019 14:49:19 +0200:
Quoted 117 lines
Hi Miguel
Quoted 102 lines · Miquel Raynal
Hi Greg,
+ Boris
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 95 lines
Hi Miquel,
Quoted 91 lines · Miquel Raynal
Hi Greg,
One question below.
(quoted diff) +2
-0+Michael +SaschaHello Michael, here is a similar issue to yours, I know you did not have enough time to share your solution but here we have someone else reproducing the issue, would you mind sharing a branch or a patch, even a WIP one, just to help debugging?
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
Quoted 64 lines
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512Quoted 8 lines
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chipWhat is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Quoted 8 lines
Quoted 1 line
Sure, how to do that?
This loop [1] tries to configure each mode (5, 4, ...) until one succeeds (default is 0: must always work). Please try to limit mode to 0, 1, etc.
Mode 0 should work.
This is not correct. When all the mode fail it fallback to 0 that does not work. Already check
So the fallback is created for this situation
Quoted 6 lines
Quoted 2 lines
Sorry but I don't understand what you are saying.
I said that where a timing mode is not ackolege then the mtd stack should send a reset command and fallback to timeing mode 0. The nand does not respond anymore.
It depends on what you define by "not acknowledged". What you describe is the current situation: if either the NAND controller or the NAND chip do not support the mode requested by the core, the core will try another (slower) mode until either we found one or we are at timing mode 0.
Unfortunately, we cannot check that "all operation with these timings will work" at boot time, it would be very time consuming; especially for something that is very likely to be a controller driver issue, and that is what happens here: both the controller and the chip acknowledge the new timings.
Quoted 8 lines
Quoted 4 lines
Are you telling me that you already tried mode 0 and that it did not work better than other timings?
I force only to use different mode but never try mode 0 ;) just because should be
the normal fallback
Unless there is a timing calculation issue in the controller driver. Greg, can you please find the quickest working mode (starting from 0, of course, to ensure mode 0 is stable).
[...]
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Quoted 2 lines
That's strange... I don't get what would produce such unstable issue.
My initial guess is that the calculated timing is very marginal.
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
What do you mean by "marginal"?
I don't think that is timing calculation. I have tried to use the same timing as before but when those are applide. Is it possible?
^I suppose the end of the sentence is missing?
Michael, what did you mean here?
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Miquel
sorry was difficult day ;). My answer below
Quoted 175 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Mon, 29 Jul 2019 15:00:04 +0200:
Quoted 127 lines
Hi Miquel
Quoted 124 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Mon, 29 Jul 2019 14:49:19 +0200:
Quoted 117 lines
Hi Miguel
Quoted 102 lines · Miquel Raynal
Hi Greg,
+ Boris
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 95 lines
Hi Miquel,
Quoted 91 lines · Miquel Raynal
Hi Greg,
One question below.
(quoted diff) +2
-0+Michael +SaschaHello Michael, here is a similar issue to yours, I know you did not have enough time to share your solution but here we have someone else reproducing the issue, would you mind sharing a branch or a patch, even a WIP one, just to help debugging?
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
Quoted 64 lines
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512Quoted 8 lines
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chipWhat is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Quoted 8 lines
Quoted 1 line
Sure, how to do that?
This loop [1] tries to configure each mode (5, 4, ...) until one succeeds (default is 0: must always work). Please try to limit mode to 0, 1, etc.
Mode 0 should work.
This is not correct. When all the mode fail it fallback to 0 that does not work. Already check
So the fallback is created for this situationQuoted 6 lines
Quoted 2 lines
Sorry but I don't understand what you are saying.
I said that where a timing mode is not ackolege then the mtd stack should send a reset command and fallback to timeing mode 0. The nand does not respond anymore.
It depends on what you define by "not acknowledged". What you describe is the current situation: if either the NAND controller or the NAND chip do not support the mode requested by the core, the core will try another (slower) mode until either we found one or we are at timing mode 0.
Unfortunately, we cannot check that "all operation with these timings will work" at boot time, it would be very time consuming; especially for something that is very likely to be a controller driver issue, and that is what happens here: both the controller and the chip acknowledge the new timings.
Quoted 8 lines
Quoted 4 lines
Are you telling me that you already tried mode 0 and that it did not work better than other timings?
I force only to use different mode but never try mode 0 ;) just because should be
the normal fallbackUnless there is a timing calculation issue in the controller driver. Greg, can you please find the quickest working mode (starting from 0, of course, to ensure mode 0 is stable).
[...]
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
That's strange... I don't get what would produce such unstable issue.
My initial guess is that the calculated timing is very marginal.
What do you mean by "marginal"?
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
Quoted 2 lines
I don't think that is timing calculation. I have tried to use the same timing as before but when those are applide. Is it possible?
^I suppose the end of the sentence is missing?
Michael, what did you mean here?
commit 02c786627b93b3c3286570f793294816286ff397
Author: Michael Trimarchi <[email protected]> Date: Fri Oct 5 09:46:29 2018 +0200
Revert "mtd: rawnand: gpmi: use core timings instead of an
empirical derivation"
This reverts commit b1206122069aadabe1a8c50789277a978aaa4df7.
Change-Id: Icd0ddcd5e3ac7d82932bbf412299cca424cbc571
Jira-Id: WAN-50
Signed-off-by: Michael Trimarchi <[email protected]>Revert this one does not fix the problem. Right now I have two revert this one and
commit 6ab543c1924f77957004994bd6806a9daa45f903 (tag: MMI_004_011_R02)
Author: Michael Trimarchi <[email protected]> Date: Fri Oct 5 09:46:44 2018 +0200
Revert "mtd: rawnand: gpmi: support ->setup_data_interface()"
This reverts commit 76e1a0086a0c3276b384f77905345e0fcc886fdd.
Change-Id: I60fb6f874364d1deeda3424d4508553a38ac9b1a
Jira-Id: WAN-50
Signed-off-by: Michael Trimarchi <[email protected]>I did not have time to finish to undestand why this was fixing my problem Michael
Quoted 3 lines
Thanks,
Miquèl
Signature · 8 lines
| Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com | ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Mon, 29 Jul 2019 22:00:25 +0200:
Quoted 4 lines
Hi Miquel
sorry was difficult day ;). My answer below
No pb ;)
[...]
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
That's strange... I don't get what would produce
such unstable issue.
Quoted 42 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines
My initial guess is that the calculated timing is very marginal.
What do you mean by "marginal"?
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
Quoted 2 lines
I don't think that is timing calculation. I have tried to use the same timing as before but when those are applide. Is it possible?
^I suppose the end of the sentence is missing?
Michael, what did you mean here?
commit
02c786627b93b3c3286570f793294816286ff397Author: Michael Trimarchi <[email protected]> Date: Fri Oct 5 09:46:29 2018 +0200Revert "mtd: rawnand: gpmi: use core timings instead of an
empirical derivation"This reverts commit b1206122069aadabe1a8c50789277a978aaa4df7. Change-Id: Icd0ddcd5e3ac7d82932bbf412299cca424cbc571 Jira-Id: WAN-50 Signed-off-by: Michael Trimarchi <[email protected]>Revert this one does not fix the problem. Right now I have two revert this one and
commit
6ab543c1924f77957004994bd6806a9daa45f903(tag:MMI_004_011_R02)Author: Michael Trimarchi <[email protected]> Date: Fri Oct 5 09:46:44 2018 +0200Revert "mtd: rawnand: gpmi: support ->setup_data_interface()" This reverts commit 76e1a0086a0c3276b384f77905345e0fcc886fdd. Change-Id: I60fb6f874364d1deeda3424d4508553a38ac9b1a Jira-Id: WAN-50 Signed-off-by: Michael Trimarchi <[email protected]>
Quoted 1 line
I did not have time to finish to undestand why this was fixing my problem
Ok so I am pretty convinced that this is still a timings issue then; but not entirely due to the different timings calculation. Interesting. I'm waiting for Greg's results now.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Miquel,
Quoted 103 lines · Miquel Raynal
Hi Greg,
+ Boris
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 90 lines
Hi Miquel,
Quoted 87 lines · Miquel Raynal
Hi Greg,
One question below.
(quoted diff) +2
-0+Michael +SaschaHello Michael, here is a similar issue to yours, I know you did not have enough time to share your solution but here we have someone else reproducing the issue, would you mind sharing a branch or a patch, even a WIP one, just to help debugging?
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
Quoted 72 lines
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chipQuoted 6 lines
Quoted 4 lines
What is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Sure, how to do that?
Quoted 7 lines
This loop [1] tries to configure each mode (5, 4, ...) until one succeeds (default is 0: must always work). Please try to limit mode to 0, 1, etc.
Mode 0 should work.
[1] https://elixir.bootlin.com/linux/v5.3-rc1/source/drivers/mtd/nand/raw/nand_base.c#L933
The normal behavior - which usually works - has chip->onfi_timing_mode_default=5 here. So in other words on the first pass through this loop it is checking mode 5, and setting it as the default.
I am running a test/reboot loop now waiting for failure to see if it is still using mode 5 in that case.
Regards
Greg
Quoted 87 lines
Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 Scanning device for bad blocks
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
....
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22 gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
This is using a linux kernel v5.1.14. I have seen this happen on a number of boards I have here - but it is only occasional. It only happens once in a while on boot, maybe 1 in 40 or more times. So it can take quite a while to reproduce (using a boot loop setup).
That's strange... I don't get what would produce such unstable issue.
My initial guess is that the calculated timing is very marginal.
What do you mean by "marginal"?
Quoted 3 lines
The problem seems more likely to happen if flash write activity had been occurring just before a soft reboot. Its not a guarantee, just more likely.
That's really disturbing. I doubt this is the real cause though.
Quoted 7 lines
Interesting observation is that Michael was using Micron flash, and boards that I have with the problem also have Micron flash. Both a form of Micron MT29F2G08.
I have similar boards, iMX6ull based, with different brands of NAND flash and I have not seen any problem on them.
That's great to narrow down the root cause. Maybe these chips have tighter timing constraints.
Quoted 38 lines
Regards
GregQuoted 32 lines
Quoted 23 lines
As per the email thread I pointed to above I looked at reverting those patches, but that was not at all easy given how much the gpmi driver code had moved. So instead I modified the code with this:
linux/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -481,6 +481,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) { +#if 0 struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;@@ -505,6 +512,7 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us); +#endif } int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,So far after a couple of days of testing with this I no longer see the DMA timeout.
Quoted 5 lines
Any thoughts?
Regards
GregThanks,
Miquèl
Quoted 3 lines
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Miquel,
Quoted 4 lines · Greg Ungerer
Quoted 3 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Quoted 1 line
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Quoted 15 lines
Quoted 15 lines
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
nand: timing mode 5 not acknowledged by the NAND chip
What is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Sure, how to do that?
This loop [1] tries to configure each mode (5, 4, ...) until one succeeds (default is 0: must always work). Please try to limit mode to 0, 1, etc.
Mode 0 should work.
Quoted 8 lines
Quoted 1 line
[1] https://elixir.bootlin.com/linux/v5.3-rc1/source/drivers/mtd/nand/raw/nand_base.c#L933
The normal behavior - which usually works - has chip->onfi_timing_mode_default=5 here. So in other words on the first pass through this loop it is checking mode 5, and setting it as the default.
I am running a test/reboot loop now waiting for failure to see if it is still using mode 5 in that case.
With this trace in place:
linux/drivers/mtd/nand/raw/nand_base.c +3 -0
@@ -910,6 +910,7 @@ static int nand_init_data_interface(struct nand_chip *chip) }for (mode =fls (modes) -1 ; mode >=0 ; mode--) { +printk ("%s(%d): checking mode=%d\n" , __FILE__, __LINE__, mode); ret =onfi_fill_data_interface (chip,NAND_SDR_IFACE , mode);if (ret)continue ;
@@ -923,10 +924,12 @@ static int nand_init_data_interface(struct nand_chip *chip) &chip->data_interface);if (!ret) { chip->onfi_timing_mode_default = mode; +printk ("%s(%d): BREAKING AT mode=%d\n" , __FILE__, __LINE__, mode);break ; } } +printk ("%s(%d): chip->onfi_timing_mode_default=%d\n" , __FILE__, __LINE__, chip->onfi_timing_mode_default);return 0 ; }
First NAND failure gives this:
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: use legacy bch geometry drivers/mtd/nand/raw/nand_base.c(913): checking mode=5 drivers/mtd/nand/raw/nand_base.c(927): BREAKING AT mode=5 drivers/mtd/nand/raw/nand_base.c(932): chip->onfi_timing_mode_default=5 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA
gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset 0x000 : 0x20830002 gpmi-nand 1806000.gpmi-nand: offset 0x010 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x020 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x030 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x040 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x050 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x060 : 0x01c6800c gpmi-nand 1806000.gpmi-nand: offset 0x070 : 0x00010101 gpmi-nand 1806000.gpmi-nand: offset 0x080 : 0xe0000000 gpmi-nand 1806000.gpmi-nand: offset 0x090 : 0x23023336 gpmi-nand 1806000.gpmi-nand: offset 0x0a0 : 0x000001ee gpmi-nand 1806000.gpmi-nand: offset 0x0b0 : 0xff000001 gpmi-nand 1806000.gpmi-nand: offset 0x0c0 : 0x00000100 gpmi-nand 1806000.gpmi-nand: offset 0x0d0 : 0x05020000 gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset 0x000 : 0x00000100 gpmi-nand 1806000.gpmi-nand: offset 0x010 : 0x00000010 gpmi-nand 1806000.gpmi-nand: offset 0x020 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x030 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x040 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x050 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x060 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x070 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x080 : 0x030a2080 gpmi-nand 1806000.gpmi-nand: offset 0x090 : 0x083e2080 gpmi-nand 1806000.gpmi-nand: offset 0x0a0 : 0x070a4080 gpmi-nand 1806000.gpmi-nand: offset 0x0b0 : 0x10da4080 gpmi-nand 1806000.gpmi-nand: offset 0x0c0 : 0x070a4080 gpmi-nand 1806000.gpmi-nand: offset 0x0d0 : 0x10da4080 gpmi-nand 1806000.gpmi-nand: offset 0x0e0 : 0x070a4080 gpmi-nand 1806000.gpmi-nand: offset 0x0f0 : 0x10da4080 gpmi-nand 1806000.gpmi-nand: offset 0x100 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x110 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x120 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x130 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x140 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x150 : 0x20484342 gpmi-nand 1806000.gpmi-nand: offset 0x160 : 0x01000000 gpmi-nand 1806000.gpmi-nand: offset 0x170 : 0x00000000 gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chip gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
Regards
Greg
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Miquel,
Quoted 114 lines · Greg Ungerer
Quoted 4 lines · Greg Ungerer
Quoted 3 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Quoted 1 line
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Quoted 15 lines
Quoted 15 lines
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
nand: timing mode 5 not acknowledged by the NAND chip
What is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Sure, how to do that?
This loop [1] tries to configure each mode (5, 4, ...) until one succeeds (default is 0: must always work). Please try to limit mode to 0, 1, etc.
Mode 0 should work.
Quoted 8 lines
Quoted 1 line
[1] https://elixir.bootlin.com/linux/v5.3-rc1/source/drivers/mtd/nand/raw/nand_base.c#L933
The normal behavior - which usually works - has chip->onfi_timing_mode_default=5 here. So in other words on the first pass through this loop it is checking mode 5, and setting it as the default.
I am running a test/reboot loop now waiting for failure to see if it is still using mode 5 in that case.
With this trace in place:
linux/drivers/mtd/nand/raw/nand_base.c +3
-0@@ -910,6 +910,7 @@ static int nand_init_data_interface(struct nand_chip *chip) } for (mode = fls(modes) - 1; mode >= 0; mode--) { + printk("%s(%d): checking mode=%d\n", __FILE__, __LINE__, mode); ret = onfi_fill_data_interface(chip, NAND_SDR_IFACE, mode); if (ret) continue;@@ -923,10 +924,12 @@ static int nand_init_data_interface(struct nand_chip *chip) &chip->data_interface); if (!ret) { chip->onfi_timing_mode_default = mode; + printk("%s(%d): BREAKING AT mode=%d\n", __FILE__, __LINE__, mode); break; } } + printk("%s(%d): chip->onfi_timing_mode_default=%d\n", __FILE__, __LINE__, chip->onfi_timing_mode_default); return 0; }First NAND failure gives this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: use legacy bch geometry drivers/mtd/nand/raw/nand_base.c(913): checking mode=5 drivers/mtd/nand/raw/nand_base.c(927): BREAKING AT mode=5 drivers/mtd/nand/raw/nand_base.c(932): chip->onfi_timing_mode_default=5 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA
gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512
ECC Chunk Count : 4
Quoted 8 lines
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chip gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22
Not sure if this is a useful data point... But I modified that nand_init_data_interface() loop to start checking from data mode 4. So now on every boot it defaults to mode 4. That has been running most of the day, up to 900 boot cycles now, no failures.
Regards
Greg
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Greg,
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 122 lines
Hi Miquel,
Quoted 119 lines · Greg Ungerer
Quoted 4 lines · Greg Ungerer
Quoted 3 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Quoted 1 line
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Quoted 15 lines
Quoted 15 lines
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
nand: timing mode 5 not acknowledged by the NAND chip
What is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Sure, how to do that?
This loop [1] tries to configure each mode (5, 4, ...) until one succeeds (default is 0: must always work). Please try to limit mode to 0, 1, etc.
Mode 0 should work.
Quoted 8 lines
Quoted 1 line
[1] https://elixir.bootlin.com/linux/v5.3-rc1/source/drivers/mtd/nand/raw/nand_base.c#L933
The normal behavior - which usually works - has chip->onfi_timing_mode_default=5 here. So in other words on the first pass through this loop it is checking mode 5, and setting it as the default.
I am running a test/reboot loop now waiting for failure to see if it is still using mode 5 in that case.
With this trace in place:
linux/drivers/mtd/nand/raw/nand_base.c +3
-0@@ -910,6 +910,7 @@ static int nand_init_data_interface(struct nand_chip *chip) } for (mode = fls(modes) - 1; mode >= 0; mode--) { + printk("%s(%d): checking mode=%d\n", __FILE__, __LINE__, mode); ret = onfi_fill_data_interface(chip, NAND_SDR_IFACE, mode); if (ret) continue;@@ -923,10 +924,12 @@ static int nand_init_data_interface(struct nand_chip *chip) &chip->data_interface); if (!ret) { chip->onfi_timing_mode_default = mode; + printk("%s(%d): BREAKING AT mode=%d\n", __FILE__, __LINE__, mode); break; } } + printk("%s(%d): chip->onfi_timing_mode_default=%d\n", __FILE__, __LINE__, chip->onfi_timing_mode_default); return 0; }First NAND failure gives this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: use legacy bch geometry drivers/mtd/nand/raw/nand_base.c(913): checking mode=5 drivers/mtd/nand/raw/nand_base.c(927): BREAKING AT mode=5 drivers/mtd/nand/raw/nand_base.c(932): chip->onfi_timing_mode_default=5 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA
gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
Quoted 8 lines
Quoted 3 lines
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chip gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22Not sure if this is a useful data point... But I modified that
nand_init_data_interface()loop to start checking from data mode 4. So now on every boot it defaults to mode 4. That has been running most of the day, up to 900 boot cycles now, no failures.
Ok so after having chatted quite a bit with Boris, it is very likely that, for these chips, the timings in mode 5 are too tight. It could fail the GET_FEATURES once in mode 5. Can you please dump every single intermediate value in gpmi_nfc_compute_timings() (period, *_cycles, use of half pêriods, tRP, sample delay, etc) as well as the content of /sys/kernel/debug/clk/clk_summary (you'll need debugfs support enabled and mounted).
Also, can you be sure that the NAND chip is powered with 3.3V?
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 135 lines · On Tue, 30 Jul 2019 10:38:22 +0200 Miquel Raynal <[email protected]>…
Hi Greg,
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 122 lines
Hi Miquel,
Quoted 119 lines · Greg Ungerer
Quoted 4 lines · Greg Ungerer
Quoted 3 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Quoted 1 line
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Quoted 15 lines
Quoted 15 lines
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
nand: timing mode 5 not acknowledged by the NAND chip
What is the final timing mode used? Most of us tested in mode 5 I guess, maybe mode 4 is broken (don't know if this is the one used here, neither why mode 5 is refused). Can you please try by limiting the mode to 0, 1, 2... until, hopefully, we narrow down to the failing mode.
Sure, how to do that?
This loop [1] tries to configure each mode (5, 4, ...) until one succeeds (default is 0: must always work). Please try to limit mode to 0, 1, etc.
Mode 0 should work.
Quoted 8 lines
Quoted 1 line
[1] https://elixir.bootlin.com/linux/v5.3-rc1/source/drivers/mtd/nand/raw/nand_base.c#L933
The normal behavior - which usually works - has chip->onfi_timing_mode_default=5 here. So in other words on the first pass through this loop it is checking mode 5, and setting it as the default.
I am running a test/reboot loop now waiting for failure to see if it is still using mode 5 in that case.
With this trace in place:
linux/drivers/mtd/nand/raw/nand_base.c +3
-0@@ -910,6 +910,7 @@ static int nand_init_data_interface(struct nand_chip *chip) } for (mode = fls(modes) - 1; mode >= 0; mode--) { + printk("%s(%d): checking mode=%d\n", __FILE__, __LINE__, mode); ret = onfi_fill_data_interface(chip, NAND_SDR_IFACE, mode); if (ret) continue;@@ -923,10 +924,12 @@ static int nand_init_data_interface(struct nand_chip *chip) &chip->data_interface); if (!ret) { chip->onfi_timing_mode_default = mode; + printk("%s(%d): BREAKING AT mode=%d\n", __FILE__, __LINE__, mode); break; } } + printk("%s(%d): chip->onfi_timing_mode_default=%d\n", __FILE__, __LINE__, chip->onfi_timing_mode_default); return 0; }First NAND failure gives this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: use legacy bch geometry drivers/mtd/nand/raw/nand_base.c(913): checking mode=5 drivers/mtd/nand/raw/nand_base.c(927): BREAKING AT mode=5 drivers/mtd/nand/raw/nand_base.c(932): chip->onfi_timing_mode_default=5 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA
gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.gpmi-nand: offset0x090:0x083e2080gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000gpmi-nand 1806000.gpmi-nand: offset0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0Quoted 8 lines
Quoted 3 lines
gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -110
nand: timing mode 5 not acknowledged by the NAND chip gpmi-nand 1806000.gpmi-nand: Chip: 0, Error -22Not sure if this is a useful data point... But I modified that
nand_init_data_interface()loop to start checking from data mode 4. So now on every boot it defaults to mode 4. That has been running most of the day, up to 900 boot cycles now, no failures.
Quoted 7 lines
Ok so after having chatted quite a bit with Boris, it is very likely that, for these chips, the timings in mode 5 are too tight. It could fail the
GET_FEATURESonce in mode 5. Can you please dump every single intermediate value ingpmi_nfc_compute_timings()(period,*_cycles, use of half pêriods, tRP, sample delay, etc) as well as the content of/sys/kernel/debug/clk/clk_summary(you'll need debugfs support enabled and mounted).
Not sure the clk will stay at the rate it was set during the timing selection. Can you also add a trace printing the result of clk_get_rate(r->clock[0], hw->clk_rate) here [1]?
[1]https://elixir.bootlin.com/linux/v5.3-rc1/source/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c#L711
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Miquel, Boris,
Quoted 21 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 11 lines · Greg Ungerer
Quoted 6 lines · Greg Ungerer
Quoted 4 lines · Miquel Raynal
Quoted 3 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Quoted 1 line
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Not sure if this is a useful data point... But I modified that
nand_init_data_interface()loop to start checking from data mode 4. So now on every boot it defaults to mode 4. That has been running most of the day, up to 900 boot cycles now, no failures.Ok so after having chatted quite a bit with Boris, it is very likely that, for these chips, the timings in mode 5 are too tight. It could fail the
GET_FEATURESonce in mode 5. Can you please dump every single intermediate value ingpmi_nfc_compute_timings()(period,*_cycles, use of half pêriods, tRP, sample delay, etc) as well as the content of/sys/kernel/debug/clk/clk_summary(you'll need debugfs support enabled and mounted).
Quoted 1 line
Also, can you be sure that the NAND chip is powered with 3.3V?
Yes, 3.3V NAND chip.
Using the attached patch I get the following trace:
...
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426): gpmi_nfc_compute_timings()
sdr->tBERS_max=65535000000
sdr->tCCS_min=500000000
sdr->tPROG_max=65535000000
sdr->tR_max=200000000000000
sdr->tALH_min=20000
sdr->tADL_min=400000
sdr->tALS_min=50000
sdr->tAR_min=25000
sdr->tCEA_max=100000
sdr->tCEH_min=20000
sdr->tCH_min=20000
sdr->tCHZ_max=100000
sdr->tCLH_min=20000
sdr->tCLR_min=20000
sdr->tCLS_min=50000
sdr->tCOH_min=0
sdr->tCS_min=70000
sdr->tDH_min=20000
sdr->tDS_min=40000
sdr->tFEAT_max=1000000
sdr->tIR_min=10000
sdr->tITC_max=1000000
sdr->tRC_min=100000
sdr->tREA_max=40000
sdr->tREH_min=30000
sdr->tRHOH_min=0
sdr->tRHW_min=200000
sdr->tRHZ_max=200000
sdr->tRLOH_min=0
sdr->tRP_min=50000
sdr->tRR_min=40000
sdr->tRST_max=250000000000
sdr->tWB_max=200000
sdr->tWC_min=100000
sdr->tWH_min=30000
sdr->tWHR_min=120000
sdr->tWP_min=50000
sdr->tWW_min=100000
hw->clk_rate=22000000
wrn_dly_sel=0
period_ps=45454
addr_setup_cycles=2
data_setup_cycles=1
data_hold_cycles=1
busy_timeout_cycles=31302
hw->timing0=0x00020101
hw->timing1=0x60000000
dll_threshold_ps=12000
use_half_period=1
reference_period_ps=22727
tRP_ps=45454
sample_delay_ps=4294955664
sample_delay_factor=0
hw->ctrl1n=0x00000000
hw->ctrl1n=0x00000000drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547): gpmi_nfc_apply_timings()
hw>clk_rate=22000000
clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=22000000
random: fast init done
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426): gpmi_nfc_compute_timings()
sdr->tBERS_max=3000000000
sdr->tCCS_min=100000
sdr->tPROG_max=600000000
sdr->tR_max=25000000
sdr->tALH_min=20000
sdr->tADL_min=400000
sdr->tALS_min=50000
sdr->tAR_min=25000
sdr->tCEA_max=100000
sdr->tCEH_min=20000
sdr->tCH_min=20000
sdr->tCHZ_max=100000
sdr->tCLH_min=20000
sdr->tCLR_min=20000
sdr->tCLS_min=50000
sdr->tCOH_min=0
sdr->tCS_min=70000
sdr->tDH_min=20000
sdr->tDS_min=40000
sdr->tFEAT_max=1000000
sdr->tIR_min=10000
sdr->tITC_max=1000000
sdr->tRC_min=100000
sdr->tREA_max=40000
sdr->tREH_min=30000
sdr->tRHOH_min=0
sdr->tRHW_min=200000
sdr->tRHZ_max=200000
sdr->tRLOH_min=0
sdr->tRP_min=50000
sdr->tRR_min=40000
sdr->tRST_max=250000000000
sdr->tWB_max=200000
sdr->tWC_min=100000
sdr->tWH_min=30000
sdr->tWHR_min=120000
sdr->tWP_min=50000
sdr->tWW_min=100000
hw->clk_rate=22000000
wrn_dly_sel=0
period_ps=45454
addr_setup_cycles=2
data_setup_cycles=1
data_hold_cycles=1
busy_timeout_cycles=555
hw->timing0=0x00020101
hw->timing1=0xb0000000
dll_threshold_ps=12000
use_half_period=1
reference_period_ps=22727
tRP_ps=45454
sample_delay_ps=4294955664
sample_delay_factor=0
hw->ctrl1n=0x00000000
hw->ctrl1n=0x00000000drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547): gpmi_nfc_apply_timings()
hw>clk_rate=22000000
clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=22000000
gpmi-nand 1806000.gpmi-nand: use legacy bch geometry drivers/mtd/nand/raw/nand_base.c(913): checking mode=5 drivers/mtd/nand/raw/nand_base.c(927): BREAKING AT mode=5 drivers/mtd/nand/raw/nand_base.c(932): chip->onfi_timing_mode_default=5 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426): gpmi_nfc_compute_timings()
sdr->tBERS_max=3000000000
sdr->tCCS_min=100000
sdr->tPROG_max=600000000
sdr->tR_max=25000000
sdr->tALH_min=5000
sdr->tADL_min=400000
sdr->tALS_min=10000
sdr->tAR_min=10000
sdr->tCEA_max=25000
sdr->tCEH_min=20000
sdr->tCH_min=5000
sdr->tCHZ_max=30000
sdr->tCLH_min=5000
sdr->tCLR_min=10000
sdr->tCLS_min=10000
sdr->tCOH_min=15000
sdr->tCS_min=15000
sdr->tDH_min=5000
sdr->tDS_min=7000
sdr->tFEAT_max=1000000
sdr->tIR_min=0
sdr->tITC_max=1000000
sdr->tRC_min=20000
sdr->tREA_max=16000
sdr->tREH_min=7000
sdr->tRHOH_min=15000
sdr->tRHW_min=100000
sdr->tRHZ_max=100000
sdr->tRLOH_min=5000
sdr->tRP_min=10000
sdr->tRR_min=20000
sdr->tRST_max=500000000
sdr->tWB_max=100000
sdr->tWC_min=20000
sdr->tWH_min=7000
sdr->tWHR_min=80000
sdr->tWP_min=10000
sdr->tWW_min=100000
hw->clk_rate=100000000
wrn_dly_sel=3
period_ps=10000
addr_setup_cycles=1
data_setup_cycles=1
data_hold_cycles=1
busy_timeout_cycles=2510
hw->timing0=0x00010101
hw->timing1=0xe0000000
dll_threshold_ps=12000
use_half_period=0
reference_period_ps=10000
tRP_ps=10000
sample_delay_ps=80000
sample_delay_factor=8
hw->ctrl1n=0x00c00000
hw->ctrl1n=0x00c28000drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547): gpmi_nfc_apply_timings()
hw>clk_rate=100000000
clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=99000000
Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...
And "cat /sys/kernel/debug/clk/clk_summary" gives:
enable prepare protect duty
clock count count count rate accuracy phase cycle
---------------------------------------------------------------------------------------------
dummy 2 2 0 0 0 0 50000
cko2_sel 0 0 0 0 0 0 50000
cko2_podf 0 0 0 0 0 0 50000
cko2 0 0 0 0 0 0 50000
cko1_sel 0 0 0 0 0 0 50000
cko1_podf 0 0 0 0 0 0 50000
cko1 0 0 0 0 0 0 50000
cko 0 0 0 0 0 0 50000
usbphy2_gate 1 1 0 0 0 0 50000
usbphy1_gate 1 1 0 0 0 0 50000
ipp_di1 0 0 0 0 0 0 50000
ipp_di0 0 0 0 0 0 0 50000
osc 6 6 0 24000000 0 0 50000
perclk_sel 1 1 0 24000000 0 0 50000
perclk 3 3 0 24000000 0 0 50000
pwm7 0 0 0 24000000 0 0 50000
pwm6 0 0 0 24000000 0 0 50000
pwm5 0 0 0 24000000 0 0 50000
i2c4 0 0 0 24000000 0 0 50000
pwm8 0 0 0 24000000 0 0 50000
pwm4 0 0 0 24000000 0 0 50000
pwm3 0 0 0 24000000 0 0 50000
pwm2 0 0 0 24000000 0 0 50000
pwm1 0 0 0 24000000 0 0 50000
i2c3 0 0 0 24000000 0 0 50000
i2c2 1 1 0 24000000 0 0 50000
i2c1 0 0 0 24000000 0 0 50000
gpt1_serial 1 1 0 24000000 0 0 50000
gpt1_bus 1 1 0 24000000 0 0 50000
epit2 0 0 0 24000000 0 0 50000
epit1 0 0 0 24000000 0 0 50000
gpt2_serial 0 0 0 24000000 0 0 50000
gpt2_bus 0 0 0 24000000 0 0 50000
periph_clk2_sel 0 0 0 24000000 0 0 50000
periph_clk2 0 0 0 24000000 0 0 50000
gpt_3m 0 0 0 3000000 0 0 50000
csi_sel 0 0 0 24000000 0 0 50000
csi_podf 0 0 0 24000000 0 0 50000
csi 0 0 0 24000000 0 0 50000
pll7 1 1 0 480000000 0 0 50000
pll7_bypass 1 1 0 480000000 0 0 50000
pll7_usb_host 1 1 0 480000000 0 0 50000
usbphy2 1 1 0 480000000 0 0 50000
pll6 1 1 0 500000000 0 0 50000
pll6_bypass 1 1 0 500000000 0 0 50000
pll6_enet 2 2 0 500000000 0 0 50000
enet_ptp_ref 1 1 0 25000000 0 0 50000
enet_ptp 1 1 0 25000000 0 0 50000
enet2_ref 0 0 0 50000000 0 0 50000
enet_ref_125m 0 0 0 50000000 0 0 50000
enet_ref 2 2 0 50000000 0 0 50000
pll5 0 0 0 296600000 0 0 50000
pll5_bypass 0 0 0 296600000 0 0 50000
pll5_video 0 0 0 296600000 0 0 50000
pll5_post_div 0 0 0 74150000 0 0 50000
pll5_video_div 0 0 0 74150000 0 0 50000
pll4 0 0 0 147456000 0 0 50000
pll4_bypass 0 0 0 147456000 0 0 50000
pll4_audio 0 0 0 147456000 0 0 50000
pll4_post_div 0 0 0 36864000 0 0 50000
pll4_audio_div 0 0 0 36864000 0 0 50000
pll3 1 1 0 480000000 0 0 50000
pll3_bypass 1 1 0 480000000 0 0 50000
pll3_usb_otg 2 2 0 480000000 0 0 50000
spdif_sel 0 0 0 480000000 0 0 50000
spdif_pred 0 0 0 240000000 0 0 50000
spdif_podf 0 0 0 30000000 0 0 50000
spdif 0 0 0 30000000 0 0 50000
esai_sel 0 0 0 480000000 0 0 50000
esai_pred 0 0 0 240000000 0 0 50000
esai_podf 0 0 0 30000000 0 0 50000
esai_extal 0 0 0 30000000 0 0 50000
qspi1_sel 0 0 0 480000000 0 0 50000
qspi1_podf 0 0 0 240000000 0 0 50000
qspi1 0 0 0 240000000 0 0 50000
ldb_di1_div_7 0 0 0 68571428 0 0 50000
ldb_di1 0 0 0 68571428 0 0 50000
ldb_di1_div_3_5 0 0 0 137142857 0 0 50000
periph2_clk2_sel 0 0 0 480000000 0 0 50000
periph2_clk2 0 0 0 480000000 0 0 50000
pll3_60m 0 0 0 60000000 0 0 50000
can_sel 0 0 0 60000000 0 0 50000
can_podf 0 0 0 30000000 0 0 50000
can2_serial 0 0 0 30000000 0 0 50000
can1_serial 0 0 0 30000000 0 0 50000
ecspi_sel 0 0 0 60000000 0 0 50000
ecspi_podf 0 0 0 60000000 0 0 50000
ecspi4 0 0 0 60000000 0 0 50000
ecspi3 0 0 0 60000000 0 0 50000
ecspi2 0 0 0 60000000 0 0 50000
ecspi1 0 0 0 60000000 0 0 50000
pll3_80m 1 1 0 80000000 0 0 50000
uart_sel 1 1 0 80000000 0 0 50000
uart_podf 1 1 0 80000000 0 0 50000
uart8_serial 0 0 0 80000000 0 0 50000
uart7_serial 0 0 0 80000000 0 0 50000
uart1_serial 1 2 0 80000000 0 0 50000
uart6_serial 0 0 0 80000000 0 0 50000
uart5_serial 0 0 0 80000000 0 0 50000
uart4_serial 0 0 0 80000000 0 0 50000
uart3_serial 0 0 0 80000000 0 0 50000
uart2_serial 0 0 0 80000000 0 0 50000
pll3_pfd3_454m 0 0 0 454736842 0 0 50000
pll3_pfd2_508m 0 0 0 508235294 0 0 50000
epdc_pre_sel 0 0 0 508235294 0 0 50000
epdc_podf 0 0 0 254117647 0 0 50000
epdc_pix 0 0 0 254117647 0 0 50000
epdc_sel 0 0 0 254117647 0 0 50000
sai1_sel 0 0 0 508235294 0 0 50000
sai1_pred 0 0 0 127058824 0 0 50000
sai1_podf 0 0 0 63529412 0 0 50000
sai1 0 0 0 63529412 0 0 50000
sai2_sel 0 0 0 508235294 0 0 50000
sai2_pred 0 0 0 127058824 0 0 50000
sai2_podf 0 0 0 63529412 0 0 50000
sai2 0 0 0 63529412 0 0 50000
sai3_sel 0 0 0 508235294 0 0 50000
sai3_pred 0 0 0 127058824 0 0 50000
sai3_podf 0 0 0 63529412 0 0 50000
sai3 0 0 0 63529412 0 0 50000
pll3_pfd1_540m 0 0 0 540000000 0 0 50000
lcdif_pre_sel 0 0 0 540000000 0 0 50000
lcdif_pred 0 0 0 270000000 0 0 50000
lcdif_podf 0 0 0 135000000 0 0 50000
lcdif_pix 0 0 0 135000000 0 0 50000
iomuxc 0 0 0 135000000 0 0 50000
lcdif_sel 0 0 0 135000000 0 0 50000
pll3_pfd0_720m 0 0 0 720000000 0 0 50000
usbphy1 1 1 0 480000000 0 0 50000
pll2 1 1 0 528000000 0 0 50000
pll2_bypass 1 1 0 528000000 0 0 50000
pll2_bus 2 2 0 528000000 0 0 50000
ca7_secondary_sel 0 0 0 528000000 0 0 50000
step 0 0 0 528000000 0 0 50000
periph_pre 1 1 0 528000000 0 0 50000
periph 3 3 0 528000000 0 0 50000
ahb 7 7 0 132000000 0 0 50000
sdma 0 0 0 132000000 0 0 50000
rom 1 1 0 132000000 0 0 50000
esai_mem 0 0 0 132000000 0 0 50000
esai_ipg 0 0 0 132000000 0 0 50000
aips_tz3 1 1 0 132000000 0 0 50000
enet_ahb 2 2 0 132000000 0 0 50000
dcp 0 0 0 132000000 0 0 50000
asrc_mem 0 0 0 132000000 0 0 50000
asrc_ipg 0 0 0 132000000 0 0 50000
aips_tz2 1 1 0 132000000 0 0 50000
aips_tz1 1 1 0 132000000 0 0 50000
ipg 10 10 0 66000000 0 0 50000
wdog3 0 0 0 66000000 0 0 50000
uart8_ipg 0 0 0 66000000 0 0 50000
usboh3 2 2 0 66000000 0 0 50000
sai2_ipg 0 0 0 66000000 0 0 50000
sai1_ipg 0 0 0 66000000 0 0 50000
uart7_ipg 0 0 0 66000000 0 0 50000
uart1_ipg 1 2 0 66000000 0 0 50000
sai3_ipg 0 0 0 66000000 0 0 50000
spdif_gclk 0 0 0 66000000 0 0 50000
spba 0 0 0 66000000 0 0 50000
wdog2 0 0 0 66000000 0 0 50000
kpp 0 0 0 66000000 0 0 50000
mmdc_p1_ipg 0 0 0 66000000 0 0 50000
mmdc_p0_ipg 2 2 0 66000000 0 0 50000
wdog1 1 1 0 66000000 0 0 50000
gpio4 1 1 0 66000000 0 0 50000
uart6_ipg 0 0 0 66000000 0 0 50000
uart5_ipg 0 0 0 66000000 0 0 50000
gpio3 1 1 0 66000000 0 0 50000
ocotp 0 0 0 66000000 0 0 50000
gpio5 1 1 0 66000000 0 0 50000
gpio1 1 1 0 66000000 0 0 50000
uart4_ipg 0 0 0 66000000 0 0 50000
adc1 0 0 0 66000000 0 0 50000
uart3_ipg 0 0 0 66000000 0 0 50000
adc2 0 0 0 66000000 0 0 50000
gpio2 1 1 0 66000000 0 0 50000
uart2_ipg 0 0 0 66000000 0 0 50000
can2_ipg 0 0 0 66000000 0 0 50000
can1_ipg 0 0 0 66000000 0 0 50000
enet 2 2 0 66000000 0 0 50000
axi_sel 1 1 0 528000000 0 0 50000
axi_podf 2 2 0 264000000 0 0 50000
axi 1 1 0 264000000 0 0 50000
eim_slow_sel 0 0 0 264000000 0 0 50000
eim_slow_podf 0 0 0 132000000 0 0 50000
eim 0 0 0 132000000 0 0 50000
lcdif_apb 0 0 0 264000000 0 0 50000
pxp 0 0 0 264000000 0 0 50000
epdc_aclk 0 0 0 264000000 0 0 50000
pll2_pfd3_594m 0 0 0 594000000 0 0 50000
ldb_di0_sel 0 0 0 594000000 0 0 50000
ldb_di0_div_7 0 0 0 84857142 0 0 50000
ldb_di0 0 0 0 84857142 0 0 50000
ldb_di0_div_3_5 0 0 0 169714285 0 0 50000
pll2_pfd2_396m 2 2 0 396000000 0 0 50000
enfc_sel 0 0 0 396000000 0 0 50000
enfc_pred 0 0 0 99000000 0 0 50000
enfc_podf 0 0 0 99000000 0 0 50000
gpmi_io 0 0 0 99000000 0 0 50000
usdhc1_sel 0 0 0 396000000 0 0 50000
usdhc1_podf 0 0 0 198000000 0 0 50000
usdhc1 0 0 0 198000000 0 0 50000
usdhc2_sel 0 0 0 396000000 0 0 50000
usdhc2_podf 0 0 0 198000000 0 0 50000
usdhc2 0 0 0 198000000 0 0 50000
bch_sel 1 1 0 396000000 0 0 50000
bch_podf 1 1 0 99000000 0 0 50000
gpmi_apb 0 0 0 99000000 0 0 50000
gpmi_bch_apb 0 0 0 99000000 0 0 50000
per_bch 0 0 0 99000000 0 0 50000
apbh_dma 1 1 0 99000000 0 0 50000
gpmi_sel 0 0 0 396000000 0 0 50000
gpmi_podf 0 0 0 99000000 0 0 50000
gpmi_bch 0 0 0 99000000 0 0 50000
periph2_pre 1 1 0 396000000 0 0 50000
periph2 2 2 0 396000000 0 0 50000
mmdc_podf 2 2 0 396000000 0 0 50000
mmdc_p0_fast 1 1 0 396000000 0 0 50000
axi_alt_sel 0 0 0 396000000 0 0 50000
pll2_198m 0 0 0 198000000 0 0 50000
pll2_pfd1_594m 0 0 0 594000000 0 0 50000
pll2_pfd0_352m 0 0 0 352000000 0 0 50000
pll1 1 1 0 900000000 0 0 50000
pll1_bypass 1 1 0 900000000 0 0 50000
pll1_sys 1 1 0 900000000 0 0 50000
pll1_sw 1 1 0 900000000 0 0 50000
arm 1 1 0 900000000 0 0 50000
pll7_bypass_src 0 0 0 24000000 0 0 50000
pll6_bypass_src 0 0 0 24000000 0 0 50000
pll5_bypass_src 0 0 0 24000000 0 0 50000
pll4_bypass_src 0 0 0 24000000 0 0 50000
pll3_bypass_src 0 0 0 24000000 0 0 50000
pll2_bypass_src 0 0 0 24000000 0 0 50000
pll1_bypass_src 0 0 0 24000000 0 0 50000ckil 0 0 0 32768 0 0 50000
Note that this was generated on a normal boot up (not failure).
Running boot testing now waiting for a failure.
Regards
Greg
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +63 -1
@@ -423,6 +423,46 @@u16 busy_timeout_cycles;u8 wrn_dly_sel; +printk ("%s(%d): gpmi_nfc_compute_timings()\n" , __FILE__, __LINE__); +printk (" sdr->tBERS_max=%llu\n" , sdr->tBERS_max); +printk (" sdr->tCCS_min=%u\n" , sdr->tCCS_min); +printk (" sdr->tPROG_max=%llu\n" , sdr->tPROG_max); +printk (" sdr->tR_max=%llu\n" , sdr->tR_max); +printk (" sdr->tALH_min=%u\n" , sdr->tALH_min); +printk (" sdr->tADL_min=%u\n" , sdr->tADL_min); +printk (" sdr->tALS_min=%u\n" , sdr->tALS_min); +printk (" sdr->tAR_min=%u\n" , sdr->tAR_min); +printk (" sdr->tCEA_max=%u\n" , sdr->tCEA_max); +printk (" sdr->tCEH_min=%u\n" , sdr->tCEH_min); +printk (" sdr->tCH_min=%u\n" , sdr->tCH_min); +printk (" sdr->tCHZ_max=%u\n" , sdr->tCHZ_max); +printk (" sdr->tCLH_min=%u\n" , sdr->tCLH_min); +printk (" sdr->tCLR_min=%u\n" , sdr->tCLR_min); +printk (" sdr->tCLS_min=%u\n" , sdr->tCLS_min); +printk (" sdr->tCOH_min=%u\n" , sdr->tCOH_min); +printk (" sdr->tCS_min=%u\n" , sdr->tCS_min); +printk (" sdr->tDH_min=%u\n" , sdr->tDH_min); +printk (" sdr->tDS_min=%u\n" , sdr->tDS_min); +printk (" sdr->tFEAT_max=%u\n" , sdr->tFEAT_max); +printk (" sdr->tIR_min=%u\n" , sdr->tIR_min); +printk (" sdr->tITC_max=%u\n" , sdr->tITC_max); +printk (" sdr->tRC_min=%u\n" , sdr->tRC_min); +printk (" sdr->tREA_max=%u\n" , sdr->tREA_max); +printk (" sdr->tREH_min=%u\n" , sdr->tREH_min); +printk (" sdr->tRHOH_min=%u\n" , sdr->tRHOH_min); +printk (" sdr->tRHW_min=%u\n" , sdr->tRHW_min); +printk (" sdr->tRHZ_max=%u\n" , sdr->tRHZ_max); +printk (" sdr->tRLOH_min=%u\n" , sdr->tRLOH_min); +printk (" sdr->tRP_min=%u\n" , sdr->tRP_min); +printk (" sdr->tRR_min=%u\n" , sdr->tRR_min); +printk (" sdr->tRST_max=%llu\n" , sdr->tRST_max); +printk (" sdr->tWB_max=%u\n" , sdr->tWB_max); +printk (" sdr->tWC_min=%u\n" , sdr->tWC_min); +printk (" sdr->tWH_min=%u\n" , sdr->tWH_min); +printk (" sdr->tWHR_min=%u\n" , sdr->tWHR_min); +printk (" sdr->tWP_min=%u\n" , sdr->tWP_min); +printk (" sdr->tWW_min=%u\n" , sdr->tWW_min); +if (sdr->tRC_min >=30000 ) {/* ONFI non-EDO modes [0-3] */ hw->clk_rate =22000000 ;
@@ -436,19 +476,28 @@ hw->clk_rate =100000000 ; wrn_dly_sel =BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY ; } +printk (" hw->clk_rate=%lu\n" , hw->clk_rate); +printk (" wrn_dly_sel=%u\n" , wrn_dly_sel);/* SDR core timings are given in picoseconds */ period_ps =div_u64 ((u64 )NSEC_PER_SEC *1000 , hw->clk_rate); +printk (" period_ps=%u\n" , period_ps); addr_setup_cycles =TO_CYCLES (sdr->tALS_min, period_ps); +printk (" addr_setup_cycles=%u\n" , addr_setup_cycles); data_setup_cycles =TO_CYCLES (sdr->tDS_min, period_ps); +printk (" data_setup_cycles=%u\n" , data_setup_cycles); data_hold_cycles =TO_CYCLES (sdr->tDH_min, period_ps); +printk (" data_hold_cycles=%u\n" , data_hold_cycles); busy_timeout_cycles =TO_CYCLES (sdr->tWB_max + sdr->tR_max, period_ps); +printk (" busy_timeout_cycles=%u\n" , busy_timeout_cycles); hw->timing0 =BF_GPMI_TIMING0_ADDRESS_SETUP (addr_setup_cycles) |BF_GPMI_TIMING0_DATA_HOLD (data_hold_cycles) |BF_GPMI_TIMING0_DATA_SETUP (data_setup_cycles); +printk (" hw->timing0=0x%08x\n" , hw->timing0); hw->timing1 =BF_GPMI_TIMING1_BUSY_TIMEOUT (busy_timeout_cycles *4096 ); +printk (" hw->timing1=0x%08x\n" , hw->timing1);/* * Derive NFC ideal delay from {3}:
@@ -457,6 +506,7 @@* RDN_DELAY = ----------------------- * RP */ +printk (" dll_threshold_ps=%u\n" , dll_threshold_ps);if (period_ps > dll_threshold_ps) { use_half_period = true; reference_period_ps = period_ps /2 ;
@@ -464,19 +514,26 @@ use_half_period = false; reference_period_ps = period_ps; } +printk (" use_half_period=%u\n" , use_half_period); +printk (" reference_period_ps=%u\n" , reference_period_ps); tRP_ps = data_setup_cycles * period_ps; +printk (" tRP_ps=%u\n" , tRP_ps); sample_delay_ps = (sdr->tREA_max +4000 - tRP_ps) *8 ; +printk (" sample_delay_ps=%u\n" , sample_delay_ps);if (sample_delay_ps >0 ) sample_delay_factor = sample_delay_ps / reference_period_ps;else sample_delay_factor =0 ; +printk (" sample_delay_factor=%u\n" , sample_delay_factor); hw->ctrl1n =BF_GPMI_CTRL1_WRN_DLY_SEL (wrn_dly_sel); +printk (" hw->ctrl1n=0x%08x\n" , hw->ctrl1n);if (sample_delay_factor) hw->ctrl1n |=BF_GPMI_CTRL1_RDN_DELAY (sample_delay_factor) |BM_GPMI_CTRL1_DLL_ENABLE | (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); +printk (" hw->ctrl1n=0x%08x\n" , hw->ctrl1n); }void gpmi_nfc_apply_timings (struct gpmi_nand_data *this)
@@ -485,8 +542,13 @@struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; +int ret; -clk_set_rate (r->clock[0 ], hw->clk_rate); +printk ("%s(%d): gpmi_nfc_apply_timings()\n" , __FILE__, __LINE__); +printk (" hw>clk_rate=%lu\n" , hw->clk_rate); + ret =clk_set_rate (r->clock[0 ], hw->clk_rate); +printk (" clk_set_rate(r->clock[0], hw->clk_rate)=%d\n" , ret); +printk (" clk_get_rate(r->clock[0])=%lu\n" ,clk_get_rate (r->clock[0 ]));writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );
drivers/mtd/nand/raw/nand_base.c +3 -0
@@ -910,6 +910,7 @@ static int nand_init_data_interface(struct nand_chip *chip) }for (mode =fls (modes) -1 ; mode >=0 ; mode--) { +printk ("%s(%d): checking mode=%d\n" , __FILE__, __LINE__, mode); ret =onfi_fill_data_interface (chip,NAND_SDR_IFACE , mode);if (ret)continue ;
@@ -923,10 +924,12 @@ static int nand_init_data_interface(struct nand_chip *chip) &chip->data_interface);if (!ret) { chip->onfi_timing_mode_default = mode; +printk ("%s(%d): BREAKING AT mode=%d\n" , __FILE__, __LINE__, mode);break ; } } +printk ("%s(%d): chip->onfi_timing_mode_default=%d\n" , __FILE__, __LINE__, chip->onfi_timing_mode_default);return 0 ; }
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 470 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Hi Miquel, Boris,
Quoted 21 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 11 lines · Greg Ungerer
Quoted 6 lines · Greg Ungerer
Quoted 4 lines · Miquel Raynal
Quoted 3 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Quoted 1 line
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Not sure if this is a useful data point... But I modified that
nand_init_data_interface()loop to start checking from data mode 4. So now on every boot it defaults to mode 4. That has been running most of the day, up to 900 boot cycles now, no failures.Ok so after having chatted quite a bit with Boris, it is very likely that, for these chips, the timings in mode 5 are too tight. It could fail the
GET_FEATURESonce in mode 5. Can you please dump every single intermediate value ingpmi_nfc_compute_timings()(period,*_cycles, use of half pêriods, tRP, sample delay, etc) as well as the content of/sys/kernel/debug/clk/clk_summary(you'll need debugfs support enabled and mounted).Quoted 1 line
Also, can you be sure that the NAND chip is powered with 3.3V?
Yes, 3.3V NAND chip.
Using the attached patch I get the following trace:
...
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426):gpmi_nfc_compute_timings()
sdr->tBERS_max=65535000000
sdr->tCCS_min=500000000
sdr->tPROG_max=65535000000
sdr->tR_max=200000000000000
sdr->tALH_min=20000
sdr->tADL_min=400000
sdr->tALS_min=50000
sdr->tAR_min=25000
sdr->tCEA_max=100000
sdr->tCEH_min=20000
sdr->tCH_min=20000
sdr->tCHZ_max=100000
sdr->tCLH_min=20000
sdr->tCLR_min=20000
sdr->tCLS_min=50000
sdr->tCOH_min=0
sdr->tCS_min=70000
sdr->tDH_min=20000
sdr->tDS_min=40000
sdr->tFEAT_max=1000000
sdr->tIR_min=10000
sdr->tITC_max=1000000
sdr->tRC_min=100000
sdr->tREA_max=40000
sdr->tREH_min=30000
sdr->tRHOH_min=0
sdr->tRHW_min=200000
sdr->tRHZ_max=200000
sdr->tRLOH_min=0
sdr->tRP_min=50000
sdr->tRR_min=40000
sdr->tRST_max=250000000000
sdr->tWB_max=200000
sdr->tWC_min=100000
sdr->tWH_min=30000
sdr->tWHR_min=120000
sdr->tWP_min=50000
sdr->tWW_min=100000hw->clk_rate=22000000 wrn_dly_sel=0 period_ps=45454 addr_setup_cycles=2 data_setup_cycles=1 data_hold_cycles=1 busy_timeout_cycles=31302 hw->timing0=0x00020101 hw->timing1=0x60000000 dll_threshold_ps=12000 use_half_period=1 reference_period_ps=22727 tRP_ps=45454 sample_delay_ps=4294955664 sample_delay_factor=0 hw->ctrl1n=0x00000000 hw->ctrl1n=0x00000000drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547):
gpmi_nfc_apply_timings()
hw>clk_rate=22000000
clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=22000000
random: fast init done
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426):gpmi_nfc_compute_timings()
sdr->tBERS_max=3000000000
sdr->tCCS_min=100000
sdr->tPROG_max=600000000
sdr->tR_max=25000000
sdr->tALH_min=20000
sdr->tADL_min=400000
sdr->tALS_min=50000
sdr->tAR_min=25000
sdr->tCEA_max=100000
sdr->tCEH_min=20000
sdr->tCH_min=20000
sdr->tCHZ_max=100000
sdr->tCLH_min=20000
sdr->tCLR_min=20000
sdr->tCLS_min=50000
sdr->tCOH_min=0
sdr->tCS_min=70000
sdr->tDH_min=20000
sdr->tDS_min=40000
sdr->tFEAT_max=1000000
sdr->tIR_min=10000
sdr->tITC_max=1000000
sdr->tRC_min=100000
sdr->tREA_max=40000
sdr->tREH_min=30000
sdr->tRHOH_min=0
sdr->tRHW_min=200000
sdr->tRHZ_max=200000
sdr->tRLOH_min=0
sdr->tRP_min=50000
sdr->tRR_min=40000
sdr->tRST_max=250000000000
sdr->tWB_max=200000
sdr->tWC_min=100000
sdr->tWH_min=30000
sdr->tWHR_min=120000
sdr->tWP_min=50000
sdr->tWW_min=100000hw->clk_rate=22000000 wrn_dly_sel=0 period_ps=45454 addr_setup_cycles=2 data_setup_cycles=1 data_hold_cycles=1 busy_timeout_cycles=555 hw->timing0=0x00020101 hw->timing1=0xb0000000 dll_threshold_ps=12000 use_half_period=1 reference_period_ps=22727 tRP_ps=45454 sample_delay_ps=4294955664 sample_delay_factor=0 hw->ctrl1n=0x00000000 hw->ctrl1n=0x00000000drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547):
gpmi_nfc_apply_timings()
hw>clk_rate=22000000
clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=22000000
gpmi-nand 1806000.gpmi-nand: use legacy bch geometry drivers/mtd/nand/raw/nand_base.c(913): checking mode=5 drivers/mtd/nand/raw/nand_base.c(927): BREAKING AT mode=5 drivers/mtd/nand/raw/nand_base.c(932): chip->onfi_timing_mode_default=5 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426):gpmi_nfc_compute_timings()
sdr->tBERS_max=3000000000
sdr->tCCS_min=100000
sdr->tPROG_max=600000000
sdr->tR_max=25000000
sdr->tALH_min=5000
sdr->tADL_min=400000
sdr->tALS_min=10000
sdr->tAR_min=10000
sdr->tCEA_max=25000
sdr->tCEH_min=20000
sdr->tCH_min=5000
sdr->tCHZ_max=30000
sdr->tCLH_min=5000
sdr->tCLR_min=10000
sdr->tCLS_min=10000
sdr->tCOH_min=15000
sdr->tCS_min=15000
sdr->tDH_min=5000
sdr->tDS_min=7000
sdr->tFEAT_max=1000000
sdr->tIR_min=0
sdr->tITC_max=1000000
sdr->tRC_min=20000
sdr->tREA_max=16000
sdr->tREH_min=7000
sdr->tRHOH_min=15000
sdr->tRHW_min=100000
sdr->tRHZ_max=100000
sdr->tRLOH_min=5000
sdr->tRP_min=10000
sdr->tRR_min=20000
sdr->tRST_max=500000000
sdr->tWB_max=100000
sdr->tWC_min=20000
sdr->tWH_min=7000
sdr->tWHR_min=80000
sdr->tWP_min=10000
sdr->tWW_min=100000hw->clk_rate=100000000 wrn_dly_sel=3 period_ps=10000 addr_setup_cycles=1 data_setup_cycles=1 data_hold_cycles=1 busy_timeout_cycles=2510 hw->timing0=0x00010101 hw->timing1=0xe0000000 dll_threshold_ps=12000 use_half_period=0 reference_period_ps=10000 tRP_ps=10000 sample_delay_ps=80000 sample_delay_factor=8 hw->ctrl1n=0x00c00000 hw->ctrl1n=0x00c28000drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547):
gpmi_nfc_apply_timings()
hw>clk_rate=100000000
clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=99000000
Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...And "cat
/sys/kernel/debug/clk/clk_summary" gives:enable prepare protect duty
clock count count count rate accuracy phase cycle
---------------------------------------------------------------------------------------------dummy 2 2 0 0 0 0 50000 cko2_sel 0 0 0 0 0 0 50000 cko2_podf 0 0 0 0 0 0 50000 cko2 0 0 0 0 0 0 50000 cko1_sel 0 0 0 0 0 0 50000 cko1_podf 0 0 0 0 0 0 50000 cko1 0 0 0 0 0 0 50000 cko 0 0 0 0 0 0 50000 usbphy2_gate 1 1 0 0 0 0 50000 usbphy1_gate 1 1 0 0 0 0 50000 ipp_di1 0 0 0 0 0 0 50000 ipp_di0 0 0 0 0 0 0 50000 osc 6 6 0 24000000 0 0 50000 perclk_sel 1 1 0 24000000 0 0 50000 perclk 3 3 0 24000000 0 0 50000 pwm7 0 0 0 24000000 0 0 50000 pwm6 0 0 0 24000000 0 0 50000 pwm5 0 0 0 24000000 0 0 50000 i2c4 0 0 0 24000000 0 0 50000 pwm8 0 0 0 24000000 0 0 50000 pwm4 0 0 0 24000000 0 0 50000 pwm3 0 0 0 24000000 0 0 50000 pwm2 0 0 0 24000000 0 0 50000 pwm1 0 0 0 24000000 0 0 50000 i2c3 0 0 0 24000000 0 0 50000 i2c2 1 1 0 24000000 0 0 50000 i2c1 0 0 0 24000000 0 0 50000 gpt1_serial 1 1 0 24000000 0 0 50000 gpt1_bus 1 1 0 24000000 0 0 50000 epit2 0 0 0 24000000 0 0 50000 epit1 0 0 0 24000000 0 0 50000 gpt2_serial 0 0 0 24000000 0 0 50000 gpt2_bus 0 0 0 24000000 0 0 50000 periph_clk2_sel 0 0 0 24000000 0 0 50000 periph_clk2 0 0 0 24000000 0 0 50000 gpt_3m 0 0 0 3000000 0 0 50000 csi_sel 0 0 0 24000000 0 0 50000 csi_podf 0 0 0 24000000 0 0 50000 csi 0 0 0 24000000 0 0 50000 pll7 1 1 0 480000000 0 0 50000 pll7_bypass 1 1 0 480000000 0 0 50000 pll7_usb_host 1 1 0 480000000 0 0 50000 usbphy2 1 1 0 480000000 0 0 50000 pll6 1 1 0 500000000 0 0 50000 pll6_bypass 1 1 0 500000000 0 0 50000 pll6_enet 2 2 0 500000000 0 0 50000 enet_ptp_ref 1 1 0 25000000 0 0 50000 enet_ptp 1 1 0 25000000 0 0 50000 enet2_ref 0 0 0 50000000 0 0 50000 enet_ref_125m 0 0 0 50000000 0 0 50000 enet_ref 2 2 0 50000000 0 0 50000 pll5 0 0 0 296600000 0 0 50000 pll5_bypass 0 0 0 296600000 0 0 50000 pll5_video 0 0 0 296600000 0 0 50000 pll5_post_div 0 0 0 74150000 0 0 50000 pll5_video_div 0 0 0 74150000 0 0 50000 pll4 0 0 0 147456000 0 0 50000 pll4_bypass 0 0 0 147456000 0 0 50000 pll4_audio 0 0 0 147456000 0 0 50000 pll4_post_div 0 0 0 36864000 0 0 50000 pll4_audio_div 0 0 0 36864000 0 0 50000 pll3 1 1 0 480000000 0 0 50000 pll3_bypass 1 1 0 480000000 0 0 50000 pll3_usb_otg 2 2 0 480000000 0 0 50000 spdif_sel 0 0 0 480000000 0 0 50000 spdif_pred 0 0 0 240000000 0 0 50000 spdif_podf 0 0 0 30000000 0 0 50000 spdif 0 0 0 30000000 0 0 50000 esai_sel 0 0 0 480000000 0 0 50000 esai_pred 0 0 0 240000000 0 0 50000 esai_podf 0 0 0 30000000 0 0 50000 esai_extal 0 0 0 30000000 0 0 50000 qspi1_sel 0 0 0 480000000 0 0 50000 qspi1_podf 0 0 0 240000000 0 0 50000 qspi1 0 0 0 240000000 0 0 50000 ldb_di1_div_7 0 0 0 68571428 0 0 50000 ldb_di1 0 0 0 68571428 0 0 50000 ldb_di1_div_3_5 0 0 0 137142857 0 0 50000 periph2_clk2_sel 0 0 0 480000000 0 0 50000 periph2_clk2 0 0 0 480000000 0 0 50000 pll3_60m 0 0 0 60000000 0 0 50000 can_sel 0 0 0 60000000 0 0 50000 can_podf 0 0 0 30000000 0 0 50000 can2_serial 0 0 0 30000000 0 0 50000 can1_serial 0 0 0 30000000 0 0 50000 ecspi_sel 0 0 0 60000000 0 0 50000 ecspi_podf 0 0 0 60000000 0 0 50000 ecspi4 0 0 0 60000000 0 0 50000 ecspi3 0 0 0 60000000 0 0 50000 ecspi2 0 0 0 60000000 0 0 50000 ecspi1 0 0 0 60000000 0 0 50000 pll3_80m 1 1 0 80000000 0 0 50000 uart_sel 1 1 0 80000000 0 0 50000 uart_podf 1 1 0 80000000 0 0 50000 uart8_serial 0 0 0 80000000 0 0 50000 uart7_serial 0 0 0 80000000 0 0 50000 uart1_serial 1 2 0 80000000 0 0 50000 uart6_serial 0 0 0 80000000 0 0 50000 uart5_serial 0 0 0 80000000 0 0 50000 uart4_serial 0 0 0 80000000 0 0 50000 uart3_serial 0 0 0 80000000 0 0 50000 uart2_serial 0 0 0 80000000 0 0 50000 pll3_pfd3_454m 0 0 0 454736842 0 0 50000 pll3_pfd2_508m 0 0 0 508235294 0 0 50000 epdc_pre_sel 0 0 0 508235294 0 0 50000 epdc_podf 0 0 0 254117647 0 0 50000 epdc_pix 0 0 0 254117647 0 0 50000 epdc_sel 0 0 0 254117647 0 0 50000 sai1_sel 0 0 0 508235294 0 0 50000 sai1_pred 0 0 0 127058824 0 0 50000 sai1_podf 0 0 0 63529412 0 0 50000 sai1 0 0 0 63529412 0 0 50000 sai2_sel 0 0 0 508235294 0 0 50000 sai2_pred 0 0 0 127058824 0 0 50000 sai2_podf 0 0 0 63529412 0 0 50000 sai2 0 0 0 63529412 0 0 50000 sai3_sel 0 0 0 508235294 0 0 50000 sai3_pred 0 0 0 127058824 0 0 50000 sai3_podf 0 0 0 63529412 0 0 50000 sai3 0 0 0 63529412 0 0 50000 pll3_pfd1_540m 0 0 0 540000000 0 0 50000 lcdif_pre_sel 0 0 0 540000000 0 0 50000 lcdif_pred 0 0 0 270000000 0 0 50000 lcdif_podf 0 0 0 135000000 0 0 50000 lcdif_pix 0 0 0 135000000 0 0 50000 iomuxc 0 0 0 135000000 0 0 50000 lcdif_sel 0 0 0 135000000 0 0 50000 pll3_pfd0_720m 0 0 0 720000000 0 0 50000 usbphy1 1 1 0 480000000 0 0 50000 pll2 1 1 0 528000000 0 0 50000 pll2_bypass 1 1 0 528000000 0 0 50000 pll2_bus 2 2 0 528000000 0 0 50000 ca7_secondary_sel 0 0 0 528000000 0 0 50000 step 0 0 0 528000000 0 0 50000 periph_pre 1 1 0 528000000 0 0 50000 periph 3 3 0 528000000 0 0 50000 ahb 7 7 0 132000000 0 0 50000 sdma 0 0 0 132000000 0 0 50000 rom 1 1 0 132000000 0 0 50000 esai_mem 0 0 0 132000000 0 0 50000 esai_ipg 0 0 0 132000000 0 0 50000 aips_tz3 1 1 0 132000000 0 0 50000 enet_ahb 2 2 0 132000000 0 0 50000 dcp 0 0 0 132000000 0 0 50000 asrc_mem 0 0 0 132000000 0 0 50000 asrc_ipg 0 0 0 132000000 0 0 50000 aips_tz2 1 1 0 132000000 0 0 50000 aips_tz1 1 1 0 132000000 0 0 50000 ipg 10 10 0 66000000 0 0 50000 wdog3 0 0 0 66000000 0 0 50000 uart8_ipg 0 0 0 66000000 0 0 50000 usboh3 2 2 0 66000000 0 0 50000 sai2_ipg 0 0 0 66000000 0 0 50000 sai1_ipg 0 0 0 66000000 0 0 50000 uart7_ipg 0 0 0 66000000 0 0 50000 uart1_ipg 1 2 0 66000000 0 0 50000 sai3_ipg 0 0 0 66000000 0 0 50000 spdif_gclk 0 0 0 66000000 0 0 50000 spba 0 0 0 66000000 0 0 50000 wdog2 0 0 0 66000000 0 0 50000 kpp 0 0 0 66000000 0 0 50000 mmdc_p1_ipg 0 0 0 66000000 0 0 50000 mmdc_p0_ipg 2 2 0 66000000 0 0 50000 wdog1 1 1 0 66000000 0 0 50000 gpio4 1 1 0 66000000 0 0 50000 uart6_ipg 0 0 0 66000000 0 0 50000 uart5_ipg 0 0 0 66000000 0 0 50000 gpio3 1 1 0 66000000 0 0 50000 ocotp 0 0 0 66000000 0 0 50000 gpio5 1 1 0 66000000 0 0 50000 gpio1 1 1 0 66000000 0 0 50000 uart4_ipg 0 0 0 66000000 0 0 50000 adc1 0 0 0 66000000 0 0 50000 uart3_ipg 0 0 0 66000000 0 0 50000 adc2 0 0 0 66000000 0 0 50000 gpio2 1 1 0 66000000 0 0 50000 uart2_ipg 0 0 0 66000000 0 0 50000 can2_ipg 0 0 0 66000000 0 0 50000 can1_ipg 0 0 0 66000000 0 0 50000 enet 2 2 0 66000000 0 0 50000 axi_sel 1 1 0 528000000 0 0 50000 axi_podf 2 2 0 264000000 0 0 50000 axi 1 1 0 264000000 0 0 50000 eim_slow_sel 0 0 0 264000000 0 0 50000 eim_slow_podf 0 0 0 132000000 0 0 50000 eim 0 0 0 132000000 0 0 50000 lcdif_apb 0 0 0 264000000 0 0 50000 pxp 0 0 0 264000000 0 0 50000 epdc_aclk 0 0 0 264000000 0 0 50000 pll2_pfd3_594m 0 0 0 594000000 0 0 50000 ldb_di0_sel 0 0 0 594000000 0 0 50000 ldb_di0_div_7 0 0 0 84857142 0 0 50000 ldb_di0 0 0 0 84857142 0 0 50000 ldb_di0_div_3_5 0 0 0 169714285 0 0 50000 pll2_pfd2_396m 2 2 0 396000000 0 0 50000 enfc_sel 0 0 0 396000000 0 0 50000 enfc_pred 0 0 0 99000000 0 0 50000 enfc_podf 0 0 0 99000000 0 0 50000 gpmi_io 0 0 0 99000000 0 0 50000 usdhc1_sel 0 0 0 396000000 0 0 50000 usdhc1_podf 0 0 0 198000000 0 0 50000 usdhc1 0 0 0 198000000 0 0 50000 usdhc2_sel 0 0 0 396000000 0 0 50000 usdhc2_podf 0 0 0 198000000 0 0 50000 usdhc2 0 0 0 198000000 0 0 50000 bch_sel 1 1 0 396000000 0 0 50000 bch_podf 1 1 0 99000000 0 0 50000 gpmi_apb 0 0 0 99000000 0 0 50000 gpmi_bch_apb 0 0 0 99000000 0 0 50000 per_bch 0 0 0 99000000 0 0 50000 apbh_dma 1 1 0 99000000 0 0 50000 gpmi_sel 0 0 0 396000000 0 0 50000 gpmi_podf 0 0 0 99000000 0 0 50000 gpmi_bch 0 0 0 99000000 0 0 50000 periph2_pre 1 1 0 396000000 0 0 50000 periph2 2 2 0 396000000 0 0 50000 mmdc_podf 2 2 0 396000000 0 0 50000 mmdc_p0_fast 1 1 0 396000000 0 0 50000 axi_alt_sel 0 0 0 396000000 0 0 50000 pll2_198m 0 0 0 198000000 0 0 50000 pll2_pfd1_594m 0 0 0 594000000 0 0 50000 pll2_pfd0_352m 0 0 0 352000000 0 0 50000 pll1 1 1 0 900000000 0 0 50000 pll1_bypass 1 1 0 900000000 0 0 50000 pll1_sys 1 1 0 900000000 0 0 50000 pll1_sw 1 1 0 900000000 0 0 50000 arm 1 1 0 900000000 0 0 50000 pll7_bypass_src 0 0 0 24000000 0 0 50000 pll6_bypass_src 0 0 0 24000000 0 0 50000 pll5_bypass_src 0 0 0 24000000 0 0 50000 pll4_bypass_src 0 0 0 24000000 0 0 50000 pll3_bypass_src 0 0 0 24000000 0 0 50000 pll2_bypass_src 0 0 0 24000000 0 0 50000 pll1_bypass_src 0 0 0 24000000 0 0 50000
Quoted 4 lines
ckil 0 0 0 32768 0 0 50000
Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2 -4
@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ; -if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate);/* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); } static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Boris,
Quoted 489 lines · Boris Brezillon
Quoted 470 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Hi Miquel, Boris,
Quoted 21 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 11 lines · Greg Ungerer
Quoted 6 lines · Greg Ungerer
Quoted 4 lines · Miquel Raynal
Quoted 3 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Quoted 1 line
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Not sure if this is a useful data point... But I modified that
nand_init_data_interface()loop to start checking from data mode 4. So now on every boot it defaults to mode 4. That has been running most of the day, up to 900 boot cycles now, no failures.Ok so after having chatted quite a bit with Boris, it is very likely that, for these chips, the timings in mode 5 are too tight. It could fail the
GET_FEATURESonce in mode 5. Can you please dump every single intermediate value ingpmi_nfc_compute_timings()(period,*_cycles, use of half pêriods, tRP, sample delay, etc) as well as the content of/sys/kernel/debug/clk/clk_summary(you'll need debugfs support enabled and mounted).Quoted 1 line
Also, can you be sure that the NAND chip is powered with 3.3V?
Yes, 3.3V NAND chip.
Using the attached patch I get the following trace:
...
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426):gpmi_nfc_compute_timings()sdr->tBERS_max=65535000000 sdr->tCCS_min=500000000 sdr->tPROG_max=65535000000 sdr->tR_max=200000000000000 sdr->tALH_min=20000 sdr->tADL_min=400000 sdr->tALS_min=50000 sdr->tAR_min=25000 sdr->tCEA_max=100000 sdr->tCEH_min=20000 sdr->tCH_min=20000 sdr->tCHZ_max=100000 sdr->tCLH_min=20000 sdr->tCLR_min=20000 sdr->tCLS_min=50000 sdr->tCOH_min=0 sdr->tCS_min=70000 sdr->tDH_min=20000 sdr->tDS_min=40000 sdr->tFEAT_max=1000000 sdr->tIR_min=10000 sdr->tITC_max=1000000 sdr->tRC_min=100000 sdr->tREA_max=40000 sdr->tREH_min=30000 sdr->tRHOH_min=0 sdr->tRHW_min=200000 sdr->tRHZ_max=200000 sdr->tRLOH_min=0 sdr->tRP_min=50000 sdr->tRR_min=40000 sdr->tRST_max=250000000000 sdr->tWB_max=200000 sdr->tWC_min=100000 sdr->tWH_min=30000 sdr->tWHR_min=120000 sdr->tWP_min=50000 sdr->tWW_min=100000 hw->clk_rate=22000000 wrn_dly_sel=0 period_ps=45454 addr_setup_cycles=2 data_setup_cycles=1 data_hold_cycles=1 busy_timeout_cycles=31302 hw->timing0=0x00020101 hw->timing1=0x60000000 dll_threshold_ps=12000 use_half_period=1 reference_period_ps=22727 tRP_ps=45454 sample_delay_ps=4294955664 sample_delay_factor=0 hw->ctrl1n=0x00000000 hw->ctrl1n=0x00000000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547): gpmi_nfc_apply_timings() hw>clk_rate=22000000 clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=22000000random: fast init done
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426):gpmi_nfc_compute_timings()sdr->tBERS_max=3000000000 sdr->tCCS_min=100000 sdr->tPROG_max=600000000 sdr->tR_max=25000000 sdr->tALH_min=20000 sdr->tADL_min=400000 sdr->tALS_min=50000 sdr->tAR_min=25000 sdr->tCEA_max=100000 sdr->tCEH_min=20000 sdr->tCH_min=20000 sdr->tCHZ_max=100000 sdr->tCLH_min=20000 sdr->tCLR_min=20000 sdr->tCLS_min=50000 sdr->tCOH_min=0 sdr->tCS_min=70000 sdr->tDH_min=20000 sdr->tDS_min=40000 sdr->tFEAT_max=1000000 sdr->tIR_min=10000 sdr->tITC_max=1000000 sdr->tRC_min=100000 sdr->tREA_max=40000 sdr->tREH_min=30000 sdr->tRHOH_min=0 sdr->tRHW_min=200000 sdr->tRHZ_max=200000 sdr->tRLOH_min=0 sdr->tRP_min=50000 sdr->tRR_min=40000 sdr->tRST_max=250000000000 sdr->tWB_max=200000 sdr->tWC_min=100000 sdr->tWH_min=30000 sdr->tWHR_min=120000 sdr->tWP_min=50000 sdr->tWW_min=100000 hw->clk_rate=22000000 wrn_dly_sel=0 period_ps=45454 addr_setup_cycles=2 data_setup_cycles=1 data_hold_cycles=1 busy_timeout_cycles=555 hw->timing0=0x00020101 hw->timing1=0xb0000000 dll_threshold_ps=12000 use_half_period=1 reference_period_ps=22727 tRP_ps=45454 sample_delay_ps=4294955664 sample_delay_factor=0 hw->ctrl1n=0x00000000 hw->ctrl1n=0x00000000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547): gpmi_nfc_apply_timings() hw>clk_rate=22000000 clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=22000000gpmi-nand 1806000.gpmi-nand: use legacy bch geometry drivers/mtd/nand/raw/nand_base.c(913): checking mode=5 drivers/mtd/nand/raw/nand_base.c(927): BREAKING AT mode=5 drivers/mtd/nand/raw/nand_base.c(932): chip->onfi_timing_mode_default=5 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426):
gpmi_nfc_compute_timings()sdr->tBERS_max=3000000000 sdr->tCCS_min=100000 sdr->tPROG_max=600000000 sdr->tR_max=25000000 sdr->tALH_min=5000 sdr->tADL_min=400000 sdr->tALS_min=10000 sdr->tAR_min=10000 sdr->tCEA_max=25000 sdr->tCEH_min=20000 sdr->tCH_min=5000 sdr->tCHZ_max=30000 sdr->tCLH_min=5000 sdr->tCLR_min=10000 sdr->tCLS_min=10000 sdr->tCOH_min=15000 sdr->tCS_min=15000 sdr->tDH_min=5000 sdr->tDS_min=7000 sdr->tFEAT_max=1000000 sdr->tIR_min=0 sdr->tITC_max=1000000 sdr->tRC_min=20000 sdr->tREA_max=16000 sdr->tREH_min=7000 sdr->tRHOH_min=15000 sdr->tRHW_min=100000 sdr->tRHZ_max=100000 sdr->tRLOH_min=5000 sdr->tRP_min=10000 sdr->tRR_min=20000 sdr->tRST_max=500000000 sdr->tWB_max=100000 sdr->tWC_min=20000 sdr->tWH_min=7000 sdr->tWHR_min=80000 sdr->tWP_min=10000 sdr->tWW_min=100000 hw->clk_rate=100000000 wrn_dly_sel=3 period_ps=10000 addr_setup_cycles=1 data_setup_cycles=1 data_hold_cycles=1 busy_timeout_cycles=2510 hw->timing0=0x00010101 hw->timing1=0xe0000000 dll_threshold_ps=12000 use_half_period=0 reference_period_ps=10000 tRP_ps=10000 sample_delay_ps=80000 sample_delay_factor=8 hw->ctrl1n=0x00c00000 hw->ctrl1n=0x00c28000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547): gpmi_nfc_apply_timings() hw>clk_rate=100000000 clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=99000000Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...And "cat
/sys/kernel/debug/clk/clk_summary" gives:enable prepare protect duty
clock count count count rate accuracy phase cycle
---------------------------------------------------------------------------------------------dummy 2 2 0 0 0 0 50000 cko2_sel 0 0 0 0 0 0 50000 cko2_podf 0 0 0 0 0 0 50000 cko2 0 0 0 0 0 0 50000 cko1_sel 0 0 0 0 0 0 50000 cko1_podf 0 0 0 0 0 0 50000 cko1 0 0 0 0 0 0 50000 cko 0 0 0 0 0 0 50000 usbphy2_gate 1 1 0 0 0 0 50000 usbphy1_gate 1 1 0 0 0 0 50000 ipp_di1 0 0 0 0 0 0 50000 ipp_di0 0 0 0 0 0 0 50000 osc 6 6 0 24000000 0 0 50000 perclk_sel 1 1 0 24000000 0 0 50000 perclk 3 3 0 24000000 0 0 50000 pwm7 0 0 0 24000000 0 0 50000 pwm6 0 0 0 24000000 0 0 50000 pwm5 0 0 0 24000000 0 0 50000 i2c4 0 0 0 24000000 0 0 50000 pwm8 0 0 0 24000000 0 0 50000 pwm4 0 0 0 24000000 0 0 50000 pwm3 0 0 0 24000000 0 0 50000 pwm2 0 0 0 24000000 0 0 50000 pwm1 0 0 0 24000000 0 0 50000 i2c3 0 0 0 24000000 0 0 50000 i2c2 1 1 0 24000000 0 0 50000 i2c1 0 0 0 24000000 0 0 50000 gpt1_serial 1 1 0 24000000 0 0 50000 gpt1_bus 1 1 0 24000000 0 0 50000 epit2 0 0 0 24000000 0 0 50000 epit1 0 0 0 24000000 0 0 50000 gpt2_serial 0 0 0 24000000 0 0 50000 gpt2_bus 0 0 0 24000000 0 0 50000 periph_clk2_sel 0 0 0 24000000 0 0 50000 periph_clk2 0 0 0 24000000 0 0 50000 gpt_3m 0 0 0 3000000 0 0 50000 csi_sel 0 0 0 24000000 0 0 50000 csi_podf 0 0 0 24000000 0 0 50000 csi 0 0 0 24000000 0 0 50000 pll7 1 1 0 480000000 0 0 50000 pll7_bypass 1 1 0 480000000 0 0 50000 pll7_usb_host 1 1 0 480000000 0 0 50000 usbphy2 1 1 0 480000000 0 0 50000 pll6 1 1 0 500000000 0 0 50000 pll6_bypass 1 1 0 500000000 0 0 50000 pll6_enet 2 2 0 500000000 0 0 50000 enet_ptp_ref 1 1 0 25000000 0 0 50000 enet_ptp 1 1 0 25000000 0 0 50000 enet2_ref 0 0 0 50000000 0 0 50000 enet_ref_125m 0 0 0 50000000 0 0 50000 enet_ref 2 2 0 50000000 0 0 50000 pll5 0 0 0 296600000 0 0 50000 pll5_bypass 0 0 0 296600000 0 0 50000 pll5_video 0 0 0 296600000 0 0 50000 pll5_post_div 0 0 0 74150000 0 0 50000 pll5_video_div 0 0 0 74150000 0 0 50000 pll4 0 0 0 147456000 0 0 50000 pll4_bypass 0 0 0 147456000 0 0 50000 pll4_audio 0 0 0 147456000 0 0 50000 pll4_post_div 0 0 0 36864000 0 0 50000 pll4_audio_div 0 0 0 36864000 0 0 50000 pll3 1 1 0 480000000 0 0 50000 pll3_bypass 1 1 0 480000000 0 0 50000 pll3_usb_otg 2 2 0 480000000 0 0 50000 spdif_sel 0 0 0 480000000 0 0 50000 spdif_pred 0 0 0 240000000 0 0 50000 spdif_podf 0 0 0 30000000 0 0 50000 spdif 0 0 0 30000000 0 0 50000 esai_sel 0 0 0 480000000 0 0 50000 esai_pred 0 0 0 240000000 0 0 50000 esai_podf 0 0 0 30000000 0 0 50000 esai_extal 0 0 0 30000000 0 0 50000 qspi1_sel 0 0 0 480000000 0 0 50000 qspi1_podf 0 0 0 240000000 0 0 50000 qspi1 0 0 0 240000000 0 0 50000 ldb_di1_div_7 0 0 0 68571428 0 0 50000 ldb_di1 0 0 0 68571428 0 0 50000 ldb_di1_div_3_5 0 0 0 137142857 0 0 50000 periph2_clk2_sel 0 0 0 480000000 0 0 50000 periph2_clk2 0 0 0 480000000 0 0 50000 pll3_60m 0 0 0 60000000 0 0 50000 can_sel 0 0 0 60000000 0 0 50000 can_podf 0 0 0 30000000 0 0 50000 can2_serial 0 0 0 30000000 0 0 50000 can1_serial 0 0 0 30000000 0 0 50000 ecspi_sel 0 0 0 60000000 0 0 50000 ecspi_podf 0 0 0 60000000 0 0 50000 ecspi4 0 0 0 60000000 0 0 50000 ecspi3 0 0 0 60000000 0 0 50000 ecspi2 0 0 0 60000000 0 0 50000 ecspi1 0 0 0 60000000 0 0 50000 pll3_80m 1 1 0 80000000 0 0 50000 uart_sel 1 1 0 80000000 0 0 50000 uart_podf 1 1 0 80000000 0 0 50000 uart8_serial 0 0 0 80000000 0 0 50000 uart7_serial 0 0 0 80000000 0 0 50000 uart1_serial 1 2 0 80000000 0 0 50000 uart6_serial 0 0 0 80000000 0 0 50000 uart5_serial 0 0 0 80000000 0 0 50000 uart4_serial 0 0 0 80000000 0 0 50000 uart3_serial 0 0 0 80000000 0 0 50000 uart2_serial 0 0 0 80000000 0 0 50000 pll3_pfd3_454m 0 0 0 454736842 0 0 50000 pll3_pfd2_508m 0 0 0 508235294 0 0 50000 epdc_pre_sel 0 0 0 508235294 0 0 50000 epdc_podf 0 0 0 254117647 0 0 50000 epdc_pix 0 0 0 254117647 0 0 50000 epdc_sel 0 0 0 254117647 0 0 50000 sai1_sel 0 0 0 508235294 0 0 50000 sai1_pred 0 0 0 127058824 0 0 50000 sai1_podf 0 0 0 63529412 0 0 50000 sai1 0 0 0 63529412 0 0 50000 sai2_sel 0 0 0 508235294 0 0 50000 sai2_pred 0 0 0 127058824 0 0 50000 sai2_podf 0 0 0 63529412 0 0 50000 sai2 0 0 0 63529412 0 0 50000 sai3_sel 0 0 0 508235294 0 0 50000 sai3_pred 0 0 0 127058824 0 0 50000 sai3_podf 0 0 0 63529412 0 0 50000 sai3 0 0 0 63529412 0 0 50000 pll3_pfd1_540m 0 0 0 540000000 0 0 50000 lcdif_pre_sel 0 0 0 540000000 0 0 50000 lcdif_pred 0 0 0 270000000 0 0 50000 lcdif_podf 0 0 0 135000000 0 0 50000 lcdif_pix 0 0 0 135000000 0 0 50000 iomuxc 0 0 0 135000000 0 0 50000 lcdif_sel 0 0 0 135000000 0 0 50000 pll3_pfd0_720m 0 0 0 720000000 0 0 50000 usbphy1 1 1 0 480000000 0 0 50000 pll2 1 1 0 528000000 0 0 50000 pll2_bypass 1 1 0 528000000 0 0 50000 pll2_bus 2 2 0 528000000 0 0 50000 ca7_secondary_sel 0 0 0 528000000 0 0 50000 step 0 0 0 528000000 0 0 50000 periph_pre 1 1 0 528000000 0 0 50000 periph 3 3 0 528000000 0 0 50000 ahb 7 7 0 132000000 0 0 50000 sdma 0 0 0 132000000 0 0 50000 rom 1 1 0 132000000 0 0 50000 esai_mem 0 0 0 132000000 0 0 50000 esai_ipg 0 0 0 132000000 0 0 50000 aips_tz3 1 1 0 132000000 0 0 50000 enet_ahb 2 2 0 132000000 0 0 50000 dcp 0 0 0 132000000 0 0 50000 asrc_mem 0 0 0 132000000 0 0 50000 asrc_ipg 0 0 0 132000000 0 0 50000 aips_tz2 1 1 0 132000000 0 0 50000 aips_tz1 1 1 0 132000000 0 0 50000 ipg 10 10 0 66000000 0 0 50000 wdog3 0 0 0 66000000 0 0 50000 uart8_ipg 0 0 0 66000000 0 0 50000 usboh3 2 2 0 66000000 0 0 50000 sai2_ipg 0 0 0 66000000 0 0 50000 sai1_ipg 0 0 0 66000000 0 0 50000 uart7_ipg 0 0 0 66000000 0 0 50000 uart1_ipg 1 2 0 66000000 0 0 50000 sai3_ipg 0 0 0 66000000 0 0 50000 spdif_gclk 0 0 0 66000000 0 0 50000 spba 0 0 0 66000000 0 0 50000 wdog2 0 0 0 66000000 0 0 50000 kpp 0 0 0 66000000 0 0 50000 mmdc_p1_ipg 0 0 0 66000000 0 0 50000 mmdc_p0_ipg 2 2 0 66000000 0 0 50000 wdog1 1 1 0 66000000 0 0 50000 gpio4 1 1 0 66000000 0 0 50000 uart6_ipg 0 0 0 66000000 0 0 50000 uart5_ipg 0 0 0 66000000 0 0 50000 gpio3 1 1 0 66000000 0 0 50000 ocotp 0 0 0 66000000 0 0 50000 gpio5 1 1 0 66000000 0 0 50000 gpio1 1 1 0 66000000 0 0 50000 uart4_ipg 0 0 0 66000000 0 0 50000 adc1 0 0 0 66000000 0 0 50000 uart3_ipg 0 0 0 66000000 0 0 50000 adc2 0 0 0 66000000 0 0 50000 gpio2 1 1 0 66000000 0 0 50000 uart2_ipg 0 0 0 66000000 0 0 50000 can2_ipg 0 0 0 66000000 0 0 50000 can1_ipg 0 0 0 66000000 0 0 50000 enet 2 2 0 66000000 0 0 50000 axi_sel 1 1 0 528000000 0 0 50000 axi_podf 2 2 0 264000000 0 0 50000 axi 1 1 0 264000000 0 0 50000 eim_slow_sel 0 0 0 264000000 0 0 50000 eim_slow_podf 0 0 0 132000000 0 0 50000 eim 0 0 0 132000000 0 0 50000 lcdif_apb 0 0 0 264000000 0 0 50000 pxp 0 0 0 264000000 0 0 50000 epdc_aclk 0 0 0 264000000 0 0 50000 pll2_pfd3_594m 0 0 0 594000000 0 0 50000 ldb_di0_sel 0 0 0 594000000 0 0 50000 ldb_di0_div_7 0 0 0 84857142 0 0 50000 ldb_di0 0 0 0 84857142 0 0 50000 ldb_di0_div_3_5 0 0 0 169714285 0 0 50000 pll2_pfd2_396m 2 2 0 396000000 0 0 50000 enfc_sel 0 0 0 396000000 0 0 50000 enfc_pred 0 0 0 99000000 0 0 50000 enfc_podf 0 0 0 99000000 0 0 50000 gpmi_io 0 0 0 99000000 0 0 50000 usdhc1_sel 0 0 0 396000000 0 0 50000 usdhc1_podf 0 0 0 198000000 0 0 50000 usdhc1 0 0 0 198000000 0 0 50000 usdhc2_sel 0 0 0 396000000 0 0 50000 usdhc2_podf 0 0 0 198000000 0 0 50000 usdhc2 0 0 0 198000000 0 0 50000 bch_sel 1 1 0 396000000 0 0 50000 bch_podf 1 1 0 99000000 0 0 50000 gpmi_apb 0 0 0 99000000 0 0 50000 gpmi_bch_apb 0 0 0 99000000 0 0 50000 per_bch 0 0 0 99000000 0 0 50000 apbh_dma 1 1 0 99000000 0 0 50000 gpmi_sel 0 0 0 396000000 0 0 50000 gpmi_podf 0 0 0 99000000 0 0 50000 gpmi_bch 0 0 0 99000000 0 0 50000 periph2_pre 1 1 0 396000000 0 0 50000 periph2 2 2 0 396000000 0 0 50000 mmdc_podf 2 2 0 396000000 0 0 50000 mmdc_p0_fast 1 1 0 396000000 0 0 50000 axi_alt_sel 0 0 0 396000000 0 0 50000 pll2_198m 0 0 0 198000000 0 0 50000 pll2_pfd1_594m 0 0 0 594000000 0 0 50000 pll2_pfd0_352m 0 0 0 352000000 0 0 50000 pll1 1 1 0 900000000 0 0 50000 pll1_bypass 1 1 0 900000000 0 0 50000 pll1_sys 1 1 0 900000000 0 0 50000 pll1_sw 1 1 0 900000000 0 0 50000 arm 1 1 0 900000000 0 0 50000 pll7_bypass_src 0 0 0 24000000 0 0 50000 pll6_bypass_src 0 0 0 24000000 0 0 50000 pll5_bypass_src 0 0 0 24000000 0 0 50000 pll4_bypass_src 0 0 0 24000000 0 0 50000 pll3_bypass_src 0 0 0 24000000 0 0 50000 pll2_bypass_src 0 0 0 24000000 0 0 50000 pll1_bypass_src 0 0 0 24000000 0 0 50000Quoted 4 lines
ckil 0 0 0 32768 0 0 50000
Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-1@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ;
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 730
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-3-if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate);/* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); } static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,
Running a boot test with this now. Has run for a couple of hours, but I want to give it a really good run over the weekend. Will report results on Monday.
Thanks
Greg
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Boris,
Quoted 489 lines · Boris Brezillon
Quoted 470 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Hi Miquel, Boris,
Quoted 21 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 11 lines · Greg Ungerer
Quoted 6 lines · Greg Ungerer
Quoted 4 lines · Miquel Raynal
Quoted 3 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Quoted 1 line
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Not sure if this is a useful data point... But I modified that
nand_init_data_interface()loop to start checking from data mode 4. So now on every boot it defaults to mode 4. That has been running most of the day, up to 900 boot cycles now, no failures.Ok so after having chatted quite a bit with Boris, it is very likely that, for these chips, the timings in mode 5 are too tight. It could fail the
GET_FEATURESonce in mode 5. Can you please dump every single intermediate value ingpmi_nfc_compute_timings()(period,*_cycles, use of half pêriods, tRP, sample delay, etc) as well as the content of/sys/kernel/debug/clk/clk_summary(you'll need debugfs support enabled and mounted).Quoted 1 line
Also, can you be sure that the NAND chip is powered with 3.3V?
Yes, 3.3V NAND chip.
Using the attached patch I get the following trace:
...
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426):gpmi_nfc_compute_timings()sdr->tBERS_max=65535000000 sdr->tCCS_min=500000000 sdr->tPROG_max=65535000000 sdr->tR_max=200000000000000 sdr->tALH_min=20000 sdr->tADL_min=400000 sdr->tALS_min=50000 sdr->tAR_min=25000 sdr->tCEA_max=100000 sdr->tCEH_min=20000 sdr->tCH_min=20000 sdr->tCHZ_max=100000 sdr->tCLH_min=20000 sdr->tCLR_min=20000 sdr->tCLS_min=50000 sdr->tCOH_min=0 sdr->tCS_min=70000 sdr->tDH_min=20000 sdr->tDS_min=40000 sdr->tFEAT_max=1000000 sdr->tIR_min=10000 sdr->tITC_max=1000000 sdr->tRC_min=100000 sdr->tREA_max=40000 sdr->tREH_min=30000 sdr->tRHOH_min=0 sdr->tRHW_min=200000 sdr->tRHZ_max=200000 sdr->tRLOH_min=0 sdr->tRP_min=50000 sdr->tRR_min=40000 sdr->tRST_max=250000000000 sdr->tWB_max=200000 sdr->tWC_min=100000 sdr->tWH_min=30000 sdr->tWHR_min=120000 sdr->tWP_min=50000 sdr->tWW_min=100000 hw->clk_rate=22000000 wrn_dly_sel=0 period_ps=45454 addr_setup_cycles=2 data_setup_cycles=1 data_hold_cycles=1 busy_timeout_cycles=31302 hw->timing0=0x00020101 hw->timing1=0x60000000 dll_threshold_ps=12000 use_half_period=1 reference_period_ps=22727 tRP_ps=45454 sample_delay_ps=4294955664 sample_delay_factor=0 hw->ctrl1n=0x00000000 hw->ctrl1n=0x00000000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547): gpmi_nfc_apply_timings() hw>clk_rate=22000000 clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=22000000random: fast init done
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426):gpmi_nfc_compute_timings()sdr->tBERS_max=3000000000 sdr->tCCS_min=100000 sdr->tPROG_max=600000000 sdr->tR_max=25000000 sdr->tALH_min=20000 sdr->tADL_min=400000 sdr->tALS_min=50000 sdr->tAR_min=25000 sdr->tCEA_max=100000 sdr->tCEH_min=20000 sdr->tCH_min=20000 sdr->tCHZ_max=100000 sdr->tCLH_min=20000 sdr->tCLR_min=20000 sdr->tCLS_min=50000 sdr->tCOH_min=0 sdr->tCS_min=70000 sdr->tDH_min=20000 sdr->tDS_min=40000 sdr->tFEAT_max=1000000 sdr->tIR_min=10000 sdr->tITC_max=1000000 sdr->tRC_min=100000 sdr->tREA_max=40000 sdr->tREH_min=30000 sdr->tRHOH_min=0 sdr->tRHW_min=200000 sdr->tRHZ_max=200000 sdr->tRLOH_min=0 sdr->tRP_min=50000 sdr->tRR_min=40000 sdr->tRST_max=250000000000 sdr->tWB_max=200000 sdr->tWC_min=100000 sdr->tWH_min=30000 sdr->tWHR_min=120000 sdr->tWP_min=50000 sdr->tWW_min=100000 hw->clk_rate=22000000 wrn_dly_sel=0 period_ps=45454 addr_setup_cycles=2 data_setup_cycles=1 data_hold_cycles=1 busy_timeout_cycles=555 hw->timing0=0x00020101 hw->timing1=0xb0000000 dll_threshold_ps=12000 use_half_period=1 reference_period_ps=22727 tRP_ps=45454 sample_delay_ps=4294955664 sample_delay_factor=0 hw->ctrl1n=0x00000000 hw->ctrl1n=0x00000000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547): gpmi_nfc_apply_timings() hw>clk_rate=22000000 clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=22000000gpmi-nand 1806000.gpmi-nand: use legacy bch geometry drivers/mtd/nand/raw/nand_base.c(913): checking mode=5 drivers/mtd/nand/raw/nand_base.c(927): BREAKING AT mode=5 drivers/mtd/nand/raw/nand_base.c(932): chip->onfi_timing_mode_default=5 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426):
gpmi_nfc_compute_timings()sdr->tBERS_max=3000000000 sdr->tCCS_min=100000 sdr->tPROG_max=600000000 sdr->tR_max=25000000 sdr->tALH_min=5000 sdr->tADL_min=400000 sdr->tALS_min=10000 sdr->tAR_min=10000 sdr->tCEA_max=25000 sdr->tCEH_min=20000 sdr->tCH_min=5000 sdr->tCHZ_max=30000 sdr->tCLH_min=5000 sdr->tCLR_min=10000 sdr->tCLS_min=10000 sdr->tCOH_min=15000 sdr->tCS_min=15000 sdr->tDH_min=5000 sdr->tDS_min=7000 sdr->tFEAT_max=1000000 sdr->tIR_min=0 sdr->tITC_max=1000000 sdr->tRC_min=20000 sdr->tREA_max=16000 sdr->tREH_min=7000 sdr->tRHOH_min=15000 sdr->tRHW_min=100000 sdr->tRHZ_max=100000 sdr->tRLOH_min=5000 sdr->tRP_min=10000 sdr->tRR_min=20000 sdr->tRST_max=500000000 sdr->tWB_max=100000 sdr->tWC_min=20000 sdr->tWH_min=7000 sdr->tWHR_min=80000 sdr->tWP_min=10000 sdr->tWW_min=100000 hw->clk_rate=100000000 wrn_dly_sel=3 period_ps=10000 addr_setup_cycles=1 data_setup_cycles=1 data_hold_cycles=1 busy_timeout_cycles=2510 hw->timing0=0x00010101 hw->timing1=0xe0000000 dll_threshold_ps=12000 use_half_period=0 reference_period_ps=10000 tRP_ps=10000 sample_delay_ps=80000 sample_delay_factor=8 hw->ctrl1n=0x00c00000 hw->ctrl1n=0x00c28000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547): gpmi_nfc_apply_timings() hw>clk_rate=100000000 clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=99000000Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...And "cat
/sys/kernel/debug/clk/clk_summary" gives:enable prepare protect duty
clock count count count rate accuracy phase cycle
---------------------------------------------------------------------------------------------dummy 2 2 0 0 0 0 50000 cko2_sel 0 0 0 0 0 0 50000 cko2_podf 0 0 0 0 0 0 50000 cko2 0 0 0 0 0 0 50000 cko1_sel 0 0 0 0 0 0 50000 cko1_podf 0 0 0 0 0 0 50000 cko1 0 0 0 0 0 0 50000 cko 0 0 0 0 0 0 50000 usbphy2_gate 1 1 0 0 0 0 50000 usbphy1_gate 1 1 0 0 0 0 50000 ipp_di1 0 0 0 0 0 0 50000 ipp_di0 0 0 0 0 0 0 50000 osc 6 6 0 24000000 0 0 50000 perclk_sel 1 1 0 24000000 0 0 50000 perclk 3 3 0 24000000 0 0 50000 pwm7 0 0 0 24000000 0 0 50000 pwm6 0 0 0 24000000 0 0 50000 pwm5 0 0 0 24000000 0 0 50000 i2c4 0 0 0 24000000 0 0 50000 pwm8 0 0 0 24000000 0 0 50000 pwm4 0 0 0 24000000 0 0 50000 pwm3 0 0 0 24000000 0 0 50000 pwm2 0 0 0 24000000 0 0 50000 pwm1 0 0 0 24000000 0 0 50000 i2c3 0 0 0 24000000 0 0 50000 i2c2 1 1 0 24000000 0 0 50000 i2c1 0 0 0 24000000 0 0 50000 gpt1_serial 1 1 0 24000000 0 0 50000 gpt1_bus 1 1 0 24000000 0 0 50000 epit2 0 0 0 24000000 0 0 50000 epit1 0 0 0 24000000 0 0 50000 gpt2_serial 0 0 0 24000000 0 0 50000 gpt2_bus 0 0 0 24000000 0 0 50000 periph_clk2_sel 0 0 0 24000000 0 0 50000 periph_clk2 0 0 0 24000000 0 0 50000 gpt_3m 0 0 0 3000000 0 0 50000 csi_sel 0 0 0 24000000 0 0 50000 csi_podf 0 0 0 24000000 0 0 50000 csi 0 0 0 24000000 0 0 50000 pll7 1 1 0 480000000 0 0 50000 pll7_bypass 1 1 0 480000000 0 0 50000 pll7_usb_host 1 1 0 480000000 0 0 50000 usbphy2 1 1 0 480000000 0 0 50000 pll6 1 1 0 500000000 0 0 50000 pll6_bypass 1 1 0 500000000 0 0 50000 pll6_enet 2 2 0 500000000 0 0 50000 enet_ptp_ref 1 1 0 25000000 0 0 50000 enet_ptp 1 1 0 25000000 0 0 50000 enet2_ref 0 0 0 50000000 0 0 50000 enet_ref_125m 0 0 0 50000000 0 0 50000 enet_ref 2 2 0 50000000 0 0 50000 pll5 0 0 0 296600000 0 0 50000 pll5_bypass 0 0 0 296600000 0 0 50000 pll5_video 0 0 0 296600000 0 0 50000 pll5_post_div 0 0 0 74150000 0 0 50000 pll5_video_div 0 0 0 74150000 0 0 50000 pll4 0 0 0 147456000 0 0 50000 pll4_bypass 0 0 0 147456000 0 0 50000 pll4_audio 0 0 0 147456000 0 0 50000 pll4_post_div 0 0 0 36864000 0 0 50000 pll4_audio_div 0 0 0 36864000 0 0 50000 pll3 1 1 0 480000000 0 0 50000 pll3_bypass 1 1 0 480000000 0 0 50000 pll3_usb_otg 2 2 0 480000000 0 0 50000 spdif_sel 0 0 0 480000000 0 0 50000 spdif_pred 0 0 0 240000000 0 0 50000 spdif_podf 0 0 0 30000000 0 0 50000 spdif 0 0 0 30000000 0 0 50000 esai_sel 0 0 0 480000000 0 0 50000 esai_pred 0 0 0 240000000 0 0 50000 esai_podf 0 0 0 30000000 0 0 50000 esai_extal 0 0 0 30000000 0 0 50000 qspi1_sel 0 0 0 480000000 0 0 50000 qspi1_podf 0 0 0 240000000 0 0 50000 qspi1 0 0 0 240000000 0 0 50000 ldb_di1_div_7 0 0 0 68571428 0 0 50000 ldb_di1 0 0 0 68571428 0 0 50000 ldb_di1_div_3_5 0 0 0 137142857 0 0 50000 periph2_clk2_sel 0 0 0 480000000 0 0 50000 periph2_clk2 0 0 0 480000000 0 0 50000 pll3_60m 0 0 0 60000000 0 0 50000 can_sel 0 0 0 60000000 0 0 50000 can_podf 0 0 0 30000000 0 0 50000 can2_serial 0 0 0 30000000 0 0 50000 can1_serial 0 0 0 30000000 0 0 50000 ecspi_sel 0 0 0 60000000 0 0 50000 ecspi_podf 0 0 0 60000000 0 0 50000 ecspi4 0 0 0 60000000 0 0 50000 ecspi3 0 0 0 60000000 0 0 50000 ecspi2 0 0 0 60000000 0 0 50000 ecspi1 0 0 0 60000000 0 0 50000 pll3_80m 1 1 0 80000000 0 0 50000 uart_sel 1 1 0 80000000 0 0 50000 uart_podf 1 1 0 80000000 0 0 50000 uart8_serial 0 0 0 80000000 0 0 50000 uart7_serial 0 0 0 80000000 0 0 50000 uart1_serial 1 2 0 80000000 0 0 50000 uart6_serial 0 0 0 80000000 0 0 50000 uart5_serial 0 0 0 80000000 0 0 50000 uart4_serial 0 0 0 80000000 0 0 50000 uart3_serial 0 0 0 80000000 0 0 50000 uart2_serial 0 0 0 80000000 0 0 50000 pll3_pfd3_454m 0 0 0 454736842 0 0 50000 pll3_pfd2_508m 0 0 0 508235294 0 0 50000 epdc_pre_sel 0 0 0 508235294 0 0 50000 epdc_podf 0 0 0 254117647 0 0 50000 epdc_pix 0 0 0 254117647 0 0 50000 epdc_sel 0 0 0 254117647 0 0 50000 sai1_sel 0 0 0 508235294 0 0 50000 sai1_pred 0 0 0 127058824 0 0 50000 sai1_podf 0 0 0 63529412 0 0 50000 sai1 0 0 0 63529412 0 0 50000 sai2_sel 0 0 0 508235294 0 0 50000 sai2_pred 0 0 0 127058824 0 0 50000 sai2_podf 0 0 0 63529412 0 0 50000 sai2 0 0 0 63529412 0 0 50000 sai3_sel 0 0 0 508235294 0 0 50000 sai3_pred 0 0 0 127058824 0 0 50000 sai3_podf 0 0 0 63529412 0 0 50000 sai3 0 0 0 63529412 0 0 50000 pll3_pfd1_540m 0 0 0 540000000 0 0 50000 lcdif_pre_sel 0 0 0 540000000 0 0 50000 lcdif_pred 0 0 0 270000000 0 0 50000 lcdif_podf 0 0 0 135000000 0 0 50000 lcdif_pix 0 0 0 135000000 0 0 50000 iomuxc 0 0 0 135000000 0 0 50000 lcdif_sel 0 0 0 135000000 0 0 50000 pll3_pfd0_720m 0 0 0 720000000 0 0 50000 usbphy1 1 1 0 480000000 0 0 50000 pll2 1 1 0 528000000 0 0 50000 pll2_bypass 1 1 0 528000000 0 0 50000 pll2_bus 2 2 0 528000000 0 0 50000 ca7_secondary_sel 0 0 0 528000000 0 0 50000 step 0 0 0 528000000 0 0 50000 periph_pre 1 1 0 528000000 0 0 50000 periph 3 3 0 528000000 0 0 50000 ahb 7 7 0 132000000 0 0 50000 sdma 0 0 0 132000000 0 0 50000 rom 1 1 0 132000000 0 0 50000 esai_mem 0 0 0 132000000 0 0 50000 esai_ipg 0 0 0 132000000 0 0 50000 aips_tz3 1 1 0 132000000 0 0 50000 enet_ahb 2 2 0 132000000 0 0 50000 dcp 0 0 0 132000000 0 0 50000 asrc_mem 0 0 0 132000000 0 0 50000 asrc_ipg 0 0 0 132000000 0 0 50000 aips_tz2 1 1 0 132000000 0 0 50000 aips_tz1 1 1 0 132000000 0 0 50000 ipg 10 10 0 66000000 0 0 50000 wdog3 0 0 0 66000000 0 0 50000 uart8_ipg 0 0 0 66000000 0 0 50000 usboh3 2 2 0 66000000 0 0 50000 sai2_ipg 0 0 0 66000000 0 0 50000 sai1_ipg 0 0 0 66000000 0 0 50000 uart7_ipg 0 0 0 66000000 0 0 50000 uart1_ipg 1 2 0 66000000 0 0 50000 sai3_ipg 0 0 0 66000000 0 0 50000 spdif_gclk 0 0 0 66000000 0 0 50000 spba 0 0 0 66000000 0 0 50000 wdog2 0 0 0 66000000 0 0 50000 kpp 0 0 0 66000000 0 0 50000 mmdc_p1_ipg 0 0 0 66000000 0 0 50000 mmdc_p0_ipg 2 2 0 66000000 0 0 50000 wdog1 1 1 0 66000000 0 0 50000 gpio4 1 1 0 66000000 0 0 50000 uart6_ipg 0 0 0 66000000 0 0 50000 uart5_ipg 0 0 0 66000000 0 0 50000 gpio3 1 1 0 66000000 0 0 50000 ocotp 0 0 0 66000000 0 0 50000 gpio5 1 1 0 66000000 0 0 50000 gpio1 1 1 0 66000000 0 0 50000 uart4_ipg 0 0 0 66000000 0 0 50000 adc1 0 0 0 66000000 0 0 50000 uart3_ipg 0 0 0 66000000 0 0 50000 adc2 0 0 0 66000000 0 0 50000 gpio2 1 1 0 66000000 0 0 50000 uart2_ipg 0 0 0 66000000 0 0 50000 can2_ipg 0 0 0 66000000 0 0 50000 can1_ipg 0 0 0 66000000 0 0 50000 enet 2 2 0 66000000 0 0 50000 axi_sel 1 1 0 528000000 0 0 50000 axi_podf 2 2 0 264000000 0 0 50000 axi 1 1 0 264000000 0 0 50000 eim_slow_sel 0 0 0 264000000 0 0 50000 eim_slow_podf 0 0 0 132000000 0 0 50000 eim 0 0 0 132000000 0 0 50000 lcdif_apb 0 0 0 264000000 0 0 50000 pxp 0 0 0 264000000 0 0 50000 epdc_aclk 0 0 0 264000000 0 0 50000 pll2_pfd3_594m 0 0 0 594000000 0 0 50000 ldb_di0_sel 0 0 0 594000000 0 0 50000 ldb_di0_div_7 0 0 0 84857142 0 0 50000 ldb_di0 0 0 0 84857142 0 0 50000 ldb_di0_div_3_5 0 0 0 169714285 0 0 50000 pll2_pfd2_396m 2 2 0 396000000 0 0 50000 enfc_sel 0 0 0 396000000 0 0 50000 enfc_pred 0 0 0 99000000 0 0 50000 enfc_podf 0 0 0 99000000 0 0 50000 gpmi_io 0 0 0 99000000 0 0 50000 usdhc1_sel 0 0 0 396000000 0 0 50000 usdhc1_podf 0 0 0 198000000 0 0 50000 usdhc1 0 0 0 198000000 0 0 50000 usdhc2_sel 0 0 0 396000000 0 0 50000 usdhc2_podf 0 0 0 198000000 0 0 50000 usdhc2 0 0 0 198000000 0 0 50000 bch_sel 1 1 0 396000000 0 0 50000 bch_podf 1 1 0 99000000 0 0 50000 gpmi_apb 0 0 0 99000000 0 0 50000 gpmi_bch_apb 0 0 0 99000000 0 0 50000 per_bch 0 0 0 99000000 0 0 50000 apbh_dma 1 1 0 99000000 0 0 50000 gpmi_sel 0 0 0 396000000 0 0 50000 gpmi_podf 0 0 0 99000000 0 0 50000 gpmi_bch 0 0 0 99000000 0 0 50000 periph2_pre 1 1 0 396000000 0 0 50000 periph2 2 2 0 396000000 0 0 50000 mmdc_podf 2 2 0 396000000 0 0 50000 mmdc_p0_fast 1 1 0 396000000 0 0 50000 axi_alt_sel 0 0 0 396000000 0 0 50000 pll2_198m 0 0 0 198000000 0 0 50000 pll2_pfd1_594m 0 0 0 594000000 0 0 50000 pll2_pfd0_352m 0 0 0 352000000 0 0 50000 pll1 1 1 0 900000000 0 0 50000 pll1_bypass 1 1 0 900000000 0 0 50000 pll1_sys 1 1 0 900000000 0 0 50000 pll1_sw 1 1 0 900000000 0 0 50000 arm 1 1 0 900000000 0 0 50000 pll7_bypass_src 0 0 0 24000000 0 0 50000 pll6_bypass_src 0 0 0 24000000 0 0 50000 pll5_bypass_src 0 0 0 24000000 0 0 50000 pll4_bypass_src 0 0 0 24000000 0 0 50000 pll3_bypass_src 0 0 0 24000000 0 0 50000 pll2_bypass_src 0 0 0 24000000 0 0 50000 pll1_bypass_src 0 0 0 24000000 0 0 50000Quoted 4 lines
ckil 0 0 0 32768 0 0 50000
Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-1@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ;
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 730
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-3-if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate);/* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); } static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,
Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Note also that I had to hand merge the changes, since in 5.1.14 that gpmi_nfc_apply_timings() is in gpmi-lib.c. But it was trivial to do.
Regards
Greg
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 501 lines · On Fri, 2 Aug 2019 22:34:57 +1000 Greg Ungerer <[email protected]> wrote:
Hi Boris,
Quoted 498 lines · Boris Brezillon
Quoted 470 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Hi Miquel, Boris,
Quoted 21 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 11 lines · Greg Ungerer
Quoted 6 lines · Greg Ungerer
Quoted 4 lines · Miquel Raynal
Quoted 3 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Quoted 1 line
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Not sure if this is a useful data point... But I modified that
nand_init_data_interface()loop to start checking from data mode 4. So now on every boot it defaults to mode 4. That has been running most of the day, up to 900 boot cycles now, no failures.Ok so after having chatted quite a bit with Boris, it is very likely that, for these chips, the timings in mode 5 are too tight. It could fail the
GET_FEATURESonce in mode 5. Can you please dump every single intermediate value ingpmi_nfc_compute_timings()(period,*_cycles, use of half pêriods, tRP, sample delay, etc) as well as the content of/sys/kernel/debug/clk/clk_summary(you'll need debugfs support enabled and mounted).Quoted 1 line
Also, can you be sure that the NAND chip is powered with 3.3V?
Yes, 3.3V NAND chip.
Using the attached patch I get the following trace:
...
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426):gpmi_nfc_compute_timings()sdr->tBERS_max=65535000000 sdr->tCCS_min=500000000 sdr->tPROG_max=65535000000 sdr->tR_max=200000000000000 sdr->tALH_min=20000 sdr->tADL_min=400000 sdr->tALS_min=50000 sdr->tAR_min=25000 sdr->tCEA_max=100000 sdr->tCEH_min=20000 sdr->tCH_min=20000 sdr->tCHZ_max=100000 sdr->tCLH_min=20000 sdr->tCLR_min=20000 sdr->tCLS_min=50000 sdr->tCOH_min=0 sdr->tCS_min=70000 sdr->tDH_min=20000 sdr->tDS_min=40000 sdr->tFEAT_max=1000000 sdr->tIR_min=10000 sdr->tITC_max=1000000 sdr->tRC_min=100000 sdr->tREA_max=40000 sdr->tREH_min=30000 sdr->tRHOH_min=0 sdr->tRHW_min=200000 sdr->tRHZ_max=200000 sdr->tRLOH_min=0 sdr->tRP_min=50000 sdr->tRR_min=40000 sdr->tRST_max=250000000000 sdr->tWB_max=200000 sdr->tWC_min=100000 sdr->tWH_min=30000 sdr->tWHR_min=120000 sdr->tWP_min=50000 sdr->tWW_min=100000 hw->clk_rate=22000000 wrn_dly_sel=0 period_ps=45454 addr_setup_cycles=2 data_setup_cycles=1 data_hold_cycles=1 busy_timeout_cycles=31302 hw->timing0=0x00020101 hw->timing1=0x60000000 dll_threshold_ps=12000 use_half_period=1 reference_period_ps=22727 tRP_ps=45454 sample_delay_ps=4294955664 sample_delay_factor=0 hw->ctrl1n=0x00000000 hw->ctrl1n=0x00000000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547): gpmi_nfc_apply_timings() hw>clk_rate=22000000 clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=22000000random: fast init done
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426):gpmi_nfc_compute_timings()sdr->tBERS_max=3000000000 sdr->tCCS_min=100000 sdr->tPROG_max=600000000 sdr->tR_max=25000000 sdr->tALH_min=20000 sdr->tADL_min=400000 sdr->tALS_min=50000 sdr->tAR_min=25000 sdr->tCEA_max=100000 sdr->tCEH_min=20000 sdr->tCH_min=20000 sdr->tCHZ_max=100000 sdr->tCLH_min=20000 sdr->tCLR_min=20000 sdr->tCLS_min=50000 sdr->tCOH_min=0 sdr->tCS_min=70000 sdr->tDH_min=20000 sdr->tDS_min=40000 sdr->tFEAT_max=1000000 sdr->tIR_min=10000 sdr->tITC_max=1000000 sdr->tRC_min=100000 sdr->tREA_max=40000 sdr->tREH_min=30000 sdr->tRHOH_min=0 sdr->tRHW_min=200000 sdr->tRHZ_max=200000 sdr->tRLOH_min=0 sdr->tRP_min=50000 sdr->tRR_min=40000 sdr->tRST_max=250000000000 sdr->tWB_max=200000 sdr->tWC_min=100000 sdr->tWH_min=30000 sdr->tWHR_min=120000 sdr->tWP_min=50000 sdr->tWW_min=100000 hw->clk_rate=22000000 wrn_dly_sel=0 period_ps=45454 addr_setup_cycles=2 data_setup_cycles=1 data_hold_cycles=1 busy_timeout_cycles=555 hw->timing0=0x00020101 hw->timing1=0xb0000000 dll_threshold_ps=12000 use_half_period=1 reference_period_ps=22727 tRP_ps=45454 sample_delay_ps=4294955664 sample_delay_factor=0 hw->ctrl1n=0x00000000 hw->ctrl1n=0x00000000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547): gpmi_nfc_apply_timings() hw>clk_rate=22000000 clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=22000000gpmi-nand 1806000.gpmi-nand: use legacy bch geometry drivers/mtd/nand/raw/nand_base.c(913): checking mode=5 drivers/mtd/nand/raw/nand_base.c(927): BREAKING AT mode=5 drivers/mtd/nand/raw/nand_base.c(932): chip->onfi_timing_mode_default=5 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(426):
gpmi_nfc_compute_timings()sdr->tBERS_max=3000000000 sdr->tCCS_min=100000 sdr->tPROG_max=600000000 sdr->tR_max=25000000 sdr->tALH_min=5000 sdr->tADL_min=400000 sdr->tALS_min=10000 sdr->tAR_min=10000 sdr->tCEA_max=25000 sdr->tCEH_min=20000 sdr->tCH_min=5000 sdr->tCHZ_max=30000 sdr->tCLH_min=5000 sdr->tCLR_min=10000 sdr->tCLS_min=10000 sdr->tCOH_min=15000 sdr->tCS_min=15000 sdr->tDH_min=5000 sdr->tDS_min=7000 sdr->tFEAT_max=1000000 sdr->tIR_min=0 sdr->tITC_max=1000000 sdr->tRC_min=20000 sdr->tREA_max=16000 sdr->tREH_min=7000 sdr->tRHOH_min=15000 sdr->tRHW_min=100000 sdr->tRHZ_max=100000 sdr->tRLOH_min=5000 sdr->tRP_min=10000 sdr->tRR_min=20000 sdr->tRST_max=500000000 sdr->tWB_max=100000 sdr->tWC_min=20000 sdr->tWH_min=7000 sdr->tWHR_min=80000 sdr->tWP_min=10000 sdr->tWW_min=100000 hw->clk_rate=100000000 wrn_dly_sel=3 period_ps=10000 addr_setup_cycles=1 data_setup_cycles=1 data_hold_cycles=1 busy_timeout_cycles=2510 hw->timing0=0x00010101 hw->timing1=0xe0000000 dll_threshold_ps=12000 use_half_period=0 reference_period_ps=10000 tRP_ps=10000 sample_delay_ps=80000 sample_delay_factor=8 hw->ctrl1n=0x00c00000 hw->ctrl1n=0x00c28000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(547): gpmi_nfc_apply_timings() hw>clk_rate=100000000 clk_set_rate(r->clock[0], hw->clk_rate)=0 clk_get_rate(r->clock[0])=99000000Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...And "cat
/sys/kernel/debug/clk/clk_summary" gives:enable prepare protect duty
clock count count count rate accuracy phase cycle
---------------------------------------------------------------------------------------------dummy 2 2 0 0 0 0 50000 cko2_sel 0 0 0 0 0 0 50000 cko2_podf 0 0 0 0 0 0 50000 cko2 0 0 0 0 0 0 50000 cko1_sel 0 0 0 0 0 0 50000 cko1_podf 0 0 0 0 0 0 50000 cko1 0 0 0 0 0 0 50000 cko 0 0 0 0 0 0 50000 usbphy2_gate 1 1 0 0 0 0 50000 usbphy1_gate 1 1 0 0 0 0 50000 ipp_di1 0 0 0 0 0 0 50000 ipp_di0 0 0 0 0 0 0 50000 osc 6 6 0 24000000 0 0 50000 perclk_sel 1 1 0 24000000 0 0 50000 perclk 3 3 0 24000000 0 0 50000 pwm7 0 0 0 24000000 0 0 50000 pwm6 0 0 0 24000000 0 0 50000 pwm5 0 0 0 24000000 0 0 50000 i2c4 0 0 0 24000000 0 0 50000 pwm8 0 0 0 24000000 0 0 50000 pwm4 0 0 0 24000000 0 0 50000 pwm3 0 0 0 24000000 0 0 50000 pwm2 0 0 0 24000000 0 0 50000 pwm1 0 0 0 24000000 0 0 50000 i2c3 0 0 0 24000000 0 0 50000 i2c2 1 1 0 24000000 0 0 50000 i2c1 0 0 0 24000000 0 0 50000 gpt1_serial 1 1 0 24000000 0 0 50000 gpt1_bus 1 1 0 24000000 0 0 50000 epit2 0 0 0 24000000 0 0 50000 epit1 0 0 0 24000000 0 0 50000 gpt2_serial 0 0 0 24000000 0 0 50000 gpt2_bus 0 0 0 24000000 0 0 50000 periph_clk2_sel 0 0 0 24000000 0 0 50000 periph_clk2 0 0 0 24000000 0 0 50000 gpt_3m 0 0 0 3000000 0 0 50000 csi_sel 0 0 0 24000000 0 0 50000 csi_podf 0 0 0 24000000 0 0 50000 csi 0 0 0 24000000 0 0 50000 pll7 1 1 0 480000000 0 0 50000 pll7_bypass 1 1 0 480000000 0 0 50000 pll7_usb_host 1 1 0 480000000 0 0 50000 usbphy2 1 1 0 480000000 0 0 50000 pll6 1 1 0 500000000 0 0 50000 pll6_bypass 1 1 0 500000000 0 0 50000 pll6_enet 2 2 0 500000000 0 0 50000 enet_ptp_ref 1 1 0 25000000 0 0 50000 enet_ptp 1 1 0 25000000 0 0 50000 enet2_ref 0 0 0 50000000 0 0 50000 enet_ref_125m 0 0 0 50000000 0 0 50000 enet_ref 2 2 0 50000000 0 0 50000 pll5 0 0 0 296600000 0 0 50000 pll5_bypass 0 0 0 296600000 0 0 50000 pll5_video 0 0 0 296600000 0 0 50000 pll5_post_div 0 0 0 74150000 0 0 50000 pll5_video_div 0 0 0 74150000 0 0 50000 pll4 0 0 0 147456000 0 0 50000 pll4_bypass 0 0 0 147456000 0 0 50000 pll4_audio 0 0 0 147456000 0 0 50000 pll4_post_div 0 0 0 36864000 0 0 50000 pll4_audio_div 0 0 0 36864000 0 0 50000 pll3 1 1 0 480000000 0 0 50000 pll3_bypass 1 1 0 480000000 0 0 50000 pll3_usb_otg 2 2 0 480000000 0 0 50000 spdif_sel 0 0 0 480000000 0 0 50000 spdif_pred 0 0 0 240000000 0 0 50000 spdif_podf 0 0 0 30000000 0 0 50000 spdif 0 0 0 30000000 0 0 50000 esai_sel 0 0 0 480000000 0 0 50000 esai_pred 0 0 0 240000000 0 0 50000 esai_podf 0 0 0 30000000 0 0 50000 esai_extal 0 0 0 30000000 0 0 50000 qspi1_sel 0 0 0 480000000 0 0 50000 qspi1_podf 0 0 0 240000000 0 0 50000 qspi1 0 0 0 240000000 0 0 50000 ldb_di1_div_7 0 0 0 68571428 0 0 50000 ldb_di1 0 0 0 68571428 0 0 50000 ldb_di1_div_3_5 0 0 0 137142857 0 0 50000 periph2_clk2_sel 0 0 0 480000000 0 0 50000 periph2_clk2 0 0 0 480000000 0 0 50000 pll3_60m 0 0 0 60000000 0 0 50000 can_sel 0 0 0 60000000 0 0 50000 can_podf 0 0 0 30000000 0 0 50000 can2_serial 0 0 0 30000000 0 0 50000 can1_serial 0 0 0 30000000 0 0 50000 ecspi_sel 0 0 0 60000000 0 0 50000 ecspi_podf 0 0 0 60000000 0 0 50000 ecspi4 0 0 0 60000000 0 0 50000 ecspi3 0 0 0 60000000 0 0 50000 ecspi2 0 0 0 60000000 0 0 50000 ecspi1 0 0 0 60000000 0 0 50000 pll3_80m 1 1 0 80000000 0 0 50000 uart_sel 1 1 0 80000000 0 0 50000 uart_podf 1 1 0 80000000 0 0 50000 uart8_serial 0 0 0 80000000 0 0 50000 uart7_serial 0 0 0 80000000 0 0 50000 uart1_serial 1 2 0 80000000 0 0 50000 uart6_serial 0 0 0 80000000 0 0 50000 uart5_serial 0 0 0 80000000 0 0 50000 uart4_serial 0 0 0 80000000 0 0 50000 uart3_serial 0 0 0 80000000 0 0 50000 uart2_serial 0 0 0 80000000 0 0 50000 pll3_pfd3_454m 0 0 0 454736842 0 0 50000 pll3_pfd2_508m 0 0 0 508235294 0 0 50000 epdc_pre_sel 0 0 0 508235294 0 0 50000 epdc_podf 0 0 0 254117647 0 0 50000 epdc_pix 0 0 0 254117647 0 0 50000 epdc_sel 0 0 0 254117647 0 0 50000 sai1_sel 0 0 0 508235294 0 0 50000 sai1_pred 0 0 0 127058824 0 0 50000 sai1_podf 0 0 0 63529412 0 0 50000 sai1 0 0 0 63529412 0 0 50000 sai2_sel 0 0 0 508235294 0 0 50000 sai2_pred 0 0 0 127058824 0 0 50000 sai2_podf 0 0 0 63529412 0 0 50000 sai2 0 0 0 63529412 0 0 50000 sai3_sel 0 0 0 508235294 0 0 50000 sai3_pred 0 0 0 127058824 0 0 50000 sai3_podf 0 0 0 63529412 0 0 50000 sai3 0 0 0 63529412 0 0 50000 pll3_pfd1_540m 0 0 0 540000000 0 0 50000 lcdif_pre_sel 0 0 0 540000000 0 0 50000 lcdif_pred 0 0 0 270000000 0 0 50000 lcdif_podf 0 0 0 135000000 0 0 50000 lcdif_pix 0 0 0 135000000 0 0 50000 iomuxc 0 0 0 135000000 0 0 50000 lcdif_sel 0 0 0 135000000 0 0 50000 pll3_pfd0_720m 0 0 0 720000000 0 0 50000 usbphy1 1 1 0 480000000 0 0 50000 pll2 1 1 0 528000000 0 0 50000 pll2_bypass 1 1 0 528000000 0 0 50000 pll2_bus 2 2 0 528000000 0 0 50000 ca7_secondary_sel 0 0 0 528000000 0 0 50000 step 0 0 0 528000000 0 0 50000 periph_pre 1 1 0 528000000 0 0 50000 periph 3 3 0 528000000 0 0 50000 ahb 7 7 0 132000000 0 0 50000 sdma 0 0 0 132000000 0 0 50000 rom 1 1 0 132000000 0 0 50000 esai_mem 0 0 0 132000000 0 0 50000 esai_ipg 0 0 0 132000000 0 0 50000 aips_tz3 1 1 0 132000000 0 0 50000 enet_ahb 2 2 0 132000000 0 0 50000 dcp 0 0 0 132000000 0 0 50000 asrc_mem 0 0 0 132000000 0 0 50000 asrc_ipg 0 0 0 132000000 0 0 50000 aips_tz2 1 1 0 132000000 0 0 50000 aips_tz1 1 1 0 132000000 0 0 50000 ipg 10 10 0 66000000 0 0 50000 wdog3 0 0 0 66000000 0 0 50000 uart8_ipg 0 0 0 66000000 0 0 50000 usboh3 2 2 0 66000000 0 0 50000 sai2_ipg 0 0 0 66000000 0 0 50000 sai1_ipg 0 0 0 66000000 0 0 50000 uart7_ipg 0 0 0 66000000 0 0 50000 uart1_ipg 1 2 0 66000000 0 0 50000 sai3_ipg 0 0 0 66000000 0 0 50000 spdif_gclk 0 0 0 66000000 0 0 50000 spba 0 0 0 66000000 0 0 50000 wdog2 0 0 0 66000000 0 0 50000 kpp 0 0 0 66000000 0 0 50000 mmdc_p1_ipg 0 0 0 66000000 0 0 50000 mmdc_p0_ipg 2 2 0 66000000 0 0 50000 wdog1 1 1 0 66000000 0 0 50000 gpio4 1 1 0 66000000 0 0 50000 uart6_ipg 0 0 0 66000000 0 0 50000 uart5_ipg 0 0 0 66000000 0 0 50000 gpio3 1 1 0 66000000 0 0 50000 ocotp 0 0 0 66000000 0 0 50000 gpio5 1 1 0 66000000 0 0 50000 gpio1 1 1 0 66000000 0 0 50000 uart4_ipg 0 0 0 66000000 0 0 50000 adc1 0 0 0 66000000 0 0 50000 uart3_ipg 0 0 0 66000000 0 0 50000 adc2 0 0 0 66000000 0 0 50000 gpio2 1 1 0 66000000 0 0 50000 uart2_ipg 0 0 0 66000000 0 0 50000 can2_ipg 0 0 0 66000000 0 0 50000 can1_ipg 0 0 0 66000000 0 0 50000 enet 2 2 0 66000000 0 0 50000 axi_sel 1 1 0 528000000 0 0 50000 axi_podf 2 2 0 264000000 0 0 50000 axi 1 1 0 264000000 0 0 50000 eim_slow_sel 0 0 0 264000000 0 0 50000 eim_slow_podf 0 0 0 132000000 0 0 50000 eim 0 0 0 132000000 0 0 50000 lcdif_apb 0 0 0 264000000 0 0 50000 pxp 0 0 0 264000000 0 0 50000 epdc_aclk 0 0 0 264000000 0 0 50000 pll2_pfd3_594m 0 0 0 594000000 0 0 50000 ldb_di0_sel 0 0 0 594000000 0 0 50000 ldb_di0_div_7 0 0 0 84857142 0 0 50000 ldb_di0 0 0 0 84857142 0 0 50000 ldb_di0_div_3_5 0 0 0 169714285 0 0 50000 pll2_pfd2_396m 2 2 0 396000000 0 0 50000 enfc_sel 0 0 0 396000000 0 0 50000 enfc_pred 0 0 0 99000000 0 0 50000 enfc_podf 0 0 0 99000000 0 0 50000 gpmi_io 0 0 0 99000000 0 0 50000 usdhc1_sel 0 0 0 396000000 0 0 50000 usdhc1_podf 0 0 0 198000000 0 0 50000 usdhc1 0 0 0 198000000 0 0 50000 usdhc2_sel 0 0 0 396000000 0 0 50000 usdhc2_podf 0 0 0 198000000 0 0 50000 usdhc2 0 0 0 198000000 0 0 50000 bch_sel 1 1 0 396000000 0 0 50000 bch_podf 1 1 0 99000000 0 0 50000 gpmi_apb 0 0 0 99000000 0 0 50000 gpmi_bch_apb 0 0 0 99000000 0 0 50000 per_bch 0 0 0 99000000 0 0 50000 apbh_dma 1 1 0 99000000 0 0 50000 gpmi_sel 0 0 0 396000000 0 0 50000 gpmi_podf 0 0 0 99000000 0 0 50000 gpmi_bch 0 0 0 99000000 0 0 50000 periph2_pre 1 1 0 396000000 0 0 50000 periph2 2 2 0 396000000 0 0 50000 mmdc_podf 2 2 0 396000000 0 0 50000 mmdc_p0_fast 1 1 0 396000000 0 0 50000 axi_alt_sel 0 0 0 396000000 0 0 50000 pll2_198m 0 0 0 198000000 0 0 50000 pll2_pfd1_594m 0 0 0 594000000 0 0 50000 pll2_pfd0_352m 0 0 0 352000000 0 0 50000 pll1 1 1 0 900000000 0 0 50000 pll1_bypass 1 1 0 900000000 0 0 50000 pll1_sys 1 1 0 900000000 0 0 50000 pll1_sw 1 1 0 900000000 0 0 50000 arm 1 1 0 900000000 0 0 50000 pll7_bypass_src 0 0 0 24000000 0 0 50000 pll6_bypass_src 0 0 0 24000000 0 0 50000 pll5_bypass_src 0 0 0 24000000 0 0 50000 pll4_bypass_src 0 0 0 24000000 0 0 50000 pll3_bypass_src 0 0 0 24000000 0 0 50000 pll2_bypass_src 0 0 0 24000000 0 0 50000 pll1_bypass_src 0 0 0 24000000 0 0 50000Quoted 4 lines
ckil 0 0 0 32768 0 0 50000
Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-4@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ; -if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate);/* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); }
Quoted 7 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 730
Quoted 1 line
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Note also that I had to hand merge the changes, since in 5.1.14 that
gpmi_nfc_apply_timings()is ingpmi-lib.c. But it was trivial to do.
Oh well. I guess the next thing to do would be to dump the timing regs and clk rate that are set by the bootloader (before the driver override them) or those applied by an older kernel (one that didn't have that issue).
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Boris,
Quoted 41 lines · Boris Brezillon
Quoted 39 lines · On Fri, 2 Aug 2019 22:34:57 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 24 lines · Boris Brezillon
Quoted 10 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 8 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 7 lines · Greg Ungerer
Quoted 6 lines · Greg Ungerer
Quoted 4 lines · Miquel Raynal
Quoted 3 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Quoted 1 line
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-1@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ;drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 730
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-3-if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate);/* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); } static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Quoted 7 lines
Quoted 2 lines
Note also that I had to hand merge the changes, since in 5.1.14 that
gpmi_nfc_apply_timings()is ingpmi-lib.c. But it was trivial to do.Oh well. I guess the next thing to do would be to dump the timing regs and clk rate that are set by the bootloader (before the driver override them) or those applied by an older kernel (one that didn't have that issue).
Is this useful?
With attached patch, I get the following dump of the timing settings in use:
...
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490): gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00010203 (calculated=0x00020101) HW_GPMI_TIMING1=0x00000000 (calculated=0x60000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00000000) r->clock[0]=22000000 (calculated=22000000)
random: fast init done
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490): gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00010203 (calculated=0x00020101) HW_GPMI_TIMING1=0x00000000 (calculated=0xb0000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00000000) r->clock[0]=22000000 (calculated=22000000)
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490): gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00010203 (calculated=0x00010101) HW_GPMI_TIMING1=0x00000000 (calculated=0xe0000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00c28000) r->clock[0]=22000000 (calculated=100000000)
Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...
Regards
Greg
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +9 -0
@@ -486,6 +486,14 @@void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; +#if 1 +printk ("%s(%d): gpmi_nfc_apply_timings()\n" , __FILE__, __LINE__); +printk (" HW_GPMI_TIMING0=0x%08x (calculated=0x%08x)\n" ,readl (gpmi_regs +HW_GPMI_TIMING0 ), hw->timing0); +printk (" HW_GPMI_TIMING1=0x%08x (calculated=0x%08x)\n" ,readl (gpmi_regs +HW_GPMI_TIMING1 ), hw->timing1); +printk (" HW_GPMI_CTRL1_SET=0x%08x (calculated=0x%08x)\n" ,readl (gpmi_regs +HW_GPMI_CTRL1_SET ), hw->ctrl1n); +printk (" r->clock[0]=%d (calculated=%d)\n" ,clk_get_rate (r->clock[0 ]), hw->clk_rate); +#endif +#if 0 clk_set_rate (r->clock[0 ], hw->clk_rate);writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );
@@ -505,6 +513,7 @@/* Wait for the DLL to settle. */ udelay (dll_wait_time_us); +#endif } int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Greg,
Greg Ungerer <[email protected]> wrote on Mon, 5 Aug 2019 15:51:05 +1000:
Quoted 66 lines
Hi Boris,
Quoted 38 lines · Boris Brezillon
Quoted 36 lines · On Fri, 2 Aug 2019 22:34:57 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 21 lines · Boris Brezillon
Quoted 10 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 8 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 7 lines · Greg Ungerer
Quoted 6 lines · Greg Ungerer
Quoted 4 lines · Miquel Raynal
Quoted 3 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Quoted 1 line
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 727
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-4>>> /* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ; -if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate); >>> /* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); } >>> static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Quoted 7 lines
Quoted 2 lines
Note also that I had to hand merge the changes, since in 5.1.14 that
gpmi_nfc_apply_timings()is ingpmi-lib.c. But it was trivial to do.Oh well. I guess the next thing to do would be to dump the timing regs and clk rate that are set by the bootloader (before the driver override them) or those applied by an older kernel (one that didn't have that issue).
Is this useful?
With attached patch, I get the following dump of the timing settings in use:
...
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490):gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00010203 (calculated=0x00020101) HW_GPMI_TIMING1=0x00000000 (calculated=0x60000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00000000) r->clock[0]=22000000 (calculated=22000000)
random: fast init done
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490):gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00010203 (calculated=0x00020101)
Quoted 8 lines
HW_GPMI_TIMING1=0x00000000 (calculated=0xb0000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00000000) r->clock[0]=22000000 (calculated=22000000)
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490):gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00010203 (calculated=0x00010101) HW_GPMI_TIMING1=0x00000000 (calculated=0xe0000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00c28000) r->clock[0]=22000000 (calculated=100000000)
Why are the registers not updated? Is it the same situation when we get all the failures?
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Miquel,
Quoted 74 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Mon, 5 Aug 2019 15:51:05 +1000:
Quoted 63 lines · Boris Brezillon
Quoted 38 lines
Quoted 36 lines · On Fri, 2 Aug 2019 22:34:57 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 21 lines · Boris Brezillon
Quoted 10 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 8 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 7 lines · Greg Ungerer
Quoted 6 lines · Greg Ungerer
Quoted 4 lines · Miquel Raynal
Quoted 3 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Quoted 1 line
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 727
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-4>>> /* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ; -if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate); >>> /* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); } >>> static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Quoted 7 lines
Quoted 2 lines
Note also that I had to hand merge the changes, since in 5.1.14 that
gpmi_nfc_apply_timings()is ingpmi-lib.c. But it was trivial to do.Oh well. I guess the next thing to do would be to dump the timing regs and clk rate that are set by the bootloader (before the driver override them) or those applied by an older kernel (one that didn't have that issue).
Is this useful?
With attached patch, I get the following dump of the timing settings in use:
...
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490):gpmi_nfc_apply_timings()HW_GPMI_TIMING0=0x00010203 (calculated=0x00020101) HW_GPMI_TIMING1=0x00000000 (calculated=0x60000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00000000) r->clock[0]=22000000 (calculated=22000000)random: fast init done
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490):gpmi_nfc_apply_timings()Quoted 9 lines
HW_GPMI_TIMING0=0x00010203 (calculated=0x00020101) HW_GPMI_TIMING1=0x00000000 (calculated=0xb0000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00000000) r->clock[0]=22000000 (calculated=22000000) drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490): gpmi_nfc_apply_timings() HW_GPMI_TIMING0=0x00010203 (calculated=0x00010101) HW_GPMI_TIMING1=0x00000000 (calculated=0xe0000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00c28000) r->clock[0]=22000000 (calculated=100000000)
Quoted 2 lines
Why are the registers not updated? Is it the same situation when we get all the failures?
As per the patch that was attached to that email. The setting of the registers and clock was "#if 0" out so you could see what the power-up/boot-loader settings are. Those settings work reliably with no nand failures. In between running various tests I have left my hardware boot cycle testing with those settings. I don't have an exact number but it has probably run at least 100 hours and tens of thousands of boots with no problem using those.
Or am I misunderstanding your question?
Regards
Greg
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 47 lines · On Mon, 5 Aug 2019 15:51:05 +1000 Greg Ungerer <[email protected]> wrote:
Hi Boris,
Quoted 44 lines · Boris Brezillon
Quoted 41 lines · On Fri, 2 Aug 2019 22:34:57 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 24 lines · Boris Brezillon
Quoted 10 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 8 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 7 lines · Greg Ungerer
Quoted 6 lines · Greg Ungerer
Quoted 4 lines · Miquel Raynal
Quoted 3 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Quoted 1 line
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-1@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ;drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 730
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-3-if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate);/* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); } static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Note also that I had to hand merge the changes, since in 5.1.14 that
gpmi_nfc_apply_timings()is ingpmi-lib.c. But it was trivial to do.
Quoted 6 lines
Quoted 4 lines
Oh well. I guess the next thing to do would be to dump the timing regs and clk rate that are set by the bootloader (before the driver override them) or those applied by an older kernel (one that didn't have that issue).
Is this useful?
Hm, looks like it's configured in mode 0, so no, it's not super useful. Can you try booting an older kernel (one that didn't have the ->setup_data_interface() hook implemented).
Quoted 35 lines
With attached patch, I get the following dump of the timing settings in use:
...
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490):gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00010203 (calculated=0x00020101) HW_GPMI_TIMING1=0x00000000 (calculated=0x60000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00000000) r->clock[0]=22000000 (calculated=22000000)
random: fast init done
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490):gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00010203 (calculated=0x00020101) HW_GPMI_TIMING1=0x00000000 (calculated=0xb0000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00000000) r->clock[0]=22000000 (calculated=22000000)
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490):gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00010203 (calculated=0x00010101) HW_GPMI_TIMING1=0x00000000 (calculated=0xe0000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00c28000) r->clock[0]=22000000 (calculated=100000000)
Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...
Quoted 4 lines
Regards
Greg
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Boris,
Quoted 52 lines · Boris Brezillon
Quoted 50 lines · On Mon, 5 Aug 2019 15:51:05 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 48 lines · Boris Brezillon
Quoted 34 lines · On Fri, 2 Aug 2019 22:34:57 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 33 lines · Boris Brezillon
Quoted 10 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 8 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 7 lines · Greg Ungerer
Quoted 6 lines · Greg Ungerer
Quoted 4 lines · Miquel Raynal
Quoted 3 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Quoted 1 line
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-4@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ; -if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate);/* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); }Quoted 7 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 730
Quoted 1 line
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Note also that I had to hand merge the changes, since in 5.1.14 that
gpmi_nfc_apply_timings()is ingpmi-lib.c. But it was trivial to do.Oh well. I guess the next thing to do would be to dump the timing regs and clk rate that are set by the bootloader (before the driver override them) or those applied by an older kernel (one that didn't have that issue).
Quoted 5 lines
Quoted 1 line
Is this useful?
Hm, looks like it's configured in mode 0, so no, it's not super useful. Can you try booting an older kernel (one that didn't have the ->setup_data_interface() hook implemented).
Ok. I went back from 5.1 and the first kernel I could find that returned no grep hits for "setup_data_interface" was 4.16.
So I built for my target with that and added similar trace to dump the hardware register settings for that. Debug output looks like this now for it:
...
drivers/mtd/nand/gpmi-nand/gpmi-nand.c(807): gpmi_get_clks()
clk_get_rate(r->clock[0])=22000000
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin()
HW_GPMI_TIMING0=0x00010203
HW_GPMI_TIMING1=0x05000000
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(966): enable_edo_mode()
clk_get_rate(r->clock[0])=99000000
gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin()
HW_GPMI_TIMING0=0x00010101
HW_GPMI_TIMING1=0x90000000
Scanning device for bad blocks
5 ofpart partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...
I am running boot tests now on this to confirm it actually runs reliably.
Regards
Greg
Quoted 34 lines
Quoted 34 lines
With attached patch, I get the following dump of the timing settings in use:
...
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490):gpmi_nfc_apply_timings()HW_GPMI_TIMING0=0x00010203 (calculated=0x00020101) HW_GPMI_TIMING1=0x00000000 (calculated=0x60000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00000000) r->clock[0]=22000000 (calculated=22000000)random: fast init done
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490):gpmi_nfc_apply_timings()HW_GPMI_TIMING0=0x00010203 (calculated=0x00020101) HW_GPMI_TIMING1=0x00000000 (calculated=0xb0000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00000000) r->clock[0]=22000000 (calculated=22000000) drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490): gpmi_nfc_apply_timings() HW_GPMI_TIMING0=0x00010203 (calculated=0x00010101) HW_GPMI_TIMING1=0x00000000 (calculated=0xe0000000) HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00c28000) r->clock[0]=22000000 (calculated=100000000)Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...
Quoted 6 lines
Quoted 4 lines
Regards
Greg
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 68 lines · On Fri, 9 Aug 2019 15:20:52 +1000 Greg Ungerer <[email protected]> wrote:
Hi Boris,
Quoted 52 lines · Boris Brezillon
Quoted 50 lines · On Mon, 5 Aug 2019 15:51:05 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 48 lines · Boris Brezillon
Quoted 34 lines · On Fri, 2 Aug 2019 22:34:57 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 33 lines · Boris Brezillon
Quoted 10 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 8 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 7 lines · Greg Ungerer
Quoted 6 lines · Greg Ungerer
Quoted 4 lines · Miquel Raynal
Quoted 3 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
Quoted 2 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-4@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ; -if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate);/* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); }Quoted 7 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 730
Quoted 1 line
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Note also that I had to hand merge the changes, since in 5.1.14 that
gpmi_nfc_apply_timings()is ingpmi-lib.c. But it was trivial to do.Oh well. I guess the next thing to do would be to dump the timing regs and clk rate that are set by the bootloader (before the driver override them) or those applied by an older kernel (one that didn't have that issue).
Quoted 5 lines
Quoted 1 line
Is this useful?
Hm, looks like it's configured in mode 0, so no, it's not super useful. Can you try booting an older kernel (one that didn't have the ->setup_data_interface() hook implemented).
Ok. I went back from 5.1 and the first kernel I could find that returned no grep hits for "
setup_data_interface" was 4.16.So I built for my target with that and added similar trace to dump the hardware register settings for that. Debug output looks like this now for it:
Quoted 14 lines
...
drivers/mtd/nand/gpmi-nand/gpmi-nand.c(807):gpmi_get_clks()
clk_get_rate(r->clock[0])=22000000
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054):gpmi_begin()
HW_GPMI_TIMING0=0x00010203
HW_GPMI_TIMING1=0x05000000
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(966):enable_edo_mode()
clk_get_rate(r->clock[0])=99000000
gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054):gpmi_begin()
HW_GPMI_TIMING0=0x00010101
TIMING0 match the one you have with 5.1 kernels.
Quoted 1 line
HW_GPMI_TIMING1=0x90000000
And we even have a bigger timeout value in 5.1 (0xe0000000), so we should be all safe WRT to timings in TIMING{0,1}.
Can you dump CTRL1?
Quoted 11 lines
Scanning device for bad blocks
5 ofpart partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 83 lines · Boris Brezillon
Quoted 72 lines · On Fri, 9 Aug 2019 15:20:52 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 52 lines · Boris Brezillon
Quoted 50 lines · On Mon, 5 Aug 2019 15:51:05 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 48 lines · Boris Brezillon
Quoted 34 lines · On Fri, 2 Aug 2019 22:34:57 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 33 lines · Boris Brezillon
Quoted 10 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 8 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 7 lines · Greg Ungerer
Quoted 6 lines · Greg Ungerer
Quoted 4 lines · Miquel Raynal
Quoted 3 lines
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
On 29/7/19 6:36 pm, Miquel Raynal wrote:
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:[snip]
Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-4@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ; -if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate);/* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); }Quoted 7 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 730
Quoted 1 line
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Note also that I had to hand merge the changes, since in 5.1.14 that
gpmi_nfc_apply_timings()is ingpmi-lib.c. But it was trivial to do.Oh well. I guess the next thing to do would be to dump the timing regs and clk rate that are set by the bootloader (before the driver override them) or those applied by an older kernel (one that didn't have that issue).
Quoted 5 lines
Quoted 1 line
Is this useful?
Hm, looks like it's configured in mode 0, so no, it's not super useful. Can you try booting an older kernel (one that didn't have the ->setup_data_interface() hook implemented).
Ok. I went back from 5.1 and the first kernel I could find that returned no grep hits for "
setup_data_interface" was 4.16.So I built for my target with that and added similar trace to dump the hardware register settings for that. Debug output looks like this now for it:
...
drivers/mtd/nand/gpmi-nand/gpmi-nand.c(807):gpmi_get_clks()clk_get_rate(r->clock[0])=22000000 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin() HW_GPMI_TIMING0=0x00010203 HW_GPMI_TIMING1=0x05000000Quoted 8 lines
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(966):enable_edo_mode()clk_get_rate(r->clock[0])=99000000 gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin() HW_GPMI_TIMING0=0x00010101
Quoted 8 lines
TIMING0 match the one you have with 5.1 kernels.
Quoted 1 line
HW_GPMI_TIMING1=0x90000000And we even have a bigger timeout value in 5.1 (
0xe0000000), so we should be all safe WRT to timings in TIMING{0,1}.Can you dump CTRL1?
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin()
HW_GPMI_TIMING0=0x00010101 HW_GPMI_TIMING1=0x90000000 HW_GPMI_CTRL1_SET=0x01c4800c
Scanning device for bad blocks
5 ofpart partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
Regards
Greg
Quoted 13 lines
Quoted 11 lines
Scanning device for bad blocks
5 ofpart partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 91 lines · On Fri, 9 Aug 2019 16:55:22 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 90 lines · Boris Brezillon
Quoted 72 lines · On Fri, 9 Aug 2019 15:20:52 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 52 lines · Boris Brezillon
Quoted 50 lines · On Mon, 5 Aug 2019 15:51:05 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 48 lines · Boris Brezillon
Quoted 34 lines · On Fri, 2 Aug 2019 22:34:57 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 33 lines · Boris Brezillon
Quoted 10 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 8 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 7 lines · Greg Ungerer
Quoted 6 lines · Greg Ungerer
Quoted 4 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
On 29/7/19 6:36 pm, Miquel Raynal wrote:
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:[snip]
Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-4@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ; -if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate);/* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); }Quoted 7 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 730
Quoted 1 line
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Note also that I had to hand merge the changes, since in 5.1.14 that
gpmi_nfc_apply_timings()is ingpmi-lib.c. But it was trivial to do.Oh well. I guess the next thing to do would be to dump the timing regs and clk rate that are set by the bootloader (before the driver override them) or those applied by an older kernel (one that didn't have that issue).
Quoted 5 lines
Quoted 1 line
Is this useful?
Hm, looks like it's configured in mode 0, so no, it's not super useful. Can you try booting an older kernel (one that didn't have the ->setup_data_interface() hook implemented).
Ok. I went back from 5.1 and the first kernel I could find that returned no grep hits for "
setup_data_interface" was 4.16.So I built for my target with that and added similar trace to dump the hardware register settings for that. Debug output looks like this now for it:
...
drivers/mtd/nand/gpmi-nand/gpmi-nand.c(807):gpmi_get_clks()clk_get_rate(r->clock[0])=22000000 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin() HW_GPMI_TIMING0=0x00010203 HW_GPMI_TIMING1=0x05000000Quoted 8 lines
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(966):enable_edo_mode()clk_get_rate(r->clock[0])=99000000 gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin() HW_GPMI_TIMING0=0x00010101TIMING0 match the one you have with 5.1 kernels.
Quoted 1 line
HW_GPMI_TIMING1=0x90000000And we even have a bigger timeout value in 5.1 (
0xe0000000), so we should be all safe WRT to timings in TIMING{0,1}.
Quoted 6 lines
Quoted 1 line
Can you dump CTRL1?
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054):
gpmi_begin()
HW_GPMI_TIMING0=0x00010101 HW_GPMI_TIMING1=0x90000000 HW_GPMI_CTRL1_SET=0x01c4800c
The read/write delay fields seem to match, but there are a few more fields set in this version:
- DECOUPLE_CS
- BCH_MODE
- DEV_RESET
- CTRL1_ATA_IRQRDY_POLARITY__ACTIVEHIGH
Looks like those fields are not explicitly set in the gpmi_begin() patch, but maybe you dumped CTRL1. Would you mind sharing your patch? If I'm right and you indeed dumped CTRL1, it might be worth doing the same in your 5.1 kernel so we can more easily compare those dumps. While at it, can you dump CTRL1 before and after applying the changes?
Quoted 10 lines
Scanning device for bad blocks
5 ofpart partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
Quoted 17 lines
Regards
GregQuoted 13 lines
Quoted 11 lines
Scanning device for bad blocks
5 ofpart partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Boris,
Quoted 107 lines · Boris Brezillon
Quoted 91 lines · On Fri, 9 Aug 2019 16:55:22 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 90 lines · Boris Brezillon
Quoted 72 lines · On Fri, 9 Aug 2019 15:20:52 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 52 lines · Boris Brezillon
Quoted 50 lines · On Mon, 5 Aug 2019 15:51:05 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 48 lines · Boris Brezillon
Quoted 34 lines · On Fri, 2 Aug 2019 22:34:57 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 33 lines · Boris Brezillon
Quoted 10 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 8 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 7 lines · Greg Ungerer
Quoted 6 lines · Greg Ungerer
On 29/7/19 10:47 pm, Miquel Raynal wrote:
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
On 29/7/19 6:36 pm, Miquel Raynal wrote:
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-4@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ; -if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate);/* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); }Quoted 7 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 730
Quoted 1 line
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Note also that I had to hand merge the changes, since in 5.1.14 that
gpmi_nfc_apply_timings()is ingpmi-lib.c. But it was trivial to do.Oh well. I guess the next thing to do would be to dump the timing regs and clk rate that are set by the bootloader (before the driver override them) or those applied by an older kernel (one that didn't have that issue).
Quoted 5 lines
Quoted 1 line
Is this useful?
Hm, looks like it's configured in mode 0, so no, it's not super useful. Can you try booting an older kernel (one that didn't have the ->setup_data_interface() hook implemented).
Ok. I went back from 5.1 and the first kernel I could find that returned no grep hits for "
setup_data_interface" was 4.16.So I built for my target with that and added similar trace to dump the hardware register settings for that. Debug output looks like this now for it:
...
drivers/mtd/nand/gpmi-nand/gpmi-nand.c(807):gpmi_get_clks()clk_get_rate(r->clock[0])=22000000 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin() HW_GPMI_TIMING0=0x00010203 HW_GPMI_TIMING1=0x05000000Quoted 8 lines
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(966):enable_edo_mode()clk_get_rate(r->clock[0])=99000000 gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin() HW_GPMI_TIMING0=0x00010101TIMING0 match the one you have with 5.1 kernels.
Quoted 1 line
HW_GPMI_TIMING1=0x90000000And we even have a bigger timeout value in 5.1 (
0xe0000000), so we should be all safe WRT to timings in TIMING{0,1}.Quoted 6 lines
Quoted 1 line
Can you dump CTRL1?
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054):
gpmi_begin()HW_GPMI_TIMING0=0x00010101 HW_GPMI_TIMING1=0x90000000 HW_GPMI_CTRL1_SET=0x01c4800cThe read/write delay fields seem to match, but there are a few more fields set in this version:
-DECOUPLE_CS
-BCH_MODE
-DEV_RESET
-CTRL1_ATA_IRQRDY_POLARITY__ACTIVEHIGH
Quoted 2 lines
Looks like those fields are not explicitly set in the
gpmi_begin()patch, but maybe you dumped CTRL1. Would you mind sharing your patch?
Attached.
Quoted 3 lines
If I'm right and you indeed dumped CTRL1, it might be worth doing the same in your 5.1 kernel so we can more easily compare those dumps. While at it, can you dump CTRL1 before and after applying the changes?
Will do. I am out of my lab for the weekend, but I'll get those numbers first thing Monday morning.
Regards
Greg
drivers/mtd/nand/gpmi-nand/gpmi-lib.c +6 -0
@@ -963,6 +963,7 @@ static int enable_edo_mode(struct gpmi_nunsigned long rate;int ret; +printk ("%s(%d): enable_edo_mode()\n" , __FILE__, __LINE__); feature =kzalloc (ONFI_SUBFEATURE_PARAM_LEN ,GFP_KERNEL );if (!feature)return -ENOMEM ;
@@ -988,6 +989,7 @@ static int enable_edo_mode(struct gpmi_n/* [3] set the main IO clock, 100MHz for mode 5, 80MHz for mode 4. */ rate = (mode ==5 ) ?100000000 :80000000 ;clk_set_rate (r->clock[0 ], rate); +printk (" clk_get_rate(r->clock[0])=%ld\n" ,clk_get_rate (r->clock[0 ]));/* Let the gpmi_begin() re-compute the timing again. */ this->flags &= ~GPMI_TIMING_INIT_OK ;
@@ -1049,6 +1051,7 @@ void gpmi_begin(struct gpmi_nand_data *treturn ; this->flags |=GPMI_TIMING_INIT_OK ; +printk ("%s(%d): gpmi_begin()\n" , __FILE__, __LINE__);if (this->flags &GPMI_ASYNC_EDO_ENABLED )gpmi_compute_edo_timing (this, &hw);else
@@ -1060,10 +1063,12 @@ void gpmi_begin(struct gpmi_nand_data *tBF_GPMI_TIMING0_DATA_SETUP (hw.data_setup_in_cycles);writel (reg, gpmi_regs +HW_GPMI_TIMING0 ); +printk (" HW_GPMI_TIMING0=0x%08x\n" ,readl (gpmi_regs +HW_GPMI_TIMING0 ));/* [2] Set HW_GPMI_TIMING1 */ writel (BF_GPMI_TIMING1_BUSY_TIMEOUT (hw.device_busy_timeout), gpmi_regs +HW_GPMI_TIMING1 ); +printk (" HW_GPMI_TIMING1=0x%08x\n" ,readl (gpmi_regs +HW_GPMI_TIMING1 ));/* [3] The following code is to set the HW_GPMI_CTRL1. */
@@ -1088,6 +1093,7 @@ void gpmi_begin(struct gpmi_nand_data *t | BF_GPMI_CTRL1_RDN_DELAY(hw.sample_delay_factor);writel (reg, gpmi_regs +HW_GPMI_CTRL1_SET ); +printk (" HW_GPMI_CTRL1_SET=0x%08x\n" ,readl (gpmi_regs +HW_GPMI_CTRL1_SET ));/* At last, we enable the DLL. */ writel (BM_GPMI_CTRL1_DLL_ENABLE , gpmi_regs +HW_GPMI_CTRL1_SET );
drivers/mtd/nand/gpmi-nand/gpmi-nand.c +2 -0
@@ -804,6 +804,7 @@ static int gpmi_get_clks(struct gpmi_nanstruct clk *clk;int err, i; +printk ("%s(%d): gpmi_get_clks()\n" , __FILE__, __LINE__);for (i =0 ; i < this->devdata->clks_count; i++) { clk =devm_clk_get (this->dev, this->devdata->clks[i]);if (IS_ERR (clk)) {
@@ -822,6 +823,7 @@ static int gpmi_get_clks(struct gpmi_nan* Synchronous Mode, you should change the clock as you need. */ clk_set_rate (r->clock[0 ],22000000 ); +printk (" clk_get_rate(r->clock[0])=%ld\n" ,clk_get_rate (r->clock[0 ]));return 0 ;
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 110 lines · On Fri, 9 Aug 2019 23:57:08 +1000 Greg Ungerer <[email protected]> wrote:
Hi Boris,
Quoted 107 lines · Boris Brezillon
Quoted 91 lines · On Fri, 9 Aug 2019 16:55:22 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 90 lines · Boris Brezillon
Quoted 72 lines · On Fri, 9 Aug 2019 15:20:52 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 52 lines · Boris Brezillon
Quoted 50 lines · On Mon, 5 Aug 2019 15:51:05 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 48 lines · Boris Brezillon
Quoted 34 lines · On Fri, 2 Aug 2019 22:34:57 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 33 lines · Boris Brezillon
Quoted 10 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 8 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
Quoted 7 lines · Greg Ungerer
On 30/7/19 10:28 am, Greg Ungerer wrote:
On 29/7/19 10:47 pm, Miquel Raynal wrote:
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
On 29/7/19 6:36 pm, Miquel Raynal wrote:
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-4@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ; -if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate);/* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); }Quoted 7 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 730
Quoted 1 line
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Note also that I had to hand merge the changes, since in 5.1.14 that
gpmi_nfc_apply_timings()is ingpmi-lib.c. But it was trivial to do.Oh well. I guess the next thing to do would be to dump the timing regs and clk rate that are set by the bootloader (before the driver override them) or those applied by an older kernel (one that didn't have that issue).
Quoted 5 lines
Quoted 1 line
Is this useful?
Hm, looks like it's configured in mode 0, so no, it's not super useful. Can you try booting an older kernel (one that didn't have the ->setup_data_interface() hook implemented).
Ok. I went back from 5.1 and the first kernel I could find that returned no grep hits for "
setup_data_interface" was 4.16.So I built for my target with that and added similar trace to dump the hardware register settings for that. Debug output looks like this now for it:
...
drivers/mtd/nand/gpmi-nand/gpmi-nand.c(807):gpmi_get_clks()clk_get_rate(r->clock[0])=22000000 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin() HW_GPMI_TIMING0=0x00010203 HW_GPMI_TIMING1=0x05000000Quoted 8 lines
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(966):enable_edo_mode()clk_get_rate(r->clock[0])=99000000 gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin() HW_GPMI_TIMING0=0x00010101TIMING0 match the one you have with 5.1 kernels.
Quoted 1 line
HW_GPMI_TIMING1=0x90000000And we even have a bigger timeout value in 5.1 (
0xe0000000), so we should be all safe WRT to timings in TIMING{0,1}.Quoted 6 lines
Quoted 1 line
Can you dump CTRL1?
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054):
gpmi_begin()HW_GPMI_TIMING0=0x00010101 HW_GPMI_TIMING1=0x90000000 HW_GPMI_CTRL1_SET=0x01c4800cThe read/write delay fields seem to match, but there are a few more fields set in this version:
-DECOUPLE_CS
-BCH_MODE
-DEV_RESET
-CTRL1_ATA_IRQRDY_POLARITY__ACTIVEHIGH
Quoted 4 lines
Quoted 2 lines
Looks like those fields are not explicitly set in the
gpmi_begin()patch, but maybe you dumped CTRL1. Would you mind sharing your patch?Attached.
Hm, you should read CTRL1 instead of CTRL1_SET which I guess is WO.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Boris,
Quoted 110 lines · Boris Brezillon
Quoted 108 lines · On Fri, 9 Aug 2019 23:57:08 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 107 lines · Boris Brezillon
Quoted 91 lines · On Fri, 9 Aug 2019 16:55:22 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 90 lines · Boris Brezillon
Quoted 72 lines · On Fri, 9 Aug 2019 15:20:52 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 52 lines · Boris Brezillon
Quoted 50 lines · On Mon, 5 Aug 2019 15:51:05 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 48 lines · Boris Brezillon
Quoted 34 lines · On Fri, 2 Aug 2019 22:34:57 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 33 lines · Boris Brezillon
Quoted 10 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 8 lines · Miquel Raynal
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
On 30/7/19 10:41 am, Greg Ungerer wrote:
On 30/7/19 10:28 am, Greg Ungerer wrote:
On 29/7/19 10:47 pm, Miquel Raynal wrote:
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
On 29/7/19 6:36 pm, Miquel Raynal wrote:
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]Note that this was generated on a normal boot up (not failure).
The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-4@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ; -if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate);/* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); }Quoted 7 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 730
Quoted 1 line
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Note also that I had to hand merge the changes, since in 5.1.14 that
gpmi_nfc_apply_timings()is ingpmi-lib.c. But it was trivial to do.Oh well. I guess the next thing to do would be to dump the timing regs and clk rate that are set by the bootloader (before the driver override them) or those applied by an older kernel (one that didn't have that issue).
Quoted 5 lines
Quoted 1 line
Is this useful?
Hm, looks like it's configured in mode 0, so no, it's not super useful. Can you try booting an older kernel (one that didn't have the ->setup_data_interface() hook implemented).
Ok. I went back from 5.1 and the first kernel I could find that returned no grep hits for "
setup_data_interface" was 4.16.So I built for my target with that and added similar trace to dump the hardware register settings for that. Debug output looks like this now for it:
...
drivers/mtd/nand/gpmi-nand/gpmi-nand.c(807):gpmi_get_clks()clk_get_rate(r->clock[0])=22000000 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin() HW_GPMI_TIMING0=0x00010203 HW_GPMI_TIMING1=0x05000000Quoted 8 lines
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(966):enable_edo_mode()clk_get_rate(r->clock[0])=99000000 gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin() HW_GPMI_TIMING0=0x00010101TIMING0 match the one you have with 5.1 kernels.
Quoted 1 line
HW_GPMI_TIMING1=0x90000000And we even have a bigger timeout value in 5.1 (
0xe0000000), so we should be all safe WRT to timings in TIMING{0,1}.Quoted 6 lines
Quoted 1 line
Can you dump CTRL1?
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054):
gpmi_begin()HW_GPMI_TIMING0=0x00010101 HW_GPMI_TIMING1=0x90000000 HW_GPMI_CTRL1_SET=0x01c4800cThe read/write delay fields seem to match, but there are a few more fields set in this version:
-DECOUPLE_CS
-BCH_MODE
-DEV_RESET
-CTRL1_ATA_IRQRDY_POLARITY__ACTIVEHIGH
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Looks like those fields are not explicitly set in the
gpmi_begin()patch, but maybe you dumped CTRL1. Would you mind sharing your patch?Attached.
Hm, you should read CTRL1 instead of
CTRL1_SETwhich I guess is WO.
Here is 2 sets of trace dumping the same set of registers. This first is on the linux-4.16 kernel:
Linux version 4.16.0 (gerg@goober) (gcc version 4.8.3 (GCC)) #9 Mon Aug 12 10:46:25 AEST 2019
...
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: use legacy bch geometry
gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1110): gpmi_begin()
HW_GPMI_TIMING0=0x00010101
HW_GPMI_TIMING1=0x90000000
HW_GPMI_CTRL1=0x01c6800c
r->clock[0]=99000000
Scanning device for bad blocks
5 ofpart partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...
And then this is from the 5.1.14 kernel:
Linux version 5.1.14 (gerg@goober) (gcc version 4.8.3 (GCC)) #25 Mon Aug 12 10:49:21 AEST 2019
...
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(510): gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00020101
HW_GPMI_TIMING1=0xb0000000
HW_GPMI_CTRL1=0x0104000c
r->clock[0]=22000000
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(510): gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00010101
HW_GPMI_TIMING1=0xe0000000
HW_GPMI_CTRL1=0x01c6800c
r->clock[0]=99000000
Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
Register settings read back from the registers themselves at the end of the respective setting routines (so gpmi_begin() for 4.16 and gpmi_nfc_apply_timings() for 5.1.14)
So something I notice here is that gpmi_nfc_apply_timings() is being run multiple times. When I look back to the original failure dumps the first error ("DMA timeout, last DMA") occurred after the device type messages ("nand: 256 MiB, SLC,..."). Is it happening with that higher clock rate still set?
Regards
Greg
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 174 lines · Greg Ungerer
Quoted 106 lines · Boris Brezillon
Quoted 104 lines · On Fri, 9 Aug 2019 23:57:08 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 103 lines · Boris Brezillon
Quoted 87 lines · On Fri, 9 Aug 2019 16:55:22 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 86 lines · Boris Brezillon
Quoted 63 lines · On Fri, 9 Aug 2019 15:20:52 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 49 lines · Boris Brezillon
Quoted 47 lines · On Mon, 5 Aug 2019 15:51:05 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 45 lines · Boris Brezillon
Quoted 36 lines · On Fri, 2 Aug 2019 22:34:57 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 21 lines · Boris Brezillon
Quoted 10 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
On 30/7/19 6:38 pm, Miquel Raynal wrote:
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
On 30/7/19 10:41 am, Greg Ungerer wrote:
On 30/7/19 10:28 am, Greg Ungerer wrote:
On 29/7/19 10:47 pm, Miquel Raynal wrote:
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
On 29/7/19 6:36 pm, Miquel Raynal wrote:
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Note that this was generated on a normal boot up (not failure).The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) writel(hw->ctrl1n, gpmi_regs + HW_GPMI_CTRL1_SET);drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 727
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-4/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us = USEC_PER_SEC / hw->clk_rate * 64; - if (!dll_wait_time_us) - dll_wait_time_us = 1; + dll_wait_time_us = DIV_ROUND_UP(USEC_PER_SEC * 64, hw->clk_rate); /* Wait for the DLL to settle. */ - udelay(dll_wait_time_us); + usleep_range(dll_wait_time_us, dll_wait_time_us * 10); } static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Quoted 2 lines
Note also that I had to hand merge the changes, since in 5.1.14 that
gpmi_nfc_apply_timings()is ingpmi-lib.c. But it was trivial to do.Oh well. I guess the next thing to do would be to dump the timing regs and clk rate that are set by the bootloader (before the driver override them) or those applied by an older kernel (one that didn't have that issue).
Quoted 5 lines
Quoted 1 line
Is this useful?
Hm, looks like it's configured in mode 0, so no, it's not super useful. Can you try booting an older kernel (one that didn't have the ->setup_data_interface() hook implemented).
Ok. I went back from 5.1 and the first kernel I could find that returned no grep hits for "
setup_data_interface" was 4.16.So I built for my target with that and added similar trace to dump the hardware register settings for that. Debug output looks like this now for it:
Quoted 14 lines
...
drivers/mtd/nand/gpmi-nand/gpmi-nand.c(807):gpmi_get_clks()clk_get_rate(r->clock[0])=22000000 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054):gpmi_begin()HW_GPMI_TIMING0=0x00010203
HW_GPMI_TIMING1=0x05000000
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(966):enable_edo_mode()clk_get_rate(r->clock[0])=99000000
gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054):gpmi_begin()HW_GPMI_TIMING0=0x00010101TIMING0 match the one you have with 5.1 kernels.
Quoted 1 line
HW_GPMI_TIMING1=0x90000000
And we even have a bigger timeout value in 5.1 (
0xe0000000), so we should be all safe WRT to timings in TIMING{0,1}.Quoted 6 lines
Quoted 1 line
Can you dump CTRL1?
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054):
gpmi_begin()HW_GPMI_TIMING0=0x00010101 HW_GPMI_TIMING1=0x90000000 HW_GPMI_CTRL1_SET=0x01c4800cThe read/write delay fields seem to match, but there are a few more fields set in this version:
-DECOUPLE_CS
-BCH_MODE
-DEV_RESET
-CTRL1_ATA_IRQRDY_POLARITY__ACTIVEHIGHQuoted 6 lines
Quoted 4 lines
Quoted 2 lines
Looks like those fields are not explicitly set in the
gpmi_begin()patch, but maybe you dumped CTRL1. Would you mind sharing your patch?Attached.
Hm, you should read CTRL1 instead of
CTRL1_SETwhich I guess is WO.Here is 2 sets of trace dumping the same set of registers. This first is on the linux-4.16 kernel:
Linux version 4.16.0 (gerg@goober) (gcc version 4.8.3 (GCC)) #9 Mon Aug 12 10:46:25 AEST 2019
...
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: use legacy bch geometry
gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1110):gpmi_begin()
HW_GPMI_TIMING0=0x00010101
HW_GPMI_TIMING1=0x90000000
HW_GPMI_CTRL1=0x01c6800c
r->clock[0]=99000000
Scanning device for bad blocks
5 ofpart partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...And then this is from the 5.1.14 kernel:
Linux version 5.1.14 (gerg@goober) (gcc version 4.8.3 (GCC)) #25 Mon Aug 12 10:49:21 AEST 2019
...
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(510):gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00020101
HW_GPMI_TIMING1=0xb0000000
HW_GPMI_CTRL1=0x0104000c
r->clock[0]=22000000
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(510):gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00010101
HW_GPMI_TIMING1=0xe0000000
HW_GPMI_CTRL1=0x01c6800c
r->clock[0]=99000000
Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.Register settings read back from the registers themselves at the end of the respective setting routines (so
gpmi_begin()for 4.16 andgpmi_nfc_apply_timings()for 5.1.14)
Quoted 5 lines
So something I notice here is that
gpmi_nfc_apply_timings()is being run multiple times. When I look back to the original failure dumps the first error ("DMA timeout, last DMA") occurred after the device type messages ("nand: 256 MiB, SLC,..."). Is it happening with that higher clock rate still set?
Looks like that is not the case...
...
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(510): gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00020101
HW_GPMI_TIMING1=0xb0000000
HW_GPMI_CTRL1=0x0104000c
r->clock[0]=22000000
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(510): gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00010101
HW_GPMI_TIMING1=0xe0000000
HW_GPMI_CTRL1=0x01c6800c
r->clock[0]=99000000
gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA
gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset 0x000 : 0x20830002 gpmi-nand 1806000.gpmi-nand: offset 0x010 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x020 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x030 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x040 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x050 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x060 : 0x01c6800c gpmi-nand 1806000.gpmi-nand: offset 0x070 : 0x00010101 gpmi-nand 1806000.gpmi-nand: offset 0x080 : 0xe0000000 gpmi-nand 1806000.gpmi-nand: offset 0x090 : 0x23023336 gpmi-nand 1806000.gpmi-nand: offset 0x0a0 : 0x000001ee gpmi-nand 1806000.gpmi-nand: offset 0x0b0 : 0xff000001 gpmi-nand 1806000.gpmi-nand: offset 0x0c0 : 0x00000100 gpmi-nand 1806000.gpmi-nand: offset 0x0d0 : 0x05020000 gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset 0x000 : 0x00000100 gpmi-nand 1806000.gpmi-nand: offset 0x010 : 0x00000010 gpmi-nand 1806000.gpmi-nand: offset 0x020 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x030 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x040 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x050 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x060 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x070 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x080 : 0x030a2080 gpmi-nand 1806000.gpmi-nand: offset 0x090 : 0x083e2080 gpmi-nand 1806000.gpmi-nand: offset 0x0a0 : 0x070a4080 gpmi-nand 1806000.gpmi-nand: offset 0x0b0 : 0x10da4080 gpmi-nand 1806000.gpmi-nand: offset 0x0c0 : 0x070a4080 gpmi-nand 1806000.gpmi-nand: offset 0x0d0 : 0x10da4080 gpmi-nand 1806000.gpmi-nand: offset 0x0e0 : 0x070a4080 gpmi-nand 1806000.gpmi-nand: offset 0x0f0 : 0x10da4080 gpmi-nand 1806000.gpmi-nand: offset 0x100 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x110 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x120 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x130 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x140 : 0x00000000 gpmi-nand 1806000.gpmi-nand: offset 0x150 : 0x20484342 gpmi-nand 1806000.gpmi-nand: offset 0x160 : 0x01000000 gpmi-nand 1806000.gpmi-nand: offset 0x170 : 0x00000000
Regards
Greg
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 176 lines · On Mon, 12 Aug 2019 12:50:36 +1000 Greg Ungerer <[email protected]> wrote:
Hi Boris,
Quoted 110 lines · Boris Brezillon
Quoted 108 lines · On Fri, 9 Aug 2019 23:57:08 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 107 lines · Boris Brezillon
Quoted 91 lines · On Fri, 9 Aug 2019 16:55:22 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 90 lines · Boris Brezillon
Quoted 72 lines · On Fri, 9 Aug 2019 15:20:52 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 52 lines · Boris Brezillon
Quoted 50 lines · On Mon, 5 Aug 2019 15:51:05 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 48 lines · Boris Brezillon
Quoted 34 lines · On Fri, 2 Aug 2019 22:34:57 +1000 Greg Ungerer <[email protected]> wrote:
Quoted 33 lines · Boris Brezillon
Quoted 10 lines · On Wed, 31 Jul 2019 12:05:44 +1000 Greg Ungerer <[email protected]> wrote:
On 30/7/19 6:38 pm, Miquel Raynal wrote:
Greg Ungerer <[email protected]> wrote on Tue, 30 Jul 2019 16:06:55 +1000:
On 30/7/19 10:41 am, Greg Ungerer wrote:
On 30/7/19 10:28 am, Greg Ungerer wrote:
On 29/7/19 10:47 pm, Miquel Raynal wrote:
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 22:33:56 +1000:
On 29/7/19 6:36 pm, Miquel Raynal wrote:
Greg Ungerer <[email protected]> wrote on Mon, 29 Jul 2019 16:41:51 +1000:
[snip]
Note that this was generated on a normal boot up (not failure).The values looks good. Can you try with the below diff applied? --->8---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-4@@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)writel (hw->ctrl1n, gpmi_regs +HW_GPMI_CTRL1_SET );/* Wait 64 clock cycles before using the GPMI after enabling the DLL */ - dll_wait_time_us =USEC_PER_SEC / hw->clk_rate *64 ; -if (!dll_wait_time_us) - dll_wait_time_us =1 ; + dll_wait_time_us =DIV_ROUND_UP (USEC_PER_SEC *64 , hw->clk_rate);/* Wait for the DLL to settle. */ -udelay (dll_wait_time_us); +usleep_range (dll_wait_time_us, dll_wait_time_us *10 ); }Quoted 7 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) · line 730
Quoted 1 line
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr,Eventually it failed, in the same way with with same errors. Took quite a while, over 600 boot cycles.
Note also that I had to hand merge the changes, since in 5.1.14 that
gpmi_nfc_apply_timings()is ingpmi-lib.c. But it was trivial to do.Oh well. I guess the next thing to do would be to dump the timing regs and clk rate that are set by the bootloader (before the driver override them) or those applied by an older kernel (one that didn't have that issue).
Quoted 5 lines
Quoted 1 line
Is this useful?
Hm, looks like it's configured in mode 0, so no, it's not super useful. Can you try booting an older kernel (one that didn't have the ->setup_data_interface() hook implemented).
Ok. I went back from 5.1 and the first kernel I could find that returned no grep hits for "
setup_data_interface" was 4.16.So I built for my target with that and added similar trace to dump the hardware register settings for that. Debug output looks like this now for it:
...
drivers/mtd/nand/gpmi-nand/gpmi-nand.c(807):gpmi_get_clks()clk_get_rate(r->clock[0])=22000000 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin() HW_GPMI_TIMING0=0x00010203 HW_GPMI_TIMING1=0x05000000Quoted 8 lines
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(966):enable_edo_mode()clk_get_rate(r->clock[0])=99000000 gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054): gpmi_begin() HW_GPMI_TIMING0=0x00010101TIMING0 match the one you have with 5.1 kernels.
Quoted 1 line
HW_GPMI_TIMING1=0x90000000And we even have a bigger timeout value in 5.1 (
0xe0000000), so we should be all safe WRT to timings in TIMING{0,1}.Quoted 6 lines
Quoted 1 line
Can you dump CTRL1?
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1054):
gpmi_begin()HW_GPMI_TIMING0=0x00010101 HW_GPMI_TIMING1=0x90000000 HW_GPMI_CTRL1_SET=0x01c4800cThe read/write delay fields seem to match, but there are a few more fields set in this version:
-DECOUPLE_CS
-BCH_MODE
-DEV_RESET
-CTRL1_ATA_IRQRDY_POLARITY__ACTIVEHIGHQuoted 6 lines
Quoted 4 lines
Quoted 2 lines
Looks like those fields are not explicitly set in the
gpmi_begin()patch, but maybe you dumped CTRL1. Would you mind sharing your patch?Attached.
Hm, you should read CTRL1 instead of
CTRL1_SETwhich I guess is WO.Here is 2 sets of trace dumping the same set of registers. This first is on the linux-4.16 kernel:
Linux version 4.16.0 (gerg@goober) (gcc version 4.8.3 (GCC)) #9 Mon Aug 12 10:46:25 AEST 2019
...
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: use legacy bch geometry
gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1110):gpmi_begin()
HW_GPMI_TIMING0=0x00010101
HW_GPMI_TIMING1=0x90000000
HW_GPMI_CTRL1=0x01c6800c
r->clock[0]=99000000
Scanning device for bad blocks
5 ofpart partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...And then this is from the 5.1.14 kernel:
Linux version 5.1.14 (gerg@goober) (gcc version 4.8.3 (GCC)) #25 Mon Aug 12 10:49:21 AEST 2019
...
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(510):gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00020101
HW_GPMI_TIMING1=0xb0000000
HW_GPMI_CTRL1=0x0104000c
r->clock[0]=22000000
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(510):gpmi_nfc_apply_timings()
HW_GPMI_TIMING0=0x00010101
HW_GPMI_TIMING1=0xe0000000
HW_GPMI_CTRL1=0x01c6800c
r->clock[0]=99000000
Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
Quoted 3 lines
Register settings read back from the registers themselves at the end of the respective setting routines (so
gpmi_begin()for 4.16 andgpmi_nfc_apply_timings()for 5.1.14)
Hm, CTRL1 is identical. Can you dump all regs at the beginning and at the end of those funcs?
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Boris,
Quoted 1 line · Boris Brezillon
On Mon, 12 Aug 2019 12:50:36 +1000
[snip]
Quoted 2 lines
Hm, CTRL1 is identical. Can you dump all regs at the beginning and at the end of those funcs?
Here is a more complete dump of registers. Trace points are at entry and exit of the respective functions in the different kernel versions. Register dumping code is identical for both.
Linux version 4.16.0 (gerg@goober) (gcc version 4.8.3 (GCC)) #10 Tue Aug 13 10:24:28 AEST 2019
...
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1073): gpmi_begin(): ENTRY
HW_GPMI_CTRL0=0x00000000
HW_GPMI_CTRL1=0x01c4000c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000400
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00010203
HW_GPMI_TIMING1=0x00000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x00000000
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000000
r->clock[0]=22000000
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1073): gpmi_begin(): ENTRY
HW_GPMI_CTRL0=0x01800001
HW_GPMI_CTRL1=0x0104000c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000000
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00010203
HW_GPMI_TIMING1=0x05000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x00000000
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000101
r->clock[0]=99000000
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1136): gpmi_begin(): EXIT
HW_GPMI_CTRL0=0x01800001
HW_GPMI_CTRL1=0x01c6800c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000000
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00010101
HW_GPMI_TIMING1=0x90000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x00000000
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000101
r->clock[0]=99000000
Scanning device for bad blocks
5 ofpart partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...
Note that the first ENTRY dump has no matching EXIT dump. From the code I assume it is returning from gpmi_begin() at the "if (!hw.sample_delay_factor)" check.
And for the 5.1.14 kernel:
Linux version 5.1.14 (gerg@goober) (gcc version 4.8.3 (GCC)) #27 Tue Aug 13 10:20:32 AEST 2019
...
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(512): gpmi_nfc_apply_timings(): ENTRY
HW_GPMI_CTRL0=0x00000000
HW_GPMI_CTRL1=0x01c4000c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000400
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00010203
HW_GPMI_TIMING1=0x00000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x00000000
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000000
r->clock[0]=22000000
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(536): gpmi_nfc_apply_timings(): EXIT
HW_GPMI_CTRL0=0x00000000
HW_GPMI_CTRL1=0x0104000c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000400
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00020101
HW_GPMI_TIMING1=0x60000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x00000000
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000000
r->clock[0]=22000000
random: fast init done
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(512): gpmi_nfc_apply_timings(): ENTRY
HW_GPMI_CTRL0=0x01800001
HW_GPMI_CTRL1=0x0104000c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000000
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00020101
HW_GPMI_TIMING1=0x60000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x0000003f
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000101
r->clock[0]=22000000
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(536): gpmi_nfc_apply_timings(): EXIT
HW_GPMI_CTRL0=0x01800001
HW_GPMI_CTRL1=0x0104000c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000000
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00020101
HW_GPMI_TIMING1=0xb0000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x0000003f
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000101
r->clock[0]=22000000
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(512): gpmi_nfc_apply_timings(): ENTRY
HW_GPMI_CTRL0=0x01800001
HW_GPMI_CTRL1=0x0104000c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000000
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00020101
HW_GPMI_TIMING1=0xb0000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x000000e0
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000000
r->clock[0]=22000000
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(536): gpmi_nfc_apply_timings(): EXIT
HW_GPMI_CTRL0=0x01800001
HW_GPMI_CTRL1=0x01c6800c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000000
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00010101
HW_GPMI_TIMING1=0xe0000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x000000e0
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000000
r->clock[0]=99000000
Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...
Regards
Greg
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Greg
Quoted 9 lines · Greg Ungerer
Hi Boris,
Quoted 1 line · Boris Brezillon
On Mon, 12 Aug 2019 12:50:36 +1000
[snip]
Quoted 2 lines
Hm, CTRL1 is identical. Can you dump all regs at the beginning and at the end of those funcs?
Quoted 7 lines
Here is a more complete dump of registers. Trace points are at entry and exit of the respective functions in the different kernel versions. Register dumping code is identical for both.
Linux version 4.16.0 (gerg@goober) (gcc version 4.8.3 (GCC)) #10 Tue Aug 13 10:24:28 AEST 2019
...
I ran an overnight reboot process on linux-4.19.y tag: v4.19.169 and I'm not able to reproduce up to now.
Do you have an update from your side?
Michael
Quoted 179 lines
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1073):
gpmi_begin(): ENTRY
HW_GPMI_CTRL0=0x00000000
HW_GPMI_CTRL1=0x01c4000c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000400
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00010203
HW_GPMI_TIMING1=0x00000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x00000000
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000000
r->clock[0]=22000000
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1073):gpmi_begin(): ENTRY
HW_GPMI_CTRL0=0x01800001
HW_GPMI_CTRL1=0x0104000c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000000
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00010203
HW_GPMI_TIMING1=0x05000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x00000000
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000101
r->clock[0]=99000000
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1136):gpmi_begin(): EXIT
HW_GPMI_CTRL0=0x01800001
HW_GPMI_CTRL1=0x01c6800c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000000
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00010101
HW_GPMI_TIMING1=0x90000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x00000000
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000101
r->clock[0]=99000000
Scanning device for bad blocks
5 ofpart partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...Note that the first ENTRY dump has no matching EXIT dump. From the code I assume it is returning from
gpmi_begin()at the "if (!hw.sample_delay_factor)" check.And for the 5.1.14 kernel:
Linux version 5.1.14 (gerg@goober) (gcc version 4.8.3 (GCC)) #27 Tue Aug 13 10:20:32 AEST 2019
...
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(512):gpmi_nfc_apply_timings(): ENTRY
HW_GPMI_CTRL0=0x00000000
HW_GPMI_CTRL1=0x01c4000c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000400
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00010203
HW_GPMI_TIMING1=0x00000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x00000000
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000000
r->clock[0]=22000000
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(536):gpmi_nfc_apply_timings(): EXIT
HW_GPMI_CTRL0=0x00000000
HW_GPMI_CTRL1=0x0104000c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000400
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00020101
HW_GPMI_TIMING1=0x60000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x00000000
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000000
r->clock[0]=22000000
random: fast init done
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(512):gpmi_nfc_apply_timings(): ENTRY
HW_GPMI_CTRL0=0x01800001
HW_GPMI_CTRL1=0x0104000c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000000
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00020101
HW_GPMI_TIMING1=0x60000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x0000003f
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000101
r->clock[0]=22000000
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(536):gpmi_nfc_apply_timings(): EXIT
HW_GPMI_CTRL0=0x01800001
HW_GPMI_CTRL1=0x0104000c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000000
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00020101
HW_GPMI_TIMING1=0xb0000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x0000003f
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000101
r->clock[0]=22000000
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(512):gpmi_nfc_apply_timings(): ENTRY
HW_GPMI_CTRL0=0x01800001
HW_GPMI_CTRL1=0x0104000c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000000
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00020101
HW_GPMI_TIMING1=0xb0000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x000000e0
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000000
r->clock[0]=22000000
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(536):gpmi_nfc_apply_timings(): EXIT
HW_GPMI_CTRL0=0x01800001
HW_GPMI_CTRL1=0x01c6800c
HW_GPMI_COMPARE=0x00000000
HW_GPMI_ECCCTRL=0x00000000
HW_GPMI_ECCCOUNT=0x00000000
HW_GPMI_PAYLOAD=0x00000000
HW_GPMI_AUXILIARY=0x00000000
HW_GPMI_TIMING0=0x00010101
HW_GPMI_TIMING1=0xe0000000
HW_GPMI_TIMING2=0x23023336
HW_GPMI_DATA=0x000000e0
HW_GPMI_STAT=0xff000005
HW_GPMI_DEBUG=0x00000000
r->clock[0]=99000000
Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...Regards
Greg
Signature · 11 lines
Michael Nazzareno Trimarchi Amarula Solutions BV COO Co-Founder Cruquiuskade 47 Amsterdam 1018 AM NL T. +31(0)851119172 M. +39(0)3479132170 [`as] https://www.amarulasolutions.com ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Thu, 28 Jan 2021 10:45:29 +0100:
Quoted 17 lines
Hi Greg
Quoted 14 lines · Greg Ungerer
Hi Boris,
Quoted 1 line · Boris Brezillon
On Mon, 12 Aug 2019 12:50:36 +1000
[snip]
Quoted 2 lines
Hm, CTRL1 is identical. Can you dump all regs at the beginning and at the end of those funcs?
Here is a more complete dump of registers. Trace points are at entry and exit of the respective functions in the different kernel versions. Register dumping code is identical for both.
Quoted 7 lines
Quoted 2 lines
Linux version 4.16.0 (gerg@goober) (gcc version 4.8.3 (GCC)) #10 Tue Aug 13 10:24:28 AEST 2019
...I ran an overnight reboot process on linux-4.19.y tag: v4.19.169 and I'm not able to reproduce up to now.
Do you have an update from your side?
Perhaps this patch [1] was backported to v4.19.169 (I didn't check) but it might have fixed the DMA issue you were seeing, at least in the recent kernel versions.
[1] mtd: rawnand: gpmi: Fix the random DMA timeout issue
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi
Quoted 26 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Thu, 28 Jan 2021 10:45:29 +0100:
Quoted 20 lines
Hi Greg
Quoted 16 lines · Greg Ungerer
Hi Boris,
Quoted 1 line · Boris Brezillon
On Mon, 12 Aug 2019 12:50:36 +1000
[snip]
Quoted 2 lines
Hm, CTRL1 is identical. Can you dump all regs at the beginning and at the end of those funcs?
Here is a more complete dump of registers. Trace points are at entry and exit of the respective functions in the different kernel versions. Register dumping code is identical for both.
Linux version 4.16.0 (gerg@goober) (gcc version 4.8.3 (GCC)) #10 Tue Aug 13 10:24:28 AEST 2019
...
Quoted 8 lines
Quoted 4 lines
I ran an overnight reboot process on linux-4.19.y tag: v4.19.169 and I'm not able to reproduce up to now.
Do you have an update from your side?
Perhaps this patch [1] was backported to v4.19.169 (I didn't check) but it might have fixed the DMA issue you were seeing, at least in the recent kernel versions.
It's not there and should not go because this patch fixes another regression. Apply
it means apply anyway both.
I will decode the registers on those thread and check the difference
Michael
Quoted 5 lines
[1] mtd: rawnand: gpmi: Fix the random DMA timeout issue
Thanks,
Miquèl
Signature · 11 lines
Michael Nazzareno Trimarchi Amarula Solutions BV COO Co-Founder Cruquiuskade 47 Amsterdam 1018 AM NL T. +31(0)851119172 M. +39(0)3479132170 [`as] https://www.amarulasolutions.com ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi
I have a couple of questions
Quoted 36 lines · Michael Nazzareno Trimarchi
Hi
Quoted 31 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Thu, 28 Jan 2021 10:45:29 +0100:
Quoted 24 lines
Hi Greg
Quoted 9 lines · Greg Ungerer
Hi Boris,
Quoted 1 line · Boris Brezillon
On Mon, 12 Aug 2019 12:50:36 +1000
[snip]
Quoted 2 lines
Hm, CTRL1 is identical. Can you dump all regs at the beginning and at the end of those funcs?
Quoted 7 lines
Here is a more complete dump of registers. Trace points are at entry and exit of the respective functions in the different kernel versions. Register dumping code is identical for both.
Linux version 4.16.0 (gerg@goober) (gcc version 4.8.3 (GCC)) #10 Tue Aug 13 10:24:28 AEST 2019
...I ran an overnight reboot process on linux-4.19.y tag: v4.19.169 and I'm not able to reproduce up to now.
Do you have an update from your side?
Quoted 9 lines
Quoted 3 lines
Perhaps this patch [1] was backported to v4.19.169 (I didn't check) but it might have fixed the DMA issue you were seeing, at least in the recent kernel versions.
It's not there and should not go because this patch fixes another regression. Apply
it means apply anyway both.
I will decode the registers on those thread and check the difference
maxchips is 2 for IMX6 and I think that is connected to NAND_CE0_B and NAND_CE1_B, When
we probe I think both are probed. Is that right?
Michael
Quoted 18 lines
Michae
Quoted 5 lines
[1] mtd: rawnand: gpmi: Fix the random DMA timeout issue
Thanks,
Miquèl--
Michael Nazzareno Trimarchi
Amarula Solutions BV
COO Co-Founder
Cruquiuskade 47 Amsterdam 1018 AM NL
T. +31(0)851119172
M. +39(0)3479132170
[`as] https://www.amarulasolutions.com
Signature · 11 lines
Michael Nazzareno Trimarchi Amarula Solutions BV COO Co-Founder Cruquiuskade 47 Amsterdam 1018 AM NL T. +31(0)851119172 M. +39(0)3479132170 [`as] https://www.amarulasolutions.com ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Michael,
Quoted 17 lines · Michael Nazzareno Trimarchi
Hi Greg
Quoted 14 lines · Greg Ungerer
Hi Boris,
Quoted 1 line · Boris Brezillon
On Mon, 12 Aug 2019 12:50:36 +1000
[snip]
Quoted 2 lines
Hm, CTRL1 is identical. Can you dump all regs at the beginning and at the end of those funcs?
Here is a more complete dump of registers. Trace points are at entry and exit of the respective functions in the different kernel versions. Register dumping code is identical for both.
Quoted 7 lines
Quoted 2 lines
Linux version 4.16.0 (gerg@goober) (gcc version 4.8.3 (GCC)) #10 Tue Aug 13 10:24:28 AEST 2019
...I ran an overnight reboot process on linux-4.19.y tag: v4.19.169 and I'm not able to reproduce up to now.
Do you have an update from your side?
I haven't seen the problem for a while now.
I pretty much only run modern kernels, I am currently using 5.10. So I am guessing it was resolved somewhere at some point, but I don't know exactly what change resolved it.
Regards
Greg
Quoted 175 lines
Quoted 175 lines
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1073):
gpmi_begin(): ENTRYHW_GPMI_CTRL0=0x00000000 HW_GPMI_CTRL1=0x01c4000c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000400 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00010203 HW_GPMI_TIMING1=0x00000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x00000000 HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000000 r->clock[0]=22000000nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1073):gpmi_begin(): ENTRYHW_GPMI_CTRL0=0x01800001 HW_GPMI_CTRL1=0x0104000c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000000 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00010203 HW_GPMI_TIMING1=0x05000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x00000000 HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000101 r->clock[0]=99000000 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1136): gpmi_begin(): EXIT HW_GPMI_CTRL0=0x01800001 HW_GPMI_CTRL1=0x01c6800c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000000 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00010101 HW_GPMI_TIMING1=0x90000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x00000000 HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000101 r->clock[0]=99000000Scanning device for bad blocks
5 ofpart partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...Note that the first ENTRY dump has no matching EXIT dump. From the code I assume it is returning from
gpmi_begin()at the "if (!hw.sample_delay_factor)" check.And for the 5.1.14 kernel:
Linux version 5.1.14 (gerg@goober) (gcc version 4.8.3 (GCC)) #27 Tue Aug 13 10:20:32 AEST 2019
...
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(512):gpmi_nfc_apply_timings(): ENTRYHW_GPMI_CTRL0=0x00000000 HW_GPMI_CTRL1=0x01c4000c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000400 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00010203 HW_GPMI_TIMING1=0x00000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x00000000 HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000000 r->clock[0]=22000000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(536): gpmi_nfc_apply_timings(): EXIT HW_GPMI_CTRL0=0x00000000 HW_GPMI_CTRL1=0x0104000c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000400 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00020101 HW_GPMI_TIMING1=0x60000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x00000000 HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000000 r->clock[0]=22000000random: fast init done
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(512):gpmi_nfc_apply_timings(): ENTRYHW_GPMI_CTRL0=0x01800001 HW_GPMI_CTRL1=0x0104000c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000000 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00020101 HW_GPMI_TIMING1=0x60000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x0000003f HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000101 r->clock[0]=22000000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(536): gpmi_nfc_apply_timings(): EXIT HW_GPMI_CTRL0=0x01800001 HW_GPMI_CTRL1=0x0104000c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000000 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00020101 HW_GPMI_TIMING1=0xb0000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x0000003f HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000101 r->clock[0]=22000000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(512): gpmi_nfc_apply_timings(): ENTRY HW_GPMI_CTRL0=0x01800001 HW_GPMI_CTRL1=0x0104000c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000000 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00020101 HW_GPMI_TIMING1=0xb0000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x000000e0 HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000000 r->clock[0]=22000000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(536): gpmi_nfc_apply_timings(): EXIT HW_GPMI_CTRL0=0x01800001 HW_GPMI_CTRL1=0x01c6800c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000000 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00010101 HW_GPMI_TIMING1=0xe0000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x000000e0 HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000000 r->clock[0]=99000000Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...
Quoted 6 lines
Quoted 4 lines
Regards
Greg
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Miquel
commit f8e6ad14388067f91b26d044185d95623fbc9535
Author: Michael Trimarchi <[email protected]> Date: Fri Jan 29 08:46:53 2021 +0100
mtd: nand: Calculate the clock before enable it
(quoted diff) +0 -0
b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
index 322a008290e5..0bca52b3bc8f 100644
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +0 -0
@@ -377,6 +377,7 @@ static void gpmi_nfc_compute_timings(struct
gpmi_nand_data *this,
const struct nand_sdr_timings *sdr)
{
struct gpmi_nfc_hardware_timing *hw = &this->hw;
+ struct resources *r = &this->resources;
unsigned int dll_threshold_ps = this->devdata->max_chain_delay;
unsigned int period_ps, reference_period_ps;
unsigned int data_setup_cycles, data_hold_cycles, addr_setup_cycles;
@@ -440,6 +441,8 @@ static void gpmi_nfc_compute_timings(struct
gpmi_nand_data *this,
hw->ctrl1n |= BF_GPMI_CTRL1_RDN_DELAY(sample_delay_factor) |
BM_GPMI_CTRL1_DLL_ENABLE |
(use_half_period ? BM_GPMI_CTRL1_HALF_PERIOD : 0);+
+ clk_set_rate(r->clock[0], hw->clk_rate);
}
void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)
@@ -449,8 +452,6 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)
void __iomem *gpmi_regs = r->gpmi_regs;
unsigned int dll_wait_time_us;- clk_set_rate(r->clock[0], hw->clk_rate);
-
writel(hw->timing0, gpmi_regs + HW_GPMI_TIMING0);
writel(hw->timing1, gpmi_regs + HW_GPMI_TIMING1);Right now I have this change applied and seems fine. That is the only difference I get. Clock is apply a bit earlier that when is enabled it.
Michael
Quoted 220 lines · Greg Ungerer
Hi Michael,
Quoted 17 lines · Michael Nazzareno Trimarchi
Hi Greg
Quoted 14 lines · Greg Ungerer
Hi Boris,
Quoted 1 line · Boris Brezillon
On Mon, 12 Aug 2019 12:50:36 +1000
[snip]
Quoted 2 lines
Hm, CTRL1 is identical. Can you dump all regs at the beginning and at the end of those funcs?
Here is a more complete dump of registers. Trace points are at entry and exit of the respective functions in the different kernel versions. Register dumping code is identical for both.
Quoted 7 lines
Quoted 2 lines
Linux version 4.16.0 (gerg@goober) (gcc version 4.8.3 (GCC)) #10 Tue Aug 13 10:24:28 AEST 2019
...I ran an overnight reboot process on linux-4.19.y tag: v4.19.169 and I'm not able to reproduce up to now.
Do you have an update from your side?
I haven't seen the problem for a while now.
I pretty much only run modern kernels, I am currently using 5.10. So I am guessing it was resolved somewhere at some point, but I don't know exactly what change resolved it.Regards
GregQuoted 181 lines
Quoted 179 lines
drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1073):
gpmi_begin(): ENTRYHW_GPMI_CTRL0=0x00000000 HW_GPMI_CTRL1=0x01c4000c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000400 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00010203 HW_GPMI_TIMING1=0x00000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x00000000 HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000000 r->clock[0]=22000000nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: enable the asynchronous EDO mode 5 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1073):gpmi_begin(): ENTRYHW_GPMI_CTRL0=0x01800001 HW_GPMI_CTRL1=0x0104000c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000000 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00010203 HW_GPMI_TIMING1=0x05000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x00000000 HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000101 r->clock[0]=99000000 drivers/mtd/nand/gpmi-nand/gpmi-lib.c(1136): gpmi_begin(): EXIT HW_GPMI_CTRL0=0x01800001 HW_GPMI_CTRL1=0x01c6800c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000000 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00010101 HW_GPMI_TIMING1=0x90000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x00000000 HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000101 r->clock[0]=99000000Scanning device for bad blocks
5 ofpart partitions found on MTD device gpmi-nand
Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot"
0x000000500000-0x000000600000 : "u-boot-env"
0x000000600000-0x000000800000 : "log"
0x000000800000-0x000010000000 : "flash"
0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...Note that the first ENTRY dump has no matching EXIT dump. From the code I assume it is returning from
gpmi_begin()at the "if (!hw.sample_delay_factor)" check.And for the 5.1.14 kernel:
Linux version 5.1.14 (gerg@goober) (gcc version 4.8.3 (GCC)) #27 Tue Aug 13 10:20:32 AEST 2019
...
drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(512):gpmi_nfc_apply_timings(): ENTRYHW_GPMI_CTRL0=0x00000000 HW_GPMI_CTRL1=0x01c4000c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000400 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00010203 HW_GPMI_TIMING1=0x00000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x00000000 HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000000 r->clock[0]=22000000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(536): gpmi_nfc_apply_timings(): EXIT HW_GPMI_CTRL0=0x00000000 HW_GPMI_CTRL1=0x0104000c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000400 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00020101 HW_GPMI_TIMING1=0x60000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x00000000 HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000000 r->clock[0]=22000000random: fast init done
nand: device found, Manufacturer ID:0x2c, Chip ID:0xda
nand: Micron MT29F2G08ABAEAWP
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(512):gpmi_nfc_apply_timings(): ENTRYHW_GPMI_CTRL0=0x01800001 HW_GPMI_CTRL1=0x0104000c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000000 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00020101 HW_GPMI_TIMING1=0x60000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x0000003f HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000101 r->clock[0]=22000000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(536): gpmi_nfc_apply_timings(): EXIT HW_GPMI_CTRL0=0x01800001 HW_GPMI_CTRL1=0x0104000c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000000 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00020101 HW_GPMI_TIMING1=0xb0000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x0000003f HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000101 r->clock[0]=22000000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(512): gpmi_nfc_apply_timings(): ENTRY HW_GPMI_CTRL0=0x01800001 HW_GPMI_CTRL1=0x0104000c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000000 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00020101 HW_GPMI_TIMING1=0xb0000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x000000e0 HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000000 r->clock[0]=22000000 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(536): gpmi_nfc_apply_timings(): EXIT HW_GPMI_CTRL0=0x01800001 HW_GPMI_CTRL1=0x01c6800c HW_GPMI_COMPARE=0x00000000 HW_GPMI_ECCCTRL=0x00000000 HW_GPMI_ECCCOUNT=0x00000000 HW_GPMI_PAYLOAD=0x00000000 HW_GPMI_AUXILIARY=0x00000000 HW_GPMI_TIMING0=0x00010101 HW_GPMI_TIMING1=0xe0000000 HW_GPMI_TIMING2=0x23023336 HW_GPMI_DATA=0x000000e0 HW_GPMI_STAT=0xff000005 HW_GPMI_DEBUG=0x00000000 r->clock[0]=99000000Scanning device for bad blocks
5 fixed-partitions partitions found on MTD device gpmi-nand Creating 5 MTD partitions on "gpmi-nand":
0x000000000000-0x000000500000 : "u-boot" 0x000000500000-0x000000600000 : "u-boot-env" 0x000000600000-0x000000800000 : "log" 0x000000800000-0x000010000000 : "flash" 0x000000000000-0x000010000000 : "all"
gpmi-nand 1806000.gpmi-nand: driver registered.
...Regards
Greg
Signature · 11 lines
Michael Nazzareno Trimarchi Amarula Solutions BV COO Co-Founder Cruquiuskade 47 Amsterdam 1018 AM NL T. +31(0)851119172 M. +39(0)3479132170 [`as] https://www.amarulasolutions.com ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Sat, 30 Jan 2021 10:41:29 +0100:
Quoted 44 lines
Hi Miquel
commit
f8e6ad14388067f91b26d044185d95623fbc9535Author: Michael Trimarchi <[email protected]> Date: Fri Jan 29 08:46:53 2021 +0100mtd: nand: Calculate the clock before enable it
Signed-off-by Michael Trimarchi <[email protected]>Change-Id I79b0da39de0a9b32ea0b002fa200d7f44d4f8ce7drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +1
-0@@ -377,6 +377,7 @@ static void gpmi_nfc_compute_timings(structgpmi_nand_data *this, const struct nand_sdr_timings *sdr) { struct gpmi_nfc_hardware_timing *hw = &this->hw; +struct resources *r = &this->resources;unsigned int dll_threshold_ps = this->devdata->max_chain_delay;unsigned int period_ps, reference_period_ps;unsigned int data_setup_cycles, data_hold_cycles, addr_setup_cycles;drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -440,6 +441,8 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, hw->ctrl1n |=BF_GPMI_CTRL1_RDN_DELAY (sample_delay_factor) |BM_GPMI_CTRL1_DLL_ENABLE | (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); + +clk_set_rate (r->clock[0 ], hw->clk_rate); }void
gpmi_nfc_apply_timings(struct gpmi_nand_data *this)drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +0
-2@@ -449,8 +452,6 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; -clk_set_rate (r->clock[0 ], hw->clk_rate); -writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );
Quoted 3 lines
Right now I have this change applied and seems fine. That is the only difference I get. Clock is apply a bit earlier that when is enabled it.
This is very interesting. So this would mean the issue you are experiencing comes from the clock driver which kind of returns too early from clk_set_rate()? Could you report this to the clk ML/NXP clk maintainers and keep us in copy? If it is as global as it sounds, we might not be the only ones affected.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi
Quoted 50 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Sat, 30 Jan 2021 10:41:29 +0100:
Quoted 44 lines
Hi Miquel
commit
f8e6ad14388067f91b26d044185d95623fbc9535Author: Michael Trimarchi <[email protected]> Date: Fri Jan 29 08:46:53 2021 +0100mtd: nand: Calculate the clock before enable it
Signed-off-by Michael Trimarchi <[email protected]>Change-Id I79b0da39de0a9b32ea0b002fa200d7f44d4f8ce7drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +1
-0@@ -377,6 +377,7 @@ static void gpmi_nfc_compute_timings(structgpmi_nand_data *this, const struct nand_sdr_timings *sdr) { struct gpmi_nfc_hardware_timing *hw = &this->hw; +struct resources *r = &this->resources;unsigned int dll_threshold_ps = this->devdata->max_chain_delay;unsigned int period_ps, reference_period_ps;unsigned int data_setup_cycles, data_hold_cycles, addr_setup_cycles;drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -440,6 +441,8 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, hw->ctrl1n |=BF_GPMI_CTRL1_RDN_DELAY (sample_delay_factor) |BM_GPMI_CTRL1_DLL_ENABLE | (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); + +clk_set_rate (r->clock[0 ], hw->clk_rate); }void
gpmi_nfc_apply_timings(struct gpmi_nand_data *this)drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +0
-2@@ -449,8 +452,6 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; -clk_set_rate (r->clock[0 ], hw->clk_rate); -writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );
Quoted 10 lines
Quoted 3 lines
Right now I have this change applied and seems fine. That is the only difference I get. Clock is apply a bit earlier that when is enabled it.
This is very interesting. So this would mean the issue you are experiencing comes from the clock driver which kind of returns too early from
clk_set_rate()? Could you report this to the clk ML/NXP clk maintainers and keep us in copy? If it is as global as it sounds, we might not be the only ones affected.
The imx28 is broken too, so it's a general problem. I need to trace it down I have a reverting for lts but it\s not the way to go
Michael
Quoted 2 lines
Thanks,
Miquèl
Signature · 11 lines
Michael Nazzareno Trimarchi Amarula Solutions BV COO Co-Founder Cruquiuskade 47 Amsterdam 1018 AM NL T. +31(0)851119172 M. +39(0)3479132170 [`as] https://www.amarulasolutions.com ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi
Quoted 65 lines · Michael Nazzareno Trimarchi
Hi
Quoted 50 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Sat, 30 Jan 2021 10:41:29 +0100:
Quoted 44 lines
Hi Miquel
commit
f8e6ad14388067f91b26d044185d95623fbc9535Author: Michael Trimarchi <[email protected]> Date: Fri Jan 29 08:46:53 2021 +0100mtd: nand: Calculate the clock before enable it
Signed-off-by Michael Trimarchi <[email protected]>Change-Id I79b0da39de0a9b32ea0b002fa200d7f44d4f8ce7drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +1
-0@@ -377,6 +377,7 @@ static void gpmi_nfc_compute_timings(structgpmi_nand_data *this, const struct nand_sdr_timings *sdr) { struct gpmi_nfc_hardware_timing *hw = &this->hw; +struct resources *r = &this->resources;unsigned int dll_threshold_ps = this->devdata->max_chain_delay;unsigned int period_ps, reference_period_ps;unsigned int data_setup_cycles, data_hold_cycles, addr_setup_cycles;drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -440,6 +441,8 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, hw->ctrl1n |=BF_GPMI_CTRL1_RDN_DELAY (sample_delay_factor) |BM_GPMI_CTRL1_DLL_ENABLE | (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); + +clk_set_rate (r->clock[0 ], hw->clk_rate); }void
gpmi_nfc_apply_timings(struct gpmi_nand_data *this)drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +0
-2@@ -449,8 +452,6 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; -clk_set_rate (r->clock[0 ], hw->clk_rate); -writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );Quoted 10 lines
Quoted 3 lines
Right now I have this change applied and seems fine. That is the only difference I get. Clock is apply a bit earlier that when is enabled it.
This is very interesting. So this would mean the issue you are experiencing comes from the clock driver which kind of returns too early from
clk_set_rate()? Could you report this to the clk ML/NXP clk maintainers and keep us in copy? If it is as global as it sounds, we might not be the only ones affected.
Quoted 3 lines
The imx28 is broken too, so it's a general problem. I need to trace it down I have a reverting for lts but it\s not the way to go
For imx28 you ask to set the rate to 22Mhz but you don't care about the clock that you get back. You get back 12Mhz because the base clock is 24 Mhz and seems that it can not get the point. You need to check if the clock requested is in range or ask
for set_rate_clk_min to avoid to have somenthing lower. Then for imx6ull because is sporadic
I think that is more connected to the clk_set_rate and when you change the register. Can not be a
setting time?
Michael
Quoted 15 lines
Michael
Quoted 2 lines
Thanks,
Miquèl--
Michael Nazzareno Trimarchi
Amarula Solutions BV
COO Co-Founder
Cruquiuskade 47 Amsterdam 1018 AM NL
T. +31(0)851119172
M. +39(0)3479132170
[`as] https://www.amarulasolutions.com
Signature · 11 lines
Michael Nazzareno Trimarchi Amarula Solutions BV COO Co-Founder Cruquiuskade 47 Amsterdam 1018 AM NL T. +31(0)851119172 M. +39(0)3479132170 [`as] https://www.amarulasolutions.com ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Mon, 1 Feb 2021 16:08:23 +0100:
Quoted 73 lines
Hi
Quoted 65 lines · Michael Nazzareno Trimarchi
Hi
Quoted 50 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Sat, 30 Jan 2021 10:41:29 +0100:
Quoted 44 lines
Hi Miquel
commit
f8e6ad14388067f91b26d044185d95623fbc9535Author: Michael Trimarchi <[email protected]> Date: Fri Jan 29 08:46:53 2021 +0100mtd: nand: Calculate the clock before enable it
Signed-off-by Michael Trimarchi <[email protected]>Change-Id I79b0da39de0a9b32ea0b002fa200d7f44d4f8ce7drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +1
-0@@ -377,6 +377,7 @@ static void gpmi_nfc_compute_timings(structgpmi_nand_data *this, const struct nand_sdr_timings *sdr) { struct gpmi_nfc_hardware_timing *hw = &this->hw; +struct resources *r = &this->resources;unsigned int dll_threshold_ps = this->devdata->max_chain_delay;unsigned int period_ps, reference_period_ps;unsigned int data_setup_cycles, data_hold_cycles, addr_setup_cycles;drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -440,6 +441,8 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, hw->ctrl1n |=BF_GPMI_CTRL1_RDN_DELAY (sample_delay_factor) |BM_GPMI_CTRL1_DLL_ENABLE | (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); + +clk_set_rate (r->clock[0 ], hw->clk_rate); }void
gpmi_nfc_apply_timings(struct gpmi_nand_data *this)drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +0
-2@@ -449,8 +452,6 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; -clk_set_rate (r->clock[0 ], hw->clk_rate); -writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );Quoted 10 lines
Quoted 3 lines
Right now I have this change applied and seems fine. That is the only difference I get. Clock is apply a bit earlier that when is enabled it.
This is very interesting. So this would mean the issue you are experiencing comes from the clock driver which kind of returns too early from
clk_set_rate()? Could you report this to the clk ML/NXP clk maintainers and keep us in copy? If it is as global as it sounds, we might not be the only ones affected.Quoted 3 lines
The imx28 is broken too, so it's a general problem. I need to trace it down I have a reverting for lts but it\s not the way to go
Quoted 9 lines
For imx28 you ask to set the rate to 22Mhz but you don't care about the clock that you get back. You get back 12Mhz because the base clock is 24 Mhz and seems that it can not get the point. You need to check if the clock requested is in range or ask
forset_rate_clk_minto avoid to have somenthing lower. Then for imx6ull because is sporadic
I think that is more connected to theclk_set_rateand when you change the register. Can not be a
setting time?
So, if I understand correctly, we face two different problems:
- imx6*: seems like a clock issue regarding the clock settlement
- imx28: actual NAND driver issue (does not check the validity of the new frequency). This should be handled properly in ->setup_interface().
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi
Quoted 89 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Mon, 1 Feb 2021 16:08:23 +0100:
Quoted 73 lines
Hi
Quoted 65 lines · Michael Nazzareno Trimarchi
Hi
Quoted 50 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Sat, 30 Jan 2021 10:41:29 +0100:
Quoted 44 lines
Hi Miquel
commit
f8e6ad14388067f91b26d044185d95623fbc9535Author: Michael Trimarchi <[email protected]> Date: Fri Jan 29 08:46:53 2021 +0100mtd: nand: Calculate the clock before enable it
Signed-off-by Michael Trimarchi <[email protected]>Change-Id I79b0da39de0a9b32ea0b002fa200d7f44d4f8ce7drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +1
-0@@ -377,6 +377,7 @@ static void gpmi_nfc_compute_timings(structgpmi_nand_data *this, const struct nand_sdr_timings *sdr) { struct gpmi_nfc_hardware_timing *hw = &this->hw; +struct resources *r = &this->resources;unsigned int dll_threshold_ps = this->devdata->max_chain_delay;unsigned int period_ps, reference_period_ps;unsigned int data_setup_cycles, data_hold_cycles, addr_setup_cycles;drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -440,6 +441,8 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, hw->ctrl1n |=BF_GPMI_CTRL1_RDN_DELAY (sample_delay_factor) |BM_GPMI_CTRL1_DLL_ENABLE | (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); + +clk_set_rate (r->clock[0 ], hw->clk_rate); }void
gpmi_nfc_apply_timings(struct gpmi_nand_data *this)drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +0
-2@@ -449,8 +452,6 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; -clk_set_rate (r->clock[0 ], hw->clk_rate); -writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );Quoted 10 lines
Quoted 3 lines
Right now I have this change applied and seems fine. That is the only difference I get. Clock is apply a bit earlier that when is enabled it.
This is very interesting. So this would mean the issue you are experiencing comes from the clock driver which kind of returns too early from
clk_set_rate()? Could you report this to the clk ML/NXP clk maintainers and keep us in copy? If it is as global as it sounds, we might not be the only ones affected.Quoted 3 lines
The imx28 is broken too, so it's a general problem. I need to trace it down I have a reverting for lts but it\s not the way to go
Quoted 9 lines
For imx28 you ask to set the rate to 22Mhz but you don't care about the clock that you get back. You get back 12Mhz because the base clock is 24 Mhz and seems that it can not get the point. You need to check if the clock requested is in range or ask
forset_rate_clk_minto avoid to have somenthing lower. Then for imx6ull because is sporadic
I think that is more connected to theclk_set_rateand when you change the register. Can not be a
setting time?
Quoted 5 lines
So, if I understand correctly, we face two different problems:
- imx6*: seems like a clock issue regarding the clock settlement
- imx28: actual NAND driver issue (does not check the validity of the new frequency). This should be handled properly in ->setup_interface().
I'm planning to work on it, I need to deliver on the field updates on the new LTS release.
Everything is correct what you said. I will check and try to fix the issues properly after this
Michael
Quoted 3 lines
Thanks,
Miquèl
Signature · 11 lines
Michael Nazzareno Trimarchi Amarula Solutions BV COO Co-Founder Cruquiuskade 47 Amsterdam 1018 AM NL T. +31(0)851119172 M. +39(0)3479132170 [`as] https://www.amarulasolutions.com ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi
Quoted 88 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Mon, 1 Feb 2021 16:08:23 +0100:
Quoted 73 lines
Hi
Quoted 65 lines · Michael Nazzareno Trimarchi
Hi
Quoted 50 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Sat, 30 Jan 2021 10:41:29 +0100:
Quoted 44 lines
Hi Miquel
commit
f8e6ad14388067f91b26d044185d95623fbc9535Author: Michael Trimarchi <[email protected]> Date: Fri Jan 29 08:46:53 2021 +0100mtd: nand: Calculate the clock before enable it
Signed-off-by Michael Trimarchi <[email protected]>Change-Id I79b0da39de0a9b32ea0b002fa200d7f44d4f8ce7drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +1
-0@@ -377,6 +377,7 @@ static void gpmi_nfc_compute_timings(structgpmi_nand_data *this, const struct nand_sdr_timings *sdr) { struct gpmi_nfc_hardware_timing *hw = &this->hw; +struct resources *r = &this->resources;unsigned int dll_threshold_ps = this->devdata->max_chain_delay;unsigned int period_ps, reference_period_ps;unsigned int data_setup_cycles, data_hold_cycles, addr_setup_cycles;drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -440,6 +441,8 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, hw->ctrl1n |=BF_GPMI_CTRL1_RDN_DELAY (sample_delay_factor) |BM_GPMI_CTRL1_DLL_ENABLE | (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); + +clk_set_rate (r->clock[0 ], hw->clk_rate); }void
gpmi_nfc_apply_timings(struct gpmi_nand_data *this)drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +0
-2@@ -449,8 +452,6 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; -clk_set_rate (r->clock[0 ], hw->clk_rate); -writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );Quoted 10 lines
Quoted 3 lines
Right now I have this change applied and seems fine. That is the only difference I get. Clock is apply a bit earlier that when is enabled it.
This is very interesting. So this would mean the issue you are experiencing comes from the clock driver which kind of returns too early from
clk_set_rate()? Could you report this to the clk ML/NXP clk maintainers and keep us in copy? If it is as global as it sounds, we might not be the only ones affected.Quoted 3 lines
The imx28 is broken too, so it's a general problem. I need to trace it down I have a reverting for lts but it\s not the way to go
Quoted 9 lines
For imx28 you ask to set the rate to 22Mhz but you don't care about the clock that you get back. You get back 12Mhz because the base clock is 24 Mhz and seems that it can not get the point. You need to check if the clock requested is in range or ask
forset_rate_clk_minto avoid to have somenthing lower. Then for imx6ull because is sporadic
I think that is more connected to theclk_set_rateand when you change the register. Can not be a
setting time?
Quoted 6 lines
So, if I understand correctly, we face two different problems:
- imx6*: seems like a clock issue regarding the clock settlement
- imx28: actual NAND driver issue (does not check the validity of the new frequency). This should be handled properly in ->setup_interface().
Somenthing like this? Not compile/tested
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +11 -5
@@ -644,7 +644,7 @@ static int bch_set_geometry(struct gpmi_nand_data *this)* RDN_DELAY = ----------------------- {3} * RP */ -static void gpmi_nfc_compute_timings (struct gpmi_nand_data *this, +static int gpmi_nfc_compute_timings (struct gpmi_nand_data *this,const struct nand_sdr_timings *sdr) {struct gpmi_nfc_hardware_timing *hw = &this->hw;
@@ -656,6 +656,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,int sample_delay_ps, sample_delay_factor;u16 busy_timeout_cycles;u8 wrn_dly_sel; +long clk_rate;if (sdr->tRC_min >=30000 ) {/* ONFI non-EDO modes [0-3] */
@@ -671,6 +672,10 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, wrn_dly_sel =BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY ; } + clk_rate =clk_round_rate (r->clock[0 ], hw->clk_rate); +if (clk_rate < hw->clk_rate || clk_rate <=0 ) +return -ENOTSUPP ; +/* SDR core timings are given in picoseconds */ period_ps =div_u64 ((u64 )NSEC_PER_SEC *1000 , hw->clk_rate);
@@ -746,6 +751,7 @@ static int gpmi_setup_interface(struct nand_chip *chip, int chipnr, {struct gpmi_nand_data *this =nand_get_controller_data (chip);const struct nand_sdr_timings *sdr; +int ret =0 ;/* Retrieve required NAND timings */ sdr =nand_get_sdr_timings (conf);
@@ -761,11 +767,11 @@ static int gpmi_setup_interface(struct nand_chip *chip, int chipnr,return 0 ;/* Do the actual derivation of the controller timings */ -gpmi_nfc_compute_timings (this, sdr); - - this->hw.must_apply_timings = true; + ret =gpmi_nfc_compute_timings (this, sdr); +if (!ret) + this->hw.must_apply_timings = true; -return 0 ; +return ret; }/* Clears a BCH interrupt. */
Quoted 2 lines
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi
Quoted 123 lines · Michael Trimarchi
Hi
Quoted 88 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Mon, 1 Feb 2021 16:08:23 +0100:
Quoted 73 lines
Hi
Quoted 65 lines · Michael Nazzareno Trimarchi
Hi
Quoted 50 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Sat, 30 Jan 2021 10:41:29 +0100:
Quoted 44 lines
Hi Miquel
commit
f8e6ad14388067f91b26d044185d95623fbc9535Author: Michael Trimarchi <[email protected]> Date: Fri Jan 29 08:46:53 2021 +0100mtd: nand: Calculate the clock before enable it
Signed-off-by Michael Trimarchi <[email protected]>Change-Id I79b0da39de0a9b32ea0b002fa200d7f44d4f8ce7drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +1
-0@@ -377,6 +377,7 @@ static void gpmi_nfc_compute_timings(structgpmi_nand_data *this, const struct nand_sdr_timings *sdr) { struct gpmi_nfc_hardware_timing *hw = &this->hw; +struct resources *r = &this->resources;unsigned int dll_threshold_ps = this->devdata->max_chain_delay;unsigned int period_ps, reference_period_ps;unsigned int data_setup_cycles, data_hold_cycles, addr_setup_cycles;drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -440,6 +441,8 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, hw->ctrl1n |=BF_GPMI_CTRL1_RDN_DELAY (sample_delay_factor) |BM_GPMI_CTRL1_DLL_ENABLE | (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); + +clk_set_rate (r->clock[0 ], hw->clk_rate); }void
gpmi_nfc_apply_timings(struct gpmi_nand_data *this)drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +0
-2@@ -449,8 +452,6 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; -clk_set_rate (r->clock[0 ], hw->clk_rate); -writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );Quoted 10 lines
Quoted 3 lines
Right now I have this change applied and seems fine. That is the only difference I get. Clock is apply a bit earlier that when is enabled it.
This is very interesting. So this would mean the issue you are experiencing comes from the clock driver which kind of returns too early from
clk_set_rate()? Could you report this to the clk ML/NXP clk maintainers and keep us in copy? If it is as global as it sounds, we might not be the only ones affected.Quoted 3 lines
The imx28 is broken too, so it's a general problem. I need to trace it down I have a reverting for lts but it\s not the way to go
Quoted 9 lines
For imx28 you ask to set the rate to 22Mhz but you don't care about the clock that you get back. You get back 12Mhz because the base clock is 24 Mhz and seems that it can not get the point. You need to check if the clock requested is in range or ask
forset_rate_clk_minto avoid to have somenthing lower. Then for imx6ull because is sporadic
I think that is more connected to theclk_set_rateand when you change the register. Can not be a
setting time?Quoted 6 lines
So, if I understand correctly, we face two different problems:
- imx6*: seems like a clock issue regarding the clock settlement
- imx28: actual NAND driver issue (does not check the validity of the new frequency). This should be handled properly in ->setup_interface().Somenthing like this? Not compile/tested
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-1@@ -644,7 +644,7 @@ static int bch_set_geometry(struct gpmi_nand_data *this)* RDN_DELAY = ----------------------- {3} * RP */ -static void gpmi_nfc_compute_timings (struct gpmi_nand_data *this, +static int gpmi_nfc_compute_timings (struct gpmi_nand_data *this,const struct nand_sdr_timings *sdr) {struct gpmi_nfc_hardware_timing *hw = &this->hw;@@ -656,6 +656,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,int sample_delay_ps, sample_delay_factor;u16 busy_timeout_cycles;u8 wrn_dly_sel; +long clk_rate;if (sdr->tRC_min >=30000 ) {/* ONFI non-EDO modes [0-3] */
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, · line 680
Quoted 9 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +4
-0@@ -671,6 +672,10 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, wrn_dly_sel =BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY ; } + clk_rate =clk_round_rate (r->clock[0 ], hw->clk_rate); +if (clk_rate < hw->clk_rate || clk_rate <=0 ) +return -ENOTSUPP ; +/* SDR core timings are given in picoseconds */ period_ps =div_u64 ((u64 )NSEC_PER_SEC *1000 , hw->clk_rate);
Not sure here or:
period_ps = div_u64((u64)NSEC_PER_SEC * 1000, clk_rate);
Michael
Quoted 25 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +5
-4@@ -746,6 +751,7 @@ static int gpmi_setup_interface(struct nand_chip *chip, int chipnr, {struct gpmi_nand_data *this =nand_get_controller_data (chip);const struct nand_sdr_timings *sdr; +int ret =0 ;/* Retrieve required NAND timings */ sdr =nand_get_sdr_timings (conf);@@ -761,11 +767,11 @@ static int gpmi_setup_interface(struct nand_chip *chip, int chipnr,return 0 ;/* Do the actual derivation of the controller timings */ -gpmi_nfc_compute_timings (this, sdr); - - this->hw.must_apply_timings = true; + ret =gpmi_nfc_compute_timings (this, sdr); +if (!ret) + this->hw.must_apply_timings = true; -return 0 ; +return ret; }/* Clears a BCH interrupt. */
Quoted 2 lines
Quoted 2 lines
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Michael,
[email protected] wrote on Fri, 15 Oct 2021 22:05:41 +0200:
Quoted 122 lines
Hi
Quoted 88 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Mon, 1 Feb 2021 16:08:23 +0100:
Quoted 73 lines
Hi
Quoted 65 lines · Michael Nazzareno Trimarchi
Hi
Quoted 50 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Sat, 30 Jan 2021 10:41:29 +0100:
Quoted 44 lines
Hi Miquel
commit
f8e6ad14388067f91b26d044185d95623fbc9535Author: Michael Trimarchi <[email protected]> Date: Fri Jan 29 08:46:53 2021 +0100mtd: nand: Calculate the clock before enable it
Signed-off-by Michael Trimarchi <[email protected]>Change-Id I79b0da39de0a9b32ea0b002fa200d7f44d4f8ce7drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +1
-0@@ -377,6 +377,7 @@ static void gpmi_nfc_compute_timings(structgpmi_nand_data *this, const struct nand_sdr_timings *sdr) { struct gpmi_nfc_hardware_timing *hw = &this->hw; +struct resources *r = &this->resources;unsigned int dll_threshold_ps = this->devdata->max_chain_delay;unsigned int period_ps, reference_period_ps;unsigned int data_setup_cycles, data_hold_cycles, addr_setup_cycles;drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -440,6 +441,8 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, hw->ctrl1n |=BF_GPMI_CTRL1_RDN_DELAY (sample_delay_factor) |BM_GPMI_CTRL1_DLL_ENABLE | (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); + +clk_set_rate (r->clock[0 ], hw->clk_rate); }void
gpmi_nfc_apply_timings(struct gpmi_nand_data *this)drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +0
-2@@ -449,8 +452,6 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; -clk_set_rate (r->clock[0 ], hw->clk_rate); -writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );Quoted 10 lines
Quoted 3 lines
Right now I have this change applied and seems fine. That is the only difference I get. Clock is apply a bit earlier that when is enabled it.
This is very interesting. So this would mean the issue you are experiencing comes from the clock driver which kind of returns too early from
clk_set_rate()? Could you report this to the clk ML/NXP clk maintainers and keep us in copy? If it is as global as it sounds, we might not be the only ones affected.Quoted 3 lines
The imx28 is broken too, so it's a general problem. I need to trace it down I have a reverting for lts but it\s not the way to go
Quoted 9 lines
For imx28 you ask to set the rate to 22Mhz but you don't care about the clock that you get back. You get back 12Mhz because the base clock is 24 Mhz and seems that it can not get the point. You need to check if the clock requested is in range or ask
forset_rate_clk_minto avoid to have somenthing lower. Then for imx6ull because is sporadic
I think that is more connected to theclk_set_rateand when you change the register. Can not be a
setting time?Quoted 6 lines
So, if I understand correctly, we face two different problems:
- imx6*: seems like a clock issue regarding the clock settlement
- imx28: actual NAND driver issue (does not check the validity of the new frequency). This should be handled properly in ->setup_interface().Somenthing like this? Not compile/tested
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-1@@ -644,7 +644,7 @@ static int bch_set_geometry(struct gpmi_nand_data *this)* RDN_DELAY = ----------------------- {3} * RP */ -static void gpmi_nfc_compute_timings (struct gpmi_nand_data *this, +static int gpmi_nfc_compute_timings (struct gpmi_nand_data *this,const struct nand_sdr_timings *sdr) {struct gpmi_nfc_hardware_timing *hw = &this->hw;@@ -656,6 +656,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,int sample_delay_ps, sample_delay_factor;u16 busy_timeout_cycles;u8 wrn_dly_sel; +long clk_rate;if (sdr->tRC_min >=30000 ) {/* ONFI non-EDO modes [0-3] */
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, · line 677
Quoted 6 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +3
-0@@ -671,6 +672,10 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, wrn_dly_sel =BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY ; } + clk_rate =clk_round_rate (r->clock[0 ], hw->clk_rate); +if (clk_rate < hw->clk_rate || clk_rate <=0 ) +return -ENOTSUPP ;
I believe clk_rate < hw->clk_rate will always match cases where clk_rate <= 0 ?
The check looks very strict though. Will it even pass on i.MX6? Perhaps we could verify something like a 10% error which might grab all the erroneous situations?
if (abs(clk_rate - hw->clk_rate) > (hw->clk_rate / 10)) return -ENOTSUPP;
Quoted 28 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +6
-4+/* SDR core timings are given in picoseconds */ period_ps =div_u64 ((u64 )NSEC_PER_SEC *1000 , hw->clk_rate);@@ -746,6 +751,7 @@ static int gpmi_setup_interface(struct nand_chip *chip, int chipnr, {struct gpmi_nand_data *this =nand_get_controller_data (chip);const struct nand_sdr_timings *sdr; +int ret =0 ;/* Retrieve required NAND timings */ sdr =nand_get_sdr_timings (conf);@@ -761,11 +767,11 @@ static int gpmi_setup_interface(struct nand_chip *chip, int chipnr,return 0 ;/* Do the actual derivation of the controller timings */ -gpmi_nfc_compute_timings (this, sdr); - - this->hw.must_apply_timings = true; + ret =gpmi_nfc_compute_timings (this, sdr); +if (!ret) + this->hw.must_apply_timings = true; -return 0 ; +return ret; }/* Clears a BCH interrupt. */
Quoted 2 lines
Quoted 2 lines
Thanks,
Miquèl
Otherwise looks good, thanks!
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi
Quoted 137 lines · Miquel Raynal
Hi Michael,
[email protected] wrote on Fri, 15 Oct 2021 22:05:41 +0200:
Quoted 122 lines
Hi
Quoted 88 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Mon, 1 Feb 2021 16:08:23 +0100:
Quoted 73 lines
Hi
Quoted 65 lines · Michael Nazzareno Trimarchi
Hi
Quoted 50 lines · Miquel Raynal
Hi Michael,
Michael Nazzareno Trimarchi <[email protected]> wrote on Sat, 30 Jan 2021 10:41:29 +0100:
Quoted 44 lines
Hi Miquel
commit
f8e6ad14388067f91b26d044185d95623fbc9535Author: Michael Trimarchi <[email protected]> Date: Fri Jan 29 08:46:53 2021 +0100mtd: nand: Calculate the clock before enable it
Signed-off-by Michael Trimarchi <[email protected]>Change-Id I79b0da39de0a9b32ea0b002fa200d7f44d4f8ce7drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +1
-0@@ -377,6 +377,7 @@ static void gpmi_nfc_compute_timings(structgpmi_nand_data *this, const struct nand_sdr_timings *sdr) { struct gpmi_nfc_hardware_timing *hw = &this->hw; +struct resources *r = &this->resources;unsigned int dll_threshold_ps = this->devdata->max_chain_delay;unsigned int period_ps, reference_period_ps;unsigned int data_setup_cycles, data_hold_cycles, addr_setup_cycles;drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -440,6 +441,8 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, hw->ctrl1n |=BF_GPMI_CTRL1_RDN_DELAY (sample_delay_factor) |BM_GPMI_CTRL1_DLL_ENABLE | (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); + +clk_set_rate (r->clock[0 ], hw->clk_rate); }void
gpmi_nfc_apply_timings(struct gpmi_nand_data *this)drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +0
-2@@ -449,8 +452,6 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; -clk_set_rate (r->clock[0 ], hw->clk_rate); -writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );Quoted 10 lines
Quoted 3 lines
Right now I have this change applied and seems fine. That is the only difference I get. Clock is apply a bit earlier that when is enabled it.
This is very interesting. So this would mean the issue you are experiencing comes from the clock driver which kind of returns too early from
clk_set_rate()? Could you report this to the clk ML/NXP clk maintainers and keep us in copy? If it is as global as it sounds, we might not be the only ones affected.Quoted 3 lines
The imx28 is broken too, so it's a general problem. I need to trace it down I have a reverting for lts but it\s not the way to go
Quoted 9 lines
For imx28 you ask to set the rate to 22Mhz but you don't care about the clock that you get back. You get back 12Mhz because the base clock is 24 Mhz and seems that it can not get the point. You need to check if the clock requested is in range or ask
forset_rate_clk_minto avoid to have somenthing lower. Then for imx6ull because is sporadic
I think that is more connected to theclk_set_rateand when you change the register. Can not be a
setting time?Quoted 6 lines
So, if I understand correctly, we face two different problems:
- imx6*: seems like a clock issue regarding the clock settlement
- imx28: actual NAND driver issue (does not check the validity of the new frequency). This should be handled properly in ->setup_interface().Somenthing like this? Not compile/tested
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-1@@ -644,7 +644,7 @@ static int bch_set_geometry(struct gpmi_nand_data *this)* RDN_DELAY = ----------------------- {3} * RP */ -static void gpmi_nfc_compute_timings (struct gpmi_nand_data *this, +static int gpmi_nfc_compute_timings (struct gpmi_nand_data *this,const struct nand_sdr_timings *sdr) {struct gpmi_nfc_hardware_timing *hw = &this->hw;@@ -656,6 +656,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,int sample_delay_ps, sample_delay_factor;u16 busy_timeout_cycles;u8 wrn_dly_sel; +long clk_rate;if (sdr->tRC_min >=30000 ) {/* ONFI non-EDO modes [0-3] */ drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, · line 677
Quoted 6 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +3
-0@@ -671,6 +672,10 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, wrn_dly_sel =BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY ; } + clk_rate =clk_round_rate (r->clock[0 ], hw->clk_rate); +if (clk_rate < hw->clk_rate || clk_rate <=0 ) +return -ENOTSUPP ;I believe
clk_rate<hw->clk_ratewill always match cases whereclk_rate<= 0 ?
Quoted 3 lines
The check looks very strict though. Will it even pass on i.MX6? Perhaps we could verify something like a 10% error which might grab all the erroneous situations?
According to what I read the clk is the min that we can accept. So any clock from EDO4 to EDO5 should be ok. My concern is that calculation. I need to read it properly. I don't think that put 10% or any will help us, until we now that is possible or not.
I will even anyway put a warning
Michael
Quoted 31 lines
if (abs(clk_rate - hw->clk_rate) > (hw->clk_rate / 10)) return -ENOTSUPP;Quoted 27 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +6
-4+/* SDR core timings are given in picoseconds */ period_ps =div_u64 ((u64 )NSEC_PER_SEC *1000 , hw->clk_rate);@@ -746,6 +751,7 @@ static int gpmi_setup_interface(struct nand_chip *chip, int chipnr, {struct gpmi_nand_data *this =nand_get_controller_data (chip);const struct nand_sdr_timings *sdr; +int ret =0 ;/* Retrieve required NAND timings */ sdr =nand_get_sdr_timings (conf);@@ -761,11 +767,11 @@ static int gpmi_setup_interface(struct nand_chip *chip, int chipnr,return 0 ;/* Do the actual derivation of the controller timings */ -gpmi_nfc_compute_timings (this, sdr); - - this->hw.must_apply_timings = true; + ret =gpmi_nfc_compute_timings (this, sdr); +if (!ret) + this->hw.must_apply_timings = true; -return 0 ; +return ret; }
Quoted 7 lines
Quoted 3 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0/* Clears a BCH interrupt. */ Quoted 2 lines
Thanks,
MiquèlOtherwise looks good, thanks!
Miquèl
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
[email protected]
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
[email protected]
www.amarulasolutions.com
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Michael,
Quoted 108 lines
Quoted 108 lines
Quoted 98 lines
Quoted 67 lines
Quoted 57 lines
Quoted 53 lines
Quoted 42 lines
Quoted 42 lines
commit
f8e6ad14388067f91b26d044185d95623fbc9535Author: Michael Trimarchi <[email protected]> Date: Fri Jan 29 08:46:53 2021 +0100mtd: nand: Calculate the clock before enable it
Signed-off-by Michael Trimarchi <[email protected]>Change-Id I79b0da39de0a9b32ea0b002fa200d7f44d4f8ce7drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +1
-0@@ -377,6 +377,7 @@ static void gpmi_nfc_compute_timings(structgpmi_nand_data *this, const struct nand_sdr_timings *sdr) { struct gpmi_nfc_hardware_timing *hw = &this->hw; +struct resources *r = &this->resources;unsigned int dll_threshold_ps = this->devdata->max_chain_delay;unsigned int period_ps, reference_period_ps;unsigned int data_setup_cycles, data_hold_cycles, addr_setup_cycles;drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +2
-0@@ -440,6 +441,8 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, hw->ctrl1n |=BF_GPMI_CTRL1_RDN_DELAY (sample_delay_factor) |BM_GPMI_CTRL1_DLL_ENABLE | (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); + +clk_set_rate (r->clock[0 ], hw->clk_rate); }void
gpmi_nfc_apply_timings(struct gpmi_nand_data *this)drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +0
-2@@ -449,8 +452,6 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; -clk_set_rate (r->clock[0 ], hw->clk_rate); -writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );Quoted 10 lines
Quoted 3 lines
Right now I have this change applied and seems fine. That is the only difference I get. Clock is apply a bit earlier that when is enabled it.
This is very interesting. So this would mean the issue you are experiencing comes from the clock driver which kind of returns too early from
clk_set_rate()? Could you report this to the clk ML/NXP clk maintainers and keep us in copy? If it is as global as it sounds, we might not be the only ones affected.Quoted 3 lines
The imx28 is broken too, so it's a general problem. I need to trace it down I have a reverting for lts but it\s not the way to go
Quoted 9 lines
For imx28 you ask to set the rate to 22Mhz but you don't care about the clock that you get back. You get back 12Mhz because the base clock is 24 Mhz and seems that it can not get the point. You need to check if the clock requested is in range or ask
forset_rate_clk_minto avoid to have somenthing lower. Then for imx6ull because is sporadic
I think that is more connected to theclk_set_rateand when you change the register. Can not be a
setting time?Quoted 6 lines
So, if I understand correctly, we face two different problems:
- imx6*: seems like a clock issue regarding the clock settlement
- imx28: actual NAND driver issue (does not check the validity of the new frequency). This should be handled properly in ->setup_interface().Somenthing like this? Not compile/tested
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-1@@ -644,7 +644,7 @@ static int bch_set_geometry(struct gpmi_nand_data *this)* RDN_DELAY = ----------------------- {3} * RP */ -static void gpmi_nfc_compute_timings (struct gpmi_nand_data *this, +static int gpmi_nfc_compute_timings (struct gpmi_nand_data *this,const struct nand_sdr_timings *sdr) {struct gpmi_nfc_hardware_timing *hw = &this->hw;@@ -656,6 +656,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,int sample_delay_ps, sample_delay_factor;u16 busy_timeout_cycles;u8 wrn_dly_sel; +long clk_rate;if (sdr->tRC_min >=30000 ) {/* ONFI non-EDO modes [0-3] */ drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, · line 677
Quoted 6 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +3
-0@@ -671,6 +672,10 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, wrn_dly_sel =BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY ; } + clk_rate =clk_round_rate (r->clock[0 ], hw->clk_rate); +if (clk_rate < hw->clk_rate || clk_rate <=0 ) +return -ENOTSUPP ;I believe
clk_rate<hw->clk_ratewill always match cases whereclk_rate<= 0 ?
Quoted 8 lines
Quoted 3 lines
The check looks very strict though. Will it even pass on i.MX6? Perhaps we could verify something like a 10% error which might grab all the erroneous situations?
According to what I read the clk is the min that we can accept. So any clock from EDO4 to EDO5 should be ok. My concern is that calculation. I need to read it properly. I don't think that put 10% or any will help us, until we now that is possible or not.
10% was for the example, what I mean is that it is very common to request a clock to run at 100MHz and to read it at eg. 93MHz. Your check won't pass in this case and we cannot get the necessary test coverage in order to ensure that we won't break working boards.
The thing is, if the calculation are made using hw->clk_rate we will always get the register values wrong anyway and in this case it's true that only experience will tell us if such a clock works or not. However, if the calculations are made with clk_rate instead, it is likely that we will get more accurate timings which very likely will work. So perhaps the right solution would be to use the real clock rate instead than refusing clock rates which do not match our strict expectations?
Quoted 31 lines
Quoted 31 lines
if (abs(clk_rate - hw->clk_rate) > (hw->clk_rate / 10)) return -ENOTSUPP;Quoted 27 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +6
-4+/* SDR core timings are given in picoseconds */ period_ps =div_u64 ((u64 )NSEC_PER_SEC *1000 , hw->clk_rate);@@ -746,6 +751,7 @@ static int gpmi_setup_interface(struct nand_chip *chip, int chipnr, {struct gpmi_nand_data *this =nand_get_controller_data (chip);const struct nand_sdr_timings *sdr; +int ret =0 ;/* Retrieve required NAND timings */ sdr =nand_get_sdr_timings (conf);@@ -761,11 +767,11 @@ static int gpmi_setup_interface(struct nand_chip *chip, int chipnr,return 0 ;/* Do the actual derivation of the controller timings */ -gpmi_nfc_compute_timings (this, sdr); - - this->hw.must_apply_timings = true; + ret =gpmi_nfc_compute_timings (this, sdr); +if (!ret) + this->hw.must_apply_timings = true; -return 0 ; +return ret; }
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0/* Clears a BCH interrupt. */ Quoted 2 lines
Thanks,
MiquèlOtherwise looks good, thanks!
Miquèl
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 10 lines · Greg Ungerer
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
Hi all,
I am joining this thread because I am also affected by this problem. I use kernel 5.10.65-rt53 but I have seen this issue on many previous versions. In the past I only recognized this on my development setup but now this has been found by our testing team.
In our test setup we simply perform a reboot every 30s. After 5 to 200 cycles the test stops due to this error.
The kernel version I use already includes:
Quoted 2 lines
Han Xu <[email protected]>
mtd: rawnand: gpmi: Fix the random DMA timeout issue
Additionally I tried ...
Quoted 2 lines
Michael Trimarchi <[email protected]>
mtd: nand: Calculate the clock before enable it
... but the problem still persists.
In my case, some registers show different values (annotated below):
Quoted 4 lines
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xda
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xdc
Quoted 1 line
nand: Micron MT29F2G08ABAEAWP
nand: Micron MT29F4G08ABADAH4
Quoted 8 lines
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000
Quoted 8 lines
gpmi-nand 1806000.gpmi-nand: offset
0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001
gpmi-nand 1806000.nand-controller: offset 0x0c0 : 0x00000202
Quoted 3 lines
gpmi-nand 1806000.gpmi-nand: offset
0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100
gpmi-nand 1806000.nand-controller: offset 0x000 : 0x00000000
Quoted 8 lines
gpmi-nand 1806000.gpmi-nand: offset
0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080
gpmi-nand 1806000.nand-controller: offset 0x080 : 0x070a4080
Quoted 1 line
gpmi-nand 1806000.gpmi-nand: offset
0x090:0x083e2080
gpmi-nand 1806000.nand-controller: offset 0x090 : 0x10da4080
Quoted 13 lines
gpmi-nand 1806000.gpmi-nand: offset
0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000
Quoted 8 lines
gpmi-nand 1806000.gpmi-nand: offset
0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512
ECC Chunk Size in Bytes: 512
Quoted 6 lines
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0
Please let me know if further information is required.
regards
Christian
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Christian
Quoted 98 lines · Christian Eggers
Quoted 10 lines · Greg Ungerer
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
Hi all,
I am joining this thread because I am also affected by this problem. I use kernel 5.10.65-rt53 but I have seen this issue on many previous versions. In the past I only recognized this on my development setup but now this has been found by our testing team.
In our test setup we simply perform a reboot every 30s. After 5 to 200 cycles the test stops due to this error.
The kernel version I use already includes:
Quoted 2 lines
Han Xu <[email protected]>
mtd: rawnand: gpmi: Fix the random DMA timeout issueAdditionally I tried ...
Quoted 2 lines
Michael Trimarchi <[email protected]>
mtd: nand: Calculate the clock before enable it... but the problem still persists.
In my case, some registers show different values (annotated below):
Quoted 4 lines
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xdanand: device found, Manufacturer ID:
0x2c, Chip ID:0xdcQuoted 1 line
nand: Micron MT29F2G08ABAEAWP
nand: Micron MT29F4G08ABADAH4
Quoted 8 lines
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000Quoted 8 lines
gpmi-nand 1806000.gpmi-nand: offset
0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.nand-controller: offset
0x0c0:0x00000202Quoted 3 lines
gpmi-nand 1806000.gpmi-nand: offset
0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.nand-controller: offset
0x000:0x00000000Quoted 8 lines
gpmi-nand 1806000.gpmi-nand: offset
0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.nand-controller: offset
0x080:0x070a4080Quoted 1 line
gpmi-nand 1806000.gpmi-nand: offset
0x090:0x083e2080gpmi-nand 1806000.nand-controller: offset
0x090:0x10da4080Quoted 13 lines
gpmi-nand 1806000.gpmi-nand: offset
0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000Quoted 8 lines
gpmi-nand 1806000.gpmi-nand: offset
0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512ECC Chunk Size in Bytes: 512
Quoted 8 lines
Quoted 6 lines
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0Please let me know if further information is required.
I need to continue on it, during the following days. I have stopped moving to LTS 4.19.y and with my partial revert.
The problem as usual was to go to production on some devices. Anyway I have the device that has this problem. I can
restart next weekend. One of the thing I notice that make not work on imx28 is:
if (sdr->tRC_min >= 30000) {
/* ONFI non-EDO modes [0-3] */
hw->clk_rate = 22000000;
wrn_dly_sel = BV_GPMI_CTRL1_WRN_DLY_SEL_4_TO_8NS;
} else if (sdr->tRC_min >= 25000) {
/* ONFI EDO mode 4 */
hw->clk_rate = 80000000;
wrn_dly_sel = BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY;
} else {
/* ONFI EDO mode 5 */
hw->clk_rate = 100000000;
wrn_dly_sel = BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY;
}Here there is an assumption that your clk_rate can be set to that rate but on imx28, the parent clock of the NAND one can not
let it go to those speed. Changing it let it really set to the wrong value, so imx28 was totally broken. The other computation was based not on fixed clock rate but I think even on clk_get_rate
Michael
Quoted 7 lines
regards
Christian
Signature · 15 lines
Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 [email protected] __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 [email protected] www.amarulasolutions.com ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Michael, Christian,
[email protected] wrote on Mon, 4 Oct 2021 08:27:54 +0200:
Quoted 130 lines
Hi Christian
Quoted 98 lines · Christian Eggers
Quoted 10 lines · Greg Ungerer
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://linux-mtd.infradead.narkive.com/JIUulfFB/gpmi-imx6ull-timeout-on-dma
That didn't come to any specific resolution that I could see in that thread.
Hi all,
I am joining this thread because I am also affected by this problem. I use kernel 5.10.65-rt53 but I have seen this issue on many previous versions. In the past I only recognized this on my development setup but now this has been found by our testing team.
In our test setup we simply perform a reboot every 30s. After 5 to 200 cycles the test stops due to this error.
The kernel version I use already includes:
Quoted 2 lines
Han Xu <[email protected]>
mtd: rawnand: gpmi: Fix the random DMA timeout issueAdditionally I tried ...
Quoted 2 lines
Michael Trimarchi <[email protected]>
mtd: nand: Calculate the clock before enable it... but the problem still persists.
In my case, some registers show different values (annotated below):
Quoted 4 lines
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xdanand: device found, Manufacturer ID:
0x2c, Chip ID:0xdcQuoted 1 line
nand: Micron MT29F2G08ABAEAWP
nand: Micron MT29F4G08ABADAH4
Quoted 8 lines
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000Quoted 8 lines
gpmi-nand 1806000.gpmi-nand: offset
0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.nand-controller: offset
0x0c0:0x00000202Quoted 3 lines
gpmi-nand 1806000.gpmi-nand: offset
0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.nand-controller: offset
0x000:0x00000000Quoted 8 lines
gpmi-nand 1806000.gpmi-nand: offset
0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.nand-controller: offset
0x080:0x070a4080Quoted 1 line
gpmi-nand 1806000.gpmi-nand: offset
0x090:0x083e2080gpmi-nand 1806000.nand-controller: offset
0x090:0x10da4080Quoted 13 lines
gpmi-nand 1806000.gpmi-nand: offset
0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000Quoted 8 lines
gpmi-nand 1806000.gpmi-nand: offset
0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512ECC Chunk Size in Bytes: 512
Quoted 8 lines
Quoted 6 lines
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0Please let me know if further information is required.
I need to continue on it, during the following days. I have stopped moving to LTS 4.19.y and with my partial revert.
The problem as usual was to go to production on some devices. Anyway I have the device that has this problem. I can
restart next weekend. One of the thing I notice that make not work on imx28 is:if (sdr->tRC_min >= 30000) { /* ONFI non-EDO modes [0-3] */ hw->clk_rate = 22000000; wrn_dly_sel = BV_GPMI_CTRL1_WRN_DLY_SEL_4_TO_8NS; } else if (sdr->tRC_min >= 25000) { /* ONFI EDO mode 4 */ hw->clk_rate = 80000000; wrn_dly_sel = BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY; } else { /* ONFI EDO mode 5 */ hw->clk_rate = 100000000; wrn_dly_sel = BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY; }
Quoted 5 lines
Here there is an assumption that your
clk_ratecan be set to that rate but on imx28, the parent clock of the NAND one can not
let it go to those speed. Changing it let it really set to the wrong value, so imx28 was totally broken. The other computation was based not on fixed clock rate but I think even onclk_get_rate
Interesting finding. I guess we should try to apply the desired block rate and if the final clock rate is too far from what is achievable and works we should refuse the requested configuration. The core will automatically try the slowest -but perhaps working- modes.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Han Xu
maintainerQuoted 113 lines · Miquel Raynal
Hi Michael, Christian,
[email protected] wrote on Mon, 4 Oct 2021 08:27:54 +0200:
Quoted 109 lines
Hi Christian
Quoted 106 lines · Christian Eggers
Quoted 10 lines · Greg Ungerer
Hi Miquel,
I am experiencing a problem with NAND flash DMA timeouts on iMX6ull based boards. The problem is very similar to that described in:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinux-mtd.infradead.narkive.com%2FJIUulfFB%2Fgpmi-imx6ull-timeout-on-dma&data=04%7C01%7Chan.xu%40nxp.com%7C278d7b93edbb4b72923408d9874c5ffe%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637689584362563293%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=uSkVTsEF9yhHt5ZstJMbPIjUQbHzjhiHMjO9eDgFSg0%3D&reserved=0That didn't come to any specific resolution that I could see in that thread.
Hi all,
I am joining this thread because I am also affected by this problem. I use kernel 5.10.65-rt53 but I have seen this issue on many previous versions. In the past I only recognized this on my development setup but now this has been found by our testing team.
In our test setup we simply perform a reboot every 30s. After 5 to 200 cycles the test stops due to this error.
The kernel version I use already includes:
Quoted 2 lines
Han Xu <[email protected]>
mtd: rawnand: gpmi: Fix the random DMA timeout issueAdditionally I tried ...
Quoted 2 lines
Michael Trimarchi <[email protected]>
mtd: nand: Calculate the clock before enable it... but the problem still persists.
In my case, some registers show different values (annotated below):
Quoted 4 lines
The boot trace on the console for me looks like this:
nand: device found, Manufacturer ID:
0x2c, Chip ID:0xdanand: device found, Manufacturer ID:
0x2c, Chip ID:0xdcQuoted 1 line
nand: Micron MT29F2G08ABAEAWP
nand: Micron MT29F4G08ABADAH4
Quoted 8 lines
nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi-nand 1806000.gpmi-nand: DMA timeout, last DMA gpmi-nand 1806000.gpmi-nand: Show GPMI registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x20830002gpmi-nand 1806000.gpmi-nand: offset0x010:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000Quoted 8 lines
gpmi-nand 1806000.gpmi-nand: offset
0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x01c6800cgpmi-nand 1806000.gpmi-nand: offset0x070:0x00010101gpmi-nand 1806000.gpmi-nand: offset0x080:0xe0000000gpmi-nand 1806000.gpmi-nand: offset0x090:0x23023336gpmi-nand 1806000.gpmi-nand: offset0x0a0:0x000001eegpmi-nand 1806000.gpmi-nand: offset0x0b0:0xff000001gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x00000001gpmi-nand 1806000.nand-controller: offset
0x0c0:0x00000202Quoted 3 lines
gpmi-nand 1806000.gpmi-nand: offset
0x0d0:0x05020000gpmi-nand 1806000.gpmi-nand: Show BCH registers :
gpmi-nand 1806000.gpmi-nand: offset0x000:0x00000100gpmi-nand 1806000.nand-controller: offset
0x000:0x00000000Quoted 8 lines
gpmi-nand 1806000.gpmi-nand: offset
0x010:0x00000010gpmi-nand 1806000.gpmi-nand: offset0x020:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x030:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x040:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x050:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x060:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x070:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x080:0x030a2080gpmi-nand 1806000.nand-controller: offset
0x080:0x070a4080Quoted 1 line
gpmi-nand 1806000.gpmi-nand: offset
0x090:0x083e2080gpmi-nand 1806000.nand-controller: offset
0x090:0x10da4080Quoted 13 lines
gpmi-nand 1806000.gpmi-nand: offset
0x0a0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0b0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0c0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0d0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x0e0:0x070a4080gpmi-nand 1806000.gpmi-nand: offset0x0f0:0x10da4080gpmi-nand 1806000.gpmi-nand: offset0x100:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x110:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x120:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x130:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x140:0x00000000gpmi-nand 1806000.gpmi-nand: offset0x150:0x20484342gpmi-nand 1806000.gpmi-nand: offset0x160:0x01000000Quoted 8 lines
gpmi-nand 1806000.gpmi-nand: offset
0x170:0x00000000gpmi-nand 1806000.gpmi-nand: BCH Geometry :
GF length : 13
ECC Strength : 8
Page Size in Bytes : 2110
Metadata Size in Bytes : 10
ECC Chunk0 Size in Bytes: 512
ECC Chunkn Size in Bytes: 512ECC Chunk Size in Bytes: 512
Quoted 6 lines
ECC Chunk Count : 4
Payload Size in Bytes : 2048
Auxiliary Size in Bytes: 16
Auxiliary Status Offset: 12
Block Mark Byte Offset : 1999
Block Mark Bit Offset : 0Please let me know if further information is required.
Could you please try to add clock dis/enable when setting clock rate, in case clock glitches.
clk_disable_unprepare(r->clock[0]);clk_set_rate(r->clock[0], hw->clk_rate);clk_prepare_enable(r->clock[0]);
Quoted 27 lines
Quoted 21 lines
I need to continue on it, during the following days. I have stopped moving to LTS 4.19.y and with my partial revert.
The problem as usual was to go to production on some devices. Anyway I have the device that has this problem. I can
restart next weekend. One of the thing I notice that make not work on imx28 is:if (sdr->tRC_min >= 30000) { /* ONFI non-EDO modes [0-3] */ hw->clk_rate = 22000000; wrn_dly_sel = BV_GPMI_CTRL1_WRN_DLY_SEL_4_TO_8NS; } else if (sdr->tRC_min >= 25000) { /* ONFI EDO mode 4 */ hw->clk_rate = 80000000; wrn_dly_sel = BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY; } else { /* ONFI EDO mode 5 */ hw->clk_rate = 100000000; wrn_dly_sel = BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY; }Quoted 5 lines
Here there is an assumption that your
clk_ratecan be set to that rate but on imx28, the parent clock of the NAND one can not
let it go to those speed. Changing it let it really set to the wrong value, so imx28 was totally broken. The other computation was based not on fixed clock rate but I think even onclk_get_rate
Quoted 7 lines
Interesting finding. I guess we should try to apply the desired block rate and if the final clock rate is too far from what is achievable and works we should refuse the requested configuration. The core will automatically try the slowest -but perhaps working- modes.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 8 lines · Han Xu
Could you please try to add clock dis/enable when setting clock rate, in case clock glitches.
clk_disable_unprepare(r->clock[0]);clk_set_rate(r->clock[0], hw->clk_rate);clk_prepare_enable(r->clock[0]);
This looks promising! Last night I had a successful test run with more than 600 reboots! The test only stopped because my network was disturbed by the daily backup run...
I'll do further tests within the next 24 hours.
regards
Christian
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
+ set PHYTEC developers on (B)CC
Quoted 8 lines · Han Xu
Could you please try to add clock dis/enable when setting clock rate, in case clock glitches.
clk_disable_unprepare(r->clock[0]);clk_set_rate(r->clock[0], hw->clk_rate);clk_prepare_enable(r->clock[0]);
With this change, we made over 2000 successful reboots without any GPMI DMA timeout problems!
From PHYTEC (our BSP supplier), I got some possible background for this problem. For older revisions of IMX6DQ there was an errata (ERR007117, [1]) in the ROM bootloader which triggers a similar / the same behavior:
Quoted 8 lines
For raw NAND boot, ROM switches the source of
enfc_clk_rootfromPLL2_PFD2to PLL3. The root clock is required to be gated before switching the source clock. If the root clock is not gated, clock glitches might be passed to the divider that follows the clock mux, and the divider might behave unpredictably.
...
This problem can also occur elsewhere in application code if the root clock is not properly gated when the clock configuration is changed.
In my case (Linux boot on i.MX6ULL), I recognized that on the 3rd call of gpmi_nfc_apply_timings(), the rate of r->clock[0] is changed
- from: 22 MHz (CS2CDR::ENFC_CLK_PRED=6 and CS2CDR::ENFC_CLK_PODF=3)
- to: 100 MHz (CS2CDR::ENFC_CLK_PRED=4 and CS2CDR::ENFC_CLK_PODF=1)
The proposal from from Han Xu
Quoted 3 lines
clk_disable_unprepare(r->clock[0]);clk_set_rate(r->clock[0], hw->clk_rate);clk_prepare_enable(r->clock[0]);
disables only CCGR4::CG14 [RAWNAND_U_GPMI_BCH_INPUT_GPMI_IO_CLK_ENABLE] during the rate change. While this works very fine on my system, this probably doesn't fulfill the requirements in the errata description:
Quoted 10 lines
For other occurrences in application code, the following procedure should be followed to change the clock configuration for the
enfc_clk_root:
1) Gate (disable) the GPMI/BCH clocks in registerCCM_CCGR4.
2) Gate (disable) theenfc_clk_rootbefore changing theenfc_clk_rootsource or dividers by clearing CCM_CCGR2[CG7] to 2’b00. This disables theiomux_ipt_clk_io_clk.
3) ConfigureCCM_CS2CDRfor the new clock source configuration.
4) Enableenfc_clk_rootby setting CCM_CCGR2[CG7] to 2’b11. This enables theiomux_ipt_clk_io_clk.
5) Enable the GPMI/BCH clocks in registerCCM_CCGR4
I got another solution from PHYTEC ([2], not lengthy tested yet), which disables all GPMI/BCH clocks on CCGR4 (verified with a JTAG debugger):
- CCGR4::CG15 [RAWNAND_U_GPMI_INPUT_APB_CLK_ENABLE] - CCGR4::CG14 [RAWNAND_U_GPMI_BCH_INPUT_GPMI_IO_CLK_ENABLE] - CCGR4::CG13 [RAWNAND_U_GPMI_BCH_INPUT_BCH_CLK_ENABLE] - CCGR4::CG12 [RAWNAND_U_BCH_INPUT_APB_CLK_ENABLE] - CCGR4::CG6 [PL301_MX6QPER1_BCHCLK_ENABLE]
CCM_CCGR2[CG7] is used for IOMUX_IPT_CLK_IO_ENABLE on i.MX6ULL, so step 2. seems not to apply here. Actually I don't know how to gate ENFC_CLK_ROOT.
I will cyclic test the solution from PHYTEC over the weekend.
@Han Xu: Should I prefer the solution from PHYTEC? @Stefan Riedmueller: Are you willing to commit this upstream?
regards
Christian
[1] https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf
[2] https://git.phytec.de/linux-mainline/commit/?h=v5.10.48-phy&id=866939ea8110764d9c12af960d746e2f7f5debe3
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Christian,
Quoted 68 lines · Christian Eggers
+ set PHYTEC developers on (B)CC
Quoted 8 lines · Han Xu
Could you please try to add clock dis/enable when setting clock rate, in case
clock glitches.
clk_disable_unprepare(r->clock[0]);clk_set_rate(r->clock[0], hw->clk_rate);clk_prepare_enable(r->clock[0]);With this change, we made over 2000 successful reboots without any GPMI DMA timeout problems!
From PHYTEC (our BSP supplier), I got some possible background for this problem. For older revisions of IMX6DQ there was an errata (ERR007117, [1]) in the ROM bootloader which triggers a similar / the same behavior:
Quoted 10 lines
For raw NAND boot, ROM switches the source of
enfc_clk_rootfromPLL2_PFD2to PLL3. The root clock is required to be gated before switching the source
clock. If the root clock is not gated, clock glitches might be passed to the divider that follows the clock mux, and the divider might behave unpredictably.
...
This problem can also occur elsewhere in application code if the root clock
is not properly gated when the clock configuration is changed.In my case (Linux boot on i.MX6ULL), I recognized that on the 3rd call of
gpmi_nfc_apply_timings(), the rate of r->clock[0] is changed- from: 22 MHz (CS2CDR::ENFC_CLK_PRED=6 and CS2CDR::ENFC_CLK_PODF=3)
- to: 100 MHz (CS2CDR::ENFC_CLK_PRED=4 and CS2CDR::ENFC_CLK_PODF=1)The proposal from from Han Xu
Quoted 3 lines
clk_disable_unprepare(r->clock[0]);clk_set_rate(r->clock[0], hw->clk_rate);clk_prepare_enable(r->clock[0]);disables only
CCGR4::CG14[RAWNAND_U_GPMI_BCH_INPUT_GPMI_IO_CLK_ENABLE] during
the rate change. While this works very fine on my system, this probably doesn't
fulfill the requirements in the errata description:Quoted 5 lines
For other occurrences in application code, the following procedure should be
followed to change the clock configuration for theenfc_clk_root:
1) Gate (disable) the GPMI/BCH clocks in registerCCM_CCGR4.
2) Gate (disable) theenfc_clk_rootbefore changing theenfc_clk_rootQuoted 8 lines
source
or dividers by clearing CCM_CCGR2[CG7] to 2’b00. This disables theiomux_ipt_clk_io_clk.
3) ConfigureCCM_CS2CDRfor the new clock source configuration.
4) Enableenfc_clk_rootby setting CCM_CCGR2[CG7] to 2’b11. This enables the
iomux_ipt_clk_io_clk.
5) Enable the GPMI/BCH clocks in registerCCM_CCGR4I got another solution from PHYTEC ([2], not lengthy tested yet), which disables all GPMI/BCH clocks on CCGR4 (verified with a JTAG debugger):
- CCGR4::CG15 [RAWNAND_U_GPMI_INPUT_APB_CLK_ENABLE] - CCGR4::CG14 [RAWNAND_U_GPMI_BCH_INPUT_GPMI_IO_CLK_ENABLE] - CCGR4::CG13 [RAWNAND_U_GPMI_BCH_INPUT_BCH_CLK_ENABLE] - CCGR4::CG12 [RAWNAND_U_BCH_INPUT_APB_CLK_ENABLE] - CCGR4::CG6 [PL301_MX6QPER1_BCHCLK_ENABLE]
Quoted 7 lines
CCM_CCGR2[CG7] is used for
IOMUX_IPT_CLK_IO_ENABLEon i.MX6ULL, so step 2. seems not to apply here. Actually I don't know how to gateENFC_CLK_ROOT.I will cyclic test the solution from PHYTEC over the weekend.
@Han Xu: Should I prefer the solution from PHYTEC? @Stefan Riedmueller: Are you willing to commit this upstream?
Yes sure, I can prepare a patch beginning of next week.
BTW, we have seen these DMA timeout issues on the i.MX6 SOCs as well. So this fix is not only for the i.MX 6ULL.
Regards,
Stefan
Quoted 11 lines
regards
Christian[1] https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf
[2]
https://git.phytec.de/linux-mainline/commit/?h=v5.10.48-phy&id=866939ea8110764d9c12af960d746e2f7f5debe3
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHello,
[email protected] wrote on Fri, 8 Oct 2021 12:08:01 +0000:
Quoted 74 lines
Hi Christian,
Quoted 71 lines · Christian Eggers
+ set PHYTEC developers on (B)CC
Quoted 8 lines · Han Xu
Could you please try to add clock dis/enable when setting clock rate, in case
clock glitches.
clk_disable_unprepare(r->clock[0]);clk_set_rate(r->clock[0], hw->clk_rate);clk_prepare_enable(r->clock[0]);With this change, we made over 2000 successful reboots without any GPMI DMA timeout problems!
From PHYTEC (our BSP supplier), I got some possible background for this problem. For older revisions of IMX6DQ there was an errata (ERR007117, [1]) in the ROM bootloader which triggers a similar / the same behavior:
Quoted 10 lines
For raw NAND boot, ROM switches the source of
enfc_clk_rootfromPLL2_PFD2to PLL3. The root clock is required to be gated before switching the source
clock. If the root clock is not gated, clock glitches might be passed to the divider that follows the clock mux, and the divider might behave unpredictably.
...
This problem can also occur elsewhere in application code if the root clock
is not properly gated when the clock configuration is changed.In my case (Linux boot on i.MX6ULL), I recognized that on the 3rd call of
gpmi_nfc_apply_timings(), the rate of r->clock[0] is changed- from: 22 MHz (CS2CDR::ENFC_CLK_PRED=6 and CS2CDR::ENFC_CLK_PODF=3)
- to: 100 MHz (CS2CDR::ENFC_CLK_PRED=4 and CS2CDR::ENFC_CLK_PODF=1)The proposal from from Han Xu
Quoted 3 lines
clk_disable_unprepare(r->clock[0]);clk_set_rate(r->clock[0], hw->clk_rate);clk_prepare_enable(r->clock[0]);disables only
CCGR4::CG14[RAWNAND_U_GPMI_BCH_INPUT_GPMI_IO_CLK_ENABLE] during
the rate change. While this works very fine on my system, this probably doesn't
fulfill the requirements in the errata description:Quoted 5 lines
For other occurrences in application code, the following procedure should be
followed to change the clock configuration for theenfc_clk_root:
1) Gate (disable) the GPMI/BCH clocks in registerCCM_CCGR4.
2) Gate (disable) theenfc_clk_rootbefore changing theenfc_clk_rootQuoted 8 lines
source
or dividers by clearing CCM_CCGR2[CG7] to 2’b00. This disables theiomux_ipt_clk_io_clk.
3) ConfigureCCM_CS2CDRfor the new clock source configuration.
4) Enableenfc_clk_rootby setting CCM_CCGR2[CG7] to 2’b11. This enables the
iomux_ipt_clk_io_clk.
5) Enable the GPMI/BCH clocks in registerCCM_CCGR4I got another solution from PHYTEC ([2], not lengthy tested yet), which disables all GPMI/BCH clocks on CCGR4 (verified with a JTAG debugger):
- CCGR4::CG15 [RAWNAND_U_GPMI_INPUT_APB_CLK_ENABLE] - CCGR4::CG14 [RAWNAND_U_GPMI_BCH_INPUT_GPMI_IO_CLK_ENABLE] - CCGR4::CG13 [RAWNAND_U_GPMI_BCH_INPUT_BCH_CLK_ENABLE] - CCGR4::CG12 [RAWNAND_U_BCH_INPUT_APB_CLK_ENABLE] - CCGR4::CG6 [PL301_MX6QPER1_BCHCLK_ENABLE]CCM_CCGR2[CG7] is used for
IOMUX_IPT_CLK_IO_ENABLEon i.MX6ULL, so step 2. seems not to apply here. Actually I don't know how to gateENFC_CLK_ROOT.
Quoted 8 lines
Quoted 4 lines
I will cyclic test the solution from PHYTEC over the weekend.
@Han Xu: Should I prefer the solution from PHYTEC? @Stefan Riedmueller: Are you willing to commit this upstream?
Yes sure, I can prepare a patch beginning of next week.
BTW, we have seen these DMA timeout issues on the i.MX6 SOCs as well. So this fix is not only for the i.MX 6ULL.
Could it be possible to quantify the extra time spent in disabling/re-enabling clocks just for the record? So far this driver only supports a single chip and thus frequency changes do not happen frequently (a couple times at boot) but if someday we introduce support for several chips it might become very impacting.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 17 lines · Christian Eggers
I got another solution from PHYTEC ([2], not lengthy tested yet), which disables all GPMI/BCH clocks on CCGR4
(quoted diff) +4
-1-static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) +static int gpmi_nfc_apply_timings(struct gpmi_nand_data *this) { struct gpmi_nfc_hardware_timing *hw = &this->hw; struct resources *r = &this->resources; void __iomem *gpmi_regs = r->gpmi_regs; unsigned int dll_wait_time_us; + int ret; + ret = __gpmi_enable_clk(this, false); + if (ret)
Review
Quoted 10 lines
(quoted diff) +4
-0+ return ret; clk_set_rate(r->clock[0], hw->clk_rate); + ret = __gpmi_enable_clk(this, true); + if (ret) + return ret; writel(hw->timing0, gpmi_regs + HW_GPMI_TIMING0); writel(hw->timing1, gpmi_regs + HW_GPMI_TIMING1);
I think that this is also required for the first call to clk_set_rate() in gpmi_get_clks(). From the kernel's point of view, the clocks are not enabled yet, so no "guard" is required. Putting the same guard here will actually give a warning at runtime that I am trying to disable a clock which is not enabled. But on my system, all clock gates are enabled by the bootloader (barebox) and therefore the glitch could also happen here.
If setting the clock to a "default" rate is really required (on my system, the clock is switched from 99 MHz to 22 MHz, and back to 99 MHz on a later call...), I suggest moving this call to gpmi_nand_probe() (below __gpmi_enable_clock()) and guard it. The result would look like:
...
ret = acquire_resources(this);
if (ret)
goto exit_acquire_resources;
ret = __gpmi_enable_clk(this, true);
if (ret)
goto exit_acquire_resources;
if (GPMI_IS_MX6(this)) {
/*
* Set the default value for the gpmi clock.
*
* If you want to use the ONFI nand which is in the
* Synchronous Mode, you should change the clock as you need.
*/
__gpmi_enable_clk(this, false);
clk_set_rate(this->resources.clock[0], 22000000);
__gpmi_enable_clk(this, true);
}
pm_runtime_set_autosuspend_delay(&pdev->dev, 500);...
It looks a little bit useless to enable the clocks and immediately disable them. But probably this is the only way to make sure that clocks enabled by the bootloader are certainly off.
regards
Christian
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Christian,
[email protected] wrote on Fri, 8 Oct 2021 15:11:59 +0200:
Quoted 57 lines · Christian Eggers
Quoted 18 lines
I got another solution from PHYTEC ([2], not lengthy tested yet), which disables all GPMI/BCH clocks on CCGR4
(quoted diff) +4
-1-static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) +static int gpmi_nfc_apply_timings(struct gpmi_nand_data *this) { struct gpmi_nfc_hardware_timing *hw = &this->hw; struct resources *r = &this->resources; void __iomem *gpmi_regs = r->gpmi_regs; unsigned int dll_wait_time_us; + int ret; + ret = __gpmi_enable_clk(this, false); + if (ret)Review
Quoted 10 lines
(quoted diff) +4
-0+ return ret; clk_set_rate(r->clock[0], hw->clk_rate); + ret = __gpmi_enable_clk(this, true); + if (ret) + return ret; writel(hw->timing0, gpmi_regs + HW_GPMI_TIMING0); writel(hw->timing1, gpmi_regs + HW_GPMI_TIMING1);I think that this is also required for the first call to
clk_set_rate()ingpmi_get_clks(). From the kernel's point of view, the clocks are not enabled yet, so no "guard" is required. Putting the same guard here will actually give a warning at runtime that I am trying to disable a clock which is not enabled. But on my system, all clock gates are enabled by the bootloader (barebox) and therefore the glitch could also happen here.If setting the clock to a "default" rate is really required (on my system, the clock is switched from 99 MHz to 22 MHz, and back to 99 MHz on a later call...), I suggest moving this call to
gpmi_nand_probe()(below__gpmi_enable_clock()) and guard it. The result would look like:...
ret = acquire_resources(this); if (ret) goto exit_acquire_resources; ret = __gpmi_enable_clk(this, true); if (ret) goto exit_acquire_resources; if (GPMI_IS_MX6(this)) { /* * Set the default value for the gpmi clock. * * If you want to use the ONFI nand which is in the
Quoted 8 lines
* Synchronous Mode, you should change the clock as you need. */ __gpmi_enable_clk(this, false); clk_set_rate(this->resources.clock[0], 22000000); __gpmi_enable_clk(this, true); } pm_runtime_set_autosuspend_delay(&pdev->dev, 500);
If this clock (as I understand) does not prevent us to access the registers but only feeds the external NAND bus part, then there is no need to enable it in the probe, just acquiring it will be enough.
Then, the first call for an IO operation with ->must_apply_timings should:
if (imx6) disable_clk(); clk_set_rate(); if (imx6) enable_clk();
I believe this should cover it all.
Quoted 11 lines
...
It looks a little bit useless to enable the clocks and immediately disable them. But probably this is the only way to make sure that clocks enabled by the bootloader are certainly off.
regards
Christian
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainer[email protected] wrote on Fri, 8 Oct 2021 15:29:05 +0200:
Quoted 76 lines
Hi Christian,
[email protected] wrote on Fri, 8 Oct 2021 15:11:59 +0200:
Quoted 57 lines · Christian Eggers
Quoted 18 lines
I got another solution from PHYTEC ([2], not lengthy tested yet), which disables all GPMI/BCH clocks on CCGR4
(quoted diff) +4
-1-static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) +static int gpmi_nfc_apply_timings(struct gpmi_nand_data *this) { struct gpmi_nfc_hardware_timing *hw = &this->hw; struct resources *r = &this->resources; void __iomem *gpmi_regs = r->gpmi_regs; unsigned int dll_wait_time_us; + int ret; + ret = __gpmi_enable_clk(this, false); + if (ret)Review
Quoted 10 lines
(quoted diff) +4
-0+ return ret; clk_set_rate(r->clock[0], hw->clk_rate); + ret = __gpmi_enable_clk(this, true); + if (ret) + return ret; writel(hw->timing0, gpmi_regs + HW_GPMI_TIMING0); writel(hw->timing1, gpmi_regs + HW_GPMI_TIMING1);I think that this is also required for the first call to
clk_set_rate()ingpmi_get_clks(). From the kernel's point of view, the clocks are not enabled yet, so no "guard" is required. Putting the same guard here will actually give a warning at runtime that I am trying to disable a clock which is not enabled. But on my system, all clock gates are enabled by the bootloader (barebox) and therefore the glitch could also happen here.If setting the clock to a "default" rate is really required (on my system, the clock is switched from 99 MHz to 22 MHz, and back to 99 MHz on a later call...), I suggest moving this call to
gpmi_nand_probe()(below__gpmi_enable_clock()) and guard it. The result would look like:...
ret = acquire_resources(this); if (ret) goto exit_acquire_resources; ret = __gpmi_enable_clk(this, true); if (ret) goto exit_acquire_resources; if (GPMI_IS_MX6(this)) { /* * Set the default value for the gpmi clock. * * If you want to use the ONFI nand which is in theQuoted 8 lines
* Synchronous Mode, you should change the clock as you need. */ __gpmi_enable_clk(this, false); clk_set_rate(this->resources.clock[0], 22000000); __gpmi_enable_clk(this, true); } pm_runtime_set_autosuspend_delay(&pdev->dev, 500);If this clock (as I understand) does not prevent us to access the registers but only feeds the external NAND bus part, then there is no need to enable it in the probe, just acquiring it will be enough. Then, the first call for an IO operation with ->must_apply_timings should:
Quoted 7 lines
if (imx6) disable_clk(); clk_set_rate(); if (imx6) enable_clk();
Actually we should ensure clks are enabled in the !imx6 case anyway, but this is needed only once so either we keep enabling the clock in the probe or we check here if the clk has already been enabled or not.
Cheers,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 7 lines · Miquel Raynal
[email protected] wrote on Fri, 8 Oct 2021 15:29:05 +0200:
Quoted 4 lines
If this clock (as I understand) does not prevent us to access the registers but only feeds the external NAND bus part, then there is no need to enable it in the probe, just acquiring it will be enough.
clocks[0] is "gpmi_io" which sounds more like i/o than registers. So lets try to remove the initial call to clk_set_rate().
Quoted 10 lines
Quoted 10 lines
Then, the first call for an IO operation with ->must_apply_timings should:
if (imx6) disable_clk(); clk_set_rate(); if (imx6) enable_clk();
Do you think that the need for avoiding clock glitches is i.MX6 specific? The errata I mentioned is specific for the bootloader software, but (I think) the requirement for switching off the clocks gates prior changing the dividers may apply also for other series.
Quoted 3 lines
Actually we should ensure clks are enabled in the !imx6 case anyway, but this is needed only once so either we keep enabling the clock in the probe or we check here if the clk has already been enabled or not.
The clocks are already enabled (and kept on) in probe. The initial call to clk_set_rate() is just above this (but the clocks are not disabled at this stage as all gates have been enabled by the boot loader).
regards
Christian
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Christian,
[email protected] wrote on Fri, 8 Oct 2021 15:49:21 +0200:
Quoted 20 lines · Miquel Raynal
Quoted 7 lines
[email protected] wrote on Fri, 8 Oct 2021 15:29:05 +0200:
Quoted 4 lines
If this clock (as I understand) does not prevent us to access the registers but only feeds the external NAND bus part, then there is no need to enable it in the probe, just acquiring it will be enough.
clocks[0] is "
gpmi_io" which sounds more like i/o than registers. So lets try to remove the initial call toclk_set_rate().Quoted 8 lines
Quoted 8 lines
Then, the first call for an IO operation with ->must_apply_timings should:
if (imx6) disable_clk(); clk_set_rate();
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
if (imx6) enable_clk();Do you think that the need for avoiding clock glitches is i.MX6 specific? The errata I mentioned is specific for the bootloader software, but (I think) the requirement for switching off the clocks gates prior changing the dividers may apply also for other series.
I honestly don't know, perhaps Han have more details about it. If you think it's a wider issue, then we can just do the disable/enable step without any further checks.
Quoted 6 lines
Quoted 3 lines
Actually we should ensure clks are enabled in the !imx6 case anyway, but this is needed only once so either we keep enabling the clock in the probe or we check here if the clk has already been enabled or not.
The clocks are already enabled (and kept on) in probe. The initial call to
clk_set_rate()is just above this (but the clocks are not disabled at this stage as all gates have been enabled by the boot loader).
The IO clock should be enabled and set to a particular rate the first time the die is selected to perform a NAND operation, or when we switch from one device to the other (this does not apply to the GPMI driver for now). So we can drop the enable/set_rate call in the probe if the assumption that this clock only feeds the external bus is right.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi
Quoted 28 lines · Miquel Raynal
Hi Christian,
[email protected] wrote on Fri, 8 Oct 2021 15:49:21 +0200:
Quoted 23 lines · Miquel Raynal
Quoted 7 lines
[email protected] wrote on Fri, 8 Oct 2021 15:29:05 +0200:
Quoted 4 lines
If this clock (as I understand) does not prevent us to access the registers but only feeds the external NAND bus part, then there is no need to enable it in the probe, just acquiring it will be enough.
clocks[0] is "
gpmi_io" which sounds more like i/o than registers. So lets try to remove the initial call toclk_set_rate().Quoted 10 lines
Quoted 10 lines
Then, the first call for an IO operation with ->must_apply_timings should:
if (imx6) disable_clk(); clk_set_rate(); if (imx6) enable_clk();
Quoted 9 lines
Quoted 4 lines
Do you think that the need for avoiding clock glitches is i.MX6 specific? The errata I mentioned is specific for the bootloader software, but (I think) the requirement for switching off the clocks gates prior changing the dividers may apply also for other series.
I honestly don't know, perhaps Han have more details about it. If you think it's a wider issue, then we can just do the disable/enable step without any further checks.
Still don't explain why it was working on the old driver. The glitch was already there,
so just a delay can do the trick. For imx28 we need to reparent to a different clock the
nand driver in order to get the frequency we want in EDO mode. I'm still thinking that
set the frequency without without get back and understand if in that edo mode is valid
is still a bug.
Michael
Quoted 15 lines
Quoted 6 lines
Quoted 3 lines
Actually we should ensure clks are enabled in the !imx6 case anyway, but this is needed only once so either we keep enabling the clock in the probe or we check here if the clk has already been enabled or not.
The clocks are already enabled (and kept on) in probe. The initial call to
clk_set_rate()is just above this (but the clocks are not disabled at this stage as all gates have been enabled by the boot loader).The IO clock should be enabled and set to a particular rate the first time the die is selected to perform a NAND operation, or when we switch from one device to the other (this does not apply to the GPMI driver for now). So we can drop the enable/set_rate call in the probe if the assumption that this clock only feeds the external bus is right.
Thanks,
Miquèl
Signature · 15 lines
Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 [email protected] __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 [email protected] www.amarulasolutions.com ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Michael,
[email protected] wrote on Sat, 9 Oct 2021 07:53:26 +0200:
Quoted 41 lines
Hi
Quoted 28 lines · Miquel Raynal
Hi Christian,
[email protected] wrote on Fri, 8 Oct 2021 15:49:21 +0200:
Quoted 23 lines · Miquel Raynal
Quoted 7 lines
[email protected] wrote on Fri, 8 Oct 2021 15:29:05 +0200:
Quoted 4 lines
If this clock (as I understand) does not prevent us to access the registers but only feeds the external NAND bus part, then there is no need to enable it in the probe, just acquiring it will be enough.
clocks[0] is "
gpmi_io" which sounds more like i/o than registers. So lets try to remove the initial call toclk_set_rate().Quoted 10 lines
Quoted 10 lines
Then, the first call for an IO operation with ->must_apply_timings should:
if (imx6) disable_clk(); clk_set_rate(); if (imx6) enable_clk();Quoted 9 lines
Quoted 4 lines
Do you think that the need for avoiding clock glitches is i.MX6 specific? The errata I mentioned is specific for the bootloader software, but (I think) the requirement for switching off the clocks gates prior changing the dividers may apply also for other series.
I honestly don't know, perhaps Han have more details about it. If you think it's a wider issue, then we can just do the disable/enable step without any further checks.
Quoted 9 lines
Still don't explain why it was working on the old driver. The glitch was already there,
so just a delay can do the trick. For imx28 we need to reparent to a different clock the
nand driver in order to get the frequency we want in EDO mode. I'm still thinking that
set the frequency without without get back and understand if in that edo mode is valid
is still a bug.
There are possibly two bugs here, I am also in favor of checking that the received frequencies match what we expect, so please provide a patch to also cover that situation.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
RFC PATCH 1/2 mtd: rawnand: gpmi: Remove explicit default gpmi clock setting for i.MX6
There is no need to explicitly set the default gpmi clock rate during boot for the i.MX 6 since this is done during nand_detect anyway.
--- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 9 --------- 1 file changed, 9 deletions(-)
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0 -9
@@ -1034,15 +1034,6 @@ static int gpmi_get_clks(struct gpmi_nand_data *this) r->clock[i] = clk; } -if (GPMI_IS_MX6 (this)) -/* -* Set the default value for the gpmi clock. -* -* If you want to use the ONFI nand which is in the -* Synchronous Mode, you should change the clock as you need. -*/ -clk_set_rate (r->clock[0 ],22000000 ); -return 0 ; err_clock:
Signature · 6 lines
2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
RFC PATCH 2/2 gpmi-nand: Add ERR007117 protection for nfc_apply_timings
According to i.MX 6 erratum ERR007117 gpmi clocks need to be gated off when doing a gpmi_io clk rate change. So gate the clocks off before the rate change in nfc_apply_timings and ungate them again after the change.
Otherwise this rate change can lead to an unresponsive GPMI core which results in DMA timeouts and failed driver probe:
[ 4.072318] gpmi-nand 112000.gpmi-nand: DMA timeout, last DMA ... [ 4.370355] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -110 ... [ 4.375988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.381524] gpmi-nand 112000.gpmi-nand: Error in ECC-based read: -22 [ 4.387988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.393535] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22
...
---
Hi,
I'm not sure about the error handling here, if it is actually neccessary. So some feedback would be nice here.
Thanks,
Stefan
--- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +19 -2
@@ -713,15 +713,28 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); } -static void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) +static int gpmi_nfc_apply_timings (struct gpmi_nand_data *this) {struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; +int ret; + +if (GPMI_IS_MX6Q (this)) { + ret =__gpmi_enable_clk (this, false); +if (ret) +return ret; + }clk_set_rate (r->clock[0 ], hw->clk_rate); +if (GPMI_IS_MX6Q (this)) { + ret =__gpmi_enable_clk (this, true); +if (ret) +return ret; + } +writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );
@@ -739,6 +752,8 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us); + +return 0 ; } static int gpmi_setup_interface(struct nand_chip *chip, int chipnr,
@@ -2271,7 +2286,9 @@ static int gpmi_nfc_exec_op(struct nand_chip *chip,*/ if (this->hw.must_apply_timings) { this->hw.must_apply_timings = false; -gpmi_nfc_apply_timings (this); + ret =gpmi_nfc_apply_timings (this); +if (ret) +return ret; }dev_dbg (this->dev,"%s: %d instructions\n" , __func__, op->ninstrs);
Signature · 6 lines
2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Han Xu
maintainerRe: [RFC PATCH 2/2] gpmi-nand: Add ERR007117 protection for nfc_apply_timings
Quoted 39 lines · Stefan Riedmueller
According to i.MX 6 erratum ERR007117 gpmi clocks need to be gated off when doing a
gpmi_ioclk rate change. So gate the clocks off before the rate change innfc_apply_timingsand ungate them again after the change.Otherwise this rate change can lead to an unresponsive GPMI core which results in DMA timeouts and failed driver probe:
[ 4.072318] gpmi-nand 112000.gpmi-nand: DMA timeout, last DMA ... [ 4.370355] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -110 ... [ 4.375988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.381524] gpmi-nand 112000.gpmi-nand: Error in ECC-based read: -22 [ 4.387988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.393535] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22...
Signed-off-by Stefan Riedmueller <[email protected]>---
Hi,I'm not sure about the error handling here, if it is actually neccessary. So some feedback would be nice here.
Thanks,
Stefan--- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0@@ -713,15 +713,28 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); }
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, · line 724
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +4
-1-static void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) +static int gpmi_nfc_apply_timings (struct gpmi_nand_data *this) {struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; +int ret; + +if (GPMI_IS_MX6Q (this)) {
Not only for 6Q but for GPMI_IS_MX6
Quoted 39 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +15
-1+ ret =__gpmi_enable_clk (this, false); +if (ret) +return ret; + }clk_set_rate (r->clock[0 ], hw->clk_rate); +if (GPMI_IS_MX6Q (this)) { + ret =__gpmi_enable_clk (this, true); +if (ret) +return ret; + } +writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );@@ -739,6 +752,8 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us); + +return 0 ; } static int gpmi_setup_interface(struct nand_chip *chip, int chipnr,@@ -2271,7 +2286,9 @@ static int gpmi_nfc_exec_op(struct nand_chip *chip,*/ if (this->hw.must_apply_timings) { this->hw.must_apply_timings = false; -gpmi_nfc_apply_timings (this); + ret =gpmi_nfc_apply_timings (this); +if (ret) +return ret; }dev_dbg (this->dev,"%s: %d instructions\n" , __func__, op->ninstrs);Signature · 1 line
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Re: [RFC PATCH 2/2] gpmi-nand: Add ERR007117 protection for nfc_apply_timings
Hi Han,
sorry it took me some time to get back to you.
Quoted 43 lines · Han Xu
Quoted 42 lines · Stefan Riedmueller
According to i.MX 6 erratum ERR007117 gpmi clocks need to be gated off when doing a
gpmi_ioclk rate change. So gate the clocks off before the rate change innfc_apply_timingsand ungate them again after the change.Otherwise this rate change can lead to an unresponsive GPMI core which results in DMA timeouts and failed driver probe:
[ 4.072318] gpmi-nand 112000.gpmi-nand: DMA timeout, last DMA ... [ 4.370355] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -110 ... [ 4.375988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.381524] gpmi-nand 112000.gpmi-nand: Error in ECC-based read: -22 [ 4.387988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.393535] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22...
Signed-off-by Stefan Riedmueller <[email protected]>---
Hi,I'm not sure about the error handling here, if it is actually neccessary. So some feedback would be nice here.
Thanks,
Stefan--- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0@@ -713,15 +713,28 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); }
Quoted 12 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, · line 724
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +4
-1-static void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) +static int gpmi_nfc_apply_timings (struct gpmi_nand_data *this) {struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; +int ret; + +if (GPMI_IS_MX6Q (this)) {Not only for 6Q but for
GPMI_IS_MX6
Can you confirm that i.MX 6SX and i.MX 7 are affected by the ERR007117 erratum as well? Because the i.MX 6UL/ULL are included by the GPMI_IS_MX6Q already.
Or do we need another macro for i.MX 6UL/ULL as Christian has suggested earlier?
Thanks,
Stefan
Quoted 37 lines
Quoted 37 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +10
-0+ ret =__gpmi_enable_clk (this, false); +if (ret) +return ret; + }clk_set_rate (r->clock[0 ], hw->clk_rate); +if (GPMI_IS_MX6Q (this)) { + ret =__gpmi_enable_clk (this, true); +if (ret) +return ret; + } +writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-0writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );@@ -739,6 +752,8 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us ); + +return 0 ; }static int gpmi_setup_interface(struct
nand_chip*chip, int chipnr,drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +3
-1@@ -2271,7 +2286,9 @@ static int gpmi_nfc_exec_op(struct nand_chip *chip,*/ if (this->hw.must_apply_timings) { this->hw.must_apply_timings = false; -gpmi_nfc_apply_timings (this); + ret =gpmi_nfc_apply_timings (this); +if (ret) +return ret; }
Quoted 4 lines
Quoted 4 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0dev_dbg (this->dev,"%s: %d instructions\n" , __func__, op->ninstrs);Signature · 1 line
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
[email protected]
maintainerRe: [RFC PATCH 2/2] gpmi-nand: Add ERR007117 protection for nfc_apply_timings
Quoted 61 lines · Stefan Riedmüller
Hi Han,
sorry it took me some time to get back to you.
Quoted 43 lines · Han Xu
Quoted 42 lines · Stefan Riedmueller
According to i.MX 6 erratum ERR007117 gpmi clocks need to be gated off when doing a
gpmi_ioclk rate change. So gate the clocks off before the rate change innfc_apply_timingsand ungate them again after the change.Otherwise this rate change can lead to an unresponsive GPMI core which results in DMA timeouts and failed driver probe:
[ 4.072318] gpmi-nand 112000.gpmi-nand: DMA timeout, last DMA ... [ 4.370355] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -110 ... [ 4.375988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.381524] gpmi-nand 112000.gpmi-nand: Error in ECC-based read: -22 [ 4.387988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.393535] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22...
Signed-off-by Stefan Riedmueller <[email protected]>---
Hi,I'm not sure about the error handling here, if it is actually neccessary. So some feedback would be nice here.
Thanks,
Stefan--- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0@@ -713,15 +713,28 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); }Quoted 12 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, · line 724
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +4
-1-static void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) +static int gpmi_nfc_apply_timings (struct gpmi_nand_data *this) {struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; +int ret; + +if (GPMI_IS_MX6Q (this)) {Not only for 6Q but for
GPMI_IS_MX6
Quoted 2 lines
Can you confirm that i.MX 6SX and i.MX 7 are affected by the ERR007117 erratum as well? Because the i.MX 6UL/ULL are included by the
GPMI_IS_MX6Qalready.
i.MX6SX has the glitch issue for sure, but I can double check if it's due to the same errata. I will also go check if the errata will affect i.MX7
Quoted 44 lines
Or do we need another macro for i.MX 6UL/ULL as Christian has suggested earlier?
Thanks,
StefanQuoted 37 lines
Quoted 37 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +10
-0+ ret =__gpmi_enable_clk (this, false); +if (ret) +return ret; + }clk_set_rate (r->clock[0 ], hw->clk_rate); +if (GPMI_IS_MX6Q (this)) { + ret =__gpmi_enable_clk (this, true); +if (ret) +return ret; + } +writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +2
-0writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );@@ -739,6 +752,8 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us ); + +return 0 ; }static int gpmi_setup_interface(struct
nand_chip*chip, int chipnr,drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +3
-1@@ -2271,7 +2286,9 @@ static int gpmi_nfc_exec_op(struct nand_chip *chip,*/ if (this->hw.must_apply_timings) { this->hw.must_apply_timings = false; -gpmi_nfc_apply_timings (this); + ret =gpmi_nfc_apply_timings (this); +if (ret) +return ret; }
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0dev_dbg (this->dev,"%s: %d instructions\n" , __func__, op->ninstrs);Signature · 1 line
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Re: [RFC PATCH 2/2] gpmi-nand: Add ERR007117 protection for nfc_apply_timings
Hi Han,
Quoted 65 lines · On Fri, 2021-10-22 at 09:35 -0500, [email protected] wrote:
Quoted 64 lines · Stefan Riedmüller
Hi Han,
sorry it took me some time to get back to you.
Quoted 58 lines · Han Xu
Quoted 45 lines · Stefan Riedmueller
According to i.MX 6 erratum ERR007117 gpmi clocks need to be gated off when doing a
gpmi_ioclk rate change. So gate the clocks off before the rate change innfc_apply_timingsand ungate them again after the change.Otherwise this rate change can lead to an unresponsive GPMI core which results in DMA timeouts and failed driver probe:
[ 4.072318] gpmi-nand 112000.gpmi-nand: DMA timeout, last DMA ... [ 4.370355] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -110 ... [ 4.375988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.381524] gpmi-nand 112000.gpmi-nand: Error in ECC-based read: -22 [ 4.387988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.393535] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22...
Signed-off-by Stefan Riedmueller <[email protected]>---
Hi,I'm not sure about the error handling here, if it is actually neccessary.
So some feedback would be nice here.Thanks,
Stefan--- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0@@ -713,15 +713,28 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, (use_half_period ?
BM_GPMI_CTRL1_HALF_PERIOD:
0);
}drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, · line 724
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +4
-1-static void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) +static int gpmi_nfc_apply_timings (struct gpmi_nand_data *this) {struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; +int ret; + +if (GPMI_IS_MX6Q (this)) {Not only for 6Q but for
GPMI_IS_MX6
Quoted 8 lines
Quoted 4 lines
Can you confirm that i.MX 6SX and i.MX 7 are affected by the ERR007117 erratum
as well? Because the i.MX 6UL/ULL are included by theGPMI_IS_MX6Qalready.i.MX6SX has the glitch issue for sure, but I can double check if it's due to the
same errata. I will also go check if the errata will affect i.MX7
Thanks, that'll be great!
I'll wait for your response.
Thanks,
Stefan
Quoted 44 lines
Quoted 44 lines
Or do we need another macro for i.MX 6UL/ULL as Christian has suggested earlier?
Thanks,
StefanQuoted 37 lines
Quoted 37 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +12
-0+ ret =__gpmi_enable_clk (this, false); +if (ret) +return ret; + }clk_set_rate (r->clock[0 ], hw->clk_rate); +if (GPMI_IS_MX6Q (this)) { + ret =__gpmi_enable_clk (this, true); +if (ret) +return ret; + } +writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );@@ -739,6 +752,8 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us ); + +return 0 ; }static int gpmi_setup_interface(struct
nand_chip*chip, int chipnr,drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +3
-1@@ -2271,7 +2286,9 @@ static int gpmi_nfc_exec_op(struct nand_chip*chip, */ if (this->hw.must_apply_timings) { this->hw.must_apply_timings = false; -gpmi_nfc_apply_timings (this); + ret =gpmi_nfc_apply_timings (this); +if (ret) +return ret; }
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
dev_dbg(this->dev, "%s: %d instructions\n",
__func__, op-Quoted 1 line
ninstrs);
Signature · 1 line
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Re: [RFC PATCH 2/2] gpmi-nand: Add ERR007117 protection for nfc_apply_timings
In reply to [email protected]Hi Han,
Quoted 65 lines · On Fri, 2021-10-22 at 09:35 -0500, [email protected] wrote:
Quoted 64 lines · Stefan Riedmüller
Hi Han,
sorry it took me some time to get back to you.
Quoted 58 lines · Han Xu
Quoted 45 lines · Stefan Riedmueller
According to i.MX 6 erratum ERR007117 gpmi clocks need to be gated off when doing a
gpmi_ioclk rate change. So gate the clocks off before the rate change innfc_apply_timingsand ungate them again after the change.Otherwise this rate change can lead to an unresponsive GPMI core which results in DMA timeouts and failed driver probe:
[ 4.072318] gpmi-nand 112000.gpmi-nand: DMA timeout, last DMA ... [ 4.370355] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -110 ... [ 4.375988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.381524] gpmi-nand 112000.gpmi-nand: Error in ECC-based read: -22 [ 4.387988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.393535] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22...
Signed-off-by Stefan Riedmueller <[email protected]>---
Hi,I'm not sure about the error handling here, if it is actually neccessary.
So some feedback would be nice here.Thanks,
Stefan--- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0@@ -713,15 +713,28 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, (use_half_period ?
BM_GPMI_CTRL1_HALF_PERIOD:
0);
}drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, · line 724
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +4
-1-static void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) +static int gpmi_nfc_apply_timings (struct gpmi_nand_data *this) {struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; +int ret; + +if (GPMI_IS_MX6Q (this)) {Not only for 6Q but for
GPMI_IS_MX6
Quoted 8 lines
Quoted 4 lines
Can you confirm that i.MX 6SX and i.MX 7 are affected by the ERR007117 erratum
as well? Because the i.MX 6UL/ULL are included by theGPMI_IS_MX6Qalready.i.MX6SX has the glitch issue for sure, but I can double check if it's due to the
same errata. I will also go check if the errata will affect i.MX7
Any updates yet?
Thanks,
Stefan
Quoted 44 lines
Quoted 44 lines
Or do we need another macro for i.MX 6UL/ULL as Christian has suggested earlier?
Thanks,
StefanQuoted 37 lines
Quoted 37 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +12
-0+ ret =__gpmi_enable_clk (this, false); +if (ret) +return ret; + }clk_set_rate (r->clock[0 ], hw->clk_rate); +if (GPMI_IS_MX6Q (this)) { + ret =__gpmi_enable_clk (this, true); +if (ret) +return ret; + } +writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );@@ -739,6 +752,8 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us ); + +return 0 ; }static int gpmi_setup_interface(struct
nand_chip*chip, int chipnr,drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +3
-1@@ -2271,7 +2286,9 @@ static int gpmi_nfc_exec_op(struct nand_chip*chip, */ if (this->hw.must_apply_timings) { this->hw.must_apply_timings = false; -gpmi_nfc_apply_timings (this); + ret =gpmi_nfc_apply_timings (this); +if (ret) +return ret; }
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
dev_dbg(this->dev, "%s: %d instructions\n",
__func__, op-Quoted 1 line
ninstrs);
Signature · 1 line
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
[email protected]
maintainerRe: [RFC PATCH 2/2] gpmi-nand: Add ERR007117 protection for nfc_apply_timings
Quoted 73 lines · Stefan Riedmüller
Hi Han,
Quoted 70 lines · On Fri, 2021-10-22 at 09:35 -0500, [email protected] wrote:
Quoted 68 lines · Stefan Riedmüller
Hi Han,
sorry it took me some time to get back to you.
Quoted 46 lines · Han Xu
Quoted 45 lines · Stefan Riedmueller
According to i.MX 6 erratum ERR007117 gpmi clocks need to be gated off when doing a
gpmi_ioclk rate change. So gate the clocks off before the rate change innfc_apply_timingsand ungate them again after the change.Otherwise this rate change can lead to an unresponsive GPMI core which results in DMA timeouts and failed driver probe:
[ 4.072318] gpmi-nand 112000.gpmi-nand: DMA timeout, last DMA ... [ 4.370355] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -110 ... [ 4.375988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.381524] gpmi-nand 112000.gpmi-nand: Error in ECC-based read: -22 [ 4.387988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.393535] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22...
Signed-off-by Stefan Riedmueller <[email protected]>---
Hi,I'm not sure about the error handling here, if it is actually neccessary.
So some feedback would be nice here.Thanks,
Stefan--- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0@@ -713,15 +713,28 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, (use_half_period ?
BM_GPMI_CTRL1_HALF_PERIOD:
0);
}Quoted 12 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, · line 724
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +4
-1-static void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) +static int gpmi_nfc_apply_timings (struct gpmi_nand_data *this) {struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; +int ret; + +if (GPMI_IS_MX6Q (this)) {Not only for 6Q but for
GPMI_IS_MX6Can you confirm that i.MX 6SX and i.MX 7 are affected by the ERR007117 erratum
as well? Because the i.MX 6UL/ULL are included by theGPMI_IS_MX6Qalready.
Quoted 8 lines
Quoted 3 lines
i.MX6SX has the glitch issue for sure, but I can double check if it's due to the
same errata. I will also go check if the errata will affect i.MX7Any updates yet?
Thanks,
Stefan
Sorry Stefan, I didn't get useful info so I involved more people for this question. Hopefully can get an answer soon.
Or you can just add 6Q and 6UL/ULL first.
Quoted 45 lines
Quoted 45 lines
Quoted 45 lines
Or do we need another macro for i.MX 6UL/ULL as Christian has suggested earlier?
Thanks,
StefanQuoted 37 lines
Quoted 37 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +12
-0+ ret =__gpmi_enable_clk (this, false); +if (ret) +return ret; + }clk_set_rate (r->clock[0 ], hw->clk_rate); +if (GPMI_IS_MX6Q (this)) { + ret =__gpmi_enable_clk (this, true); +if (ret) +return ret; + } +writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );@@ -739,6 +752,8 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us ); + +return 0 ; }static int gpmi_setup_interface(struct
nand_chip*chip, int chipnr,drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +3
-1@@ -2271,7 +2286,9 @@ static int gpmi_nfc_exec_op(struct nand_chip*chip, */ if (this->hw.must_apply_timings) { this->hw.must_apply_timings = false; -gpmi_nfc_apply_timings (this); + ret =gpmi_nfc_apply_timings (this); +if (ret) +return ret; }
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
dev_dbg(this->dev, "%s: %d instructions\n",
__func__, op-Quoted 1 line
ninstrs);
Signature · 1 line
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Re: [RFC PATCH 2/2] gpmi-nand: Add ERR007117 protection for nfc_apply_timings
In reply to Stefan RiedmuellerQuoted 16 lines · Stefan Riedmueller
According to i.MX 6 erratum ERR007117 gpmi clocks need to be gated off when doing a
gpmi_ioclk rate change. So gate the clocks off before the rate change innfc_apply_timingsand ungate them again after the change.Otherwise this rate change can lead to an unresponsive GPMI core which results in DMA timeouts and failed driver probe:
[ 4.072318] gpmi-nand 112000.gpmi-nand: DMA timeout, last DMA ... [ 4.370355] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -110 ... [ 4.375988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.381524] gpmi-nand 112000.gpmi-nand: Error in ECC-based read: -22 [ 4.387988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22 [ 4.393535] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22
Quoted 5 lines
...
Signed-off-by Stefan Riedmueller <[email protected]>---
Hi,
Hi Stefan,
thanks for providing the patches! I am suffering from this problem for some time now and I am happy to get this fixed!
Quoted 3 lines
I'm not sure about the error handling here, if it is actually neccessary. So some feedback would be nice here.
IMHO errors should always be handled.
Quoted 15 lines
Thanks,
Stefan--- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-0@@ -713,15 +713,28 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, (use_half_period ?BM_GPMI_CTRL1_HALF_PERIOD :0 ); }
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this, · line 724
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +4
-1-static void gpmi_nfc_apply_timings (struct gpmi_nand_data *this) +static int gpmi_nfc_apply_timings (struct gpmi_nand_data *this) {struct gpmi_nfc_hardware_timing *hw = &this->hw;struct resources *r = &this->resources;void __iomem *gpmi_regs = r->gpmi_regs;unsigned int dll_wait_time_us; +int ret; + +if (GPMI_IS_MX6Q (this)) {
I would like to explicitly see i.MX6UL(L) here (in order to make clear that not only Solo/Dual/Quad are affected):
#define GPMI_IS_MX6UL(x) ((x)->devdata->type == IS_MX6Q)
...
if (GPMI_IS_MX6Q(this) || GPMI_IS_MX6UL(this)) {
But if Han Xu is sure that also SoloX and i.MX7 are affected, GPMI_IS_MX6(x) is fine for me. In this case I would like to explicitly mention this in the commit message, so that nobody will change this later because ERR007117 exists only for Solo/Dual/Quad.
Quoted 27 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +12
-0+ ret =__gpmi_enable_clk (this, false); +if (ret) +return ret; + }clk_set_rate (r->clock[0 ], hw->clk_rate); +if (GPMI_IS_MX6Q (this)) { + ret =__gpmi_enable_clk (this, true); +if (ret) +return ret; + } +writel (hw->timing0, gpmi_regs +HW_GPMI_TIMING0 );writel (hw->timing1, gpmi_regs +HW_GPMI_TIMING1 );@@ -739,6 +752,8 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)/* Wait for the DLL to settle. */ udelay (dll_wait_time_us); + +return 0 ; } static int gpmi_setup_interface(struct nand_chip *chip, int chipnr,
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static int gpmi_nfc_exec_op(struct nand_chip *chip, · line 2294
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +3
-1@@ -2271,7 +2286,9 @@ static int gpmi_nfc_exec_op(struct nand_chip *chip,*/ if (this->hw.must_apply_timings) { this->hw.must_apply_timings = false; -gpmi_nfc_apply_timings (this); + ret =gpmi_nfc_apply_timings (this); +if (ret) +return ret; }dev_dbg (this->dev,"%s: %d instructions\n" , __func__, op->ninstrs);
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Re: [RFC PATCH 1/2] mtd: rawnand: gpmi: Remove explicit default gpmi clock setting for i.MX6
In reply to Stefan RiedmuellerQuoted 19 lines · Stefan Riedmueller
There is no need to explicitly set the default gpmi clock rate during boot for the i.MX 6 since this is done during
nand_detectanyway.Signed-off-by Stefan Riedmueller <[email protected]>--- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 9 --------- 1 file changed, 9 deletions(-)drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-2@@ -1034,15 +1034,6 @@ static int gpmi_get_clks(struct gpmi_nand_data *this) r->clock[i] = clk; } -if (GPMI_IS_MX6 (this)) -/*
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c static int gpmi_get_clks(struct gpmi_nand_data *this) · line 1039
Quoted 10 lines
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +0
-7-* Set the default value for the gpmi clock. -* -* If you want to use the ONFI nand which is in the -* Synchronous Mode, you should change the clock as you need. -*/ -clk_set_rate (r->clock[0 ],22000000 ); -return 0 ; err_clock:
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 15 lines · Miquel Raynal
Hi Christian,
[email protected] wrote on Fri, 8 Oct 2021 15:49:21 +0200:
Quoted 11 lines · Miquel Raynal
Quoted 7 lines
[email protected] wrote on Fri, 8 Oct 2021 15:29:05 +0200:
Quoted 4 lines
If this clock (as I understand) does not prevent us to access the registers but only feeds the external NAND bus part, then there is no need to enable it in the probe, just acquiring it will be enough.
clocks[0] is "
gpmi_io" which sounds more like i/o than registers. So lets try to remove the initial call toclk_set_rate().
From the GPMI description (i.MX6 ULL):
Quoted 3 lines
[GPMI] Registers are clocked on the HCLK domain. The I/O and pin timing are clocked on a dedicated GPMICLK domain. GPMICLK can be set to maximize I/O performance.
Additionally, figure 17-1 in IMX6ULLRM.pdf shows that both (BCH and GPMI) registers are connected to APBH.
I checked this with the debugger: For accessing the BCH and GPMI registers, only CCGR0::CG2 [APBHDMA_HCLK_ENABLE] is required. This bit is enabled in mxs_dma_alloc_chan_resources():
-000|mxs_dma_alloc_chan_resources(chan = 0xC2090154) -001|__refcount_inc_not_zero(inline) -001|refcount_inc_not_zero(inline) -001|kref_get_unless_zero(inline) -001|dma_chan_get(:chan = 0xC2090154) -002|find_candidate(device = 0xC2090050, :mask = 0xC209BD38, :fn = 0xC0254679, :fn_param = 0xC209BD3C) -003|__dma_request_channel(:mask = 0xC209BD38, :fn = 0xC0254679, :fn_param = 0xC209BD3C, np = 0xC7EEB0B0) -004|mxs_dma_xlate(:dma_spec = 0xC209BD60, :ofdma = 0xC2264840) -005|of_dma_request_slave_channel(np = 0xC7EEB2B4, name = 0xC04F923A -> "rx-tx") -006|dma_request_chan(dev = 0xC2182410, :name = 0xC04F923A -> "rx-tx") -007|acquire_dma_channels(inline) -007|acquire_resources(:this = 0xC200F840) -008|gpmi_nand_probe(:pdev = 0xC2182400)
The root clock is BCH_CLK_ROOT. It doesn't depend on ENFC_PRED or ENFC_PODF (the dividers which are actually set in clk_set_rate(r->clock[0], 22000000)).
--> clk_set_rate(r->clock[0], 22000000) is not required for accessing the registers. I removed the call entirely and everything works fine.
Quoted 12 lines
Quoted 12 lines
Quoted 11 lines
Quoted 11 lines
Then, the first call for an IO operation with ->must_apply_timings should:
if (imx6) disable_clk(); clk_set_rate(); if (imx6) enable_clk();
Quoted 8 lines
Quoted 4 lines
Do you think that the need for avoiding clock glitches is i.MX6 specific? The errata I mentioned is specific for the bootloader software, but (I think) the requirement for switching off the clocks gates prior changing the dividers may apply also for other series.
I honestly don't know, perhaps Han have more details about it. If you think it's a wider issue, then we can just do the disable/enable step without any further checks.
I also don't know. I can not find the required sequence in the reference manual (only in the errata sheet), so I cannot compare with other series. For best performance we can start with checking for GPMI_IS_MX6Q(x) and extend it later if this issue comes up on other devices.
I sent a question for this on NXP community:
https://community.nxp.com/t5/i-MX-Processors/ERR007117-Which-i-MX-devices-require-gating-the-clocks-when/m-p/1353018
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Actually we should ensure clks are enabled in the !imx6 case anyway, but this is needed only once so either we keep enabling the clock in the probe or we check here if the clk has already been enabled or not.
The clocks are already enabled (and kept on) in probe. The initial call to
clk_set_rate()is just above this (but the clocks are not disabled at this stage as all gates have been enabled by the boot loader).
Quoted 5 lines
The IO clock should be enabled and set to a particular rate the first time the die is selected to perform a NAND operation, or when we switch from one device to the other (this does not apply to the GPMI driver for now). So we can drop the enable/set_rate call in the probe if the assumption that this clock only feeds the external bus is right.
I think that this assumption is right.
regards
Christian
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 13 lines · Christian Eggers
Quoted 8 lines
Quoted 4 lines
Do you think that the need for avoiding clock glitches is i.MX6 specific? The errata I mentioned is specific for the bootloader software, but (I think) the requirement for switching off the clocks gates prior changing the dividers may apply also for other series.
I honestly don't know, perhaps Han have more details about it. If you think it's a wider issue, then we can just do the disable/enable step without any further checks.
I also don't know. I can not find the required sequence in the reference manual (only in the errata sheet), so I cannot compare with other series. For best performance we can start with checking for
GPMI_IS_MX6Q(x)and extend it later if this issue comes up on other devices.
Quoted 6 lines
I sent a question for this on NXP community:
https://community.nxp.com/t5/i-MX-Processors/ERR007117-Which-i-MX-devices-require-gating-the-clocks-when/m-p/13530181. Which i.MX models / series require this sequence?
2. Where can I find this sequence in the reference manuals (e.g. for i.MX6 ULL)?
3. How is CCM_CCGR2[CG7] (iomux_ipt_clk_io_clk) related to "gatingenfc_clk_root"?
@Han Xu: Can you provide further information about this? Do you have contact to the hardware developers?
regards
Christian
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 11 lines · Miquel Raynal
Hello,
Could it be possible to quantify the extra time spent in disabling/re-enabling clocks just for the record? So far this driver only supports a single chip and thus frequency changes do not happen frequently (a couple times at boot) but if someday we introduce support for several chips it might become very impacting.
Thanks,
Miquèl
ktime_t start = ktime_get(), duration;__gpmi_enable_clk(this, false);clk_set_rate(r->clock[0], hw->clk_rate);__gpmi_enable_clk(this, true);
duration = ktime_get() - start;printk(KERN_ERR "%s() duration = %lld ns\n", __func__, ktime_to_ns(duration));
-->
gpmi_nfc_apply_timings() duration = 39250 ns
...
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xdc
nand: Micron MT29F4G08ABADAH4
nand: 512 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 gpmi_nfc_apply_timings() duration = 36750 ns gpmi_nfc_apply_timings() duration = 170750 ns
On i.MX6ULL @ 792MHz this takes less than 250 us.
regards
Christian
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHi Christian,
[email protected] wrote on Fri, 8 Oct 2021 15:13:17 +0200:
Quoted 31 lines · Miquel Raynal
Quoted 11 lines
Hello,
Could it be possible to quantify the extra time spent in disabling/re-enabling clocks just for the record? So far this driver only supports a single chip and thus frequency changes do not happen frequently (a couple times at boot) but if someday we introduce support for several chips it might become very impacting.
Thanks,
Miquèl
ktime_tstart =ktime_get(), duration;__gpmi_enable_clk(this, false);clk_set_rate(r->clock[0], hw->clk_rate);__gpmi_enable_clk(this, true);
duration =ktime_get()- start;printk(KERN_ERR "%s() duration = %lld ns\n", __func__, ktime_to_ns(duration));-->
gpmi_nfc_apply_timings()duration = 39250 ns
...
nand: device found, Manufacturer ID:0x2c, Chip ID:0xdc
nand: Micron MT29F4G08ABADAH4
nand: 512 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64gpmi_nfc_apply_timings()duration = 36750 nsgpmi_nfc_apply_timings()duration = 170750 ns
Quoted 1 line
On i.MX6ULL @ 792MHz this takes less than 250 us.
Ok thanks for the feedback. This is not negligible if we start switching between chips with different frequencies quite regularly.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 6 lines · Stefan Riedmüller
Quoted 1 line · Christian Eggers
@Stefan Riedmueller: Are you willing to commit this upstream?
Yes sure, I can prepare a patch beginning of next week.
BTW, we have seen these DMA timeout issues on the i.MX6 SOCs as well. So this fix is not only for the i.MX 6ULL.
Current status:
- If have entirely removed the following part:
if (GPMI_IS_MX6(this)) /* * Set the default value for the gpmi clock. * * If you want to use the ONFI nand which is in the * Synchronous Mode, you should change the clock as you need. */ clk_set_rate(r->clock[0], 22000000);
- I applied your patch:
https://git.phytec.de/linux-mainline/commit/?h=v5.10.48-phy&id=866939ea8110764d9c12af960d746e2f7f5debe3
Last night I made a cycle test with a phyCORE i.MX6ULL. Over 1700 cycles were successful!
regards
Christian
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/