Skip to contentSkip to conversation

arm64: dts: rockchip: remove max-freq from &spi1 node for Hugsun X99

PATCH In review Johan Jonker 2 participants 2 messages Mar 9, 2020 – Mar 11, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: remove max-freq from &spi1 node for Hugsun X99

A test with the command below does not detect all errors in combination with 'additionalProperties: false' and allOf:
- $ref: "spi-controller.yaml#"

'additionalProperties' applies to all properties that are not accounted-for by 'properties' or 'patternProperties' in the immediate schema.

First when we combine spi-rockchip.yaml and
spi-controller.yaml it gives this error:

arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dt.yaml: spi@ff1d0000:
'max-freq' does not match any of the regexes:
'^.*@[0-9a-f]+$', '^slave$'

'max-freq' is not a valid property name for spi nodes, so remove it.

make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/spi-rockchip.yaml

---
 arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts +0 -1
index f2ffee639..ee4867fbe 100644
@@ -610,7 +610,6 @@
 
 &spi1 {
 	status = "okay";
-	max-freq = <10000000>;
 
 	flash@0 {
 		compatible = "jedec,spi-nor";
Signature · 1 line
2.11.0
maintainer
#1 lore raw

Am Montag, 9. März 2020, 13:51:45 CET schrieb Johan Jonker:

Quoted 16 lines

A test with the command below does not detect all errors in combination with 'additionalProperties: false' and allOf:
- $ref: "spi-controller.yaml#"

'additionalProperties' applies to all properties that are not accounted-for by 'properties' or 'patternProperties' in the immediate schema.

First when we combine spi-rockchip.yaml and
spi-controller.yaml it gives this error:

arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dt.yaml: spi@ff1d0000:
'max-freq' does not match any of the regexes:
'^.*@[0-9a-f]+$', '^slave$'

Quoted 7 lines

'max-freq' is not a valid property name for spi nodes, so remove it.

make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/spi-rockchip.yaml

applied for 5.7

Thanks
Heiko