Skip to contentSkip to conversation

core-image-basic.bb: Allow user extensions

PATCH Superseded Gary Thomas 2 participants 6 messages Oct 30, 2013

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Gary Thomas

author
#0 lore raw

PATCH 1/1 core-image-basic.bb: Allow user extensions

Allow the user to provide additional packages to this image. This lets core-image-basic behave like all other core-image* recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well as match the documentation which suggests this as the mode to extend any core-image* image.

Signed-off-by Gary Thomas <[email protected]>
---
 meta/recipes-extended/images/core-image-basic.bb |    3 +++
 1 file changed, 3 insertions(+)
meta/recipes-extended/images/core-image-basic.bb +2 -0
index 091f57d..e393a28 100644
@@ -3,9 +3,12 @@ functionality installed."
  IMAGE_FEATURES += "splash ssh-server-openssh"
 +CORE_IMAGE_EXTRA_INSTALL ?= ""
+
 IMAGE_INSTALL = "\
     packagegroup-core-boot \
     packagegroup-core-basic \
+    ${CORE_IMAGE_EXTRA_INSTALL} \
     "
  inherit core-image
Signature · 1 line
1.7.9.5
#1 lore raw

Hi Gary,

Quoted 17 lines · On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:

Allow the user to provide additional packages to this image. This lets core-image-basic behave like all other core-image* recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well as match the documentation which suggests this as the mode to extend any core-image* image.

Signed-off-by Gary Thomas <[email protected]>
---
  meta/recipes-extended/images/core-image-basic.bb |    3 +++
  1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28 100644

meta/recipes-extended/images/core-image-basic.bb functionality installed." · line 5

Quoted 3 lines
meta/recipes-extended/images/core-image-basic.bb +1 -0
@@ -3,9 +3,12 @@ functionality installed."
   IMAGE_FEATURES += "splash ssh-server-openssh"
  +CORE_IMAGE_EXTRA_INSTALL ?= ""
+

Not sure if it's my mail client but the above looks slightly mangled; in any case the above addition shouldn't be needed because core-image.bbclass already does this.

meta/recipes-extended/images/core-image-basic.bb functionality installed." · line 11

Quoted 6 lines
meta/recipes-extended/images/core-image-basic.bb +1 -0
  IMAGE_INSTALL = "\
      packagegroup-core-boot \
      packagegroup-core-basic \
+    ${CORE_IMAGE_EXTRA_INSTALL} \
      "
   inherit core-image

Good catch on this one though.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
author
#2 lore raw
Quoted 14 lines · Paul Eggleton

Hi Gary,

Quoted 11 lines · On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:

Allow the user to provide additional packages to this image. This lets core-image-basic behave like all other core-image* recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well as match the documentation which suggests this as the mode to extend any core-image* image.

Signed-off-by Gary Thomas <[email protected]>
---
   meta/recipes-extended/images/core-image-basic.bb |    3 +++
   1 file changed, 3 insertions(+)
Quoted 13 lines

meta/recipes-extended/images/core-image-basic.bb functionality installed." · line 5

Quoted 9 lines
(quoted diff) +0 -0

b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28 100644

meta/recipes-extended/images/core-image-basic.bb +1 -0
@@ -3,9 +3,12 @@ functionality installed."
    IMAGE_FEATURES += "splash ssh-server-openssh"
   +CORE_IMAGE_EXTRA_INSTALL ?= ""
+

Not sure if it's my mail client but the above looks slightly mangled; in any case the above addition shouldn't be needed because core-image.bbclass already does this.

Are you sure it counts? core-image.bbclass is included after this would be evaluated, or does that not matter?

Quoted 13 lines

meta/recipes-extended/images/core-image-basic.bb functionality installed." · line 11

Quoted 7 lines
meta/recipes-extended/images/core-image-basic.bb +1 -0
   IMAGE_INSTALL = "\
       packagegroup-core-boot \
       packagegroup-core-basic \
+    ${CORE_IMAGE_EXTRA_INSTALL} \
       "
    inherit core-image

Good catch on this one though.

Cheers,
Paul

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#3 lore raw
Quoted 25 lines · On Wednesday 30 October 2013 08:55:09 Gary Thomas wrote:
Quoted 24 lines · Paul Eggleton
Quoted 23 lines · On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:

Allow the user to provide additional packages to this image. This lets core-image-basic behave like all other core-image* recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well as match the documentation which suggests this as the mode to extend any core-image* image.

Signed-off-by Gary Thomas <[email protected]>

---

   meta/recipes-extended/images/core-image-basic.bb |    3 +++
   1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28 100644

meta/recipes-extended/images/core-image-basic.bb +0 -0
@@ -3,9 +3,12 @@ functionality installed."
 
    IMAGE_FEATURES += "splash ssh-server-openssh"
 
   +CORE_IMAGE_EXTRA_INSTALL ?= ""
Quoted 8 lines
Quoted 5 lines

meta/recipes-extended/images/core-image-basic.bb functionality installed." · line 5

Quoted 1 line
meta/recipes-extended/images/core-image-basic.bb +1 -0
+

Not sure if it's my mail client but the above looks slightly mangled; in any case the above addition shouldn't be needed because core-image.bbclass already does this.

Are you sure it counts? core-image.bbclass is included after this would be evaluated, or does that not matter?

It doesn't matter in most cases, because the value won't actually be expanded until later. Values aren't expanded unless you use immediate expansion (the := operator) or you d.getVar("SOMEVAR", True) is called from python code to return the expanded value.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
author
#4 lore raw
Quoted 32 lines · Paul Eggleton
Quoted 31 lines · On Wednesday 30 October 2013 08:55:09 Gary Thomas wrote:
Quoted 29 lines · Paul Eggleton
Quoted 18 lines · On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:

Allow the user to provide additional packages to this image. This lets core-image-basic behave like all other core-image* recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well as match the documentation which suggests this as the mode to extend any core-image* image.

Signed-off-by Gary Thomas <[email protected]>

---

    meta/recipes-extended/images/core-image-basic.bb |    3 +++
    1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28 100644

meta/recipes-extended/images/core-image-basic.bb functionality installed." · line 8

Quoted 6 lines
meta/recipes-extended/images/core-image-basic.bb +1 -0
@@ -3,9 +3,12 @@ functionality installed."
 
     IMAGE_FEATURES += "splash ssh-server-openssh"
 
    +CORE_IMAGE_EXTRA_INSTALL ?= ""
 
+

Not sure if it's my mail client but the above looks slightly mangled; in any case the above addition shouldn't be needed because core-image.bbclass already does this.

Quoted 7 lines
Quoted 2 lines

Are you sure it counts? core-image.bbclass is included after this would be evaluated, or does that not matter?

It doesn't matter in most cases, because the value won't actually be expanded until later. Values aren't expanded unless you use immediate expansion (the := operator) or you d.getVar("SOMEVAR", True) is called from python code to return the expanded value.

Understood, thanks.

Should I send another patch with that line removed?

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#5 lore raw
Quoted 37 lines · On Wednesday 30 October 2013 09:40:09 Gary Thomas wrote:
Quoted 36 lines · Paul Eggleton
Quoted 34 lines · On Wednesday 30 October 2013 08:55:09 Gary Thomas wrote:
Quoted 23 lines · Paul Eggleton
Quoted 22 lines · On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:

Allow the user to provide additional packages to this image. This lets core-image-basic behave like all other core-image* recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well as match the documentation which suggests this as the mode to extend any core-image* image.

Signed-off-by Gary Thomas <[email protected]>

---

    meta/recipes-extended/images/core-image-basic.bb |    3 +++
    1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28
100644

meta/recipes-extended/images/core-image-basic.bb +0 -0
@@ -3,9 +3,12 @@ functionality installed."
 
     IMAGE_FEATURES += "splash ssh-server-openssh"
Quoted 7 lines

meta/recipes-extended/images/core-image-basic.bb functionality installed." · line 5

Quoted 3 lines
meta/recipes-extended/images/core-image-basic.bb +1 -0
    +CORE_IMAGE_EXTRA_INSTALL ?= ""
 
+

Not sure if it's my mail client but the above looks slightly mangled; in any case the above addition shouldn't be needed because core-image.bbclass already does this.

Are you sure it counts? core-image.bbclass is included after this would be evaluated, or does that not matter?

Quoted 8 lines
Quoted 4 lines

It doesn't matter in most cases, because the value won't actually be expanded until later. Values aren't expanded unless you use immediate expansion (the := operator) or you d.getVar("SOMEVAR", True) is called from python code to return the expanded value.

Understood, thanks.

Should I send another patch with that line removed?

Yes please.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre