Skip to contentSkip to conversation

ring name size

DISCUSSION Thomas Monjalon 2 participants 3 messages Sep 4, 2023

lore
Share & tools
lore
#0 lore raw

Hello,

When creating a ring, we need to know the maximum length of the name. It seems this value is not documented.
And there is no constant defined.
There is only RTE_MEMZONE_NAMESIZE.

Should we document the maximum length as 31 and add a constant? #define RTE_RING_NAME_SIZE RTE_MEMZONE_NAMESIZE

#1 lore raw
Quoted 8 lines

From: Thomas Monjalon [mailto:[email protected]]
Sent: Monday, 4 September 2023 11.31

Hello,

When creating a ring, we need to know the maximum length of the name. It seems this value is not documented.
And there is no constant defined.

It is defined (with a description) here:
https://elixir.bootlin.com/dpdk/latest/source/lib/ring/rte_ring_core.h#L52

Quoted 5 lines

There is only RTE_MEMZONE_NAMESIZE.

Should we document the maximum length as 31 and add a constant? #define RTE_RING_NAME_SIZE RTE_MEMZONE_NAMESIZE

#2 lore raw

04/09/2023 11:33, Morten Brørup:

Quoted 11 lines
Quoted 8 lines

From: Thomas Monjalon [mailto:[email protected]]
Sent: Monday, 4 September 2023 11.31

Hello,

When creating a ring, we need to know the maximum length of the name. It seems this value is not documented.
And there is no constant defined.

It is defined (with a description) here:
https://elixir.bootlin.com/dpdk/latest/source/lib/ring/rte_ring_core.h#L52

Indeed, thank you Morten. I missed it when looking simply at rte_ring.h. So we are just missing to mention it in the doxygen of the related functions.

Quoted 4 lines
Quoted 4 lines

There is only RTE_MEMZONE_NAMESIZE.

Should we document the maximum length as 31 and add a constant? #define RTE_RING_NAME_SIZE RTE_MEMZONE_NAMESIZE