Skip to contentSkip to conversation

net: fsl: avoid 64-bit warning on pq_mdio

PATCH Applied Arnd Bergmann 2 participants 2 messages Dec 8, 2015 – Dec 9, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: fsl: avoid 64-bit warning on pq_mdio

The pq_mdio driver can now be built for ARM64, where we get a format string warning:

drivers/net/ethernet/freescale/fsl_pq_mdio.c: In function 'fsl_pq_mdio_probe':
drivers/net/ethernet/freescale/fsl_pq_mdio.c:467:25: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long int' [-Wformat=]

The argument is an implicit ptrdiff_t from the subtraction of two pointers, so we should use the %z format string modifier to make this work on 64-bit architectures.

Fixes fe761bcb9046 ("net: fsl: expands dependencies of NET_VENDOR_FREESCALE")
---
 drivers/net/ethernet/freescale/fsl_pq_mdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/fsl_pq_mdio.c +1 -1
index 55c36230e176..40071dad1c57 100644
@@ -464,7 +464,7 @@ static int fsl_pq_mdio_probe(struct platform_device *pdev)
 			 * address). Print error message but continue anyway.
 			 */
 			if ((void *)tbipa > priv->map + resource_size(&res) - 4)
-				dev_err(&pdev->dev, "invalid register map (should be at least 0x%04x to contain TBI address)\n",
+				dev_err(&pdev->dev, "invalid register map (should be at least 0x%04zx to contain TBI address)\n",
 					((void *)tbipa - priv->map) + 4);
 
 			iowrite32be(be32_to_cpup(prop), tbipa);
Signature · 1 line
2.1.0.rc2
maintainer Applied
#1 lore raw

From: Arnd Bergmann <[email protected]>
Date: Tue, 08 Dec 2015 16:17:29 +0100

Quoted 6 lines

The pq_mdio driver can now be built for ARM64, where we get a format string warning:

drivers/net/ethernet/freescale/fsl_pq_mdio.c: In function 'fsl_pq_mdio_probe':
drivers/net/ethernet/freescale/fsl_pq_mdio.c:467:25: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long int' [-Wformat=]

Quoted 6 lines

The argument is an implicit ptrdiff_t from the subtraction of two pointers, so we should use the %z format string modifier to make this work on 64-bit architectures.

Fixes fe761bcb9046 ("net: fsl: expands dependencies of NET_VENDOR_FREESCALE")

Applied.