Skip to contentSkip to conversation

ARM: shmobile: r8a7779: Fix GPIO input reg addresses

PATCH Superseded Phil Edworthy 3 participants 7 messages Dec 11, 2012 – Dec 13, 2012

Subsystems (4)
Arm (32-bit) Arm sub-architectures SuperH Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Phil Edworthy

author
#0 lore raw

PATCH 1/1 ARM: shmobile: r8a7779: Fix GPIO input reg addresses

The INDTx register addresses were wrong.

---
 arch/arm/mach-shmobile/pfc-r8a7779.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)
arch/arm/mach-shmobile/pfc-r8a7779.c +7 -7
index 15f6a48..717e058 100644
@@ -2585,13 +2585,13 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
 };
 
 static struct pinmux_data_reg pinmux_data_regs[] = {
-	{ PINMUX_DATA_REG("INDT0", 0xffc40008, 32) { GP_INDT(0) } },
-	{ PINMUX_DATA_REG("INDT1", 0xffc41008, 32) { GP_INDT(1) } },
-	{ PINMUX_DATA_REG("INDT2", 0xffc42008, 32) { GP_INDT(2) } },
-	{ PINMUX_DATA_REG("INDT3", 0xffc43008, 32) { GP_INDT(3) } },
-	{ PINMUX_DATA_REG("INDT4", 0xffc44008, 32) { GP_INDT(4) } },
-	{ PINMUX_DATA_REG("INDT5", 0xffc45008, 32) { GP_INDT(5) } },
-	{ PINMUX_DATA_REG("INDT6", 0xffc46008, 32) {
+	{ PINMUX_DATA_REG("INDT0", 0xffc4000c, 32) { GP_INDT(0) } },
+	{ PINMUX_DATA_REG("INDT1", 0xffc4100c, 32) { GP_INDT(1) } },
+	{ PINMUX_DATA_REG("INDT2", 0xffc4200c, 32) { GP_INDT(2) } },
+	{ PINMUX_DATA_REG("INDT3", 0xffc4300c, 32) { GP_INDT(3) } },
+	{ PINMUX_DATA_REG("INDT4", 0xffc4400c, 32) { GP_INDT(4) } },
+	{ PINMUX_DATA_REG("INDT5", 0xffc4500c, 32) { GP_INDT(5) } },
+	{ PINMUX_DATA_REG("INDT6", 0xffc4600c, 32) {
 		0, 0, 0, 0, 0, 0, 0, 0,	0, 0, 0, 0, 0, 0, 0, 0,
 		0, 0, 0, 0, 0, 0, 0, GP_6_8_DATA,
 		GP_6_7_DATA, GP_6_6_DATA, GP_6_5_DATA, GP_6_4_DATA,
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 ARM: shmobile: r8a7779: Fix GPIO input reg addresses

Hi Phil,

Thank you for the patch.

Your SoB line is missing, have you forgotten to commit with -s ?

Acked-by Laurent Pinchart <[email protected]>
Quoted 30 lines · On Tuesday 11 December 2012 09:48:15 Phil Edworthy wrote:

The INDTx register addresses were wrong.

---
 arch/arm/mach-shmobile/pfc-r8a7779.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-shmobile/pfc-r8a7779.c index 15f6a48..717e058 100644

arch/arm/mach-shmobile/pfc-r8a7779.c +7 -7
@@ -2585,13 +2585,13 @@ static struct pinmux_cfg_reg pinmux_config_regs[] =
 { };
 
 static struct pinmux_data_reg pinmux_data_regs[] = {
-	{ PINMUX_DATA_REG("INDT0", 0xffc40008, 32) { GP_INDT(0) } },
-	{ PINMUX_DATA_REG("INDT1", 0xffc41008, 32) { GP_INDT(1) } },
-	{ PINMUX_DATA_REG("INDT2", 0xffc42008, 32) { GP_INDT(2) } },
-	{ PINMUX_DATA_REG("INDT3", 0xffc43008, 32) { GP_INDT(3) } },
-	{ PINMUX_DATA_REG("INDT4", 0xffc44008, 32) { GP_INDT(4) } },
-	{ PINMUX_DATA_REG("INDT5", 0xffc45008, 32) { GP_INDT(5) } },
-	{ PINMUX_DATA_REG("INDT6", 0xffc46008, 32) {
+	{ PINMUX_DATA_REG("INDT0", 0xffc4000c, 32) { GP_INDT(0) } },
+	{ PINMUX_DATA_REG("INDT1", 0xffc4100c, 32) { GP_INDT(1) } },
+	{ PINMUX_DATA_REG("INDT2", 0xffc4200c, 32) { GP_INDT(2) } },
+	{ PINMUX_DATA_REG("INDT3", 0xffc4300c, 32) { GP_INDT(3) } },
+	{ PINMUX_DATA_REG("INDT4", 0xffc4400c, 32) { GP_INDT(4) } },
+	{ PINMUX_DATA_REG("INDT5", 0xffc4500c, 32) { GP_INDT(5) } },
+	{ PINMUX_DATA_REG("INDT6", 0xffc4600c, 32) {
 		0, 0, 0, 0, 0, 0, 0, 0,	0, 0, 0, 0, 0, 0, 0, 0,
 		0, 0, 0, 0, 0, 0, 0, GP_6_8_DATA,
 		GP_6_7_DATA, GP_6_6_DATA, GP_6_5_DATA, GP_6_4_DATA,
Signature · 3 lines
Regards,

Laurent Pinchart
author
#2 lore raw

PATCH v2 1/1 ARM: shmobile: r8a7779: Fix GPIO input reg addresses

The INDTx register addresses were wrong.

Signed-off-by Phil Edworthy <[email protected]>

---
v2:
Included SoB line this time - doh!

 arch/arm/mach-shmobile/pfc-r8a7779.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)
arch/arm/mach-shmobile/pfc-r8a7779.c +7 -7
index 15f6a48..717e058 100644
@@ -2585,13 +2585,13 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
 };
 
 static struct pinmux_data_reg pinmux_data_regs[] = {
-	{ PINMUX_DATA_REG("INDT0", 0xffc40008, 32) { GP_INDT(0) } },
-	{ PINMUX_DATA_REG("INDT1", 0xffc41008, 32) { GP_INDT(1) } },
-	{ PINMUX_DATA_REG("INDT2", 0xffc42008, 32) { GP_INDT(2) } },
-	{ PINMUX_DATA_REG("INDT3", 0xffc43008, 32) { GP_INDT(3) } },
-	{ PINMUX_DATA_REG("INDT4", 0xffc44008, 32) { GP_INDT(4) } },
-	{ PINMUX_DATA_REG("INDT5", 0xffc45008, 32) { GP_INDT(5) } },
-	{ PINMUX_DATA_REG("INDT6", 0xffc46008, 32) {
+	{ PINMUX_DATA_REG("INDT0", 0xffc4000c, 32) { GP_INDT(0) } },
+	{ PINMUX_DATA_REG("INDT1", 0xffc4100c, 32) { GP_INDT(1) } },
+	{ PINMUX_DATA_REG("INDT2", 0xffc4200c, 32) { GP_INDT(2) } },
+	{ PINMUX_DATA_REG("INDT3", 0xffc4300c, 32) { GP_INDT(3) } },
+	{ PINMUX_DATA_REG("INDT4", 0xffc4400c, 32) { GP_INDT(4) } },
+	{ PINMUX_DATA_REG("INDT5", 0xffc4500c, 32) { GP_INDT(5) } },
+	{ PINMUX_DATA_REG("INDT6", 0xffc4600c, 32) {
 		0, 0, 0, 0, 0, 0, 0, 0,	0, 0, 0, 0, 0, 0, 0, 0,
 		0, 0, 0, 0, 0, 0, 0, GP_6_8_DATA,
 		GP_6_7_DATA, GP_6_6_DATA, GP_6_5_DATA, GP_6_4_DATA,
Signature · 1 line
1.7.5.4
#3 lore raw

PATCH v2 1/1 ARM: shmobile: r8a7779: Fix GPIO input reg addresses

Quoted 3 lines · On Tuesday 11 December 2012 11:34:17 Phil Edworthy wrote:

The INDTx register addresses were wrong.

Signed-off-by Phil Edworthy <[email protected]>

You can add

Acked-by Laurent Pinchart <[email protected]>

:-)

Quoted 32 lines

---
v2:
Included SoB line this time - doh!

 arch/arm/mach-shmobile/pfc-r8a7779.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-shmobile/pfc-r8a7779.c index 15f6a48..717e058 100644

arch/arm/mach-shmobile/pfc-r8a7779.c +7 -7
@@ -2585,13 +2585,13 @@ static struct pinmux_cfg_reg pinmux_config_regs[] =
 { };
 
 static struct pinmux_data_reg pinmux_data_regs[] = {
-	{ PINMUX_DATA_REG("INDT0", 0xffc40008, 32) { GP_INDT(0) } },
-	{ PINMUX_DATA_REG("INDT1", 0xffc41008, 32) { GP_INDT(1) } },
-	{ PINMUX_DATA_REG("INDT2", 0xffc42008, 32) { GP_INDT(2) } },
-	{ PINMUX_DATA_REG("INDT3", 0xffc43008, 32) { GP_INDT(3) } },
-	{ PINMUX_DATA_REG("INDT4", 0xffc44008, 32) { GP_INDT(4) } },
-	{ PINMUX_DATA_REG("INDT5", 0xffc45008, 32) { GP_INDT(5) } },
-	{ PINMUX_DATA_REG("INDT6", 0xffc46008, 32) {
+	{ PINMUX_DATA_REG("INDT0", 0xffc4000c, 32) { GP_INDT(0) } },
+	{ PINMUX_DATA_REG("INDT1", 0xffc4100c, 32) { GP_INDT(1) } },
+	{ PINMUX_DATA_REG("INDT2", 0xffc4200c, 32) { GP_INDT(2) } },
+	{ PINMUX_DATA_REG("INDT3", 0xffc4300c, 32) { GP_INDT(3) } },
+	{ PINMUX_DATA_REG("INDT4", 0xffc4400c, 32) { GP_INDT(4) } },
+	{ PINMUX_DATA_REG("INDT5", 0xffc4500c, 32) { GP_INDT(5) } },
+	{ PINMUX_DATA_REG("INDT6", 0xffc4600c, 32) {
 		0, 0, 0, 0, 0, 0, 0, 0,	0, 0, 0, 0, 0, 0, 0, 0,
 		0, 0, 0, 0, 0, 0, 0, GP_6_8_DATA,
 		GP_6_7_DATA, GP_6_6_DATA, GP_6_5_DATA, GP_6_4_DATA,
Signature · 3 lines
Regards,

Laurent Pinchart
author
#4 lore raw

PATCH v2 1/1 ARM: shmobile: r8a7779: Fix GPIO input reg addresses

Hi Simon, Laurent,

Quoted 8 lines

From: Laurent Pinchart <[email protected]>
To: Phil Edworthy <[email protected]>,
Cc: Simon <[email protected]>, linux-sh at vger.kernel.org, linux-arm- kernel at lists.infradead.org, Magnus <[email protected]>, Laurent Pinchart <[email protected]>
Date: 11/12/2012 11:39
Subject: Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg addresses

Quoted 8 lines
Quoted 3 lines · On Tuesday 11 December 2012 11:34:17 Phil Edworthy wrote:

The INDTx register addresses were wrong.

Signed-off-by Phil Edworthy <[email protected]>

You can add

Acked-by Laurent Pinchart <[email protected]>

Please scrap this patch. I just found out that it screws up the GPIO outputs. The current code assumes the same register is used for both input and output, which is not the case. It needs a bit of work to fix this.

Thanks
Phil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121212/f7cdbc2a/attachment-0001.html>

author
#5 lore raw

PATCH v2 1/1 ARM: shmobile: r8a7779: Fix GPIO input reg addresses

In reply to Laurent Pinchart

Hi Simon, Laurent,

(resend as plain text)

Quoted 7 lines

From: Laurent Pinchart <[email protected]>
To: Phil Edworthy <[email protected]>,
Cc: Simon <[email protected]>, linux-sh at vger.kernel.org, linux-arm- kernel at lists.infradead.org, Magnus <[email protected]>, Laurent Pinchart <[email protected]>
Date: 11/12/2012 11:39
Subject: Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg

addresses

Quoted 9 lines · On Tuesday 11 December 2012 11:34:17 Phil Edworthy wrote:
Quoted 3 lines

The INDTx register addresses were wrong.

Signed-off-by Phil Edworthy <[email protected]>

You can add

Acked-by Laurent Pinchart <[email protected]>

Please scrap this patch. I just found out that it screws up the GPIO outputs. The current code assumes the same register is used for both input and output, which is not the case. It needs a bit of work to fix this.

Thanks
Phil

#6 lore raw

PATCH v2 1/1 ARM: shmobile: r8a7779: Fix GPIO input reg addresses

Quoted 18 lines · phil.edworthy at renesas.com

Hi Simon, Laurent,

(resend as plain text)

Quoted 7 lines

From: Laurent Pinchart <[email protected]>
To: Phil Edworthy <[email protected]>,
Cc: Simon <[email protected]>, linux-sh at vger.kernel.org, linux-arm- kernel at lists.infradead.org, Magnus <[email protected]>, Laurent Pinchart <[email protected]>
Date: 11/12/2012 11:39
Subject: Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg

addresses

Quoted 6 lines · On Tuesday 11 December 2012 11:34:17 Phil Edworthy wrote:
Quoted 3 lines

The INDTx register addresses were wrong.

Signed-off-by Phil Edworthy <[email protected]>
Quoted 7 lines
Quoted 3 lines

You can add

Acked-by Laurent Pinchart <[email protected]>

Please scrap this patch. I just found out that it screws up the GPIO outputs. The current code assumes the same register is used for both input and output, which is not the case. It needs a bit of work to fix this.

Thanks, I have marked v1 and v2 as Rejected in patchwork.