Skip to contentSkip to conversation

PM / AVS: rockchip-io: depend on CONFIG_POWER_AVS

PATCH Superseded Heiko Stuebner 3 participants 3 messages May 23, 2015 – May 26, 2015 Arm Rockchip

lore
Share & tools
lore

Heiko Stuebner

author maintainer
#0 lore raw

PATCH 1/1 PM / AVS: rockchip-io: depend on CONFIG_POWER_AVS

The rockchip io-domain driver currently only depends on ARCH_ROCKCHIP itself. This makes it possible to select the power-domain driver, but not the POWER_AVS class and results in the iodomain-driver not getting build in this case.

So add the additional dependency, which also results in the driver config option now being placed nicely into the AVS submenu.

Fixes 662a958638bd ("PM / AVS: rockchip-io: add driver handling Rockchip io domains")

---
Found while trying to make the wifi on current rk3288 Chromebooks work.

 drivers/power/avs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/avs/Kconfig +1 -1
index 7f3d389..a67eeac 100644
@@ -13,7 +13,7 @@ menuconfig POWER_AVS
 
 config ROCKCHIP_IODOMAIN
         tristate "Rockchip IO domain support"
-        depends on ARCH_ROCKCHIP && OF
+        depends on POWER_AVS && ARCH_ROCKCHIP && OF
         help
           Say y here to enable support io domains on Rockchip SoCs. It is
           necessary for the io domain setting of the SoC to match the
Signature · 1 line
2.1.4
#1 lore raw

Hi,

Quoted 10 lines · Heiko Stuebner

The rockchip io-domain driver currently only depends on ARCH_ROCKCHIP itself. This makes it possible to select the power-domain driver, but not the POWER_AVS class and results in the iodomain-driver not getting build in this case.

So add the additional dependency, which also results in the driver config option now being placed nicely into the AVS submenu.

Fixes 662a958638bd ("PM / AVS: rockchip-io: add driver handling Rockchip io domains")

Looks like the power supply entry in the MAINTAINERS file is missing an "X: drivers/power/avs/" entry.

-- Sebastian

Acked-by on v1 1/1
#2 lore raw
In reply to Heiko Stuebner
Quoted 10 lines · Heiko Stuebner

The rockchip io-domain driver currently only depends on ARCH_ROCKCHIP itself. This makes it possible to select the power-domain driver, but not the POWER_AVS class and results in the iodomain-driver not getting build in this case.

So add the additional dependency, which also results in the driver config option now being placed nicely into the AVS submenu.

Fixes 662a958638bd ("PM / AVS: rockchip-io: add driver handling Rockchip io domains")

Rafael, feel free to queue this up as a fix. I don't have any other drivers/power/avs stuff queued up.

Kevin