Skip to contentSkip to conversation

mailbox: ZynqMP IPI: Delete an error message in zynqmp_ipi_probe()

PATCH New Markus Elfring 1 participant 1 message Apr 5, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mailbox: ZynqMP IPI: Delete an error message in zynqmp_ipi_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 5 Apr 2020 15:10:16 +0200

The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function.

This issue was detected by using the Coccinelle software.

---
 drivers/mailbox/zynqmp-ipi-mailbox.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/mailbox/zynqmp-ipi-mailbox.c +2 -3
index 86887c9a349a..a4d176f160b8 100644
@@ -668,10 +668,9 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
 
 	/* IPI IRQ */
 	ret = platform_get_irq(pdev, 0);
-	if (ret < 0) {
-		dev_err(dev, "unable to find IPI IRQ.\n");
+	if (ret < 0)
 		goto free_mbox_dev;
-	}
+
 	pdata->irq = ret;
 	ret = devm_request_irq(dev, pdata->irq, zynqmp_ipi_interrupt,
 			       IRQF_SHARED, dev_name(dev), pdata);

--
2.26.0