mm/hugetlb: move hugetlb_sysctl_init() to the __init section
Subsystems (2)
PATCH 1/1 mm/hugetlb: move hugetlb_sysctl_init() to the __init section
From: Marc Herbert <[email protected]>
hugetlb_sysctl_init() is only invoked once by an __init function and is merely a wrapper around another __init function so there is not reason to keep it.
Fixes the following warning when toning down some GCC inline options:
WARNING: modpost: vmlinux: section mismatch in reference:
hugetlb_sysctl_init+0x1b (section: .text) ->
__register_sysctl_init (section: .init.text)
--- mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/hugetlb.c +1 -1
@@ -4900,7 +4900,7 @@ static const struct ctl_table hugetlb_table[] = { }, }; -static void hugetlb_sysctl_init (void ) +static void __init hugetlb_sysctl_init (void ) {register_sysctl_init ("vm" , hugetlb_table); }
Signature · 1 line
2.48.1
Quoted 22 lines · On 3/19/25 11:30, [email protected] wrote:
From: Marc Herbert <[email protected]>
hugetlb_sysctl_init()is only invoked once by an__initfunction and is merely a wrapper around another__initfunction so there is not reason to keep it.Fixes the following warning when toning down some GCC inline options:
WARNING: modpost: vmlinux: section mismatch in reference:
hugetlb_sysctl_init+0x1b(section: .text) ->
__register_sysctl_init(section: .init.text)Signed-off-by Marc Herbert <[email protected]>--- mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/hugetlb.c +0
-0
mm/hugetlb.c static const struct ctl_table hugetlb_table[] = { · line 4906
Quoted 8 lines
mm/hugetlb.c +1
-1@@ -4900,7 +4900,7 @@ static const struct ctl_table hugetlb_table[] = { }, }; -static void hugetlb_sysctl_init (void ) +static void __init hugetlb_sysctl_init (void ) {register_sysctl_init ("vm" , hugetlb_table); }
LGTM
Andrew Morton
maintainerQuoted 6 lines · On Wed, 19 Mar 2025 06:00:30 +0000 [email protected] wrote:
From: Marc Herbert <[email protected]>
hugetlb_sysctl_init()is only invoked once by an__initfunction and is merely a wrapper around another__initfunction so there is not reason to keep it.
Quoted 6 lines
Fixes the following warning when toning down some GCC inline options:
WARNING: modpost: vmlinux: section mismatch in reference:
hugetlb_sysctl_init+0x1b(section: .text) ->
__register_sysctl_init(section: .init.text)
Huh. I wonder why this just started happening.
Hi Andrew,
Quoted 6 lines · Andrew Morton
Quoted 4 lines · On Wed, 19 Mar 2025 06:00:30 +0000 [email protected] wrote:
hugetlb_sysctl_init()is only invoked once by an__initfunction and is merely a wrapper around another__initfunction so there is not reason to keep it.
Quoted 8 lines
Quoted 6 lines
Fixes the following warning when toning down some GCC inline options:
WARNING: modpost: vmlinux: section mismatch in reference:
hugetlb_sysctl_init+0x1b(section: .text) ->
__register_sysctl_init(section: .init.text)Huh. I wonder why this just started happening.
As I just mentioned, I see this warning only because I'm playing with GCC flags.
Not sure how good is that page but its name is perfect here:
https://stackoverflow.com/questions/59388740/gcc-shows-different-warnings-depending-on-optimisation-level
Also, https://gcc.gnu.org/onlinedocs/gcc-14.2.0/gcc/Warning-Options.html
Quoted 6 lines
The effectiveness of some warnings depends on optimizations also being enabled. For example -Wsuggest-final-types is more effective with link-time optimization and some instances of other warnings may not be issued at all unless optimization is enabled. While optimization in general improves the efficacy of control and data flow sensitive warnings, in some cases it may also cause false positives.
That particular warning was very minor but simple and valid; not a false positive. It was also the only "section mismatch" warning found in my entire configuration.
Marc
PS: who needs expensive static analysis tools when unusual combination of compiler flags can find issues? :-D
Quoted 10 lines · On Mar 19, 2025, at 14:00, [email protected] wrote:
From: Marc Herbert <[email protected]>
hugetlb_sysctl_init()is only invoked once by an__initfunction and is merely a wrapper around another__initfunction so there is not reason to keep it.
Quoted 7 lines
Fixes the following warning when toning down some GCC inline options:
WARNING: modpost: vmlinux: section mismatch in reference:
hugetlb_sysctl_init+0x1b(section: .text) ->
__register_sysctl_init(section: .init.text)Signed-off-by Marc Herbert <[email protected]>
Thanks.