drm/i915/fbdev: Implement fb_dirty for intel custom fb helper
Subsystems (3)
PATCH 1/1 drm/i915/fbdev: Implement fb_dirty for intel custom fb helper
After splitting generic drm_fb_helper into it's own file it's left to helper implementation to have fb_dirty function. Currently intel fb doesn't have it. This is causing problems when PSR is enabled.
Implement simple fb_dirty callback to deliver notifications to psr about updates in fb console.
--- drivers/gpu/drm/i915/display/intel_fbdev.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/gpu/drm/i915/display/intel_fbdev.c +9 -0
@@ -328,8 +328,17 @@ static int intelfb_create(struct drm_fb_helper *helper,return ret; } +static int intelfb_dirty (struct drm_fb_helper *helper,struct drm_clip_rect *clip) +{ +if (helper->fb->funcs->dirty) +return helper->fb->funcs->dirty (helper->fb,NULL ,0 ,0 , clip,1 ); + +return 0 ; +} +static const struct drm_fb_helper_funcs intel_fb_helper_funcs = { .fb_probe = intelfb_create, + .fb_dirty = intelfb_dirty, };static void intel_fbdev_destroy (struct intel_fbdev *ifbdev)
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbdev: Implement fb_dirty for intel custom fb helper
== Series Details ==
== Series Details ==
Series: drm/i915/fbdev: Implement fb_dirty for intel custom fb helper
URL : https://patchwork.freedesktop.org/series/111433/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12442 -> Patchwork_111433v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/index.html
Participating hosts (30 -> 36)
------------------------------
Additional (7): bat-kbl-2 fi-rkl-11600 fi-tgl-dsi bat-dg1-5 bat-adlp-4 bat-jsl-3 fi-skl-6600u
Missing (1): bat-rpls-2
Known issues
------------
Here are the changes found in Patchwork_111433v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-adlp-4: NOTRUN -> [SKIP][1] ([i915#7456])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-adlp-4/igt@[email protected]
- fi-rkl-11600: NOTRUN -> [SKIP][2] ([i915#7456])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-rkl-11600/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-skl-6600u: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-skl-6600u/igt@[email protected]
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-rkl-11600/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-rkl-11600: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-rkl-11600/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-adlp-4: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-adlp-4/igt@[email protected]
* igt@gem_lmem_swapping@random-engines:
- fi-skl-6600u: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-skl-6600u/igt@[email protected]
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][8] ([i915#4083])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@[email protected]
* igt@gem_tiled_blits@basic:
- bat-dg1-5: NOTRUN -> [SKIP][9] ([i915#4077]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@[email protected]
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][10] ([i915#3282])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-rkl-11600/igt@gem_tiled_pread_basic.html
- bat-dg1-5: NOTRUN -> [SKIP][11] ([i915#4079]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@gem_tiled_pread_basic.html
- bat-adlp-4: NOTRUN -> [SKIP][12] ([i915#3282])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-adlp-4/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][13] ([i915#7561])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-rkl-11600/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][14] ([i915#7561])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@[email protected]
* igt@i915_pm_rps@basic-api:
- bat-adlp-4: NOTRUN -> [SKIP][15] ([i915#6621])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][16] ([i915#6621])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][17] ([i915#4817])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-rkl-11600/igt@[email protected]
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][18] ([i915#4212]) +7 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@[email protected]
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][19] ([i915#4215])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][20] ([fdo#111827]) +8 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][21] ([fdo#111827]) +8 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@[email protected]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-skl-6600u: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +8 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-skl-6600u/igt@[email protected]
* igt@kms_chamelium@hdmi-edid-read:
- fi-rkl-11600: NOTRUN -> [SKIP][23] ([fdo#111827]) +7 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-rkl-11600/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- bat-adlp-4: NOTRUN -> [SKIP][24] ([i915#4103])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][25] ([i915#4103] / [i915#4213])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@[email protected]
- fi-rkl-11600: NOTRUN -> [SKIP][26] ([i915#4103])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-rkl-11600/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- bat-adlp-4: NOTRUN -> [SKIP][27] ([i915#4093]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][28] ([fdo#109285])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@[email protected]
- fi-rkl-11600: NOTRUN -> [SKIP][29] ([fdo#109285] / [i915#4098])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-rkl-11600/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-adlp-4: NOTRUN -> [SKIP][30] ([i915#3546])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-adlp-4/igt@[email protected]
* igt@kms_psr@primary_page_flip:
- fi-rkl-11600: NOTRUN -> [SKIP][31] ([i915#1072]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-rkl-11600/igt@kms_psr@primary_page_flip.html
- bat-dg1-5: NOTRUN -> [SKIP][32] ([i915#1072] / [i915#4078]) +3 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@kms_psr@primary_page_flip.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][33] ([i915#3555] / [i915#4098])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-rkl-11600/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][34] ([i915#3555])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][35] ([i915#3555] / [i915#4579])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-adlp-4/igt@[email protected]
* igt@prime_vgem@basic-fence-read:
- bat-dg1-5: NOTRUN -> [SKIP][36] ([i915#3708]) +3 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@[email protected]
* igt@prime_vgem@basic-gtt:
- bat-dg1-5: NOTRUN -> [SKIP][37] ([i915#3708] / [i915#4077]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@[email protected]
* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][38] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-rkl-11600/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- fi-skl-6600u: NOTRUN -> [SKIP][39] ([fdo#109271]) +4 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-skl-6600u/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][40] ([fdo#109295] / [i915#3301] / [i915#3708])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][41] ([i915#3708] / [i915#4873])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-dg1-5/igt@[email protected]
- fi-rkl-11600: NOTRUN -> [SKIP][42] ([fdo#109295] / [i915#3301] / [i915#3708])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/fi-rkl-11600/igt@[email protected]
* igt@prime_vgem@basic-write:
- bat-adlp-4: NOTRUN -> [SKIP][43] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-adlp-4/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@hugepages:
- {bat-rpls-1}: [DMESG-WARN][44] ([i915#5278]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/bat-rpls-1/igt@i915_selftest@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/bat-rpls-1/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6856]: https://gitlab.freedesktop.org/drm/intel/issues/6856
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7125]: https://gitlab.freedesktop.org/drm/intel/issues/7125
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
Build changes
-------------
* Linux: CI_DRM_12442 -> Patchwork_111433v1
CI-20190529: 20190529
CI_DRM_12442: 9e8dc55b099e744c1f5fa5d7eac9f81966591028 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7074: a7403583f1baee0548d86d1f2c9bb078384f997a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111433v1: 9e8dc55b099e744c1f5fa5d7eac9f81966591028 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
92c53504805c drm/i915/fbdev: Implement fb_dirty for intel custom fb helper
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/fbdev: Implement fb_dirty for intel custom fb helper
In reply to Jouni Högander== Series Details ==
== Series Details ==
Series: drm/i915/fbdev: Implement fb_dirty for intel custom fb helper
URL : https://patchwork.freedesktop.org/series/111433/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12442_full -> Patchwork_111433v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_111433v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-skl: [PASS][1] -> [INCOMPLETE][2] ([i915#4793])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-skl9/igt@gem_ctx_isolation@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-skl7/igt@gem_ctx_isolation@[email protected]
* igt@gem_eio@in-flight-suspend:
- shard-skl: [PASS][3] -> [INCOMPLETE][4] ([i915#7112])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-skl9/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-skl10/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][5] -> [FAIL][6] ([i915#2842]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-tglb5/igt@gem_exec_fair@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][7] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-iclb1/igt@gem_exec_fair@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [PASS][8] -> [SKIP][9] ([i915#4281])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-iclb1/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-iclb3/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-tglb: NOTRUN -> [WARN][10] ([i915#2681])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb7/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-skl: [PASS][11] -> [WARN][12] ([i915#1804])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-skl9/igt@i915_pm_rc6_residency@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-skl1/igt@i915_pm_rc6_residency@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- shard-skl: [PASS][13] -> [DMESG-FAIL][14] ([i915#5334])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-skl6/igt@i915_selftest@live@gt_heartbeat.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-skl1/igt@i915_selftest@live@gt_heartbeat.html
- shard-apl: [PASS][15] -> [DMESG-FAIL][16] ([i915#5334])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-apl1/igt@i915_selftest@live@gt_heartbeat.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-apl1/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#2521]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-skl9/igt@kms_async_flips@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-skl1/igt@kms_async_flips@[email protected]
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-tglb: NOTRUN -> [SKIP][19] ([i915#1769])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb7/igt@[email protected]
* igt@kms_big_fb@4-tiled-8bpp-rotate-180:
- shard-apl: NOTRUN -> [SKIP][20] ([fdo#109271]) +7 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-apl1/igt@[email protected]
* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][21] ([fdo#111614])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb7/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][22] ([i915#3763])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-skl6/igt@[email protected]
* igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][23] ([fdo#111615])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb7/igt@[email protected]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][24] ([i915#3689])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_ccs.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3886])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-apl1/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][26] ([fdo#111615] / [i915#3689]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb7/igt@kms_ccs@pipe-c-ccs-on-another-bo-yf_tiled_ccs.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][27] ([i915#3689] / [i915#3886])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb7/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3886])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-skl6/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@dp-edid-read:
- shard-skl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-skl6/igt@[email protected]
* igt@kms_color_chamelium@ctm-red-to-blue:
- shard-apl: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-apl1/igt@[email protected]
* igt@kms_cursor_crc@cursor-suspend@pipe-c-edp-1:
- shard-skl: [PASS][31] -> [INCOMPLETE][32] ([i915#6951])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-skl9/igt@kms_cursor_crc@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-skl4/igt@kms_cursor_crc@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@toggle:
- shard-iclb: [PASS][33] -> [FAIL][34] ([i915#2346]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-iclb8/igt@kms_cursor_legacy@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-iclb7/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][35] -> [FAIL][36] ([i915#2122])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-skl1/igt@kms_flip@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-apl7/igt@kms_flip@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-apl8/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][39] ([i915#2587] / [i915#2672]) +4 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-iclb8/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][40] ([i915#2672]) +6 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt:
- shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271]) +41 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-skl6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#109280] / [fdo#111825]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#658])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-skl9/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][44] -> [SKIP][45] ([fdo#109441]) +3 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-iclb7/igt@kms_psr@psr2_cursor_blt.html
- shard-tglb: NOTRUN -> [FAIL][46] ([i915#132] / [i915#3467]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb7/igt@kms_psr@psr2_cursor_blt.html
* igt@perf_pmu@interrupts:
- shard-skl: [PASS][47] -> [FAIL][48] ([i915#7318])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-skl9/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-skl1/igt@[email protected]
* igt@sysfs_clients@sema-25:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#2994])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb7/igt@[email protected]
* igt@sysfs_clients@sema-50:
- shard-skl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#2994])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-skl6/igt@[email protected]
#### Possible fixes ####
* igt@api_intel_allocator@fork-simple-stress-signal:
- shard-tglb: [INCOMPLETE][51] ([i915#6453]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-tglb5/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb7/igt@[email protected]
* igt@gem_ctx_persistence@engines-hang@bcs0:
- {shard-rkl}: [SKIP][53] ([i915#6252]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-5/igt@gem_ctx_persistence@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-2/igt@gem_ctx_persistence@[email protected]
* igt@gem_eio@suspend:
- {shard-rkl}: [FAIL][55] ([i915#7052]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-3/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-2/igt@[email protected]
* igt@gem_exec_balancer@fairslice:
- {shard-rkl}: [SKIP][57] ([i915#6259]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-5/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-2/igt@[email protected]
* igt@gem_exec_reloc@basic-wc-read-noreloc:
- {shard-rkl}: [SKIP][59] ([i915#3281]) -> [PASS][60] +7 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-4/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-5/igt@[email protected]
* igt@gem_exec_whisper@basic-contexts-forked-all:
- {shard-rkl}: [INCOMPLETE][61] -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-4/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-5/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][63] ([i915#2190]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-tglb6/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb2/igt@[email protected]
* igt@gem_mmap_gtt@coherency:
- {shard-rkl}: [SKIP][65] ([fdo#111656]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-4/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-5/igt@[email protected]
* igt@gem_pwrite@basic-self:
- {shard-rkl}: [SKIP][67] ([i915#3282]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-4/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-5/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [DMESG-WARN][69] ([i915#5566] / [i915#716]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-apl1/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-apl1/igt@[email protected]
* igt@gen9_exec_parse@batch-without-end:
- {shard-rkl}: [SKIP][71] ([i915#2527]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-6/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-5/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- {shard-rkl}: [SKIP][73] ([i915#658]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-3/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-6/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- {shard-rkl}: [SKIP][75] ([i915#3361]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-5/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-1/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-dg1}: [FAIL][77] ([i915#3591]) -> [PASS][78] +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-dg1-17/igt@i915_pm_rc6_residency@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-dg1-12/igt@i915_pm_rc6_residency@[email protected]
* igt@i915_pm_rpm@cursor-dpms:
- {shard-rkl}: [SKIP][79] ([i915#1849]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-1/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@dpms-lpsp:
- {shard-rkl}: [SKIP][81] ([i915#1397]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-1/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@i2c:
- {shard-rkl}: [SKIP][83] ([fdo#109308]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-1/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-6/igt@[email protected]
* igt@kms_atomic@atomic_plane_damage:
- {shard-rkl}: [SKIP][85] ([i915#4098]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-1/igt@kms_atomic@atomic_plane_damage.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-6/igt@kms_atomic@atomic_plane_damage.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [SKIP][87] ([i915#1845] / [i915#4098]) -> [PASS][88] +18 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-1/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-6/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][89] ([i915#4767]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-apl2/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-apl8/igt@[email protected]
- shard-tglb: [FAIL][91] ([i915#2411] / [i915#4767]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-tglb7/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb5/igt@[email protected]
- shard-iclb: [FAIL][93] ([i915#4767]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-iclb6/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-iclb6/igt@[email protected]
* igt@kms_fbcon_fbt@psr:
- {shard-rkl}: [SKIP][95] ([fdo#110189] / [i915#3955]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-1/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- {shard-rkl}: [SKIP][97] ([i915#1849] / [i915#4098]) -> [PASS][98] +21 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-1/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-6/igt@[email protected]
* igt@kms_plane@plane-position-covered@pipe-a-planes:
- {shard-rkl}: [SKIP][99] ([i915#3558]) -> [PASS][100] +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-3/igt@kms_plane@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-6/igt@kms_plane@[email protected]
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1:
- shard-iclb: [SKIP][101] ([i915#5176]) -> [PASS][102] +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-iclb8/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1:
- shard-iclb: [SKIP][103] ([i915#5235]) -> [PASS][104] +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-iclb2/igt@kms_plane_scaling@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-iclb6/igt@kms_plane_scaling@[email protected]
* igt@kms_psr@sprite_blt:
- {shard-rkl}: [SKIP][105] ([i915#1072]) -> [PASS][106] +2 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-1/igt@kms_psr@sprite_blt.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-6/igt@kms_psr@sprite_blt.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglb: [SKIP][107] ([i915#5519]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-tglb1/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb1/igt@[email protected]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-b:
- {shard-rkl}: [SKIP][109] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][110] +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-rkl-1/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-rkl-6/igt@[email protected]
* igt@kms_vblank@pipe-b-query-forked-hang:
- shard-tglb: [INCOMPLETE][111] -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-tglb6/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb2/igt@[email protected]
#### Warnings ####
* igt@gem_pread@exhaustion:
- shard-tglb: [WARN][113] ([i915#2658]) -> [INCOMPLETE][114] ([i915#7248])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-tglb7/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb5/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-tglb: [INCOMPLETE][115] ([i915#7248]) -> [WARN][116] ([i915#2658])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-tglb8/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-tglb2/igt@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][117] ([i915#658]) -> [SKIP][118] ([i915#588])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-iclb7/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][119] ([i915#2920]) -> [SKIP][120] ([i915#658])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-iclb2/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-iclb7/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][121] ([i915#658]) -> [SKIP][122] ([i915#2920])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-iclb7/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-apl: ([FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126]) ([fdo#109271] / [i915#3002] / [i915#4312]) -> ([FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130]) ([i915#180] / [i915#3002] / [i915#4312])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-apl7/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-apl3/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-apl3/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12442/shard-apl1/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-apl1/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-apl7/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-apl7/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/shard-apl8/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3692]: https://gitlab.freedesktop.org/drm/intel/issues/3692
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3763]: https://gitlab.freedesktop.org/drm/intel/issues/3763
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4793]: https://gitlab.freedesktop.org/drm/intel/issues/4793
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6453]: https://gitlab.freedesktop.org/drm/intel/issues/6453
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6951]: https://gitlab.freedesktop.org/drm/intel/issues/6951
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7112]: https://gitlab.freedesktop.org/drm/intel/issues/7112
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#7318]: https://gitlab.freedesktop.org/drm/intel/issues/7318
Build changes
-------------
* Linux: CI_DRM_12442 -> Patchwork_111433v1
CI-20190529: 20190529
CI_DRM_12442: 9e8dc55b099e744c1f5fa5d7eac9f81966591028 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7074: a7403583f1baee0548d86d1f2c9bb078384f997a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111433v1: 9e8dc55b099e744c1f5fa5d7eac9f81966591028 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111433v1/index.html
Quoted 6 lines · Jouni Högander
After splitting generic
drm_fb_helperinto it's own file it's left to helper implementation to havefb_dirtyfunction. Currently intel fb doesn't have it. This is causing problems when PSR is enabled.Implement simple
fb_dirtycallback to deliver notifications to psr about updates in fb console.
Just found this regression myself after being baffled why the vt console was inoperable right after the driver gets loaded.
It's also not just psr, but also fbc that is having issues.
Needs a fixes + cc:stable tags.
Quoted 13 lines
Cc Thomas Zimmermann <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Jouni Högander <[email protected]>--- drivers/gpu/drm/i915/display/intel_fbdev.c | 9 +++++++++ 1 file changed, 9 insertions(+)drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0
drivers/gpu/drm/i915/display/intel_fbdev.c static int intelfb_create(struct drm_fb_helper *helper, · line 332
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +2
-0@@ -328,8 +328,17 @@ static int intelfb_create(struct drm_fb_helper *helper,return ret; } +static int intelfb_dirty (struct drm_fb_helper *helper,struct drm_clip_rect *clip) +{
The original thing had some kind of "is this rect actually visible?" check here. Does anyone know why it was there, and if so maybe it should go back to the higher level function so everyone doens't need to add it back in?
Quoted 14 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +7
-0+if (helper->fb->funcs->dirty) +return helper->fb->funcs->dirty (helper->fb,NULL ,0 ,0 , clip,1 ); + +return 0 ; +} +static const struct drm_fb_helper_funcs intel_fb_helper_funcs = { .fb_probe = intelfb_create, + .fb_dirty = intelfb_dirty, };static void intel_fbdev_destroy (struct intel_fbdev *ifbdev)Signature · 1 line
2.34.1
Signature · 2 lines
Ville Syrjälä Intel
Quoted 8 lines · Ville Syrjälä
Quoted 6 lines · Jouni Högander
After splitting generic
drm_fb_helperinto it's own file it's left to helper implementation to havefb_dirtyfunction. Currently intel fb doesn't have it. This is causing problems when PSR is enabled.Implement simple
fb_dirtycallback to deliver notifications to psr about updates in fb console.
Quoted 6 lines
Just found this regression myself after being baffled why the vt console was inoperable right after the driver gets loaded.
It's also not just psr, but also fbc that is having issues.
Needs a fixes + cc:stable tags.
Actually looks like it didn't make it into 6.1 so I guess no cc:stable needed.
Quoted 43 lines
Quoted 14 lines
Cc Thomas Zimmermann <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Jouni Högander <[email protected]>--- drivers/gpu/drm/i915/display/intel_fbdev.c | 9 +++++++++ 1 file changed, 9 insertions(+)drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0drivers/gpu/drm/i915/display/intel_fbdev.c static int intelfb_create(struct drm_fb_helper *helper, · line 332
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +2
-0@@ -328,8 +328,17 @@ static int intelfb_create(struct drm_fb_helper *helper,return ret; } +static int intelfb_dirty (struct drm_fb_helper *helper,struct drm_clip_rect *clip) +{The original thing had some kind of "is this rect actually visible?" check here. Does anyone know why it was there, and if so maybe it should go back to the higher level function so everyone doens't need to add it back in?
Quoted 14 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +7
-0+if (helper->fb->funcs->dirty) +return helper->fb->funcs->dirty (helper->fb,NULL ,0 ,0 , clip,1 ); + +return 0 ; +} +static const struct drm_fb_helper_funcs intel_fb_helper_funcs = { .fb_probe = intelfb_create, + .fb_dirty = intelfb_dirty, };static void intel_fbdev_destroy (struct intel_fbdev *ifbdev)Signature · 1 line
2.34.1Signature · 2 lines
Ville Syrjälä Intel
Signature · 2 lines
Ville Syrjälä Intel
Quoted 14 lines · Ville Syrjälä
Quoted 13 lines · Ville Syrjälä
Quoted 8 lines · Jouni Högander
After splitting generic
drm_fb_helperinto it's own file it's left to
helper implementation to havefb_dirtyfunction. Currently intel fb doesn't have it. This is causing problems when PSR is enabled.Implement simple
fb_dirtycallback to deliver notifications to psr
about updates in fb console.Just found this regression myself after being baffled why the vt console was inoperable right after the driver gets loaded.
Quoted 6 lines
Quoted 3 lines
It's also not just psr, but also fbc that is having issues.
Needs a fixes + cc:stable tags.
Actually looks like it didn't make it into 6.1 so I guess no cc:stable needed.
Added Fixes tag.
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
Cc Thomas Zimmermann <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Jouni Högander <[email protected]>---
drivers/gpu/drm/i915/display/intel_fbdev.c | 9 +++++++++1 file changed, 9 insertions(+)drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -328,8 +328,17 @@ static int intelfb_create(structdrm_fb_helper *helper, return ret; }
+static intintelfb_dirty(struct drm_fb_helper *helper, struct drm_clip_rect *clip)
+{
Quoted 8 lines
Quoted 8 lines
The original thing had some kind of "is this rect actually visible?"
check here. Does anyone know why it was there, and if so maybe it should
go back to the higher level function so everyone doens't need to add it
back in?
I'll guess you mean this one ?:
// snip
/* Call damage handlers only if necessary */
if (!(clip->x1 < clip->x2 && clip->y1 < clip->y2))
return 0;// snip
I will create separate patch for this.
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
+ if (
helper->fb->funcs->dirty)
+ returnhelper->fb->funcs->dirty(helper->fb, NULL, 0, 0, clip, 1);drivers/gpu/drm/i915/display/intel_fbdev.c +4
-0+ + return 0; +} +static const struct
drm_fb_helper_funcsintel_fb_helper_funcs= {
.fb_probe =intelfb_create,
+ .fb_dirty =intelfb_dirty,
};
Quoted 9 lines
Quoted 8 lines
Quoted 4 lines
static voidintel_fbdev_destroy(struct intel_fbdev *ifbdev)Signature · 1 line
2.34.1Signature · 2 lines
Ville Syrjälä Intel
BR,
Jouni Högander
Hi
Am 29.11.22 um 13:43 schrieb Jouni Högander:
Quoted 6 lines
After splitting generic
drm_fb_helperinto it's own file it's left to helper implementation to havefb_dirtyfunction. Currently intel fb doesn't have it. This is causing problems when PSR is enabled.Implement simple
fb_dirtycallback to deliver notifications to psr about updates in fb console.
I'm a bit confused about i915's use of fb_dirty here. How is this supposed to interact with mmap? i915 doesn't use deferred I/O so fbdev mmap will never call fb_dirty if userspace writes to mmap'ed pages. Is this only required for the kernel's graphics console?
Best regards
Thomas
Quoted 30 lines
Cc Thomas Zimmermann <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Jouni Högander <[email protected]>--- drivers/gpu/drm/i915/display/intel_fbdev.c | 9 +++++++++ 1 file changed, 9 insertions(+)drivers/gpu/drm/i915/display/intel_fbdev.c +9
-0@@ -328,8 +328,17 @@ static int intelfb_create(struct drm_fb_helper *helper,return ret; } +static int intelfb_dirty (struct drm_fb_helper *helper,struct drm_clip_rect *clip) +{ +if (helper->fb->funcs->dirty) +return helper->fb->funcs->dirty (helper->fb,NULL ,0 ,0 , clip,1 ); + +return 0 ; +} +static const struct drm_fb_helper_funcs intel_fb_helper_funcs = { .fb_probe = intelfb_create, + .fb_dirty = intelfb_dirty, };static void intel_fbdev_destroy (struct intel_fbdev *ifbdev)
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
Quoted 11 lines · Thomas Zimmermann
Hi
Am 29.11.22 um 13:43 schrieb Jouni Högander:
Quoted 7 lines
After splitting generic
drm_fb_helperinto it's own file it's left to
helper implementation to havefb_dirtyfunction. Currently intel fb doesn't have it. This is causing problems when PSR is enabled.Implement simple
fb_dirtycallback to deliver notifications to psr about updates in fb console.
Quoted 6 lines
I'm a bit confused about i915's use of
fb_dirtyhere. How is this supposed to interact with mmap? i915 doesn't use deferred I/O so fbdev
mmap will never callfb_dirtyif userspace writes to mmap'ed pages. Is
this only required for the kernel's graphics console?
Yes, this fix is targeted for kernel's graphics console.
Please check new set I just sent.
Quoted 29 lines
Best regards
ThomasQuoted 26 lines
Cc Thomas Zimmermann <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Jouni Högander <[email protected]>---
drivers/gpu/drm/i915/display/intel_fbdev.c| 9 +++++++++1 file changed, 9 insertions(+)drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -328,8 +328,17 @@ static int intelfb_create(struct drm_fb_helper *helper, return ret; }
+static intintelfb_dirty(struct drm_fb_helper *helper, struct drm_clip_rect *clip)
+{
+ if (helper->fb->funcs->dirty)
+ returnhelper->fb->funcs->dirty(helper->fb, NULL, 0, 0, clip, 1);
+
+ return 0;
Quoted 16 lines
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +2
-0+} +static const struct
drm_fb_helper_funcsintel_fb_helper_funcs= { .fb_probe =intelfb_create,
+ .fb_dirty =intelfb_dirty,
};
static voidintel_fbdev_destroy(struct intel_fbdev *ifbdev)Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
BR,
Jouni Högander
Quoted 7 lines · Thomas Zimmermann
Hi
Am 29.11.22 um 13:43 schrieb Jouni Högander:
Quoted 4 lines
After splitting generic
drm_fb_helperinto it's own file it's left to helper implementation to havefb_dirtyfunction. Currently intel fb doesn't have it. This is causing problems when PSR is enabled.
Quoted 7 lines
Quoted 2 lines
Implement simple
fb_dirtycallback to deliver notifications to psr about updates in fb console.I'm a bit confused about i915's use of
fb_dirtyhere. How is this supposed to interact with mmap? i915 doesn't use deferred I/O so fbdev mmap will never callfb_dirtyif userspace writes to mmap'ed pages. Is this only required for the kernel's graphics console?
It's required for everything. mmap is presumably borked for the cases where we can't use any hw based damage tracking.
Quoted 42 lines
Best regards
ThomasQuoted 30 lines
Cc Thomas Zimmermann <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Jouni Högander <[email protected]>--- drivers/gpu/drm/i915/display/intel_fbdev.c | 9 +++++++++ 1 file changed, 9 insertions(+)drivers/gpu/drm/i915/display/intel_fbdev.c +9
-0@@ -328,8 +328,17 @@ static int intelfb_create(struct drm_fb_helper *helper,return ret; } +static int intelfb_dirty (struct drm_fb_helper *helper,struct drm_clip_rect *clip) +{ +if (helper->fb->funcs->dirty) +return helper->fb->funcs->dirty (helper->fb,NULL ,0 ,0 , clip,1 ); + +return 0 ; +} +static const struct drm_fb_helper_funcs intel_fb_helper_funcs = { .fb_probe = intelfb_create, + .fb_dirty = intelfb_dirty, };static void intel_fbdev_destroy (struct intel_fbdev *ifbdev)Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
Signature · 2 lines
Ville Syrjälä Intel
Hi
Am 21.12.22 um 15:51 schrieb Ville Syrjälä:
Quoted 11 lines · Thomas Zimmermann
Quoted 10 lines
Hi
Am 29.11.22 um 13:43 schrieb Jouni Högander:
Quoted 6 lines
After splitting generic
drm_fb_helperinto it's own file it's left to helper implementation to havefb_dirtyfunction. Currently intel fb doesn't have it. This is causing problems when PSR is enabled.Implement simple
fb_dirtycallback to deliver notifications to psr about updates in fb console.
Quoted 7 lines
Quoted 4 lines
I'm a bit confused about i915's use of
fb_dirtyhere. How is this supposed to interact with mmap? i915 doesn't use deferred I/O so fbdev mmap will never callfb_dirtyif userspace writes to mmap'ed pages. Is this only required for the kernel's graphics console?It's required for everything. mmap is presumably borked for the cases where we can't use any hw based damage tracking.
In this case, it would make sense to implement the update with fb_dirty (instead of the fb_ops I mentioned).
For mmap you can use fbdev's deferred I/O. There's drm_fb_helper_deferrer_io() that tracks mmaped pages and regularly calls fb_dirty to let the driver do an update.
Best regards
Thomas
Quoted 47 lines
Quoted 43 lines
Best regards
ThomasQuoted 30 lines
Cc Thomas Zimmermann <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Jouni Högander <[email protected]>--- drivers/gpu/drm/i915/display/intel_fbdev.c | 9 +++++++++ 1 file changed, 9 insertions(+)drivers/gpu/drm/i915/display/intel_fbdev.c +9
-0@@ -328,8 +328,17 @@ static int intelfb_create(struct drm_fb_helper *helper,return ret; } +static int intelfb_dirty (struct drm_fb_helper *helper,struct drm_clip_rect *clip) +{ +if (helper->fb->funcs->dirty) +return helper->fb->funcs->dirty (helper->fb,NULL ,0 ,0 , clip,1 ); + +return 0 ; +} +static const struct drm_fb_helper_funcs intel_fb_helper_funcs = { .fb_probe = intelfb_create, + .fb_dirty = intelfb_dirty, };static void intel_fbdev_destroy (struct intel_fbdev *ifbdev)Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
Quoted 22 lines · Thomas Zimmermann
Hi
Am 21.12.22 um 15:51 schrieb Ville Syrjälä:
Quoted 11 lines · Thomas Zimmermann
Quoted 10 lines
Hi
Am 29.11.22 um 13:43 schrieb Jouni Högander:
Quoted 6 lines
After splitting generic
drm_fb_helperinto it's own file it's left to helper implementation to havefb_dirtyfunction. Currently intel fb doesn't have it. This is causing problems when PSR is enabled.Implement simple
fb_dirtycallback to deliver notifications to psr about updates in fb console.Quoted 7 lines
Quoted 4 lines
I'm a bit confused about i915's use of
fb_dirtyhere. How is this supposed to interact with mmap? i915 doesn't use deferred I/O so fbdev mmap will never callfb_dirtyif userspace writes to mmap'ed pages. Is this only required for the kernel's graphics console?It's required for everything. mmap is presumably borked for the cases where we can't use any hw based damage tracking.
Quoted 6 lines
In this case, it would make sense to implement the update with
fb_dirty(instead of thefb_opsI mentioned).For mmap you can use fbdev's deferred I/O. There's
drm_fb_helper_deferrer_io()that tracks mmaped pages and regularly callsfb_dirtyto let the driver do an update.
Not sure we want the extra defio overhead for a feature no one is likely to ever need.
If we actually cared about any of this we could perhaps just hook into .fb_mmap() and turn off any stuff that needs software dirty tracking while the buffer is mapped.
Signature · 2 lines
Ville Syrjälä Intel