Makefile: allow modules_install if CONFIG_MODULES=n
PATCH 1/1 Makefile: allow modules_install if CONFIG_MODULES=n
Many applications check for available kernel features via:
* /proc/modules (loaded modules, present if CONFIG_MODULES=y)
* $(MODLIB)/modules.builtin (builtin modules)
They fail to detect features if the kernel was built with CONFIG_MODULES=n and modules.builtin isn't installed.
Therefore, allow the Makefile's modules_install target to be used always.
Tested Makefile targets with different CONFIG_MODULES states:
* (CONFIG_MODULES=n) modules_install: install modules.builtin etc.
* (CONFIG_MODULES=y) modules_install: produce same result as before
* (CONFIG_MODULES=y) modules_install: still fail if no modules.order
* (CONFIG_MODULES=y) modules: build modules, as before
* (CONFIG_MODULES=n) modules: still fail and warn
---
Makefile | 60 ++++++++++++++++++++++++++++++++---------------------------- 1 file changed, 32 insertions(+), 28 deletions(-)
Makefile renamed from Makefile.orig +1 -26
@@ -1309,31 +1309,7 @@ dt_binding_check: scripts_dtc # --------------------------------------------------------------------------- # Modules -ifdef CONFIG_MODULES - -# By default, build modules as well - -all: modules - -# Build modules -# -# A module can be listed more than once in obj-m resulting in -# duplicate lines in modules.order files. Those are removed -# using awk while concatenating to the final file. - -PHONY += modules -modules: $(if $(KBUILD_BUILTIN),vmlinux) modules.order - $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost - $(Q)$(CONFIG_SHELL) $(srctree)/scripts/modules-check.sh - -modules.order: descend - $(Q)$(AWK) '!x[$$0]++' $(addsuffix /$@, $(build-dirs)) > $@ - -# Target to prepare building external modules -PHONY += modules_prepare -modules_prepare: prepare - -# Target to install modules +# Target to install modules and accompanying files PHONY += modules_install modules_install: _modinst_ _modinst_post
@@ -1347,10 +1323,14 @@ _modinst_:
rm -f $(MODLIB)/build ; \
ln -s $(CURDIR) $(MODLIB)/build ; \
fi
- @sed 's:^:kernel/:' modules.order > $(MODLIB)/modules.order
@cp -f modules.builtin $(MODLIB)/
@cp -f $(objtree)/modules.builtin.modinfo $(MODLIB)/
+ifdef CONFIG_MODULES
+ @sed 's:^:kernel/:' modules.order > $(MODLIB)/modules.order
$(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modinst
+else
+ @touch $(MODLIB)/modules.order
+endif
# This depmod is only for convenience to give the initial
# boot a modules.dep even before / is mounted read-write. However the @@ -1359,6 +1339,30 @@ PHONY += _modinst_post _modinst_post: _modinst_ $(call cmd,depmod)
+ifdef CONFIG_MODULES
+
+# By default, build modules as well
+
+all: modules
+
+# Build modules
+#
+# A module can be listed more than once in obj-m resulting in +# duplicate lines in modules.order files. Those are removed +# using awk while concatenating to the final file. +
+PHONY += modules
+modules: $(if $(KBUILD_BUILTIN),vmlinux) modules.order
+ $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost
+ $(Q)$(CONFIG_SHELL) $(srctree)/scripts/modules-check.sh
+
+modules.order: descend
+ $(Q)$(AWK) '!x[$$0]++' $(addsuffix /$@, $(build-dirs)) > $@
+
+# Target to prepare building external modules +PHONY += modules_prepare
+modules_prepare: prepare
+
ifeq ($(CONFIG_MODULE_SIG), y)
PHONY += modules_sign
modules_sign:
@@ -1370,8 +1374,8 @@ else # CONFIG_MODULES
# Modules not configured
#
---------------------------------------------------------------------------
-PHONY += modules modules_install
-modules modules_install:
+PHONY += modules
+modules:
@echo >&2
@echo >&2 "The present kernel configuration has modules disabled." @echo >&2 "Type 'make config' and enable loadable module support."
Quoted 15 lines · Jonas Zeiger
Many applications check for available kernel features via:
*
/proc/modules(loaded modules, present ifCONFIG_MODULES=y)
* $(MODLIB)/modules.builtin (builtin modules)They fail to detect features if the kernel was built with
CONFIG_MODULES=n
and modules.builtin isn't installed.Therefore, allow the Makefile's
modules_installtarget to be used always.Tested
Makefiletargets with differentCONFIG_MODULESstates:
Quoted 7 lines
* (
CONFIG_MODULES=n)modules_install: install modules.builtin etc.
* (CONFIG_MODULES=y)modules_install: produce same result as before
* (CONFIG_MODULES=y)modules_install: still fail if no modules.order
* (CONFIG_MODULES=y) modules: build modules, as before
* (CONFIG_MODULES=n) modules: still fail and warnSigned-off-by Jonas Zeiger <[email protected]>
Maybe, module.builtin and module.builtin.modinfo should be installed by 'make install' because they are byproducts of vmlinux.
Signature · 2 lines
Best Regards Masahiro Yamada
Quoted 22 lines · Masahiro Yamada
Quoted 21 lines · Jonas Zeiger
Many applications check for available kernel features via:
*
/proc/modules(loaded modules, present ifCONFIG_MODULES=y)
* $(MODLIB)/modules.builtin (builtin modules)They fail to detect features if the kernel was built with
CONFIG_MODULES=n
and modules.builtin isn't installed.Therefore, allow the Makefile's
modules_installtarget to be used always.Tested
Makefiletargets with differentCONFIG_MODULESstates:* (
CONFIG_MODULES=n)modules_install: install modules.builtin etc.
* (CONFIG_MODULES=y)modules_install: produce same result as before
* (CONFIG_MODULES=y)modules_install: still fail if no modules.order
* (CONFIG_MODULES=y) modules: build modules, as before
* (CONFIG_MODULES=n) modules: still fail and warn
Quoted 5 lines
Quoted 1 line
Signed-off-by Jonas Zeiger <[email protected]>Maybe, module.builtin and module.builtin.modinfo should be installed by 'make install' because they are byproducts of vmlinux.
Yes, thank you for this suggestion.
I will submit a new patch.
PATCH v2 1/1 Makefile: install modules.builtin even if CONFIG_MODULES=n
In reply to Masahiro YamadaMany applications check for available kernel features via:
- /proc/modules (loaded modules, present if CONFIG_MODULES=y)
- $(MODLIB)/modules.builtin (builtin modules)
They fail to detect features if the kernel was built with CONFIG_MODULES=n and modules.builtin isn't installed.
Therefore, add the target "_builtin_inst_" and make "install" and "modules_install" depend on it.
Tests results:
- make install: kernel image is copied as before, modules.builtin
copied
- make modules_install: (CONFIG_MODULES=n) nothing is copied, exit 1
--- Makefile | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
Makefile +10 -1
@@ -1315,6 +1315,16 @@ dt_binding_check: scripts_dtc # --------------------------------------------------------------------------- # Modules +# install modules.builtin regardless of CONFIG_MODULES +PHONY += _builtin_inst_ +_builtin_inst_: + @mkdir -p $(MODLIB)/ + @cp -f modules.builtin $(MODLIB)/ + @cp -f $(objtree)/modules.builtin.modinfo $(MODLIB)/ + +PHONY += install +install: _builtin_inst_ + ifdef CONFIG_MODULES
# By default, build modules as well
@@ -1344,7 +1354,7 @@ PHONY += modules_install
modules_install: _modinst_ _modinst_post
PHONY += _modinst_
-_modinst_:
+_modinst_: _builtin_inst_
@rm -rf $(MODLIB)/kernel
@rm -f $(MODLIB)/source
@mkdir -p $(MODLIB)/kernel
@@ -1354,8 +1364,6 @@ _modinst_:
ln -s $(CURDIR) $(MODLIB)/build ; \
fi
@sed 's:^:kernel/:' modules.order > $(MODLIB)/modules.order
- @cp -f modules.builtin $(MODLIB)/
- @cp -f $(objtree)/modules.builtin.modinfo $(MODLIB)/
$(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modinst
# This depmod is only for convenience to give the initial
Signature · 1 line
2.26.2
Re: [PATCH v2] Makefile: install modules.builtin even if CONFIG_MODULES=n
Quoted 13 lines · Jonas Zeiger
Many applications check for available kernel features via:
-
/proc/modules(loaded modules, present ifCONFIG_MODULES=y)
- $(MODLIB)/modules.builtin (builtin modules)They fail to detect features if the kernel was built with
CONFIG_MODULES=n
and modules.builtin isn't installed.Therefore, add the target "_builtin_inst_" and make "install" and "
modules_install" depend on it.
Quoted 8 lines
Tests results:
- make install: kernel image is copied as before, modules.builtin
copied
- makemodules_install: (CONFIG_MODULES=n) nothing is copied, exit 1Signed-off-by Jonas Zeiger <[email protected]>---
Applied to linux-kbuild,
but this patch format is broken.
I manually fixed it up, but
please use 'git send-email' next time.
Quoted 46 lines
Makefile | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)Makefile +11
-5@@ -1315,6 +1315,16 @@ dt_binding_check: scripts_dtc # --------------------------------------------------------------------------- # Modules +# install modules.builtin regardless of CONFIG_MODULES +PHONY += _builtin_inst_ +_builtin_inst_: + @mkdir -p $(MODLIB)/ + @cp -f modules.builtin $(MODLIB)/ + @cp -f $(objtree)/modules.builtin.modinfo $(MODLIB)/ + +PHONY += install +install: _builtin_inst_ + ifdef CONFIG_MODULES # By default, build modules as well@@ -1344,7 +1354,7 @@ PHONY += modules_install modules_install: _modinst_ _modinst_post PHONY += _modinst_ -_modinst_: +_modinst_: _builtin_inst_ @rm -rf $(MODLIB)/kernel @rm -f $(MODLIB)/source @mkdir -p $(MODLIB)/kernel@@ -1354,8 +1364,6 @@ _modinst_: ln -s $(CURDIR) $(MODLIB)/build ; \ fi @sed 's:^:kernel/:' modules.order > $(MODLIB)/modules.order - @cp -f modules.builtin $(MODLIB)/ - @cp -f $(objtree)/modules.builtin.modinfo $(MODLIB)/ $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modinst # This depmod is only for convenience to give the initial --2.26.2
Signature · 2 lines
Best Regards Masahiro Yamada
Re: [PATCH v2] Makefile: install modules.builtin even if CONFIG_MODULES=n
In reply to Jonas ZeigerHi,
Quoted 15 lines · Jonas Zeiger
Many applications check for available kernel features via:
-
/proc/modules(loaded modules, present ifCONFIG_MODULES=y)
- $(MODLIB)/modules.builtin (builtin modules)They fail to detect features if the kernel was built with
CONFIG_MODULES=n
and modules.builtin isn't installed.Therefore, add the target "_builtin_inst_" and make "install" and "
modules_install" depend on it.Tests results:
Quoted 8 lines
- make install: kernel image is copied as before, modules.builtin
copied
- makemodules_install: (CONFIG_MODULES=n) nothing is copied, exit 1Signed-off-by Jonas Zeiger <[email protected]>--- Makefile | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
Note that this change broke builds in the Chrome OS build system because we require modules to be installed to a certain path and we weren't passing "INSTALL_MOD_PATH" when we called "make install".
We can certainly fix our build system (I have a patch at
https://crrev.com/c/2237511 for it), but I do wonder if others will hit the same issue. Others might not have such a nice sandboxing system so they might unknowingly try to install files to the build computer's modules directory instead of their target.
-Doug
Re: [PATCH v2] Makefile: install modules.builtin even if CONFIG_MODULES=n
Quoted 32 lines · Doug Anderson
Hi,
Quoted 15 lines · Jonas Zeiger
Many applications check for available kernel features via:
-
/proc/modules(loaded modules, present ifCONFIG_MODULES=y)
- $(MODLIB)/modules.builtin (builtin modules)They fail to detect features if the kernel was built with
CONFIG_MODULES=n
and modules.builtin isn't installed.Therefore, add the target "_builtin_inst_" and make "install" and "
modules_install" depend on it.Tests results:
Quoted 8 lines
- make install: kernel image is copied as before, modules.builtin
copied
- makemodules_install: (CONFIG_MODULES=n) nothing is copied, exit 1Signed-off-by Jonas Zeiger <[email protected]>--- Makefile | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)Note that this change broke builds in the Chrome OS build system because we require modules to be installed to a certain path and we weren't passing "
INSTALL_MOD_PATH" when we called "make install".
Quoted 6 lines
We can certainly fix our build system (I have a patch at
https://crrev.com/c/2237511 for it), but I do wonder if others will hit the same issue. Others might not have such a nice sandboxing system so they might unknowingly try to install files to the build computer's modules directory instead of their target.
I am more concerned with people getting errors such as
mkdir: cannot create directory '/lib/modules/5.7.0+/': Permission denied
when running "make install", with no documentation or explanation that or why INSTALL_MOD_PATH is now mandatory for non-root installations. Even for root installations, it seems odd that "make install" now installs module files; after all, this is what "make modules_install" is for.
I can understand the use case for CONFIG_MODULES=n, but the impact and changed behavior on systems with CONFIG_MODULES=y is quite unexpected.
Guenter
Re: [PATCH v2] Makefile: install modules.builtin even if CONFIG_MODULES=n
Quoted 51 lines · Guenter Roeck
Quoted 32 lines · Doug Anderson
Hi,
Quoted 15 lines · Jonas Zeiger
Many applications check for available kernel features via:
-
/proc/modules(loaded modules, present ifCONFIG_MODULES=y)
- $(MODLIB)/modules.builtin (builtin modules)They fail to detect features if the kernel was built with
CONFIG_MODULES=n
and modules.builtin isn't installed.Therefore, add the target "_builtin_inst_" and make "install" and "
modules_install" depend on it.Tests results:
Quoted 8 lines
- make install: kernel image is copied as before, modules.builtin
copied
- makemodules_install: (CONFIG_MODULES=n) nothing is copied, exit 1Signed-off-by Jonas Zeiger <[email protected]>--- Makefile | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)Note that this change broke builds in the Chrome OS build system because we require modules to be installed to a certain path and we weren't passing "
INSTALL_MOD_PATH" when we called "make install".Quoted 6 lines
We can certainly fix our build system (I have a patch at
https://crrev.com/c/2237511 for it), but I do wonder if others will hit the same issue. Others might not have such a nice sandboxing system so they might unknowingly try to install files to the build computer's modules directory instead of their target.I am more concerned with people getting errors such as
mkdir: cannot create directory '
/lib/modules/5.7.0+/': Permission deniedwhen running "make install", with no documentation or explanation that or why
INSTALL_MOD_PATHis now mandatory for non-root installations. Even for root installations, it seems odd that "make install" now installs module files; after all, this is what "makemodules_install" is for.
Quoted 4 lines
I can understand the use case for
CONFIG_MODULES=n, but the impact and changed behavior on systems withCONFIG_MODULES=yis quite unexpected.Guenter
Sorry, I led this patch in a wrong way.
Maybe, we should allow 'make modules_install' for CONFIG_MODULES=n as Jonas did in v1.
Another way might be to install it
in /boot/modules.builtin.(ver) when CONFIG_MODULES=n but checking multiple locations would be inconvenient.
Signature · 2 lines
Best Regards Masahiro Yamada
Re: [PATCH v2] Makefile: install modules.builtin even if CONFIG_MODULES=n
Quoted 56 lines · Masahiro Yamada
Quoted 54 lines · Guenter Roeck
Quoted 32 lines · Doug Anderson
Hi,
Quoted 15 lines · Jonas Zeiger
Many applications check for available kernel features via:
-
/proc/modules(loaded modules, present ifCONFIG_MODULES=y)
- $(MODLIB)/modules.builtin (builtin modules)They fail to detect features if the kernel was built with
CONFIG_MODULES=n
and modules.builtin isn't installed.Therefore, add the target "_builtin_inst_" and make "install" and "
modules_install" depend on it.Tests results:
Quoted 8 lines
- make install: kernel image is copied as before, modules.builtin
copied
- makemodules_install: (CONFIG_MODULES=n) nothing is copied, exit 1Signed-off-by Jonas Zeiger <[email protected]>--- Makefile | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)Note that this change broke builds in the Chrome OS build system because we require modules to be installed to a certain path and we weren't passing "
INSTALL_MOD_PATH" when we called "make install".Quoted 6 lines
We can certainly fix our build system (I have a patch at
https://crrev.com/c/2237511 for it), but I do wonder if others will hit the same issue. Others might not have such a nice sandboxing system so they might unknowingly try to install files to the build computer's modules directory instead of their target.I am more concerned with people getting errors such as
mkdir: cannot create directory '
/lib/modules/5.7.0+/': Permission deniedwhen running "make install", with no documentation or explanation that or why
INSTALL_MOD_PATHis now mandatory for non-root installations. Even for root installations, it seems odd that "make install" now installs module files; after all, this is what "makemodules_install" is for.I can understand the use case for
CONFIG_MODULES=n, but the impact and changed behavior on systems withCONFIG_MODULES=yis quite unexpected.
Quoted 8 lines
Quoted 1 line
Guenter
Sorry, I led this patch in a wrong way.
Maybe, we should allow 'make
modules_install' forCONFIG_MODULES=nas Jonas did in v1.
Personally I think that would have been much better than the current solution. It would specifically give people the choice to install those files if they want to, without forcing others to do it (and to do it in an unrelated context/command).
Thanks,
Guenter
Quoted 10 lines
Another way might be to install it
in /boot/modules.builtin.(ver) whenCONFIG_MODULES=nbut checking multiple locations would be inconvenient.--
Best Regards
Masahiro Yamada
Re: [PATCH v2] Makefile: install modules.builtin even if CONFIG_MODULES=n
In reply to Masahiro YamadaQuoted 60 lines · Masahiro Yamada
Quoted 51 lines · Guenter Roeck
Quoted 32 lines · Doug Anderson
Hi,
Quoted 15 lines · Jonas Zeiger
Many applications check for available kernel features via:
-
/proc/modules(loaded modules, present ifCONFIG_MODULES=y)
- $(MODLIB)/modules.builtin (builtin modules)They fail to detect features if the kernel was built with
CONFIG_MODULES=n
and modules.builtin isn't installed.Therefore, add the target "_builtin_inst_" and make "install" and "
modules_install" depend on it.Tests results:
Quoted 8 lines
- make install: kernel image is copied as before, modules.builtin
copied
- makemodules_install: (CONFIG_MODULES=n) nothing is copied, exit 1Signed-off-by Jonas Zeiger <[email protected]>--- Makefile | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)Note that this change broke builds in the Chrome OS build system because we require modules to be installed to a certain path and we weren't passing "
INSTALL_MOD_PATH" when we called "make install".Quoted 6 lines
We can certainly fix our build system (I have a patch at
https://crrev.com/c/2237511 for it), but I do wonder if others will hit the same issue. Others might not have such a nice sandboxing system so they might unknowingly try to install files to the build computer's modules directory instead of their target.I am more concerned with people getting errors such as
mkdir: cannot create directory '
/lib/modules/5.7.0+/': Permission deniedwhen running "make install", with no documentation or explanation that or why
INSTALL_MOD_PATHis now mandatory for non-root installations. Even for root installations, it seems odd that "make install" now installs module files; after all, this is what "makemodules_install" is for.Quoted 4 lines
I can understand the use case for
CONFIG_MODULES=n, but the impact and changed behavior on systems withCONFIG_MODULES=yis quite unexpected.Guenter
Sorry, I led this patch in a wrong way.
Quoted 7 lines
Maybe, we should allow 'make
modules_install' forCONFIG_MODULES=nas Jonas did in v1.Another way might be to install it
in /boot/modules.builtin.(ver) whenCONFIG_MODULES=nbut checking multiple locations would be inconvenient.
I have noticed that my build system specified INSTALL_MOD_PATH for "make install", so the patch doesn't cause issues in my environment.
However, I should have noticed that the change is breaking some existing setups.
Masahiro, I still believe that the approach you favored (v2) makes more sense architecturally, but at this point it seems that v1 is more pragmatic.
Would you agree to revert v2 and apply v1 instead?
I will fix issues that may come up with v1, however unlikely.
Re: [PATCH v2] Makefile: install modules.builtin even if CONFIG_MODULES=n
Quoted 76 lines · Jonas Zeiger
Quoted 63 lines · Masahiro Yamada
Quoted 53 lines · Guenter Roeck
Quoted 32 lines · Doug Anderson
Hi,
Quoted 15 lines · Jonas Zeiger
Many applications check for available kernel features via:
-
/proc/modules(loaded modules, present ifCONFIG_MODULES=y)
- $(MODLIB)/modules.builtin (builtin modules)They fail to detect features if the kernel was built with
CONFIG_MODULES=n
and modules.builtin isn't installed.Therefore, add the target "_builtin_inst_" and make "install" and "
modules_install" depend on it.Tests results:
Quoted 8 lines
- make install: kernel image is copied as before, modules.builtin
copied
- makemodules_install: (CONFIG_MODULES=n) nothing is copied, exit 1Signed-off-by Jonas Zeiger <[email protected]>--- Makefile | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)Note that this change broke builds in the Chrome OS build system because we require modules to be installed to a certain path and we weren't passing "
INSTALL_MOD_PATH" when we called "make install".Quoted 6 lines
We can certainly fix our build system (I have a patch at
https://crrev.com/c/2237511 for it), but I do wonder if others will hit the same issue. Others might not have such a nice sandboxing system so they might unknowingly try to install files to the build computer's modules directory instead of their target.I am more concerned with people getting errors such as
mkdir: cannot create directory '
/lib/modules/5.7.0+/': Permission deniedwhen running "make install", with no documentation or explanation that or why
INSTALL_MOD_PATHis now mandatory for non-root installations. Even for root installations, it seems odd that "make install" now installs module files; after all, this is what "makemodules_install" is for.Quoted 4 lines
I can understand the use case for
CONFIG_MODULES=n, but the impact and changed behavior on systems withCONFIG_MODULES=yis quite unexpected.Guenter
Sorry, I led this patch in a wrong way.
Quoted 7 lines
Maybe, we should allow 'make
modules_install' forCONFIG_MODULES=nas Jonas did in v1.Another way might be to install it
in /boot/modules.builtin.(ver) whenCONFIG_MODULES=nbut checking multiple locations would be inconvenient.I have noticed that my build system specified
INSTALL_MOD_PATHfor "make install", so the patch doesn't cause issues in my environment.
Quoted 8 lines
However, I should have noticed that the change is breaking some existing setups.
Masahiro, I still believe that the approach you favored (v2) makes more sense architecturally, but at this point it seems that v1 is more pragmatic.
Would you agree to revert v2 and apply v1 instead?
Yes, I agree.
Thanks.
Quoted 2 lines
I will fix issues that may come up with v1, however unlikely.
Signature · 2 lines
Best Regards Masahiro Yamada