Skip to contentSkip to conversation

FS-Cache: Bug fixes for bugs that happen under vma pressure

PATCH In review Milosz Tanski 2 participants 3 messages Jul 22, 2014 – Aug 5, 2014 VFS

lore
Share & tools
lore
#0 lore raw

cover FS-Cache: Bug fixes for bugs that happen under vma pressure

FS-Cache has a few bugs generally only get tried in error mode / under VMA preassure. The problem is exhasterbated when majority of the IO is cacheable netfs IO. At that point there are few pages that are evictalbe due to GPF_NOFS allocation strategies.

The first bug is a recursive hang caused by fscache write out to ext4 which in turn needs to allocate pages and ends up calling releasepages() on the netfs.

The second two bugs are cookie ref count bugs that happen when in the error cases (mostly from related memory alloc failures).

Milosz Tanski (3):
FS-Cache: Timeout for releasepage()
FS-Cache: Reduce cookie ref count if submit fails.
FS-Cache: refcount becomes corrupt under vma pressure.

 fs/fscache/object.c |    4 ++++
 fs/fscache/page.c   |   22 ++++++++++++++++++----
 2 files changed, 22 insertions(+), 4 deletions(-)
Signature · 1 line
1.7.9.5
#2 lore raw

David, I was away for a few days I'll take a look at your comments and respond appropriately within the next two days.

- M

Quoted 3 lines · David Howells

Did you mean to add Signed-off-by lines?

David

Signature · 7 lines
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016

p: 646-253-9055
e: [email protected]