net: phy: qcom: at803x: fix kernel panic with at8031_probe
Subsystems (5)
PATCH 1/1 net: phy: qcom: at803x: fix kernel panic with at8031_probe
On reworking and splitting the at803x driver, in splitting function of at803x PHYs it was added a NULL dereference bug where priv is referenced before it's actually allocated and then is tried to write to for the is_1000basex and is_fiber variables in the case of at8031, writing on the wrong address.
Fix this by correctly setting priv local variable only after at803x_probe is called and actually allocates priv in the phydev struct.
--- drivers/net/phy/qcom/at803x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/phy/qcom/at803x.c +3 -1
@@ -797,7 +797,7 @@ static int at8031_parse_dt(struct phy_device *phydev)static int at8031_probe (struct phy_device *phydev) { -struct at803x_priv *priv = phydev->priv; +struct at803x_priv *priv;int mode_cfg;int ccr;int ret;
@@ -806,6 +806,8 @@ static int at8031_probe(struct phy_device *phydev)if (ret)return ret; + priv = phydev->priv; +/* Only supported on AR8031/AR8033, the AR8030/AR8035 use strapping * options. */
Signature · 1 line
2.43.0
Quoted 6 lines · Christian Marangi
On reworking and splitting the at803x driver, in splitting function of at803x PHYs it was added a NULL dereference bug where priv is referenced before it's actually allocated and then is tried to write to for the
is_1000basexandis_fibervariables in the case of at8031, writing on the wrong address.
Quoted 7 lines
Fix this by correctly setting priv local variable only after
at803x_probeis called and actually allocates priv in the phydev struct.Reported-by William Wortel <[email protected]>Cc <[email protected]>Fixes 25d2ba94005f ("net: phy: at803x: move specific at8031 probe mode check to dedicated probe")Signed-off-by Christian Marangi <[email protected]>
Andrew
This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <[email protected]>:
Quoted 10 lines · On Mon, 25 Mar 2024 20:06:19 +0100 you wrote:
On reworking and splitting the at803x driver, in splitting function of at803x PHYs it was added a NULL dereference bug where priv is referenced before it's actually allocated and then is tried to write to for the
is_1000basexandis_fibervariables in the case of at8031, writing on the wrong address.Fix this by correctly setting priv local variable only after
at803x_probeis called and actually allocates priv in the phydev struct.[...]
Here is the summary with links:
- [net] net: phy: qcom: at803x: fix kernel panic with at8031_probe
https://git.kernel.org/netdev/net/c/6a4aee277740
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html