fbdev: sis: enforce selection of at least one backend
PATCH 1/1 fbdev: sis: enforce selection of at least one backend
The sis framebuffer driver complains with a compile-time warning if neither the FB_SIS_300 nor FB_SIS_315 symbols are selected:
drivers/video/fbdev/sis/sis_main.c:61:2: warning: #warning Neither CONFIG_FB_SIS_300 nor CONFIG_FB_SIS_315 is se
This is reasonable because it doesn't work in that case, but it's also annoying for randconfig builds and is one of the most common warnings I'm seeing on ARM now.
This changes the Kconfig logic to prevent the silly configuration, by always selecting the FB_SIS_300 variant if the other one is not set.
---
Sorry for sending this twice, it looks like I forgot the fbdev list and Tomi as recipients the first time
drivers/video/fbdev/Kconfig +1 -0
@@ -1506,6 +1506,7 @@ config FB_SIS select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT select FB_BOOT_VESA_SUPPORT if FB_SIS = y + select FB_SIS_300 if !FB_SIS_315 help This is the frame buffer device driver for the SiS 300, 315, 330 and 340 series as well as XGI V3XT, V5, V8, Z7 graphics chipsets.
Quoted 9 lines · Arnd Bergmann
The sis framebuffer driver complains with a compile-time warning if neither the
FB_SIS_300norFB_SIS_315symbols are selected:
drivers/video/fbdev/sis/sis_main.c:61:2: warning: #warning NeitherCONFIG_FB_SIS_300norCONFIG_FB_SIS_315is seThis is reasonable because it doesn't work in that case, but it's also annoying for randconfig builds and is one of the most common warnings I'm seeing on ARM now.
Quoted 8 lines
This changes the
Kconfiglogic to prevent the silly configuration, by always selecting theFB_SIS_300variant if the other one is not set.Signed-off-by Arnd Bergmann <[email protected]>---
Sorry for sending this twice, it looks like I forgot the fbdev list and Tomi as recipients the first time
Thanks, queued for 4.5.
tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151207/b73370aa/attachment.sig>