Skip to contentSkip to conversation

i387: support lazy restore of FPU state

PATCH Jongman Heo 1 participant 1 message Feb 21, 2012

lore
Share & tools
lore
#0 lore raw
Quoted 23 lines

Sender : Linus Torvalds<[email protected]> Date : 2012-02-21 11:18 (GMT+09:00)
Title : Re: [PATCH v2 3/3] i387: support lazy restore of FPU state

Quoted 2 lines · Linus Torvalds

The attached trivial patch fixes it, I bet.

Actually, it doesn't fix it on x86-32, because we actually have an #ifdef CONFIG_X86_64 around the "current_task" definition due to pointless differences in how we do that on x86-64 and x86-32.

So much for the "common" part of "arch/x86/kernel/cpu/common.c"

Quoted 3 lines

Although I do wonder if we should just make kernel_fpu_begin() be a real function instead of inlining it. I'm not sure it makes sense to inline that thing, and it might be better to export that one instead.

I do think that would be better in the long run, but for now here's an updated "trivial" patch to fix it.

Quoted 7 lines

I want the fpu_owner_task to be declared next to the cache-hot task-switching stuff, and since they are different on 32-bit and 64-bit (for no really good reason), that gets duplicated too. Sad.

Linus

Linus

Yeah, this patch fixes my x86-32 build.

Thanks,
Jongman Heo.�淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay����,j�f"톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&x�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�