Skip to contentSkip to conversation

iommu/dma: Fix NEED_SG_DMA_LENGTH dependency

PATCH New Robin Murphy 3 participants 3 messages Feb 29, 2016 IOMMU

lore
Share & tools
lore

Robin Murphy

author reviewer
#0 lore raw

PATCH 1/1 iommu/dma: Fix NEED_SG_DMA_LENGTH dependency

IOMMU_DMA does indeed depend on scatterlists having a DMA length, but the NEED_SG_DMA_LENGTH symbol should be selected, not depended upon.

Reported-by Arnd Bergmann <[email protected]>
Signed-off-by Robin Murphy <[email protected]>
---
 drivers/iommu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/Kconfig +1 -1
index b325954..83f1a65 100644
@@ -70,9 +70,9 @@ config OF_IOMMU
 # IOMMU-agnostic DMA-mapping layer
 config IOMMU_DMA
 	bool
-	depends on NEED_SG_DMA_LENGTH
 	select IOMMU_API
 	select IOMMU_IOVA
+	select NEED_SG_DMA_LENGTH
 
 config FSL_PAMU
 	bool "Freescale IOMMU support"
Signature · 1 line
2.7.2.333.g70bd996.dirty
maintainer Applied
#2 lore raw

PATCH 1/1 iommu/dma: Fix NEED_SG_DMA_LENGTH dependency

In reply to Robin Murphy
Quoted 8 lines · Robin Murphy

IOMMU_DMA does indeed depend on scatterlists having a DMA length, but the NEED_SG_DMA_LENGTH symbol should be selected, not depended upon.

Reported-by Arnd Bergmann <[email protected]>
Signed-off-by Robin Murphy <[email protected]>
---
 drivers/iommu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.