NFS: fix RENAME attr in presence of directory delegations
Subsystems (2)
Olga Kornievskaia
reviewerPATCH 1/1 NFS: fix RENAME attr in presence of directory delegations
Since commit 6f9bda2337f8 ("NFS: Fix directory delegation verifier checks") xfstest generic/309 is failing because after the rename (mv) operation, client's mtime/ctime is the same. Update the delegated mtime when directory delegations are present in rename.
Fixes 6f9bda2337f8 ("NFS: Fix directory delegation verifier checks")
Signed-off-by Olga Kornievskaia <[email protected]>
--- fs/nfs/inode.c | 3 ++- fs/nfs/nfs4proc.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-)
fs/nfs/inode.c +2 -1
@@ -692,7 +692,8 @@ void nfs_update_delegated_atime(struct inode *inode)void nfs_update_delegated_mtime_locked (struct inode *inode) { -if (nfs_have_delegated_mtime (inode)) +if (nfs_have_delegated_mtime (inode) || +nfs_have_directory_delegation (inode))nfs_update_mtime (inode); }
fs/nfs/nfs4proc.c +1 -0
@@ -5052,6 +5052,7 @@ static int nfs4_proc_rename_done(struct rpc_task *task, struct inode *old_dir, res->new_fattr->time_start,NFS_INO_INVALID_NLINK | NFS_INO_INVALID_DATA); +nfs_update_delegated_mtime (new_dir); }else nfs4_update_changeattr(old_dir, &res->old_cinfo, res->old_fattr->time_start,
Signature · 1 line
2.52.0
Quoted 8 lines · Olga Kornievskaia
Since commit
6f9bda2337f8("NFS: Fix directory delegation verifier checks") xfstest generic/309 is failing because after the rename (mv) operation, client's mtime/ctime is the same. Update the delegated mtime when directory delegations are present in rename.Fixes 6f9bda2337f8 ("NFS: Fix directory delegation verifier checks")Signed-off-by Olga Kornievskaia <[email protected]>
Reviewed-by Benjamin Coddington <[email protected]>
Ben