app/testpmd: count outer IP checksum errors
PATCH 1/1 app/testpmd: count outer IP checksum errors
Count and display outer IP checksum errors in the checksum forwarder.
Example forwarder stats output:
RX-packets: 158 RX-dropped: 0 RX-total: 158 Bad-ipcsum: 48 Bad-l4csum: 48 Bad-outer-l4csum: 6
Bad-outer-ipcsum: 40
TX-packets: 0 TX-dropped: 0 TX-total: 0
--- app/test-pmd/csumonly.c | 5 +++++ app/test-pmd/testpmd.c | 11 ++++++++++- app/test-pmd/testpmd.h | 2 ++ 3 files changed, 17 insertions(+), 1 deletion(-)
app/test-pmd/csumonly.c +5 -0
@@ -814,6 +814,7 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)uint32_t rx_bad_ip_csum;uint32_t rx_bad_l4_csum;uint32_t rx_bad_outer_l4_csum; +uint32_t rx_bad_outer_ip_csum;struct testpmd_offload_info info;uint16_t nb_segments =0 ;int ret;
@@ -833,6 +834,7 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) rx_bad_ip_csum =0 ; rx_bad_l4_csum =0 ; rx_bad_outer_l4_csum =0 ; + rx_bad_outer_ip_csum =0 ; gro_enable = gro_ports[fs->rx_port].enable; txp = &ports[fs->tx_port];
@@ -862,6 +864,8 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) rx_bad_l4_csum +=1 ;if (rx_ol_flags &PKT_RX_OUTER_L4_CKSUM_BAD ) rx_bad_outer_l4_csum +=1 ; +if (rx_ol_flags &PKT_RX_EIP_CKSUM_BAD ) + rx_bad_outer_ip_csum +=1 ;/* step 1: dissect packet, parsing optional vlan, ip4/ip6, vxlan * and inner headers */
@@ -1124,6 +1128,7 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) fs->rx_bad_ip_csum += rx_bad_ip_csum; fs->rx_bad_l4_csum += rx_bad_l4_csum; fs->rx_bad_outer_l4_csum += rx_bad_outer_l4_csum; + fs->rx_bad_outer_ip_csum += rx_bad_outer_ip_csum;inc_tx_burst_stats (fs, nb_tx);if (unlikely (nb_tx < nb_rx)) {
app/test-pmd/testpmd.c +10 -1
@@ -1805,6 +1805,8 @@ fwd_stream_stats_display(streamid_t stream_id)" Rx- bad outer L4 checksum: %-14" PRIu64"\n" , fs->rx_bad_ip_csum, fs->rx_bad_l4_csum, fs->rx_bad_outer_l4_csum); +printf (" RX- bad outer IP checksum: %-14" PRIu64"\n" , + fs->rx_bad_outer_ip_csum); }else {printf ("\n" ); }
@@ -1827,6 +1829,7 @@ fwd_stats_display(void)uint64_t rx_bad_ip_csum;uint64_t rx_bad_l4_csum;uint64_t rx_bad_outer_l4_csum; +uint64_t rx_bad_outer_ip_csum; } ports_stats[RTE_MAX_ETHPORTS ];uint64_t total_rx_dropped =0 ;uint64_t total_tx_dropped =0 ;
@@ -1859,6 +1862,8 @@ fwd_stats_display(void) ports_stats[fs->rx_port].rx_bad_l4_csum += fs->rx_bad_l4_csum; ports_stats[fs->rx_port].rx_bad_outer_l4_csum += fs->rx_bad_outer_l4_csum; + ports_stats[fs->rx_port].rx_bad_outer_ip_csum += + fs->rx_bad_outer_ip_csum;if (record_core_cycles) fwd_cycles += fs->core_cycles;
@@ -1890,13 +1895,16 @@ fwd_stats_display(void)"RX-total: %-" PRIu64"\n" , stats.ipackets, stats.imissed, stats.ipackets + stats.imissed); -if (cur_fwd_eng == &csum_fwd_engine) +if (cur_fwd_eng == &csum_fwd_engine) {printf (" Bad-ipcsum: %-14" PRIu64" Bad-l4csum: %-14" PRIu64"Bad-outer-l4csum: %-14" PRIu64"\n" , ports_stats[pt_id].rx_bad_ip_csum, ports_stats[pt_id].rx_bad_l4_csum, ports_stats[pt_id].rx_bad_outer_l4_csum); +printf (" Bad-outer-ipcsum: %-14" PRIu64"\n" , + ports_stats[pt_id].rx_bad_outer_ip_csum); + }if (stats.ierrors + stats.rx_nombuf >0 ) {printf (" RX-error: %-" PRIu64"\n" , stats.ierrors);printf (" RX-nombufs: %-14" PRIu64"\n" , stats.rx_nombuf);
@@ -1974,6 +1982,7 @@ fwd_stats_reset(void) fs->rx_bad_ip_csum =0 ; fs->rx_bad_l4_csum =0 ; fs->rx_bad_outer_l4_csum =0 ; + fs->rx_bad_outer_ip_csum =0 ;memset (&fs->rx_burst_stats,0 ,sizeof (fs->rx_burst_stats));memset (&fs->tx_burst_stats,0 ,sizeof (fs->tx_burst_stats));
app/test-pmd/testpmd.h +2 -0
@@ -137,6 +137,8 @@ struct fwd_stream {uint64_t rx_bad_l4_csum ;/**< received packets has bad l4 checksum */ uint64_t rx_bad_outer_l4_csum;/**< received packets has bad outer l4 checksum */ +uint64_t rx_bad_outer_ip_csum; +/**< received packets having bad outer ip checksum */ unsigned int gro_times;/**< GRO operation times */ uint64_t core_cycles;/**< used for RX and TX processing */ struct pkt_burst_stats rx_burst_stats;
Signature · 1 line
2.25.1
A message that is not in the archive (sent off-list or not yet received): MWHPR12MB16777B885F3E9A3B7803CD57A4B79@MWHPR12MB1677.namprd12.prod.outlook.com
Quoted 21 lines · Wisam Monther
Hi,
Quoted 19 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Lance Richardson
Sent: Saturday, January 30, 2021 12:36 AM
To: Wenzhuo Lu <[email protected]>; Xiaoyun Li <[email protected]>; Bernard Iremonger <[email protected]>
Cc: [email protected]; Ajit Kumar Khaparde <[email protected]>; Kalesh Anakkur Purayil <[email protected]>
Subject: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum errorsCount and display outer IP checksum errors in the checksum forwarder.
Example forwarder stats output:
RX-packets: 158 RX-dropped: 0 RX-total: 158 Bad-ipcsum: 48 Bad-l4csum: 48 Bad-outer-l4csum: 6Bad-outer-ipcsum: 40
TX-packets: 0 TX-dropped: 0 TX-total: 0
Quoted 7 lines
Quoted 4 lines
Signed-off-by Lance Richardson <[email protected]>Reviewed-by Ajit Kumar Khaparde <[email protected]>Reviewed-by Kalesh Anakkur Purayil <kalesh-Acked-by Wisam Jaddo <[email protected]>
Applied to dpdk-next-net/main, thanks.
'PKT_RX_EIP_CKSUM_BAD' is documented in mbuf header as:
"/** External IP header checksum error. */"
I think 'External' wording is confusing, as well as 'EIP' abbreviation, what do you think to create another macro alias to existing one, and mark the old one as deprecated?
Quoted 36 lines · Ferruh Yigit
Quoted 21 lines · Wisam Monther
Hi,
Quoted 19 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Lance Richardson
Sent: Saturday, January 30, 2021 12:36 AM
To: Wenzhuo Lu <[email protected]>; Xiaoyun Li <[email protected]>; Bernard Iremonger <[email protected]>
Cc: [email protected]; Ajit Kumar Khaparde <[email protected]>; Kalesh Anakkur Purayil <[email protected]>
Subject: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum errorsCount and display outer IP checksum errors in the checksum forwarder.
Example forwarder stats output:
RX-packets: 158 RX-dropped: 0 RX-total: 158 Bad-ipcsum: 48 Bad-l4csum: 48 Bad-outer-l4csum: 6Bad-outer-ipcsum: 40
TX-packets: 0 TX-dropped: 0 TX-total: 0Quoted 7 lines
Quoted 4 lines
Signed-off-by Lance Richardson <[email protected]>Reviewed-by Ajit Kumar Khaparde <[email protected]>Reviewed-by Kalesh Anakkur Purayil <kalesh-Acked-by Wisam Jaddo <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Applied to dpdk-next-net/main, thanks.
Quoted 6 lines
'
PKT_RX_EIP_CKSUM_BAD' is documented in mbuf header as:
"/** External IP header checksum error. */"I think 'External' wording is confusing, as well as 'EIP' abbreviation, what do you think to create another macro alias to existing one, and mark the old one as deprecated?
+1
Quoted 1 line
23/02/2021 19:39, Ajit Khaparde:
Quoted 37 lines · Ferruh Yigit
Quoted 36 lines · Wisam Monther
Quoted 21 lines
Hi,
Quoted 19 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Lance Richardson
Sent: Saturday, January 30, 2021 12:36 AM
To: Wenzhuo Lu <[email protected]>; Xiaoyun Li <[email protected]>; Bernard Iremonger <[email protected]>
Cc: [email protected]; Ajit Kumar Khaparde <[email protected]>; Kalesh Anakkur Purayil <[email protected]>
Subject: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum errorsCount and display outer IP checksum errors in the checksum forwarder.
Example forwarder stats output:
RX-packets: 158 RX-dropped: 0 RX-total: 158 Bad-ipcsum: 48 Bad-l4csum: 48 Bad-outer-l4csum: 6Bad-outer-ipcsum: 40
TX-packets: 0 TX-dropped: 0 TX-total: 0Quoted 7 lines
Quoted 4 lines
Signed-off-by Lance Richardson <[email protected]>Reviewed-by Ajit Kumar Khaparde <[email protected]>Reviewed-by Kalesh Anakkur Purayil <kalesh-Acked-by Wisam Jaddo <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Applied to dpdk-next-net/main, thanks.
Quoted 7 lines
Quoted 6 lines
'
PKT_RX_EIP_CKSUM_BAD' is documented in mbuf header as:
"/** External IP header checksum error. */"I think 'External' wording is confusing, as well as 'EIP' abbreviation, what do you think to create another macro alias to existing one, and mark the old one as deprecated?
+1
+1
Quoted 41 lines · Thomas Monjalon
23/02/2021 19:39, Ajit Khaparde:
Quoted 40 lines · Ferruh Yigit
Quoted 39 lines · Wisam Monther
Quoted 21 lines
Hi,
Quoted 19 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Lance Richardson
Sent: Saturday, January 30, 2021 12:36 AM
To: Wenzhuo Lu <[email protected]>; Xiaoyun Li <[email protected]>; Bernard Iremonger <[email protected]>
Cc: [email protected]; Ajit Kumar Khaparde <[email protected]>; Kalesh Anakkur Purayil <[email protected]>
Subject: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum errorsCount and display outer IP checksum errors in the checksum forwarder.
Example forwarder stats output:
RX-packets: 158 RX-dropped: 0 RX-total: 158 Bad-ipcsum: 48 Bad-l4csum: 48 Bad-outer-l4csum: 6Bad-outer-ipcsum: 40
TX-packets: 0 TX-dropped: 0 TX-total: 0Quoted 7 lines
Quoted 4 lines
Signed-off-by Lance Richardson <[email protected]>Reviewed-by Ajit Kumar Khaparde <[email protected]>Reviewed-by Kalesh Anakkur Purayil <kalesh-Acked-by Wisam Jaddo <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Applied to dpdk-next-net/main, thanks.
'
PKT_RX_EIP_CKSUM_BAD' is documented in mbuf header as:
"/** External IP header checksum error. */"
Quoted 7 lines
Quoted 4 lines
Quoted 3 lines
I think 'External' wording is confusing, as well as 'EIP' abbreviation, what do you think to create another macro alias to existing one, and mark the old one as deprecated?
+1
+1
Lance, can you spare some time to make the above mentioned patch?
Quoted 1 line
Lance, can you spare some time to make the above mentioned patch?
Sure. Are you looking for something like the changes below, or also including a search and replace of the deprecated macro name with the new one?
- /** External IP header checksum error. */
+/**
+ * Deprecated.
+ * This flag has been renamed, use PKT_RX_OUTER_IP_CKSUM_BAD instead.
+ */
+#define PKT_RX_EIP_CKSUM_BAD (1ULL << 5)
+
+/**
+ * This flag is set when the outermost IP header checksum is detected as
+ * wrong by the hardware.
+ */
#define PKT_RX_OUTER_IP_CKSUM_BAD (1ULL << 5)
/**
Quoted 5 lines · Lance Richardson
Quoted 1 line
Lance, can you spare some time to make the above mentioned patch?
Sure. Are you looking for something like the changes below, or also including a search and replace of the deprecated macro name with the new one?
Thank you.
Yes below looks good, and I think we should have the search & replace of the old macro usage, the latest upstream code shouldn't have the deprecated macro.
Quoted 15 lines
- /** External IP header checksum error. */
(quoted diff) +10
-0+/** + * Deprecated. + * This flag has been renamed, use PKT_RX_OUTER_IP_CKSUM_BAD instead. + */ +#define PKT_RX_EIP_CKSUM_BAD (1ULL << 5) + +/** + * This flag is set when the outermost IP header checksum is detected as + * wrong by the hardware. + */ #define PKT_RX_OUTER_IP_CKSUM_BAD (1ULL << 5) /**