Skip to contentSkip to conversation

devfreq: fix use after free in devfreq_remove_device

PATCH Applied 함명주 2 participants 2 messages Nov 10, 2011 – Nov 14, 2011

lore
Share & tools
lore

함명주

author Acked-by
#0 lore raw

Sender : Axel Lin<[email protected]> Date : 2011-11-10 16:28 (GMT+09:00)

Quoted 4 lines

In devfreq_remove_device, calling _remove_devfreq will also free devfreq. Don't dereference devfreq->governor->no_central_polling after _remove_devfreq.

Thank you for finding that out.

Quoted 28 lines

---
drivers/devfreq/devfreq.c | 8 ++++++--

1 files changed, 6 insertions(+), 2 deletions(-)
drivers/devfreq/devfreq.c +5 -1
index d065925..59d24e9 100644
@@ -418,10 +418,14 @@ out:
  */
 int devfreq_remove_device(struct devfreq *devfreq)
 {
+ bool central_polling;
+
 if (!devfreq)
 return -EINVAL;
 
- if (!devfreq->governor->no_central_polling) {
+ central_polling = !devfreq->governor->no_central_polling;
+
+ if (central_polling) {
 mutex_lock(&devfreq_list_lock);
 while (wait_remove_device == devfreq) {
 mutex_unlock(&devfreq_list_lock);
@@ -433,7 +437,7 @@ int devfreq_remove_device(struct devfreq *devfreq)
 mutex_lock(&devfreq->lock);

_remove_devfreq(devfreq, false); /* it unlocks devfreq->lock */

Quoted 7 lines

- if (!devfreq->governor->no_central_polling)
+ if (central_polling)
mutex_unlock(&devfreq_list_lock);

return 0;

Signature · 1 line
1.7.5.4

MyungJoo Ham (함명주)

Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: +82-10-6714-2858 / office: +82-31-279-8033�淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay����,j�f"톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&x�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�

#1 lore raw
Quoted 9 lines · 함명주

Sender : Axel Lin<[email protected]> Date : 2011-11-10 16:28 (GMT+09:00)

Quoted 4 lines

In devfreq_remove_device, calling _remove_devfreq will also free devfreq. Don't dereference devfreq->governor->no_central_polling after _remove_devfreq.

Thank you for finding that out.

Applied to linux-pm/pm-fixes.

Thanks,
Rafael

Quoted 40 lines
Quoted 28 lines

---
drivers/devfreq/devfreq.c | 8 ++++++--

1 files changed, 6 insertions(+), 2 deletions(-)
drivers/devfreq/devfreq.c +5 -1
index d065925..59d24e9 100644
@@ -418,10 +418,14 @@ out:
  */
 int devfreq_remove_device(struct devfreq *devfreq)
 {
+ bool central_polling;
+
 if (!devfreq)
 return -EINVAL;
 
- if (!devfreq->governor->no_central_polling) {
+ central_polling = !devfreq->governor->no_central_polling;
+
+ if (central_polling) {
 mutex_lock(&devfreq_list_lock);
 while (wait_remove_device == devfreq) {
 mutex_unlock(&devfreq_list_lock);
@@ -433,7 +437,7 @@ int devfreq_remove_device(struct devfreq *devfreq)
 mutex_lock(&devfreq->lock);

_remove_devfreq(devfreq, false); /* it unlocks devfreq->lock */

Quoted 5 lines

- if (!devfreq->governor->no_central_polling)
+ if (central_polling)
mutex_unlock(&devfreq_list_lock);

return 0;

MyungJoo Ham (함명주)

Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: +82-10-6714-2858 / office: +82-31-279-8033