ALC236 recording issue

PATCH Kailang 2 participants 5 messages Oct 5, 2021 – Oct 7, 2021 Sound

lore

Share & tools

lore

Kailang

author

2021-10-05 06:56 UTC #0 lore raw

Hi Takashi,

Attach patch will solve alc236 recording issue for HP platform.

Many Thanks.

BR,
Kailang

From 0a51c04b79f4baf7c368b9682aca211d67886cba Mon Sep 17 00:00:00 2001
From: Kailang Yang <[email protected]>
Date: Tue, 5 Oct 2021 14:35:14 +0800
Subject: [PATCH] ALSA: hda/realtek - ALC236 headset MIC recording issue

In power save mode, the recording voice from headset mic will 2s more delay. Add this patch will solve this issue.

Signed-off-by Kailang Yang <[email protected]>

Tested-by Kai-Heng Feng <[email protected]>

sound/pci/hda/patch_realtek.c +5 -2

index 0331fae5525e..12208bdfd2df 100644
@@ -526,6 +526,8 @@ static void alc_shutup_pins(struct hda_codec *codec)
 	struct alc_spec *spec = codec->spec;
 
 	switch (codec->core.vendor_id) {
+	case 0x10ec0236:
+	case 0x10ec0256:
 	case 0x10ec0283:
 	case 0x10ec0286:
 	case 0x10ec0288:

@@ -3529,8 +3531,9 @@ static void alc256_shutup(struct hda_codec *codec)
 	/* If disable 3k pulldown control for alc257, the Mic detection will not work correctly
 	 * when booting with headset plugged. So skip setting it for the codec alc257
 	 */
-	if (codec->core.vendor_id != 0x10ec0257)
-		alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
+	if (spec->codec_variant != ALC269_TYPE_ALC257 &&
+		spec->codec_variant != ALC269_TYPE_ALC256)
+			alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
 
 	if (!spec->no_shutup_pins)
 		snd_hda_codec_write(codec, hp_pin, 0,

Takashi Iwai

2021-10-05 08:12 UTC #1 lore raw

Quoted 9 lines · Kailang

Hi Takashi,
Attach patch will solve alc236 recording issue for HP platform.
Many Thanks.
BR,
Kailang

Applied now. Thanks.

Takashi

Kailang

author

2021-10-06 09:16 UTC #2 lore raw

Hi Takashi,

I couldn't find this apply record on git.kernel.org. HP guy want me to provide the patch URL.

BR,
Kailang

Quoted 24 lines

-----Original Message-----
From: Takashi Iwai <[email protected]>
Sent: Tuesday, October 5, 2021 4:12 PM
To: Kailang <[email protected]>
Cc: ([email protected]) <[email protected]>
Subject: Re: ALC236 recording issue
Quoted 9 lines · Kailang
Hi Takashi,
Attach patch will solve alc236 recording issue for HP platform.
Many Thanks.
BR,
Kailang
Applied now. Thanks.
Takashi
------Please consider the environment before printing this e-mail.

Takashi Iwai

2021-10-06 10:45 UTC #3 lore raw

Quoted 5 lines · Kailang

Hi Takashi,
I couldn't find this apply record on git.kernel.org. HP guy want me to provide the patch URL.

It wasn't pushed out properly, sorry. Now it's public, found in the commit 5aec98913095ed3b4424ed6c5fdeb6964e9734da.

Takashi

Quoted 29 lines

BR,
Kailang
Quoted 24 lines
-----Original Message-----
From: Takashi Iwai <[email protected]>
Sent: Tuesday, October 5, 2021 4:12 PM
To: Kailang <[email protected]>
Cc: ([email protected]) <[email protected]>
Subject: Re: ALC236 recording issue
Quoted 9 lines · Kailang
Hi Takashi,
Attach patch will solve alc236 recording issue for HP platform.
Many Thanks.
BR,
Kailang
Applied now. Thanks.
Takashi
------Please consider the environment before printing this e-mail.

Kailang

author

2021-10-07 06:17 UTC #4 lore raw

Many Thanks. ^^

Quoted 50 lines

-----Original Message-----
From: Takashi Iwai <[email protected]>
Sent: Wednesday, October 6, 2021 6:44 PM
To: Kailang <[email protected]>
Cc: ([email protected]) <[email protected]>
Subject: Re: ALC236 recording issue
Quoted 5 lines · Kailang
Hi Takashi,
I couldn't find this apply record on git.kernel.org. HP guy want me to provide the patch URL.
It wasn't pushed out properly, sorry. Now it's public, found in the commit 5aec98913095ed3b4424ed6c5fdeb6964e9734da.
Takashi
Quoted 29 lines
BR,
Kailang
Quoted 24 lines
-----Original Message-----
From: Takashi Iwai <[email protected]>
Sent: Tuesday, October 5, 2021 4:12 PM
To: Kailang <[email protected]>
Cc: ([email protected]) <[email protected]>
Subject: Re: ALC236 recording issue
Quoted 9 lines · Kailang
Hi Takashi,
Attach patch will solve alc236 recording issue for HP platform.
Many Thanks.
BR,
Kailang
Applied now. Thanks.
Takashi
------Please consider the environment before printing this e-mail.