Skip to contentSkip to conversation

gpudev: remove unnecessary rte_gpu_wmb

PATCH Applied [email protected] 2 participants 2 messages Nov 25, 2021 – Nov 26, 2021

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 gpudev: remove unnecessary rte_gpu_wmb

From: Elena Agostini <[email protected]>

Remove unnecessary rte_gpu_wmb from rte_gpu_comm_populate_list_pkts. It causes a performance degradation in case of NVIDIA GPU V100.

This change doesn't affect any functionality as the status resides in CPU registered memory.

Fixes c7ebd65c1372 ("gpudev: add communication list")
Signed-off-by Elena Agostini <[email protected]>
---
 lib/gpudev/gpudev.c | 1 -
 1 file changed, 1 deletion(-)
lib/gpudev/gpudev.c +0 -1
index 1d8200e71b..9ae36dbae9 100644
@@ -877,7 +877,6 @@ rte_gpu_comm_populate_list_pkts(struct rte_gpu_comm_list *comm_list_item,
 	RTE_GPU_VOLATILE(comm_list_item->num_pkts) = num_mbufs;
 	rte_gpu_wmb(comm_list_item->dev_id);
 	RTE_GPU_VOLATILE(comm_list_item->status) = RTE_GPU_COMM_LIST_READY;
-	rte_gpu_wmb(comm_list_item->dev_id);
 
 	return 0;
 }
Signature · 1 line
2.17.1
Applied
#1 lore raw

25/11/2021 23:40, [email protected]:

Quoted 11 lines

From: Elena Agostini <[email protected]>

Remove unnecessary rte_gpu_wmb from rte_gpu_comm_populate_list_pkts. It causes a performance degradation in case of NVIDIA GPU V100.

This change doesn't affect any functionality as the status resides in CPU registered memory.

Fixes c7ebd65c1372 ("gpudev: add communication list")
Signed-off-by Elena Agostini <[email protected]>

Applied, thanks.